On Fri, 2017-11-03 at 11:52 -0400, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin
>
> However I might recommend doing like
>
> const glsl_type *type_without_array = type->without_array();
> if (type_without_array->is_interface()) {
> for (... ; i < type_without_array->length; i++) {
> fiel
2017-11-03 19:02 GMT+08:00 Tapani Pälli :
> On 11/03/2017 12:30 PM, Chih-Wei Huang wrote:
>> 2017-11-03 15:47 GMT+08:00 Tapani Pälli :
>>> Hi Chih-Wei;
>>> This looks good to me. Only thing that causes a bit of headache is ...
>>> what
>>> is the difference between PRODUCT_OUT, OUT_DIR and TARGET_O
On Fri, Nov 03, 2017 at 04:17:31PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp_genX_exec.h | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/src/intel/blorp/blorp_genX_exec.h
> b/src/intel/blorp/blorp_genX_exec.h
> index 5389262..ccbfe51 100644
> --- a/
On Fri, Nov 03, 2017 at 04:17:33PM -0700, Jason Ekstrand wrote:
> This makes our MOCS settings significantly more flexible.
Patches 2 and 3:
Reviewed-by: Topi Pohjolainen
> ---
> src/intel/blorp/blorp.h | 7 +--
> src/intel/blorp/blorp_genX_exec.h | 16 ++
On Mon, 2017-11-06 at 10:31 +1100, Timothy Arceri wrote:
> Fixes: 379b24a40d3d "i965: make use of nir linking"
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103537
> ---
>
> Jason's fixes referenced in the bug report help a little,
> however there are still issues with the vector bac
From: Nicolai Hähnle
Cc: Jose Fonseca
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/Makefile.sources | 1 -
src/gallium/auxiliary/meson.build | 1 -
src/gallium/auxiliary/pipebuffer/pb_bufmgr_cache.c | 1 -
src/gallium/auxiliary/pipebuffer/pb_bufmgr_debu
From: Nicolai Hähnle
C11 threads were changed to use struct timespec instead of xtime, and
thrd_sleep got a second argument.
See http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1554.htm and
http://en.cppreference.com/w/c/thread/{thrd_sleep,cnd_timedwait,mtx_timedlock}
Note that cnd_timedwait i
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/Makefile.sources | 2 --
src/gallium/auxiliary/gallivm/lp_bld_init.c| 2 +-
src/gallium/auxiliary/hud/hud_cpu.c| 2 +-
src/gallium/auxiliary/hud/hud_cpufreq.c| 2 +-
src/g
From: Nicolai Hähnle
These bits are intended to be used by the ddebug hang detection and are
named in analogy to the Vulkan stage bits (and the corresponding Radeon
pipeline event).
Hang detection needs fences on the granularity of individual commands,
which nothing else really covers. The close
From: Nicolai Hähnle
v2:
- style fixes
- fix missing timeout handling in futex path
Reviewed-by: Marek Olšák (v1)
---
src/util/futex.h | 9 --
src/util/simple_mtx.h | 2 +-
src/util/u_queue.c| 82 ++-
src/util/u_queue.h| 54 +++
From: Nicolai Hähnle
Also document some subtleties of pipe_context::flush.
Reviewed-by: Marek Olšák
---
src/gallium/docs/source/context.rst | 9 +
src/gallium/include/pipe/p_context.h | 8 +++-
src/gallium/include/pipe/p_defines.h | 2 ++
3 files changed, 18 insertions(+), 1 delet
Hi all,
here's a re-spin of the series, v1 was here:
https://patchwork.freedesktop.org/series/32427, and the updated
patches in a larger context are here:
https://cgit.freedesktop.org/~nh/mesa/log/?h=fences-threads-ddebug
Changes in v2:
- patch 3: Windows build issues should be fixed now (tested
From: Nicolai Hähnle
The idea is to fix the following interleaving of operations
that can arise from deferred fences:
Thread 1 / Context 1 Thread 2 / Context 2
f = deferred flush
<--- application-side synchronization --->
From: Nicolai Hähnle
v2: remove the change to si_fence_server_sync, we'll handle that more
robustly
Reviewed-by: Marek Olšák (v1)
---
src/gallium/drivers/radeonsi/si_fence.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_fence.c
From: Nicolai Hähnle
This requires out-of-band creation of fences, and will be signaled to
the pipe_context::flush implementation by a special TC_FLUSH_ASYNC flag.
v2:
- remove an incorrect assertion
- handle fence_server_sync for unsubmitted fences by
relying on the improved cs_add_fence_depe
From: Nicolai Hähnle
v2: use uncached system memory for the fence, and use the CPU to
clear it so we never read garbage when checking the fence
---
src/gallium/drivers/radeonsi/si_fence.c | 89 -
1 file changed, 88 insertions(+), 1 deletion(-)
diff --git a/sr
From: Nicolai Hähnle
Queries should still get marked as flushed when flushes are executed
asynchronously in the driver thread.
To this end, the management of the unflushed_queries list is moved into
the driver thread.
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_threaded_context.
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 267 --
src/gallium/drivers/radeonsi/Makefile.sources | 1 +
src/gallium/drivers/radeonsi/meson.build | 1 +
src/gallium/drivers/radeonsi/si_fence.c | 304 +++
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_dump.h | 3 +++
src/gallium/auxiliary/util/u_dump_state.c | 10 ++
2 files changed, 13 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_dump.h
b/src/gallium/auxiliary/util/u_dump.h
index ff132
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_threaded_context.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_threaded_context.c
b/src/gallium/auxiliary/util/u_threaded_context.c
index 4908ea8a7ba..1f8a9d5088b 10
From: Nicolai Hähnle
For running post-draw operations inside the driver thread. ddebug will
use it.
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_threaded_context.c| 46 ++
.../auxiliary/util/u_threaded_context_calls.h | 1 +
src/gallium/include/pipe/p
From: Nicolai Hähnle
The driver uses (and must use) the flushed flag of queries as a hint that
it does not have to check for synchronization with currently queued up
commands. Deferred flushes do not actually flush queued up commands, so
we must not set the flushed flag for them.
Found by inspec
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_util.h | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/ddebug/dd_util.h
b/src/gallium/drivers/ddebug/dd_util.h
index 4e1a945c57d..cfc0fb0ccce
From: Nicolai Hähnle
Change format to %p while we're at it.
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_dump.h | 3 +++
src/gallium/auxiliary/util/u_dump_state.c | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_dump.h
b/
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_draw.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/src/gallium/drivers/ddebug/dd_draw.c
b/src/gallium/drivers/ddebug/dd_draw.c
index 99c9c929b2e..a856d0142a1 1006
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 10225353907..b193a0b4f21 100644
--- a/s
From: Nicolai Hähnle
This patch has multiple goals:
1. Off-load the writing of records in 'always' mode to another thread
for performance.
2. Allow using ddebug with threaded contexts. This really forces us to
move some of the "after_draw" handling into another thread.
3. Simplify the di
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_debug.c | 5 -
src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_draw.c | 8
src/gallium/drivers/ddebug/dd_pipe.h | 2 ++
2 files changed, 10 insertions(+)
diff --git a/src/gallium/drivers/ddebug/dd_draw.c
b/src/gallium/drivers/ddebug/dd_draw.c
index a856d0142a1..182d6
From: Nicolai Hähnle
Transfer commands can have associated GPU operations.
Enabled by passing GALLIUM_DDEBUG=transfers.
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_context.c | 65 -
src/gallium/drivers/ddebug/dd_draw.c| 234
src/gal
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_util.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/ddebug/dd_util.h
b/src/gallium/drivers/ddebug/dd_util.h
index cfc0fb0ccce..bdfb7cc9163 100644
--- a/src/gallium/driv
Bas, how is the backport for this patch going? The pre-release announce
is planned for this Wednesday so it'd great to have it latest by
tomorrow.
Thanks!
On Mon, 2017-10-30 at 18:55 +0200, Andres Gomez wrote:
> On Fri, 2017-10-27 at 19:50 +0200, Bas Nieuwenhuizen wrote:
> > On Fri, Oct 27, 2017
From: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/auxiliary/util/u_debug.c| 19 +++
src/gallium/auxiliary/util/u_dump.h | 3 ++
src/gallium/auxiliary/util/u_dump_defines.c | 53 +
src/gallium/auxiliary/util/u_dump_state.c | 2 +
Already implemented for Gallium drivers.
Useful for gbm_bo_(un)map.
Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM.
Signed-off-by: Julien Isorce
---
src/mesa/drivers/dri/i965/intel_screen.c | 47 ++--
1 file changed, 45 insertions(+), 2 deletion
Is this mean to work with asm turned on? It fails to build currently for me.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
We should use the result type of the OpSampledImage opcode, rather than
the type of the underlying image/samplers.
This resolves an issue when using separate images and shadow samplers
with glslang. Example:
layout (...) uniform samplerShadow s0;
layout (...) uniform texture2D res0;
.
On 03.11.2017 12:02, Thomas Hellstrom wrote:
It turned out that with recent changes that call into dri3 from glFinish(),
it appears like different thread end up waiting for X events simultaneously,
causing deadlocks since they steal events from eachoter and update the dri3
counters behind eachoth
For the series:
Reviewed-by: Nicolai Hähnle
On 04.11.2017 14:03, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_buffer_common.c | 20
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/src
On 06.11.2017 05:22, Ilia Mirkin wrote:
Radeonsi also sets this flag.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103544
Signed-off-by: Ilia Mirkin
---
This needs testing with the fbo-float-nan piglit that was recently added. Just
guessing that this is the right flag to set here.
The GL spec will soon be revised to clarify that a buffer binding for
a transform feedback buffer is only required if a variable is actually
defined to use the buffer binding point. Previously a declaration for
the default transform buffer would make it require a binding even if
nothing was declare
Both patches are,
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On Fri, 2017-11-03 at 15:31 -0700, Jason Ekstrand wrote:
> Before, we were trusting in the hardware to take the intersection
> of the viewport clip with the drawing rectangle. Unfortunately,
> 3DSTATE_DRAWING_RECTANGLE is fairly expe
Patch series is,
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On Thu, 2017-11-02 at 21:53 -0700, Jason Ekstrand wrote:
> Now that we're returning a sane type, we can drop the retyping to Q
> in
> nir_emit_load_const.
>
> Cc: Jose Maria Casanova Crespo
> ---
> src/intel/compiler/brw_fs_nir.cpp
On 11/06/2017 12:14 PM, Nicolai Hähnle wrote:
On 03.11.2017 12:02, Thomas Hellstrom wrote:
It turned out that with recent changes that call into dri3 from
glFinish(),
it appears like different thread end up waiting for X events
simultaneously,
causing deadlocks since they steal events from each
On Thu, 2017-11-02 at 15:54 -0700, Jason Ekstrand wrote:
> Register strides higher than 4 are uncommon but they can happen. For
> instance, if you have a 64-bit extract_u8 operation, we turn that
> into
> UB -> UQ MOV with a source stride of 8. Our previous calculation
> would
> try to generate
Hi,
On 04.11.2017 03:28, Christian Schmidbauer wrote:
On Thu, Nov 2, 2017 at 11:45 AM, Andres Rodriguez wrote:
[...]
In the autotools system we have today, we have --enable-debug, which
adds -g and -O0 if some -g* and -O* are not already in CFLAGS. It also
adds -DDEBUG which turns on lots of
This is what we do in the condition too, so it makes sense.
v2: Only compute without_array() once (Ilia).
Reviewed-by: Ilia Mirkin
---
src/compiler/glsl/link_varyings.cpp | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/compil
Regarding location aliasing requirements, the OpenGL spec says:
"Further, when location aliasing, the aliases sharing the location
must have the same underlying numerical type (floating-point or
integer)."
Khronos has further clarified that this also requires the underlying
types to have
Hi,
I haven't seen anyone mention -Og in this thread yet:
"-Og enables optimizations that do not interfere with debugging."
Was added in GCC 4.8.
Regards
//Ernst
2017-11-06 13:25 GMT+01:00 Eero Tamminen :
> Hi,
>
> On 04.11.2017 03:28, Christian Schmidbauer wrote:
>>>
>>> On Thu, Nov 2, 2017 at
Reviewed-by: Samuel Pitoiset
On 11/06/2017 07:58 AM, Dave Airlie wrote:
From: Dave Airlie
There's no point recalculating these the whole time on descriptor
emission, just store them at pipeline creation.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_cmd_buffer.c | 14 ++--
s
Fair enough.
Reviewed-by: Samuel Pitoiset
On 11/06/2017 03:18 AM, Dave Airlie wrote:
From: Dave Airlie
The function that calls us has just added the buffer to the
list already, no need to try and add it again.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_cmd_buffer.c | 2 --
1 fil
On 11/6/17 5:22 AM, Ilia Mirkin wrote:
This matches nvc0 behavior, tested with the fbo-float-nan piglit.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
b/s
On 11/06/2017 05:07 AM, Dave Airlie wrote:
From: Dave Airlie
The next patch will try and avoid calling the indirect function.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_cmd_buffer.c | 40 ++--
src/amd/vulkan/radv_descriptor_set.c | 6 +++---
Reviewed-by: Samuel Pitoiset
On 11/06/2017 05:07 AM, Dave Airlie wrote:
From: Dave Airlie
We can avoid adding the buffer in the non-local case, this will
avoid all the overhead of the indirect call.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_radeon_winsys.h | 4
sr
On Mon, Nov 6, 2017 at 6:21 AM, Nicolai Hähnle wrote:
> On 06.11.2017 05:22, Ilia Mirkin wrote:
>>
>> Radeonsi also sets this flag.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103544
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> This needs testing with the fbo-float-nan piglit that
On Mon, Nov 6, 2017 at 8:44 AM, Tobias Klausmann
wrote:
>
> On 11/6/17 5:22 AM, Ilia Mirkin wrote:
>>
>> This matches nvc0 behavior, tested with the fbo-float-nan piglit.
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>> src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 +
>> 1 file changed, 5 i
On 11/06/2017 06:37 AM, Dave Airlie wrote:
From: Dave Airlie
This should reduce some pointless loops.
v2: fix missing check which causes crashes with compute shaders
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_cmd_buffer.c | 53 +++-
src/amd/vu
On Mon, Nov 6, 2017 at 8:48 AM, Ilia Mirkin wrote:
> On Mon, Nov 6, 2017 at 6:21 AM, Nicolai Hähnle wrote:
>> On 06.11.2017 05:22, Ilia Mirkin wrote:
>>>
>>> Radeonsi also sets this flag.
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103544
>>> Signed-off-by: Ilia Mirkin
>>> ---
On Thu, 2017-10-19 at 06:55 -0700, Jason Ekstrand wrote:
> On October 18, 2017 11:44:12 PM Samuel Iglesias Gonsálvez
> wrote:
>
> > On Wednesday, October 18, 2017 8:11:01 AM CEST Jason Ekstrand
> > wrote:
> > > On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez
> > >
> > > wrote:
> > >
So are we saying that you can't have explicit components on a bindless
sampler/image varying, which are defined as 64-bit integer types?
On Mon, Nov 6, 2017 at 7:22 AM, Iago Toral Quiroga wrote:
> Regarding location aliasing requirements, the OpenGL spec says:
>
> "Further, when location aliasi
Acked-by: Marek Olšák
Marek
On Fri, Nov 3, 2017 at 9:09 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Fences are now 4 bytes instead of 96 bytes (on my 64-bit system).
>
> Signaling a fence is a single atomic operation in the fast case plus a
> syscall in the slow case.
>
> Testing if a
Fixes:
make[2]: Leaving directory '/home/local/mesa/mesa-17.4.0-devel/_build/sub/src'
make[2]: *** No rule to make target '../../../src/git_sha1.h.in', needed by
'git_sha1.h'. Stop.
Makefile:660: recipe for target 'all-recursive' failed
Signed-off-by: Juan A. Suarez Romero
---
src/Makefile.am
2017-11-01 18:19 GMT+01:00 Wladimir J. van der Laan :
> Add ASTC texture support for hardware that supports this
> (currently only GC3000 on i.MX6qp is known to have this).
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_em
On Thu 02 Nov 2017, Eric Engestrom wrote:
> On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote:
> > On Wed 01 Nov 2017, Dylan Baker wrote:
> > > I'm not dead set on debug as the default buildtype, it's what we have ATM
> > > though. I asked around here and the feeling was that builtype debu
On Thu 02 Nov 2017, Dylan Baker wrote:
> Quoting Matt Turner (2017-11-02 10:06:43)
> > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote:
> > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's
> > > debugging information useful for bug reports, but performance should be
>
On Mon, Nov 6, 2017 at 2:37 AM, Alex Smith
wrote:
> We should use the result type of the OpSampledImage opcode, rather than
> the type of the underlying image/samplers.
>
> This resolves an issue when using separate images and shadow samplers
> with glslang. Example:
>
> layout (...) uniform
On Mon, Nov 6, 2017 at 12:56 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Nov 03, 2017 at 04:17:31PM -0700, Jason Ekstrand wrote:
> > ---
> > src/intel/blorp/blorp_genX_exec.h | 6 +-
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/src/intel/blo
On Monday, 2017-11-06 16:44:40 +0100, Juan A. Suarez Romero wrote:
> Fixes:
>
> make[2]: Leaving directory '/home/local/mesa/mesa-17.4.0-devel/_build/sub/src'
> make[2]: *** No rule to make target '../../../src/git_sha1.h.in', needed by
> 'git_sha1.h'. Stop.
> Makefile:660: recipe for target 'al
Reviewed-by: Marek Olšák
Marek
On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> v2:
> - style fixes
> - fix missing timeout handling in futex path
>
> Reviewed-by: Marek Olšák (v1)
> ---
> src/util/futex.h | 9 --
> src/util/simple_mtx.h | 2 +-
>
Didn't danvet give you a RB'd here? As well:
Tested-by: Lyude Paul
On Fri, 2017-11-03 at 16:17 -0700, Jason Ekstrand wrote:
> We were already using PTE for all render targets in case one happened to
> get scanned out. However, this still wasn't 100% correct because there
> are still possibly ca
This patch series was intended to:
a) de-duplicate code across various platforms.
b) do preparatory work for platform_tizen.
There was some confusion[1] on how we want to move forward with
platform_tizen. Until we can figure that out, I suggest we drop patches
that move stuff out of platform_and
On Monday, 2017-11-06 08:07:21 -0800, Chad Versace wrote:
> On Thu 02 Nov 2017, Dylan Baker wrote:
> > Quoting Matt Turner (2017-11-02 10:06:43)
> > > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote:
> > > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's
> > > > debugg
[PATCH 1/2] Remove libtxc-dxtn* recommends for S3TC
[PATCH 2/2] Rename --enable-gallium-llvm to --enable-llvm
Fabio
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Cc: Dylan Baker
Cc: Chad Versace
Cc: Emil Velikov
Cc: Ilia Mirkin
Cc: Andres Rodriguez
Cc: Michel Dänzer
Cc: Matt Turner
Cc: Christian Schmidbauer
Cc: Eero Tamminen
Cc: Ernst Sjöstrand
Signed-off-by: Eric Engestrom
---
Sorry for the massive Cc-list, I wanted to include everyone who took
Cc: Dylan Baker
Cc: Chad Versace
Signed-off-by: Eric Engestrom
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 6e9a799704ecf606b689..78d51b9b9b580fdc4058 100644
--- a/meson.build
+++ b/meson.build
@@ -350,7 +350,7 @@ if cc.get_
From: Michel Dänzer
This matches the standard assert.h header.
Signed-off-by: Michel Dänzer
---
src/gallium/auxiliary/util/u_debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_debug.h
b/src/gallium/auxiliary/util/u_debug.h
index 63940b7225
Acked-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon 06 Nov 2017, Eric Engestrom wrote:
> On Monday, 2017-11-06 08:07:21 -0800, Chad Versace wrote:
> > On Thu 02 Nov 2017, Dylan Baker wrote:
> > > Quoting Matt Turner (2017-11-02 10:06:43)
> > > > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer
> > > > wrote:
> > > > > FWIW, my vote is for debu
On Monday, 2017-11-06 18:39:54 +0100, Michel Dänzer wrote:
> From: Michel Dänzer
>
> This matches the standard assert.h header.
>
> Signed-off-by: Michel Dänzer
Reviewed-by: Eric Engestrom
Guess we should audit every DEBUG in the codebase to make sure the right
one is used.
> ---
> src/gal
For both patches,
Reviewed-by: Chad Versace
Tested-by: Chad Versace
On Mon 06 Nov 2017, Eric Engestrom wrote:
> Cc: Dylan Baker
> Cc: Chad Versace
> Cc: Emil Velikov
> Cc: Ilia Mirkin
> Cc: Andres Rodriguez
> Cc: Michel Dänzer
> Cc: Matt Turner
> Cc: Christian Schmidbauer
> Cc: Eero Tam
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2017-11-06 09:19:34)
> Cc: Dylan Baker
> Cc: Chad Versace
> Cc: Emil Velikov
> Cc: Ilia Mirkin
> Cc: Andres Rodriguez
> Cc: Michel Dänzer
> Cc: Matt Turner
> Cc: Christian Schmidbauer
> Cc: Eero Tamminen
> Cc: Ernst Sjöstrand
> Signed-off
On Monday, 2017-11-06 17:19:35 +, Eric Engestrom wrote:
> Cc: Dylan Baker
> Cc: Chad Versace
> Signed-off-by: Eric Engestrom
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 6e9a799704ecf606b689..78d51b9b9b580fdc
To clarify, with the one hunk in patch 2 moved to patch 1, both patches are:
Reviewed-by: Dylan Baker
Quoting Dylan Baker (2017-11-02 16:51:18)
> I'm also not sure that it matters, but I think consistency with autotools is
> important,
> Reviewed-by: Dylan Baker
>
> Quoting Eric Engestrom (2017
On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> The idea is to fix the following interleaving of operations
> that can arise from deferred fences:
>
> Thread 1 / Context 1 Thread 2 / Context 2
>
> f
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Quoting Eric Engestrom (2017-11-03 16:44:11)
> On Friday, 2017-11-03 18:09:01 +, Dylan Baker wrote:
> > This allows drivers to be set by OS/arch in a sane manner.
> >
> > v2: - set _drivers to a list of drivers instead of manually assigning
> > each with_*
> > v3: - Use "auto" instead of
On Mon, Nov 6, 2017 at 4:10 AM, Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:
>
> On Thu, 2017-11-02 at 15:54 -0700, Jason Ekstrand wrote:
> > Register strides higher than 4 are uncommon but they can happen. For
> > instance, if you have a 64-bit extract_u8 operation, we turn that
> >
For both patches:
Acked-by: Andres Rodriguez
On Mon, Nov 6, 2017 at 1:06 PM, Chad Versace wrote:
> For both patches,
> Reviewed-by: Chad Versace
> Tested-by: Chad Versace
>
>
> On Mon 06 Nov 2017, Eric Engestrom wrote:
>> Cc: Dylan Baker
>> Cc: Chad Versace
>> Cc: Emil Velikov
>> Cc: Ilia
Reviewed-by: Bas Nieuwenhuizen
On Sat, Nov 4, 2017 at 9:15 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> It appears the latest dota2 vulkan uses this,
> and we get a hang in VR mode without it.
>
> v2: remove finishme I left in after finishing.
>
> Cc: "17.2 17.3"
> Signed-off-by: Dave Airlie
On 6 November 2017 at 15:44, Juan A. Suarez Romero wrote:
> Fixes:
>
> make[2]: Leaving directory '/home/local/mesa/mesa-17.4.0-devel/_build/sub/src'
> make[2]: *** No rule to make target '../../../src/git_sha1.h.in', needed by
> 'git_sha1.h'. Stop.
> Makefile:660: recipe for target 'all-recursi
Wrong list, I think.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 6 November 2017 at 17:19, Eric Engestrom wrote:
> Cc: Dylan Baker
> Cc: Chad Versace
> Cc: Emil Velikov
> Cc: Ilia Mirkin
> Cc: Andres Rodriguez
> Cc: Michel Dänzer
> Cc: Matt Turner
> Cc: Christian Schmidbauer
> Cc: Eero Tamminen
> Cc: Ernst Sjöstrand
> Signed-off-by: Eric Engestrom
Quoting Aaron Watry (2017-11-03 19:51:49)
> On an unrelated note, I also had to remove the LLVM minimum version
> check temporarily, otherwise I get llvm version parsing errors from
> 6.0.0svn at the following line:
>
> dep_llvm = dependency(
> 'llvm', version : '>= 3.9.0', required : with_amd_
Jason, I tested this series against the khronos-internal vk-gl-cts and
found an assertion failure in src/compiler/spirv. Any thoughts?
I haven't debugged yet because I don't grok these parts of Mesa.
vk-gl-cts
commit a24448cdd72ffdbd8f7f571886625b8a53100979
mesa
refs/tags/chadv/test/an
2017-11-02 16:08 GMT+01:00 Wladimir J. van der Laan :
> HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't
> render to them anyway. So use the tightest possible packing. This
> avoids bugs with non-power-of-two block sizes.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewe
The patch doesn't help at all, but looks like a sensible thing to do anyway.
Reviewed-by: Roland Scheidegger
Am 06.11.2017 um 05:22 schrieb Ilia Mirkin:
> Radeonsi also sets this flag.
>
> Bugzilla:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fi
Reviewed-by: Marek Olšák
Marek
On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This requires out-of-band creation of fences, and will be signaled to
> the pipe_context::flush implementation by a special TC_FLUSH_ASYNC flag.
>
> v2:
> - remove an incorrect asse
Reviewed-by: Marek Olšák
Marek
On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> v2: remove the change to si_fence_server_sync, we'll handle that more
> robustly
>
> Reviewed-by: Marek Olšák (v1)
> ---
> src/gallium/drivers/radeonsi/si_fence.c | 22 +++
Use the proper enum types for various variables. Makes life in gdb
a little nicer.
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 ---
src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 6 +++---
src/mesa/state_tracker/st_mesa_to_tgsi.c | 6 +++---
src/mesa/state_tracker/st_
Remove trailing whitespace, fix indentation, wrap lines to 78 columns, etc.
---
src/mesa/state_tracker/st_mesa_to_tgsi.c | 336 ---
1 file changed, 169 insertions(+), 167 deletions(-)
diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c
b/src/mesa/state_tracker/st_me
Declare glsl_type::sampled_type as glsl_base_type as we do for the
base_type field. And make base_type a bitfield to save a few bytes.
Update glsl_type constructor to take glsl_base_type intead of unsigned
and pass GLSL_TYPE_VOID instead of zero.
No Piglit regressions with llvmpipe.
---
src/com
1 - 100 of 164 matches
Mail list logo
