On Mon, Nov 6, 2017 at 8:44 AM, Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> wrote: > > On 11/6/17 5:22 AM, Ilia Mirkin wrote: >> >> This matches nvc0 behavior, tested with the fbo-float-nan piglit. >> >> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> >> --- >> src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c >> b/src/gallium/drivers/nouveau/nv50/nv50_screen.c >> index 5ee5a26b652..47c70d74e94 100644 >> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c >> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c >> @@ -771,6 +771,11 @@ nv50_screen_init_hwctx(struct nv50_screen *screen) >> PUSH_DATA (push, 0); >> } >> + BEGIN_NV04(push, NV50_3D(UNK0FDC), 1); >> + PUSH_DATA (push, 1); >> + BEGIN_NV04(push, NV50_3D(UNK19C0), 1); >> + PUSH_DATA (push, 1); >> + >> PUSH_KICK (push); >> } >> > > > Hi, > > if you have gained knowledge about these regs and their functionality, > renaming them would be good (or are they already renamed in envytools and > not synced yet?).
Not really. Just copying blob. Could rename them to BLEND_UNK0FDC, but ... meh. > A bit off topic question is: Where does nvc0 set those > regs? I have a hard time finding it. :O nvc0_magic_3d_init: BEGIN_NVC0(push, SUBC_3D(0x0fdc), 1); PUSH_DATA (push, 1); BEGIN_NVC0(push, SUBC_3D(0x19c0), 1); PUSH_DATA (push, 1); > > Anyway, the patch looks ok and you can add my R-b with or without renaming > the regs: > > Reviewed-by: Tobias Klausmann<tobias.johannes.klausm...@mni.thm.de> > Thanks! _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
