Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:29 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 12:15 AM, Iago Toral > wrote: > > On Fri, 2017-10-27 at 12:21 -0700, Jason Ekstrand wrote: > > > On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral > > > wrote: > > > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand w

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:34 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 12:33 AM, Iago Toral > wrote: > > On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral > > > wrote: > > > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wr

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:39 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 12:43 AM, Iago Toral > wrote: > > On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral > > > wrote: > > > > This sounds good to me, but I guess it is not reall

Re: [Mesa-dev] [PATCH v3 39/48] nir: Add a new subgroups lowering pass

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:45 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 4:38 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > > > > This commit pulls nir_lower_read_invocations_to_scalar along with > > > > > most > > > > > of the guts of nir_op

[Mesa-dev] [PATCH 2/2] meson: prefer 'auto', 'true', 'false'

2017-10-31 Thread Erik Faye-Lund
This way users don't have to care if these options are boolean or not, as they take the same values (apart from 'auto'). Signed-off-by: Erik Faye-Lund --- I'm not quite sure about this patch. Yes, it cleans up the semantics, but at the same time, it breaks backwards compatibility for some of the

[Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
If we don't want to use these deps, there's no good reason to search for them in the first place. This should shave a bit of time for the initial build. Signed-off-by: Erik Faye-Lund --- meson.build | 20 ++-- meson_options.txt | 14 -- 2 files changed, 22 inser

Re: [Mesa-dev] [PATCH] radv: bail out when binding the same vertex buffers

2017-10-31 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Oct 30, 2017 at 7:37 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/sr

Re: [Mesa-dev] [PATCH] radv: bail out when binding the same index buffer

2017-10-31 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Since we store buffer and offset, do we want to calculate index_va at emit time, so we don't have to store it? On Mon, Oct 30, 2017 at 5:12 PM, Samuel Pitoiset wrote: > DOW3 appears to hit this path. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH] radv: bail out when binding the same index buffer

2017-10-31 Thread Samuel Pitoiset
On 10/31/2017 09:37 AM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen Since we store buffer and offset, do we want to calculate index_va at emit time, so we don't have to store it? I wasn't sure myself because the draw code path is really the hot spot. Though, this could save 12

[Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

2017-10-31 Thread Kenneth Graunke
For the render pipeline, the upload_sampler_state_table atom emits 3DSTATE_BINDING_TABLE_POINTERS_XS. It tries to avoid this for compute: if (GEN_GEN >= 7 && stage_state->stage != MESA_SHADER_COMPUTE) { /* Emit a 3DSTATE_SAMPLER_STATE_POINTERS_XS packet. */ genX(emit_sampler_state_

[Mesa-dev] [PATCH] radv: use the optimal packets order for dispatch calls

2017-10-31 Thread Samuel Pitoiset
This should reduce the time where compute units are idle, mainly for meta operations because they use a bunch of compute shaders. This seems to have a really minor positive effect for Talos, at least. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 61 +

[Mesa-dev] [PATCH] radv: make radv_bind_descriptor_set() static

2017-10-31 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- src/amd/vulkan/radv_private.h| 3 --- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 4b38ece10f..27b7f78a89 100644 --- a/sr

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-31 Thread Eric Engestrom
On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: > The u_format_other.c users sqrtf, which on some systems require > a math-library. So let's make sure we link with it. > > Signed-off-by: Erik Faye-Lund Reviewed-by: Eric Engestrom Do you have push rights? > --- > > I noticed this

Re: [Mesa-dev] [PATCH] meson: Use true and false instead of yes and no for tristate options

2017-10-31 Thread Eric Engestrom
On Monday, 2017-10-30 10:31:07 -0700, Dylan Baker wrote: > This allows a user to not care whether they're setting a tristate or a > boolean option, which is a nice user facing feature, and something I've > personally run into. > > Suggested-by: Adam Jackson > Signed-off-by: Dylan Baker Reviewed

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Eric Engestrom
On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: > If we don't want to use these deps, there's no good reason to search > for them in the first place. This should shave a bit of time for the > initial build. > > Signed-off-by: Erik Faye-Lund > --- > meson.build | 20 +++

Re: [Mesa-dev] [PATCH 2/2] meson: set visibility flags on gbm

2017-10-31 Thread Eric Engestrom
On Monday, 2017-10-30 11:32:34 -0700, Dylan Baker wrote: > This is done in autotools, and is an oversight in the meson build. > > Signed-off-by: Dylan Baker > --- > src/gbm/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gbm/meson.build b/src/gbm/meson.b

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom wrote: > On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >> The u_format_other.c users sqrtf, which on some systems require >> a math-library. So let's make sure we link with it. >> >> Signed-off-by: Erik Faye-Lund > > Reviewed-by: Eric

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 11:33 AM, Erik Faye-Lund wrote: > On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom > wrote: >> On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >>> The u_format_other.c users sqrtf, which on some systems require >>> a math-library. So let's make sure we link wit

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom wrote: > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: >> If we don't want to use these deps, there's no good reason to search >> for them in the first place. This should shave a bit of time for the >> initial build. >> >> Signed-off-

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Eric Engestrom
On Tuesday, 2017-10-31 11:37:25 +0100, Erik Faye-Lund wrote: > On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom > wrote: > > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: > >> If we don't want to use these deps, there's no good reason to search > >> for them in the first place. This

[Mesa-dev] [PATCH mesa 00/11] fix tests

2017-10-31 Thread Eric Engestrom
a few issues being fixed here: - symbol checks would silently pass when the lib is missing - meson was failing to pass the lib to the scripts - the egl symbol check only works on the non-libglvnd lib (we probably want to have one for libglvnd, didn't do it in this series though) es2-ABI-check an

[Mesa-dev] [PATCH mesa 04/11] gles1: fail symbol check if lib is missing

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es1api/ABI-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index 223658b32e08edf77558..25970bc41419eac5b544 100755 --- a/src/mapi/es1api/ABI-check +++ b/src/mapi/es

[Mesa-dev] [PATCH mesa 01/11] egl: fail symbol check if lib is missing

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/egl/egl-symbols-check b/src/egl/egl-symbols-check index 4c5232cb6c031397b423..ae867d04bca91f22b070 100755 --- a/src/egl/egl-symbols-check +++ b/src/egl/egl

[Mesa-dev] [PATCH mesa 05/11] gles2: fail symbol check if lib is missing

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es2api/ABI-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check index 5c9e82662461ab367ef3..2c2764e7fb94fb9494d2 100755 --- a/src/mapi/es2api/ABI-check +++ b/src/mapi/es

[Mesa-dev] [PATCH mesa 02/11] wayland-egl: fail symbol check if lib is missing

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/wayland/wayland-egl/wayland-egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/wayland-egl-symbols-check b/src/egl/wayland/wayland-egl/wayland-egl-symbols-check index e7105ea5793784

[Mesa-dev] [PATCH mesa 03/11] gbm: fail symbol check if lib is missing

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/gbm-symbols-check | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-check index 2444131e990228513d8f..cf57a08d5728cfff480c 100755 --- a/src/gbm/gbm-symbols-check +++ b/src/gbm/g

[Mesa-dev] [PATCH mesa 06/11] meson: pass correct env/args to egl tests

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/meson.build | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/egl/meson.build b/src/egl/meson.build index cc51671f9d8f24708405..254e7e7a1778a5abc654 100644 --- a/src/egl/meson.build +++ b/src/egl/meson.build @@ -183,6 +183

[Mesa-dev] [PATCH mesa 07/11] automake+meson: don't run egl symbol check on libglvnd lib

2017-10-31 Thread Eric Engestrom
We might want to add a symbol check for the glvnd variant though. Signed-off-by: Eric Engestrom --- src/egl/Makefile.am | 9 +++-- src/egl/meson.build | 12 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am index eeb745f97

[Mesa-dev] [PATCH mesa 08/11] meson: pass correct args to wayland-egl symbol test

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/wayland/wayland-egl/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/meson.build b/src/egl/wayland/wayland-egl/meson.build index f380e96ee32d7f89e646..14c78a3ecbc37308e45b 100644 --- a/src/eg

[Mesa-dev] [PATCH mesa 11/11] meson: pass correct args to gles2 ABI test

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es2api/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mapi/es2api/meson.build b/src/mapi/es2api/meson.build index f4922d755adee30c0efb..3d6888a4b8f789cf355a 100644 --- a/src/mapi/es2api/meson.build +++ b/src/mapi/

[Mesa-dev] [PATCH mesa 09/11] meson: pass correct args to gbm symbol test

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gbm/meson.build b/src/gbm/meson.build index 1bb3c94c38788b2e42fc..fa40f00374e0039631e1 100644 --- a/src/gbm/meson.build +++ b/src/gbm/meson.build @@ -70,6 +70,8 @@ p

[Mesa-dev] [PATCH mesa 10/11] meson: pass correct args to gles1 ABI test

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es1api/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mapi/es1api/meson.build b/src/mapi/es1api/meson.build index 57cfb1e8d8580fcae2a2..84a21cd6b7697d687328 100644 --- a/src/mapi/es1api/meson.build +++ b/src/mapi/

Re: [Mesa-dev] [PATCH v3 33/34] dri drivers: Always add the sha1 build-id

2017-10-31 Thread Emil Velikov
On 22 October 2017 at 21:01, Jordan Justen wrote: > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/Makefile.am | 1 + > src/mesa/drivers/dri/meson.build | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/Makefile.am > b/

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-10-31 Thread Emil Velikov
Hi Lionel, On 30 October 2017 at 16:58, Lionel Landwerlin wrote: > create mode 100644 src/intel/tools/aubinator_imgui_widgets.cpp > create mode 100644 src/intel/tools/aubinator_imgui_widgets.h > create mode 100644 src/intel/tools/aubinator_ui.cpp > create mode 100644 src/intel/tools/imgui/LI

[Mesa-dev] [Bug 103526] Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb

2017-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103526 Bug ID: 103526 Summary: Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb Product: Mesa

[Mesa-dev] [Bug 103526] Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb

2017-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103526 --- Comment #1 from Eric Engestrom --- Thank you for running tests on PowerPC, we don't have many people with the right hardware to do that :) big-/little-endian issues unfortunately come up every now and then because of this lack of testing. (

Re: [Mesa-dev] [PATCH v3 32/34] disk_cache: Fix issue reading GLSL metadata

2017-10-31 Thread Grazvydas Ignotas
On Tue, Oct 31, 2017 at 12:54 AM, Kenneth Graunke wrote: > On Sunday, October 22, 2017 1:01:40 PM PDT Jordan Justen wrote: >> This would cause the read of the metadata content to fail, which would >> prevent the linking from being skipped. >> >> Seen on Rocket League with i965 shader cache. >> >>

Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-31 Thread Jason Ekstrand
On Tue, Oct 31, 2017 at 12:01 AM, Iago Toral wrote: > On Mon, 2017-10-30 at 11:29 -0700, Jason Ekstrand wrote: > > On Mon, Oct 30, 2017 at 12:15 AM, Iago Toral wrote: > > On Fri, 2017-10-27 at 12:21 -0700, Jason Ekstrand wrote: > > On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral wrote: > > On Wed,

Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-31 Thread Iago Toral
On Tue, 2017-10-31 at 07:20 -0700, Jason Ekstrand wrote: > On Tue, Oct 31, 2017 at 12:01 AM, Iago Toral > wrote: > > On Mon, 2017-10-30 at 11:29 -0700, Jason Ekstrand wrote: > > > On Mon, Oct 30, 2017 at 12:15 AM, Iago Toral > > > wrote: > > > > On Fri, 2017-10-27 at 12:21 -0700, Jason Ekstrand w

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 12:04 PM, Eric Engestrom wrote: > On Tuesday, 2017-10-31 11:37:25 +0100, Erik Faye-Lund wrote: >> On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom >> wrote: >> > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: >> >> If we don't want to use these deps, there's

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-10-31 Thread Lionel Landwerlin
On 31/10/17 12:59, Emil Velikov wrote: Hi Lionel, On 30 October 2017 at 16:58, Lionel Landwerlin wrote: create mode 100644 src/intel/tools/aubinator_imgui_widgets.cpp create mode 100644 src/intel/tools/aubinator_imgui_widgets.h create mode 100644 src/intel/tools/aubinator_ui.cpp creat

[Mesa-dev] [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-10-31 Thread Rob Herring
EGL, gralloc, and HWC must all have a common definition of fd's and int's in native_handle_t to share the fd and width, height, format, etc. of a dmabuf. Move the definition into HWC so we aren't dependent on a specific gralloc implementation and so we don't have to create an importer just for dif

Re: [Mesa-dev] [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-10-31 Thread Rob Herring
Sorry, wrong list... On Tue, Oct 31, 2017 at 9:58 AM, Rob Herring wrote: > EGL, gralloc, and HWC must all have a common definition of fd's and int's > in native_handle_t to share the fd and width, height, format, etc. of a > dmabuf. > > Move the definition into HWC so we aren't dependent on a spe

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-10-31 Thread Emil Velikov
On 31 October 2017 at 14:42, Lionel Landwerlin wrote: > On 31/10/17 12:59, Emil Velikov wrote: >> >> Hi Lionel, >> >> On 30 October 2017 at 16:58, Lionel Landwerlin >> wrote: >> >>> create mode 100644 src/intel/tools/aubinator_imgui_widgets.cpp >>> create mode 100644 src/intel/tools/aubinator

[Mesa-dev] [Bug 103526] Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb

2017-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103526 --- Comment #2 from Emil Velikov --- As Eric mentioned - Mesa 13.0.x is EOL. We had a number of PPC fixes since then, so I'd encourage you to try 17.2.3/17.2.4 or master. -- You are receiving this mail because: You are the QA Contact for the b

Re: [Mesa-dev] [PATCH 12/15] ac: add support for SPV_AMD_shader_ballot

2017-10-31 Thread Connor Abbott
On Tue, Oct 31, 2017 at 2:08 AM, Dave Airlie wrote: >> +LLVMValueRef >> +ac_build_subgroup_inclusive_scan(struct ac_llvm_context *ctx, >> +LLVMValueRef src, >> +ac_reduce_op reduce, >> +LLVMValueRef ide

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Samuel Pitoiset
On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Michel Dänzer
On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: > Signed-off-by: Andrey Grodzovsky [...] > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > index 8f43e93..1155492 100644 > --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > +++ b/src/gallium/wi

[Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8 src/gallium/winsys/amdgpu/drm/amdgpu_cs.

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Marek Olšák
I addressed the feedback and pushed the patch. Marek On Tue, Oct 31, 2017 at 4:50 PM, Michel Dänzer wrote: > On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: >> Signed-off-by: Andrey Grodzovsky > > [...] > >> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c >> b/src/gallium/winsys/amdgpu/d

Re: [Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

2017-10-31 Thread Jason Ekstrand
I think I'd prefer the commit message to say something like: i965: properly initialize brw->cs.base.stage to MESA_SHADER_COMPUTE and then keep all the VS stuff in the body of the message. That's a better description of the change even though the fallout is rather whacky. With that, Reviewed-by

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

2017-10-31 Thread Marek Olšák
On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_fence.c | 83 > - > 1 file changed, 82 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_fence.c > b/src/gallium/d

[Mesa-dev] [PATCH mesa] meson: bump libdrm version required by amdgpu

2017-10-31 Thread Eric Engestrom
Fixes: f03b7c9ad92c1656a221 "winsys/amdgpu: Add R600_DEBUG flag to reserve VMID per ctx." Cc: Andrey Grodzovsky Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d6a2d83b5

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Andrey Grodzovsky
On 2017-10-31 11:50 AM, Samuel Pitoiset wrote: On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h |

[Mesa-dev] [Bug 103526] Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb

2017-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103526 --- Comment #3 from spbroth...@inbox.ru --- (In reply to Eric Engestrom from comment #1) > Thank you for running tests on PowerPC, we don't have many people with the > right hardware to do that :) > big-/little-endian issues unfortunately come u

Re: [Mesa-dev] [PATCH 21/33] intel: decoder: extract field value computation

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_decoder.c | 59 > ++ > 1 file changed, 37 insertions(+), 22 deletions(-) > > diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c > index a6

Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > This is required to have output redirected to something else than a > file descriptor (stdout). > > Signed-off-by: Lionel Landwerlin > --- > src/intel/compiler/brw_compile_clip.c | 5 +- > src/intel/compiler/brw_compile_sf.c | 5 +- > src/intel/compiler

Re: [Mesa-dev] [PATCH mesa 00/11] fix tests

2017-10-31 Thread Dylan Baker
I've pushed the gbm patch mentioned, and I'll look into the wayland symbols. for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 04:19:57) > a few issues being fixed here: > - symbol checks would silently pass when the lib is missing > - meson was failing to pass the lib

[Mesa-dev] [PATCH] radeonsi: remove 'Authors:' comments

2017-10-31 Thread Marek Olšák
From: Marek Olšák It's inaccurate. Instead, see the copyright and use "git log" and "git blame" to know the authorship. --- src/amd/common/ac_binary.c | 4 src/amd/common/ac_binary.h | 3 --- src/amd/common/ac_debug.c

Re: [Mesa-dev] [PATCH 5/7] meson: build r600

2017-10-31 Thread Dylan Baker
I would be grateful if you would give r300 a whirl. I do have patches that are almost ready for the gallium media state trackers (just needs a little polish, and some testing). Clover will be the next thing on my list after the media stuff. Dylan Quoting Aaron Watry (2017-10-30 20:47:21) > Hi Dyl

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-31 Thread Manolova, Plamena
Thank you for helping me out with this Ken! On Tue, Oct 31, 2017 at 3:50 AM, Kenneth Graunke wrote: > On Monday, October 30, 2017 2:14:24 PM PDT Plamena Manolova wrote: > > This patch modifies the ARB_indirect_parameters logic in > > brw_draw_prims, so that our implementation isn't affected if >

Re: [Mesa-dev] [PATCH 25/25] radeonsi: use a threaded context even for debug contexts

2017-10-31 Thread Marek Olšák
For patch 20: Acked-by: Marek Olšák For patches 1-13, 15-19, 21-25 (assuming my comment on patch 9 is taken into account): Reviewed-by: Marek Olšák I commented on patch 14. Marek On Sun, Oct 22, 2017 at 9:08 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers

[Mesa-dev] [PATCH 0/3] Fix gl_SubGroupG{e,t}MaskARB

2017-10-31 Thread Neil Roberts
Here are some patches to fix the values for gl_SubGroupG{e,t}MaskARB. This fixes a corresponding CTS test. The first patch alone fixes the problem but it generates somewhat inefficient code. The next two patches try to address this but I’m not really sure whether it’s worth it and maybe someone wi

[Mesa-dev] [PATCH 1/3] nir/opt_intrinsics: Fix values for gl_SubGroupG{e, t}MaskARB

2017-10-31 Thread Neil Roberts
Previously the values were calculated by just shifting ~0 by the invocation ID. This would end up including bits that are higher than gl_SubGroupSizeARB. The corresponding CTS test effectively requires that these high bits be zero so it was failing. There is a Piglit test as well but this appears t

[Mesa-dev] [PATCH 2/3] nir: Add an intrinsic for a bitmask of the whole subgroup

2017-10-31 Thread Neil Roberts
Similar to nir_intrinsic_load_subgroup_eq_mask and friends, this adds an intrinsic which contains a bit for every member of the group. This doesn’t have a corresponding GLSL builtin but it will be used to calculate nir_intrinsic_load_subgroup_g{t,e}_mask. It has its own nir option on whether to low

[Mesa-dev] [PATCH 3/3] i965/fs/nir: Don’t let nir lower nir_intrinsic_load_subgroup_all_mask

2017-10-31 Thread Neil Roberts
Instead of letting nir lower nir_intrinsic_load_subgroup_all_mask this is now generated directly. This is more efficient because it can be calculated in the compiler based on the dispatch width. Sadly it’s still not totally ideal because the constant doesn’t seem to get propagated and there is sti

Re: [Mesa-dev] [PATCH mesa 00/11] fix tests

2017-10-31 Thread Emil Velikov
On 31 October 2017 at 11:19, Eric Engestrom wrote: > a few issues being fixed here: > - symbol checks would silently pass when the lib is missing > - meson was failing to pass the lib to the scripts > - the egl symbol check only works on the non-libglvnd lib (we probably > want to have one for l

Re: [Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c > index 48d4456cc16..2c4eaab1701 100644 > --- a/src/intel/to

Re: [Mesa-dev] [PATCH 3/5] st/mesa: use asynchronous flushes

2017-10-31 Thread Marek Olšák
On Sun, Oct 22, 2017 at 9:18 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_cb_flush.c | 4 ++-- > src/mesa/state_tracker/st_cb_syncobj.c | 26 -- > 2 files changed, 26 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/state_

Re: [Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-31 Thread Lionel Landwerlin
On 31/10/17 17:59, Scott D Phillips wrote: Lionel Landwerlin writes: Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16..2c4e

Re: [Mesa-dev] [PATCH 5/5] mesa: flush and wait after creating a fallback texture

2017-10-31 Thread Marek Olšák
I asked a question on patch 3. Other than that, the series is: Reviewed-by: Marek Olšák Marek On Sun, Oct 22, 2017 at 9:18 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes non-deterministic failures in > dEQP-EGL.functional.sharing.gles2.multithread.simple_egl_sync.images.texture_so

Re: [Mesa-dev] [PATCH] radeonsi: fix culldist_writemask in nir path

2017-10-31 Thread Marek Olšák
Yes, si_create_shader_selector contains this: sel->culldist_mask = sel->info.culldist_writemask << sel->info.num_written_clipdistance; Reviewed-by: Marek Olšák Marek On Tue, Oct 31, 2017 at 4:26 AM, Timothy Arceri wrote: > In RADV we need to offset the writemask because >

[Mesa-dev] [PATCH mesa] travis: build meson first for quicker feedback

2017-10-31 Thread Eric Engestrom
Meson is much quicker to build Mesa, giving quicker feedback if executed first. Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Eric Engestrom --- .travis.yml | 64 ++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/.tr

Re: [Mesa-dev] [PATCH 3/3] i965/fs/nir: Don’t let nir lower nir_intrinsic_load_subgroup_all_mask

2017-10-31 Thread Jason Ekstrand
On Tue, Oct 31, 2017 at 10:55 AM, Neil Roberts wrote: > Instead of letting nir lower nir_intrinsic_load_subgroup_all_mask this > is now generated directly. This is more efficient because it can be > calculated in the compiler based on the dispatch width. > > Sadly it’s still not totally ideal bec

Re: [Mesa-dev] [PATCH 3/3] i965/fs/nir: Don’t let nir lower nir_intrinsic_load_subgroup_all_mask

2017-10-31 Thread Jason Ekstrand
On Tue, Oct 31, 2017 at 11:29 AM, Jason Ekstrand wrote: > On Tue, Oct 31, 2017 at 10:55 AM, Neil Roberts > wrote: > >> Instead of letting nir lower nir_intrinsic_load_subgroup_all_mask this >> is now generated directly. This is more efficient because it can be >> calculated in the compiler based

Re: [Mesa-dev] [PATCH 1/3] nir/opt_intrinsics: Fix values for gl_SubGroupG{e, t}MaskARB

2017-10-31 Thread Jason Ekstrand
On Tue, Oct 31, 2017 at 10:55 AM, Neil Roberts wrote: > Previously the values were calculated by just shifting ~0 by the > invocation ID. This would end up including bits that are higher than > gl_SubGroupSizeARB. The corresponding CTS test effectively requires that > these high bits be zero so i

Re: [Mesa-dev] [PATCH 3/3] i965/fs/nir: Don’t let nir lower nir_intrinsic_load_subgroup_all_mask

2017-10-31 Thread Matt Turner
On Tue, Oct 31, 2017 at 10:55 AM, Neil Roberts wrote: > Instead of letting nir lower nir_intrinsic_load_subgroup_all_mask this > is now generated directly. This is more efficient because it can be > calculated in the compiler based on the dispatch width. > > Sadly it’s still not totally ideal beca

Re: [Mesa-dev] [PATCH 2/3] nir: Add an intrinsic for a bitmask of the whole subgroup

2017-10-31 Thread Jason Ekstrand
On Tue, Oct 31, 2017 at 10:55 AM, Neil Roberts wrote: > Similar to nir_intrinsic_load_subgroup_eq_mask and friends, this adds > an intrinsic which contains a bit for every member of the group. This > doesn’t have a corresponding GLSL builtin but it will be used to > calculate nir_intrinsic_load_s

Re: [Mesa-dev] [PATCH] radeonsi: remove 'Authors:' comments

2017-10-31 Thread Matt Turner
On Tue, Oct 31, 2017 at 10:47 AM, Marek Olšák wrote: > From: Marek Olšák > > It's inaccurate. Instead, see the copyright and use "git log" and > "git blame" to know the authorship. Agreed. I've tried to discourage adding new ones. Maybe it's time to clean them out of i965, etc. _

[Mesa-dev] [PATCH mesa] mapi: fix .so path in ABI-check

2017-10-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Didn't find when this was broken, but it looks like the tests had been silently ignored by `make check` for a long time... --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 1/3] meson: Set c visibility args for wayland-drm

2017-10-31 Thread Dylan Baker
Because otherwise gbm will expose wayland symbols that it shouldn't. Signed-off-by: Dylan Baker --- src/egl/wayland/wayland-drm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/wayland/wayland-drm/meson.build b/src/egl/wayland/wayland-drm/meson.build index 12b49ca4f06..19

[Mesa-dev] [PATCH 3/3] fixup! es2api/ABI-check: Add es3.x symbols

2017-10-31 Thread Dylan Baker
This will be squashed before push, but was split out to make review easier. --- src/mapi/es2api/ABI-check | 248 +++--- 1 file changed, 124 insertions(+), 124 deletions(-) diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check index 84e8a130601.

[Mesa-dev] [PATCH 2/3] es2api/ABI-check: Add es3.x symbols

2017-10-31 Thread Dylan Baker
Currently this ABI check only checks for es2.x symbols, but es3.x symbols are also exposed. Exposing these symbols is recommended by Khronos, and as such the test should accept that as ABI. see: https://lists.freedesktop.org/archives/mesa-stable/2016-June/004545.html for the discussion about expos

Re: [Mesa-dev] [PATCH mesa] travis: build meson first for quicker feedback

2017-10-31 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 11:19:02) > Meson is much quicker to build Mesa, giving quicker feedback if > executed first. > > Cc: Dylan Baker > Cc: Emil Velikov > Signed-off-by: Eric Engestrom > --- > .travis.yml | 64 > ++-

Re: [Mesa-dev] [PATCH mesa] travis: build meson first for quicker feedback

2017-10-31 Thread Emil Velikov
Need moar cores :-P Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa] meson: bump libdrm version required by amdgpu

2017-10-31 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 09:29:08) > Fixes: f03b7c9ad92c1656a221 "winsys/amdgpu: Add R600_DEBUG flag to > reserve VMID per ctx." > Cc: Andrey Grodzovsky > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed,

[Mesa-dev] [PATCH 1/2] configure: loosen --enable-glvnd check to honour egl

2017-10-31 Thread Emil Velikov
From: Emil Velikov Currently we error out when building GLVND w/o GLX. That was the original premice before we had EGL. As the commit says, that error should be reworked to honour both - do so. Reported-by: Lukas Rusak Cc: Lukas Rusak Fixes: ce562f9e3fa ("EGL: Implement the libglvnd interface

[Mesa-dev] [PATCH 2/2] configure.ac: require xcb* for the omx/va/... when using x11 platform

2017-10-31 Thread Emil Velikov
From: Emil Velikov Targets such as omx and va can work w/o anything X related. Mandate the xcb* dependencies only when the X11 platform is selected. Reported-by: Lukas Rusak Cc: Lukas Rusak Fixes: 63e11ac2b5c ("configure: error out if building VA w/o supported platform") Signed-off-by: Emil Ve

[Mesa-dev] [PATCH 2/2] configure.ac: append to existing initializer override flags

2017-10-31 Thread Emil Velikov
From: Emil Velikov Currently we were overwriting the existing warning flags, instead of adding new [as applicable]. Fixes c5d2e2d43f6 ("configure: Test for -Wno-initializer-overrides") Cc: Matt Turner Signed-off-by: Emil Velikov --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[Mesa-dev] [PATCH 1/2] configure.ac: append to existing MSVC compat flags

2017-10-31 Thread Emil Velikov
From: Emil Velikov Currently we were overwriting the existing warning flags, instead of adding new [as applicable]. Fixes e4b2b69e828 ("configure: Add and use AX_CHECK_COMPILE_FLAG") Cc: Matt Turner Signed-off-by: Emil Velikov --- configure.ac | 8 1 file changed, 4 insertions(+), 4

Re: [Mesa-dev] [PATCH] radv: make radv_bind_descriptor_set() static

2017-10-31 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Oct 31, 2017 at 10:29 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- > src/amd/vulkan/radv_private.h| 3 --- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/amd/

Re: [Mesa-dev] [PATCH 1/2] configure.ac: append to existing MSVC compat flags

2017-10-31 Thread Matt Turner
Oops! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 15/33] intel: error-decode: implement a rolling window of programs

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > If we have more programs than what we can store, > aubinator_error_decode will assert. Instead let's have a rolling > window of programs. > > v2: Fix overflowing issues (Eric Engestrom) > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Eric Engestrom As an enhance

Re: [Mesa-dev] [PATCH 23/33] intel: decoder: group enum related declarations

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: Is this one a rebase error? The commit message doesn't make sense with the patch, and the change from Patch 22 gets reverted here. > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_decoder.c | 8 > src/intel/common/gen_decoder.h | 3 ++- > 2 fil

Re: [Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-31 Thread Nanley Chery
On Mon, Oct 30, 2017 at 05:24:10PM -0700, Nanley Chery wrote: > On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote: > > There are few other (duplicate) workarounds which have similar > > recommendations: > > WaFlushHangWhenNonPipelineStateAndMarkerStalled > > WaCSStallBefore3DSamplePatter

Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > This is required to have output redirected to something else than a > file descriptor (stdout). an alternative here might be to fdopen() a pipe(). Maybe a bit weird but it could save several hundred lines of change and maybe get you buffering to boot. however you feel

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > We want to introduce a reader interface for accessing memory, so that > later on we can use different ways of storing the content of the GTT > address space that don't involve a pointer to a linear buffer. I'm kinda sceptical that this is the best way to achieve what

[Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

2017-10-31 Thread Dylan Baker
Because meson mirrors the auototools logic, it needs the same changes to allow building glvnd based EGL without building any GLX. Signed-off-by: Dylan Baker --- Emil, This implements the same logic that you're implementing for meson: one or both of dri based GLX or EGL is required for glvnd, b

Re: [Mesa-dev] create src/wsi

2017-10-31 Thread Dylan Baker
Quoting Emil Velikov (2017-10-30 10:47:22) > On 30 October 2017 at 17:05, Dylan Baker wrote: > > So I think the consensus is this is okay? > > > > Emil, is the autotools right here? > > > > Without a clear separation or cleanup of the the existing code, this > such move brings no technical benefi

Re: [Mesa-dev] [PATCH 21/33] intel: decoder: extract field value computation

2017-10-31 Thread Lionel Landwerlin
On 31/10/17 17:29, Scott D Phillips wrote: Lionel Landwerlin writes: Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/int

  1   2   >