[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103323 Bug ID: 103323 Summary: Possible unintended error message in file pixel.c line 286 Product: Mesa Version: git Hardware: Other OS: All Status: N

[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103323 Petru Mihancea changed: What|Removed |Added Severity|normal |trivial Priority|medium

Re: [Mesa-dev] [PATCH] radv: don't create dummy fs when compiling compute stage

2017-10-18 Thread Bas Nieuwenhuizen
r-b On Wed, Oct 18, 2017 at 5:02 AM, Timothy Arceri wrote: > Fixes: d1c9f30d7ff7 "radv: add radv_create_shaders() helper" > --- > src/amd/vulkan/radv_pipeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.

[Mesa-dev] [PATCH v3 4/4] spirv: add support for images and samplers as function arguments

2017-10-18 Thread Samuel Iglesias Gonsálvez
Fixes: dEQP-VK.spirv_assembly.instruction.*.image_sampler.* Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_cfg.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 25ff254bcec..8b139068f

[Mesa-dev] [PATCH v3 3/4] i965/vec4: remove setting default LOD in the backend

2017-10-18 Thread Samuel Iglesias Gonsálvez
It is already done in NIR. Signed-off-by: Samuel Iglesias Gonsálvez Reviewed-by: Lionel Landwerlin --- src/intel/compiler/brw_vec4_nir.cpp | 9 - src/intel/compiler/brw_vec4_visitor.cpp | 12 2 files changed, 21 deletions(-) diff --git a/src/intel/compiler/brw_vec4_ni

[Mesa-dev] [PATCH v3 2/4] i965/fs: remove setting default LOD in the backend

2017-10-18 Thread Samuel Iglesias Gonsálvez
It is already done in NIR. Signed-off-by: Samuel Iglesias Gonsálvez Reviewed-by: Lionel Landwerlin --- src/intel/compiler/brw_fs_nir.cpp | 9 - 1 file changed, 9 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 7ed44f534c0..cc098849

[Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Samuel Iglesias Gonsálvez
v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index 65

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: > On 17.10.2017 19:16, Daniel Vetter wrote: > > On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: > > > On 17/10/17 05:04 PM, Daniel Vetter wrote: > > > > On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: > > > > > On

[Mesa-dev] [PATCH] anv: Fix instance typos.

2017-10-18 Thread Vinson Lee
Fix build error. CC vulkan/vulkan_libvulkan_common_la-anv_device.lo In file included from vulkan/anv_device.c:33:0: vulkan/anv_device.c: In function ‘anv_AllocateMemory’: vulkan/anv_device.c:1562:37: error: ‘struct anv_device’ has no member named ‘instace’; did you mean ‘instance’?

Re: [Mesa-dev] [PATCH v2] r600/sb: bail out if prepare_alu_group() doesn't find a proper scheduling

2017-10-18 Thread Vadim Girlin
On 10/16/2017 10:06 PM, Gert Wollny wrote: It is possible that the optimizer ends up in an infinite loop in post_scheduler::schedule_alu(), because post_scheduler::prepare_alu_group() does not find a proper scheduling. This can be deducted from pending.count() being larger than zero and not getti

[Mesa-dev] [PATCH v4] automake: intel: move expat handling where it's used

2017-10-18 Thread Hongxu Jia
Linking libvulkan_intel.so can fail, due to unresolved references to libexpat.so. EXPAT_CFLAGS should be moved as well. Signed-off-by: Hongxu Jia --- src/intel/Makefile.common.am | 3 ++- src/intel/Makefile.tools.am | 4 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/i

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] auxiliary: use vl_drm_screen_create method for surfaceless

2017-10-18 Thread Guttula, Suresh
On 11 October 2017 at 07:13, Guttula, Suresh mailto:suresh.gutt...@amd.com>> wrote: > HI, > >>- why do we need "surfaceless" support >ChromeOS supports surfacelsess and we need this va enablement for > surfaceless in chromium. Ack, that should have been part of the commit message. >>>I wil

[Mesa-dev] [PATCH] i965: Do not log a perf warning when mapping an idle bo

2017-10-18 Thread Chris Wilson
We only want to scare the user away from causing a GPU stall for mapping a busy bo. The time taken to instantiate the set of pages for a buffer and their mmapping is unavoidable and flagging idle bo as being busy is "crying wolf". Reported-by: Tvrtko Ursulin Cc: Kenneth Graunke --- src/mesa/dri

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 Bug ID: 103332 Summary: glDrawArrays does not take the "first" argument into account Product: Mesa Version: 17.2 Hardware: Other OS: Linux (All)

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 Laurent Renard changed: What|Removed |Added CC||laurent.ren...@int.com -- You are rec

Re: [Mesa-dev] [PATCH] i965: Do not log a perf warning when mapping an idle bo

2017-10-18 Thread Chris Wilson
Quoting Chris Wilson (2017-10-18 09:53:27) > We only want to scare the user away from causing a GPU stall for mapping > a busy bo. The time taken to instantiate the set of pages for a buffer > and their mmapping is unavoidable and flagging idle bo as being busy is > "crying wolf". > > Reported-by:

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Michel Dänzer
On 18/10/17 10:10 AM, Daniel Vetter wrote: > On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: >> On 17.10.2017 19:16, Daniel Vetter wrote: >>> On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: > On Tue, Oct 17, 2017 at 03:46:24

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 --- Comment #1 from Laurent Renard --- I have tested with modified version of the tutorial found here : http://www.opengl-tutorial.org/beginners-tutorials/tutorial-5-a-textured-cube/ Modifying the command // Draw the triangle ! glDrawArrays(GL

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 21:38, Gurchetan Singh wrote: > The naming is verbose and somewhat inconsistent. We have: > > dri2_init_surface > dri2_fini_surface > dri2_egl_surface_alloc_local_buffer > dri2_egl_surface_free_local_buffers > > I suggest you implement the following convention: > > dri2_surf

Re: [Mesa-dev] [PATCH v2 2/8] egl: refactor color_buffers structure for deduplicating

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 21:49, Gurchetan Singh wrote: > Can you wrap color_buffers around: > > #if defined(HAVE_WAYLAND_PLATFORM) || defined(HAVE_DRM_PLATFORM) || > defined(HAVE_ANDROID_PLATFORM) > > flags? This is because platform_surfaceless has no native surfaces and it's > good to be explicit i

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > I might need to double check the spec, but I thought "no damage hint" > > meant "no way to reduce the update, redraw the whole screen"? > > > > If that's the case, then SwapBuffers() and SwapBuf

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Nicolai Hähnle
On 18.10.2017 10:10, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: On 17.10.2017 19:16, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 03:46:24PM +0200, Miche

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Harish Krupo
Hi Eric, Eric Engestrom writes: > On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: >> Hi Eric, >> >> Eric Engestrom writes: >> > I might need to double check the spec, but I thought "no damage hint" >> > meant "no way to reduce the update, redraw the whole screen"? >> > >> > If tha

Re: [Mesa-dev] [PATCH] anv: Fix instance typos.

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 08:12:27 +, Vinson Lee wrote: > Fix build error. > > CC vulkan/vulkan_libvulkan_common_la-anv_device.lo > In file included from vulkan/anv_device.c:33:0: > vulkan/anv_device.c: In function ‘anv_AllocateMemory’: > vulkan/anv_device.c:1562:37: error: ‘struct anv_

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 20:21, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > > I'm sending this out now so that others can look at it, review it, and > reference > it, but this should not end up in the 17.3 release, as the meson build for > mesa > will not be ready to go into the 17.3 r

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Lionel Landwerlin
Thanks again! Reviewed-by: Lionel Landwerlin On 18/10/17 08:54, Samuel Iglesias Gonsálvez wrote: v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file changed, 23

Re: [Mesa-dev] [PATCH v4] automake: intel: move expat handling where it's used

2017-10-18 Thread Lionel Landwerlin
If you feel like it, you could also fix the meson build :) Otherwise, this is : Reviewed-by: Lionel Landwerlin On 18/10/17 02:47, Hongxu Jia wrote: Linking libvulkan_intel.so can fail, due to unresolved references to libexpat.so. EXPAT_CFLAGS should be moved as well. Signed-off-by: Hongxu Ji

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Eric Engestrom
On Tuesday, 2017-10-17 19:21:10 +, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > > I'm sending this out now so that others can look at it, review it, and > reference > it, but this should not end up in the 17.3 release, as the meson build for > mesa > will not be ready to go into

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Nicolai Hähnle
On 17.10.2017 21:53, Ville Syrjälä wrote: On Tue, Oct 17, 2017 at 09:00:56PM +0200, Nicolai Hähnle wrote: On 17.10.2017 16:09, Ville Syrjälä wrote: On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: On 17/10/17 02:22 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 12:28:17PM +020

[Mesa-dev] [PATCH mesa] meson: move expat dependency where it's needed

2017-10-18 Thread Eric Engestrom
Suggested-by: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/common/meson.build | 2 +- src/intel/tools/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/meson.build b/src/intel/common/meson.build index 6b0af929d9ef481e3c46..db7d7

[Mesa-dev] i965: tiled-memcpy + subimages

2017-10-18 Thread Chris Wilson
I noticed when enabling "accelerated readback" with userptr enabling writes directly into client memory was that we often missed the tiled-memcpy fastpaths; in particular it did not handle subimages. Since I was relying on the tiled-memcpy fastpath to avoid using the GPU for readback where unnecess

[Mesa-dev] [PATCH 2/3] i965: Remove packing restrictions for tiled-memcpy

2017-10-18 Thread Chris Wilson
Use the core unpacking functions to convert the gl_pixelstore_attrib into the real pixel address required for copying; thereby removing the restrictions that the tiled-memcpy could only handle exactly matching image transfers. Cc: Matt Turner Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH 1/3] i965: Support very simple expansion options for tiled memcpy

2017-10-18 Thread Chris Wilson
A big limitation of the current direct memcpy routine is that it only recognises a couple of (admittedly) common colour types, and cannot do any inline conversion. If we pass the mesa_format down to memcpy and tell it the direction of the transfer, we can start accepting a few mixed transfers and b

[Mesa-dev] [PATCH 3/3] i965: Support direct upload into texture arrays

2017-10-18 Thread Chris Wilson
Iterate the tiled_memcpy for each face so that we can quickly do synchronous uploads into cube maps etc. Cc: Matt Turner Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_image.c | 60 + 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/src/me

[Mesa-dev] [PATCH 1/3] i965: call nir_lower_io_to_scalar() at link time for BDW and above

2017-10-18 Thread Timothy Arceri
This will allow dead components of varyings to be removed. BDW shader-db results: total instructions in shared programs: 13190730 -> 13108459 (-0.62%) instructions in affected programs: 2110903 -> 2028632 (-3.90%) helped: 14043 HURT: 486 total cycles in shared programs: 541148990 -> 540544072 (-

[Mesa-dev] [PATCH 2/3] nir: add varying component packing helpers

2017-10-18 Thread Timothy Arceri
This packing pass is relatively simple, it only packs scalar components. To be effective it relies on nir_lower_io_to_scalar_early() having already split the majority of varyings into scalar components. We may wish to add matrix and array support at some point however a matrix/array splitting pass

[Mesa-dev] [PATCH 3/3] i965: enable varying component packing for BDW+

2017-10-18 Thread Timothy Arceri
shader-db results BDW: total instructions in shared programs: 13192895 -> 13182351 (-0.08%) instructions in affected programs: 831151 -> 820607 (-1.27%) helped: 5241 HURT: 116 total cycles in shared programs: 539249342 -> 539155930 (-0.02%) cycles in affected programs: 21914368 -> 21820956 (-0.43

Re: [Mesa-dev] [PATCH mesa] meson: move expat dependency where it's needed

2017-10-18 Thread Lionel Landwerlin
Thanks Eric! Reviewed-by: Lionel Landwerlin On 18/10/17 12:08, Eric Engestrom wrote: Suggested-by: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/common/meson.build | 2 +- src/intel/tools/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Mesa-dev] [PATCH] radv: reset dirty flags after flushing all states

2017-10-18 Thread Samuel Pitoiset
Move it to radv_cmd_buffer_flush_state() because if rasterizerDiscardEnable is true, the flags are not cleared. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/v

[Mesa-dev] [PATCH 1/2] radv: remove useless mask operation in radv_cs_emit_draw_indexed_packet()

2017-10-18 Thread Samuel Pitoiset
This saves few CPU cycles when CmdDrawIndexed() is used a lot. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index e0d6646616..c6dd620eea

[Mesa-dev] [PATCH 2/2] radv: do not re-emit the index buffer for every draw call

2017-10-18 Thread Samuel Pitoiset
It can only be changed when CmdBindIndexBuffer() is called or when a secondary buffer is used. Though not always, but let's re-emit the packets in this situation for now. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 57 1 file cha

[Mesa-dev] [PATCH] radv/winsys: bump the buffer hash table size to 4096

2017-10-18 Thread Samuel Pitoiset
This reduces the number of conflicts when a bunch of buffers are added to the CS list. It improves the benchmark #3 (from GL_vs_VK) by +3/4%. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/a

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-18 Thread Eero Tamminen
Hi Jason, This commit dropped SynMark2 v7 OglShMapPcf performance by 1-2% on GT2 versions of SKL, KBL and CFL. It may have improved it by same amount on SKL GT4e. Effects on other machines were within normal variation. - Eero On 30.09.2017 00:25, Jason Ekstrand wrote: Otherwise, i

[Mesa-dev] [PATCH] radv: Set active_stages after getting cached shaders

2017-10-18 Thread Alex Smith
Fixes: 7d45d22fdd2e ("radv: switch to using radv_create_shaders()") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_pipeline.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 559862678e..a3d8660eda 1

[Mesa-dev] [PATCH] radv: Don't free NIR shaders if tracing

2017-10-18 Thread Alex Smith
Fixes a crash while generating a hang report. Fixes: 7d45d22fdd2e ("radv: switch to using radv_create_shaders()") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 17:34, Harish Krupo wrote: > Hi Emil, > > Thank you for the comments, will fix the code accordingly and send a > v2 patch. > I have answered the question inline. > > Emil Velikov writes: > >> Hi Harish, >> >> Overall looks great, a few comments/questions inline. >> >> On 13

Re: [Mesa-dev] [PATCH] radv: Don't free NIR shaders if tracing

2017-10-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/18/2017 04:08 PM, Alex Smith wrote: Fixes a crash while generating a hang report. Fixes: 7d45d22fdd2e ("radv: switch to using radv_create_shaders()") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Mesa-dev] [PATCH 6/7] glsl/parser: Track built-in types using the glsl_type directly

2017-10-18 Thread Ian Romanick
On 10/17/2017 12:54 PM, Nicolai Hähnle wrote: > On 17.10.2017 20:14, Ian Romanick wrote: >> From: Ian Romanick >> >>     text   data    bss    dec    hex    filename >> 8255243 268856 294072    8818171 868dfb    32-bit >> i965_dri.so before >> 8255291 268856 294

Re: [Mesa-dev] [PATCH v4] automake: intel: move expat handling where it's used

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 10:50:09 +, Lionel Landwerlin wrote: > If you feel like it, you could also fix the meson build :) > Otherwise, this is : > > Reviewed-by: Lionel Landwerlin Just pushed both :) Thanks Hongxu, and welcome to Mesa! > > On 18/10/17 02:47, Hongxu Jia wrote: > > Linking

[Mesa-dev] [PATCH v5 0/3] build system: Unify c++11 detection and use

2017-10-18 Thread Gert Wollny
Dear all, here is another rework of the c++11 detection and flag application implementing the ideas raised in the discussion with Emil and Chuck. The part in configure.ac has been completely rewritten. Now one can give an environment variable CXX11_CXXFLAGS to test for enabling c++11 support with

[Mesa-dev] [PATCH v5 3/3] clover: use the unified check for c++11 instead of the gcc version number

2017-10-18 Thread Gert Wollny
So far clover based its test for compiler support on the version of gcc, while in reality support for c++11 is required. This patch replaces the version check by the check unified for all modules that require c++11. --- configure.ac | 4 ++-- src/gallium/state_trac

[Mesa-dev] [PATCH v5 2/3] swr: Replace the check for c++11 by the unified version

2017-10-18 Thread Gert Wollny
--- configure.ac| 7 +++ src/gallium/drivers/swr/Makefile.am | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index b828a45310..2f6809a5f3 100644 --- a/configure.ac +++ b/configure.ac @@ -2583,10 +2583,9 @@ if test -n

[Mesa-dev] [PATCH v5 1/3] configure+mesa/st: check for -std=c++11 support and enable mesa/st/test accordingly

2017-10-18 Thread Gert Wollny
Add a check that tests whether the c++ compiler supports c++11, either by default, by adding the compiler flag -std=c++11, or by adding a compiler flag that the user has specified via the environment variable CXX11_CXXFLAGS. The test only does a very shallow check of c++11 support, i.e. it tests

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Jason Ekstrand
On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez wrote: v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/co

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-18 Thread Kai Wasserbäch
Hey Eric, Eric Engestrom wrote on 17.10.2017 19:48: > On Tuesday, 2017-10-17 17:20:13 +, Emil Velikov wrote: >> [...] >> Yes name is a bit misleading, so I'm wondering if any of the following >> won't be better >> - s/DRI2/DRI/ - might be tad confusing >> - emit the corresponding DRI2 vs DRI3

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-18 Thread Jason Ekstrand
On Wed, Oct 18, 2017 at 6:11 AM, Eero Tamminen wrote: > Hi Jason, > > This commit dropped SynMark2 v7 OglShMapPcf performance by 1-2% on GT2 > versions of SKL, KBL and CFL. It may have improved it by same amount on > SKL GT4e. Effects on other machines were within normal variation. > That's ver

Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 15:39, Andy Furniss wrote: > Emil Velikov wrote: > On a "bad" build (-DLLVM_BUILD_LLVM_DYLIB=ON) I get andy [~]$ llvm-config --link-shared --libs bitwriter llvm-config: error: missing: /usr/lib/libLLVMDemangle.so llvm-config: error: missing: /usr/lib/

[Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-10-18 Thread Eric Engestrom
The "DRI2" name was reported as confusing when printing EGL infos (one user reported thinking DRI3 was not working on his X server), and the only alternative is Haiku, which can only be used on a Haiku machine. The name therefore doesn't add any information that the user wouldn't know already, so

[Mesa-dev] [PATCH mesa 1/2] egl: drop always-false TestOnly option

2017-10-18 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 4 src/egl/main/eglapi.c | 2 +- src/egl/main/egldisplay.h | 1 - src/egl/main/egldriver.c| 18 +++--- src/egl/main/egldriver.h| 2 +- 5 files changed, 9 insertions(+), 18 dele

Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-18 Thread Michel Dänzer
On 18/10/17 05:41 PM, Emil Velikov wrote: > On 17 October 2017 at 15:39, Andy Furniss wrote: >> Emil Velikov wrote: >> > On a "bad" build (-DLLVM_BUILD_LLVM_DYLIB=ON) I get > > andy [~]$ llvm-config --link-shared --libs bitwriter > llvm-config: error: missing: /usr/lib/libLLVMDeman

[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103323 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 --- Comment #2 from Bruce Cherniak --- Hello Laurent. I will be happy to take a look at this with you. It does seem like a bug in the SWR code. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [PATCH mesa] egl: set UseFallback if LIBGL_ALWAYS_SOFTWARE is set

2017-10-18 Thread Eric Engestrom
Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_surfaceless.c | 3 +-- src/egl/drivers/dri2/platform_wayland.c | 3 +-- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/main/egldriver.c| 5 - 4 files changed, 7 ins

Re: [Mesa-dev] [PATCH] anv: Fix instance typos.

2017-10-18 Thread Jason Ekstrand
Pushed. On Wed, Oct 18, 2017 at 3:31 AM, Eric Engestrom wrote: > On Wednesday, 2017-10-18 08:12:27 +, Vinson Lee wrote: > > Fix build error. > > > > CC vulkan/vulkan_libvulkan_common_la-anv_device.lo > > In file included from vulkan/anv_device.c:33:0: > > vulkan/anv_device.c: In func

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 15:32:20 +, Kai Wasserbäch wrote: > Hey Eric, > Eric Engestrom wrote on 17.10.2017 19:48: > > On Tuesday, 2017-10-17 17:20:13 +, Emil Velikov wrote: > >> [...] > >> Yes name is a bit misleading, so I'm wondering if any of the following > >> won't be better > >> - s

Re: [Mesa-dev] [PATCH] Fix the xf86vm meson dependency

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 02:36:30 +, Dylan Baker wrote: > I could have sworn this got fixed already, but clearly not. > > reviewed-by: Dylan Baker R-b and pushed :) (and I also remember this being mentioned and fixed already) > > On October 17, 2017 6:04:16 PM PDT, Nicholas Miell wrote: >

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-10-18 Thread Eric Engestrom
Ugh, apologies, I failed at git again... I just pushed these two (and the UseFallback patch) to master by mistake... I'm happy to revert if someone had and reservation on this patch /me doesn't push anything anywhere anymore today. On Wednesday, 2017-10-18 15:42:34 +, Eric Engestrom wrote:

[Mesa-dev] [AppVeyor] mesa master #5838 failed

2017-10-18 Thread AppVeyor
Build mesa 5838 failed Commit 7561da367b by Michel Dänzer on 10/16/2017 2:35 PM: st/mesa: Initialize textures array in st_framebuffer_validate\n\nAnd just reference pipe_resources to it in the validate callbacks.\n\nAvoids pipe_resource leaks when st_framebuffe

[Mesa-dev] [AppVeyor] mesa master #5839 completed

2017-10-18 Thread AppVeyor
Build mesa 5839 completed Commit 8c9e7c9638 by Michel Dänzer on 10/18/2017 4:44 PM: st/osmesa: include u_inlines.h for pipe_resource_reference\n\nFixes build failure due to unresolved symbol.\n\nFixes: 7561da367bae "st/mesa: Initialize textures array in\n

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Michel Dänzer
On 18/10/17 12:15 PM, Nicolai Hähnle wrote: > On 18.10.2017 10:10, Daniel Vetter wrote: >> On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: >>> On 17.10.2017 19:16, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: > On 17/10/17 05:04 PM, Danie

Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-18 Thread Andy Furniss
Michel Dänzer wrote: On 18/10/17 05:41 PM, Emil Velikov wrote: On 17 October 2017 at 15:39, Andy Furniss wrote: Emil Velikov wrote: On a "bad" build (-DLLVM_BUILD_LLVM_DYLIB=ON) I get andy [~]$ llvm-config --link-shared --libs bitwriter llvm-config: error: missing: /usr/lib/libLLVMDemangle

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Dylan Baker
Quoting Emil Velikov (2017-10-18 03:32:14) > On 17 October 2017 at 20:21, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > > > I'm sending this out now so that others can look at it, review it, and > > reference > > it, but this should not end up in the 17.3 release, as the meson bu

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-18 04:02:07) > On Tuesday, 2017-10-17 19:21:10 +, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > > > I'm sending this out now so that others can look at it, review it, and > > reference > > it, but this should not end up in the 17.3 release, as

Re: [Mesa-dev] [PATCH] st/mesa: set dimension for constants in ATI_fragment_shader

2017-10-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Oct 15, 2017 at 7:46 PM, Miklós Máté wrote: > This fixes an assertion failure introduced by 30a2f0dfd46de. > > Signed-off-by: Miklós Máté > --- > src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/m

Re: [Mesa-dev] [PATCH mesa 5/6] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

2017-10-18 Thread Mark Janes
This patch causes wflinfo to segfault for Intel platforms. https://bugs.freedesktop.org/show_bug.cgi?id=103349 This has a high impact, because Intel engineers cannot test their patches until the commit is fixed or reverted. Eric Engestrom writes: > Note: dropping the EGL_BAD_ALLOC in egl_haiku

Re: [Mesa-dev] [PATCH] st/mesa: set dimension for constants in ATI_fragment_shader

2017-10-18 Thread Marek Olšák
Pushed! Marek On Wed, Oct 18, 2017 at 7:34 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Sun, Oct 15, 2017 at 7:46 PM, Miklós Máté wrote: >> This fixes an assertion failure introduced by 30a2f0dfd46de. >> >> Signed-off-by: Miklós Máté >> --- >> src/mesa/state_tracker/st_

Re: [Mesa-dev] [PATCH 1/2] drirc: Enable glthread for more games (Saints Row 4 & Gat out of Hell).

2017-10-18 Thread Marek Olšák
Did you verify with GALLIUM_HUD that glthread is enabled and most calls are offloaded? Marek On Mon, Oct 16, 2017 at 12:22 AM, Darren Salt wrote: > “Saints Row: Gat out of Hell” benefits from this on slower CPUs in that > usage spikes on individual cores are avoided, which in turn makes it harde

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-10-18 Thread Emil Velikov
On 18 October 2017 at 17:33, Eric Engestrom wrote: > Ugh, apologies, I failed at git again... I just pushed these two (and > the UseFallback patch) to master by mistake... > > I'm happy to revert if someone had and reservation on this patch > Thanks for the cleanups Eric. Patches seem fine to me.

Re: [Mesa-dev] [PATCH] i965: Do not log a perf warning when mapping an idle bo

2017-10-18 Thread Kenneth Graunke
On Wednesday, October 18, 2017 2:03:37 AM PDT Chris Wilson wrote: > Quoting Chris Wilson (2017-10-18 09:53:27) > > We only want to scare the user away from causing a GPU stall for mapping > > a busy bo. The time taken to instantiate the set of pages for a buffer > > and their mmapping is unavoidabl

[Mesa-dev] [PATCH v2] docs: add documentation for building with meson

2017-10-18 Thread Dylan Baker
v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) - Add message at top that meson for mesa is still a work in progress - Add trailing "/" to directories (Eric E.) - Fix a number of spelling/grammar/style suggestions from Eric E. - Make a number of changes as sugges

[Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

2017-10-18 Thread Emil Velikov
From: Emil Velikov Seems that a few function pointers are initialized by the function. We could pick the missing ones and add them to the respective platforms. Since this brings down the Intel Jenkins CI, let's reinstate the call and worry about more elegant fix later. Fixes: 8cb84c8477a ("egl:

Re: [Mesa-dev] [PATCH 01/10] anv/android: Link to Android libraries in the autotools build

2017-10-18 Thread Dylan Baker
Android with meson is still a TODO as a whole. If someone at google wanted to get all of that working I would be very appreciative Dylan Quoting Jason Ekstrand (2017-10-16 15:46:05) > No meson love? > > On Mon, Oct 16, 2017 at 11:54 AM, Chad Versace > wrote: > > A first step to support

Re: [Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

2017-10-18 Thread Mark Janes
Tested-by: Mark Janes Emil Velikov writes: > From: Emil Velikov > > Seems that a few function pointers are initialized by the function. > We could pick the missing ones and add them to the respective platforms. > > Since this brings down the Intel Jenkins CI, let's reinstate the call > and wor

Re: [Mesa-dev] Mesa 17.3.0 release plan

2017-10-18 Thread Emil Velikov
On 12 October 2017 at 14:47, Emil Velikov wrote: > Hi all, > > As you've know the Mesa 17.3.0 release plan has been available for a while > on the mesa3d.org website [1]. > > In case you've missed it here it is: > > Oct 20 2017 - Feature freeze/Release candidate 1 > Oct 27 2017 - Release candida

Re: [Mesa-dev] [PATCH mesa 5/6] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

2017-10-18 Thread Marek Olšák
Hi, I just reverted 2 egl commits including this one. See the commit log for more information. Marek On Wed, Oct 18, 2017 at 7:38 PM, Mark Janes wrote: > This patch causes wflinfo to segfault for Intel platforms. > > https://bugs.freedesktop.org/show_bug.cgi?id=103349 > > This has a high impact

Re: [Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

2017-10-18 Thread Marek Olšák
Hi Emil, I guess you can squash this into the commits I reverted. Marek On Wed, Oct 18, 2017 at 8:02 PM, Emil Velikov wrote: > From: Emil Velikov > > Seems that a few function pointers are initialized by the function. > We could pick the missing ones and add them to the respective platforms. >

Re: [Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 18:09:33 +, Emil Velikov wrote: > From: Emil Velikov > > Seems that a few function pointers are initialized by the function. > We could pick the missing ones and add them to the respective platforms. > > Since this brings down the Intel Jenkins CI, let's reinstate th

Re: [Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

2017-10-18 Thread Emil Velikov
On 18 October 2017 at 19:31, Eric Engestrom wrote: > On Wednesday, 2017-10-18 18:09:33 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Seems that a few function pointers are initialized by the function. >> We could pick the missing ones and add them to the respective platforms. >> >> Since

[Mesa-dev] [PATCH mesa] egl: add missing _eglInitDriverFallbacks() call

2017-10-18 Thread Eric Engestrom
I mistakenly dropped this during a rebase. Fixes: 8cb84c8477a ("egl: move alloc & init out of _eglBuiltInDriver{DRI2,Haiku}") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103349 Reported-by: Mark Janes Cc: Emil Velikov Signed-off-by: Eric Engestrom --- src/egl/mai

Re: [Mesa-dev] [PATCH] radv: Set active_stages after getting cached shaders

2017-10-18 Thread Bas Nieuwenhuizen
Thanks, pushed both patches. On Wed, Oct 18, 2017 at 3:47 PM, Alex Smith wrote: > Fixes: 7d45d22fdd2e ("radv: switch to using radv_create_shaders()") > Signed-off-by: Alex Smith > --- > src/amd/vulkan/radv_pipeline.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Nicholas Miell
On 10/17/2017 12:21 PM, Dylan Baker wrote: + +To see a description of your options you can run "meson configure". This will +show your meson project configuration options as well as your local +configuration options. One meson option to be aware of is that meson's default +build type is "debug" (

Re: [Mesa-dev] [PATCH] radv: reset dirty flags after flushing all states

2017-10-18 Thread Bas Nieuwenhuizen
r-b On Wed, Oct 18, 2017 at 2:09 PM, Samuel Pitoiset wrote: > Move it to radv_cmd_buffer_flush_state() because if > rasterizerDiscardEnable is true, the flags are not cleared. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH] radv/winsys: bump the buffer hash table size to 4096

2017-10-18 Thread Bas Nieuwenhuizen
I'd prefer not to. The current size is already huge when you consider that a lot of applications use pretty small command buffers, adding another 12k per command buffer is a bit much. I'd prefer not having that overhead, since the GL_vs_VK benchmarks were IIRC not really representative. On Wed, Oc

Re: [Mesa-dev] [PATCH 2/2] radv: do not re-emit the index buffer for every draw call

2017-10-18 Thread Bas Nieuwenhuizen
Interesting that we already had RADV_CMD_DIRTY_INDEX_BUFFER. r-b for the series. On Wed, Oct 18, 2017 at 2:17 PM, Samuel Pitoiset wrote: > It can only be changed when CmdBindIndexBuffer() is called > or when a secondary buffer is used. Though not always, but > let's re-emit the packets in this si

[Mesa-dev] [Bug 103350] llvmpipe regressions due to be3ab867

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103350 Bug ID: 103350 Summary: llvmpipe regressions due to be3ab867 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: no

[Mesa-dev] [Bug 103265] [llvmpipe] piglit depth-tex-compare regression

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103265 Tim Rowley changed: What|Removed |Added Depends on||103350 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 103266] [llvmpipe] piglit sampler-cube-shadow regression

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103266 Tim Rowley changed: What|Removed |Added Depends on||103350 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 103268] [llvmpipe] piglit texdepth regression

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103268 Tim Rowley changed: What|Removed |Added Depends on||103350 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 103350] llvmpipe regressions due to be3ab867

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103350 Tim Rowley changed: What|Removed |Added Blocks||103266, 103265, 103268 Referenced Bugs:

[Mesa-dev] [Bug 103266] [llvmpipe] piglit sampler-cube-shadow regression

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103266 Bug 103266 depends on bug 103350, which changed state. Bug 103350 Summary: llvmpipe regressions due to be3ab867 https://bugs.freedesktop.org/show_bug.cgi?id=103350 What|Removed |Added --

  1   2   3   >