https://bugs.freedesktop.org/show_bug.cgi?id=102021
Bug ID: 102021
Summary: ir validation assert on valid GLSL
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Prio
https://bugs.freedesktop.org/show_bug.cgi?id=102016
Fabio Pedretti changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=102016
Vinson Lee changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=102021
--- Comment #1 from Dave Airlie ---
ah looks like do_vectorize
START GLSL optimization do_vectorize
(
(declare (location=0 shader_out ) vec4 gl_Position)
(declare (shader_in ) (array vec4 3) vertex)
(declare (shader_out ) vec4 temp)
(declare (t
https://bugs.freedesktop.org/show_bug.cgi?id=102021
--- Comment #2 from Dave Airlie ---
START GLSL optimization optimize_split_arrays
(
(declare (location=0 shader_out ) vec4 gl_Position)
(declare (shader_in ) (array vec4 3) vertex)
(declare (shader_out ) vec4 temp)
(declare (temporary ) vec4 tem
https://bugs.freedesktop.org/show_bug.cgi?id=102021
--- Comment #3 from Dave Airlie ---
Created attachment 133221
--> https://bugs.freedesktop.org/attachment.cgi?id=133221&action=edit
hacky attempt at fixing it.
--
You are receiving this mail because:
You are the assignee for the bug.
Aux usage is ISL_AUX_USAGE_NONE when miptree is set shareable
within (intel_miptree_make_shareable).
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925
---
src/mesa/drivers/dri/i965/brw_blorp.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mes
https://bugs.freedesktop.org/show_bug.cgi?id=101334
--- Comment #32 from Marko ---
Sorry, couldn't test yesterday due to build bug:
https://bugs.freedesktop.org/show_bug.cgi?id=102014
I'll recompile today and test this evening with any luck.
glhf,
Marko
--
You are receiving this mail becaus
LLC platforms are magic in that reads from the CPU are always cache
coherent, or rather GPU writes that bypass LLC do still invalidate the
appropriate cache line.
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/me
Ensure that any buffer allocated for a scanout image is kept out of the
CPU/LLC cache so as to avoid any visual glitch.
Cc: Kenneth Graunke
---
src/mesa/drivers/dri/i965/intel_screen.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src
Fixes build error with anv_extensions.c not found for
libmesa_anv_entrypoints.
Fixes: d62063c "anv: Autogenerate extension query and lookup"
Signed-off-by: Tapani Pälli
---
src/intel/Android.vulkan.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/Android.vulkan.mk
Quoting Kenneth Graunke (2017-08-03 02:06:05)
> After a successful wait, we know the buffer ought to be idle.
I was sure this was already the case, because I keep looking at thinking
it needed a if (flags & MAP_WRITE) bo->idle = true...
Reviewed-by: Chris Wilson
The only caveat here is that bo
Other ones are either unsupported or don't have any helper
function checks.
v4: - drop ARB suffix for shader_group_vote/arb_shader_atomic_counter_ops
v3: - always add gl_BaseVertex & co when 460 is enabled
v2: - fix ARB_shader_draw_parameters system value names
Signed-off-by: Samuel Pitoiset
---
On 08/03/2017 02:44 AM, Ilia Mirkin wrote:
Can you go through all the others and work out the suffixes too? Just
going by memory, but the vote extension functions have suffixes, as do
the atomic counter ones, maybe there's other stuff too...
Yes... Hopefully, this time is the good one. :)
On 3 August 2017 at 09:57, Tapani Pälli wrote:
> Fixes build error with anv_extensions.c not found for
> libmesa_anv_entrypoints.
>
> Fixes: d62063c "anv: Autogenerate extension query and lookup"
> Signed-off-by: Tapani Pälli
Reviewed-by: Emil Velikov
-Emil
Quoting Kenneth Graunke (2017-08-02 21:43:33)
> I'm not so sure. Table 8.25 of the GL 4.4 compatibility spec (page 257),
> below glGetTexImage, shows this:
>
>++
>| Base Internal Format | R | G | B | A |
>+-
On 3 August 2017 at 03:23, Michel Dänzer wrote:
> On 03/08/17 03:39 AM, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra
>> gymnastics to detect it.
>>
>> Version 2.1.0 was released back in Mar 2012 and all major distributions
Hi Mauro,
Thanks for the series. I'll pull 2&3 in a second - there's a minor
suggestion in this patch.
On 3 August 2017 at 01:55, Mauro Rossi wrote:
> Android build changes to avoid the following building error:
>
> target C: libmesa_pipe_radeonsi <=
> external/mesa/src/gallium/drivers/radeons
On 3 August 2017 at 01:55, Mauro Rossi wrote:
> Android build changes to avoid the following building error:
>
> external/mesa/src/gallium/drivers/radeonsi/si_shader_nir.c:505:
> error: undefined reference to 'ac_nir_translate'
>
> Fixes: 86d4b46d66 "ac/common: always build NIR translation"
For 2/
On 08/01/2017 09:43 PM, Marek Olšák wrote:
There is an issue independent of this patch:
si_update_all_resident_texture_descriptors only updates resident
descriptors. Non-resident descriptors aren't updated, and
si_make_texture_handle_resident doesn't update them either. I think it
should be fi
On 08/01/2017 09:54 PM, Marek Olšák wrote:
Hi Samuel,
Can you move this slot allocator into a util module? It seems generic
enough that it could be reused for "handle" and "ID" allocations.
What do you mean by "ID" allocations?
Some additional notes:
- a bit array of uin32_t would be bett
On 2 August 2017 at 20:01, wrote:
> From: Zhongmin Wu
>
> Before we queued the buffer with a invalid fence (-1), it causes
> benchmarks such as flatland to fail. This patch enables explicit
> sync feature on android.
>
> Now we get the out fence during the flushing buffer and then pass
> it to S
2017-08-03 11:57 GMT+02:00 Emil Velikov :
> Hi Mauro,
>
> Thanks for the series. I'll pull 2&3 in a second - there's a minor
> suggestion in this patch.
>
> On 3 August 2017 at 01:55, Mauro Rossi wrote:
>> Android build changes to avoid the following building error:
>>
>> target C: libmesa_pipe_r
On 03.08.2017 04:09, Michel Dänzer wrote:
On 03/08/17 01:14 AM, Nicolai Hähnle wrote:
On 02.08.2017 18:04, Emil Velikov wrote:
On 2 August 2017 at 16:29, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create
functions")
Bugzilla: ht
On 02.08.2017 22:44, Jan Vesely wrote:
probably. The original changeset passes NULL(which is then
unconditionally accessed) at least in:
src/gallium/auxiliary/vl/vl_winsys_dri.c
src/gallium/auxiliary/vl/vl_winsys_dri3.c
src/gallium/auxiliary/vl/vl_winsys_drm.c
src/gallium/state_trackers/xa/xa_tr
Hi Gwan-gyeong Mun,
Thanks for sorting this out. Having a single copy instead of 3+ is always a win.
On 2 August 2017 at 10:23, Gwan-gyeong Mun wrote:
> platform_drm, platform_wayland and platform_android have similiar local buffer
> allocation routines. For deduplicating, it unifies dri2_egl_su
Emil,
> -Original Message-
> From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
> Sent: Thursday, August 3, 2017 4:06 PM
> To: Marathe, Yogesh
> Cc: ML mesa-dev ; Wu, Zhongmin
>
> Subject: Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync
> fence
> for Android OS
>
> O
Thanks for doing this. For the series:
Reviewed-by: Nicolai Hähnle
On 02.08.2017 20:39, Emil Velikov wrote:
From: Emil Velikov
Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra
gymnastics to detect it.
Version 2.1.0 was released back in Mar 2012 and all major distribu
From: Nicolai Hähnle
Missed updating this caller of pipe_loader_find_module.
Fixes: 0d7d60b7ea ("pipe-loader: pass only the driver_name to
pipe_loader_find_module")
---
src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ga
From: Nicolai Hähnle
The config passed into the screen should be independent from the state
tracker, because at least in the case of radeonsi, the screen structure
can be shared between different state trackers.
Incidentally, this also fixes crashes that were recently introduced.
Fixes: a35a9e7
From: Nicolai Hähnle
They were set only by the DRI state tracker, which is problematic
when radeonsi is used with different state trackers in the same
process.
Also, we don't need them anymore.
---
src/gallium/include/pipe/p_defines.h| 6 --
src/gallium/include/pipe/p_screen.h
From: Nicolai Hähnle
Also, access the options directly, allowing us to get rid of the
PIPE_SCREEN_xxx flags.
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.c | 9 ++---
src/gallium/drivers/radeon/r600_pipe_common.h | 2 +-
src/gallium
On Thu, Aug 3, 2017 at 10:11 PM, Marathe, Yogesh
wrote:
> Emil,
>
>> -Original Message-
>> From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
>> Sent: Thursday, August 3, 2017 4:06 PM
>> To: Marathe, Yogesh
>> Cc: ML mesa-dev ; Wu, Zhongmin
>>
>> Subject: Re: [Mesa-dev] [PATCH v5 2/2]
I was a bit confused by this at first but I think I understand it. Just to
clarify, this isn't actually dropping support for any version of expat,
it's just dropping support for automatic detection without a pkg-config
file, which coincidentally started shipping in 2.1.0. But it's not like
there'
We already do this as a side-effect of intel_miptree_create_for_dri_image.
Also, in the new world of modifiers, the usage flags don't get set.
On August 3, 2017 1:48:01 AM Chris Wilson wrote:
Ensure that any buffer allocated for a scanout image is kept out of the
CPU/LLC cache so as to avoi
On August 3, 2017 1:02:53 AM Tapani Pälli wrote:
Aux usage is ISL_AUX_USAGE_NONE when miptree is set shareable
within (intel_miptree_make_shareable).
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925
---
src/mesa/drivers/dri/i965/brw_blorp.c | 4
On 3 August 2017 at 14:58, Chuck Atkins wrote:
> I was a bit confused by this at first but I think I understand it. Just to
> clarify, this isn't actually dropping support for any version of expat, it's
> just dropping support for automatic detection without a pkg-config file,
> which coincidenta
> So if
> > you did happen to have an older expat version that you manually created a
> > .pc file for, then things should build and work just fine, barring of
> course
> > any expat bugs from untested older versions. Do I have that right?
> >
> Right - the version and .pc is more of a happy coinc
Need to take the sample count into account in the depth decompress and
resummarize pipelines and render pass.
Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver")
Signed-off-by: Alex Smith
Cc: "17.2"
---
Possibly a little late, but I'd really like to get this into 17.2 if
p
Hi,
What prompted me to dig into this was that we didn't seem the decode
the ImmediateData field of MI_STORE_DATA_IMM properly. The fix for
this is in patch 6. I also found out that we were skipping printing
some dword with fields > 32bits.
Cheers,
Lionel Landwerlin (7):
intel: decoder: build
For example, we were skipping Dword 3 in this PIPE_CONTROL :
0x000ce130: 0x7a04: PIPE_CONTROL
DWord Length: 4
0x000ce134: 0x0010 : Dword 1
Flush LLC: false
Destination Address Type: 0 (PPGTT)
LRI Post Sync Operation: 0 (No LRI Operation)
Store Data Index: 0
Comma
The xml files don't always have fields in order. This might confuse
our parsing of the commands. Let's have the fields in order. To do
this, the easiest way it to use a linked list. It also helps a bit
with the iterator.
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 52 ++
We used to print invalid data when the last field what clamped to
32bits due to Dword Length of the whole instruction :
0x000ce0b4: 0x1002: MI_STORE_DATA_IMM
0x000ce0b4: 0x1002 : Dword 0
DWord Length: 2
Store Qword: 0
Use Global GTT: false
0x000ce0b8: 0x00045010 : Dword 1
Due to the new way we handle fields, we need *not* to forget the first
field when decoding instructions. The issue was that the advance
function was called first and skipped the first field.
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 31 +--
This should be inside the function that actually decodes fields.
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index a30b7f28aab..9cd
Making the next change more readable.
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index e32d4190235..a30b7f28
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 48d4456cc16..2c4eaab1701 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubin
Hi, Michel.
Thanks for doing this. Was there a follow-up st/mesa fix to this. I
remember someone posting about a problem about the new backbuffer always
being NULL?
/Thomas
On 07/07/2017 05:29 AM, Michel Dänzer wrote:
From: Thomas Hellstrom
If the application hasn't done any drawing sin
On 3 August 2017 at 13:24, Mauro Rossi wrote:
> 2017-08-03 11:57 GMT+02:00 Emil Velikov :
>> Hi Mauro,
>>
>> Thanks for the series. I'll pull 2&3 in a second - there's a minor
>> suggestion in this patch.
>>
>> On 3 August 2017 at 01:55, Mauro Rossi wrote:
>>> Android build changes to avoid the f
Quoting Jason Ekstrand (2017-08-03 15:04:42)
> We already do this as a side-effect of intel_miptree_create_for_dri_image.
Hmm, really? It certainly isn't being applied as glamor is using the bo->map_cpu
for linear_to_tiled() uploads. Which is bad.
Currently only external bo are marked as incohe
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/.gitignore b/src/intel/vulkan/.gitignore
index 725a8584624..4ea978d6e41 100644
--- a/src/intel/vulkan/.gitignore
+++ b/src/intel/vulkan/.gitignore
@@ -1,4 +1,5 @@
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl_format_layout.csv | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index f340e30a1bf..150c15220eb 100644
--- a/src/intel/isl/isl_format_layout.csv
+++ b/src/int
Rb
On August 3, 2017 8:02:31 AM Lionel Landwerlin
wrote:
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/.gitignore b/src/intel/vulkan/.gitignore
index 725a8584624..4ea978d6e41 100644
--- a/src/intel/vul
>
> On Aug 2, 2017, at 10:30 PM, Brian Paul wrote:
>
> I'll let Charmaine review, but the subject line prefix should probably be
> "st/osmesa".
Thanks, I'll clarify the subject line on commit.
> -Brian
>
> On 08/02/2017 05:28 PM, Bruce Cherniak wrote:
>> Commit bbc29393d3 didn't include osme
2017-08-03 16:52 GMT+02:00 Emil Velikov :
> On 3 August 2017 at 13:24, Mauro Rossi wrote:
>> 2017-08-03 11:57 GMT+02:00 Emil Velikov :
>>> Hi Mauro,
>>>
>>> Thanks for the series. I'll pull 2&3 in a second - there's a minor
>>> suggestion in this patch.
>>>
>>> On 3 August 2017 at 01:55, Mauro Ros
https://bugs.freedesktop.org/show_bug.cgi?id=102017
--- Comment #8 from Marcin Gałązka ---
@Kenneth UNITY_DISABLE_GRAPHICS_DRIVER_WORKAROUNDS=yes didn't help
unfortunately. (I tried it before IIRC).
@MWATTT R600_DEBUG=nosb didn't change anything as well.
@Gert The game requires Steam, so I cann
Running Android on top of Mesa has exposed an issue with the
GALLIUM_HUD where we get the HUD graphs rendered to each of the
surfaces that Android is working with, so there is one with the top
bar, one with the bottom bar, one with the main surface, and even one
with popups.
I'm looking to get som
The make_shareable function deletes the aux buffer and then whacks
aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear.
Since we only look at supports_fast_clear to decide whether or not to do
fast clears, this was causing assertion failures.
Reported-by: Tapani Pälli
Bugzilla:
On Thu, 2017-08-03 at 00:28 -0500, Aaron Watry wrote:
> /
>
> On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote:
> > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
> > > Fixes: OpenCL CTS test/conformance/buffers/buffer_copy
> >
> > Similar patch was pushed in 2013:
> > 56647c5d8f8e60269f
Adding folks who were CCed for earlier versions.
Hi Emil, few doubts and comments below.
> -Original Message-
> From: Tomasz Figa [mailto:tf...@chromium.org]
> Sent: Thursday, August 3, 2017 7:19 PM
> To: Marathe, Yogesh
> Cc: Emil Velikov ; Antognolli, Rafael
> ; ML mesa-dev d...@lists
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:27, Jason Ekstrand wrote:
> We were calculating the total height of 2D surfaces by multiplying the
> row pitch by the number of slices. This means that we actually request
> slightly more space than actually needed since the padding on the last
> sl
subect: form => from
Commit message? Why is this being removed?
On 2017-08-02 13:35:29, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:30, Jason Ekstrand wrote:
> We rename it to intel_miptree_supports_mcs and make the function
> signature match intel_miptree_supports_ccs/hiz. We also move the sample
> count check into the function so it returns false for single-sampled
> surfaces.
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:31, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 ++---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ---
> 2 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/i
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:32, Jason Ekstrand wrote:
> The flag hasn't affected actual surface layout for some time. The only
> purpose it served was to set bo->cache_coherent = false on the BO used
> to create the miptree. This is fairly silly because we can just set
> that
Maybe add reference to bf24c3539e4b6989512968cae12da2f88d2c53e9 where
is was removed?
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:34, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/src/mesa/drivers/dri
On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset
wrote:
> Other ones are either unsupported or don't have any helper
> function checks.
>
> v4: - drop ARB suffix for shader_group_vote/arb_shader_atomic_counter_ops
> v3: - always add gl_BaseVertex & co when 460 is enabled
> v2: - fix ARB_shader_draw
Commit 0ab04ba979b7 (anv: Use python to generate ICD json files) changed
the way ICD json files are created.
Remove the old .in files from extra dist, and add the python script.
---
src/intel/Makefile.vulkan.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/Makefi
---
src/gallium/drivers/radeonsi/Makefile.sources | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeonsi/Makefile.sources
b/src/gallium/drivers/radeonsi/Makefile.sources
index 6dc6da04e3..74df4d7b67 100644
--- a/src/gallium/drivers/radeonsi/Makefile.sources
+++ b/src/gal
---
src/util/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/Makefile.am b/src/util/Makefile.am
index fa6551eaa5..a8352a9053 100644
--- a/src/util/Makefile.am
+++ b/src/util/Makefile.am
@@ -70,6 +70,7 @@ CLEANFILES = $(BUILT_SOURCES)
EXTRA_DIST = \
drirc \
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:35, Jason Ekstrand wrote:
> The only force tiling flag we really care about is LAYOUT_TILING_NONE.
> The others don't actually do anything but add confusion.
> ---
> src/mesa/drivers/dri/i965/intel_fbo.c | 3 +--
> src/mesa/drivers/dri/i96
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Bug ID: 102030
Summary: private memory overflow in openCL
Product: Mesa
Version: 17.2
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: norm
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Janpieter Sollie changed:
What|Removed |Added
CC||janpieter.sol...@dommel.be
--
You a
On Fri, 2017-04-28 at 14:15 +0200, Nicolai Hähnle wrote:
> On 28.04.2017 13:08, Eric Engestrom wrote:
> > Hi,
> >
> > I'm currently running llvm r299777 but I have no idea when this was
> > changed.
>
> Yeah, you'll just have to upgrade LLVM (or downgrade to LLVM 4.0).
> This
> sort of thing unf
On Thu, Aug 3, 2017 at 10:22 AM, Jordan Justen
wrote:
> subect: form => from
>
> Commit message? Why is this being removed?
>
See below...
> On 2017-08-02 13:35:29, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++-
> > 1 file changed, 2 insertio
In Mesa we use the convention that if gl_renderbuffer::NumSamples
or gl_texture_image::NumSamples is zero, it's a non-MSAA surface.
Otherwise, it's an MSAA surface. But in gallium nr_samples=1 is a
non-MSAA surface.
Before, if the user called glRenderbufferStorageMultisample() or
glTexImage2DMult
On Thu, Aug 3, 2017 at 10:32 AM, Jordan Justen
wrote:
> Maybe add reference to bf24c3539e4b6989512968cae12da2f88d2c53e9 where
> is was removed?
>
Done.
> Reviewed-by: Jordan Justen
>
> On 2017-08-02 13:35:34, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5
https://bugs.freedesktop.org/show_bug.cgi?id=102030
--- Comment #1 from Janpieter Sollie ---
Created attachment 133230
--> https://bugs.freedesktop.org/attachment.cgi?id=133230&action=edit
clover dump files
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are th
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:36, Jason Ekstrand wrote:
> The only one of the three remaining flags that has anything whatsoever
> to do with layout is TILING_NONE. This commit renames them to
> MIPTREE_CREATE_*, documents the meaning of each flag, and makes the
> create functio
https://bugs.freedesktop.org/show_bug.cgi?id=102030
--- Comment #2 from Janpieter Sollie ---
fyi: I ran the program through oclgrind, this reports no problems ...
I ran the program with pocl, there's no problem there,
I ran the program with amdgpu-pro, no problem either
--
You are receiving thi
https://bugs.freedesktop.org/show_bug.cgi?id=101952
Janpieter Sollie changed:
What|Removed |Added
See Also||https://bugs.freedesktop.or
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Janpieter Sollie changed:
What|Removed |Added
See Also||https://bugs.freedesktop.or
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c | 8
src/glx/dri_common.c| 52 -
src/glx/dri_common.h| 5 +
src/glx/drisw_glx.c | 3 +++
src/glx/glxclient.h | 6 ++
src/glx/glxextensions.c |
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 55 ---
src/gallium/state_trackers/glx/xlib/xm_api.c | 6 ++-
src/gallium/state_trackers/glx/xlib/xm_api.h | 4 +-
3 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx
Hi,
there also is a patch needed to make this work for Xorg on the
xorg-devel list as well as preliminary piglit test to verify the
functionality on the piglit list.
Grigori
On 2017-08-03 20:07, Grigori Goronzy wrote:
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c |
From: Emil Velikov
If we get a xfixes v1.x we'll error out, without freeing the
xfixes_query reply.
Cc:
Signed-off-by: Emil Velikov
---
I don't feel that strongly about having this in stable, but meh.
---
src/egl/drivers/dri2/platform_x11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
From: Emil Velikov
Introduced back in 2010 with dri2proto v2.3 and Xserver 1.9
A look through the drivers indicate that only xf86-video-ati running
a kernel older than 2.6.35 or xf86-video-freedreno using kgsl (does it
work with EGL to begin with?) may be hitting this old codepath.
Other driver
From: Emil Velikov
Back in 2012 (commit 1e7776ca2bc - egl: Remove bogus invalidate code.)
the loader use of invalidate() was purged as "bogus". One of the factors
defining that statement was the lack of the loader-side invalidate
extension - __DRI_USE_INVALIDATE.
Since then the commit was revert
From: Emil Velikov
XXX: commit message
XXX: keep it inline or move to egl_dri2.c
XXX: fold createwithmodifiers - now or as follow-up
Cc: Daniel Stone
Signed-off-by: Emil Velikov
---
Dan do you think it's a wise move to have this as a helper which tries
the withmodifiers call first and falls ba
From: Emil Velikov
Both are always true, so there's no point in keeping them around.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.h | 2 --
src/egl/drivers/dri2/platform_x11.c | 14 ++
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/egl/dri
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 2 +-
src/egl/drivers/dri2/platform_x11_dri3.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index 66
From: Emil Velikov
Having two callbacks to manage a single int seems like an overkill.
Use a cached copy and update that when needed.
Signed-off-by: Emil Velikov
---
Might want to look if the dimensions dance in .query_surface ...
speaking of which close to nobody implements that ...
---
src/e
From: Emil Velikov
The current two implementations - X11 and Wayland were identical,
barrind the upper limit.
Instead of having same code twice - introduce a helper and pass the
limit as an argument.
Thus as Android/DRM/others get support - they only need to call the
function ;-)
Signed-off-by
From: Emil Velikov
Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE")
Cc: Timothy Arceri
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11
From: Emil Velikov
The basic (null) check is identical across all backends.
Just move it to the top.
Note that eglCreateWindowSurface* already has a guard in the *Common
helper.
Cc: Eric Engestrom
Signed-off-by: Emil Velikov
---
Eric, the X11 hunk was changed/introduced by Frank with commit
2
From: Emil Velikov
The function can be called only when the type is EGL_WINDOW_BIT.
Remove the unneeded switch statement.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_drm.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/src/egl/driver
Simply the function a bit and add a comment explaining why we don't
simply destroy any buffer.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/s
On Thu, Aug 3, 2017 at 11:12 AM, Mauro Rossi wrote:
> 2017-08-03 16:52 GMT+02:00 Emil Velikov :
>> On 3 August 2017 at 13:24, Mauro Rossi wrote:
>>> 2017-08-03 11:57 GMT+02:00 Emil Velikov :
Hi Mauro,
Thanks for the series. I'll pull 2&3 in a second - there's a minor
suggestio
The v4 version of the patch that was committed still has regressed build
for me.
Reverting and applying v2 still builds OK.
I now get -
Making all in targets/opencl
make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/opencl'
CXXLDlibOpenCL.la
../../../../src/util/.libs/l
Emil Velikov writes:
> From: Emil Velikov
>
> Back in 2012 (commit 1e7776ca2bc - egl: Remove bogus invalidate code.)
> the loader use of invalidate() was purged as "bogus". One of the factors
> defining that statement was the lack of the loader-side invalidate
> extension - __DRI_USE_INVALIDATE.
1 - 100 of 172 matches
Mail list logo
