Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-05 8:57 GMT+02:00 Robert Foss : > Add local strlcpy implementation. > > Signed-off-by: Robert Foss > --- > Changes since v5: > Actually include changes from v5 in patch > > Changes since v4: > Gustaw Smolarczyk >- Make util_strlcpy have the same behaviour as strlcpy > > Changes si

Re: [Mesa-dev] [PATCH 2/4] i965: Use I915_EXEC_NO_RELOC

On Mon, Jun 19, 2017 at 08:53:33PM +0100, Chris Wilson wrote: > Quoting Kenneth Graunke (2017-06-19 20:28:31) > > On Monday, June 19, 2017 3:06:48 AM PDT Chris Wilson wrote: > > > - if (target != batch->bo) > > > - add_exec_bo(batch, target); > > > + if (target != batch->bo) { > > > +

[Mesa-dev] [PATCH v2 02/73] nir: fix nir_lower_wpos_ytransform when gl_FragCoord is a system value

From: Nicolai Hähnle --- src/compiler/nir/nir_lower_wpos_ytransform.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_wpos_ytransform.c b/src/compiler/nir/nir_lower_wpos_ytransform.c index 873d259..771c6ff 100644 --- a/src/compiler/nir/nir_lo

[Mesa-dev] [PATCH v2 03/73] nir: add load_frag_coord system value intrinsic

From: Nicolai Hähnle Some drivers prefer to treat gl_FragCoord as a system value rather than a fragment shader input, see Const.GLSLFragCoordIsSysVal. --- src/compiler/nir/nir.c | 4 src/compiler/nir/nir_gather_info.c | 1 + src/compiler/nir/nir_intrinsics.h | 1 + 3 files chan

[Mesa-dev] [PATCH v2 00/73] Experimental NIR backend for radeonsi

From: Nicolai Hähnle Hi all, Here's an updated version of the NIR backend series. Most of the comments have been integrated, and where they haven't been fully integrated, I think they could be addressed as a follow-up. The series has become shorter, since Dave pulled several of the ac/nir chang

[Mesa-dev] [PATCH v2 04/73] nir: add nir_lower_samplers_as_deref pass

From: Nicolai Hähnle This pass is a replacement for the nir_lower_samplers pass, which has the advantage of keeping sampler references as derefs. This allows a unified treatment of texture instructions and image intrinsics in the backend. --- src/compiler/Makefile.sources | 1

[Mesa-dev] [PATCH v2 06/73] gallium: add PIPE_CAP_NIR_SAMPLERS_AS_DEREF

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/

[Mesa-dev] [PATCH v2 01/73] nir: add nir_instr_rewrite_deref

From: Nicolai Hähnle Allows modifying a texture instruction's texture and sampler derefs. --- src/compiler/nir/nir.c | 13 + src/compiler/nir/nir.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 491b908..f81f4ee 100644 -

[Mesa-dev] [PATCH v2 13/73] ac, radeonsi: move some VS input descriptions to ac_shader_abi

From: Nicolai Hähnle v2: use LLVM values instead of function parameter indices Reviewed-by: Marek Olšák (v1) --- src/amd/common/ac_shader_abi.h| 40 +++ src/gallium/drivers/radeonsi/si_shader.c | 60 +-- src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH v2 12/73] radeonsi: store shader function arguments in a structure

From: Nicolai Hähnle Aligns the code a bit more with ac/nir, and simplifies the setup of ac_shader_abi. --- src/gallium/drivers/radeonsi/si_shader.c | 618 --- 1 file changed, 320 insertions(+), 298 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH v2 05/73] nir: add nir_lower_uniforms_to_ubo pass

From: Nicolai Hähnle This is a further lowering of default-block uniform loads that transforms load_uniform intrinsics into load_ubo intrinsics. This simplies the rest of the backend. v2: transform from load_uniform instead of straight from variables --- src/compiler/Makefile.sources

[Mesa-dev] [PATCH v2 09/73] st/mesa: get rid of st_glsl_types

From: Nicolai Hähnle It's a duplicate of glsl_type::count_attribute_slots. --- src/compiler/glsl_types.cpp | 4 +- src/gallium/drivers/freedreno/ir3/ir3_cmdline.c | 15 ++-- src/gallium/drivers/freedreno/ir3/ir3_shader.c | 6 ++ src/gallium/drivers/freedreno/ir3/ir3_sha

[Mesa-dev] [PATCH v2 08/73] st/glsl_to_nir: use nir_lower_samplers_as_deref when requested by the driver

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 5c4ae81..c8a7464 100644 --- a/src/me

[Mesa-dev] [PATCH v2 11/73] gallium/targets: link against NIR when building radeonsi

From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/Automake.inc | 3 +++ src/gallium/targets/d3dadapter9/Makefile.am | 1 + src/gallium/targets/omx/Makefile.am | 1 + src/gallium/targets/va/Makefile.am | 1 + src/gallium/targets/vdpau/Makefile.am

[Mesa-dev] [PATCH v2 07/73] st/glsl_to_nir: fix the case where NIR clone testing is enabled

From: Nicolai Hähnle In that case, prog->nir must be assigned at the end. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 89f7888..5c4a

[Mesa-dev] [PATCH v2 10/73] st/glsl_to_nir: move nir_lower_io to drivers

From: Nicolai Hähnle This allows drivers more freedom in how exactly they want to lower I/O, e.g. first lowering I/O to temporaries. --- src/gallium/drivers/freedreno/ir3/ir3_shader.c | 6 ++ src/gallium/drivers/vc4/vc4_program.c | 3 +++ src/mesa/state_tracker/st_glsl_to_nir.cpp

[Mesa-dev] [PATCH v2 15/73] radeonsi: add nir include paths

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/Makefile.am b/src/gallium/drivers/radeonsi/Makefile.am index 2d5c1a3..1edbd0f 100644 --- a/src/gallium/drivers/radeonsi/Makefile.am +++ b/src/galliu

[Mesa-dev] [PATCH v2 17/73] radeonsi: add si_shader_selector::nir

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/si_shader.h index a10067d..6de7b69 100644 --- a/src/gallium/drivers/radeonsi/si_shader.h +++ b/src/gal

[Mesa-dev] [PATCH v2 14/73] ac/nir: start using ac_shader_abi

From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e72747a..40d

[Mesa-dev] [PATCH v2 19/73] ac/nir: add ac_shader_abi::inputs

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 2 ++ src/amd/common/ac_shader_abi.h | 7 +++ 2 files changed, 9 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1b65368..1ef7460 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b

[Mesa-dev] [PATCH v2 16/73] radeonsi: implement pipe_screen::get_compiler_options for NIR

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_pipe.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 00cd211..beadb88 100644 --- a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH v2 21/73] radeonsi: bypass the shader cache for NIR shaders

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 875c337..df7ccb9 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH v2 20/73] radeonsi: scan NIR shaders to obtain required info

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/Makefile.sources | 1 + src/gallium/drivers/radeonsi/si_shader.c| 1 + src/gallium/drivers/radeonsi/si_shader.h| 4 + src/gallium/drivers/radeonsi/si_shader_nir.c| 312 src/gallium/drivers/

[Mesa-dev] [PATCH v2 22/73] radeonsi: dump NIR instead of TGSI when appropriate

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 5ff16f5..2340b20 100644 --- a/src/gallium/drivers/radeonsi/si_shad

[Mesa-dev] [PATCH v2 18/73] ac/nir: begin splitting off ac_nir_context

From: Nicolai Hähnle The eventual goal is to hide all radv-specific details behind ac_nir_context::abi, so that the NIR->LLVM code can be re-used by radeonsi. During development, we live with a partial split, where some of the NIR->LLVM code still relies on linking back to the nir_to_llvm_contex

[Mesa-dev] [PATCH v2 23/73] radeonsi: translate NIR to LLVM

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.h | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 13 ++--- src/gallium/drivers/radeonsi/si_shader_internal.h | 2 ++ src/gallium/drivers/radeonsi/si_shader_nir.c | 9 + 4 files changed,

[Mesa-dev] [PATCH v2 25/73] ac, radeonsi: add ac_shader_abi::emit_outputs for hardware VS shaders

From: Nicolai Hähnle --- src/amd/common/ac_shader_abi.h| 4 +++ src/gallium/drivers/radeonsi/si_shader.c | 37 --- src/gallium/drivers/radeonsi/si_shader_internal.h | 7 + 3 files changed, 37 insertions(+), 11 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH v2 26/73] ac/nir: use ac_shader_abi::emit_outputs

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1ef7460..9456b8d 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/commo

[Mesa-dev] [PATCH v2 24/73] radeonsi: pass si_shader_context to get_primitive_id

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 2d78967..0619c0f 100644 --- a/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH v2 27/73] ac/nir: pass ac_llvm_context to *build_alloca* helpers

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 9456b8d..d82e682 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/comm

[Mesa-dev] [PATCH v2 29/73] ac/nir: add ac_nir_context::main_function

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5f7a938..86ba27e 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -58,20 +5

[Mesa-dev] [PATCH v2 32/73] ac/nir: pass ac_nir_context to visit_{load, store}_var and get_deref_offset helper

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 152 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5463e44..d13d67e 100644 --- a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH v2 28/73] ac/nir: split scanning outputs from setting up output allocas

From: Nicolai Hähnle The scanning phase sets the driver_location, because it is part of the ABI: radeonsi does the assignment differently. --- src/amd/common/ac_nir_to_llvm.c | 51 ++--- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/src/amd/co

[Mesa-dev] [PATCH v2 34/73] ac/nir, radeonsi: add ac_shader_abi::load_ubo

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 3 +++ src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 14 ++ 3 files changed, 19 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_l

[Mesa-dev] [PATCH v2 33/73] ac/nir: pass ac_nir_context to visit_load_ubo_buffer

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d13d67e..034b1c3 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common

[Mesa-dev] [PATCH v2 31/73] ac/nir: pass ac_llvm_context to some helper functions

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 727c248..5463e44 100644 --- a/src/amd/common/ac_nir_to_l

[Mesa-dev] [PATCH v2 30/73] ac/nir: pass ac_nir_context to visit_intrinsic

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 104 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 86ba27e..727c248 100644 --- a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH v2 35/73] radeonsi/nir: load VS inputs

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 11 -- src/gallium/drivers/radeonsi/si_shader_internal.h | 5 + src/gallium/drivers/radeonsi/si_shader_nir.c | 26 +++ 3 files changed, 40 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 36/73] radeonsi/nir: load FS inputs

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 31 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 4 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 28 +++- 3 files changed, 52 insertions(+), 11 deletions(-) di

[Mesa-dev] [PATCH v2 38/73] ac/nir, radeonsi: add ac_shader_abi::chip_class

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 1 + src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 4f3ed2

[Mesa-dev] [PATCH v2 37/73] radeonsi/nir: emit FS outputs

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e90d25c..2b030c0 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH v2 39/73] ac/nir: pass ac_nir_context to visit_tex and various related functions

From: Nicolai Hähnle Get most of the churn out of the way before actually loading samplers via the ABI. --- src/amd/common/ac_nir_to_llvm.c | 235 1 file changed, 118 insertions(+), 117 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/

[Mesa-dev] [PATCH v2 43/73] radeonsi/nir: set si_shader_context::num_{sampler, images}

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 91796a8..a278ef2 100644 --- a/src/gallium/drivers/radeonsi/si_shader_n

[Mesa-dev] [PATCH v2 44/73] ac/nir: add support for arrays-of-arrays to get_sampler_desc

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 823b18f..62131ca 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/

[Mesa-dev] [PATCH v2 45/73] ac/nir: add image and write parameter to ac_shader_abi::load_sampler_desc

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 43 src/amd/common/ac_shader_abi.h | 4 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +- 3 files changed, 30 insertions(+), 20 deletions(-) diff --git a/src/amd/common/ac

[Mesa-dev] [PATCH v2 46/73] radeonsi/nir: add image descriptor loading

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 15 +++ src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 22 ++ 3 files changed, 32 insertions(+), 8 deletions(-) diff --gi

[Mesa-dev] [PATCH v2 40/73] ac/nir: add and use ac_shader_abi::load_sampler_desc

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 108 ++-- src/amd/common/ac_shader_abi.h | 24 + 2 files changed, 84 insertions(+), 48 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 464d8

[Mesa-dev] [PATCH v2 47/73] ac/nir: move setting shader_info->fs.writes_memory to radv-specific code

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5d7f53e..301cb83 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_

[Mesa-dev] [PATCH v2 41/73] ac/nir: pass ac_nir_context to tex_fetch_ptrs and related functions

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 155 +--- 1 file changed, 81 insertions(+), 74 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b8d9296..823b18f 100644 --- a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH v2 42/73] radeonsi/nir: implement ac_shader_abi::load_sampler_desc

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_internal.h | 4 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 32 +++ src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 26 +- 3 files changed, 49 insertions(+), 13 deletions(-) diff

[Mesa-dev] [PATCH v2 54/73] ac/nir: pass ac_nir_context to emit_discard_if

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d20b0fa..bb314cb 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common

[Mesa-dev] [PATCH v2 51/73] radeonsi/nir: perform lowering of input/output driver locations

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_shader_nir.c| 26 + src/gallium/drivers/radeonsi/si_state_shaders.c | 2 ++ 3 files changed, 29 insertions(+) diff --git a/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH v2 52/73] radeonsi/nir: perform radeonsi-specific lowering and optimization passes

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 41 1 file changed, 41 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index dc2ef8b..83c7ab1 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH v2 50/73] ac/nir: handle old-style shadow tex instructions correctly

From: Nicolai Hähnle The first element is only extracted for new-style shadow tex. --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 158d183..16729a8 100644 --- a/src/

[Mesa-dev] [PATCH v2 55/73] ac/nir: load buffer descriptors via ac_shader_abi::load_ssbo

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 28 src/amd/common/ac_shader_abi.h | 10 ++ 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index bb314cb..78de557 10

[Mesa-dev] [PATCH v2 48/73] ac/nir: use shader_info pass to determine whether instance_id is used

From: Nicolai Hähnle This improves the separation of ABI and NIR translation. --- src/amd/common/ac_nir_to_llvm.c | 7 +-- src/amd/common/ac_shader_info.c | 3 +++ src/amd/common/ac_shader_info.h | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_l

[Mesa-dev] [PATCH v2 53/73] ac/nir: extract shader_info->fs.can_discard from NIR shader info

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 16729a8..d20b0fa 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_ll

[Mesa-dev] [PATCH v2 49/73] ac/nir: whitespace fixes

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e5f28f2..158d183 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH v2 58/73] ac/nir: pass ac_nir_context to SSBO intrinsic handlers

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 114 +--- 1 file changed, 59 insertions(+), 55 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 78de557..ef1eeac 100644 --- a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH v2 57/73] radeonsi: implement and use ac_shader_abi::load_ssbo

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 16 src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 15 --- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drive

[Mesa-dev] [PATCH v2 56/73] radeonsi: make get_indirect_index globally visible

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeo

[Mesa-dev] [PATCH v2 60/73] ac/nir, radeonsi: add ac_shader_abi::front_face

From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 16 3 files changed, 15 insertions(+), 7 deletions(-) diff --g

[Mesa-dev] [PATCH v2 59/73] ac/nir: pass ac_nir_context to emit_ddxy

From: Nicolai Hähnle Allocating the ddxy_lds is considered to be part of the API shader translation and not part of the ABI. --- src/amd/common/ac_nir_to_llvm.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/s

[Mesa-dev] [PATCH v2 61/73] ac/nir: add always_vector argument to ac_build_gather_values_extended

From: Nicolai Hähnle This simplifies a bunch of places that no longer need special treatment of value_count == 1. We rely on LLVM to optimize away the 1-element vector types. This fixes a bunch of bugs where 1-element arrays are indexed indirectly. --- src/amd/common/ac_llvm_build.c | 7 -

[Mesa-dev] [PATCH v2 62/73] ac/nir: clamp shadow texture comparison value on VI

From: Nicolai Hähnle Needed for TC-compatible HTILE in radeonsi for test cases like piglit spec/arb_texture_rg/execution/fs-shadow2d-red-01.shader_test --- src/amd/common/ac_nir_to_llvm.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH v2 65/73] ac/nir, radv: move force_persample to ac_shader_info::force_persample

From: Nicolai Hähnle Avoid accessing radv-specific structures during the meat of NIR-to-LLVM translation. --- src/amd/common/ac_nir_to_llvm.c | 4 +--- src/amd/common/ac_nir_to_llvm.h | 1 - src/amd/common/ac_shader_info.c | 6 ++ src/amd/common/ac_shader_info.h | 1 + src/amd/vulkan/rad

[Mesa-dev] [PATCH v2 66/73] ac/nir, radeonsi: add and use ac_shader_abi::{ancillary, sample_coverage}

From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 10 -- src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 6 -- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a

[Mesa-dev] [PATCH v2 63/73] radeonsi: use new function ac_build_umin for edgeflag clamping

From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 7 +++ src/amd/common/ac_llvm_build.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_bu

[Mesa-dev] [PATCH v2 69/73] radeonsi/nir: lower txp instructions

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 83c7ab1..10b3630 100644 --- a/src/gallium/drivers/radeonsi/si_shader_n

[Mesa-dev] [PATCH v2 64/73] radeonsi: tweak next-shader assumptions when streamout is used

From: Nicolai Hähnle VS with streamout is always a HW VS. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c i

[Mesa-dev] [PATCH v2 67/73] ac/nir, radeonsi: add and use ac_shader_abi::frag_pos

From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 30 +- src/amd/common/ac_shader_abi.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 12 3 files changed, 26 insertions(+), 17

[Mesa-dev] [PATCH v2 68/73] ac/nir: pass ac_llvm_context to unpack_param

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f8eb0c9..9bb1904 100644 --- a/src/amd/common/ac_nir_to_llvm.

[Mesa-dev] [PATCH v2 70/73] ac/nir: implement load_frag_coord intrinsic

From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 9bb1904..5a972b7 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [PATCH v2 72/73] radeonsi: VS as ES/LS are not yet supported with R600_DEBUG=nir

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 7fa76cd..83db876 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gall

[Mesa-dev] [PATCH v2 73/73] radeonsi: enable R600_DEBUG=nir for vertex and fragment shaders

From: Nicolai Hähnle Also, disable geometry and tessellation shaders. Mixing and matching NIR and TGSI shaders should work (and I've tested it for the VS/PS interface), but geometry and tessellation requires VS-as-ES/LS, which isn't implemented yet for NIR. --- src/gallium/drivers/radeon/r600_pi

[Mesa-dev] [PATCH v2 71/73] radeonsi/nir: lower uniforms to UBO loads

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 10b3630..7de8b10 100644 --- a/src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH 5/6] radeonsi: use slot indexes for bindless handles

On 04.07.2017 15:05, Samuel Pitoiset wrote: Using VRAM address as bindless handles is not a good idea because we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize because it has no information about the pointer. Instead, use slots indexes like the existing descriptors. This improves

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

Thanks for doing the test. I did get the automated email. This stuff is mostly guess work and cargo-culting for me since I don't actually have an Android build setup. Is there any way for me to test this easily? How about the fixup at https://cgit.freedesktop.org/~nh/mesa/commit/?h=driconf?

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

On 5 July 2017 at 12:58, Nicolai Hähnle wrote: > Thanks for doing the test. I did get the automated email. > > This stuff is mostly guess work and cargo-culting for me since I don't > actually have an Android build setup. Is there any way for me to test this > easily? > > How about the fixup at >

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

On 05.07.2017 14:16, Emil Velikov wrote: On 5 July 2017 at 12:58, Nicolai Hähnle wrote: Thanks for doing the test. I did get the automated email. This stuff is mostly guess work and cargo-culting for me since I don't actually have an Android build setup. Is there any way for me to test this ea

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

On 5 July 2017 at 13:38, Nicolai Hähnle wrote: > On 05.07.2017 14:16, Emil Velikov wrote: >> >> On 5 July 2017 at 12:58, Nicolai Hähnle wrote: >>> >>> Thanks for doing the test. I did get the automated email. >>> >>> This stuff is mostly guess work and cargo-culting for me since I don't >>> actua

Re: [Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

Hi Nicolai, On 30 June 2017 at 13:45, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/drivers/dri/common/xmlconfig.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/common/xmlconfig.c > b/src/mesa/drivers/dri/common/xmlco

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

On 5 July 2017 at 13:53, Emil Velikov wrote: > On 5 July 2017 at 13:38, Nicolai Hähnle wrote: >> On 05.07.2017 14:16, Emil Velikov wrote: >>> >>> On 5 July 2017 at 12:58, Nicolai Hähnle wrote: Thanks for doing the test. I did get the automated email. This stuff is mostly gues

Re: [Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

On 5 July 2017 at 14:35, Emil Velikov wrote: > I think it matters too much here, I meant to say "I don't think it matters..." -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (master): st/mesa: use pipe_shader_type_from_mesa

On 07/05/2017 04:32 AM, Nicolai Hähnle wrote: Module: Mesa Branch: master Commit: 8a4cd79d0049f98d1c0aff7a77aca73647e3f647 URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D8a4cd79d0049f98d1c0aff7a77aca73647e3f647&d=DwIGaQ&c=uilaK90D4TOVoH5

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

On 07/05/2017 12:57 AM, Robert Foss wrote: Add local strlcpy implementation. Signed-off-by: Robert Foss --- Changes since v5: Actually include changes from v5 in patch Changes since v4: Gustaw Smolarczyk - Make util_strlcpy have the same behaviour as strlcpy Changes since v3: Ma

[Mesa-dev] [PATCH] intel: common: Fix link failure with standalone Android build

Some reshuffle in the Makefiles under src/intel resulted in Android libraries being no longer linked with code using src/intel/common/gen_debug.h that contains references to functions exported by those libraries (namely ALOGW macro, which is currently resolved into a call to __android_log_print() f

[Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

If dri2_setup_extensions() fails, the "err" variable would not be assigned causing the error path to access an unitialized variable. Fix it by assigning an error message. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") introduced CPU feature detection based Android cpufeatures library. Unfortunately it also added an assumption that if PIPE_OS_ANDROID is defined, the library is also available, which is not true for the standalone build without using An

Re: [Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

On 5 July 2017 15:57:10 BST, Tomasz Figa wrote: > If dri2_setup_extensions() fails, the "err" variable would not be > assigned > causing the error path to access an unitialized variable. Fix it by > assigning an error message. > > Signed-off-by: Tomasz Figa Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

On Jul 4, 2017, at 9:40 AM, Jose Fonseca mailto:jfons...@vmware.com>> wrote: On 29/06/17 11:02, Michel Dänzer wrote: On 29/06/17 01:54 AM, Cherniak, Bruce wrote: On Jun 26, 2017, at 2:10 PM, Marek Olšák mailto:mar...@gmail.com>> wrote: In my opinion, dumping resources isn't very useful. I thin

[Mesa-dev] [PATCH] st/mesa: find proper mipmap level in st_ClearTexSubImage()

The Piglit arb_clear_texture-error test creates a texture with only a 1x1 image at level=1, then tries to clear level 0 (non-existant) and level 1 (exists). The test only checks that the former generates an error but the later doesn't. The test passes, but when we try to clear the level=1 image w

Re: [Mesa-dev] [PATCH] st/mesa: find proper mipmap level in st_ClearTexSubImage()

Please ignore for now. I need to take a closer look at interaction with GL_ARB_texture_view... -Brian On 07/05/2017 10:31 AM, Brian Paul wrote: The Piglit arb_clear_texture-error test creates a texture with only a 1x1 image at level=1, then tries to clear level 0 (non-existant) and level 1

Re: [Mesa-dev] [PATCH] Android: generate symlinks for all enabled gallium drivers

On 1 July 2017 at 16:52, Mauro Rossi wrote: > Current post install command relies on GALLIUM_TARGET_DRIVERS variable, > however variable needs to be initialized in src/gallium/Android.mk > in order that all enabled gallium drivers symlinks are correctly generated. > > At the moment due to sorting

[Mesa-dev] [PATCH 0/3] anv: Use DRM sync objects for external semaphores when available

This tiny series makes us start using the new DRM syncobj API for external semaphores instead of the dma-buf hack. I'm hoping we can get this reviewed quickly because I'd like to land the kernel bits as soon as possible. Mesa branch: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=review/anv

[Mesa-dev] [PATCH 1/3] intel/drm: Pull in the i916 fence array API

--- src/intel/drm/i915_drm.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/src/intel/drm/i915_drm.h b/src/intel/drm/i915_drm.h index c26bf7c..338c8c2 100644 --- a/src/intel/drm/i915_drm.h +++ b/src/intel/drm/i915_drm.h @@ -431,6 +431,11 @@ type

[Mesa-dev] [PATCH 3/3] anv: Use DRM sync objects for external semaphores when available

--- src/intel/vulkan/anv_batch_chain.c | 56 +++ src/intel/vulkan/anv_device.c | 2 + src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_queue.c | 93 -- 4 files changed, 135 insertions(+), 24 deletions(-) diff --

[Mesa-dev] [PATCH 2/3] anv/gem: Add a drm syncobj support

--- src/intel/vulkan/anv_gem.c | 52 src/intel/vulkan/anv_gem_stubs.c | 24 +++ src/intel/vulkan/anv_private.h | 4 3 files changed, 80 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 5

Re: [Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

Hi Tomasz, On 5 July 2017 at 15:58, Tomasz Figa wrote: > Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") > introduced CPU feature detection based Android cpufeatures library. > Unfortunately it also added an assumption that if PIPE_OS_ANDROID is > defined, the library is also avail

Re: [Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

On 5 July 2017 at 16:08, Eric Engestrom wrote: > On 5 July 2017 15:57:10 BST, Tomasz Figa wrote: >> If dri2_setup_extensions() fails, the "err" variable would not be >> assigned >> causing the error path to access an unitialized variable. Fix it by >> assigning an error message. >> >> Signed-off-

  1   2   >