[Mesa-dev] [PATCH] anv: check support for enabled features in vkCreateDevice()

2017-06-30 Thread Samuel Iglesias Gonsálvez
From Vulkan spec, 4.2.1. "Device Creation": "vkCreateDevice verifies that extensions and features requested in the ppEnabledExtensionNames and pEnabledFeatures members of pCreateInfo, respectively, are supported by the implementation." Signed-off-by: Samuel Iglesias Gonsálvez --- I wrot

Re: [Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

2017-06-30 Thread Emil Velikov
On 29 June 2017 at 16:40, Robert Foss wrote: > On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote: >> On 28 June 2017 at 22:52, Robert Foss >> wrote: >> > From: Tomeu Vizoso >> > >> > Signed-off-by: Robert Foss >> > Reviewed-by: Tapani Pälli >> >> Fwiw >> Reviewed-by: Emil Velikov >> >> An

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 --- Comment #4 from Eero Tamminen --- If application is freeing the resources, but driver memory usage still grows unbounded due to deferred deletion, I'm not sure what else it could be described than leak... -- You are receiving this mail bec

Re: [Mesa-dev] [PATCH] anv: Advertise support for VK_FORMAT_R8_SRGB

2017-06-30 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 30/06/17 02:53, Jason Ekstrand wrote: Unreal Engine 4 seems to really like this format for some reason. We don't technically have the hardware format but we do have L8_SRGB. It's easy enough to fake with that and a swizzle. --- src/intel/vulkan/anv_formats.

Re: [Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

2017-06-30 Thread Christian Gmeiner
2017-06-30 9:39 GMT+02:00 Emil Velikov : > On 29 June 2017 at 16:40, Robert Foss wrote: >> On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote: >>> On 28 June 2017 at 22:52, Robert Foss >>> wrote: >>> > From: Tomeu Vizoso >>> > >>> > Signed-off-by: Robert Foss >>> > Reviewed-by: Tapani Pälli

[Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

2017-06-30 Thread Philipp Zabel
The smapi->get_egl_image() call in st_egl_image_get_surface() stores a reference to the EGLImage's texture in stimg.texture. That reference is released via pipe_resource_reference(&stimg.texture, NULL) before stimg goes out of scope at the end of the function, but not in the error path if !is_forma

Re: [Mesa-dev] [PATCH] anv: check support for enabled features in vkCreateDevice()

2017-06-30 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 30/06/17 07:59, Samuel Iglesias Gonsálvez wrote: From Vulkan spec, 4.2.1. "Device Creation": "vkCreateDevice verifies that extensions and features requested in the ppEnabledExtensionNames and pEnabledFeatures members of pCreateInfo, respectively, a

Re: [Mesa-dev] [PATCH] intel/compiler: Don't use opt_sampler_eot() optimization on gen10+

2017-06-30 Thread Lionel Landwerlin
Indeed, that's what the documentation says : Reviewed-by: Lionel Landwerlin On 27/06/17 23:51, Anuj Phogat wrote: This optimization has been removed on gen10+. Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

2017-06-30 Thread Thomas Hellstrom
On 06/29/2017 07:30 PM, Kristian Høgsberg wrote: On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom wrote: Hi! I was spending some time going through the GLX code to try to fix up the GLX_OML_swap_method extension implementation. I then stumbled across the fact that when we, for direct renderi

[Mesa-dev] [PATCH 1/2] ac/nir: Handle offset for atomics on shared memory

2017-06-30 Thread Alex Smith
Offset wasn't being added to the pointer, so for arrays the operation would always have been performed on the first array element. Signed-off-by: Alex Smith --- Applies on top of my earlier patch: https://lists.freedesktop.org/archives/mesa-dev/2017-June/161103.html --- src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH 2/2] ac/nir: Fix ordering of parameters for image atomic cmpswap intrinsics

2017-06-30 Thread Alex Smith
The NIR parameters are ordered "compare, data", matching GLSL, but both the image and buffer LLVM intrinsics take them the other way around. This is already handled correctly for SSBO atomics. Signed-off-by: Alex Smith --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-06-30 Thread Alex Smith
If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image view's descriptor was set to a 2D array (and a few other fields adjusted accordingly). This is correct when the image view is actually bound as a storage image, but not when bound as a sampled image. In that case the type shou

[Mesa-dev] [PATCH] docs: update HTTP -> HTTPS reference to reflect reality

2017-06-30 Thread Emil Velikov
From: Emil Velikov The link recently got updated to https. Signed-off-by: Emil Velikov --- docs/download.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/download.html b/docs/download.html index c68f4baea0a..6b2b60cd606 100644 --- a/docs/download.html +++ b/docs/do

[Mesa-dev] [PATCH 07/10] egl: check for extensions' presence during attr parsing

2017-06-30 Thread Emil Velikov
From: Emil Velikov If the respective extension is not supported, one should return EGL_BAD_PARAMETER as mentioned in earlier commits. Signed-off-by: Emil Velikov --- src/egl/main/eglimage.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/egl/main

[Mesa-dev] [PATCH 03/10] egl: split _eglParseImageAttribList into per extension functions

2017-06-30 Thread Emil Velikov
Will allow us to simplify existing code and make further improvements short and simple. No functional change intended. Signed-off-by: Emil Velikov --- Using git show -w to view the patch will make it easier to read. --- src/egl/main/eglimage.c | 446 -

[Mesa-dev] [PATCH 01/10] egl: move eglCreateDRMImageMESA's malloc later

2017-06-30 Thread Emil Velikov
From: Emil Velikov Don't bother allocating any memory until we're finished parsing and sanitising all the attributes. As a nice side effect we now consistently set eglError when any of the attrib/values are not correct. Strangely enough the spec does not mention _anything_ about what error shou

[Mesa-dev] [PATCH 04/10] egl: simplify EXT_image_dma_buf_import_modifiers attr parsing

2017-06-30 Thread Emil Velikov
From: Emil Velikov Move the common extension check at the top. Signed-off-by: Emil Velikov --- We could do fancier thing - like folding the 0..2 modifier case(s) yet that will lead to not-so-obvious-at-first idx calculation. Alternatively we could fold the lo/hi arrays into one but that'll mak

[Mesa-dev] [PATCH 02/10] egl: call _eglError within _eglParseImageAttribList

2017-06-30 Thread Emil Velikov
From: Emil Velikov As per EGL_KHR_image_base: If an attribute specified in is not one of the attributes listed in Table bbb, the error EGL_BAD_PARAMETER is generated. We should set the error as opposed to simply log it. Currently we have a partial solution, whereby only some of the c

[Mesa-dev] [PATCH 09/10] egl: enhance KHR_gl_image extensions checks

2017-06-30 Thread Emil Velikov
From: Emil Velikov Drop the (duplicate) top-level check in dri2_create_image_khr() and add the respective checks in dri2_create_image_khr_{texture,renderbuffer} Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 36 +--- 1 file changed, 21 inserti

[Mesa-dev] [PATCH 06/10] egl: add width/height as EXT_image_dma_buf_import attrs

2017-06-30 Thread Emil Velikov
From: Emil Velikov Although not listed amongst the initial EGL_LINUX_DRM_FOURCC_EXT and friends list, the spec reads ... Required attributes and their values are as follows: * EGL_WIDTH & EGL_HEIGHT: The logical dimensions of the buffer in pixels * EGL_LINUX_DRM_FOURCC_EXT: The p

[Mesa-dev] [PATCH 08/10] egl: don't set modifier if no modifiers are available

2017-06-30 Thread Emil Velikov
From: Emil Velikov If no modifiers are available, the variable will never be used. Thus there's no point in initialising it. Cc: Varad Gautam Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/

[Mesa-dev] [PATCH 10/10] egl: set KHR_gl_texture_3D_image only when the requirements are met.

2017-06-30 Thread Emil Velikov
From: Emil Velikov DRI_IMAGE's createImageFromTexture is used to implement the extension, so we should check for it prior to advertising. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/d

[Mesa-dev] [PATCH 05/10] egl: polish EXT_image_dma_buf_import attr parsing

2017-06-30 Thread Emil Velikov
From: Emil Velikov Simplify the existing if/else + temporary variable into if (foo) return X. Signed-off-by: Emil Velikov --- src/egl/main/eglimage.c | 51 + 1 file changed, 22 insertions(+), 29 deletions(-) diff --git a/src/egl/main/eglimage.c

[Mesa-dev] [PATCH] automake: include git_sha1_gen.sh into EXTRA_DIST

2017-06-30 Thread Juan A. Suarez Romero
--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index fee132e..d1eadee 100644 --- a/Makefile.am +++ b/Makefile.am @@ -53,6 +53,7 @@ EXTRA_DIST = \ common.py \ docs \ doxygen \ + git_sha1_gen.sh \ scons \ SC

Re: [Mesa-dev] [PATCH 07/14] gallium/radeon: remove RADEON_FLAG_CPU_ACCESS

2017-06-30 Thread Marek Olšák
On Fri, Jun 30, 2017 at 4:49 AM, Michel Dänzer wrote: > On 30/06/17 04:47 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> https://lists.freedesktop.org/archives/amd-gfx/2017-June/010591.html > > This is premature. The discussion on amd-gfx hasn't concluded yet. For Mesa, the outcome of that di

Re: [Mesa-dev] [PATCH 01/10] egl: move eglCreateDRMImageMESA's malloc later

2017-06-30 Thread Daniel Stone
Hi Emil, On 30 June 2017 at 12:15, Emil Velikov wrote: > Kristian can you shed some light? The extension seems quite sparse. > > Weston used the extension back in 2011. While the Glamor bit were > dropped somewhat recently in May 2017. > > Other than those I cannot find any users of the extension

[Mesa-dev] [PATCH 01/16] dri: define a version 2 of the DRI_ConfigOptions extension

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle The new function is defined to return a malloc'ed pointer. In the following patches, this helps avoid leaking library handles when pipe drivers are linked dynamically. It also allows us to generate the XML string on the fly in the future. --- include/GL/internal/dri_interfa

[Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle Hi all, This is a big change to the drirc/xmlconfig framework, mostly on the Gallium side. The non-Gallium changes are: - xmlconfig is moved to src/util to better reflect how it is used going forward - some glx/dri glue code Problem Statement - We want t

[Mesa-dev] [PATCH 02/16] glx: use v2 of DRI_ConfigOptions

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle Most of the change is concerned with avoiding memory leaks, since v2 of the DRI extension returns a malloc'ed string. This also allows us to resolve the long-standing issue of keeping drivers loaded when returning from glXGetDriverConfig. --- src/glx/dri_glx.c | 113

[Mesa-dev] [PATCH 06/16] st/drm: add DRM_CONF_XML_OPTIONS

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle Allow drivers to return the XML that describes the available config options. --- src/gallium/include/state_tracker/drm_driver.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/include/state_tracker/drm_driver.h b/src/gallium/include/state_tracker/drm_drive

[Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/drivers/dri/common/xmlconfig.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c index d464937..9bd587b 100644 --- a/src/mesa/drivers/dri/common/xmlco

[Mesa-dev] [PATCH 07/16] gallium: add pipe_screen_config to screen_create functions

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle This allows a more generic mechanism for passing user configurations into drivers by accessing the dri options directly. --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 5 +- src/gallium/auxiliary/pipe-loader/pipe_loader.h| 5 +- .../auxiliary/pipe-loader/pipe

[Mesa-dev] [PATCH 08/16] gallium: move driinfo XML to pipe_loader

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle We will switch to the pipe_loader loading the configuration options, so that they can be passed to the driver independently of the state tracker. Put the description into its own file so that it can be merged easily with driver-specific options in future commits. --- src/ga

[Mesa-dev] [PATCH 09/16] gallium: move loading of drirc to pipe-loader

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 29 +++ src/gallium/auxiliary/pipe-loader/pipe_loader.h| 14 .../auxiliary/pipe-loader/pipe_loader_drm.c| 3 +- .../auxiliary/pipe-loader/pipe_loader_priv.h | 11 ++ src/gall

[Mesa-dev] [PATCH 05/16] util: add merge_driinfo.py

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle This tool merges driinfo XML that is built using DRI_CONF_xxx macros. The intention is to merge together state-tracker options with driver-specific options. --- src/util/merge_driinfo.py | 222 ++ 1 file changed, 222 insertions(+)

[Mesa-dev] [PATCH 10/16] gallium: add driconf options to pipe_screen_config

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c | 3 +++ src/gallium/include/pipe/p_screen.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader.c b/src/gallium/auxiliary/pipe-loader/pipe_loader.c index 95e6b4

[Mesa-dev] [PATCH 13/16] st/dri: implement v2 of DRI_ConfigOptions

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 13 src/gallium/auxiliary/pipe-loader/pipe_loader.h| 16 +++ .../auxiliary/pipe-loader/pipe_loader_drm.c| 23 ++ src/gallium/state_trackers/dri/dri_screen.c

[Mesa-dev] [PATCH 11/16] pipe-loader: pass only the driver_name to pipe_loader_find_module

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c | 6 +++--- src/gallium/auxiliary/pipe-loader/pipe_loader_priv.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader.c b/src/gallium/auxiliary/pipe-lo

[Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- configure.ac | 2 +- src/gallium/state_trackers/dri/Makefile.am | 2 +- src/gallium/state_trackers/dri/dri_screen.c| 2 +- src/gallium/state_trackers/dri/dri_screen.h| 2 +- src/gallium/targets/d3dadapter9

[Mesa-dev] [PATCH 14/16] pipe-loader: move configuration_query into drm_helper

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle Having it inline is pointless anyway, since it's only called via a function pointer. --- .../auxiliary/pipe-loader/pipe_loader_drm.c| 50 ++ src/gallium/auxiliary/target-helpers/drm_helper.h | 25 +++ .../auxiliary/target-helpers/drm_help

[Mesa-dev] [PATCH 15/16] radeonsi: prepare for driver-specific driconf options

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/Automake.inc | 2 ++ .../auxiliary/pipe-loader/pipe_loader_drm.c| 2 +- src/gallium/auxiliary/target-helpers/drm_helper.h | 25 ++ .../auxiliary/target-helpers/drm_helper_public.h | 2 ++ src/gallium

[Mesa-dev] [PATCH 12/16] pipe-loader: extract a standalone get_driver_descriptor helper function

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../auxiliary/pipe-loader/pipe_loader_drm.c| 49 +- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c index 193c8dd..92b24

[Mesa-dev] [PATCH 16/16] radeonsi: add enable_sisched driconf option

2017-06-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/driinfo_radeonsi.h | 3 +++ src/gallium/drivers/radeonsi/si_pipe.c | 4 src/util/xmlpool/t_options.h| 9 + 3 files changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/driinfo_radeonsi

Re: [Mesa-dev] [PATCH] automake: include git_sha1_gen.sh into EXTRA_DIST

2017-06-30 Thread Emil Velikov
On 30 June 2017 at 12:47, Juan A. Suarez Romero wrote: > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.am b/Makefile.am > index fee132e..d1eadee 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -53,6 +53,7 @@ EXTRA_DIST = \ > common.py \ >

Re: [Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

2017-06-30 Thread Nicolai Hähnle
There is one change that I forgot to mention: The existing xmlconfig system can filter drirc settings by X screen number. After the series, this no longer works. Or rather, the system behaves as if we're always on screen 0. I really don't think this is a big deal, since multiple X screens is

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-06-30 Thread Nicolai Hähnle
On 30.06.2017 02:29, Grigori Goronzy wrote: Use function pointers to identify the unmarshalling function, which is simpler and gets rid of a lot generated code. This removes an indirection and possibly results in a slight speedup as well. The fact that it blows up cmd_base from 4 bytes to 16 b

Re: [Mesa-dev] Updating Khronos-supplied headers (and gl.xml)

2017-06-30 Thread Nicolai Hähnle
Thanks guys. It was just me being conservative and letting the patch sit a while longer. It's pushed now. Cheers, Nicolai On 29.06.2017 14:42, Emil Velikov wrote: On 29 June 2017 at 12:39, Alejandro Piñeiro wrote: On 25/06/17 20:18, Matt Turner wrote: On Sun, Jun 25, 2017 at 7:32 AM, Nicola

Re: [Mesa-dev] [PATCH 0/5] dri3, gallium: Correctness and performance fixes

2017-06-30 Thread Brian Paul
On 06/28/2017 11:07 AM, Thomas Hellstrom wrote: On 06/22/2017 12:42 PM, Thomas Hellstrom wrote: A patch series that deals with dri3 correctness- and performance fixes. The corectness fixes attempts to deal with the fact that we need to wait for all pending swapbuffers before we touch the front

Re: [Mesa-dev] [PATCH 0/5] dri3, gallium: Correctness and performance fixes

2017-06-30 Thread Thomas Hellstrom
On 06/30/2017 03:35 PM, Brian Paul wrote: On 06/28/2017 11:07 AM, Thomas Hellstrom wrote: On 06/22/2017 12:42 PM, Thomas Hellstrom wrote: A patch series that deals with dri3 correctness- and performance fixes. The corectness fixes attempts to deal with the fact that we need to wait for all pen

Re: [Mesa-dev] [PATCH] Android: fix typo in symlink for driver loading and 32 bit builds

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 1:54 AM, Mauro Rossi wrote: > There is typo in the mkdir command path, > the correct one is $(TARGET_OUT)/$(l)/$(MESA_DRI_MODULE_REL_PATH) Humm, I tested the the pre-O case by enabling it on master and thought it worked. Maybe TARGET_OUT_SHARED_LIBRARIES didn't exist pre-O

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 Ray Strode [halfline] changed: What|Removed |Added CC||rstr...@redhat.com --- Comment #

Re: [Mesa-dev] [PATCH] docs: update HTTP -> HTTPS reference to reflect reality

2017-06-30 Thread Eric Engestrom
On Friday, 2017-06-30 12:10:39 +0100, Emil Velikov wrote: > From: Emil Velikov > > The link recently got updated to https. > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- > docs/download.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/do

Re: [Mesa-dev] [PATCH] automake: include git_sha1_gen.sh into EXTRA_DIST

2017-06-30 Thread Eric Engestrom
On Friday, 2017-06-30 13:47:33 +0200, Juan A. Suarez Romero wrote: > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.am b/Makefile.am > index fee132e..d1eadee 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -53,6 +53,7 @@ EXTRA_DIST = \ > common.py \

[Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Brian Paul
--- src/xdemos/glinfo_common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index fe7b9c9..413a3e0 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/glinfo_common.c @@ -721,6 +721,12 @@ context_flags_string(int mask) #ifd

[Mesa-dev] [PATCH] wglcontext: assorted updates

2017-06-30 Thread Brian Paul
Print context flags, vendor, renderer strings. Default to not setting the WGL_CONTEXT_PROFILE_MASK_ARB attribute so we can test that scenario. Try calling glGenLists() to see if it generates an error. This helps to check if core/forward compatible profile error checking is realy working. Restructu

[Mesa-dev] [PATCH 2/2] gallium/docs: document that TXF is used with PIPE_BUFFER resources

2017-06-30 Thread Brian Paul
--- src/gallium/docs/source/tgsi.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index fab0012..6214de3 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -939,7 +939,

[Mesa-dev] [PATCH 1/2] gallium/docs: clarify that samplers are not used with PIPE_BUFFER resources

2017-06-30 Thread Brian Paul
Commit 8aba778fa2cd98a0b5a7429d3c5057778a0c808c "st/mesa: don't set sampler states for TBOs" changed how texture buffer objects are handled. Document the new convention. --- src/gallium/docs/source/context.rst | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/docs/source/cont

Re: [Mesa-dev] [PATCH 2/4] intel: Add Cannonlake PCI IDs for Y-skus.

2017-06-30 Thread Rodrigo Vivi
series pushed to libdrm. Thanks for the review. On Thu, Jun 29, 2017 at 3:16 PM, Clint Taylor wrote: > Reviewed-by: Clinton Taylor > > -Clint > > > > > On 06/29/2017 02:34 PM, Rodrigo Vivi wrote: >> >> By the Spec all CNL Y skus are 2+2, i.e. GT2. >> >> This is a copy of merged i915's >> commit

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #2 from Ray Strode [halfline] --- (In reply to Ray Strode [halfline] from comment #1) > I guess if it's gotten to the assertion things have already gone pair shaped > because that's happening when trying to send the error. So this is

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Fix ordering of parameters for image atomic cmpswap intrinsics

2017-06-30 Thread Jason Ekstrand
Does this mean that image atomics are broken and radv passes the CTS anyway? If so, someone should fine a bug against the CTS so we can keep track of the coverage hole. On June 30, 2017 3:15:57 AM Alex Smith wrote: The NIR parameters are ordered "compare, data", matching GLSL, but both the

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #3 from Ray Strode [halfline] --- In your case the last request accounted for is 84 and the narrowed error event sequence number is 82. The code notices 82 is less than 84 and assumes the upper bits were off by one, but what's really

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Fix ordering of parameters for image atomic cmpswap intrinsics

2017-06-30 Thread Alex Smith
Just compare/swap, not all the image atomics. From a quick grep it looks like the CTS doesn't have any tests for compare/swap, but does for the other atomics. Alex On 30 June 2017 at 16:45, Jason Ekstrand wrote: > Does this mean that image atomics are broken and radv passes the CTS > anyway? I

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Eric Anholt
Alex Deucher writes: > On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: >> I want to remove vc4's dependency on headers from libdrm as well, but >> storing multiple copies of drm_fourcc.h in our tree would be silly. >> >> v2: Update Android.mk as well, move distcheck drm*.h references to >>

[Mesa-dev] [Bug 100262] libswrAVX2.so Causes hang with QOpenGLWidget

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100262 --- Comment #5 from Bruce Cherniak --- Hi Chris, Just checking back. Have you had a chance to 'putz around'? Is this still an issue? Depending on your application, and the interaction of the 2 threading libraries, it may be necessary to set

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: > Alex Deucher writes: > >> On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: >>> I want to remove vc4's dependency on headers from libdrm as well, but >>> storing multiple copies of drm_fourcc.h in our tree would be silly. >>> >>> v2: Upda

[Mesa-dev] [PATCH] intel: genxml: make a couple of enums show up in aubinator

2017-06-30 Thread Lionel Landwerlin
In particular Shader Channel Select & Texture Address Control Mode. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 14 +++--- src/intel/genxml/gen6.xml | 6 +++--- src/intel/genxml/gen7.xml | 6 +++--- src/intel/genxml/gen75.xml | 30 --

[Mesa-dev] [Bug 101657] strtod.c:32:10: fatal error: xlocale.h: No such file or directory

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101657 --- Comment #1 from Eric Engestrom --- To be clear, the bug here is that SCons (scons/gallium.py) defines HAVE_XLOCALE_H without actually checking that it does indeed have xlocale.h. As far as I can tell, there is no way to perform such a check

Re: [Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Emil Velikov
On 30 June 2017 at 15:44, Brian Paul wrote: > --- > src/xdemos/glinfo_common.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c > index fe7b9c9..413a3e0 100644 > --- a/src/xdemos/glinfo_common.c > +++ b/src/xdemos/glinfo_common

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Lionel Landwerlin
On 30/06/17 17:14, Alex Deucher wrote: On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: Alex Deucher writes: On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: I want to remove vc4's dependency on headers from libdrm as well, but storing multiple copies of drm_fourcc.h in our tree wo

[Mesa-dev] [Bug 101657] strtod.c:32:10: fatal error: xlocale.h: No such file or directory

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101657 --- Comment #2 from Emil Velikov --- http://scons.org/doc/0.97/HTML/scons-user/x2827.html Above suggests that there may be a way. Although, I think we want to hunk/rework the implementation. But that for another day. -- You are receiving this

[Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Brian Paul
v2: define the GLCONTEXT_FLAG_x values if glext.h isn't new enough, per Emil. --- src/xdemos/glinfo_common.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index fe7b9c9..23f430f 100644 --- a/src/xdemo

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Emil Velikov
On 30 June 2017 at 17:40, Lionel Landwerlin wrote: > On 30/06/17 17:14, Alex Deucher wrote: >> >> On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: >>> >>> Alex Deucher writes: >>> On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: > > I want to remove vc4's dependency on head

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Lionel Landwerlin
On 30/06/17 17:43, Emil Velikov wrote: On 30 June 2017 at 17:40, Lionel Landwerlin wrote: On 30/06/17 17:14, Alex Deucher wrote: On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: Alex Deucher writes: On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: I want to remove vc4's dependen

Re: [Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Emil Velikov
On 30 June 2017 at 17:44, Brian Paul wrote: > v2: define the GLCONTEXT_FLAG_x values if glext.h isn't new enough, per Emil. Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/ma

[Mesa-dev] [PATCH] radeonsi: fix invalidating bindless buffer descriptors

2017-06-30 Thread Samuel Pitoiset
The VA is stored at [4:5], not [0:1]. This invalidated all texture buffer descriptors when they were made resident in the current context. This removes few partial flushes and cache invalidations which are needed when updating a bindless descriptor on the fly with a WRITE_DATA packet. Signed-off-

Re: [Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Eric Engestrom
On Friday, 2017-06-30 10:44:19 -0600, Brian Paul wrote: > v2: define the GLCONTEXT_FLAG_x values if glext.h isn't new enough, per Emil. > --- > src/xdemos/glinfo_common.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/src/xdemos/glinfo_common.c b/src/

[Mesa-dev] [PATCH] swr: use swr_query_result type instead of void

2017-06-30 Thread Tim Rowley
Tag pStat field in swr_draw_context structure so gen_llvm_types.py can deal with the actual structure type instead of using void. Code cleanup, no functional change. --- src/gallium/drivers/swr/swr_context.cpp | 4 ++-- src/gallium/drivers/swr/swr_context.h | 2 +- 2 files changed, 3 insertions

Re: [Mesa-dev] [PATCH 2/2] gallium/docs: document that TXF is used with PIPE_BUFFER resources

2017-06-30 Thread Roland Scheidegger
Am 30.06.2017 um 17:25 schrieb Brian Paul: > --- > src/gallium/docs/source/tgsi.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/docs/source/tgsi.rst > b/src/gallium/docs/source/tgsi.rst > index fab0012..6214de3 100644 > --- a/src/gallium/docs/source/tgs

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: clarify that samplers are not used with PIPE_BUFFER resources

2017-06-30 Thread Roland Scheidegger
Am 30.06.2017 um 17:25 schrieb Brian Paul: > Commit 8aba778fa2cd98a0b5a7429d3c5057778a0c808c "st/mesa: don't set > sampler states for TBOs" changed how texture buffer objects are handled. > Document the new convention. > --- > src/gallium/docs/source/context.rst | 8 > 1 file changed, 8 i

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 12:40 PM, Lionel Landwerlin wrote: > On 30/06/17 17:14, Alex Deucher wrote: >> >> On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: >>> >>> Alex Deucher writes: >>> On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: > > I want to remove vc4's dependency

Re: [Mesa-dev] [PATCH] Android: fix typo in symlink for driver loading and 32 bit builds

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 1:54 AM, Mauro Rossi wrote: > There is typo in the mkdir command path, > the correct one is $(TARGET_OUT)/$(l)/$(MESA_DRI_MODULE_REL_PATH) > > The other issue is in 32bit builds, because lib64 does not exist there, > we can use TARGET_IS_64_BIT to refine the post install co

Re: [Mesa-dev] [PATCH] intel: genxml: make a couple of enums show up in aubinator

2017-06-30 Thread Kristian Høgsberg
On Fri, Jun 30, 2017 at 9:25 AM, Lionel Landwerlin wrote: > In particular Shader Channel Select & Texture Address Control Mode. > > Signed-off-by: Lionel Landwerlin Nice, Reviewed-by: Kristian H. Kristensen > --- > src/intel/genxml/gen10.xml | 14 +++--- > src/intel/genxml/gen6.xml

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-06-30 Thread Grigori Goronzy
On 2017-06-30 15:27, Nicolai Hähnle wrote: On 30.06.2017 02:29, Grigori Goronzy wrote: Use function pointers to identify the unmarshalling function, which is simpler and gets rid of a lot generated code. This removes an indirection and possibly results in a slight speedup as well. The fact th

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

2017-06-30 Thread Kristian Høgsberg
On Fri, Jun 30, 2017 at 2:49 AM, Thomas Hellstrom wrote: > On 06/29/2017 07:30 PM, Kristian Høgsberg wrote: >> >> On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom >> wrote: >>> >>> Hi! >>> >>> I was spending some time going through the GLX code to try to fix up the >>> GLX_OML_swap_method extens

[Mesa-dev] [PATCH] glxinfo: print debug/no-error contex flags

2017-06-30 Thread Brian Paul
v2: define the GLCONTEXT_FLAG_x values if glext.h isn't new enough, per Emil. v3: use #ifndef, not #ifdef. Ugh. --- src/xdemos/glinfo_common.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index fe7b

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 7:45 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- [...] > diff --git a/src/util/Android.mk b/src/util/Android.mk > index facdcf8..6c81322 100644 > --- a/src/util/Android.mk > +++ b/src/util/Android.mk > @@ -24,35 +24,80 @@ LOCAL_PATH := $(call my-dir) > > in

[Mesa-dev] [ANNOUNCE] mesa 17.1.4

2017-06-30 Thread Andres Gomez
Mesa 17.1.4 is now available. In this release we have: In Mesa Core we include some fixes that involve flushing vertices before some state changes. The state tracker also received a fix for the Scissor with multiple viewports. The SPIR-V compiler has gotten a work around to prevent a shader bug

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #4 from Ray Strode [halfline] --- so looking a few stack frames up I see this: err = xcb_request_check(c, cookie);• if (err != NULL) {• gc->vtable->destroy(gc);• gc = NULL;• •

Re: [Mesa-dev] [PATCH] swr: Minor cleanup of variable usage, no functional change.

2017-06-30 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Jun 29, 2017, at 2:41 PM, Bruce Cherniak wrote: > > In swr_update_derived, for consistency, index buffer validation should > be using the p_draw_info copy "info" rather than referencing > p_draw_info. > > No functional change. > --- > src/gallium/drivers/swr/swr_st

Re: [Mesa-dev] [PATCH] swr: use swr_query_result type instead of void

2017-06-30 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 30, 2017, at 11:52 AM, Tim Rowley wrote: > > Tag pStat field in swr_draw_context structure so gen_llvm_types.py > can deal with the actual structure type instead of using void. > > Code cleanup, no functional change. > --- > src/gallium/drivers/swr/swr_con

[Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-06-30 Thread Rob Herring
Add support for 32-bit RGBX/RGBA formats which are required for Android. The original patch (commit ccdcf91104a5) was reverted (commit c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based on further investigation by Chad Versace, moving the RGBX/RGBA configs to the end is enoug

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Eric Anholt
Alex Deucher writes: > On Fri, Jun 30, 2017 at 12:40 PM, Lionel Landwerlin > wrote: >> On 30/06/17 17:14, Alex Deucher wrote: >>> >>> On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: Alex Deucher writes: > On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: >>

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 3:02 PM, Eric Anholt wrote: > Alex Deucher writes: > >> On Fri, Jun 30, 2017 at 12:40 PM, Lionel Landwerlin >> wrote: >>> On 30/06/17 17:14, Alex Deucher wrote: On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: > > Alex Deucher writes: > >>

[Mesa-dev] [PATCH] radv: Use v4i32 variant of llvm.SI.load.const.

2017-06-30 Thread Bas Nieuwenhuizen
We apparently still used v16i8 As radeonsi doesn't use it with LLVM version checks I don't think we need them either. Signed-off-by: Bas Nieuwenhuizen CC: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/common/

Re: [Mesa-dev] [PATCH 1/5] dri3: Wait for all pending swapbuffers to be scheduled before touching the front

2017-06-30 Thread Eric Anholt
Thomas Hellstrom writes: > This implements a wait for glXWaitGL, glXCopySubBuffer, dri flush_front and > creation of fake front until all pending SwapBuffers have been committed to > hardware. Among other things this fixes piglit glx-copy-sub-buffers on dri3. The GLX spec loves to talk about the

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 Bruce Cherniak changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG

[Mesa-dev] [PATCH] anv: Move a comment that got left behind in the u_vector refactor.

2017-06-30 Thread Eric Anholt
--- src/intel/vulkan/anv_private.h | 8 src/util/u_vector.c| 9 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 573778dad556..f1de08b32f35 100644 --- a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH] gles: Restore some lost typedefs

2017-06-30 Thread Scott D Phillips
GLES/gl.h has historically provided some typedefs that are not used in the API itself. Restore these typedefs that were lost to avoid breaking applications. These seem to be the only typedefs removed in the update. Fixes: 7fd0817 "Update Khronos-supplied headers" --- include/GLES/gl.h| 6 ++

Re: [Mesa-dev] [PATCH] radv: Use v4i32 variant of llvm.SI.load.const.

2017-06-30 Thread Dave Airlie
Reviewed-by: Dave Airlie On 1 Jul. 2017 05:06, "Bas Nieuwenhuizen" wrote: > We apparently still used v16i8 > > As radeonsi doesn't use it with LLVM version checks I don't think > we need them either. > > Signed-off-by: Bas Nieuwenhuizen > CC: Dave Airlie > --- > src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH] gles: Restore some lost typedefs

2017-06-30 Thread Ian Romanick
Has this been reported to upstream (i.e., Khronos)? I don't mind fixing these in our tree, but they really should get fixed at the source too. On 06/30/2017 01:49 PM, Scott D Phillips wrote: > GLES/gl.h has historically provided some typedefs that are not > used in the API itself. Restore these t

  1   2   >