2017-06-30 9:39 GMT+02:00 Emil Velikov <emil.l.veli...@gmail.com>: > On 29 June 2017 at 16:40, Robert Foss <robert.f...@collabora.com> wrote: >> On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote: >>> On 28 June 2017 at 22:52, Robert Foss <robert.f...@collabora.com> >>> wrote: >>> > From: Tomeu Vizoso <tomeu.viz...@collabora.com> >>> > >>> > Signed-off-by: Robert Foss <robert.f...@collabora.com> >>> > Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> >>> >>> Fwiw >>> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >>> >>> Any additional changes (change the int:4 to enum foo:4 in the >>> headers, >>> propagate that through the codebase, drop the default case) can be >>> done at a later stage. >> >> You mean something like this? >> - unsigned Swizzle : 2; /* TGSI_SWIZZLE_ */ >> + enum_swizzle Swizzle : 2; /* TGSI_SWIZZLE_ */ >> > Yes, that's the first step. Next checks that we consistently use > enum_swizzle instead of unsigned throughout the codebase. And finally > default cases like the one in the patch are dropped. > > Pretty much none of this is required for the patches to land. Just > some janitorial tasks which came up in earlier thread. > /me proceeds to double-check the series and push. >
Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> Lets get the current patch(es) pushed and we can have a look at possible refactoring/cleanup tasks later on. Maybe I will give a quick spin on my own. greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
