Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

2017-06-29 Thread Eric Engestrom
On 28 June 2017 09:20:27 BST, Emil Velikov wrote: > On 27 June 2017 at 13:47, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > Note: Autotools and SCons are tested, but Android isn't. > > --- > > git_sha1_gen.sh | 13 + > > src/Makefile.am

Re: [Mesa-dev] [PATCH v1 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

2017-06-29 Thread Gustaw Smolarczyk
2017-06-29 4:41 GMT+02:00 Robert Foss : > Switch to using strncopy to avoid potential overflow of > name array in struct hud_graph. > > Coverity-id: 1413760 > > Signed-off-by: Robert Foss > --- > src/gallium/auxiliary/hud/hud_cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 5/5] vc4: Set shareable BOs as T tiled if possible

2017-06-29 Thread Daniel Stone
Hi, On 29 June 2017 at 02:15, Eric Anholt wrote: > X11 and GL compositor performance on VC4 has been terrible because of our > SHARED-usage buffers all being forced to linear. This swaps SHARED && > !LINEAR buffers over to being tiled. Series is: Reviewed-by: Daniel Stone Cheers, Daniel _

Re: [Mesa-dev] [PATCH] android: anv: drop libdrm_intel dependency

2017-06-29 Thread Lionel Landwerlin
Not an expert on the android build system, I have a question below. Otherwise : Acked-by: Lionel Landwerlin Thanks! On 29/06/17 01:46, Mauro Rossi wrote: In addition to Rob Herring "Android: i965: remove libdrm_intel dependency", we can drop libdrm_intel dependency in anv for Android. Please

Re: [Mesa-dev] [PATCH 1/5] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Lionel Landwerlin
I just sent a Ack-by on a patch to fix the android build with the intel driver : https://patchwork.freedesktop.org/patch/164312/ You might want to modify this as well so it's not broken again :) Otherwise this patch is : Reviewed-by: Lionel Landwerlin On 29/06/17 02:15, Eric Anholt wrote:

Re: [Mesa-dev] [PATCH 01/11] etnaviv: fill in layer_stride for imported resources

2017-06-29 Thread Lucas Stach
Am Dienstag, den 27.06.2017, 14:09 +0200 schrieb Wladimir J. van der Laan: > On Fri, Jun 23, 2017 at 05:50:18PM +0200, Lucas Stach wrote: > > The layer stride information is used in various parts of the driver, > > so it needs to be present regardless if the driver allocated the > > buffer itself o

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-06-29 Thread Michel Dänzer
On 29/06/17 01:54 AM, Cherniak, Bruce wrote: >> On Jun 26, 2017, at 2:10 PM, Marek Olšák wrote: >> >> In my opinion, dumping resources isn't very useful. I think it would >> be better to remove that completely. > > From Michel's response, sounds like dumping resources is useful, so... FWIW, afte

Re: [Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-29 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Wed, 2017-06-28 at 17:08 -0500, Rob Herring wrote: > Commit 7dd20bc3ee8f ("anv/i965: drop libdrm_intel dependency completely") > removed the libdrm_intel dependency for automake, but Android builds still > depended on it. Now the build requires a newer versi

Re: [Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 28/06/17 23:08, Rob Herring wrote: Commit 7dd20bc3ee8f ("anv/i965: drop libdrm_intel dependency completely") removed the libdrm_intel dependency for automake, but Android builds still depended on it. Now the build requires a newer version of i915_drm.h and fail

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 08:03, Eric Engestrom wrote: > On 28 June 2017 09:20:27 BST, Emil Velikov wrote: >> On 27 June 2017 at 13:47, Eric Engestrom >> wrote: >> > Signed-off-by: Eric Engestrom >> > --- >> > Note: Autotools and SCons are tested, but Android isn't. >> > --- >> > git_sha1_gen.sh

Re: [Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 23:08, Rob Herring wrote: > Commit 7dd20bc3ee8f ("anv/i965: drop libdrm_intel dependency completely") > removed the libdrm_intel dependency for automake, but Android builds still > depended on it. Now the build requires a newer version of i915_drm.h and > fails on Android builds

Re: [Mesa-dev] [PATCH] android: anv: drop libdrm_intel dependency

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 09:21, Lionel Landwerlin wrote: > Not an expert on the android build system, I have a question below. > Otherwise : > > Acked-by: Lionel Landwerlin > > Thanks! > > On 29/06/17 01:46, Mauro Rossi wrote: >> >> In addition to Rob Herring "Android: i965: remove libdrm_intel >> depe

Re: [Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 12:20, Emil Velikov wrote: > On 28 June 2017 at 23:08, Rob Herring wrote: >> Commit 7dd20bc3ee8f ("anv/i965: drop libdrm_intel dependency completely") >> removed the libdrm_intel dependency for automake, but Android builds still >> depended on it. Now the build requires a newer

Re: [Mesa-dev] Updating Khronos-supplied headers (and gl.xml)

2017-06-29 Thread Alejandro Piñeiro
On 25/06/17 20:18, Matt Turner wrote: > On Sun, Jun 25, 2017 at 7:32 AM, Nicolai Hähnle wrote: >> Hi all, >> >> For the ARB_gl_spirv work I need some new definitions from the Khronos >> headers, and I'd like to push the corresponding update to our master branch >> already. For our late work (stil

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Emil Velikov
Hi Eric, On 28 June 2017 at 19:18, Eric Anholt wrote: > I really liked this idea, as it should help with management of packet > parsing tools like the CL dump. The python script is forked off of theirs > because our packets are byte-based instead of dwords, and the changes to > do so while avoid

Re: [Mesa-dev] [PATCH 2/5] vc4: Switch back to using a local copy of vc4_drm.h.

2017-06-29 Thread Emil Velikov
Hi Eric, On 29 June 2017 at 02:15, Eric Anholt wrote: > Needing to get our uapi header from libdrm has only complicated things. > Follow intel's lead and drop our requirement for it. > Humble question: when you get the chance please describe the complications that you've seen. That aside, there'

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 22:42, Rob Herring wrote: > On Wed, Jun 28, 2017 at 4:23 PM, Chad Versace > wrote: >> On Wed 28 Jun 2017, Rob Herring wrote: >>> On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace >>> wrote: >>> > The new function takes a mesa_format and, if the format is an alpha >>> > format wi

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 18:19, Rob Clark wrote: > On Wed, Jun 28, 2017 at 12:51 PM, Rob Herring wrote: >> On Wed, Jun 28, 2017 at 11:46 AM, Eric Anholt wrote: >>> Rob Herring writes: >>> Instead of having special driver loading logic for Android, create symlinks to gallium_dri.so so we can

Re: [Mesa-dev] Updating Khronos-supplied headers (and gl.xml)

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 12:39, Alejandro Piñeiro wrote: > On 25/06/17 20:18, Matt Turner wrote: >> On Sun, Jun 25, 2017 at 7:32 AM, Nicolai Hähnle wrote: >>> Hi all, >>> >>> For the ARB_gl_spirv work I need some new definitions from the Khronos >>> headers, and I'd like to push the corresponding updat

Re: [Mesa-dev] [PATCH 2/5] dri: Add a flushSwapBuffers method to the image loader extension

2017-06-29 Thread Emil Velikov
On 22 June 2017 at 11:42, Thomas Hellstrom wrote: > This method may be used by dri drivers to make sure all outstanding > buffer swaps have been flushed to hardware. Also add a dri3 implementation. > Based on the description we'd want this for EGL as well, won't we? At least in the EGL/X11 case.

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-29 Thread Rob Clark
On Thu, Jun 29, 2017 at 8:28 AM, Emil Velikov wrote: >> using downstream kgsl kernel also probably doesn't work with any >> kernel that supported a4xx or a5xx.. and when it worked, it was a >> kernel old enough not to have dma-buf, dma-fence, etc. So I tend to >> agree that there is no need for k

[Mesa-dev] [PATCH v2 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

2017-06-29 Thread Robert Foss
Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413761 Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/

[Mesa-dev] [PATCH v2 1/3] gallium/hud: Add define for struct hud_graph name array

2017-06-29 Thread Robert Foss
Define the length of the name field of struct hud_graph with HUD_GRAPH_NAME_LEN. Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_private.h b/src/gallium/auxiliary/hud/hud_p

[Mesa-dev] [PATCH v2 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

2017-06-29 Thread Robert Foss
Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413760 Signed-off-by: Robert Foss --- Changes since v1: Gustaw Smolarczyk - Fix strcpy -> strncpy typo src/gallium/auxiliary/hud/hud_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

2017-06-29 Thread Brian Paul
If the patches apply cleanly, sure. -Brian On 06/27/2017 10:27 AM, Andres Gomez wrote: It looks like we could want these 2 into -stable (?) On Thu, 2017-06-15 at 11:41 -0600, Brian Paul wrote: The line stipple fallback code for virtual HW version 8 didn't work. With HW version 8, we were get

Re: [Mesa-dev] [PATCH v2 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

2017-06-29 Thread Brian Paul
On 06/29/2017 07:21 AM, Robert Foss wrote: Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413761 Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

Re: [Mesa-dev] [PATCH v2 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

2017-06-29 Thread Robert Foss
Hey Brian, On Thu, 2017-06-29 at 07:28 -0600, Brian Paul wrote: > On 06/29/2017 07:21 AM, Robert Foss wrote: > > Switch to using strncopy to avoid potential overflow of > > name array in struct hud_graph. > > > > Coverity-id: 1413761 > > > > Signed-off-by: Robert Foss > > --- > >   src/gallium/

Re: [Mesa-dev] [PATCH 1/5] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Rob Herring
On Wed, Jun 28, 2017 at 8:15 PM, Eric Anholt wrote: > I want to remove vc4's dependency on headers from libdrm as well, but > storing multiple copies of drm_fourcc.h in our tree would be silly. > --- > {src/intel/drm => include/drm-uapi}/README | 0 > {src/intel/drm => include/drm-uapi}/drm

[Mesa-dev] [Bug 101648] Adding a single-iteration do-while loop in a GLSL shader leads to a different image

2017-06-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101648 Bug ID: 101648 Summary: Adding a single-iteration do-while loop in a GLSL shader leads to a different image Product: Mesa Version: 17.1 Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 101648] Adding a single-iteration do-while loop in a GLSL shader leads to a different image

2017-06-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101648 Hugues Evrard changed: What|Removed |Added CC||h.evr...@imperial.ac.uk -- You are rec

Re: [Mesa-dev] [PATCH v3 5/5] android: build imx-drm winsys

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 22:52, Robert Foss wrote: > From: Tomeu Vizoso > > Add Android.mk for winsys/imx/drm. > > Signed-off-by: Tomeu Vizoso > Reviewed-by: Tapani Pälli > --- > Changes since v2: > - Rebased on upstream/master > - Added commit message > > Changes since v1: > Emil Velikov >

Re: [Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 22:52, Robert Foss wrote: > From: Tomeu Vizoso > > Signed-off-by: Robert Foss > Reviewed-by: Tapani Pälli Fwiw Reviewed-by: Emil Velikov Any additional changes (change the int:4 to enum foo:4 in the headers, propagate that through the codebase, drop the default case) can be

[Mesa-dev] Why are we using server-side GLX fbconfigs?

2017-06-29 Thread Thomas Hellstrom
Hi! I was spending some time going through the GLX code to try to fix up the GLX_OML_swap_method extension implementation. I then stumbled across the fact that when we, for direct rendering connections, construct the list of fbconfigs, we start out with the server provided fbconfigs from the

[Mesa-dev] [Bug 101648] Adding a single-iteration do-while loop in a GLSL shader leads to a different image

2017-06-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101648 Ilia Mirkin changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

[Mesa-dev] [PATCH] swr: set dynamic vertex size

2017-06-29 Thread Tim Rowley
Reduces the memory footprint of the frontend processing by packing vertices. --- src/gallium/drivers/swr/swr_draw.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_draw.cpp b/src/gallium/drivers/swr/swr_draw.cpp index f85076b..f26b8e8 100644

Re: [Mesa-dev] [PATCH v3 5/5] android: build imx-drm winsys

2017-06-29 Thread Robert Foss
On Thu, 2017-06-29 at 15:28 +0100, Emil Velikov wrote: > On 28 June 2017 at 22:52, Robert Foss > wrote: > > From: Tomeu Vizoso > > > > Add Android.mk for winsys/imx/drm. > > > > Signed-off-by: Tomeu Vizoso > > Reviewed-by: Tapani Pälli > > --- > > Changes since v2: > >   - Rebased on upstream

Re: [Mesa-dev] [PATCH 2/5] vc4: Switch back to using a local copy of vc4_drm.h.

2017-06-29 Thread Eric Anholt
Emil Velikov writes: > Hi Eric, > > On 29 June 2017 at 02:15, Eric Anholt wrote: >> Needing to get our uapi header from libdrm has only complicated things. >> Follow intel's lead and drop our requirement for it. >> > UAPI: I think I may have noticed some compat breakage here. > > The sizeof abov

Re: [Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

2017-06-29 Thread Robert Foss
On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote: > On 28 June 2017 at 22:52, Robert Foss > wrote: > > From: Tomeu Vizoso > > > > Signed-off-by: Robert Foss > > Reviewed-by: Tapani Pälli > > Fwiw > Reviewed-by: Emil Velikov > > Any additional changes (change the int:4 to enum foo:4 in

[Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Eric Anholt
I want to remove vc4's dependency on headers from libdrm as well, but storing multiple copies of drm_fourcc.h in our tree would be silly. v2: Update Android.mk as well, move distcheck drm*.h references to top-level noinst_HEADERS. Reviewed-by: Lionel Landwerlin Reviewed-by: Daniel Stone ---

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 Bruce Cherniak changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [AppVeyor] mesa master #4797 failed

2017-06-29 Thread AppVeyor
Build mesa 4797 failed Commit 3fd425aed7 by Eric Engestrom on 6/27/2017 11:08 AM: build systems: uniformize git_sha1.h generation\n\nSigned-off-by: Eric Engestrom \nReviewed-by: Matt Turner \nReviewed-by: Emil Velikov Configure your notification pref

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 11:18 AM, Eric Anholt wrote: > I really liked this idea, as it should help with management of packet > parsing tools like the CL dump. The python script is forked off of theirs > because our packets are byte-based instead of dwords, and the changes to > do so while avoidi

[Mesa-dev] [PATCH v7 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-06-29 Thread Gregory Hainaut
Improve speed on PCSX2 v2: Add ppbo/ubpo status in XML file Disable variable parameter (as the pointer would be a fixed offset) v3: split buffer tracking into separate patches. use 'goto fallback_to_sync' when asynchronous transfer isn't supported v4: add Nicolai comment to explain why ppbo isn'

[Mesa-dev] [PATCH v7 1/3] mesa/glthread: track buffer destruction

2017-06-29 Thread Gregory Hainaut
It would be used in following commits to allow asynchronous PBO transfer. The tracking saves the buffer name into a hash. Saving pointer will be more complex as the buffer is created in BindBuffer due to IsBuffer insanity. Perf wise DeleteBuffers is now synchronous for robustness. v5: properly d

[Mesa-dev] [PATCH v7 2/3] mesa/glthread: add tracking of PBO binding

2017-06-29 Thread Gregory Hainaut
In gl core, buffer must be reserved first by CreateBuffers/GenBuffers to be valid. v4: update comments based on Nicolai review v7: s/GLint pixel_pack_buffer_bound/GLuint bound_pixel_pack_buffer/ Drop the ShadowBufferObjects hash. Synchronous creation/destruction gives us enough guarantee to looku

[Mesa-dev] [PATCH v7 0/3] asynchronous pbo transfer with glthread

2017-06-29 Thread Gregory Hainaut
Hello Mesa developers, > Please find a new version to handle invalid buffer handles. > > Allow to handle this kind of case: >genBuffer(&pbo); >BindBuffer(pbo) >DeleteBuffer(pbo); >BindBuffer(rand_pbo) >TexSubImage2D(user_memory_pointer); // Data transfer will be synchronous >

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Kenneth Graunke
On Wednesday, June 28, 2017 11:18:40 AM PDT Eric Anholt wrote: > I really liked this idea, as it should help with management of packet > parsing tools like the CL dump. The python script is forked off of theirs > because our packets are byte-based instead of dwords, and the changes to > do so whil

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

2017-06-29 Thread Gurchetan Singh
Thanks for the review, Emil. If we want to use swrast we'll probably need to implement a new swrast version of the image extension. We can't reuse the functions from dri2.c, even for version 1 of the extension (createImageFromName, createImageFromRenderbuffer etc), since they require definitions

[Mesa-dev] [AppVeyor] mesa master #4798 completed

2017-06-29 Thread AppVeyor
Build mesa 4798 completed Commit 9f6110ad32 by Eric Engestrom on 6/29/2017 4:21 PM: scons: wait on subprocess' completion\n\nWindows doesn't allow you to move a file that's opened, and Popen()\ndoesn't wait on its subprocess' completion before returning, which

Re: [Mesa-dev] [PATCH] swr: conditionally validate vertex buffer state

2017-06-29 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Jun 27, 2017, at 5:49 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: Vertex buffer state doesn't need to be validated on every call, only on dirty _NEW_VERTEX or indexed draws. Unconditional validation was introduced a

Re: [Mesa-dev] [PATCH] swr: Remove need to allocate vertex buffer scratch space all in one go.

2017-06-29 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Jun 28, 2017, at 1:42 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: Deferred deletion (via "fence_work") has obsoleted the need to allocate all client vertex buffer scratch space in a single chunk. Scratch allocations

Re: [Mesa-dev] [PATCH v2 00/13] swr: update rasterizer

2017-06-29 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 27, 2017, at 1:09 PM, Tim Rowley wrote: > > Highlights include splitting the heavily templated files into multiple > chunks to speed compile (2x for a large machine), and switching the > simd intrinsic usage from a macro-based header to a more c++ feeling >

Re: [Mesa-dev] [PATCH] swr: set dynamic vertex size

2017-06-29 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 29, 2017, at 10:07 AM, Tim Rowley wrote: > > Reduces the memory footprint of the frontend processing by packing > vertices. > --- > src/gallium/drivers/swr/swr_draw.cpp | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/galliu

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

2017-06-29 Thread Kristian Høgsberg
On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom wrote: > Hi! > > I was spending some time going through the GLX code to try to fix up the > GLX_OML_swap_method extension implementation. > > I then stumbled across the fact that when we, for direct rendering > connections, construct the list of fb

[Mesa-dev] [PATCH 01/18] nir/spirv: Move a "}"

2017-06-29 Thread Jason Ekstrand
It's closing a "{" at the begining of a switch case. --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 974adb5..31d1d76 100644 --- a/src/compiler/spirv/vtn_variab

[Mesa-dev] [PATCH 02/18] nir/spirv: Use the type from the deref for atomics

2017-06-29 Thread Jason Ekstrand
Previously, we were using the type of the variable which is incorrect. Cc: "17.1" --- src/compiler/spirv/spirv_to_nir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 0a5eb0e..78ccd65 100644 -

[Mesa-dev] [PATCH 03/18] nir/spirv: Add a storage_class_to_mode helper

2017-06-29 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_variables.c | 123 +++-- 1 file changed, 78 insertions(+), 45 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 31d1d76..bb41e89 100644 --- a/src/compiler/spirv/vtn_variables.c +++ b/

[Mesa-dev] [PATCH 04/18] nir/spirv: Split up Uniform and UniformConstant storage classes

2017-06-29 Thread Jason Ekstrand
We were originally handling them together because I was rather unclear on the distinction. However, keeping them combined keeps the confusion. Split them up so that it's more clear from the code how we expect the two storage classes to be used. --- src/compiler/spirv/vtn_variables.c | 10 +++-

[Mesa-dev] [PATCH 00/18] nir/spirv: Rework UBOs, SSBOs, and pointers

2017-06-29 Thread Jason Ekstrand
This rework has been on my ToDo list for a long time. The real crowning patch is patch 12 which makes us compute offsets to UBOs and SSBOs on the fly instead of waiting until we have the full access chain. In theory, we could do something similar for images and textures where we pass around the r

[Mesa-dev] [PATCH 07/18] nir/spirv: Use the correct stride for non-32-bit vectors

2017-06-29 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 18e3734..7a98843 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -744,7 +

[Mesa-dev] [PATCH 05/18] nir/spirv: Rename some things from access_chain to pointer

2017-06-29 Thread Jason Ekstrand
We're about to add a vtn_pointer data structure and this will prevent some rename churn in the next commit. --- src/compiler/spirv/spirv_to_nir.c | 65 +- src/compiler/spirv/vtn_cfg.c | 9 +++--- src/compiler/spirv/vtn_private.h | 18 +-- src/c

[Mesa-dev] [PATCH 08/18] nir/spirv: Simplify matrix loads/stores

2017-06-29 Thread Jason Ekstrand
Instead of handling all of the complexity at the end, we choose to decorate types a bit more cleverly. When we have a row-major matrix type, we give it the stride of a single vector and give it's array element type (which represents a column) the actual matrix stride. Previously, we were using st

[Mesa-dev] [PATCH 09/18] nir/spirv: Remove unneeded parameters from pointer_to_offset

2017-06-29 Thread Jason Ekstrand
Everyone now calls it with stop_at_matrix = false. Since we're now always walking all the way to the end of the access chain, the type returned is just the same as ptr->type; --- src/compiler/spirv/spirv_to_nir.c | 3 +-- src/compiler/spirv/vtn_private.h | 3 +-- src/compiler/spirv/vtn_varia

[Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-06-29 Thread Jason Ekstrand
Now that we have proper pointer types, we can be more sensible about the way we set up function arguments and deal with the two cases of pointer vs. SSA parameters distinctly. --- src/compiler/spirv/vtn_cfg.c | 62 +--- 1 file changed, 35 insertions(+), 27 d

[Mesa-dev] [PATCH 06/18] nir/spirv: Wrap access chains in a new vtn_pointer data structure

2017-06-29 Thread Jason Ekstrand
The vtn_pointer structure provides a bit better abstraction than passing access chains around directly. For one thing, if the pointer just points to a variable, we don't need the access chain at all. Also, pointers know what their dereferenced type is so we can avoid passing the type in a bunch o

[Mesa-dev] [PATCH 10/18] nir/spirv: Break variable creation out into a helper

2017-06-29 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_variables.c | 362 +++-- 1 file changed, 187 insertions(+), 175 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 7821663..7890594 100644 --- a/src/compiler/spirv/vtn_variables.c +++

[Mesa-dev] [PATCH 17/18] nir/spirv: Use real pointer types

2017-06-29 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 23 +-- src/compiler/spirv/vtn_cfg.c | 12 ++-- src/compiler/spirv/vtn_private.h | 18 ++ src/compiler/spirv/vtn_variables.c | 13 ++--- 4 files changed, 55 insertions(+), 11 deletions(-) diff --g

[Mesa-dev] [PATCH 11/18] nir/spirv: Rework the way pointers get dereferenced

2017-06-29 Thread Jason Ekstrand
This has the advantage of moving all of the "extend an access chain" code into one place. --- src/compiler/spirv/vtn_private.h | 8 ++- src/compiler/spirv/vtn_variables.c | 144 + 2 files changed, 88 insertions(+), 64 deletions(-) diff --git a/src/compiler/

[Mesa-dev] [PATCH 14/18] nir/spirv: Compact vtn_type

2017-06-29 Thread Jason Ekstrand
Use an anonymous union of structs to help keep the structure small and better organized. --- src/compiler/spirv/spirv_to_nir.c | 1 - src/compiler/spirv/vtn_private.h | 64 --- 2 files changed, 39 insertions(+), 26 deletions(-) diff --git a/src/compiler/spirv

[Mesa-dev] [PATCH 13/18] nir/spirv: Simplify type copying

2017-06-29 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 3d9ef76..c69cb8c 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -

[Mesa-dev] [PATCH 15/18] nir/spirv: Beef up the type system a bit

2017-06-29 Thread Jason Ekstrand
This adds a vtn concept of base_type as well as a couple of other fields. This lets us be a tiny bit more efficient in some cases but, more importantly, it will eventually let us express things the GLSL type system can't. --- src/compiler/spirv/spirv_to_nir.c | 67 +++-

[Mesa-dev] [PATCH 16/18] nir/spirv: Stop using glsl_type for function types

2017-06-29 Thread Jason Ekstrand
We're going to want the full vtn_type available to us anyway at which point glsl_type isn't really buying us anything. --- src/compiler/spirv/spirv_to_nir.c | 23 +-- src/compiler/spirv/vtn_cfg.c | 30 +- src/compiler/spirv/vtn_private.h | 9 +

[Mesa-dev] [PATCH 12/18] nir/spirv: Compute offsets for UBOs and SSBOs up-front

2017-06-29 Thread Jason Ekstrand
Now that we have a pointer wrapper class, we can create offsets for UBOs and SSBOs up-front instead of waiting until we have the full access chain. For push constants, we still use the old mechanism because it provides us with some nice range information. --- src/compiler/spirv/vtn_private.h |

Re: [Mesa-dev] [Intel-gfx] [PATCH libdrm 3/3] intel: PCI Ids for U SKU in CFL

2017-06-29 Thread Rodrigo Vivi
series merged to libdrm. thanks for patches and review. On Wed, Jun 28, 2017 at 2:09 PM, Clint Taylor wrote: > > > On 06/21/2017 09:39 AM, Anusha Srivatsa wrote: >> >> Add the PCI IDs for U SKU IN CFL by following the spec. >> >> v2: Update IDs >> >> Cc: Rodrigo Vivi >> Signed-off-by: Anusha Sri

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Alex Deucher
On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: > I want to remove vc4's dependency on headers from libdrm as well, but > storing multiple copies of drm_fourcc.h in our tree would be silly. > > v2: Update Android.mk as well, move distcheck drm*.h references to > top-level noinst_HEADERS.

Re: [Mesa-dev] [PATCH 1/8] swr/rast: Split backend.cpp to improve compile time

2017-06-29 Thread Rowley, Timothy O
> On Jun 28, 2017, at 3:56 AM, Emil Velikov wrote: > > On 26 June 2017 at 17:14, Rowley, Timothy O > wrote: >> >> On Jun 26, 2017, at 7:57 AM, Emil Velikov wrote: > +.INTERMEDIATE: backend.intermediate >>> I have limited experience with .INTERMEDIATE and it didn't seem to >>> bri

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #8 from Trevor SANDY --- MSYS2 Setup Details - FYI MSYS2 Install: • Download and install msys2-x86_64-.exe (see instructions at http://www.msys2.org/) • Install to C:\msys64 (be sure to check 'Run MSYS2 now.' on the last install dia

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Rob Herring
On Thu, Jun 29, 2017 at 10:42 AM, Eric Anholt wrote: > I want to remove vc4's dependency on headers from libdrm as well, but > storing multiple copies of drm_fourcc.h in our tree would be silly. > > v2: Update Android.mk as well, move distcheck drm*.h references to > top-level noinst_HEADERS.

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Eric Anholt
Kenneth Graunke writes: > [ Unknown signature status ] > On Wednesday, June 28, 2017 11:18:40 AM PDT Eric Anholt wrote: >> I really liked this idea, as it should help with management of packet >> parsing tools like the CL dump. The python script is forked off of theirs >> because our packets are

Re: [Mesa-dev] [PATCH 2/5] vc4: Switch back to using a local copy of vc4_drm.h.

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 16:38, Eric Anholt wrote: > Emil Velikov writes: > >> Hi Eric, >> >> On 29 June 2017 at 02:15, Eric Anholt wrote: >>> Needing to get our uapi header from libdrm has only complicated things. >>> Follow intel's lead and drop our requirement for it. >>> >> UAPI: I think I may hav

Re: [Mesa-dev] [PATCH v3 5/5] android: build imx-drm winsys

2017-06-29 Thread Emil Velikov
On 29 June 2017 at 16:35, Robert Foss wrote: > On Thu, 2017-06-29 at 15:28 +0100, Emil Velikov wrote: >> On 28 June 2017 at 22:52, Robert Foss >> wrote: >> > From: Tomeu Vizoso >> > >> > Add Android.mk for winsys/imx/drm. >> > >> > Signed-off-by: Tomeu Vizoso >> > Reviewed-by: Tapani Pälli >>

[Mesa-dev] [PATCH] swr: Minor cleanup of variable usage, no functional change.

2017-06-29 Thread Bruce Cherniak
In swr_update_derived, for consistency, index buffer validation should be using the p_draw_info copy "info" rather than referencing p_draw_info. No functional change. --- src/gallium/drivers/swr/swr_state.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 00/14] AMD winsys cleanups, heaps, suballocation for textures

2017-06-29 Thread Marek Olšák
Hi, This is mainly a cleanup series. RADEON_FLAG_CPU_ACCESS(_REQUIRED) is no longer used. CPU access can only be disallowed from now on, but it can't be enforced. See amd-gfx for more discussion. If we stay conservative, we only need 5 memory heaps, including the VRAM_GTT heap, which isn't used

[Mesa-dev] [PATCH 02/14] gallium/radeon: ignore PIPE_BIND_SHARED for buffers

2017-06-29 Thread Marek Olšák
From: Marek Olšák BO exports can't be predicted this way. --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index 5336f55..342695c 100644 ---

[Mesa-dev] [PATCH 04/14] gallium/radeon: rename RADEON_FLAG_HANDLE -> RADEON_FLAG_NO_SUBALLOC

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r300/r300_texture.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 2 +- src/gallium/drivers/radeon/radeon_winsys.h| 2 +- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 +++--- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4 ++--

[Mesa-dev] [PATCH 01/14] radeonsi: add a HUD query for getting an average GFX BO list size

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 18 ++ src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 +++ src/gallium/winsys/amdg

[Mesa-dev] [PATCH 03/14] gallium/radeon: fix a possible crash for buffer exports

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index d68587b..139ab13 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH 05/14] gallium/radeon: clean up r600_texture_get_handle

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index c811d6a..e21dc37 100644 --- a/src/gal

[Mesa-dev] [PATCH 08/14] gallium/radeon: clean up (domain, flags) <-> (slab heap) translations

2017-06-29 Thread Marek Olšák
From: Marek Olšák This is cleaner, and we are down to 4 slabs. --- src/gallium/drivers/radeon/radeon_winsys.h| 62 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 44 +++- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- src/gallium/winsy

[Mesa-dev] [PATCH 06/14] gallium/radeon: disallow exports of sparse and suballocated BOs

2017-06-29 Thread Marek Olšák
From: Marek Olšák I think it's unsafe, because the slabs can reuse exported storage. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 7 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 7 +++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/amdgpu/

[Mesa-dev] [PATCH 09/14] gallium/radeon: enable suballocations for VRAM with no CPU access

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 15 --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/rad

[Mesa-dev] [PATCH 07/14] gallium/radeon: remove RADEON_FLAG_CPU_ACCESS

2017-06-29 Thread Marek Olšák
From: Marek Olšák https://lists.freedesktop.org/archives/amd-gfx/2017-June/010591.html --- src/gallium/drivers/radeon/r600_buffer_common.c | 4 src/gallium/drivers/radeon/radeon_winsys.h | 7 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 9 + src/gallium/winsys/amdg

[Mesa-dev] [PATCH 12/14] gallium/radeon: generalize the function for in-place texture reallocation

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 64 +-- 1 file changed, 43 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index e21dc37..40cb8c0 100644 --- a/src/gal

[Mesa-dev] [PATCH 10/14] gallium/radeon: clean up pb_cache bucket/usage determination

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 20 src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 21 + src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 21 + 3 files changed, 30 insertions(+), 32 deletions(-) d

[Mesa-dev] [PATCH 14/14] winsys/amdgpu: use 128KB BOs for suballocations of up to 64KB BOs

2017-06-29 Thread Marek Olšák
From: Marek Olšák This decreases the number of BOs, but might also increase memory usage. It's better for small textures. The gameplay is on the far right: https://people.freedesktop.org/~mareko/suballoc.svg --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 ++- src/gallium/winsys/amdgpu/dr

[Mesa-dev] [PATCH 11/14] gallium/radeon: add radeon_winsys::buffer_is_suballocated

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 3 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 8 src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 6 ++ 3 files changed, 17 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gal

[Mesa-dev] [PATCH 13/14] gallium/radeon: allow suballocating textures

2017-06-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 3 +++ src/gallium/drivers/radeon/r600_texture.c | 13 - 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_bu

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Rob Herring
On Wed, Jun 28, 2017 at 1:18 PM, Eric Anholt wrote: > I really liked this idea, as it should help with management of packet > parsing tools like the CL dump. The python script is forked off of theirs > because our packets are byte-based instead of dwords, and the changes to > do so while avoiding

[Mesa-dev] [PATCH 1/2] radeonsi: use a bitfield for tracking which shaders use bindless

2017-06-29 Thread Samuel Pitoiset
This will allow to skip few partial flushes when bindless descriptors have to be re-uploaded. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 4 +-- src/gallium/drivers/radeonsi/si_pipe.h | 4 +-- src/gallium/drivers/radeonsi/si_state_shaders.c | 3

[Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

2017-06-29 Thread Samuel Pitoiset
Only emit partial flushes when the underlying shader stages are using bindless samplers or images. This gets rid of 4% of partial flushes in the DOW3 benchmark. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 18 -- 1 file changed, 16 insertion

  1   2   >