[Mesa-dev] [Bug 101340] i915_surface.c:108:4: error: too few arguments to function ‘util_blitter_default_src_texture’

https://bugs.freedesktop.org/show_bug.cgi?id=101340 Bug ID: 101340 Summary: i915_surface.c:108:4: error: too few arguments to function ‘util_blitter_default_src_texture’ Product: Mesa Version: git Hardware: All

Re: [Mesa-dev] [PATCH] Fix glcpp test expectations

On Wed, Jun 7, 2017 at 11:42 PM, Iago Toral Quiroga wrote: > With commit f7741985be0234 the we have changed some preprocessor > error messages and warnings. Adapt related glcpp tests > expectations accoridngly. > --- > src/compiler/glsl/glcpp/tests/120-undef-builtin.c.expected | 6 +++---

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On 06/08/2017 09:36 AM, Tapani Pälli wrote: On 06/08/2017 06:05 AM, Tomasz Figa wrote: On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace wrote: More patches to break your formats... again ;) The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORM

[Mesa-dev] [Bug 101340] i915_surface.c:108:4: error: too few arguments to function ‘util_blitter_default_src_texture’

https://bugs.freedesktop.org/show_bug.cgi?id=101340 Vinson Lee changed: What|Removed |Added CC||mar...@gmail.com, |

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli wrote: > > On 06/08/2017 09:36 AM, Tapani Pälli wrote: >> >> >> >> On 06/08/2017 06:05 AM, Tomasz Figa wrote: >>> >>> On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace >>> wrote: More patches to break your formats... again ;) The Android

[Mesa-dev] [PATCH] i915g: Add blitter_context argument.

Fix build error. CC i915_surface.lo i915_surface.c:108:63: error: too few arguments to function call, expected 4, have 3 util_blitter_default_src_texture(&src_templ, src, src_level); ^ ../../../../src/gallium/auxiliary/util/

[Mesa-dev] regarding mesa/state_tracker/glsl_to_tgsi register renaming

Dear all, (and specifically to Dave Arlie), when looking at the TGSI code of shaders that fail on r600g because of too many temporaries used, I notes that often their lifetime is very short, like just assigned in one line and read the only time in the next line. Looking on the register-renam

Re: [Mesa-dev] [PATCH] glsl: Fix gl_shader_stage enum unsigned comparison

On 01.06.2017 03:04, Rob Herring wrote: Replace -1 with MESA_SHADER_NONE enum value to fix sign related warning: external/mesa3d/src/compiler/glsl/link_varyings.cpp:1415:25: warning: comparison of constant -1 with expression of type 'gl_shader_stage' is always true [-Wtautological-constant-out

Re: [Mesa-dev] [PATCH] util: make set's deleted_key_value declaration consistent with hash table one

On 30.05.2017 01:51, Vlad Golovkin wrote: This also silences following clang warnings: no previous extern declaration for non-static variable 'deleted_key' [-Werror,-Wmissing-variable-declarations] const void *deleted_key = &deleted_key_value; ^ no previous extern declaration for no

Re: [Mesa-dev] [PATCH V2 4/8] mesa: stop passing state bitfield to UpdateState()

Reviewed-by: Samuel Pitoiset On 06/08/2017 01:39 AM, Timothy Arceri wrote: The code comment which seems to have been added in cab974cf6c2db (from year 2000) says: "Set ctx->NewState to zero to avoid recursion if Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)" As far as I

Re: [Mesa-dev] [PATCH] Fix glcpp test expectations

Typo in your commit message, with that fixed: Reviewed-by: Samuel Pitoiset You forgot to add the Bugzilla tag as well. On 06/08/2017 08:42 AM, Iago Toral Quiroga wrote: With commit f7741985be0234 the we have changed some preprocessor error messages and warnings. Adapt related glcpp tests expe

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

There's another problem related to the hash tables: You need to call _mesa_hash_table_set_deleted_key(ht, NULL) to avoid a possible bug when a handle happens to be equal to the address of the default deleted key marker. I suggest adding a hash_table_create wrapper analogous to the other wrapp

Re: [Mesa-dev] [PATCH] vl, omx, va, vdpau, xvmc: don't set the priv pointer in context_create

On 07.06.2017 21:51, Marek Olšák wrote: From: Marek Olšák Unused and radeonsi ignores it anyway. Seems reasonable, though I'm not too familiar with the code. Acked-by: Nicolai Hähnle --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +- src/gallium/state_trackers/omx/vid_dec.c | 2 +-

Re: [Mesa-dev] [PATCH] Fix glcpp test expectations

On Thu, 2017-06-08 at 09:42 +0200, Samuel Pitoiset wrote: > Typo in your commit message, with that fixed: > > Reviewed-by: Samuel Pitoiset > > You forgot to add the Bugzilla tag as well. Right, thanks! Iago > On 06/08/2017 08:42 AM, Iago Toral Quiroga wrote: > > With commit f7741985be0234 the

Re: [Mesa-dev] [PATCH 1/7] radeonsi: don't update dependent states if it has no effect (v2)

On 07.06.2017 21:50, Marek Olšák wrote: From: Marek Olšák This and the previous commit decrease IB sizes and the number of si_update_shaders invocations as follows: Referencing the previous commit makes no sense anymore if it's the first in the series. Apart from that, this patch is Review

Re: [Mesa-dev] [PATCH 7/7] r600g: set pipe_context::priv = NULL

On 07.06.2017 21:50, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101254 --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r60

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

On 08.06.2017 09:21, Vinson Lee wrote: Fix build error. CC i915_surface.lo i915_surface.c:108:63: error: too few arguments to function call, expected 4, have 3 util_blitter_default_src_texture(&src_templ, src, src_level);

[Mesa-dev] [Bug 101336] glcpp-test.sh regression

https://bugs.freedesktop.org/show_bug.cgi?id=101336 Iago Toral changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

Oops, sorry about that! Alex On 8 June 2017 at 03:00, Rob Herring wrote: > Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to > src/vulkan/util") broke the Android build with the following error: > > build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk: > libmesa_vul

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

On 06/08/2017 11:03 AM, Alex Smith wrote: Oops, sorry about that! my bad, for me it actually compiles fine even with the ')' but there is maybe some differences between mine and Rob's way of building Mesa Alex On 8 June 2017 at 03:00, Rob Herring > wrote: C

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: track range for writes in a if/else/endif blocks. (v2)

On 08.06.2017 05:23, Dave Airlie wrote: From: Dave Airlie This overhauls the copy prop and dead code passes to avoid major CPU overhead in some corner cases trigged by the fp64 patches v2: fix level not being updated correctly --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 123

Re: [Mesa-dev] [PATCH 2/2] RFC: radeon/compute: Limit allocations for VRAM-based chips to 3/4 VRAM

On 08.06.2017 04:15, Michel Dänzer wrote: On 08/06/17 03:42 AM, Marek Olšák wrote: On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote: On Mon, Jun 5, 2017 at 3:07 PM, Marek Olšák wrote: Can you make the change in radeon_drm_winsys.c instead? Something like the following? diff --git a/src/

Re: [Mesa-dev] [PATCH] mesa: add KHR_no_error support to glDrawRangeElements*()

Reviewed-by: Nicolai Hähnle On 08.06.2017 08:15, Timothy Arceri wrote: --- src/mesa/vbo/vbo_exec_array.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 437d260..4f86d19 100644 --- a/src/me

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

Hi Chad, On 8 June 2017 at 00:45, Chad Versace wrote: > On Tue 06 Jun 2017, Daniel Stone wrote: >> I wonder if it wouldn't be better to do this in >> intel_create_image_from_name. That way it would be more obvious >> up-front what's happening, > > I agree that the intent would become more obvious

Re: [Mesa-dev] [PATCH] mesa: add KHR_no_error support to glDrawRangeElements*()

Reviewed-by: Samuel Pitoiset On 06/08/2017 08:15 AM, Timothy Arceri wrote: --- src/mesa/vbo/vbo_exec_array.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 437d260..4f86d19 100644 --- a/sr

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

Hi Wladimir, did you also review this patch? It's the last one of this series missing review. Regards, Lucas Am Freitag, den 19.05.2017, 11:41 +0200 schrieb Lucas Stach: > Stolen from VC4. As we don't do any fancy reallocation tricks yet, it's > possible to upgrade also coherent mappings and sha

Re: [Mesa-dev] [PATCH 0/6] Shooting some piglits

2017-06-04 21:06 GMT+02:00 Lucas Stach : > Hi all, > > I decided to take a look at our current piglit status and the following are > some stright foward fixes for some of the issues. > > The first 3 patches fix some resource copy issues, that may send the blitter > into an infinite loop in a releas

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: track range for writes in a if/else/endif blocks. (v2)

On 08/06/17 18:08, Nicolai Hähnle wrote: On 08.06.2017 05:23, Dave Airlie wrote: From: Dave Airlie This overhauls the copy prop and dead code passes to avoid major CPU overhead in some corner cases trigged by the fp64 patches v2: fix level not being updated correctly --- src/mesa/state_tr

[Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

Specification states that in case of error, value should not be written, patch changes buffer age queries to return -1 in case of error so that we can skip changing the value. In addition, small change to droid_query_buffer_age to return 0 in case buffer does not have a back buffer available. Fix

Re: [Mesa-dev] [PATCH v2 27/64] gallium/util: add new util_dynarray_{shrink, delete} helpers

On 06/07/2017 06:21 PM, Nicolai Hähnle wrote: On 30.05.2017 22:35, Samuel Pitoiset wrote: These helpers will be used for handling dynamic arrays of resident texture/image handles. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/util/u_dynarray.h | 20 1 file

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

On 06/07/2017 05:58 PM, Nicolai Hähnle wrote: On 30.05.2017 22:35, Samuel Pitoiset wrote: v2: - s/GLboolean/bool for HandleAllocated - fix _mesa_has_ARB_shader_image_load_store() checks - use u_vector for texture/image handles - fix use of 64-bit handles on 32-bit systems -

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

On 06/08/2017 09:42 AM, Nicolai Hähnle wrote: There's another problem related to the hash tables: You need to call _mesa_hash_table_set_deleted_key(ht, NULL) to avoid a possible bug when a handle happens to be equal to the address of the default deleted key marker. I suggest adding a hash_t

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

Harish, please find small addition below. I noticed we still have one crasher in tests when this extension is enabled, it's related to buffer age so I've sent a fix separately here: https://lists.freedesktop.org/archives/mesa-dev/2017-June/158391.html On 06/07/2017 07:11 PM, Harish Krupo wrot

Re: [Mesa-dev] [PATCH 22/30] i965: Move images to the new resolve functions

FYI I bisected that starting from this commit (or maybe somewhere within this series) there are segfaults with systemui (using libhwui) in Android, it looks like below. Seems rather hard case to debug as it does not seem to always happen (!) but will try to figure out what is going wrong. ---

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

Final ping. If I don't hear anything, I'll push this with the changes requested by Timothy at the end of the week. Cheers, Nicolai On 22.05.2017 13:31, Nicolai Hähnle wrote: Hey Ian, Do you want more time to look into this? I double-checked that glslang accepts this code pattern. Cheers, N

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

Hi Tapani, On 06/08/2017 04:32 PM, Tapani Pälli wrote: Harish, please find small addition below. I noticed we still have one crasher in tests when this extension is enabled, it's related to buffer age so I've sent a fix separately here: https://lists.freedesktop.org/archives/mesa-dev/2017-Ju

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

On Thu, Jun 8, 2017 at 3:06 AM, Tapani Pälli wrote: > > > On 06/08/2017 11:03 AM, Alex Smith wrote: >> >> Oops, sorry about that! > > > my bad, for me it actually compiles fine even with the ')' but there is > maybe some differences between mine and Rob's way of building Mesa I think it's because

Re: [Mesa-dev] [PATCH 6/6] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

On Tue, Jun 6, 2017 at 3:37 PM, Chad Versace wrote: > The Android framework requires support for EGLConfigs with > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > Even though all RGBX formats are disabled on gen9 by > brw_surface_formats.c, the new configs work correctly on Broxton

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

Hello Lucas, On Thu, Jun 08, 2017 at 10:26:04AM +0200, Lucas Stach wrote: > Hi Wladimir, > > did you also review this patch? It's the last one of this series missing > review. Sorry, no, I missed it somehow. Looks obviously correct to me, and matches the code from VC4 (apart from the coherent w

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #1 from Eric Engestrom --- Hi John, You correctly gave the version number for the release-version of software you use, but you didn't give any information for the development-version of software you mentioned. Taking Mesa as an exam

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

On Thursday, 2017-06-08 13:10:58 +0300, Tapani Pälli wrote: > Specification states that in case of error, value should not be > written, patch changes buffer age queries to return -1 in case of > error so that we can skip changing the value. > > In addition, small change to droid_query_buffer_age

Re: [Mesa-dev] [PATCH 1/2] st/mesa: remove the "Gallium 0.4 on" prefix from GL_RENDERER

The version number is quite useless indeed (IIRC there was a gallium 0.3 at some point but given the non-stable abi which is instead changing bit by bit it has never been changed again). Not sure if removing "Gallium" is a really good idea, I think it might be helpful if you can easily see in the

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

Hi all, On 8 June 2017 at 13:06, Harish Krupo wrote: > Hi Tapani, > > > On 06/08/2017 04:32 PM, Tapani Pälli wrote: >> >> Harish, please find small addition below. >> >> I noticed we still have one crasher in tests when this extension is >> enabled, it's related to buffer age so I've sent a fix s

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

On Thursday, 2017-06-08 17:36:47 +0530, Harish Krupo wrote: > Hi Tapani, > > On 06/08/2017 04:32 PM, Tapani Pälli wrote: > > Harish, please find small addition below. > > > > I noticed we still have one crasher in tests when this extension is > > enabled, it's related to buffer age so I've sent a

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

On 06/08/2017 07:23 PM, Eric Engestrom wrote: On Thursday, 2017-06-08 17:36:47 +0530, Harish Krupo wrote: Hi Tapani, On 06/08/2017 04:32 PM, Tapani Pälli wrote: Harish, please find small addition below. I noticed we still have one crasher in tests when this extension is enabled, it's related

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

On 06/08/2017 07:23 PM, Emil Velikov wrote: Hi all, On 8 June 2017 at 13:06, Harish Krupo wrote: Hi Tapani, On 06/08/2017 04:32 PM, Tapani Pälli wrote: Harish, please find small addition below. I noticed we still have one crasher in tests when this extension is enabled, it's related to bu

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

On 8 June 2017 at 11:10, Tapani Pälli wrote: > Specification states that in case of error, value should not be > written, patch changes buffer age queries to return -1 in case of > error so that we can skip changing the value. > > In addition, small change to droid_query_buffer_age to return 0 > i

Re: [Mesa-dev] [PATCH 22/30] i965: Move images to the new resolve functions

If you can manage to get me a backtrace (bt full preferably), that would be fantastic! On Thu, Jun 8, 2017 at 4:34 AM, Tapani Pälli wrote: > FYI I bisected that starting from this commit (or maybe somewhere within > this series) there are segfaults with systemui (using libhwui) in Android, > it

[Mesa-dev] [PATCH 2/2] etnaviv: remove flat shading workaround

It turned out not to be a hardware bug, but the shader compiler emitting wrong varying component use information. With that fixed we can turn flat shading back on. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 6 +- 1 file changed, 1 insertion(+), 5 deleti

[Mesa-dev] [PATCH 1/2] etnaviv: fix varying interpolation

It seems that newer cores don't use the PA_ATTRIBUTES to decide if the varying should bypass the flat shading, but derive this from the component use. This fixes flat shading on GC880+. VARYING_COMPONENT_USE_POINTCOORD is a bit of a misnomer now, as it isn't only used for pointcoords, but missing

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

Am Donnerstag, den 08.06.2017, 15:08 +0200 schrieb Wladimir J. van der Laan: > Hello Lucas, > > On Thu, Jun 08, 2017 at 10:26:04AM +0200, Lucas Stach wrote: > > Hi Wladimir, > > > > did you also review this patch? It's the last one of this series missing > > review. > > Sorry, no, I missed it so

[Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

softpipe throws integer division by zero exceptions on windows when using % with integers in a geometry shader. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/ga

Re: [Mesa-dev] [PATCH 01/10] i965/blorp: Take a layer range in intel_hiz_exec

Patches 1-6, 8 are: Reviewed-by: Anuj Phogat On Mon, Jun 5, 2017 at 5:55 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 13 - > src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- > src/mesa/drivers/dri/i965/brw_clear.c | 10 --

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

I don't really know if it makes sense to have different "error values" for signed vs. unsigned modulo 0 - maybe the "all bits set" approach would do too (the gallivm code does this, because it is actually easier). But since it's undefined in any case pretty much everywhere, I suppose any value will

[Mesa-dev] [PATCH] Reduce zlib requirement from 1.2.8 to 1.2.3.

Testing with zlib versions 1.2.{3,4,5,6,7,8} showed no difference in functionality, correctness, or zlib API usage and 1.2.3 is the oldest version available in still actively deployed production Linux distributions (RHEL/CentOS 6 and SuSE 11). Signed-off-by: Chuck Atkins Cc: 17.1 Cc: Timothy Arc

Re: [Mesa-dev] [PATCH v2 27/64] gallium/util: add new util_dynarray_{shrink, delete} helpers

On Thu, Jun 8, 2017 at 12:26 PM, Samuel Pitoiset wrote: > > > On 06/07/2017 06:21 PM, Nicolai Hähnle wrote: >> >> On 30.05.2017 22:35, Samuel Pitoiset wrote: >>> >>> These helpers will be used for handling dynamic arrays of resident >>> texture/image handles. >>> >>> Signed-off-by: Samuel Pitoiset

[Mesa-dev] [Bug 100402] [d3d9 bisected] Diablo III fails to start after commit 0630d3600bfb770cf3b23761c45b3add3b277c6b

https://bugs.freedesktop.org/show_bug.cgi?id=100402 Nick Tenney changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] intel/blorp: Work around Sandy Bridge occlusion query issue

--- src/intel/blorp/blorp_clear.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 3d5c41c..efacadf 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c @@ -479,6 +479,16 @@ blorp_clear_dep

Re: [Mesa-dev] [PATCH 00/11] i965: Use BLORP for depth/stencil clears

On Tue, Jun 6, 2017 at 9:59 PM, Jason Ekstrand wrote: > This little series switches the GL driver to use BLORP for depth and > stencil clears. BLORP has had depth/stencil clear support ever since we > started using it in the Vulkan driver but we didn't hook it up in GL > because of a few very ha

Re: [Mesa-dev] [PATCH 6/6] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

On Thu 08 Jun 2017, Rob Herring wrote: > On Tue, Jun 6, 2017 at 3:37 PM, Chad Versace wrote: > > The Android framework requires support for EGLConfigs with > > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > > > Even though all RGBX formats are disabled on gen9 by > > brw_surface_fo

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

Reviewed-by: Juan A. Suarez Romero On Thu, 2017-06-08 at 07:21 +, Vinson Lee wrote: > Fix build error. > > CC i915_surface.lo > i915_surface.c:108:63: error: too few arguments to function call, expected 4, > have 3 >util_blitter_default_src_texture(&src_templ, src, src_level);

Re: [Mesa-dev] [PATCH v14 08/36] gallium/winsys/drm: introduce modifier field to winsys_handle

Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > we use this to import resources with format modifiers, and to support > per-resource modifier queries. > > Signed-off-by: Varad Gautam > Cc: Lucas Stach Reviewed-by: Lucas Stach > --- > src/gallium/incl

Re: [Mesa-dev] [PATCH v14 09/36] st/dri: enable DRIimage modifier queries

Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > return the modifier selected by the driver when creating this image. > > v2: since we can use winsys_handle->modifier to serve these, remove > DRIimage->modifier from v1. > use DRM_API_HANDLE_TYPE_KMS

Re: [Mesa-dev] [PATCH v14 10/36] st/dri: implement createImageWithModifiers in DRIimage

Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > adds a pscreen->resource_create_with_modifiers() to create textures > with modifier. > > v2: > - stylefixes (Emil Velikov) > - don't return selected modifier from resource_create_with_modifiers. we can > us

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

Reviewed-by: Marek Olšák Marek On Thu, Jun 8, 2017 at 9:21 AM, Vinson Lee wrote: > Fix build error. > > CC i915_surface.lo > i915_surface.c:108:63: error: too few arguments to function call, expected 4, > have 3 >util_blitter_default_src_texture(&src_templ, src, src_level); >~~

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On Thu 08 Jun 2017, Tomasz Figa wrote: > On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli wrote: > > > > On 06/08/2017 09:36 AM, Tapani Pälli wrote: > >> > >> > >> > >> On 06/08/2017 06:05 AM, Tomasz Figa wrote: > >>> > >>> On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace > >>> wrote: > > More

Re: [Mesa-dev] [PATCH v14 13/36] gallium: introduce format modifier querying

Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > format modifiers tokens are driver specific, and hence, need to come > in from the driver. this allows drivers to be queried for supported > format modifiers for EGL_EXT_image_dma_buf_import_modifiers. > > v2

Re: [Mesa-dev] [PATCH v14 14/36] st/dri: support format modifier queries

Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > ask the driver for supported modifiers for a given format. > > v2: move to __DRIimageExtension v16. > v3: fail if the supplied format is not supported by driver. > v4: purge PIPE_CAP_QUERY_DMABUF_ATTRIBS. > v

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

On Thu 08 Jun 2017, Tapani Pälli wrote: > Specification states that in case of error, value should not be > written, patch changes buffer age queries to return -1 in case of > error so that we can skip changing the value. > > In addition, small change to droid_query_buffer_age to return 0 > in cas

Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

It would be better if the function wasn't inline and was placed before st_invalidate_state to keep those two together. Marek On Wed, Jun 7, 2017 at 8:02 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_cb_fbo.c | 5 +++-- > src/mesa/state_tracker/st_context.c | 15 +++ >

[Mesa-dev] [PATCH 3.1/24] intel/genxml: Add gen10 alias for MOCS

From: Ander Conselvan de Oliveira This patch will be squashed with PATCH 3/24 before upstreaming. Signed-off-by: Ander Conselvan de Oliveira Cc: Jason Ekstrand --- src/intel/genxml/gen10.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen

[Mesa-dev] [PATCH 3.2/24] intel/genxml: Make 3DSTATE_CONSTANT_BODY on Gen10 use arrays

From: Ander Conselvan de Oliveira This patch will be squashed with "[PATCH 03/24] i965/cnl: Add gen10.xml" before upstreaming. Signed-off-by: Ander Conselvan de Oliveira Signed-off-by: Anuj Phogat Cc: Jason Ekstrand --- src/intel/genxml/gen10.xml | 14 ++ 1 file changed, 6 inser

[Mesa-dev] [RFC 03/22] intel/isl: Add ISL <-> GEM tiling conversion

Add a simple conversion from ISL tiling to GEM BO tiling flags, and use that instead of hardcoding I915_TILING_X in the ANV WSI. Signed-off-by: Daniel Stone --- src/intel/isl/isl.c| 28 src/intel/isl/isl.h| 8 src/intel/vulkan/anv_wsi.c | 6

[Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

Hi, With full support for modifiers in DRIimage, this patch series adds support for fully plumbing them through X11. A patchset proposing an extension to DRI3 to support multiple planes and modifiers can be found here: https://lists.x.org/archives/xorg-devel/2017-June/053854.html The Git trees, al

[Mesa-dev] [RFC 04/22] isl: Add isl_surf_get_drm_format_mod()

From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 330c3d6c87..b78a22df8c 100644 --- a/src/inte

[Mesa-dev] [RFC 02/22] intel/isl: Add ISL <-> DRM modifier conversion

From: Chad Versace It converts a DRM format modifier to and from enum isl_tiling and aux_usage. That's all. Signed-off-by: Daniel Stone --- src/intel/Makefile.isl.am | 1 + src/intel/isl/isl.c | 59 +++ src/intel/isl/isl.h | 16 +

[Mesa-dev] [RFC 05/22] anv: Add func anv_get_raw_format()

From: Chad Versace Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8

[Mesa-dev] [RFC 11/22] anv: Handle failure in make_hiz_surface_maybe()

From: Chad Versace make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe() to do the same. Signed-off-

[Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

From: Louis-Francis Ratté-Boulianne Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Daniel St

[Mesa-dev] [RFC 16/22] RFC: anv: Implement VK_MESAX_external_image_dma_buf

From: Chad Versace For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_device.c | 4 + src/intel/

[Mesa-dev] [RFC 22/22] RFC: vulkan/wsi: Add support for DRI3 v1.1

Adds support for multiple planes and buffer modifiers. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_wsi.c | 7 +- src/vulkan/wsi/wsi_common_x11.c | 137 2 files changed, 131 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/anv_

[Mesa-dev] [RFC 08/22] anv/image: Refactor how tiling is chosen

From: Chad Versace The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. Signed-off-by: Daniel Stone --

[Mesa-dev] [RFC 07/22] anv/image: Better var names in vkCreateImage

From: Chad Versace - Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming extensions, because the extensions

[Mesa-dev] [RFC 18/22] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

From: Chad Versace When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In anv_wsi.c, replace the combo o

[Mesa-dev] [RFC 17/22] RFC: anv: Drop vkCreateDmaBufImageINTEL()

From: Chad Versace This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled VkImage and examine it. No V

[Mesa-dev] [RFC 15/22] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

From: Chad Versace For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_device.c

[Mesa-dev] [RFC 20/22] RFC: anv: Drop unneeded struct anv_image_create_info

From: Chad Versace Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 38 +++--- src/intel/vulkan/anv_priva

[Mesa-dev] [RFC 14/22] RFC: anv: Implement VK_EXT_get_image_properties

From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_image.c| 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RFC 10/22] anv/image: Refactor creation of aux surfaces

From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe() For clarity, also rename ma

[Mesa-dev] [RFC 21/22] RFC: vulkan/wsi: Add modifiers to WSI image creation

Allow the WSI to provide a set of modifiers to be used along with the format. For now, no winsys provides any modifier support. Add a fallback to the previous default (X-tiling) inside ANV. RADV remains somewhat broken in the presence of a winsys which will suggest modifiers, but with a Vulkan dr

[Mesa-dev] [RFC 19/22] RFC: anv: Drop unused anv_image_create()

From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index a1cc514

[Mesa-dev] [RFC 09/22] anv/image: Fix return type of make_surface()

From: Chad Versace make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2 inserti

[Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

From: Chad Versace Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf - VK_MESAX_external_image_dma_buf

[Mesa-dev] [RFC 12/22] anv: Set anv_surface::offset earlier

From: Chad Versace Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 1

[Mesa-dev] [RFC 06/22] anv: Annotate anv_get_*format() as pure

From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index c4a897d061..f121b55d91 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [PATCH 2/2] gbm: implement FD import with modifier

This implements a way to import FDs with modifiers on plain GBM devices, without the need to go through EGL. This is mostly to the benefit of gbm_gralloc, which can keep its dependencies low. Signed-off-by: Lucas Stach --- src/gbm/backends/dri/gbm_dri.c | 54 +

[Mesa-dev] [PATCH 1/2] gbm: add API to to import FD with modifier

This allows to import an FD with an explicit modifier passed through userspace protocols. Signed-off-by: Lucas Stach --- src/gbm/main/gbm.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index b52137ed01d4..6a9bf1fc2a80 100644 --- a/src/

[Mesa-dev] [PATCH] radv: introduce perf test env var and allow to enable chaining

From: Dave Airlie We have some features that seem to slow things down or cause other possible undesireable side effects, but it would be nice to test games etc with them easily. I forsee multisample DCC and maybe some shader opt changes using this. For now use it for batch chaining. Signed-off

[Mesa-dev] [PATCH] radeonsi: call LLVMAddEarlyCSEMemSSAPass only for LLVM >= 4.0

LLVMAddEarlyCSEMemSSAPass() is defined in LLVM 4.0. Fixes: 257b538 ("radeonsi: do EarlyCSEMemSSA LLVM pass) --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c b/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 7/7] i965: Add format/modifier advertising

On Tue, Jun 6, 2017 at 10:18 AM, Daniel Stone wrote: > From: Varad Gautam > > v2: Rebase and reuse tiling/modifier map. (Daniel Stone) > v3: bump DRIimageExtension to version 15, fill external_only array. > > Signed-off-by: Varad Gautam > Signed-off-by: Daniel Stone > --- > src/mesa/drivers/d

  1   2   >