Re: [Mesa-dev] [PATCH 1/3] anv: Stop racing relocation offsets

On Wed, May 10, 2017 at 04:08:53PM -0700, Jason Ekstrand wrote: > One of the key invariants of the relocation system is the > presumed_offset field. The assumption is made that the value currently > in the address to be relocated agrees with the presumed_offset field. > If presumed_offset is equal

Re: [Mesa-dev] [PATCH 3/3] anv: Don't record the handle in the relocation

On Wed, May 10, 2017 at 04:08:55PM -0700, Jason Ekstrand wrote: > We use the look-up table mechanism for relocations so this isn't the > value we want. The correct value is filled out at execbuf2 time by > anv_cmd_buffer_process_relocs. > --- > src/intel/vulkan/anv_batch_chain.c | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 5/5] etnaviv: increment the resource seqno in resource_changed

On Wed, 2017-05-10 at 20:14 +0200, Wladimir J. van der Laan wrote: > Seems more straightforward, but I don't know the rationale > why it was done the way it was. > > Reviewed-By: Wladimir J. van der Laan The rationale essentially was "the texture must be older than the imported renderable so it

Re: [Mesa-dev] [PATCH 4/5] etnaviv: clean up sampler view reference counting

Hi Christian, Am Mittwoch, den 10.05.2017, 21:44 +0200 schrieb Christian Gmeiner: > Hi Lucas, > > 2017-05-10 18:01 GMT+02:00 Lucas Stach : > > Use the proper pipe_resource_reference function instead of > > rolling our own. > > Would it make sense to convert all gallium drivers using this pattern

[Mesa-dev] [PATCH] anv: Canonicalize known offsets

When we add the reloc, we write the value of the relocation target using non-canonical form. If we later patch up the address prior to command submission, we will rewrite it using canonical form. We should always write the address in canonical form in case we skip the relocation (as the target did

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #15 from talonz --- just updated mesa-git today and also have no problems, thank you for the patch and hard work. -- You are receiving this mail because: You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH] configure.ac: Fix help string for --disable-pwr8 configure option

On Wednesday, 2017-05-10 17:44:29 +0200, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index df3eb6b29a..5c460f43d5 100644 > --- a/configure.ac > +++ b/configure.ac >

Re: [Mesa-dev] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

On 25/04/17 06:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The incomplete framebuffer is set for a surfaceless context. This leads to > the following error in piglit spec@egl_khr_surfaceless_context@viewport: [...] > diff --git a/src/mesa/state_tracker/st_manager.c > b/src/mesa/sta

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

On May 11, 2017 2:30 AM, "Timothy Arceri" wrote: On 11/05/17 08:45, Marek Olšák wrote: > Hi, > > This series adds an optional module into gallium/util that wraps > around pipe_context and moves execution of all pipe_context calls into > a separate thread. > > It puts a lot of new requirements on

Re: [Mesa-dev] [PATCH 13/13] radeonsi: enable threaded_context

On May 11, 2017 5:55 AM, "Dieter Nützel" wrote: For the series: Tested-by: Dieter Nützel on radeonsi / RX580, 8 GB Unigine_Heaven-4.0 Unigine_Valley-1.0 Unigine_Superposition-1.0 running wine-2.7_gallium_nine+staging FYI, it's disabled with nine. Marek Steam: PES2015 + TS2017 LS2015 + L

[Mesa-dev] [PATCH] mesa: remove unused gl_program_parameter::Initialized

Signed-off-by: Samuel Pitoiset --- src/mesa/program/prog_parameter.c | 1 - src/mesa/program/prog_parameter.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c index 6689c71f24..44e680c048 100644 --- a/src/mesa/program/prog

Re: [Mesa-dev] [PATCH 5/9] i965: remove unused context

On 04/12/2017 01:04 AM, Thomas Hindoe Paaboel Andersen wrote: --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 -- src/mesa/drivers/dri/i965/intel_pixel_draw.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i

Re: [Mesa-dev] Trivial code cleanups

Patches 3 & 7 Reviewed-by: Tapani Pälli On 04/12/2017 01:03 AM, Thomas Hindoe Paaboel Andersen wrote: A mix of fixes for static analysis warnings, recent indentation mistakes, and unnecessary null checks before free. ___ mesa-dev mailing list mesa-

Re: [Mesa-dev] [PATCH 4/9] mesa: fix misleading indentation

On 04/12/2017 01:04 AM, Thomas Hindoe Paaboel Andersen wrote: --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 187475f..9efb2e0 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 2/3] glsl: simplify set_opaque_binding()

While we are at it, update the GLSL spec comment. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniform_initializers.cpp | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/src/compiler/glsl/link_uniform_initializers.cpp b/src/compiler/gls

[Mesa-dev] [PATCH 3/3] glsl: pass the ir_variable object to set_opaque_binding()

Useful when it's needed to rely on variable data. Will be used for bindless samplers/images in a future patches series. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniform_initializers.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/

[Mesa-dev] [PATCH 1/3] glsl: add missing check for samplers in set_opaque_binding()

Like images, this prevents out-of-bound access when the explicit binding layout qualifier is used with an array which contains too much samplers. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniform_initializers.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/

Re: [Mesa-dev] [PATCH] anv: Canonicalize known offsets

On Thu, May 11, 2017 at 11:09 AM, Chris Wilson wrote: > When we add the reloc, we write the value of the relocation target using > non-canonical form. If we later patch up the address prior to command > submission, we will rewrite it using canonical form. We should always > write the address in ca

Re: [Mesa-dev] [PATCH 2/3] glsl: simplify set_opaque_binding()

Yeah this is from a time before we used a shared opaque array for things like active. Looks good :) 1-2 are: Reviewed-by: Timothy Arceri The next patch does what you say, but it feels odd reviewing it without any patches that use it. I think you should just bundle that with the upcoming ser

[Mesa-dev] [PATCH 5/6] mesa: Add conversion from double to uint64/int64 in GetUniform*i64v()

--- src/mesa/main/uniform_query.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 42abd18..25acc31 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp @@ -579,6 +579,13 @@ _

[Mesa-dev] [PATCH 6/6] mesa: conversion from float in GetUniformi64v require rounding to nearest

As we do for all other cases of float/double conversions to integers. --- src/mesa/main/uniform_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 25acc31..76b872d 100644 --- a/src/mesa/main/uniform_

[Mesa-dev] [PATCH 3/6] mesa: Clamp GetUniformui64v values to be >= 0

Like we do for the 32-bit case. --- src/mesa/main/uniform_query.cpp | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 315973a..42abd18 100644 --- a/src/mesa/main/unif

[Mesa-dev] [PATCH 2/6] mesa: Clamp GetUniformuiv values to be >= 0

From: Kenneth Graunke Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 October 24th 2016 specification says: "If a command returning unsigned integer data is called, such as GetSamplerParameterIuiv, negative values are clamped to zero." v2: uint to int conversion sho

[Mesa-dev] [PATCH 0/6] Various fixes to integer GetUniform*()

This series is an update on a previous patch by Ken that fixed a CTS test but never got merged due to the mess with the CTS repositories at that time, plus a number of additional fixes for recently added int64 paths. Patch 1 fixes indentation. Patch 2 is the original patch by Ken, only tha rebased

[Mesa-dev] [PATCH 4/6] mesa/main: add IROUNDD64() helper

--- src/mesa/main/imports.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index ef7c378..416c59b 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -165,6 +165,13 @@ static inline GLint64 IROUND64(float f) return

[Mesa-dev] [PATCH 1/6] mesa/main: fix indentation in _mesa_get_uniform()

--- src/mesa/main/uniform_query.cpp | 194 1 file changed, 99 insertions(+), 95 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 0e02a76..bd5b4c4 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/m

Re: [Mesa-dev] [PATCH] anv: Canonicalize known offsets

On Thu, May 11, 2017 at 01:51:40PM +0300, Grazvydas Ignotas wrote: > On Thu, May 11, 2017 at 11:09 AM, Chris Wilson > wrote: > > When we add the reloc, we write the value of the relocation target using > > non-canonical form. If we later patch up the address prior to command > > submission, we wi

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 1 May 2017 at 12:09, Mauro Rossi wrote: > Fixes the following building error happening on marshmallow-x86 > with Ubuntu 16.04 LTS stock build essentials package > and by the book Android build system. > > external/mesa/src/mesa/drivers/dri/i965/brw_performance_query.c: In function > 'open_i915

Re: [Mesa-dev] [PATCH] egl: fold Android logger into main/ (v2)

On 9 May 2017 at 00:24, Mauro Rossi wrote: > Fixes the folloing building error: > > external/mesa/src/egl/drivers/dri2/platform_android.c:1492:19: > error: use of undeclared identifier 'droid_log' >_eglSetLogProc(droid_log); > ^ > 1 error generated. > > Fixes: 0372097 "egl: f

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi wrote: Fixes the following building error happening on marshmallow-x86 with Ubuntu 16.04 LTS stock build essentials package and by the book Android build system. external/mesa/src/mesa/drivers/dri/i965/brw_perfor

Re: [Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

On 13 March 2017 at 13:10, Emil Velikov wrote: > On 11 March 2017 at 16:26, Mauro Rossi wrote: >> 2017-03-08 17:44 GMT+01:00 Emil Velikov : >>> >>> On 5 March 2017 at 21:23, Mauro Rossi wrote: >>> > Adding libmesa_amd_common dependency and exporting its headers, >>> > avoids the following buildi

Re: [Mesa-dev] [PATCH] mesa: remove unused gl_program_parameter::Initialized

Reviewed-by: Timothy Arceri On 11/05/17 20:06, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/program/prog_parameter.c | 1 - src/mesa/program/prog_parameter.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/pro

Re: [Mesa-dev] [PATCH 4/5] etnaviv: clean up sampler view reference counting

Hi Lucas, 2017-05-11 10:06 GMT+02:00 Lucas Stach : > Hi Christian, > > Am Mittwoch, den 10.05.2017, 21:44 +0200 schrieb Christian Gmeiner: >> Hi Lucas, >> >> 2017-05-10 18:01 GMT+02:00 Lucas Stach : >> > Use the proper pipe_resource_reference function instead of >> > rolling our own. >> >> Would i

Re: [Mesa-dev] [PATCH] egl: fold Android logger into main/ (v2)

2017-05-11 13:25 GMT+02:00 Emil Velikov : > On 9 May 2017 at 00:24, Mauro Rossi wrote: >> Fixes the folloing building error: >> >> external/mesa/src/egl/drivers/dri2/platform_android.c:1492:19: >> error: use of undeclared identifier 'droid_log' >>_eglSetLogProc(droid_log); >>

Re: [Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

2017-05-11 13:28 GMT+02:00 Emil Velikov : > On 13 March 2017 at 13:10, Emil Velikov wrote: >> On 11 March 2017 at 16:26, Mauro Rossi wrote: >>> 2017-03-08 17:44 GMT+01:00 Emil Velikov : On 5 March 2017 at 21:23, Mauro Rossi wrote: > Adding libmesa_amd_common dependency and exporti

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

Hi Randy, On 5 May 2017 at 08:17, Xu, Randy wrote: > Ping Chad & Emil & Tapani > > Please help to review it, I just verified it on Intel i965 driver. > All three of us are already subscribed to the list, so we get the patch ;-) Please don't ping immediately after you post a patch - this tends to

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

Got it, and I will follow this rule ;) Thanks, Randy > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, May 11, 2017 8:26 PM > To: Xu, Randy > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL l

[Mesa-dev] [PATCH v3 2/9] mesa: add KHR_no_error support for glUseProgram

V3: use always_inline attribute (Suggested by Nicolai) Cc: Nicolai Hähnle --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 65 ++- src/mesa/main/shaderapi.h | 2 ++ 3 files changed, 48 insertions(+), 21 deletions(-) diff --g

[Mesa-dev] [PATCH v3 4/9] mesa: add no error support to frame_buffer_texture_layer() helper

--- src/mesa/main/fbobject.c | 70 +--- 1 file changed, 43 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8e650a2..bdce10d 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -34

[Mesa-dev] [PATCH v3 5/9] mesa: add KHR_no_error support for FramebufferTextureLayer

V3: use frame_buffer_texture_layer() helper --- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/fbobject.c | 9 + src/mesa/main/fbobject.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/g

[Mesa-dev] [PATCH v3 3/9] mesa: add frame_buffer_texture_layer() helper

To be used to add KHR_no_error support while sharing code between the DSA and non-DSA OpenGL function. --- src/mesa/main/fbobject.c | 85 ++-- 1 file changed, 31 insertions(+), 54 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobje

[Mesa-dev] [PATCH v3 1/9] mesa: move use_program() inside _mesa_use_program()

--- src/mesa/main/shaderapi.c | 50 --- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 7430cfe..f63215a 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@

[Mesa-dev] [PATCH v3 7/9] mesa: add *FramebufferTexture() support to frame_buffer_texture helper

--- src/mesa/main/fbobject.c | 138 +-- 1 file changed, 38 insertions(+), 100 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8e25dfa..0ff31ec 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -3

[Mesa-dev] [PATCH v3 8/9] mesa: add KHR_no_error support for FramebufferTexture

V3: use the frame_buffer_texture() helper --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/fbobject.c| 9 + src/mesa/main/fbobject.h| 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml index d2c768d..

[Mesa-dev] [PATCH v3 9/9] mesa: add KHR_no_error support for NamedFramebufferTexture

V3: use frame_buffer_texture() helper --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 8 src/mesa/main/fbobject.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/AR

[Mesa-dev] [PATCH v3 6/9] mesa: add KHR_no_error support for NamedFramebufferTextureLayer

v3: use frame_buffer_texture_layer() helper --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 12 src/mesa/main/fbobject.h | 5 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/ma

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

Hi Randy, Found this stuck in my Drafts. On 11 January 2017 at 08:04, Randy Xu wrote: > On Android platform, the EGL configuration query (eglGetConfigs) will > check the DRI backend. Add R8G8B8A8 and R8G8B8X8 to meet the native app > test requirement (like gl2_basic etc.). > > Reorder the list a

Re: [Mesa-dev] [PATCH] egl: fold Android logger into main/ (v2)

On 11 May 2017 at 13:07, Mauro Rossi wrote: > 2017-05-11 13:25 GMT+02:00 Emil Velikov : >> On 9 May 2017 at 00:24, Mauro Rossi wrote: >>> Fixes the folloing building error: >>> >>> external/mesa/src/egl/drivers/dri2/platform_android.c:1492:19: >>> error: use of undeclared identifier 'droid_log' >

Re: [Mesa-dev] [PATCH] egl: fold Android logger into main/ (v2)

2017-05-11 14:38 GMT+02:00 Emil Velikov : > On 11 May 2017 at 13:07, Mauro Rossi wrote: >> 2017-05-11 13:25 GMT+02:00 Emil Velikov : >>> On 9 May 2017 at 00:24, Mauro Rossi wrote: Fixes the folloing building error: external/mesa/src/egl/drivers/dri2/platform_android.c:1492:19:

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

Thanks, Emil Yes, I have discussed it with Tapani, my proposed solution is not good for desktop Linux. We will keep the change for Android only. And I will take care of it. Thanks, Randy > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, May

Re: [Mesa-dev] Building error in android-x86

Hi Mauro, Mostly rewording what Marek already said. On 6 May 2017 at 15:16, Mauro Rossi wrote: > 2017-05-06 12:15 GMT+02:00 Marek Olšák : >> >> Hi, >> >> There are several options: >> - Use Mesa 17.1 instead of master >> - Drop support for radeonsi in Nougat if you have to use master >> - Revert

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 11 May 2017 at 13:43, Xu, Randy wrote: > Thanks, Emil > > Yes, I have discussed it with Tapani, my proposed solution is not good for > desktop Linux. > We will keep the change for Android only. And I will take care of it. > What I'm saying is that you don't need to keep that change for Android

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 11/05/17 12:27, Tapani Pälli wrote: On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi wrote: Fixes the following building error happening on marshmallow-x86 with Ubuntu 16.04 LTS stock build essentials package and by the book Android build system. external/m

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 11/05/17 13:58, Lionel Landwerlin wrote: On 11/05/17 12:27, Tapani Pälli wrote: On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi wrote: Fixes the following building error happening on marshmallow-x86 with Ubuntu 16.04 LTS stock build essentials package and

[Mesa-dev] [PATCH 4/4] anv: Allocate buffer offsets from userspace

A very simple allocator that increments from the last globally allocated offset and assigns that for the lifetime of this bo for every context. Once we run out of space, we delegate finding holes to the kernel. In the future, we can opt to handle this ourselves as well, but a 48b address space mean

[Mesa-dev] [PATCH 1/4] anv: Canonicalize known offsets

When we add the reloc, we write the value of the relocation target using non-canonical form. If we later patch up the address prior to command submission, we will rewrite it using canonical form. We should always write the address in canonical form in case we skip the relocation (as the target did

[Mesa-dev] [PATCH 2/4] anv: Split tracking of bo and relocation entries

Track seen bo for a reloc list separately from the bo used by the relocs. This is a step towards not using the relocation entries themselves, but we still need to track the used bo and provide those to the kernel. In the short term, since the array of unique is likely small, we can try to keep it

[Mesa-dev] [PATCH 3/4] anv: Always set the reloc value to match the presumed_offset

It is a requirement, not just of using the NO_RELOC mode, that all relocation values in the execobjects match their reloc.presumed_offset, as the kernel will skip performing *any* relocation if the presumed_offset matches the target object. In many places the relocation entry is record with the rig

Re: [Mesa-dev] [PATCH] configure: remove unneeded bits around libunwind handling

On Monday, 2017-05-08 18:02:08 +0100, Emil Velikov wrote: > From: Emil Velikov > > If libunwind is not found we'll fail at PKG_CHECK_MODULES, so the > follow-up check won't be reached. Additionally the AM_CONDITIONAL is not > used, so we can drop it. > > Fixes: 3bcef6aa245 ("configure.ac: honour

[Mesa-dev] [PATCH] mesa: remove useless get_uniform_parameter() declaration

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniforms.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/main/uniforms.h b/src/mesa/main/uniforms.h index 314d195a24..bd42b4f036 100644 --- a/src/mesa/main/uniforms.h +++ b/src/mesa/main/uniforms.h @@ -486,9 +486,6 @@ _mesa_sampler

[Mesa-dev] [PATCH 1/2] glsl: add parcel_out_uniform_storage::count_indices() helper

In order to sort indices for images inside a struct array we need to do something similar to samplers. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniforms.cpp | 117 +++- 1 file changed, 63 insertions(+), 54 deletions(-) diff --git a/src/compiler/g

[Mesa-dev] [PATCH 2/2] glsl: order indices for images inside a struct array

ARB_bindless_texture allows images to be declared inside structures. This is similar to samplers. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniforms.cpp | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/link_unifor

Re: [Mesa-dev] [PATCH 2/4] intel/isl: Refactor gen7_choose_image_alignment_el

On Wed, May 10, 2017 at 02:30:30PM -0700, Jason Ekstrand wrote: > The Ivy Bridge PRM provides a nice table that handles most of the > alignment cases in one place. For standard color buffers we have a > little freedom of choice but for most depth, stencil and compressed it's > hard-coded. Chad's

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Wed, May 10, 2017 at 02:30:31PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl_gen6.c | 30 -- > 1 file changed, 12 insertions(+), 18 deletions(-) > > diff --git a/src/intel/isl/isl_gen6.c b/src/intel/isl/isl_gen6.c > index b746903..0de9620 100644 > --- a/sr

Re: [Mesa-dev] [PATCH] mesa: remove useless get_uniform_parameter() declaration

Reviewed-by: Timothy Arceri On 11/05/17 23:34, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniforms.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/main/uniforms.h b/src/mesa/main/uniforms.h index 314d195a24..bd42b4f036 100644 --- a/src/mesa/main

Re: [Mesa-dev] [PATCH 4/4] intel/isl: Refactor gen8_choose_image_alignment_el

On Wed, May 10, 2017 at 02:30:32PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl_gen8.c | 193 > +-- > 1 file changed, 53 insertions(+), 140 deletions(-) Wow, this becomes so much simpler: Reviewed-by: Topi Pohjolainen > > diff --git a/src

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

I don't suppose anyone tested this already with any gallium driver? I suppose if not, I should (but I didn't bring the right board with me today so it might have to be tomorrow) BR, -R On Fri, May 5, 2017 at 3:17 AM, Xu, Randy wrote: > Ping Chad & Emil & Tapani > > Please help to review it, I j

Re: [Mesa-dev] [PATCH 2/4] intel/isl: Refactor gen7_choose_image_alignment_el

On Wed, May 10, 2017 at 02:30:30PM -0700, Jason Ekstrand wrote: > The Ivy Bridge PRM provides a nice table that handles most of the > alignment cases in one place. For standard color buffers we have a > little freedom of choice but for most depth, stencil and compressed it's > hard-coded. Chad's

Re: [Mesa-dev] [PATCH 1/2] glsl: add parcel_out_uniform_storage::count_indices() helper

I'm not sure about the name. Maybe something like set_opaque_indices() would be better? Either way both patches are: Reviewed-by: Timothy Arceri On 11/05/17 23:34, Samuel Pitoiset wrote: In order to sort indices for images inside a struct array we need to do something similar to samplers. S

Re: [Mesa-dev] [PATCH 1/2] glsl: add parcel_out_uniform_storage::count_indices() helper

On 05/11/2017 04:11 PM, Timothy Arceri wrote: I'm not sure about the name. Maybe something like set_opaque_indices() would be better? Looks good to me. The Intel CI system is not totally happy with this patch, I'm wondering why... I will investigate (probably something dumb). Thanks. E

Re: [Mesa-dev] [PATCH 1/2] glsl: add parcel_out_uniform_storage::count_indices() helper

On 05/11/2017 04:11 PM, Timothy Arceri wrote: I'm not sure about the name. Maybe something like set_opaque_indices() would be better? Either way both patches are: Reviewed-by: Timothy Arceri On 11/05/17 23:34, Samuel Pitoiset wrote: In order to sort indices for images inside a struct arra

Re: [Mesa-dev] [PATCH] gallium/tests: fix build after index buffer changes

On 10.05.2017 19:54, Marek Olšák wrote: From: Marek Olšák for some reason, only scons can build these. Reviewed-by: Nicolai Hähnle --- src/gallium/tests/graw/fs-fragcoord.c| 2 +- src/gallium/tests/graw/fs-frontface.c| 2 +- src/gallium/tests/graw/fs-test.c | 2 +- src/

[Mesa-dev] [AppVeyor] mesa master #4340 completed

Build mesa 4340 completed Commit 479e76bc1f by Marek Olšák on 5/10/2017 5:52 PM: gallium/tests: fix build after index buffer changes\n\nfor some reason, only scons can build these.\n\nReviewed-by: Nicolai Hähnle Configure your notification preference

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

On 17-05-02 11:51:28, Francisco Jerez wrote: Anuj Phogat writes: On Mon, Apr 24, 2017 at 9:15 PM, Ben Widawsky wrote: On 17-04-18 18:18:39, Francisco Jerez wrote: Most, if not all of the unrelated changes that snuck in were due to rebase. Anuj, would you mind fixing those? I tried my best

[Mesa-dev] [PATCH v2 2/2] glsl: order indices for images inside a struct array

ARB_bindless_texture allows images to be declared inside structures. This is similar to samplers. v2: - check the return value of set_opaque_indices() Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/compiler/glsl/link_uniforms.cpp | 28 +--- 1 fi

[Mesa-dev] [PATCH v2 1/2] glsl: add parcel_out_uniform_storage::set_opaque_indices() helper

In order to sort indices for images inside a struct array we need to do something similar to samplers. v2: - rename count_indices() to set_opaque_indices() - make the method returns a bool to skip the loop Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/compiler/gls

Re: [Mesa-dev] [PATCH 2/3] i965: Change GEN_GEN < 7 to GEN_GEN == 6 in 3DSTATE_VS code.

Reviewed-by: Rafael Antognolli On Wed, May 10, 2017 at 12:41:38PM -0700, Kenneth Graunke wrote: > This whole code is surrounded in #if GEN_GEN >= 6, and this code only > applies on Sandybridge. So, use GEN_GEN == 6 to reduce the delta in > the next patch, when we add Gen4-5 support. > --- > src

[Mesa-dev] [PATCH] intel/genxml: Canonicalize addresses before writing them

This doesn't actually fix any 48-bit bugs because the addresses provided to us from the kernel are already sign-extended. However, it still seems like a good idea. Cc: Chris Wilson --- src/intel/genxml/gen_pack_header.py | 34 +++--- 1 file changed, 31 insertions(+),

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Thu, May 11, 2017 at 7:03 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, May 10, 2017 at 02:30:31PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_gen6.c | 30 -- > > 1 file changed, 12 insertions(+), 18 deletions(-) > > > > diff --

Re: [Mesa-dev] [PATCH 5/5] radeonsi: get rid of secondary input/output word

For the series: Reviewed-by: Marek Olšák Marek On Wed, May 10, 2017 at 7:30 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > By keeping track of fewer generics, everything can fit into 64 bits. > --- > src/gallium/drivers/radeonsi/si_shader.c| 32 > +++-- > s

Re: [Mesa-dev] [PATCH 1/3] anv: Stop racing relocation offsets

On Thu, May 11, 2017 at 12:41 AM, Chris Wilson wrote: > On Wed, May 10, 2017 at 04:08:53PM -0700, Jason Ekstrand wrote: > > One of the key invariants of the relocation system is the > > presumed_offset field. The assumption is made that the value currently > > in the address to be relocated agre

Re: [Mesa-dev] [PATCH 3/3] anv: Don't record the handle in the relocation

On Thu, May 11, 2017 at 12:42 AM, Chris Wilson wrote: > On Wed, May 10, 2017 at 04:08:55PM -0700, Jason Ekstrand wrote: > > We use the look-up table mechanism for relocations so this isn't the > > value we want. The correct value is filled out at execbuf2 time by > > anv_cmd_buffer_process_reloc

Re: [Mesa-dev] [PATCH 1/4] anv: Canonicalize known offsets

This is probably a good idea thought it doesn't solve any actual bugs ATM since the kernel always provides us canonical offsets. I considered doing it earlier when I was bringing up 48bit but didn't for that reason. I dug up the patch I had for doing it directly in genxml and sent it out. I'm no

Re: [Mesa-dev] [PATCH 12/22] anv/gpu_memcpy: Add a lighter-weight memcpy path

On Tue, May 02, 2017 at 04:58:15PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > We're now performing a GPU memcpy in more places to copy small amounts > > of data. Add a path to thrash less state. > > > > Signed-off-by: Nanley Chery > > --- > > sr

Re: [Mesa-dev] [PATCH 1/4] anv: Canonicalize known offsets

On Thu, May 11, 2017 at 09:32:01AM -0700, Jason Ekstrand wrote: >This is probably a good idea thought it doesn't solve any actual bugs ATM >since the kernel always provides us canonical offsets.  I considered doing >it earlier when I was bringing up 48bit but didn't for that reason.  I

Re: [Mesa-dev] [PATCH 3/3] anv: Don't record the handle in the relocation

On Thu, May 11, 2017 at 09:29:40AM -0700, Jason Ekstrand wrote: >On Thu, May 11, 2017 at 12:42 AM, Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Wed, May 10, 2017 at 04:08:55PM -0700, Jason Ekstrand wrote: > > We use the look-up table mechanism for relocations so this

Re: [Mesa-dev] [PATCH 3/3] i965: Port Gen4-5 VS_STATE to genxml.

On Wed, May 10, 2017 at 12:41:39PM -0700, Kenneth Graunke wrote: > It's actually not that much code. > --- > src/intel/genxml/gen4.xml | 2 +- > src/intel/genxml/gen45.xml| 2 +- > src/intel/genxml/gen5.xml | 2 +- > src/mesa/driver

Re: [Mesa-dev] [PATCH] intel/genxml: Canonicalize addresses before writing them

On Thu, May 11, 2017 at 09:13:55AM -0700, Jason Ekstrand wrote: > This doesn't actually fix any 48-bit bugs because the addresses provided > to us from the kernel are already sign-extended. However, it still > seems like a good idea. addr=1<<47-4096, delta=4096 > Cc: Chris Wilson > --- > src/i

Re: [Mesa-dev] [PATCH 1/3] anv: Stop racing relocation offsets

On Thu, May 11, 2017 at 09:27:05AM -0700, Jason Ekstrand wrote: >On Thu, May 11, 2017 at 12:41 AM, Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Wed, May 10, 2017 at 04:08:53PM -0700, Jason Ekstrand wrote: > > One of the key invariants of the relocation system is the

Re: [Mesa-dev] [PATCH v3 02/15] dri: Add an image creation with modifiers

On 17-05-10 23:15:29, Varad Gautam wrote: From: Ben Widawsky Modifiers will be obtained or guessed by the client and passed in during image creation/import. As of this patch, the modifiers aren't plumbed all the way down, this patch simply makes sure the interface level stuff is correct and ke

Re: [Mesa-dev] [PATCH] intel/genxml: Canonicalize addresses before writing them

On Thu, May 11, 2017 at 9:54 AM, Chris Wilson wrote: > On Thu, May 11, 2017 at 09:13:55AM -0700, Jason Ekstrand wrote: > > This doesn't actually fix any 48-bit bugs because the addresses provided > > to us from the kernel are already sign-extended. However, it still > > seems like a good idea. >

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery wrote: > > > On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote: > > > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > > > wrote: > > > > > > > Signed-off-by: Nanley Chery

Re: [Mesa-dev] [PATCH v3 02/15] dri: Add an image creation with modifiers

On Thu, May 11, 2017 at 10:26 PM, Ben Widawsky wrote: > On 17-05-10 23:15:29, Varad Gautam wrote: >> >> From: Ben Widawsky >> >> Modifiers will be obtained or guessed by the client and passed in during >> image creation/import. >> >> As of this patch, the modifiers aren't plumbed all the way down

[Mesa-dev] [PATCH] intel/anv, genxml: Pull address canonicalization into a common header

--- src/intel/common/gen_utils.h| 50 + src/intel/genxml/gen_pack_header.py | 14 +++ src/intel/vulkan/anv_batch_chain.c | 13 ++ 3 files changed, 55 insertions(+), 22 deletions(-) create mode 100644 src/intel/common/gen_utils.h diff -

Re: [Mesa-dev] [PATCH 04/22] anv: Add color auxiliary buffer helpers

On Tue, May 02, 2017 at 02:54:07PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_private.h | 42 ++ > > > > 1 file changed, 42 insertions(+) > > >

[Mesa-dev] [PATCH] swr: don't use AttributeSet with llvm >= 5

This change fixes the build break with llvm-svn. r301981 of llvm-svn made add/remove of function attributes use AttrBuilder instead of AttributeList. Tested with llvm-3.9, llvm-4.0, llvm-svn. --- src/gallium/drivers/swr/swr_shader.cpp | 36 -- 1 file changed, 21 i

Re: [Mesa-dev] [PATCH 01/22] intel/isl: Limit CCS to one subresource on gen7

On Tue, May 02, 2017 at 02:48:09PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/isl/isl.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/src/intel/isl/isl.c

Re: [Mesa-dev] [PATCH 07/22] anv/image: Initialize the clear values buffer

On Tue, May 02, 2017 at 04:03:36PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_image.c | 75 ++ > > +--- > > src/intel/vulkan/anv_private.h | 5 ++

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Thu, May 11, 2017 at 10:13 AM, Nanley Chery wrote: > On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery > wrote: > > > > > On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote: > > > > On Thu, Apr 27, 2017 at 11:32 AM, Na

Re: [Mesa-dev] [PATCH 3/3] i965: Port Gen4-5 VS_STATE to genxml.

Ugh, and I also forgot: you can remove brw_vs_unit from brw_state.h too. On Thu, May 11, 2017 at 09:54:13AM -0700, Rafael Antognolli wrote: > On Wed, May 10, 2017 at 12:41:39PM -0700, Kenneth Graunke wrote: > > It's actually not that much code. > > --- > > src/intel/genxml/gen4.xml

  1   2   3   >