On Wed, 2017-05-10 at 20:14 +0200, Wladimir J. van der Laan wrote:
> Seems more straightforward, but I don't know the rationale
> why it was done the way it was.
>
> Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com>
The rationale essentially was "the texture must be older than the
imported renderable so it will be resolved after importing" and "we
increase renderable seqno when we _render_ into it". I initially didn't
make the connection that reimporting a renderable with new content is
effectively the same thing as rendering new content into it.
regards
Philipp
>
> On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote:
> > From: Philipp Zabel <p.za...@pengutronix.de>
> >
> > Just increment the resource seqno instead of setting the texture
> > seqno to be lower by one than the resource seqno.
> >
> > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de>
> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de>
> > ---
> > src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c
> > b/src/gallium/drivers/etnaviv/etnaviv_resource.c
> > index 103b53c1c310..1341e1ea2314 100644
> > --- a/src/gallium/drivers/etnaviv/etnaviv_resource.c
> > +++ b/src/gallium/drivers/etnaviv/etnaviv_resource.c
> > @@ -286,11 +286,7 @@ etna_resource_changed(struct pipe_screen *pscreen,
> > struct pipe_resource *prsc)
> > {
> > struct etna_resource *res = etna_resource(prsc);
> >
> > - /* Make sure texture is older than the imported renderable buffer,
> > - * so etna_update_sampler_source will copy the pixel data again.
> > - */
> > - if (res->texture)
> > - etna_resource(res->texture)->seqno = res->seqno - 1;
> > + res->seqno++;
> > }
> >
> > static void
> > --
> > 2.11.0
> >
> > _______________________________________________
> > etnaviv mailing list
> > etna...@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/etnaviv
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
