[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #5 from Gregor Münch --- Thanks for the patch. I cant test it before Friday. Will let you know, in the meantime maybe someone else can test? Im quite confident that Feral is willing to fix their games if its a bug against the spec.

Re: [Mesa-dev] [PATCH 0/7] Move shader_group_vote and shader_ballot to using intrinsics

2017-04-25 Thread Nicolai Hähnle
Ping On 19.04.2017 10:56, Nicolai Hähnle wrote: Hi all, As Matt Turner pointed out on IRC, the builtin functions from those extensions have an unusual interaction with control-flow, which is not captured by the usual semantics of expressions. For this reason, they should really be implemented a

[Mesa-dev] [Bug 100782] [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100782 Bug ID: 100782 Summary: [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa Product: Mesa Version: git Hardware: Other OS: All St

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

2017-04-25 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-04-24 at 11:22 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Fri, 2017-04-21 at 10:23 -0700, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > On Thu, 2017-04-20 at 10:26 -0700, Francisco Jerez wrote: > > > > > Samuel Iglesias

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

2017-04-25 Thread Marc Di Luzio
Hi Marek, I agree with Ken here. For what it's worth, the list of our titles that use primitive restart here is likely the full list. DXMD was the first as far as I know - see https://cgit.freedesktop.org/mesa/mesa/commit/?id= e33f31d61f5e9019f8b0bac0378dfb8fd1147421. It also appears to be an app

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

2017-04-25 Thread Gregory Hainaut
Hello, I did more tests on my side. DRI3 + recent stack is fine. Older (Debian Jessie, ~2y old) XCB hangs/deadlock. So all DRI3 drivers should be fine (typically AMD). And all applications that called XInitThread soon enough. So yeah I think we can merge it. Note: I don't have commit access. Nouv

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

2017-04-25 Thread Marek Olšák
On Tue, Apr 25, 2017 at 11:09 AM, Marc Di Luzio wrote: > Hi Marek, > > I agree with Ken here. > > For what it's worth, the list of our titles that use primitive restart here > is likely the full list. DXMD was the first as far as I know - see > https://cgit.freedesktop.org/mesa/mesa/commit/?id=e33

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100690 Marc Di Luzio changed: What|Removed |Added CC||mdiluzio@feralinteractive.c

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #6 from Marc Di Luzio --- Cheers for the report Gregor. Kenneth: if the verdict from Khronos suggests we're out of spec then we'll be happy to patch and fix. I'll keep an eye on this thread. -- You are receiving this mail because:

[Mesa-dev] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

2017-04-25 Thread Nicolai Hähnle
From: Nicolai Hähnle The incomplete framebuffer is set for a surfaceless context. This leads to the following error in piglit spec@egl_khr_surfaceless_context@viewport: ==26703==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f6886e43240 at pc 0x7f68854db0fd bp 0x7ffca404b3b0 sp 0

[Mesa-dev] [PATCH 2/2] st/mesa: remove redundant stfb->iface checks

2017-04-25 Thread Nicolai Hähnle
From: Nicolai Hähnle stfb->iface is always non-NULL for an st_framebuffer. These checks were incorrect, relying on out-of-bounds memory access in the surface-less case of EGL_KHR_surfaceless_context. --- src/mesa/state_tracker/st_cb_viewport.c | 4 ++-- src/mesa/state_tracker/st_manager.c |

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

2017-04-25 Thread Marc Di Luzio
> Thanks. Do you plan to update the games not to enable primitive > restart for non-strip primitives? I won't be able to give a decent time frame yet, but yes I'll make sure it's on our schedule. - Marc Di Luzio Linux Group Lead @ Feral Interactive Ltd. On 25 April 2017 at 10:15, Marek Olšák

Re: [Mesa-dev] [PATCH 5/5] st/mesa: clean up min/max_index handling in st_draw_vbo

2017-04-25 Thread Marek Olšák
On Tue, Apr 25, 2017 at 8:41 AM, Nicolai Hähnle wrote: > On 24.04.2017 15:31, Marek Olšák wrote: >> >> On Mon, Apr 24, 2017 at 12:01 PM, Nicolai Hähnle >> wrote: >>> >>> On 23.04.2017 01:10, Marek Olšák wrote: From: Marek Olšák There is no reason to check for ~0. Al

Re: [Mesa-dev] [PATCH 3/4] radeonsi: disable the TGSI merge registers pass

2017-04-25 Thread Samuel Pitoiset
On 04/25/2017 08:47 AM, Nicolai Hähnle wrote: Interesting find. Is this in shaders with control flow? Perhaps with this change, there are now more undefs in places that previously had a phi with an unrelated use of the same TGSI temporary. Anyway, patches 1-3: Yes. Looks like some shaders ha

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Juan A. Suarez Romero
On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > Curro pointed out that I should not just check for MACH, but use > the reads_accumulator_implicitly() helper, which would also prevent > the same bug with MAC and SADA2 (if we ever decide to use them). > This seems to rely on commit 2faf

Re: [Mesa-dev] [PATCH] docs: add release calendar page and references to it

2017-04-25 Thread Emil Velikov
On 24 April 2017 at 23:40, Eric Engestrom wrote: > On Monday, 2017-04-24 17:22:19 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Add a page that has information which release is expected when and >> associated information. >> >> Reference to it from the "Releasing process" and "Release no

[Mesa-dev] [Bug 100782] [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100782 --- Comment #1 from Emil Velikov --- Attaching a debugger to X would be a good start. At the moment the log produced shows nothing of interest. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee fo

Re: [Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

2017-04-25 Thread Emil Velikov
On 24 April 2017 at 20:29, Jason Ekstrand wrote: > This seems like something that would be more appropriate to put on a > "getting started" page than autogen.sh. The very last thing I (as a user of > it) would expect autogen.sh to do is monkey with my git config; local or > otherwise. > Close to

Re: [Mesa-dev] [PATCH] gallium: remove u_caps.c/h interface

2017-04-25 Thread Emil Velikov
On 25 April 2017 at 00:10, Samuel Pitoiset wrote: > No longer used. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/Makefile.sources | 2 - > src/gallium/auxiliary/util/u_caps.c| 267 > - > src/gallium/auxiliary/util/u_caps.h| 71 -

Re: [Mesa-dev] [PATCH] gallium: remove u_caps.c/h interface

2017-04-25 Thread Jose Fonseca
On 25/04/17 12:15, Emil Velikov wrote: On 25 April 2017 at 00:10, Samuel Pitoiset wrote: No longer used. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_caps.c| 267 - src/gallium/auxiliary/ut

[Mesa-dev] [PATCH 0/4 v2] small r600g improvements

2017-04-25 Thread Constantine Kharlamov
No regressions with piglit. 1,2, and 3 patches without changes, tested by Dieter, 4 is the new one. Constantine Kharlamov (4): r600g: avoid redundant DB register updates r600g/radeonsi: trivial cleanups r600g: remove unused sbcl env. variable r600g: avoid redundant CB updates src/galliu

[Mesa-dev] [PATCH 2/4] r600g/radeonsi: trivial cleanups

2017-04-25 Thread Constantine Kharlamov
constified some variables, moved two variable declarations into the cycle where they're used, and removed trailing whitespace. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 4 +-- src/gallium/drivers/r600/r600_blit.c | 4 +

[Mesa-dev] [PATCH 3/4] r600g: remove unused sbcl env. variable

2017-04-25 Thread Constantine Kharlamov
sb-based optimization was only used for older LLVM, whose support was removed in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for LLVM 3.5". As of now sbcl variable doesn't do anything. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drive

[Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-25 Thread Constantine Kharlamov
Split out of "avoid redundant CB register updates" for easier review. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 76 +++- src/gallium/drivers/r600/r600_blit.c | 1 + src/gallium/drivers/r600/r

[Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
It finishes the work started by 0c2eed0edec, quoting: > The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly > when those colorbuffers aren't used. This is mainly for glamor. After 0c2eed0edec the r600g was passing null as the dirty_cbufs pointer, and the current patch makes th

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] st/mesa: remove redundant stfb->iface checks

2017-04-25 Thread Marek Olšák
On Apr 25, 2017 11:23 AM, "Nicolai Hähnle" wrote: From: Nicolai Hähnle stfb->iface is always non-NULL for an st_framebuffer. These checks were incorrect, relying on out-of-bounds memory access in the surface-less case of EGL_KHR_surfaceless_context. --- src/mesa/state_tracker/st_cb_viewport.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Andres Gomez
On Tue, 2017-04-25 at 11:57 +0200, Juan A. Suarez Romero wrote: > On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > > Curro pointed out that I should not just check for MACH, but use > > the reads_accumulator_implicitly() helper, which would also prevent > > the same bug with MAC and SADA

Re: [Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

2017-04-25 Thread Eric Engestrom
On Tuesday, 2017-04-25 12:10:46 +0100, Emil Velikov wrote: > On 24 April 2017 at 20:29, Jason Ekstrand wrote: > > This seems like something that would be more appropriate to put on a > > "getting started" page than autogen.sh. The very last thing I (as a user of > > it) would expect autogen.sh to

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-04-25 Thread Christian König
Am 21.04.2017 um 15:38 schrieb Emil Velikov: On 21 April 2017 at 13:31, Christian König wrote: Am 21.04.2017 um 14:11 schrieb Emil Velikov: Both headers are used everywhere, plus they both provide interop mechanism. Since they define [consecutive] VDPAU driver funcs, we really want the defini

Re: [Mesa-dev] [PATCH] docs: add release calendar page and references to it

2017-04-25 Thread Eric Engestrom
On Tuesday, 2017-04-25 11:46:55 +0100, Emil Velikov wrote: > On 24 April 2017 at 23:40, Eric Engestrom wrote: > > On Monday, 2017-04-24 17:22:19 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Add a page that has information which release is expected when and > >> associated informat

Re: [Mesa-dev] [PATCH 5/5] st/mesa: clean up min/max_index handling in st_draw_vbo

2017-04-25 Thread Nicolai Hähnle
On 25.04.2017 11:29, Marek Olšák wrote: On Tue, Apr 25, 2017 at 8:41 AM, Nicolai Hähnle wrote: On 24.04.2017 15:31, Marek Olšák wrote: On Mon, Apr 24, 2017 at 12:01 PM, Nicolai Hähnle wrote: On 23.04.2017 01:10, Marek Olšák wrote: From: Marek Olšák There is no reason to check for ~0.

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-04-25 Thread Ilia Mirkin
On Tue, Apr 25, 2017 at 8:51 AM, Christian König wrote: > Am 21.04.2017 um 15:38 schrieb Emil Velikov: >> >> On 21 April 2017 at 13:31, Christian König >> wrote: >>> >>> Am 21.04.2017 um 14:11 schrieb Emil Velikov: Both headers are used everywhere, plus they both provide interop me

Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
On 25.04.2017 14:59, Constantine Kharlamov wrote: > It finishes the work started by 0c2eed0edec, quoting: > >> The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly >> when those colorbuffers aren't used. This is mainly for glamor. > > After 0c2eed0edec the r600g was passing nul

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-04-25 Thread Christian König
Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: [SNIP] Is there a patch I should test? Patch is attached, but only compile tested. Basically if OpenGL/VDPAU interop worked before with Kodi/MPV it should still keep working. Christian. -ilia >From a01c07d52dc283fb97d36d54e6c9b706160973b9

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-04-25 Thread Emil Velikov
On 25 April 2017 at 15:06, Christian König wrote: > Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: >> >> [SNIP] >> Is there a patch I should test? > > > Patch is attached, but only compile tested. > > Basically if OpenGL/VDPAU interop worked before with Kodi/MPV it should > still keep working. > I th

[Mesa-dev] [PATCH 03/15] swr: [rasterizer core] Fix some MSVC errors with SIMD16 FE

2017-04-25 Thread Tim Rowley
- add SIMDAPI decorator to a few functions in the binner and clipper. - disabling buffer overrun warning for Assemble(uint32_t slot, simdvector *verts) due to what looks like a compiler bug when compiling the 16 wide frontend. --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 6 +++---

[Mesa-dev] [PATCH 02/15] swr: [rasterizer jitter] Additional jit utility functions

2017-04-25 Thread Tim Rowley
--- .../drivers/swr/rasterizer/jitter/builder.cpp | 1 + .../drivers/swr/rasterizer/jitter/builder.h| 1 + .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 69 +- .../drivers/swr/rasterizer/jitter/builder_misc.h | 6 ++ 4 files changed, 76 insertions(+), 1

[Mesa-dev] [PATCH 09/15] swr: [rasterizer core] Enable per-warp scratch space for CS

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 6 +- src/gallium/drivers/swr/rasterizer/core/api.h | 7 ++- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 10 +- src/gallium/drivers/swr/rasterizer/core/backend.h | 2 +- src/gallium/drivers/swr/rasterize

[Mesa-dev] [PATCH 00/15] swr: update rasterizer

2017-04-25 Thread Tim Rowley
Highlights: more simd16 work, enable 8x2 backend, perf fixes. Tim Rowley (15): swr: [rasterizer core/jitter] More flexible max attribute slots swr: [rasterizer jitter] Additional jit utility functions swr: [rasterizer core] Fix some MSVC errors with SIMD16 FE swr: [rasterizer core/common]

[Mesa-dev] [PATCH 04/15] swr: [rasterizer core/common] Name threads for debugging

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.sources | 1 + src/gallium/drivers/swr/rasterizer/common/os.cpp | 107 + src/gallium/drivers/swr/rasterizer/common/os.h | 5 +- .../drivers/swr/rasterizer/core/threads.cpp| 15 ++- 4 files changed, 126 insertions

[Mesa-dev] [PATCH 12/15] swr: [rasterizer core] Add SwrInit() to init backend/memory tables

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 23 --- src/gallium/drivers/swr/rasterizer/core/api.h | 5 + src/gallium/drivers/swr/rasterizer/core/backend.h | 3 --- src/gallium/drivers/swr/swr_context.cpp | 5 + src/gallium/drivers/swr/swr_me

[Mesa-dev] [PATCH 01/15] swr: [rasterizer core/jitter] More flexible max attribute slots

2017-04-25 Thread Tim Rowley
Ability to allocate space for an arbitrary number (at compile time) of positions in the vertex layout. Removes KNOB_NUM_ATTRIBUTES from knobs.h, replaces the VTX slot number #defines with the SWR_VTX_SLOTS enum (which contains replacement for NUM_ATTRIBUTES: SWR_VTX_NUM_SLOTS) --- .../drivers/swr

[Mesa-dev] [PATCH 08/15] swr: [rasterizer core] Reduce simd{16}vertex stack for VS output

2017-04-25 Thread Tim Rowley
Frontend - reduce simdvertex/simd16vertex stack usage for VS output in ProcessDraw, fixes stack overflow in some of the deeper call stacks under SIMD16. 1. Move the vertex store out of PA_FACTORY, and off the stack 2. Allocate the vertex store out of the aligned heap (pointer is temporarily sto

[Mesa-dev] [PATCH 11/15] swr: [rasterizer core] Fix SIMD16 8x2 backend

2017-04-25 Thread Tim Rowley
Misplaced #endif preventing depth and stencil hot tile pointers from incrementing in SIMD16 8x2 configuration of BackendPixelRate. --- src/gallium/drivers/swr/rasterizer/core/backend.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/backe

[Mesa-dev] [PATCH 05/15] swr: [rasterizer core] Fix gcc error for SIMD16 FE

2017-04-25 Thread Tim Rowley
Move construction of const above goto. --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/binner.cpp b/src/gallium/drivers/swr/rasterizer/core/binner.cpp index 3c94004..958f0a2 1006

[Mesa-dev] [PATCH 13/15] swr: [rasterizer core] Enable 8x2 tile backend

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h b/src/gallium/drivers/swr/rasterizer/core/knobs.h index 640b672..7ad6fe3 100644 --- a/src/gallium/drivers/swr/rasterizer/core/kno

[Mesa-dev] [PATCH 06/15] swr: [rasterizer core] Fix gcc build warnings with simd16 fe

2017-04-25 Thread Tim Rowley
clip.h workaround for vs2015 codegen still generates warnings --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 8 src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 7 ++- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 1 - 3 files changed, 2 insertions(+), 14 de

[Mesa-dev] [PATCH 10/15] swr: [rasterizer core/common] SwrGetInterface function returns api

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 6 + src/gallium/drivers/swr/rasterizer/core/api.cpp | 48 src/gallium/drivers/swr/rasterizer/core/api.h | 141 3 files changed, 151 insertions(+), 44 deletions(-) diff --git a/src/gallium/drivers/swr/ras

[Mesa-dev] [PATCH 14/15] swr: [rasterizer jitter] Small fetch perf opt

2017-04-25 Thread Tim Rowley
Use gather instruction for odd format fetch instead of slow emulated code. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 55 -- 1 file changed, 9 insertions(+), 46 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drive

[Mesa-dev] [PATCH 15/15] swr: [rasterizer core/memory] Add memory api to SwrGetInterface

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp| 3 ++ src/gallium/drivers/swr/rasterizer/core/api.h | 45 ++ .../drivers/swr/rasterizer/memory/ClearTile.cpp| 2 +- .../drivers/swr/rasterizer/memory/LoadTile.cpp | 2 +- .../drivers/swr/rasterizer/memory/

[Mesa-dev] [PATCH 07/15] swr: [rasterizer core] Remove default argument from SwrSync()

2017-04-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.h b/src/gallium/drivers/swr/rasterizer/core/api.h index d0f29dd..b9b994a 100644 --- a/src/gallium/drivers/swr/rasterizer/core/api.h +++

Re: [Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

2017-04-25 Thread Emil Velikov
Hi Gwan-gyeong, On 12 April 2017 at 01:48, Mun Gwan-gyeong wrote: > From: "Mun, Gwan-gyeong" > --- > src/egl/Makefile.am |7 + > src/egl/drivers/dri2/egl_dri2.c | 11 + > src/egl/drivers/dri2/egl_dri2.h | 36 + > src/egl/drivers/dri2/platform_tizen.c | 154

Re: [Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

2017-04-25 Thread Daniel Stone
Hi, On 25 April 2017 at 17:03, Emil Velikov wrote: > From a quick look most of this code is copy/pasted from platform_wayland.c. > > At the same time, large portions of the android, gbm and wayland (not > sure about x11) platforms are almost identical. > With the biggest differences due to featur

[Mesa-dev] [PATCH] egl: initialise dummy_thread via _eglInitThreadInfo

2017-04-25 Thread Emil Velikov
From: Emil Velikov Considering we cannot make dummy_thread a constant we might as well, initialise by the same function that handles the actual thread info. This way we don't need to worry about mismatch between the initialiser and initialising function. Signed-off-by: Emil Velikov --- src/eg

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-25 Thread Emil Velikov
On 24 April 2017 at 22:49, Rob Herring wrote: > On Mon, Apr 24, 2017 at 11:59 AM, Emil Velikov > wrote: >> Hi Rob, >> >> On 24 April 2017 at 17:46, Rob Herring wrote: >>> If r300g is the only radeon driver built, the Android build fails to >>> build: >>> >>> ninja: error: >>> 'out/target/produc

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

2017-04-25 Thread Anuj Phogat
On Mon, Apr 24, 2017 at 9:15 PM, Ben Widawsky wrote: > On 17-04-18 18:18:39, Francisco Jerez wrote: > > Most, if not all of the unrelated changes that snuck in were due to rebase. > Anuj, would you mind fixing those? I tried my best to address the rest, > but I'm > admittedly stumbling my way thr

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Kenneth Graunke
On Tuesday, April 25, 2017 5:24:09 AM PDT Andres Gomez wrote: > On Tue, 2017-04-25 at 11:57 +0200, Juan A. Suarez Romero wrote: > > On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > > > Curro pointed out that I should not just check for MACH, but use > > > the reads_accumulator_implicitly

Re: [Mesa-dev] [PATCH] egl: initialise dummy_thread via _eglInitThreadInfo

2017-04-25 Thread Eric Engestrom
On Tuesday, 2017-04-25 17:07:46 +0100, Emil Velikov wrote: > From: Emil Velikov > > Considering we cannot make dummy_thread a constant we might as well, > initialise by the same function that handles the actual thread info. > > This way we don't need to worry about mismatch between the initialis

Re: [Mesa-dev] [PATCH 1/4] mesa: only lock framebuffer in compat profile

2017-04-25 Thread Fredrik Höglund
On Tuesday 25 April 2017, Timothy Arceri wrote: > On 24/04/17 22:51, Fredrik Höglund wrote: > > On Monday 24 April 2017, Timothy Arceri wrote: > >> From the EXT_framebuffer_object spec: > >> > >> "Framebuffer objects created with the commands defined > >> by the GL_EXT_framebuffer_object

Re: [Mesa-dev] [PATCH 04/61] radeonsi/gfx9: add a workaround for viewing a slice of 3D as a 2D image

2017-04-25 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák Cc: 17.1 --- src/gallium/drivers/radeonsi/si_shader.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.

Re: [Mesa-dev] [PATCH 08/61] radeonsi: turn si_shader_key::mono into a non-union

2017-04-25 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák A merged LS-HS shader needs both fix_fetch and inputs_to_copy for compilation. Patches 5-8: Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c| 10 +- src/gallium/drivers/radeonsi/si_shader.h

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-25 Thread Mauro Rossi
2017-04-25 18:21 GMT+02:00 Emil Velikov : > > On 24 April 2017 at 22:49, Rob Herring wrote: > > On Mon, Apr 24, 2017 at 11:59 AM, Emil Velikov > > wrote: > >> Hi Rob, > >> > >> On 24 April 2017 at 17:46, Rob Herring wrote: > >>> If r300g is the only radeon driver built, the Android build fails

[Mesa-dev] EGL: Question about deferred context and surface destroy

2017-04-25 Thread Mike Gorchak
Hi all, During a quick tests of latest Mesa3D versions at different branches 12.x, 13.x, 17.x we have found that deferred context and surface destroy doesn't work properly. According to docs: https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglDestroySurface.xhtml Description If the EGL su

Re: [Mesa-dev] [PATCH] radv/ac: set no signed zero fp math on radv

2017-04-25 Thread Bas Nieuwenhuizen
The Vulkan spec has " Positive and negative infinities and positive and negative zeros are generated as dictated by IEEE 754, but subject to the precisions allowed in the following table." Sounds like we may need signed zero? On Sun, Apr 23, 2017 at 9:15 PM, Dave Airlie wrote: > From: Dave Airl

Re: [Mesa-dev] [PATCH 2/3] radv/ac: overhaul vs output/ps input routing

2017-04-25 Thread Bas Nieuwenhuizen
1-2 are Reviewed-by: Bas Nieuwenhuizen On Fri, Apr 21, 2017 at 4:41 AM, Dave Airlie wrote: > From: Dave Airlie > > In order to cleanly eliminate exports rewrite the > code first to mirror how radeonsi works for now. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 10

Re: [Mesa-dev] [PATCH] radv/ac: setup mrt exports then export them in one go.

2017-04-25 Thread Bas Nieuwenhuizen
On Sun, Apr 23, 2017 at 8:54 PM, Dave Airlie wrote: > From: Dave Airlie > > Noticed while looking at Sascha Willems deferred shaders. > > This is a bit of an llvm workaround, llvm was producing this: > v_cvt_pkrtz_f16_f32_e64 v4, v7, v8 ; D2960004 > 00021107 >

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-25 Thread Rob Herring
On Tue, Apr 25, 2017 at 1:50 PM, Mauro Rossi wrote: > 2017-04-25 18:21 GMT+02:00 Emil Velikov : >> >> On 24 April 2017 at 22:49, Rob Herring wrote: >> > On Mon, Apr 24, 2017 at 11:59 AM, Emil Velikov >> > wrote: >> >> Hi Rob, >> >> >> >> On 24 April 2017 at 17:46, Rob Herring wrote: >> >>> If

[Mesa-dev] [PATCH mesa] configure: print LDFLAGS alongside CFLAGS & co.

2017-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e42fcfff77..ba042791ad 100644 --- a/configure.ac +++ b/configure.ac @@ -2920,15 +2920,17 @@ echo "Static libs: $enable_static" echo

[Mesa-dev] software implementation of vulkan for gsoc/evoc

2017-04-25 Thread Денис Паук
Hi! I have merged https://cgit.freedesktop.org/~airlied/mesa/log/?h=not-a-vulkan-swrast with mesa-13.0.6 branch. Maybe it will be useful for someone: https://github.com/0lvin/mesa/tree/mesa-13.0.6-vallium (4f83657c02867825ebbd3cc9e407eb989c8f8dee). For build run: ./configure --with-dri-drivers=

Re: [Mesa-dev] [PATCH 3/4] vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.

2017-04-25 Thread Rob Herring
On Mon, Apr 24, 2017 at 4:59 PM, Eric Anholt wrote: > Android.mk was setting the flag across the entire driver, so we didn't > have non-NEON versions getting built. This was going to be a problem with > the next commit, when I start auto-detecting NEON support and use the > non-NEON version when

[Mesa-dev] [PATCH v3 06/37] genxml: Add alias for MOCS.

2017-04-25 Thread Rafael Antognolli
Use an alias, so we can set the same value as the #define's. v3: - Call it "SO Buffer MOCS" to follow the most common naming scheme. - Add alias for gen7 and gen75 too (Ken). Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel

[Mesa-dev] [Bug 100789] Mesa 17.0.4 pkppa, Textures become corrupt in counterstrike 1.6 and in steam overlay after indeterminate amount of time

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100789 Bug ID: 100789 Summary: Mesa 17.0.4 pkppa, Textures become corrupt in counterstrike 1.6 and in steam overlay after indeterminate amount of time Product: Mesa Ver

Re: [Mesa-dev] [PATCH 3/4] radeonsi: disable the TGSI merge registers pass

2017-04-25 Thread Ilia Mirkin
I've hated this pass for quite a while. It is necessary for nv30 but is actively harmful for nv50+ due to the undef issue nha points out. I haven't looked closely at the impl details, but the idea is acked-by me. On Apr 25, 2017 5:44 AM, "Samuel Pitoiset" wrote: > > > On 04/25/2017 08:47 AM, Nic

Re: [Mesa-dev] [PATCH 07/12] i965/cnl: Restore lossless compression for sRGB formats

2017-04-25 Thread Anuj Phogat
On Mon, Apr 24, 2017 at 10:57 PM, Ben Widawsky wrote: > On 17-04-15 18:27:33, Jason Ekstrand wrote: > >> On April 14, 2017 5:37:55 PM Anuj Phogat wrote: >> >> From: Ben Widawsky >>> >>> This support was removed on gen9 (it worked before then) and was brought >>> back >>> for gen10. >>> >>> Sign

[Mesa-dev] [PATCH] radv: Enable userspace fence checking.

2017-04-25 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 27 --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 5 + src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h | 3 +++ 3 files changed, 32 insertions(+), 3 deletions(-) diff --

Re: [Mesa-dev] [PATCH] radv/ac: set no signed zero fp math on radv

2017-04-25 Thread Roland Mainz
On Tue, Apr 25, 2017 at 9:42 PM, Bas Nieuwenhuizen wrote: > The Vulkan spec has > > " Positive and negative infinities and positive and negative zeros are > generated as dictated by IEEE > 754, but subject to the precisions allowed in the following table." > > Sounds like we may need signed zero?

Re: [Mesa-dev] [PATCH v02 15/37] i965: Add genxml related plumbing in a new genX_state_upload.c file.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:10 PM PDT Rafael Antognolli wrote: > From: Kenneth Graunke > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/Makefile.sources| 15 ++- > src/mesa/drivers/dri/i965/genX_state_upload.c | 109 +++- > 2 files changed, 119 insert

[Mesa-dev] [PATCH] radeonsi: use unsynchronized transfers for shader binary uploads

2017-04-25 Thread Samuel Pitoiset
Because the buffer is new, it can't be referenced by any CS. This can save few CPU cycles by skipping the whole PIPE_TRANSFER_UNSYNCHRONIZED if in amdgpu_bo_map(). Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-25 Thread Mauro Rossi
2017-04-25 22:12 GMT+02:00 Rob Herring : > On Tue, Apr 25, 2017 at 1:50 PM, Mauro Rossi wrote: >> 2017-04-25 18:21 GMT+02:00 Emil Velikov : >>> >>> On 24 April 2017 at 22:49, Rob Herring wrote: >>> > On Mon, Apr 24, 2017 at 11:59 AM, Emil Velikov >>> > wrote: >>> >> Hi Rob, >>> >> >>> >> On 24

[Mesa-dev] [PATCH 1/2] aubinator: import intel_aub.h from libdrm

2017-04-25 Thread Lionel Landwerlin
This enables us to compile aubinator without the libdrm dependency. Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_aub.h | 153 1 file changed, 153 insertions(+) create mode 100644 src/intel/tools/intel_aub.h diff --git a/src/intel/tools

[Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

2017-04-25 Thread Lionel Landwerlin
Hi, While working with changes that span from kernel to user space, I've been wondering whether we need to depend on libdrm at all for the anv & i965 drivers. Indeed with Ken's recent changes, we only depend on libdrm for its kernel header files which we could just embed ourselves. I've only incl

Re: [Mesa-dev] [PATCH v02 18/37] i965: Port Gen6+ DEPTH_STENCIL state to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:13 PM PDT Rafael Antognolli wrote: [snip] > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index b9e207d..ff28cf5 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 2/2] radv/ac: eliminate unused vertex shader outputs. (v2)

2017-04-25 Thread Dave Airlie
From: Dave Airlie This is ported from radeonsi, and I can see at least one Talos shader drops an export due to this, and saves some VGPR usage. v2: use shared code. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 37 - src/amd/common/ac_nir

[Mesa-dev] [PATCH 1/2] radeonsi/ac: move vertex export remove to common code.

2017-04-25 Thread Dave Airlie
From: Dave Airlie This code can be shared by radv, we bump the max to VARYING_SLOT_MAX here, but that shouldn't have too much fallout. Signed-off-by: Dave Airlie --- src/amd/common/ac_exp_param.h | 40 ++ src/amd/common/ac_llvm_build.c | 156

[Mesa-dev] [PATCH v2] radv: Enable userspace fence checking.

2017-04-25 Thread Bas Nieuwenhuizen
v2: - Added some error handling. - memset the buffer to 0. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 27 --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 8 +++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h |

Re: [Mesa-dev] [PATCH 07/12] i965/cnl: Restore lossless compression for sRGB formats

2017-04-25 Thread Ben Widawsky
On 17-04-25 14:53:46, Anuj Phogat wrote: On Mon, Apr 24, 2017 at 10:57 PM, Ben Widawsky wrote: On 17-04-15 18:27:33, Jason Ekstrand wrote: On April 14, 2017 5:37:55 PM Anuj Phogat wrote: From: Ben Widawsky This support was removed on gen9 (it worked before then) and was brought back for

[Mesa-dev] [PATCH v3] radv: Enable userspace fence checking.

2017-04-25 Thread Bas Nieuwenhuizen
v2: - Added some error handling. - memset the buffer to 0. v3: Added assert for buffer size. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 27 --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 9 src/amd/vulkan/w

[Mesa-dev] [PATCH 2/2] swr: Fix polygonmode for front==back

2017-04-25 Thread George Kyriazis
Add logic for converting enums and also making sure stipple works. CC: --- src/gallium/drivers/swr/swr_state.cpp | 14 +- src/gallium/drivers/swr/swr_state.h | 20 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_state

[Mesa-dev] [PATCH 1/2] swr: [rasterizer core] support polygonmode point

2017-04-25 Thread George Kyriazis
add support in the binner: Split BinPoints into BinPostSetupPoints, so we can use it from BinTriangles, since setup is already done. CC: --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 175 ++--- 1 file changed, 117 insertions(+), 58 deletions(-) diff --git a/src/galli

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

2017-04-25 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Mon, 2017-04-24 at 11:22 -0700, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > On Fri, 2017-04-21 at 10:23 -0700, Francisco Jerez wrote: >> > > Samuel Iglesias Gonsálvez writes: >> > > >> > > > On Thu, 2017-04-20 at 10:26 -0700, Fran

Re: [Mesa-dev] [PATCH v02 19/37] i965: Port Gen6+ 3DSTATE_CLIP state to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:14 PM PDT Rafael Antognolli wrote: > Emit clip state on Gen6+ using brw_batch_emit helper, using pack structs > from genxml. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/brw_state.h | 1 +- > src/mesa/drivers/dri/i965/gen6_clip_s

Re: [Mesa-dev] [PATCH v02 20/37] i965: Port Gen8+ 3DSTATE_RASTER state to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:15 PM PDT Rafael Antognolli wrote: > Emits 3DSTATE_RASTER from genX_state_upload.c using pack structs from > genxml. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/brw_state.h | 1 +- > src/mesa/drivers/dri/i965/gen8_sf_state.c

Re: [Mesa-dev] [PATCH v02 31/37] i965: Port gen7+ 3DSTATE_TE to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:26 PM PDT Rafael Antognolli wrote: [snip] > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index 1bdcea5..45b02a6 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 2/2] swr: Fix polygonmode for front==back

2017-04-25 Thread Ilia Mirkin
This will cause asserts on piglit and dEQP runs instead of failures. This is incredibly inconvenient, as e.g. dEQP runs everything in a single process. On Apr 25, 2017 7:29 PM, "George Kyriazis" wrote: > Add logic for converting enums and also making sure stipple works. > > CC: > > --- > src/g

Re: [Mesa-dev] [PATCH v02 35/37] i965: Port gen6+ multisample state emitting code to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:30 PM PDT Rafael Antognolli wrote: > Emit 3DSTATE_MULTISAMPLE using brw_batch_emit. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/brw_context.h| 9 +- > src/mesa/drivers/dri/i965/brw_state.h | 2 +- > src/mesa/d

Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Dieter Nützel
This one is Tested-by: Dieter Nützel My gut feeling is 'faster than ever'! Even WebGL (Konqi 5.0.97) apps (HD 1920x1080) are very smooth, now. Marek can you comment and then commit? Dieter Am 25.04.2017 13:59, schrieb Constantine Kharlamov: It finishes the work started by 0c2eed0edec, quoti

Re: [Mesa-dev] [PATCH 7/7] st/glsl_to_tgsi: make undef_src and undef_dst const

2017-04-25 Thread Timothy Arceri
I'm not overly familiar with some of the code in 2-4 but it seems to make sense so for what its worth. For the series: Reviewed-by: Timothy Arceri On 19/04/17 18:56, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++-- 1 file changed, 2 inse

Re: [Mesa-dev] [PATCH v02 36/37] i965: Port gen6+ 3DSTATE_CC_STATE_POINTERS state to genxml.

2017-04-25 Thread Kenneth Graunke
On Monday, April 24, 2017 3:19:31 PM PDT Rafael Antognolli wrote: [snip] > + brw_batch_emit(brw, GENX(3DSTATE_CC_STATE_POINTERS), ptr) { > + ptr.ColorCalcStatePointer = brw->cc.state_offset; > +#if GEN_GEN != 7 > + ptr.ColorCalcStatePointerValid = true; > +#endif > + } > +} Ah, trick

[Mesa-dev] [Bug 100789] Mesa 17.0.4 pkppa, Textures become corrupt in counterstrike 1.6 and in steam overlay after indeterminate amount of time

2017-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100789 --- Comment #1 from Michel Dänzer --- Is this a regression from older versions of Mesa? If so, can you bisect Mesa or at least narrow down the version where the problem first appeared? -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH v2 03/31] glsl: make sampler/image types as 64-bit

2017-04-25 Thread Timothy Arceri
On 24/04/17 20:35, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "Samplers are represented using 64-bit integer handles." and, "Images are represented using 64-bit integer handles." It seems simpler to always consider sampler and image types as 64-bit unsigned integer. T

  1   2   >