On Tue, Apr 25, 2017 at 11:09 AM, Marc Di Luzio
<mdilu...@feralinteractive.com> wrote:
> Hi Marek,
>
> I agree with Ken here.
>
> For what it's worth, the list of our titles that use primitive restart here
> is likely the full list. DXMD was the first as far as I know - see
> https://cgit.freedesktop.org/mesa/mesa/commit/?id=e33f31d61f5e9019f8b0bac0378dfb8fd1147421.
> It also appears to be an app side issue so we will patch as needed.
>
> In the future let us know first, in pretty much all cases we'd prefer to
> make the change on our side instead of adding game specific hacks in Mesa.
Thanks. Do you plan to update the games not to enable primitive
restart for non-strip primitives?
Marek
>
> Cheers,
>
>
> -----
> Marc Di Luzio
> Linux Group Lead @ Feral Interactive Ltd.
>
> On 24 April 2017 at 23:26, Kenneth Graunke <kenn...@whitecape.org> wrote:
>>
>> On Monday, April 24, 2017 6:22:41 AM PDT Marek Olšák wrote:
>> > From: Marek Olšák <marek.ol...@amd.com>
>> >
>> > ---
>> > src/gallium/drivers/radeonsi/si_pipe.c | 20 +++++++++++++
>> > src/gallium/drivers/radeonsi/si_pipe.h | 1 +
>> > src/gallium/drivers/radeonsi/si_state_draw.c | 45
>> > ++++++++++++++++++++--------
>> > 3 files changed, 54 insertions(+), 12 deletions(-)
>> >
>> > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
>> > b/src/gallium/drivers/radeonsi/si_pipe.c
>> > index 1a83564..53a8201 100644
>> > --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> > +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> > @@ -29,20 +29,29 @@
>> > #include "radeon/radeon_uvd.h"
>> > #include "util/u_memory.h"
>> > #include "util/u_suballoc.h"
>> > #include "util/u_tests.h"
>> > #include "vl/vl_decoder.h"
>> > #include "../ddebug/dd_util.h"
>> >
>> > #define SI_LLVM_DEFAULT_FEATURES \
>> > "+DumpCode,+vgpr-spilling,-fp32-denormals,-xnack"
>> >
>> > +/* DX10/11 apply primitive restart to strip primitive types only. */
>> > +static const char *apps_with_prim_restart_dx_behavior[] = {
>> > + "DeusExMD",
>> > + "DirtRally",
>> > + "HitmanPro",
>> > + "MadMax",
>> > + "TotalWarhammer",
>> > +};
>> > +
>>
>> Hi Marek,
>>
>> You seem to be adding driver workarounds for an incomplete list of Feral
>> Interactive's titles. Presumably, if you're going to go this route, you
>> may need to add more of them. Or, perhaps this is something they can
>> fix in their translator layer, so they only enable it when they want it?
>>
>> I've copied Marc and Alex from Feral in case they want to weigh in.
>>
>> --Ken
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
