Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

27 mar 2017 08:47 "Alejandro Piñeiro" napisał(a): On 27/03/17 01:51, Edward O'Callaghan wrote: > V.1: > We memset number of elements without multiplication by the > element size. It is not usual to summarize v1. The idea is explain just the changes. > > V.2: > We explicitly set each member to -1

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

26 mar 2017 22:32 "Edmondo Tommasina" napisał(a): Define a new MESA_USER_DRIRC environment variable to load a customized drirc file. When the variable is not defined, nothing changes and the ${HOME}/.drirc file will be loaded. If the variable is set to a file, this file will be loaded instead o

Re: [Mesa-dev] [PATCH v4.1 07/28] i965/fs: generalize the legalization d2x pass

On Fri, Mar 24, 2017 at 01:42:23PM -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > Generalize it to lower any unsupported narrower conversion. > > > > v2 (Curro): > > - Add supports_type_conversion() > > - Reuse existing intruction instead of cloning it. > > - Generalize d

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

On 27/03/17 09:19, Gustaw Smolarczyk wrote: > 27 mar 2017 08:47 "Alejandro Piñeiro" > napisał(a): > > On 27/03/17 01:51, Edward O'Callaghan wrote: > > V.1: > > We memset number of elements without multiplication by the > > element size. > > It is no

[Mesa-dev] [PATCH v4.1 03/28] i965/fs: add helper to retrieve instruction data size and execution type

From: "Juan A. Suarez Romero" The execution data size is the biggest type size of any instruction operand. We will use it to know if the instruction deals with DF, because in Ivy we need to double the execution size and regioning parameters. v2: - Fix typo in commit log (Matt) - Use static inli

[Mesa-dev] [PATCH v4.1 14/28] i965/vec4: split DF instructions and later double its execsize in IVB/BYT

We need to split DF instructions in two on IVB/BYT as it needs an execsize 8 to process 4 DF values (one GRF in total). v2: - Rename helper and make it static inline function (Matt). - Fix indention and add braces (Matt). v3: - Don't edit IR instruction when doubling exec_size (Curro) - Add comme

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

On Mon, Mar 27, 2017 at 06:30:19AM +0200, Samuel Iglesias Gonsálvez wrote: > On Fri, Mar 24, 2017 at 12:39:38PM -0700, Francisco Jerez wrote: > > Matt Turner writes: > > > > > On Fri, Mar 24, 2017 at 12:06 AM, Francisco Jerez > > > wrote: > > >> Samuel Iglesias Gonsálvez writes: > > >> > > >>>

Re: [Mesa-dev] [PATCH v4 00/28] i965: Ivybridge ARB_gpu_shader_fp64 / OpenGL 4.0

As I am sending some patch updates, to avoid any confusion I want to clarify than the patches waiting for review are: 9, 14, 16-24. Sam On Mon, Mar 20, 2017 at 10:16:57AM +0100, Samuel Iglesias Gonsálvez wrote: > Hi, > > This series implements initial support for Ivybridge FP64 for both > align1

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

Hi, Lionel/Tapani/Emil Any comments to this patch? I think it should be enough to address the VK_REMAINING_ARRAY_LAYERS (~0) issue in anv_blorp.c Thanks, Randy > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Randy Xu > Sent: Monday,

[Mesa-dev] ksmcube on vmwgfx

Hello. I have downloaded kmscube from git://anonogit.freedesktop.org/mesa/kmscube. I have tried it inside VMware with vmwgfx acceleration. The smooth mode works correctly and I see rotating cube. But I have also tried textured cube (-M rgba) and this doesn't work in vmwgfx. it asserts in init_te

Re: [Mesa-dev] [PATCH 10/11] etnaviv: add support for rb swap

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > If we render to rb swapped format we will create a shader variant doing > the involved swizzing in the pixel shader. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 17 +

Re: [Mesa-dev] [PATCH 09/11] etnaviv: adopt shader-db output for variant support

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner s/adopt/adapt in the subject Reviewed-by: Lucas Stach > --- > src/gallium/drivers/etnaviv/etnaviv_shader.c | 30 > ++-- > 1 file changed, 15 insertions(+), 15 deletio

Re: [Mesa-dev] [PATCH 08/11] etnaviv: bring back shader-db traces

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > If shader-db run, create a standard variant immediately > (as otherwise nothing will trigger the shader to be > actually compiled). > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- > src/gallium/drivers/et

Re: [Mesa-dev] [PATCH 07/11] etnaviv: add etna_shader_key and generate variants if needed

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 4 +- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 4 +- > src/gallium/drivers/etnaviv/etnaviv_compiler.h | 2 + > ..

Re: [Mesa-dev] [PATCH 06/11] etnaviv: pass a preallocated variant to compiler

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > In the long run the compiler needs to know the specifc variant > 'key' in order to compile appropriate assembly. With this commit > the variant knows its shader and we are able pass the preallocated > variant into etna_compile_sha

Re: [Mesa-dev] [PATCH 04/11] etnaviv: add struct etna_shader_state

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- > src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 4 ++-- > src/gallium/drivers/etnaviv/etnaviv_context.h| 9 + > src/gallium/drivers/etnaviv/et

Re: [Mesa-dev] [PATCH 03/11] etnaviv: add basic shader variant support

Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: > This commit adds some basic infrastructure to handle shader > variants. We are still creating exactly one shader variant > for each shader. > > Signed-off-by: Christian Gmeiner Nitpick inline, othwerwise: Reviewed-by: Lucas St

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

Hi Randy, This patch looks good to me. Reviewed-by: Lionel Landwerlin Cc: "17.0 13.0" Are you planning to send a follow up patch to fix the remaining layoutCount accesses too? Cheers, - Lionel On 20/03/17 07:31, Randy Xu wrote: From: Xu Randy We should use anv_get_layerCount() to acce

Re: [Mesa-dev] [PATCH 1/3] glsl: delay optimisations on individual shaders when cache is available

On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: > Due to a max limit of 65,536 entries on the index table that we use to > decide if we can skip compiling individual shaders, it is very likely > we will have collisions. > > To avoid doing too much work when the linked program may be in the

Re: [Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: > In the following patch we will stop pre-processing shaders before > hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE > is set. That's because the extension substitution is done by the preprocessor I assume? It's not rea

Re: [Mesa-dev] [PATCH kmscube 2/3] add video cube

On 25 March 2017 at 20:11, Rob Clark wrote: > --- a/common.h > +++ b/common.h > > +#ifdef HAVE_CONFIG_H > +# include "config.h" > +#endif > + config.h is no more as of commit 24830fe38257c6b0df8fa86acfa8cdb08eb41dcf Drop the hunk. > #include > #include > #include > @@ -85,9 +89,25 @@ enu

Re: [Mesa-dev] [PATCH 1/3] glsl: delay optimisations on individual shaders when cache is available

On 27/03/17 20:30, Grazvydas Ignotas wrote: On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: Due to a max limit of 65,536 entries on the index table that we use to decide if we can skip compiling individual shaders, it is very likely we will have collisions. To avoid doing too much wor

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On 26 March 2017 at 14:59, Rob Clark wrote: > Figured I should figure out what this meson stuff is all about. After a > bit of hunting around to find examples to look at (and interruptions) it > took maybe ~1hr to convert (for someone who never looked at meson > before). The build speed is defin

Re: [Mesa-dev] [PATCH kmscube 1/3] add license file

On 25 March 2017 at 20:11, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > COPYING | 18 ++ > 1 file changed, 18 insertions(+) > create mode 100644 COPYING > Acked-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

On 27/03/17 20:32, Grazvydas Ignotas wrote: On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: In the following patch we will stop pre-processing shaders before hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE is set. That's because the extension substitution is don

Re: [Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

On 25 March 2017 at 12:00, Tim Rowley wrote: > Move common codegen functions into gen_common.py. > --- > src/gallium/drivers/swr/Makefile.am| 22 +-- > .../drivers/swr/rasterizer/codegen/gen_archrast.py | 30 +--- > .../drivers/swr/rasterizer/codegen/gen_backends.py | 30 +--- >

[Mesa-dev] [PATCH 1/2] st/mesa: move st_manager_get_egl_image_surface into st_cb_eglimage.c

The only callers are here, and we will add generation of GL errors in the following patch. Rename the function to st_egl_image_get_surface, pass the gl_context instead of st_context, and move the cast from GLeglImageOES to void* into st_egl_image_get_surface. Signed-off-by: Philipp Zabel --- sr

[Mesa-dev] [PATCH 2/2] st/mesa: EGLImageTarget* error handling

Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe driver's create_surface callback without ever checking that the given EGL

Re: [Mesa-dev] MESA and KOTOR

The trace shows are a lot of wgl calls failing: $ apitrace dump swkotor_s3tc.trace | grep wgl.*FALSE | grep -v wglChoosePixelFormatARB 499 wglMakeCurrent(hdc = 0x50010fe2, hglrc = 0x2) = FALSE 510 wglMakeCurrent(hdc = 0xc20117ba, hglrc = 0x2) = FALSE 521 wglMakeCurrent(hdc = 0x3e010301,

Re: [Mesa-dev] [PATCH 1/3] stw/wgl: add null context check in wglBindTexImageARB()

On 26/03/17 23:29, Miklós Máté wrote: On 24/03/17 22:42, Brian Paul wrote: To avoid dereferencing a null pointer in case wglMakeCurrent() wasn't called. Found while debugging SWKOTOR game. Reviewed-by: Neha Bhende Reviewed-by: Charmaine Lee --- src/gallium/state_trackers/wgl/stw_ext_render

[Mesa-dev] [PATCHi V2 3/3] glsl: don't run the GLSL pre-processor when we are skipping compilation

Improves Deus Ex start-up times with a warm cache from ~30 seconds to ~22 seconds. Also fixes the leaking of state. V2: fix indentation --- src/compiler/glsl/glsl_parser_extras.cpp | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/compiler/glsl/glsl_par

[Mesa-dev] [PATCH V2 1/3] glsl: delay optimisations on individual shaders when cache is available

Due to a max limit of 65,536 entries on the index table that we use to decide if we can skip compiling individual shaders, it is very likely we will have collisions. To avoid doing too much work when the linked program may be in the cache this patch delays calling the optimisations until link time

[Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

In the following patch we will stop pre-processing shaders before hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE is set. --- src/util/disk_cache.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index d9de8ef..dc883a

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

On Sun, 2017-03-26 at 21:08 +1100, Timothy Arceri wrote: > Ok. So lets start again. :) ... > With those this is: > > Reviewed-by: Timothy Arceri I'll apply the changes. Thanks a lot for your patience during the reviewing process ☺ -- Br, Andres ___

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

Hey Rob, On 26 March 2017 at 14:59, Rob Clark wrote: > Figured I should figure out what this meson stuff is all about. After a > bit of hunting around to find examples to look at (and interruptions) it > took maybe ~1hr to convert (for someone who never looked at meson > before). The build spee

Re: [Mesa-dev] MESA and KOTOR

No, I'm afraid you need to fix whatever is causing make current to fail. Rebind the old context / drawable, or creating a dummy context, might avoid the division by zero, but I'm sure it will get you no closer to make it render correctly. Context/drawables are stateful objects, they are not i

Re: [Mesa-dev] [PATCH 3/3] glsl: Interface Block instances don't need linking validation

On Sun, 2017-03-26 at 21:28 +1100, Timothy Arceri wrote: > Patches 2 & 3 are: > > Reviewed-by: Timothy Arceri Thanks! I've already pushed this. Additionally, could you take a look to this piglit patch related to patch 3 in this series? https://lists.freedesktop.org/archives/piglit/2017-Februar

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

Hi Rob, On Sun, Mar 26, 2017 at 10:59 AM, Rob Clark wrote: > Figured I should figure out what this meson stuff is all about. After a > bit of hunting around to find examples to look at (and interruptions) it > took maybe ~1hr to convert (for someone who never looked at meson > before). The buil

Re: [Mesa-dev] MESA and KOTOR

First of all, stop using microsoft opengl32.dll, since it doesn't help. Using Mesa means you can debug using gdb or something. But on 2nd thought, rather than using a debugger, a good way to go about this is to add printfs on every code path that causes WGL (or in Windows cases, _debug_printf

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: > Hi Rob, > > On Sun, Mar 26, 2017 at 10:59 AM, Rob Clark wrote: >> Figured I should figure out what this meson stuff is all about. After a >> bit of hunting around to find examples to look at (and interruptions) it >> took maybe ~1hr to conv

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

Thanks, Lionel See my comments below Thanks, Randy > -Original Message- > From: Landwerlin, Lionel G > Sent: Monday, March 27, 2017 5:14 PM > To: Xu, Randy ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] anv/genX: Solve the > anv_CmdClearColorImage crash issue > > Hi

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On 27 March 2017 at 12:50, Rob Clark wrote: > On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: >> gst-decoder.c:189:40: note: each undeclared identifier is reported >> only once for each function it appears in >> Makefile:613: recipe for target 'kmscube-gst-decoder.o' failed >> make: *** [km

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On Mon, Mar 27, 2017 at 7:59 AM, Daniel Stone wrote: > On 27 March 2017 at 12:50, Rob Clark wrote: >> On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: >>> gst-decoder.c:189:40: note: each undeclared identifier is reported >>> only once for each function it appears in >>> Makefile:613: recip

Re: [Mesa-dev] [RFC 11/12] anv/cmd_buffer: Emit instanced draws for multiple views

On Fri, 2017-03-24 at 16:57 -0700, Jason Ekstrand wrote: > On Fri, Mar 24, 2017 at 5:53 AM, Iago Toral > wrote: > > On Wed, 2017-03-22 at 21:01 -0700, Jason Ekstrand wrote: > > --- > >  src/intel/vulkan/anv_private.h |   6 ++ > >  src/intel/vulkan/genX_cmd_buffer.c | 141 > > ++

Re: [Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

We have hit this limit too while working on an upcoming Vulkan extension. Increasing the push constants area to 512 seems sensible and safe. I also checked on CI that this brings no regressions. This patch needs a trivial rebase fix, otherwise it is: Reviewed-by: Eduardo Lima Mitev On 12/02/201

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 Eero Tamminen changed: What|Removed |Added Summary|[EGL] [GBM] lib32 undefined |[EGL] [GBM] undefined

[Mesa-dev] [PATCH v2 1/4] r600_state_common: check NULL return from u_upload_alloc

Like done in si_state_draw.c::si_draw_vbo u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: alloc fails or map fails. For both there is already a fprintf/stderr in radeon_create_bo and radeon_bo_do_map. In src/gallium/drivers/ it is a common usage to just avoid to crash

[Mesa-dev] [PATCH v2 2/4] si_compute: check NULL return from u_upload_alloc

Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_compute.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 46476b6..a38138f 100644 --- a/src/gallium/driv

Re: [Mesa-dev] Mesa (master): mesa/marshal: add custom BufferData/ BufferSubData marshalling

> > >>* + variable_data += size; > *>>* And here, and below. > * > This code is mostly a copy from the generated code, which adds these for > some reason (possibly a bug in generation, but it may be used by other > functions and just excess here). > > Hello, As I already looked into the python l

[Mesa-dev] [PATCH v2 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..cf820e4 100644 --- a/src/mesa/state_tracker/st_cb_bitmap.c +++ b/src/mesa/

Re: [Mesa-dev] [v2] glx: Prefer library path given by pkgconfig over the system

On Tue, Mar 21, 2017 at 10:33:12AM +, Emil Velikov wrote: > On 21 March 2017 at 09:09, Topi Pohjolainen > wrote: > > Recent change to use drmGetDevices2() made me realize that > > build configured using > > > > PKG_CONFIG_PATH=my_drm_lib_path/pkgconfig ./autogen.sh > > > > considers the libdr

Re: [Mesa-dev] [PATCH kmscube 2/3] add video cube

On Mon, Mar 27, 2017 at 5:41 AM, Emil Velikov wrote: > >> + dec->egl->eglDestroyImageKHR(dec->egl->display, >> dec->last_frame); > > Unrelated: we must be using glGetString(GL_EXTENSIONS) and > eglQueryString(... EGL_EXTENSIONS) alongside eglGetProcAddress(). > It's not cool that km

Re: [Mesa-dev] [PATCH] mesa/glthread: add custom marshalling for ClearBufferfv()

Hello Timothy, 2 small questions: Will it work for DSA equivalent function, namely glClearNamedFramebufferfv ? Would it be interesting to also do the equivalent for glClearBufferiv/glClearBufferuiv ? Note the *uiv variant could be easier as the size is always 4 INT, so it can be done with a scal

Re: [Mesa-dev] [PATCH] mesa glthread: allow asynchronous pixel transfer operation when a buffer is bound

Hello, Sorry I was in vacation. I will update my patch with a hash map to trace buffer creation/destruction. Cheers, Gregory On 3/20/17, Nicolai Hähnle wrote: > On 20.03.2017 14:33, Markus Wick wrote: >> Am 2017-03-20 14:21, schrieb Nicolai Hähnle: >>> On 17.03.2017 18:59, gregory hainaut wrote

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

On 27/03/17 12:51, Xu, Randy wrote: Thanks, Lionel See my comments below Thanks, Randy -Original Message- From: Landwerlin, Lionel G Sent: Monday, March 27, 2017 5:14 PM To: Xu, Randy ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearCol

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

Thanks, Randy > -Original Message- > From: Landwerlin, Lionel G > Sent: Monday, March 27, 2017 10:06 PM > To: Xu, Randy ; mesa-dev@lists.freedesktop.org > Cc: mesa-sta...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] anv/genX: Solve the > anv_CmdClearColorImage crash issue > >

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

On 03/26/2017 08:54 PM, Edward O'Callaghan wrote: On 03/27/2017 01:49 PM, Brian Paul wrote: On Sun, Mar 26, 2017 at 5:51 PM, Edward O'Callaghan mailto:funfunc...@folklore1984.net>> wrote: V.1: We memset number of elements without multiplication by the element size. V.2:

Re: [Mesa-dev] [PATCH v2 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

On 03/27/2017 07:46 AM, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..cf820e4 100644 --- a/src/

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On Mon, Mar 27, 2017 at 5:51 AM, Emil Velikov wrote: > On 26 March 2017 at 14:59, Rob Clark wrote: >> Figured I should figure out what this meson stuff is all about. After a >> bit of hunting around to find examples to look at (and interruptions) it >> took maybe ~1hr to convert (for someone who

Re: [Mesa-dev] [PATCH] anv/genX: Solve the anv_CmdClearColorImage crash issue

Reviewed-by: Jason Ekstrand Pushed! On Mon, Mar 27, 2017 at 2:14 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hi Randy, > > This patch looks good to me. > > Reviewed-by: Lionel Landwerlin > Cc: "17.0 13.0" > > Are you planning to send a follow up patch to fix the remaining

[Mesa-dev] [PATCH 1/2] anv: Make anv_get_layerCount a macro

Cc: "13.0 17.0" --- src/intel/vulkan/anv_private.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 27c887c..74e80e8 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_priva

[Mesa-dev] [PATCH 2/2] anv/blorp: Use anv_get_layerCount everywhere

Cc: "13.0 17.0" --- src/intel/vulkan/anv_blorp.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 9b3910f..0689142 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.

Re: [Mesa-dev] [RFC 11/12] anv/cmd_buffer: Emit instanced draws for multiple views

On Mon, Mar 27, 2017 at 5:33 AM, Iago Toral wrote: > On Fri, 2017-03-24 at 16:57 -0700, Jason Ekstrand wrote: > > On Fri, Mar 24, 2017 at 5:53 AM, Iago Toral wrote: > > On Wed, 2017-03-22 at 21:01 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_private.h | 6 ++ > src/intel/vulk

Re: [Mesa-dev] MESA and KOTOR

Yeah, from my investigation into this game/issue a few years ago, my finding was that when GL_ATI_fragment_shader is supported, the game uses a substantially different rendering path involving pbuffers. Calls to wglMakeContextCurrentARB() fail because the context and pbuffer have different p

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

On Mon, Mar 27, 2017 at 11:42 AM, Rob Clark wrote: > I'm undecided about whether or not to keep the autotools build. I > know there is some OE recipe floating around to build kmscube (since > it really is the killer-app of the embedded world :-P), but otherwise > probably aren't many/any distro'

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Use anv_get_layerCount everywhere

Looks good to me : Reviewed-by: Lionel Landwerlin On 27/03/17 15:44, Jason Ekstrand wrote: Cc: "13.0 17.0" --- src/intel/vulkan/anv_blorp.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Use anv_get_layerCount everywhere

On Mon, Mar 27, 2017 at 8:10 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Looks good to me : > > Reviewed-by: Lionel Landwerlin > Thanks! > On 27/03/17 15:44, Jason Ekstrand wrote: > >> Cc: "13.0 17.0" >> --- >> src/intel/vulkan/anv_blorp.c | 20 >>

[Mesa-dev] [PATCH kmscube] meson build support (v3)

Figured I should figure out what this meson stuff is all about. After a bit of hunting around to find examples to look at (and interruptions) it took maybe ~1hr to convert (for someone who never looked at meson before). The build speed is definitely faster even after Emil's auto- tools improvemen

Re: [Mesa-dev] [PATCH 4/4] r600_state: check NULL return from r600_aligned_buffer_create

Reviewed-by: Marek Olšák BTW, the prefix of all r600 commits should be "r600g:". Thanks a lot, Marek On Fri, Mar 24, 2017 at 12:08 PM, Julien Isorce wrote: > Signed-off-by: Julien Isorce > --- > src/gallium/drivers/r600/r600_state.c | 10 ++ > 1 file changed, 10 insertions(+) > > dif

Re: [Mesa-dev] [PATCH v2 1/4] r600_state_common: check NULL return from u_upload_alloc

Reviewed-by: Marek Olšák Marek On Mon, Mar 27, 2017 at 3:46 PM, Julien Isorce wrote: > Like done in si_state_draw.c::si_draw_vbo > > u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: > alloc fails or map fails. For both there is already a fprintf/stderr in > radeon_cre

Re: [Mesa-dev] [PATCH v2 2/4] si_compute: check NULL return from u_upload_alloc

"&&" at the end of the previous line please. Reviewed-by: Marek Olšák Marek On Mon, Mar 27, 2017 at 3:46 PM, Julien Isorce wrote: > Signed-off-by: Julien Isorce > --- > src/gallium/drivers/radeonsi/si_compute.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH v2 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

Reviewed-by: Marek Olšák Marek On Mon, Mar 27, 2017 at 3:46 PM, Julien Isorce wrote: > Signed-off-by: Julien Isorce > --- > src/mesa/state_tracker/st_cb_bitmap.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/state_tracker/st_cb_bitmap.c > b/src/mesa/state_tracker/st

Re: [Mesa-dev] [PATCH 1/2] mesa: print a notice when loading a user defined drirc file

Reviewed-by: Marek Olšák Marek On Sun, Mar 26, 2017 at 10:31 PM, Edmondo Tommasina wrote: > ... and avoid the load of ~/.drirc to go unnoticed. > --- > src/mesa/drivers/dri/common/xmlconfig.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/common/xmlconfig.c

[Mesa-dev] [Bug 100202] llvmpipe Windows scons build can't detect Visual Studio 2017 toolchain

https://bugs.freedesktop.org/show_bug.cgi?id=100202 --- Comment #2 from Anonymous Helper --- Workaround: Open Visual Studio 2017 installer. Opt-in for Visual Studio 2015 Update 3 toolset in Desktop Development with C/C++ section. Because LLVM 4.0 is not supported per bug 100201 you have to patch

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

On Mon, Mar 27, 2017 at 9:23 AM, Gustaw Smolarczyk wrote: > 26 mar 2017 22:32 "Edmondo Tommasina" > napisał(a): > > Define a new MESA_USER_DRIRC environment variable to load a customized > drirc file. > > When the variable is not defined, nothing changes and the ${HOME}/.drirc > file will be load

Re: [Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

On Mar 27, 2017, at 5:06 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: On 25 March 2017 at 12:00, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: Move common codegen functions into gen_common.py. --- src/gallium/drivers/swr/Makefile.am| 22 +-- .../drivers/swr/

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

Edmondo Tommasina writes: > Define a new MESA_USER_DRIRC environment variable to load a customized > drirc file. > > When the variable is not defined, nothing changes and the ${HOME}/.drirc > file will be loaded. > > If the variable is set to a file, this file will be loaded instead of > the the

[Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

Move common codegen functions into gen_common.py. v2: change gen_knobs.py to find the template file internally, like the rest of the gen scripts. --- src/gallium/drivers/swr/Makefile.am| 20 ++- .../drivers/swr/rasterizer/codegen/gen_archrast.py | 30 +--- .../drivers/swr/raster

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Jose Fonseca (2017-03-26 14:53:50) > I've pushed the branch to mesa/demos, so we can all collaborate without > wasting time crossporting patches between private branches. > >https://cgit.freedesktop.org/mesa/demos/commit/?h=meson > > Unfortunately, I couldn't actually go very far unt

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 27/03/17 17:24, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-26 14:53:50) I've pushed the branch to mesa/demos, so we can all collaborate without wasting time crossporting patches between private branches. https://cgit.freedesktop.org/mesa/demos/commit/?h=meson Unfortunately, I could

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

Quoting Daniel Stone (2017-03-27 04:59:13) > On 27 March 2017 at 12:50, Rob Clark wrote: > > On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: > >> gst-decoder.c:189:40: note: each undeclared identifier is reported > >> only once for each function it appears in > >> Makefile:613: recipe for t

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Jose Fonseca (2017-03-27 09:31:04) > On 27/03/17 17:24, Dylan Baker wrote: > > Quoting Jose Fonseca (2017-03-26 14:53:50) > >> I've pushed the branch to mesa/demos, so we can all collaborate without > >> wasting time crossporting patches between private branches. > >> > >>https://cgit.f

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 27/03/17 17:42, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-27 09:31:04) On 27/03/17 17:24, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-26 14:53:50) I've pushed the branch to mesa/demos, so we can all collaborate without wasting time crossporting patches between private branches.

Re: [Mesa-dev] [v2] glx: Prefer library path given by pkgconfig over the system

On 27 March 2017 at 14:56, Pohjolainen, Topi wrote: > On Tue, Mar 21, 2017 at 10:33:12AM +, Emil Velikov wrote: >> On 21 March 2017 at 09:09, Topi Pohjolainen >> wrote: >> > Recent change to use drmGetDevices2() made me realize that >> > build configured using >> > >> > PKG_CONFIG_PATH=my_dr

[Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

Hello, I was playing with profiling Minecraft on radeonsi in perf and found that _mesa_get_fixed_func_fragment_program was a little bit too high in the profile log than it should. I assumed that most of it comes from make_state_key static function which I am trying to optimize now in the spare tim

[Mesa-dev] [PATCH 2/3] mesa/main: Remove enabled_units from ff cache key.

Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b

[Mesa-dev] [PATCH 1/3] mesa/main: Use correct constant in ff cache key.

Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Mesa-dev] [PATCH 3/3] mesa/main: Reduce the size of nr_enabled_units in ff cache key.

Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 75189733ba..c29

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

Thanks. I've pushed this patch as commit 7dccd38b400d3a65da20ddefe282a7bb0b7ccb58 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Jose Fonseca writes: > On 27/03/17 17:42, Dylan Baker wrote: >> Quoting Jose Fonseca (2017-03-27 09:31:04) >>> On 27/03/17 17:24, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-26 14:53:50) > I've pushed the branch to mesa/demos, so we can all collaborate without > wasting time cro

[Mesa-dev] [PATCH 1/2] swr: [rasterizer jitter] fix llvm-5.0.0 build bustage

Add CreateAlignmentAssumptionHelper to gen_llvm_ir_macros.py ignore list. --- src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py b/src/gallium/

[Mesa-dev] [PATCH 2/2] swr: fix llvm-5.0.0 build bustage

Handle rename of llvm AttributeSet to AttributeList in the same fashion as ac_llvm_helper.cpp. --- src/gallium/drivers/swr/swr_shader.cpp | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/swr/swr_shader.cpp b/src/gallium/drivers/swr/

[Mesa-dev] [PATCH 0/7] Adding more documentation to the release process

A series of patches adding more details to the release process. Andres Gomez (7): docs/releasing: format/style homogenization docs/releasing: check in master for forgotten nomination candidates docs/releasing: further explain the build/check testing process docs/releasing: if possible, do

[Mesa-dev] [PATCH 1/7] docs/releasing: format/style homogenization

Signed-off-by: Andres Gomez Cc: Emil Velikov --- docs/releasing.html | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/docs/releasing.html b/docs/releasing.html index fc7f2a5aff9..cd5794a656a 100644 --- a/docs/releasing.html +++ b/docs/relea

[Mesa-dev] [PATCH 2/7] docs/releasing: check in master for forgotten nomination candidates

The maintanier should not just rely on the mesa-stable@ mailing list but actually check the master branch in search for suitable nomination candidates. Signed-off-by: Andres Gomez Cc: Emil Velikov --- docs/releasing.html | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 3/7] docs/releasing: further explain the build/check testing process

The build/check test should be done with an appropriate combination of flags, depending on the changes introduced by the patch set. Also, mention to cross compile with mingw-w64 for Windows. Signed-off-by: Andres Gomez Cc: Emil Velikov --- docs/releasing.html | 7 +-- 1 file changed, 5 ins

[Mesa-dev] [PATCH 4/7] docs/releasing: if possible, do some every day use on the RC

Signed-off-by: Andres Gomez Cc: Emil Velikov --- docs/releasing.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index 10a18790300..ea0088342f8 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -184,6 +184,12 @@ and llvmpipe dri

[Mesa-dev] [PATCH 5/7] docs/releasing: added relevant people for build/check with Windows

Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Vinson Lee --- docs/releasing.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index ea0088342f8..6c2740f1a82 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -133,6 +133,11 @@ G

[Mesa-dev] [PATCH 6/7] docs/releasing: added relevant people for build/check with Android

Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Tapani Pälli Cc: Mauro Rossi --- docs/releasing.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index 6c2740f1a82..0c78b0500d9 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@

[Mesa-dev] [PATCH 7/7] docs/releasing: added relevant people for build/check with MacOSX

Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Jeremy Huddleston Sequoia --- docs/releasing.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index 0c78b0500d9..e41605b2116 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -143

  1   2   >