Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

2017-03-24 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: >> SEL can only convert between a few integer types, which we basically >> never do. >> >> Fixes fs/vs-double-uniform-array-direct-indirect-non-uniform-control- >> flow >> Cc: mesa-sta...@lists.freedesktop.

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

2017-03-24 Thread Iago Toral
Topi, could you review this one? This was introduced recently with the implementation of Queries in the Vulkan driver and since the CTS OOM tests have not landed yet Jenkins won't catch these issues for now. Iago On Wed, 2017-03-22 at 10:15 +0100, Iago Toral Quiroga wrote: > We don't need to mak

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

2017-03-24 Thread Pohjolainen, Topi
On Wed, Mar 22, 2017 at 10:15:59AM +0100, Iago Toral Quiroga wrote: > We don't need to make the caller (CmdCopyQueryPoolResults) aware of the > problem since compute_query_result() only emits state. The caller is also > expected to hit OOM in this scenario right after calling this function, but > i

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

2017-03-24 Thread Pohjolainen, Topi
On Fri, Mar 24, 2017 at 09:12:21AM +0100, Iago Toral wrote: > Topi, could you review this one? > > This was introduced recently with the implementation of Queries in the > Vulkan driver and since the CTS OOM tests have not landed yet Jenkins > won't catch these issues for now. Yeah, sorry, I was

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Nicolai Hähnle
On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifycfg-sink-common option: may only occur zero or one times!" --- src/gallium/targets/va/va.sym | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/targets/va/

[Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

2017-03-24 Thread Julien Isorce
Like done in si_state_draw.c::si_draw_vbo Signed-off-by: Julien Isorce --- src/gallium/drivers/r600/r600_state_common.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index 6f8279f..cedeb74 1006

Re: [Mesa-dev] [PATCH 6/6] mesa: remove dd_function_table::BindProgram

2017-03-24 Thread Nicolai Hähnle
With Timothy's comment on patch #3 addressed, the series is Reviewed-by: Nicolai Hähnle On 24.03.2017 00:42, Marek Olšák wrote: From: Marek Olšák --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/arbprogram.c| 3 -- src/mesa/main/atifragshader.c | 3 -- s

[Mesa-dev] [PATCH 4/4] r600_state: check NULL return from r600_aligned_buffer_create

2017-03-24 Thread Julien Isorce
Signed-off-by: Julien Isorce --- src/gallium/drivers/r600/r600_state.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/drivers/r600/r600_state.c index 6139bd2..9ca113a 100644 --- a/src/gallium/drivers/r600/r600_state.c +++ b/src

[Mesa-dev] [PATCH 2/4] si_compute: check NULL return from u_upload_alloc

2017-03-24 Thread Julien Isorce
Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_compute.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 19a9189..e3ccc55 100644 --- a/src/gallium/drivers/radeonsi/si_compute.c ++

[Mesa-dev] [PATCH 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

2017-03-24 Thread Julien Isorce
Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..3ce190e 100644 --- a/src/mesa/state_tracker/st_cb_bitmap.c +++ b/src/mesa/s

Re: [Mesa-dev] [PATCH] mesa/glthread: add custom marshalling for ClearBufferfv()

2017-03-24 Thread Nicolai Hähnle
On 24.03.2017 07:46, Timothy Arceri wrote: This is one of the main causes of syncs in Civ6. Reviewed-by: Nicolai Hähnle --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/marshal.c | 73 + src/mesa/main/marshal.h | 9 ++ 3 files c

[Mesa-dev] [PATCH v4.1 07/28] i965/fs: generalize the legalization d2x pass

2017-03-24 Thread Samuel Iglesias Gonsálvez
Generalize it to lower any unsupported narrower conversion. v2 (Curro): - Add supports_type_conversion() - Reuse existing intruction instead of cloning it. - Generalize d2x to narrower and equal size conversions. v3 (Curro): - Make supports_type_conversion() const and improve it. - Use foreach_bl

[Mesa-dev] [PATCH v4.1 17.5/28] i965/vec4: split VEC4_OPCODE_FROM_DOUBLE into one opcode per destination's type

2017-03-24 Thread Samuel Iglesias Gonsálvez
This way we can set the destination type as double to all these new opcodes, avoiding any optimizer's confusion that was happening before. Signed-off-by: Samuel Iglesias Gonsálvez --- This patch is going to be placed just after patch 17. Please discard patch 19. src/intel/compiler/brw_eu_defin

Re: [Mesa-dev] [PATCH 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

2017-03-24 Thread Nicolai Hähnle
On 24.03.2017 12:08, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..3ce190e 100644 --- a/src/mesa/s

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

2017-03-24 Thread Nicolai Hähnle
I generally like the patches in the series, thanks for that. Two points though: 1. The order of patches in series is usually general code before driver code, i.e. the st/cb_bitmap should come first. 2. I don't like having silent errors, as that could be confusing. In places where the error i

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Emil Velikov
On 24 March 2017 at 11:02, Nicolai Hähnle wrote: > On 24.03.2017 01:00, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This should fix this radeonsi error: >> "mesa: for the -simplifycfg-sink-common option: may only occur zero or >> one >>times!" Can we have some commit message. Feel free

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

2017-03-24 Thread Julien Isorce
1: Ack, thx. 2: u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: alloc fails or map fails. For both there are already a fprintf/stderr, i.e., in radeon_create_bo and radeon_bo_do_map . It looks to me that in src/gallium/drivers/ it is a common usage to just avoid to crash

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-03-24 Thread Antía Puentes
On mié, 2017-02-01 at 19:18 +0100, Antía Puentes wrote: > On mié, 2017-02-01 at 00:37 -0500, Ilia Mirkin wrote: > > On Tue, Jan 31, 2017 at 2:55 PM, Antía Puentes wrote: > > > > > > There was an update in the OpenGL ES 3.2 specification (November 3, > > > 2016) addressing this: > > > > > > - In

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-03-24 Thread Antía Puentes
Reviewed-by: Antia Puentes On jue, 2017-01-26 at 00:47 -0500, Ilia Mirkin wrote: > When a texture is immutable, we can't tack on extra levels > after-the-fact like we could with glTexImage. So check against that > level limit and return an error if it's surpassed. > > The spec is a little uncle

Re: [Mesa-dev] [RFC 11/12] anv/cmd_buffer: Emit instanced draws for multiple views

2017-03-24 Thread Iago Toral
On Wed, 2017-03-22 at 21:01 -0700, Jason Ekstrand wrote: ---  src/intel/vulkan/anv_private.h |   6 ++  src/intel/vulkan/genX_cmd_buffer.c | 141 -  src/intel/vulkan/genX_pipeline.c   |  10 ++-  3 files changed, 152 insertions(+), 5 deletions(-) diff --git a/

Re: [Mesa-dev] [RFC 00/12] anv: A first pass at VK_KHX_multiview

2017-03-24 Thread Iago Toral
On Thu, 2017-03-23 at 14:28 +0100, Iago Toral wrote: > The proposed implementation makes sense to me, I looked through > patches > 1-8 and they all look good as well, so those are: Pateches 9, 19 and 12 are also: Reviewed-by: Iago Toral Quiroga I left some comments in patch 11. > Reviewed-by:

[Mesa-dev] [PATCH] egl: Return error on try to create multiple surfaces from window. (v3)

2017-03-24 Thread Adrian Pielech
According to the EGL 1.5 spec, section 3.5.1, page 34,35 on PDF eglCreateWindowSurface should set EGL_BAD_ALLOC if there is already surface for given window. Similarly it is written in EGL 1.4 spec, section 3.5.1, page 29 on PDF. v2: made it compilable(i'm porting it from other fork, so there was

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jose Fonseca
On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40 PM, Alex Deucher wrote: I guess I'm a little late to the party here, but I haven't had time to really let all o

Re: [Mesa-dev] [PATCH v2 2/5] intel: Move tools/decoder.[ch] to common/gen_decoder.[ch].

2017-03-24 Thread Rob Herring
On Thu, Mar 23, 2017 at 5:32 PM, Matt Turner wrote: > On Wed, Mar 22, 2017 at 12:53 PM, Rob Herring wrote: >> On Wed, Mar 22, 2017 at 6:50 AM, Emil Velikov >> wrote: >>> n 21 March 2017 at 20:58, Kenneth Graunke wrote: On Tuesday, March 21, 2017 4:40:26 AM PDT Emil Velikov wrote: > On

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jose Fonseca
On 22/03/17 20:57, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-22 10:59:10) On 17/03/17 02:28, Brian Paul wrote: [snip] Sure, I'd like to see one build system instead of two. Meson supports Windows so that's good. But the big issue is our automated build system. Replacing SCons with M

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Daniel Stone
Hi Jose, On 24 March 2017 at 14:03, Jose Fonseca wrote: > On 22/03/17 20:57, Dylan Baker wrote: >> Cross compiling for mingw is supported, and it provides a way to >> differentiate >> the build, host, and target machines [1], I've cross compiled for >> aarch64-linux-gnu, and it was trivial (I've

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Marek Olšák
On Fri, Mar 24, 2017 at 12:02 PM, Nicolai Hähnle wrote: > On 24.03.2017 01:00, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This should fix this radeonsi error: >> "mesa: for the -simplifycfg-sink-common option: may only occur zero or >> one >>times!" >> --- >> src/gallium/targets/va/v

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Marek Olšák
On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov wrote: > On 24 March 2017 at 11:02, Nicolai Hähnle wrote: >> On 24.03.2017 01:00, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> This should fix this radeonsi error: >>> "mesa: for the -simplifycfg-sink-common option: may only occur zero or

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Andy Furniss
Marek Olšák wrote: On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov wrote: On 24 March 2017 at 11:02, Nicolai Hähnle wrote: On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifycfg-sink-common option: may only occur zero or

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Marek Olšák
On Fri, Mar 24, 2017 at 3:50 PM, Andy Furniss wrote: > Marek Olšák wrote: >> >> On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov >> wrote: >>> >>> On 24 March 2017 at 11:02, Nicolai Hähnle wrote: On 24.03.2017 01:00, Marek Olšák wrote: > > > From: Marek Olšák > > Thi

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Andy Furniss
Andy Furniss wrote: I've not verified that, no. If it doesn't fix the bug, we still need this patch because of aforementioned reasons, and then we have to fix the bug. It fixes mpv for me testing vaapi hw decode + gl display. It doesn't fix ffmpeg cli though. ffmpeg -hwaccel vaapi -i testfi

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Emil Velikov
On 24 March 2017 at 14:42, Marek Olšák wrote: > On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov > wrote: >> On 24 March 2017 at 11:02, Nicolai Hähnle wrote: >>> On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for t

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Ilia Mirkin
Does the nouveau winsys create function also need to be added? I'm not sure I understand what problem this is solving... But afaik it's possible to use va + nouveau. On Mar 23, 2017 8:00 PM, "Marek Olšák" wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifyc

Re: [Mesa-dev] [PATCH 08/11] st/va: clear the video surface on allocation

2017-03-24 Thread Andy Furniss
Andy Furniss wrote: ping. Christian König wrote: From: Christian König This makes debugging of decoding problems quite a bit easier. This breaks gstreamer encode for me. ffmpeg is OK, but then IIRC ffmpeg only uses one of something that gstreamer uses two of, not wishing to get too techni

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Marek Olšák
On Fri, Mar 24, 2017 at 4:09 PM, Emil Velikov wrote: > On 24 March 2017 at 14:42, Marek Olšák wrote: >> On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov >> wrote: >>> On 24 March 2017 at 11:02, Nicolai Hähnle wrote: On 24.03.2017 01:00, Marek Olšák wrote: > > From: Marek Olšák

Re: [Mesa-dev] [PATCH 2/4] si_compute: check NULL return from u_upload_alloc

2017-03-24 Thread Marek Olšák
I think we should also return from si_launch_grid if this fails. Marek On Fri, Mar 24, 2017 at 12:08 PM, Julien Isorce wrote: > Signed-off-by: Julien Isorce > --- > src/gallium/drivers/radeonsi/si_compute.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH 2/9] genxml: Fix gen_zipped_file.py dependency

2017-03-24 Thread Emil Velikov
On 23 March 2017 at 01:03, Chad Versace wrote: > The gen*_xml.h files depend on gen_zipped_file.py, not the gen*_pack.h > files. Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/9] genxml: Define GENXML_XML_FILES in Makefile.sources

2017-03-24 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/9] genxml: New generated header genX_bits.h (v2)

2017-03-24 Thread Emil Velikov
On 23 March 2017 at 01:03, Chad Versace wrote: > --- > src/intel/Makefile.genxml.am| 6 +- > src/intel/Makefile.sources | 6 +- > src/intel/genxml/.gitignore | 1 + > src/intel/genxml/gen_bits_header.py | 259 > > 4 files chang

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

2017-03-24 Thread Emil Velikov
Hi Chad, On 23 March 2017 at 01:04, Chad Versace wrote: > Validate that isl_surf::row_pitch fits in the below bitfields, > if applicable based on isl_surf::usage. > > RENDER_SURFACE_STATE::SurfacePitch > RENDER_SURFACE_STATE::AuxiliarySurfacePitch > 3DSTATE_DEPTH_BUFFER::SurfacePitch

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jose Fonseca
On 24/03/17 14:22, Daniel Stone wrote: Hi Jose, On 24 March 2017 at 14:03, Jose Fonseca wrote: On 22/03/17 20:57, Dylan Baker wrote: Cross compiling for mingw is supported, and it provides a way to differentiate the build, host, and target machines [1], I've cross compiled for aarch64-linux-g

[Mesa-dev] [PATCH] mesa: simplify code around 'variable_data' in marshal.c

2017-03-24 Thread Brian Paul
Remove needless pointer increments, unneeded vars, etc. Untested. Plus, fix a couple comments. --- src/mesa/main/marshal.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/marshal.c b/src/mesa/main/marshal.c index cdc7fed..783ca0a 100644 --- a

Re: [Mesa-dev] Mesa (master): mesa/marshal: add custom BufferData/ BufferSubData marshalling

2017-03-24 Thread Brian Paul
Hi Timothy, Some late comments below. On 03/23/2017 06:28 PM, Timothy Arceri wrote: Module: Mesa Branch: master Commit: adced4a2f9d017ae126a438f97eb305fa0ca3bd0 URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3Dadced4a2f9d017ae126a438f97e

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Bas Nieuwenhuizen
> Another tool I heard good about but have not direct experience is > https://bazel.build . Any thoughts about it? Having looked a bit into it, it also is just a build system (albeit higher level than ninja or make). It doesn't do configure or install and working with system dependencies is annoy

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

2017-03-24 Thread Nicolai Hähnle
On 24.03.2017 13:11, Julien Isorce wrote: 1: Ack, thx. 2: u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: alloc fails or map fails. For both there are already a fprintf/stderr, i.e., in radeon_create_bo and radeon_bo_do_map . It looks to me that in src/gallium/drivers/

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Nicolai Hähnle
On 24.03.2017 15:31, Marek Olšák wrote: On Fri, Mar 24, 2017 at 12:02 PM, Nicolai Hähnle wrote: On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifycfg-sink-common option: may only occur zero or one times!" --- src/gal

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Dylan Baker
Quoting Colin Cross (2017-03-23 17:03:58) > On Thu, Mar 23, 2017 at 4:56 PM, Dylan Baker wrote: > > > > I'm hoping you can clarify a couple of questions I have about blueprint: > > 1) android is moving to blueprint from android.mk files? > > Yes, in a phased transition. We support both for now.

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread randyf
On Mon, 20 Mar 2017, Matt Turner wrote: - dropping the Autotools will lead to OpenBSD and NetBSD having to write one from scratch, IIRC Solaris/FreeBSD and others are in similar boat. Solaris is a closed source operating system whose developers do not contribute to the project. We do not

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Dylan Baker
Quoting Jose Fonseca (2017-03-24 06:42:18) > > I tend to disagree. While we can't avoid a transitory period, when we > embark on another build system (Meson or something else) I think we > should aim at 1) ensure such tool can indeed _completely_ replace at > least _one_ existing build system,

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Emil Velikov
On 24 March 2017 at 15:26, Marek Olšák wrote: > On Fri, Mar 24, 2017 at 4:09 PM, Emil Velikov > wrote: >> On 24 March 2017 at 14:42, Marek Olšák wrote: >>> On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov >>> wrote: On 24 March 2017 at 11:02, Nicolai Hähnle wrote: > On 24.03.2017 01:0

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > Quoting Jose Fonseca (2017-03-24 06:42:18) >> >> I tend to disagree. While we can't avoid a transitory period, when we >> embark on another build system (Meson or something else) I think we >> should aim at 1) ensure such tool can indeed _c

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-03-24 Thread Ilia Mirkin
Wait, so are we saying that my original patch is good? I've beyond-lost context on all this, but as I recall my original patch had some issues. As I don't have Khronos access to the bug in question, I'm not sure what the right thing is. The original patch applies this logic to gl[Named]Framebuffer

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

2017-03-24 Thread Chad Versace
On Fri 24 Mar 2017, Emil Velikov wrote: > Hi Chad, > > On 23 March 2017 at 01:04, Chad Versace wrote: > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > > RENDER_SURFACE_STATE::SurfacePitch > > RENDER_SURFACE_STATE::Auxilia

Re: [Mesa-dev] [PATCH 1/4] vc4: Fix indenting in vc4_screen_get_param()

2017-03-24 Thread Eric Anholt
Lyude writes: > Signed-off-by: Lyude Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

2017-03-24 Thread Chad Versace
On Thu 23 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 22, 2017 at 6:04 PM, Chad Versace > wrote: > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > > RENDER_SURFACE_STATE::SurfacePitch > > RENDER_SURFACE_STATE::Auxiliar

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Daniel Stone
Hi, On 24 March 2017 at 17:51, Eric Anholt wrote: > Dylan Baker writes: >> I also think it's worth talking to Eric (who said he's porting X to meson), >> Daniel Stone (who has patches to port weston to meson), and Peter Hutterer >> (who >> has patches to port libinput to meson). If they're seri

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

2017-03-24 Thread Emil Velikov
On 24 March 2017 at 18:02, Chad Versace wrote: > On Fri 24 Mar 2017, Emil Velikov wrote: >> Hi Chad, >> >> On 23 March 2017 at 01:04, Chad Versace wrote: >> > Validate that isl_surf::row_pitch fits in the below bitfields, >> > if applicable based on isl_surf::usage. >> > >> > RENDER_SURFACE_S

Re: [Mesa-dev] [PATCH] i965: Fix symbolic size of next_offset[] array.

2017-03-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Kristian Høgsberg
On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: > On 23/03/17 01:38, Rob Clark wrote: >> >> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: >>> >>> On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40 PM, Alex Deucher wrote: > >

Re: [Mesa-dev] [PATCH] i965: Remove pointless NULL check from Gen6 primitive counting code.

2017-03-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Require Kernel 3.6 for Gen4-5 platforms.

2017-03-24 Thread Matt Turner
On Wed, Mar 22, 2017 at 3:20 PM, Kenneth Graunke wrote: > We've already required Kernel 3.6 on Gen6+ since Mesa 9.2 (May 2013, > commit 92d2f5acfadea672417b6785710c9e8b7f605e41). It seems reasonable > to require it for Gen4-5 as well, bumping the requirement from 2.6.39. > > This is necessary for

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

2017-03-24 Thread Matt Turner
On Fri, Mar 24, 2017 at 12:06 AM, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: >>> SEL can only convert between a few integer types, which we basically >>> never do. >>> >>> Fixes fs/vs-double-uniform-array-direct-indirect-n

[Mesa-dev] [PATCH v4 1/1] clover: use pipe_resource references

2017-03-24 Thread Jan Vesely
v2: buffers are created with one reference. v3: add pipe_resource reference to mapping object v4: rename to pres and drop inline initializers CC: "17.0 13.0" Signed-off-by: Jan Vesely --- resend to include mesa-dev ML sorry for spamming jan src/gallium/state_trackers/clover/core/resource.cpp

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

2017-03-24 Thread Francisco Jerez
Matt Turner writes: > On Fri, Mar 24, 2017 at 12:06 AM, Francisco Jerez > wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: SEL can only convert between a few integer types, which we basically never do. Fixes fs/vs-doub

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Kristian Høgsberg
On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca wrote: > On 24/03/17 19:10, Kristian Høgsberg wrote: >> >> On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >>> >>> On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: > > > On Wed

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

2017-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99591 Luiz Angelo Daros de Luca changed: What|Removed |Added CC||luizl...@gmail.com -- You a

Re: [Mesa-dev] [PATCH] anv: enable sampling from fast-cleared images on SKL

2017-03-24 Thread Nanley Chery
On Mar 23, 2017 11:00 PM, "Samuel Iglesias Gonsálvez" wrote: On Thu, 2017-03-23 at 11:09 -0700, Nanley Chery wrote: > On Thu, Mar 23, 2017 at 12:25:28PM +0100, Samuel Iglesias Gonsálvez > wrote: > > A resolve is not needed on Skylake in this case. We were forcing > > a resolve because we set the

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Chad Versace
On Tue 21 Mar 2017, Matt Turner wrote: > On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > wrote: > > On 20 March 2017 at 18:30, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov > >> wrote: > >>> These projects have been getting closer to upstream and "forcing" the > >>> e

Re: [Mesa-dev] [PATCH v4.1 07/28] i965/fs: generalize the legalization d2x pass

2017-03-24 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > Generalize it to lower any unsupported narrower conversion. > > v2 (Curro): > - Add supports_type_conversion() > - Reuse existing intruction instead of cloning it. > - Generalize d2x to narrower and equal size conversions. > > v3 (Curro): > - Make supports_type

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Chad Versace
On Tue 21 Mar 2017, Matt Turner wrote: > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: > > On 21 March 2017 at 15:57, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > >> wrote: > >>> On 20 March 2017 at 18:30, Matt Turner wrote: > On Mon, Mar 20, 2017 at

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Rob Clark
On Fri, Mar 24, 2017 at 3:10 PM, Kristian Høgsberg wrote: > On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >> On 23/03/17 01:38, Rob Clark wrote: >>> >>> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: > >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jose Fonseca
On 24/03/17 20:08, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca wrote: On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote:

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jose Fonseca
On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40 PM, Alex D

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Jason Ekstrand
On Fri, Mar 24, 2017 at 2:16 PM, Jose Fonseca wrote: > On 24/03/17 20:08, Kristian Høgsberg wrote: > >> On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca >> wrote: >> >>> On 24/03/17 19:10, Kristian Høgsberg wrote: >>> On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >

[Mesa-dev] [PATCH 1/2] gallium/util: clean up stack frame printing

2017-03-24 Thread Rob Clark
Prep work for next patch. Ideally 'struct debug_stack_frame' would be opaque, but it is embedded in a bunch of places. But at least we can treat it opaquely. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_debug_refcnt.c | 27 --- src/gallium/auxiliary/util/u_

[Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-03-24 Thread Rob Clark
It's kinda sad that (a) we don't have debug_backtrace support on !X86 and that (b) we re-invent our own crude backtrace support in the first place. If available, use libunwind instead. The backtrace format is based on what xserver and weston use, since it is nice not to have to figure out a diffe

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Rob Clark
On Fri, Mar 24, 2017 at 5:16 PM, Jose Fonseca wrote: > On 24/03/17 20:08, Kristian Høgsberg wrote: >> >> On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca >> wrote: >>> >>> On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: > >>>

[Mesa-dev] [PATCH 2/8] genxml: Fix gen_zipped_file.py dependency

2017-03-24 Thread Jason Ekstrand
From: Chad Versace The gen*_xml.h files depend on gen_zipped_file.py, not the gen*_pack.h files. --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index eab6ccd..01a02b6 100644 --- a/sr

[Mesa-dev] [PATCH 0/8] genxml: Add a _bits header

2017-03-24 Thread Jason Ekstrand
This series is a re-spin of some patches that Chad wrote to add a genX_bits.h header which contains functions for getting the number of bits in any given hardware state field. The first few patches are fixes for genxml. There were a bunch of places where the sanitized field names matched but not

[Mesa-dev] [PATCH 4/8] genxml/gen8: Remove BLACK_LEVEL_CORRECTION_STATE

2017-03-24 Thread Jason Ekstrand
We've never used it, it only exists on gen8, and the name of the struct contains piles of bad characters. --- src/intel/genxml/gen8.xml | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index f9899c6..193a183 100644 --- a/src/intel/genxm

[Mesa-dev] [PATCH 7/8] genxml: Whitespace fixes

2017-03-24 Thread Jason Ekstrand
Some field names had extra spaces and some had places where we should have had a space but didn't. --- src/intel/genxml/gen6.xml | 16 src/intel/genxml/gen7.xml | 24 src/intel/genxml/gen75.xml | 22 +++--- src/intel/genxml/gen8.xml | 8

[Mesa-dev] [PATCH 3/8] genxml: Rename two MCS fields to Auxiliary Surface on gen7

2017-03-24 Thread Jason Ekstrand
This makes gen7 more consistent with gen8+ --- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml| 4 ++-- src/intel/isl/isl_surface_state.c | 7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml

[Mesa-dev] [PATCH 5/8] genxml/gen6: Remove a couple of bogus values

2017-03-24 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index da3f64d..d77d158 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -939,18 +939,14 @@ -

[Mesa-dev] [PATCH 1/8] genxml: Define GENXML_XML_FILES in Makefile.sources

2017-03-24 Thread Jason Ekstrand
From: Chad Versace The future header genX_bits.h will depend on GENXML_XML_FILES. --- src/intel/Makefile.genxml.am | 9 + src/intel/Makefile.sources | 10 ++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxm

[Mesa-dev] [PATCH 6/8] genxml: Replace "[N]" with "N"

2017-03-24 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 6 +++--- src/intel/genxml/gen7.xml | 12 ++-- src/intel/genxml/gen75.xml | 12 ++-- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index d77d158..8eef7bf 100644 --- a/src/int

[Mesa-dev] [PATCH 8/8] genxml: New generated header genX_bits.h (v2)

2017-03-24 Thread Jason Ekstrand
From: Chad Versace genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. isl_surf_init() will use the new header to validate that requested pitches fit in their destination bitfields. What's currently

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

2017-03-24 Thread Jason Ekstrand
On Fri, Mar 24, 2017 at 11:10 AM, Chad Versace wrote: > On Thu 23 Mar 2017, Jason Ekstrand wrote: > > On Wed, Mar 22, 2017 at 6:04 PM, Chad Versace > > wrote: > > > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > > if applicable based on isl_surf::usage. > > > > > > RE

Re: [Mesa-dev] [PATCH 3/8] genxml: Rename two MCS fields to Auxiliary Surface on gen7

2017-03-24 Thread Chad Versace
On Fri 24 Mar 2017, Jason Ekstrand wrote: > This makes gen7 more consistent with gen8+ > --- > src/intel/genxml/gen7.xml | 4 ++-- > src/intel/genxml/gen75.xml| 4 ++-- > src/intel/isl/isl_surface_state.c | 7 +++ > 3 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by:

Re: [Mesa-dev] [PATCH 2/8] genxml: Fix gen_zipped_file.py dependency

2017-03-24 Thread Chad Versace
Patches 1 and 2 are pushed, with Emil's r-b. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] st/wgl: Replace variable name hdc with hDrawDC

2017-03-24 Thread Brian Paul
From: Neha Bhende Reviewed-by: Brian Paul --- src/gallium/state_trackers/wgl/stw_context.c | 16 src/gallium/state_trackers/wgl/stw_context.h | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/wgl/stw_context.c b/src/gallium/

[Mesa-dev] [PATCH 1/3] stw/wgl: add null context check in wglBindTexImageARB()

2017-03-24 Thread Brian Paul
To avoid dereferencing a null pointer in case wglMakeCurrent() wasn't called. Found while debugging SWKOTOR game. Reviewed-by: Neha Bhende Reviewed-by: Charmaine Lee --- src/gallium/state_trackers/wgl/stw_ext_rendertexture.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/3] st/wgl: add support for WGL_ARB_make_current_read

2017-03-24 Thread Brian Paul
This adds the wglMakeContextCurrentARB() and wglMakeContextCurrentARB() functions. --- src/gallium/state_trackers/wgl/stw_context.c | 77 ++ src/gallium/state_trackers/wgl/stw_context.h | 5 +- src/gallium/state_trackers/wgl/stw_ext_context.c | 15 + .../stat

Re: [Mesa-dev] [PATCH 4/8] genxml/gen8: Remove BLACK_LEVEL_CORRECTION_STATE

2017-03-24 Thread Chad Versace
On Fri 24 Mar 2017, Jason Ekstrand wrote: > We've never used it, it only exists on gen8, and the name of the struct > contains piles of bad characters. > --- > src/intel/genxml/gen8.xml | 6 -- > 1 file changed, 6 deletions(-) > - wtf. Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 5/8] genxml/gen6: Remove a couple of bogus values

2017-03-24 Thread Chad Versace
On Fri 24 Mar 2017, Jason Ekstrand wrote: > --- > src/intel/genxml/gen6.xml | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Thanks. I discovered these in writing my patches, but forgot to fix them. Reviewed-by: Chad Versace ___ mesa-de

Re: [Mesa-dev] [PATCH 7/8] genxml: Whitespace fixes

2017-03-24 Thread Chad Versace
Patches 6 and 7 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH resend] mesa: Require mipmap completeness for glCopyImageSubData(), sometimes.

2017-03-24 Thread Kenneth Graunke
This patch makes glCopyImageSubData require mipmap completeness when the texture object's built-in sampler object has a mipmapping MinFilter. Fixes (on i965): dEQP-GLES31.functional.debug.negative_coverage.*.buffer.copy_image_sub_data Signed-off-by: Kenneth Graunke --- src/mesa/main/copyimage.c

Re: [Mesa-dev] MESA and KOTOR

2017-03-24 Thread Brian Paul
I'm going to re-post my recent wgl patches (verified to work now) for review before committing to master. Looking at some other notes in our code, there's another issue with KOTOR. Try setting the following env var: MESA_EXTENSION_OVERRIDE=-GL_ATI_fragment_shader The '-' means disable the G

Re: [Mesa-dev] Mesa (master): mesa/marshal: add custom BufferData/ BufferSubData marshalling

2017-03-24 Thread Timothy Arceri
On 25/03/17 02:49, Brian Paul wrote: Hi Timothy, Some late comments below. On 03/23/2017 06:28 PM, Timothy Arceri wrote: Module: Mesa Branch: master Commit: adced4a2f9d017ae126a438f97eb305fa0ca3bd0 URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit

[Mesa-dev] [PATCH] tests/cache_test: mark arguments const

2017-03-24 Thread Grazvydas Ignotas
While at it, also fix up a failure message to not reference timestamp and gpu dirs as those are no longer being made. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/tests/cach

[Mesa-dev] [PATCH] util/disk_cache: avoid making mesa subdir when cache dir is specified

2017-03-24 Thread Grazvydas Ignotas
When MESA_GLSL_CACHE_DIR is specified, we currently add a /mesa subdir even though the documentation and nearby comment in the code make no mention of it. Doesn't look useful too, remove. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 2 +- src/util/disk_cache.c

  1   2   >