Re: [Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 18:44, Marek Olšák wrote: From: Marek Olšák This fixes: vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && "Pass ID not registered!"' failed. Cc: 13.0 17.0 --- src/gallium/auxiliary/u

Re: [Mesa-dev] [PATCH 3/4] gallium/hud: prevent an infinite loop

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 18:44, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index aaa52d5..488fe66 100644 --- a/s

Re: [Mesa-dev] [PATCH 4/4] gallium/hud: handle a thread switch for API-thread-busy monitoring

2017-02-21 Thread Nicolai Hähnle
Some comments on patches 1 & 3. Apart from that: Reviewed-by: Nicolai Hähnle On 20.02.2017 18:44, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/hud/hud_cpu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_cp

Re: [Mesa-dev] [PATCH 1/5] etnaviv: add support for user index buffers

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 19:03, Marek Olšák wrote: From: Marek Olšák v2: fix a bug in u_helpers Would've been nice to be more specific here. Anyway, the change is fine: Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/util/u_helpers.c| 29 +++ src/gallium/auxili

Re: [Mesa-dev] [PATCH] vbo: kill primitive restart lowering in glDrawArrays

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 19:35, Marek Olšák wrote: From: Marek Olšák Reviewed-by: Nicolai Hähnle --- src/mesa/vbo/vbo_exec_array.c | 56 ++- 1 file changed, 7 insertions(+), 49 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_ar

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 20:27, Emil Velikov wrote: From: Emil Velikov Suggested-by: Eric Engestrom Signed-off-by: Emil Velikov --- docs/releasing.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/releasing.html b/docs/releasing.html index 048aa1f7a4..26daf505a5 100644

Re: [Mesa-dev] [PATCH] util/disk_cache: create timestamp and gpu_id dirs when MESA_GLSL_CACHE_DIR is used

2017-02-21 Thread Nicolai Hähnle
On 21.02.2017 06:39, Timothy Arceri wrote: The make check test is also updated to make sure these dirs are created. --- src/compiler/glsl/tests/cache_test.c | 40 src/util/disk_cache.c| 10 +++-- 2 files changed, 48 insertions(+), 2 deleti

Re: [Mesa-dev] [PATCH 1/4] util/radv: move *_get_function_timestamp() to utils

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 01:15, Timothy Arceri wrote: V2: The functions we are now sharing used different return values update the callers to reflect the new common api. Wasn't there a similar patch on the list recently that also had an anv part? Cheers, Nicolai --- src/amd/vulkan/radv_device.c | 22 +

Re: [Mesa-dev] [PATCH 2/4] st/mesa: implement a tgsi on-disk shader cache

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 01:15, Timothy Arceri wrote: Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders I don't think the comments I sent earlier were addressed: https://lists.freedesktop.org/archives/mesa-dev/2017-February/144675.html Thanks, Nicolai --- src

Re: [Mesa-dev] [PATCH 3/4] gallium: add disk_cache_create() callback

2017-02-21 Thread Nicolai Hähnle
On 20.02.2017 01:15, Timothy Arceri wrote: --- src/gallium/include/pipe/p_screen.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index b6203f1..43dcdf0 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/sr

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Gustaw Smolarczyk
21 lut 2017 03:47 "Jason Ekstrand" napisał(a): Fine by me Reviewed-by: Jason Ekstrand On Mon, Feb 20, 2017 at 6:26 PM, Dave Airlie wrote: > From: Dave Airlie > > For prime support I need to access this, so move it in advance. > > Signed-off-by: Dave Airlie > --- > src/vulkan/wsi/wsi_commo

Re: [Mesa-dev] [PATCH 1/4] util/radv: move *_get_function_timestamp() to utils

2017-02-21 Thread Timothy Arceri
On 21/02/17 19:54, Nicolai Hähnle wrote: On 20.02.2017 01:15, Timothy Arceri wrote: V2: The functions we are now sharing used different return values update the callers to reflect the new common api. Wasn't there a similar patch on the list recently that also had an anv part? Yes but they

Re: [Mesa-dev] [PATCH 2/4] st/mesa: implement a tgsi on-disk shader cache

2017-02-21 Thread Timothy Arceri
On 21/02/17 19:57, Nicolai Hähnle wrote: On 20.02.2017 01:15, Timothy Arceri wrote: Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders I don't think the comments I sent earlier were addressed: https://lists.freedesktop.org/archives/mesa-dev/2017-Februa

Re: [Mesa-dev] [PATCH V2 3.5/4] st/mesa: get on-disk shader cache

2017-02-21 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/21/2017 02:18 PM, Timothy Arceri wrote: > V2: make sure callback exists before calling it > --- > src/mesa/state_tracker/st_context.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH V4 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-21 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/21/2017 05:10 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. > > V2: share code in r600_pipe_common as suggested by Mare

Re: [Mesa-dev] [PATCH 1/4] util/radv: move *_get_function_timestamp() to utils

2017-02-21 Thread Nicolai Hähnle
On 21.02.2017 10:16, Timothy Arceri wrote: On 21/02/17 19:54, Nicolai Hähnle wrote: On 20.02.2017 01:15, Timothy Arceri wrote: V2: The functions we are now sharing used different return values update the callers to reflect the new common api. Wasn't there a similar patch on the list recently

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-21 Thread tournier.elie
On 13 February 2017 at 20:35, Rhys Kidd wrote: > > On Mon, Feb 13, 2017 at 9:43 AM Elie Tournier > wrote: > >> Seems good to me. >> >> Reviewed-by: Elie Tournier >> > > Thanks Elie. > > Given we are both "new-er" Mesa contributors I might wait for one more > Reviewed-by before asking for it to

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-21 Thread Marek Olšák
On Tue, Feb 21, 2017 at 4:36 AM, Roland Scheidegger wrote: > Am 20.02.2017 um 21:58 schrieb Marek Olšák: >> On Mon, Feb 20, 2017 at 9:28 PM, Roland Scheidegger >> wrote: >>> Am 20.02.2017 um 20:56 schrieb Marek Olšák: On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: > On 20/02/2017 20

Re: [Mesa-dev] [PATCH V4 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Feb 21, 2017 at 7:10 AM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. > > V2: share code in r600_pipe_common as suggeste

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-21 Thread Eric Engestrom
On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote: > On 20.02.2017 20:27, Emil Velikov wrote: > > From: Emil Velikov > > > > Suggested-by: Eric Engestrom > > Signed-off-by: Emil Velikov > > --- > > docs/releasing.html | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] [PATCH V2 3.5/4] st/mesa: get on-disk shader cache

2017-02-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Feb 21, 2017 at 4:18 AM, Timothy Arceri wrote: > V2: make sure callback exists before calling it > --- > src/mesa/state_tracker/st_context.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/stat

Re: [Mesa-dev] [PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT

2017-02-21 Thread Samuel Iglesias Gonsálvez
On 20/02/17 21:31, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> On Mon, 2017-02-20 at 08:58 +0100, Samuel Iglesias Gonsálvez wrote: >>> On Sat, 2017-02-18 at 18:58 -0800, Francisco Jerez wrote: Samuel Iglesias Gonsálvez writes: > The lowered BSW/BXT indirect move

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-21 Thread Emil Velikov
On 21 February 2017 at 11:02, Eric Engestrom wrote: > On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote: >> On 20.02.2017 20:27, Emil Velikov wrote: >> > From: Emil Velikov >> > >> > Suggested-by: Eric Engestrom >> > Signed-off-by: Emil Velikov >> > --- >> > docs/releasing.html | 6 +

Re: [Mesa-dev] [PATCH 1/3] radv/ac: rename num clips/cull to output clips/culls

2017-02-21 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/21/2017 03:14 PM, Dave Airlie wrote: > From: Dave Airlie > > As geom shaders can have different ones on entry and exit. > > also move to uint8_t as these are never that big. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to

Re: [Mesa-dev] [PATCH 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-21 Thread Lionel Landwerlin
On 20/02/17 19:21, Jason Ekstrand wrote: Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 17 - src/intel/vulkan/genX_blorp_exec.c | 8

Re: [Mesa-dev] [PATCH 0/5] anv: Fix and rework flushing

2017-02-21 Thread Lionel Landwerlin
Nice cleanup, patches 2->5 are : Reviewed-by: Lionel Landwerlin Just one question on patch 1. On 20/02/17 19:21, Jason Ekstrand wrote: The first patch in this little series should fix actual bugs on little-core platforms because it makes BLORP properly clflush it's dynamic state in Vulkan. T

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Edward O'Callaghan
wait, why is this needed at all Dave? The application should be querying and picking the correct GPU as you well know. This seems unwise to tamper with the mechanism defined by the specification. Kindly, Edward. On 02/21/2017 01:47 PM, Jason Ekstrand wrote: > Fine by me > > Reviewed-by: Jason E

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #2 from Henrique Dante de Almeida --- Yes: Nome : libclc Versão : 0.2.0+334+520743b-1 Descrição: Library requirements of the OpenCL C programming language Arquitetura : any URL

[Mesa-dev] [PATCH mesa 4/5] gallium/docs: fix section title formatting

2017-02-21 Thread Eric Engestrom
src/gallium/docs/source/tgsi.rst:3488: WARNING: Title underline too short. Signed-off-by: Eric Engestrom --- src/gallium/docs/source/tgsi.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index

[Mesa-dev] [PATCH mesa 2/5] gallium/docs: add missing math formatting

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/docs/source/tgsi.rst | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index c296447b5c..b9b9d6ca34 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/t

[Mesa-dev] [Bug 99886] [radv] No actual multithreading in a Vulkan multithreading demo

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99886 Bug ID: 99886 Summary: [radv] No actual multithreading in a Vulkan multithreading demo Product: Mesa Version: git Hardware: Other OS: All Status

[Mesa-dev] [PATCH mesa 1/5] gallium/docs: fix sublist formatting

2017-02-21 Thread Eric Engestrom
src/gallium/docs/source/context.rst:95: ERROR: Unexpected indentation. Sub lists need to be surrounded by a blank line. Signed-off-by: Eric Engestrom --- src/gallium/docs/source/context.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/docs/source/context.rst b/src/

[Mesa-dev] [PATCH mesa 3/5] gallium/docs: add missing newlines

2017-02-21 Thread Eric Engestrom
Without these, mathjax considers these as the continuation of the previous line. Signed-off-by: Eric Engestrom --- src/gallium/docs/source/tgsi.rst | 33 + 1 file changed, 33 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tg

[Mesa-dev] [PATCH mesa 0/5] gallium/docs: formatting fixes

2017-02-21 Thread Eric Engestrom
I noticed a bunch of warnings and errors when compiling the docs, so I fixed the ones I knew how. There's a couple warnings left to fix, if anyone's interested: - src/gallium/docs/source/drivers/freedreno/ir3-notes.rst:195: WARNING: Could not lex literal_block as "c". Highlighting skipped. Sh

[Mesa-dev] [PATCH mesa 5/5] gallium/docs: use imgmath instead of pngmath

2017-02-21 Thread Eric Engestrom
WARNING: sphinx.ext.pngmath has been deprecated. Please use sphinx.ext.imgmath instead. Signed-off-by: Eric Engestrom --- src/gallium/docs/source/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/docs/source/conf.py b/src/gallium/docs/source/

Re: [Mesa-dev] [PATCH mesa] docs: add link to gallium doc

2017-02-21 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa v2] docs: fix gamma correction link

2017-02-21 Thread Emil Velikov
On 14 February 2017 at 22:48, Eric Engestrom wrote: > From: Eric Engestrom > > That link has been dead for 15 years... > We could link to Archive.org [1] to get the last time this page existed, > but I feel like Wikipedia is a better choice. > > [1] > http://web.archive.org/web/20021211151318/ht

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #3 from Vedran Miletić --- On Fedora 25 with custom-compiled LLVM, libclc, and Mesa: $ gcc -lOpenCL -lm hello.c hello.c: In function ‘main’: hello.c:269:5: warning: ‘clCreateCommandQueue’ is deprecated [-Wdeprecated-declarations]

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-21 Thread Roland Scheidegger
Am 21.02.2017 um 11:46 schrieb Marek Olšák: > On Tue, Feb 21, 2017 at 4:36 AM, Roland Scheidegger > wrote: >> Am 20.02.2017 um 21:58 schrieb Marek Olšák: >>> On Mon, Feb 20, 2017 at 9:28 PM, Roland Scheidegger >>> wrote: Am 20.02.2017 um 20:56 schrieb Marek Olšák: > On Mon, Feb 20, 201

Re: [Mesa-dev] [PATCH 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-21 Thread Jason Ekstrand
On Tue, Feb 21, 2017 at 4:05 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 20/02/17 19:21, Jason Ekstrand wrote: > >> Found by inspection. However, I expect it fixes real bugs when using >> blorp from Vulkan on little-core platforms. >> >> Cc: "13.0 17.0" >> --- >> src/int

Re: [Mesa-dev] [PATCH v2] softpipe: implement clear_texture

2017-02-21 Thread Lars Hamre
That does seem nicer, then pipe->clear_texture could just be set to util_clear_texture. Tangentially, do you see anything preventing this solution being utilized by llvmpipe? On Mon, Feb 20, 2017 at 2:31 PM, Roland Scheidegger wrote: > Am 20.02.2017 um 18:01 schrieb Lars Hamre: >> v2: rework util

[Mesa-dev] [PATCH v3 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-21 Thread Jason Ekstrand
Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 19 ++- src/intel/vulkan/genX_blorp_exec.c | 11 +++ src/mesa/drivers/dri/i965/genX

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-21 Thread Axel Davy
On 21/02/2017 16:00, Roland Scheidegger wrote: Am 21.02.2017 um 11:46 schrieb Marek Olšák: On Tue, Feb 21, 2017 at 4:36 AM, Roland Scheidegger wrote: Am 20.02.2017 um 21:58 schrieb Marek Olšák: On Mon, Feb 20, 2017 at 9:28 PM, Roland Scheidegger wrote: Am 20.02.2017 um 20:56 schrieb Marek O

Re: [Mesa-dev] [PATCH v2] softpipe: implement clear_texture

2017-02-21 Thread Roland Scheidegger
Am 21.02.2017 um 16:44 schrieb Lars Hamre: > That does seem nicer, then pipe->clear_texture could just be set to > util_clear_texture. > Tangentially, do you see anything preventing this solution being > utilized by llvmpipe? No, that should work just fine. llvmpipe doesn't do anything special for

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-21 Thread Roland Scheidegger
Am 21.02.2017 um 16:49 schrieb Axel Davy: > On 21/02/2017 16:00, Roland Scheidegger wrote: >> Am 21.02.2017 um 11:46 schrieb Marek Olšák: >>> On Tue, Feb 21, 2017 at 4:36 AM, Roland Scheidegger >>> wrote: Am 20.02.2017 um 21:58 schrieb Marek Olšák: > On Mon, Feb 20, 2017 at 9:28 PM, Rolan

[Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

2017-02-21 Thread Elie Tournier
nir_const_value is not needed in get_iteration Signed-off-by: Elie Tournier --- I don't have the git access. Please push it for me. BR, Elie --- src/compiler/nir/nir_loop_analyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Jason Ekstrand
On Tue, Feb 21, 2017 at 1:01 AM, Gustaw Smolarczyk wrote: > 21 lut 2017 03:47 "Jason Ekstrand" napisał(a): > > Fine by me > > Reviewed-by: Jason Ekstrand > > On Mon, Feb 20, 2017 at 6:26 PM, Dave Airlie wrote: > >> From: Dave Airlie >> >> For prime support I need to access this, so move it in

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Jason Ekstrand
On Tue, Feb 21, 2017 at 5:06 AM, Edward O'Callaghan < funfunc...@folklore1984.net> wrote: > wait, why is this needed at all Dave? > > The application should be querying and picking the correct GPU as you > well know. This seems unwise to tamper with the mechanism defined by the > specification. >

Re: [Mesa-dev] [PATCH] vbo: kill primitive restart lowering in glDrawArrays

2017-02-21 Thread Kenneth Graunke
On Monday, February 20, 2017 10:35:36 AM PST Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/vbo/vbo_exec_array.c | 56 > ++- > 1 file changed, 7 insertions(+), 49 deletions(-) > > diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_e

[Mesa-dev] [PATCH mesa] glx: add GLXdispatchIndex sort check

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/glx/tests/Makefile.am | 2 +- src/glx/tests/dispatch-index-check | 24 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100755 src/glx/tests/dispatch-index-check diff --git a/src/glx/tests/Makefile.am b/src/glx

Re: [Mesa-dev] [PATCH v3 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-21 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 21/02/17 15:47, Jason Ekstrand wrote: Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 19 ++- src/intel/vulk

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-21 Thread Emil Velikov
On 21 February 2017 at 09:54, tournier.elie wrote: > On 13 February 2017 at 20:35, Rhys Kidd wrote: >> >> >> On Mon, Feb 13, 2017 at 9:43 AM Elie Tournier >> wrote: >>> >>> Seems good to me. >>> >>> Reviewed-by: Elie Tournier >> >> >> Thanks Elie. >> >> Given we are both "new-er" Mesa contribut

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

2017-02-21 Thread Ian Romanick
On 02/16/2017 04:33 PM, Timothy Arceri wrote: > On 17/02/17 10:44, Ian Romanick wrote: >> On 02/15/2017 11:58 PM, Timothy Arceri wrote: >>> On 16/02/17 17:55, Tapani Pälli wrote: On 02/16/2017 04:52 AM, Timothy Arceri wrote: > In order add functionality to ARB_get_program_binary we ne

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Dave Airlie
On 21 February 2017 at 23:06, Edward O'Callaghan wrote: > wait, why is this needed at all Dave? > > The application should be querying and picking the correct GPU as you > well know. This seems unwise to tamper with the mechanism defined by the > specification. how do you propose we get the frame

Re: [Mesa-dev] [PATCH 4/4] radv/entrypoints: Only generate entrypoints for supported features

2017-02-21 Thread Dave Airlie
On 19 February 2017 at 21:49, Emil Velikov wrote: > This changes the way radv_entrypoints_gen.py works from generating a > table containing every single entrypoint in the XML to just the ones > that we actually need. There's no reason for us to burn entrypoint > table space on a bunch of NV exten

[Mesa-dev] [Bug 99886] [radv] No actual multithreading in a Vulkan multithreading demo

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99886 --- Comment #1 from david becerra --- on anv the load is distributed beetwen cores but it is gpu bound so no core reaches 50% :/ what does the demo say using 4 threads, 1... -- You are receiving this mail because: You are the QA Contact for th

Re: [Mesa-dev] [PATCH mesa 0/5] gallium/docs: formatting fixes

2017-02-21 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin I actually had fixes for some of the tgsi.rst stuff but never mailed them out. We'll see what the rebase leaves me with once you push them. On Tue, Feb 21, 2017 at 9:15 AM, Eric Engestrom wrote: > I noticed a bunch of warnings and errors when compiling the do

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT

2017-02-21 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 20/02/17 21:31, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> On Mon, 2017-02-20 at 08:58 +0100, Samuel Iglesias Gonsálvez wrote: On Sat, 2017-02-18 at 18:58 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: >

Re: [Mesa-dev] [PATCH] st/nine: make use of common uploaders v4

2017-02-21 Thread Axel Davy
This looks fine to me. Reviewed-by: Axel Davy I think the patch requires your Signed-off-by though. Axel On 21/02/2017 05:31, Constantine Charlamov wrote: Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration v3: per Axel co

Re: [Mesa-dev] [PATCH] anv: implement pipeline statistics queries

2017-02-21 Thread Ilia Mirkin
Looks like after nearly 3 months of no reviews that lead to R-b's[1], this patch no longer applies to master. I'm abandoning it. If anyone's interested, feel free to pick it up and make it your own. Cheers, -ilia [1] Robert did look at it, but didn't have significant feedback or say what I nee

Re: [Mesa-dev] [PATCH] st/nine: make use of common uploaders v4

2017-02-21 Thread Constantine Charlamov
On 21.02.2017 23:28, Axel Davy wrote: > This looks fine to me. > > Reviewed-by: Axel Davy > > I think the patch requires your Signed-off-by though. > > Axel > v2: fixed formatting, broken due to thunderbird configuration v3: per Axel comment: added a comment into NineDevice9_DrawPrimitiveUP v4:

[Mesa-dev] [Bug 99886] [radv] No actual multithreading in a Vulkan multithreading demo

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99886 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #2 from M

[Mesa-dev] [PATCH 3/7] util: Change util/set to use quadratic probing

2017-02-21 Thread Thomas Helland
The same rationale applies here as for the hash table. Power of two size should give better performance, and using the algorithm hash = sh + i/2 + i*i/2 should result in only distinct hash values when hitting collisions. Collision performane is also a lot better. V4: Feedback from Jason Ekstrand

[Mesa-dev] [PATCH 0/7] Another take on the hash table

2017-02-21 Thread Thomas Helland
I think this should pretty much be the patches in their final form. A recap of the history as of now: The minecraft tests that Eric Anholt did was based on a replay of an apitrace. So that is likely not all that representative of real life workloads. Name lookups was the one big thing that the mine

[Mesa-dev] [PATCH 1/7] util/tests: Expand collision test for hash table

2017-02-21 Thread Thomas Helland
Add a test to exercise a worst case collision scenario that may cause us to not be able to find an empty slot in the table even though it is not full. This hits the bug in my last revision of the series converting the hash table to quadratic probing. V2: Feedback from Emil Velikov -Don't inclu

[Mesa-dev] [PATCH 6/7] util: Use a starting load factor of 7/8 entries

2017-02-21 Thread Thomas Helland
--- src/util/hash_table.c | 2 +- src/util/set.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index e1255a2484..8121c8e67a 100644 --- a/src/util/hash_table.c +++ b/src/util/hash_table.c @@ -85,7 +85,7 @@ _mesa_hash_tabl

[Mesa-dev] [PATCH 2/7] util: Change hash_table to use quadratic probing

2017-02-21 Thread Thomas Helland
This will allow us to remove the large static table and use a power of two hash table size that we can compute on the fly. We can use bitmasking instead of modulo to fit our hash in the table, and it's less code. By using the algorithm hash = sh + i/2 + i*i/2 we are guaranteed that all retries fro

[Mesa-dev] [PATCH 4/7] util: Use set_foreach instead of rolling our own

2017-02-21 Thread Thomas Helland
This follows the same pattern as in the hash_table. Reviewed-by: Jason Ekstrand --- src/util/set.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/util/set.c b/src/util/set.c index 99c04369c5..110f182244 100644 --- a/src/util/set.c +++ b/src/util/set.c @@ -196,12

[Mesa-dev] [PATCH 5/7] util: Increase start size of hash table and set to 8

2017-02-21 Thread Thomas Helland
--- src/util/hash_table.c | 2 +- src/util/set.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index a93326ec27..e1255a2484 100644 --- a/src/util/hash_table.c +++ b/src/util/hash_table.c @@ -83,7 +83,7 @@ _mesa_hash_tabl

[Mesa-dev] [PATCH 7/7] util: Change the pointer hashing function

2017-02-21 Thread Thomas Helland
Use our knowledge that pointers are at least 4 byte aligned to remove the useless digits. Then shift by 6, 10, and 14 bits and add this to the original pointer, effectively folding in the entropy of the higher bits of the pointer into a 4-bit section. Stopping at 14 means we can add the entropy fro

[Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

2017-02-21 Thread Marek Olšák
From: Marek Olšák This fixes: vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && "Pass ID not registered!"' failed. v2: use list_head, switch the call order in destroy Cc: 13.0 17.0 --- src/gallium/

[Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-21 Thread Thomas Hellstrom
A couple of fixes / improvements for things I've encountered while looking through and testing the video code in preparation for a virtual hardware video driver. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH 4/8] gallium/vl Fix brightness matrix description

2017-02-21 Thread Thomas Hellstrom
The brightness matrix doesn't actually match the procamp matrix and what's calculated in vl_csc_get_matrix. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/vl/vl_csc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/aux

[Mesa-dev] [PATCH 3/8] gallium/vl: Don't map vertex buffers on creation

2017-02-21 Thread Thomas Hellstrom
It will cause multiple simultaneous maps of the same vertex buffer and flushed-while-mapped warnings. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_vertex_buffers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_vertex_bu

[Mesa-dev] [PATCH 5/8] gallium/vl: Simplify usage of full range matrices

2017-02-21 Thread Thomas Hellstrom
When looking at the full range matrices, it becomes obvious that the difference between the standard matrices and the full range matrices is that the full range matrices are multiplied by 1.164. Together with offsetting the y value with -16/255, this will scale and offset RGB with the desired quant

[Mesa-dev] [PATCH 7/8] st/vdpau: Fix multithreading

2017-02-21 Thread Thomas Hellstrom
The vdpau state tracker allows multiple threads access to the same gallium context simultaneously. We can fix this either by locking the same mutex each time the context is used or by using a different gallium context for each mutex domain. Here we do the latter, although I'm not sure that's really

[Mesa-dev] [PATCH 6/8] gallium/vl: Parameter substitution in the csc matrix computation

2017-02-21 Thread Thomas Hellstrom
Makes the code significantly more readable. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/vl/vl_csc.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_csc.c b/src/gallium/auxili

[Mesa-dev] [PATCH 3/4] gallium/hud: prevent an infinite loop

2017-02-21 Thread Marek Olšák
From: Marek Olšák v2: use UINT64_MAX / 11 --- src/gallium/auxiliary/hud/hud_context.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index aaa52d5..c44f8c0 100644 --- a/src/gallium/auxil

[Mesa-dev] [PATCH 2/8] gallium/vl: Add sampler views to video filter fragment shaders

2017-02-21 Thread Thomas Hellstrom
Needed for at least the svga driver. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 5 + src/gallium/auxiliary/vl/vl_matrix_filter.c | 5 + src/gallium/auxiliary/vl/vl_median_filter.c | 5 + 3 files changed, 15 insertions

[Mesa-dev] [PATCH 1/8] gallium/vl: declare sampler views in compositor shaders

2017-02-21 Thread Thomas Hellstrom
The svga driver relies on the existence of these sampler views. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_compositor.c | 37 +++- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_

[Mesa-dev] [PATCH 8/8] gallium/vl: Simplify the matrix filter fragment shader

2017-02-21 Thread Thomas Hellstrom
It looks like it was partly copied from the median filter fragment shader and unnecessesarily saved a lot of temporary values. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_matrix_filter.c | 56 + 1 file changed, 16 insertion

[Mesa-dev] [AppVeyor] mesa master #3522 failed

2017-02-21 Thread AppVeyor
Build mesa 3522 failed Commit 0441e6bc8b by Timothy Arceri on 2/21/2017 5:34 AM: util/disk_cache: create timestamp and gpu_id dirs when MESA_GLSL_CACHE_DIR is used\n\nThe make check test is also updated to make sure these dirs are created.\n\nReviewed-by: Nicol

Re: [Mesa-dev] [PATCH v4 0/6] Add support for ARB_transform_feedback_overflow_query.

2017-02-21 Thread Kenneth Graunke
On Friday, January 20, 2017 9:53:21 AM PST Rafael Antognolli wrote: > This patch series implements the ARB_transform_feedback_overflow_query > extension for i965. > > Changes for v4: > - Reuse of MI_MATH calcs from hsw_queryobj.c in brw_conditional_render.c > - Renamed a couple functions a

[Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Brian Paul
Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/util/disk_cache.h b/src/util/disk_cache.h index 8b6fc0d..7f4da80 100644 ---

Re: [Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Brian Paul
On 02/21/2017 03:57 PM, Brian Paul wrote: Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/util/disk_cache.h b/src/util/d

[Mesa-dev] [Bug 99886] [radv] No actual multithreading in a Vulkan multithreading demo

2017-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99886 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Status|NEW |RESOLVED Re

Re: [Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

2017-02-21 Thread Eric Engestrom
On Monday, 2017-02-20 19:49:59 +, Emil Velikov wrote: > On 19 February 2017 at 23:23, Eric Engestrom wrote: > > Starting with the next commit, badly sorting this list will break the > > eglGetProcAddress(). > > > > Signed-off-by: Eric Engestrom > > --- > > src/egl/Makefile.am | 3 ++

Re: [Mesa-dev] [PATCH 1/3] isl: Return surface creation success from aux helpers

2017-02-21 Thread Chad Versace
On Mon 20 Feb 2017, Jason Ekstrand wrote: > The isl_surf_init call that each of these helpers make can, in theory, > fail. We should propagate that up to the caller rather than just > silently ignoring it. > > Reviewed-by: Topi Pohjolainen > --- > src/intel/isl/isl.c | 72 > ++

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-21 Thread Chad Versace
On Mon 20 Feb 2017, Jason Ekstrand wrote: > On Mon, Feb 20, 2017 at 10:33 AM, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > > >> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > >> index 1a47da5..6979063 100644 > >> --- a/src/intel/isl/isl.c > >> +++ b/src/intel/isl/isl.c >

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-21 Thread Jason Ekstrand
On Tue, Feb 21, 2017 at 3:44 PM, Chad Versace wrote: > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > On Mon, Feb 20, 2017 at 10:33 AM, Lionel Landwerlin < > > lionel.g.landwer...@intel.com> wrote: > > > > >> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > > >> index 1a47da5..6979063 1006

Re: [Mesa-dev] [PATCH 1/2] [swr] Add fetch shader cache

2017-02-21 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Feb 17, 2017, at 2:30 PM, George Kyriazis > wrote: > > For now, the cache key is all of FETCH_COMPILE_STATE. > > Use new/delete for swr_vertex_element_state, since we have to call the > constructors/destructors of the struct elements. > --- > src/gallium/drive

Re: [Mesa-dev] [PATCH 2/2] [swr] fix index buffers with non-zero indices

2017-02-21 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Feb 17, 2017, at 2:30 PM, George Kyriazis > wrote: > > Fix issue with index buffers that do not contain a 0 index. 0 index > can be a non-valid index if the (copied) vertex buffers are a subset of the > user's (which happens because we only copy the range betw

[Mesa-dev] [PATCH mesa v2 6/9] eglapi: move entrypoints list out to its own file

2017-02-21 Thread Eric Engestrom
This will allow us to make sure the list is always sorted in the next commit. Signed-off-by: Eric Engestrom --- v2: use .h extension for the new file, and track it in LIBEGL_C_FILES (Emil) --- src/egl/Makefile.sources | 1 + src/egl/main/eglapi.c| 78 +---

[Mesa-dev] [PATCH mesa 2/9] eglapi: add entrypoint for eglDestroySyncKHR

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 251855cc3b..e149c0f8d1 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1

[Mesa-dev] [PATCH mesa 3/9] eglapi: add entrypoint for eglClientWaitSyncKHR

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index e149c0f8d1..e44375a106 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@

[Mesa-dev] [PATCH mesa 1/9] eglapi: add entrypoint for eglDestroyImageKHR

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Note for Ilia: I'm not opposed to removing the first 3 patches and adding a macro for the special cases, but I'll wait until someone else wants it too. And if the request comes after this lands, these 3 patches are easy enough to revert (just ignore the last hunk

[Mesa-dev] [PATCH mesa v2 8/9] egl: make sure entrypoints list is always sorted

2017-02-21 Thread Eric Engestrom
Starting with the next commit, badly sorting this list will break the eglGetProcAddress(). Signed-off-by: Eric Engestrom --- v2: use sh instead of bash (Emil) --- src/egl/Makefile.am | 3 ++- src/egl/egl-entrypoint-check | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) create

[Mesa-dev] [PATCH mesa 5/9] eglapi: sort entrypoints list

2017-02-21 Thread Eric Engestrom
Let's make that comment true. If will also be necessary in a couple commits (using bsearch). Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 74 +-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/src/egl/main/eglapi.c b/s

[Mesa-dev] [PATCH mesa 7/9] egl: distribute all tests

2017-02-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am index bd8903f666..d36a786ab4 100644 --- a/src/egl/Makefile.am +++ b/src/egl/Makefile.am @@ -129,7 +129,7 @@ egl_HEADERS = \ TESTS =

[Mesa-dev] [PATCH mesa 4/9] eglapi: use macro to map entrypoints to functions

2017-02-21 Thread Eric Engestrom
As of the last 3 commits, there's a function for each entrypoint. Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 149 +- 1 file changed, 75 insertions(+), 74 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index

  1   2   >