Nice cleanup, patches 2->5 are : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
Just one question on patch 1. On 20/02/17 19:21, Jason Ekstrand wrote:
The first patch in this little series should fix actual bugs on little-core platforms because it makes BLORP properly clflush it's dynamic state in Vulkan. The GL driver is fine because it allocates it all out of the batch which gets implicitly flushed when it's submitted. The other patches just clean things up in the Vulkan driver a bit. Whether or not they're actually cleanups is a bit subjective, but I think I like it better. The last one certainly makes for less typing. Jason Ekstrand (5): intel/blorp: Explicitly flush all allocated state anv: Rename clflush_range and state_clflush anv: Remove the unused state_pool_emit macro anv: Pull all clflushing into a clflush_range helper anv: Take a device parameter in anv_state_flush src/intel/blorp/blorp_genX_exec.h | 17 +++++++++++- src/intel/vulkan/anv_batch_chain.c | 2 +- src/intel/vulkan/anv_cmd_buffer.c | 12 +++------ src/intel/vulkan/anv_device.c | 23 +++++----------- src/intel/vulkan/anv_image.c | 9 +++---- src/intel/vulkan/anv_private.h | 41 +++++++++++------------------ src/intel/vulkan/gen7_cmd_buffer.c | 6 ++--- src/intel/vulkan/gen8_cmd_buffer.c | 12 +++------ src/intel/vulkan/genX_blorp_exec.c | 8 ++++++ src/intel/vulkan/genX_cmd_buffer.c | 18 +++++-------- src/intel/vulkan/genX_pipeline.c | 3 +-- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 8 ++++++ 12 files changed, 75 insertions(+), 84 deletions(-)
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
