Re: [Mesa-dev] [PATCH 1/6] nir/lower_tex: generalize get_texture_size()

2016-12-07 Thread Iago Toral
On Mon, 2016-12-05 at 20:38 -0800, Kenneth Graunke wrote: > On Thursday, December 1, 2016 8:53:16 AM PST Iago Toral Quiroga > wrote: > > > > This was written specifically for RECT samplers. Make it more > > generic so > > we can call this from the gradient lowerings too. > > --- > >  src/compiler/

Re: [Mesa-dev] [PATCH 4/6] nir/lower_tex: add lowering for texture gradient on shadow samplers

2016-12-07 Thread Iago Toral
On Mon, 2016-12-05 at 20:39 -0800, Kenneth Graunke wrote: > On Thursday, December 1, 2016 8:53:19 AM PST Iago Toral Quiroga > wrote: > > > > This is ported from the Intel lowering pass that we use with GLSL > > IR. > > This takes care of lowering texture gradients on shadow samplers > > other > >

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-07 Thread Iago Toral
On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote: > On 10/11, Iago Toral Quiroga wrote: > > > > It's been some time since > ... anyone has reviewed your patches. Sorry. :( > > I'm going to review from your rebased i965-fp64-gen7-scalar-vec4-rc2 > branch. There have probably been some reorderi

Re: [Mesa-dev] [PATCH v2 02/25] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-07 Thread Nicolai Hähnle
On 07.12.2016 02:07, Marek Olšák wrote: On Tue, Dec 6, 2016 at 11:48 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle This is for geometry shader outputs. Without it, drivers have no way of knowing which stream each output is intended for, and have to conservatively write all outputs to all str

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-07 Thread Nicolai Hähnle
On 07.12.2016 04:47, Michel Dänzer wrote: On 07/12/16 05:06 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle The spec actually says that calling EmitStreamVertex is undefined when you exceed max_vertices. But we do need to avoid trampling over memory outside the GSVS ring. Why "but"? It still

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Nicolai Hähnle
On 07.12.2016 08:50, Michel Dänzer wrote: On 06/12/16 10:24 PM, Marek Olšák wrote: On Mon, Dec 5, 2016 at 10:05 AM, Michel Dänzer wrote: On 03/12/16 05:38 AM, Marek Olšák wrote: From: Marek Olšák This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and probably many other g

Re: [Mesa-dev] [PATCH] egl: wayland: bufferAge: only request a back buffer if there isn't one

2016-12-07 Thread Eric Engestrom
On Tuesday, 2016-12-06 12:13:32 +, Lionel Landwerlin wrote: > On 06/12/16 11:36, Eric Engestrom wrote: > > On Saturday, 2016-12-03 22:47:17 +, Lionel Landwerlin wrote: > > > Seeing gtk+ application lockup when they query the buffer age of a > > > surface. > > > > > > Since we update the b

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivin

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #4 from Vedran Miletić --- (In reply to Igor Gnatenko from comment #3) > (In reply to Michel Dänzer from comment #2) > > Can you bisect which commit broke it? > Unfortunately it's not my bugreport. In theory, I could build RPMs for >

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Alejandro Piñeiro
On 06/12/16 22:26, Anuj Phogat wrote: > On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro > wrote: >> The FIXME suggest that the check should be removed. >> > Only if we see any performance or feature benefits in doing that. > Last I checked I didn't see any performance benefits on Skylake. Ok,

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Alejandro Piñeiro
On 07/12/16 09:36, Alejandro Piñeiro wrote: > On 06/12/16 22:26, Anuj Phogat wrote: >> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro >> wrote: >>> The FIXME suggest that the check should be removed. >>> >> Only if we see any performance or feature benefits in doing that. >> Last I checked

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #5 from Igor Gnatenko --- (In reply to Vedran Miletić from comment #4) > (In reply to Igor Gnatenko from comment #3) > > (In reply to Michel Dänzer from comment #2) > > > Can you bisect which commit broke it? > > Unfortunately it's no

Re: [Mesa-dev] [PATCH] egl: wayland: bufferAge: only request a back buffer if there isn't one

2016-12-07 Thread Lionel Landwerlin
On 07/12/16 10:55, Eric Engestrom wrote: On Tuesday, 2016-12-06 12:13:32 +, Lionel Landwerlin wrote: On 06/12/16 11:36, Eric Engestrom wrote: On Saturday, 2016-12-03 22:47:17 +, Lionel Landwerlin wrote: Seeing gtk+ application lockup when they query the buffer age of a surface. Since

[Mesa-dev] [PATCH 1/2] egl: wayland: set buffer age value to 0 when image is destroyed

2016-12-07 Thread Lionel Landwerlin
We usually set that value up when creating the buffer (NULL to non-NULL transition). It doesn't hurt to set that value to 0 up front when we destroy the buffer (non-NULL to NULL transition). Signed-off-by: Lionel Landwerlin --- src/egl/drivers/dri2/platform_wayland.c | 2 ++ 1 file changed, 2 in

[Mesa-dev] [PATCH 2/2] egl: wayland: bufferAge: only request a back buffer if there isn't one

2016-12-07 Thread Lionel Landwerlin
Seeing gtk+ application lockup when they query the buffer age of a surface. Since we update the buffer age field only when creating buffers & swaping them on the client side, there shouldn't be any need for requesting a new back buffer if there is already one available. This change depends on a p

[Mesa-dev] [PATCH] automake: make the build less chatty

2016-12-07 Thread Emil Velikov
From: Emil Velikov Having the "Entering|Leaving directory X" messages it not required nor useful in vast majority of the cases. One can always have them printed by `make -w' or by overriding the AM_MAKEFLAGS variable. Signed-off-by: Emil Velikov --- Makefile.am | 1 + 1 file changed, 1 insert

[Mesa-dev] [PATCH 2/5] configure: remove HAVE_EGL_DRIVER_DRI[23]

2016-12-07 Thread Emil Velikov
From: Emil Velikov We have them for local purposes in configure, where we can use their direct dependency. With the only remaining instance in the makefile(s) being always true, as it can be seen in the configure snippet. Signed-off-by: Emil Velikov --- configure.ac| 14 +++---

[Mesa-dev] [PATCH 5/5] configure: error out when building static XOR shared

2016-12-07 Thread Emil Velikov
From: Emil Velikov Current code warns out in such cases and falls-back to either static or shared. That can be easily missed amongst the volume produced by our configure script. Replace the warning with an error such that one gets direct feedback when they're doing something wrong. Signed-off-b

[Mesa-dev] [PATCH 3/5] configure: factor out commom egl/gbm checks

2016-12-07 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- configure.ac | 47 ++- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/configure.ac b/configure.ac index bea6975..162c31a 100644 --- a/configure.ac +++ b/configure.ac @@ -1966,26 +1966

[Mesa-dev] [PATCH 1/5] configure: forbid static EGL/GBM

2016-12-07 Thread Emil Velikov
From: Emil Velikov Both libraries implicitly require shared GLAPI which in itself mandates shared libraries. Stop pretending that one can use it and error out at configure stage. Signed-off-by: Emil Velikov --- configure.ac | 36 1 file changed, 20 inserti

[Mesa-dev] [PATCH 4/5] configure: explicitly require shared glapi for enable-dri

2016-12-07 Thread Emil Velikov
From: Emil Velikov We've been using and depending on it for at least a couple of years. Make it obvious and error out, should one opt for it. Signed-off-by: Emil Velikov --- configure.ac | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 16

Re: [Mesa-dev] [PATCH] automake: make the build less chatty

2016-12-07 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/08/2016 12:22 AM, Emil Velikov wrote: > From: Emil Velikov > > Having the "Entering|Leaving directory X" messages it not required nor > useful in vast majority of the cases. > > One can always have them printed by `make -w' or by overriding the > AM_MAKEFL

Re: [Mesa-dev] [PATCH 1/2] configure: enable glx-tls by default

2016-12-07 Thread Eero Tamminen
Hi, There are quite a few bugs in FDO bugzilla which mention glx-tls, you could list few of them in the commit message, e.g. this one: https://bugs.freedesktop.org/show_bug.cgi?id=72902 - Eero On 06.12.2016 20:51, Emil Velikov wrote: On 6 December 2016 at 14:36, Andreas Boll

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 David Rosenstrauch changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-07 Thread Ilia Mirkin
On Thu, Dec 1, 2016 at 10:56 AM, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/compiler/glsl/ast.h | 5 > src/compiler/glsl/ast_to_hir.cpp | 5 > src/compiler/glsl/ast_type.cpp | 16 +++- > src/compiler/glsl/glsl_pa

Re: [Mesa-dev] [PATCH] gallivm: use getHostCPUFeatures on x86/llvm-4.0+.

2016-12-07 Thread Roland Scheidegger
The bug in llvm has been fixed, can you confirm lp_test_format passes again? Roland Am 06.12.2016 um 19:00 schrieb Roland Scheidegger: > Ok, here is the bug: > https://llvm.org/bugs/show_bug.cgi?id=31296 > > Roland > > Am 06.12.2016 um 18:47 schrieb Roland Scheidegger: >> Actually I've verified

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #14 from Emil Velikov --- (In reply to David Rosenstrauch from comment #11) > Can you please clarify? If this is resolved, then what new package release > provides the fixed behavior? I'm still seeing this issue today (also on > Arc

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-07 Thread Lionel Landwerlin
On 07/12/16 14:55, Ilia Mirkin wrote: On Thu, Dec 1, 2016 at 10:56 AM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/compiler/glsl/ast.h | 5 src/compiler/glsl/ast_to_hir.cpp | 5 src/compiler/glsl/ast_type.cpp | 16 +++

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-07 Thread Ilia Mirkin
On Wed, Dec 7, 2016 at 10:25 AM, Lionel Landwerlin wrote: > On 07/12/16 14:55, Ilia Mirkin wrote: >> >> On Thu, Dec 1, 2016 at 10:56 AM, Lionel Landwerlin >> wrote: >>> >>> Signed-off-by: Lionel Landwerlin >>> --- >>> src/compiler/glsl/ast.h | 5 >>> src/compiler/glsl/a

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #12 from Emil Velikov --- (In reply to Vinson Lee from comment #10) > Ubuntu 12.04 llvm-2.9 Afaict nothing in Mesa supports such an old version of LLVM. So I'm not sure how much we should worry about here. Either way, some things th

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-07 Thread Emil Velikov
On 6 December 2016 at 22:34, Edward O'Callaghan wrote: > On 12/07/2016 12:36 AM, Emil Velikov wrote: >> On 6 December 2016 at 11:30, Edward O'Callaghan >> wrote: >>> As per the C spec, it is illegal to alias pointers to different >>> types. This results in undefined behaviour after optimization >

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #15 from David Rosenstrauch --- Created attachment 128369 --> https://bugs.freedesktop.org/attachment.cgi?id=128369&action=edit Xorg log of crash -- You are receiving this mail because: You are the assignee for the bug. You are th

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #6 from Emil Velikov --- Considering Marek's strong request on 12.0.6 can we bisect this please ? It should require up-to 5-6 steps (using -- src/gallium). -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #7 from Emil Velikov --- As usual -> please give 12.0.5 a try first. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-d

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #16 from Chris Wilson --- (In reply to David Rosenstrauch from comment #15) > Created attachment 128369 [details] > Xorg log of crash That was my fault, I didn't check opendir() for failure. -- You are receiving this mail because:

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #17 from David Rosenstrauch --- (In reply to Emil Velikov from comment #14) > David the original report/issue (segfaults when using DisplayLink (non-PCI > devices in general) should be fixed with commit 677cd97dc4a (libdrm 2.4.72). >

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Marek Olšák
Optimizing the CSO cache isn't exactly on the top of my list, so I can't really do that right now. I think that varying the LOD bias is starting to be common. It's used for smooth LOD transitions when loading textures during rendering. Games with lots of content typically do that. This particular

Re: [Mesa-dev] [PATCH] [rfc] glsl: allow invariant on fragment shader outputs.

2016-12-07 Thread Andres Gomez
Hei Dave, recently, khronos bug 16140 was opened to address my comments regarding the "#pragma STDGL invariant(all)" sentence in GLSL specs since 1.30. The action to be taken will be removing such sentence. In other words, the "invariant" keyword should be also legal for FS outputs. Therefore, D

Re: [Mesa-dev] [PATCH libdrm v2 5/5] xf86drm: implement an OpenBSD specific drmGetDevice2

2016-12-07 Thread Emil Velikov
On 6 December 2016 at 05:12, Jonathan Gray wrote: > On Mon, Dec 05, 2016 at 05:56:40PM +, Emil Velikov wrote: >> On 1 December 2016 at 04:18, Jonathan Gray wrote: >> > DRI devices on OpenBSD are not in their own directory. They reside in >> > /dev with a large number of statically generated

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #19 from David Rosenstrauch --- Well my stack trace is actually almost identical to one someone posted later in that Arch forum thread (see https://bbs.archlinux.org/viewtopic.php?pid=1672878#p1672878) which is how I found that thread

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #20 from David Rosenstrauch --- BTW, is there a separate bug report for that opendir issue that I can track to know when a fix gets released? -- You are receiving this mail because: You are the assignee for the bug. You are the QA C

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Roland Scheidegger
Am 07.12.2016 um 17:26 schrieb Marek Olšák: > Optimizing the CSO cache isn't exactly on the top of my list, so I > can't really do that right now. > > I think that varying the LOD bias is starting to be common. It's used > for smooth LOD transitions when loading textures during rendering. > Games

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #21 from Mark Janes --- David, thank you for your input on this bug. Even though the root cause of your crash was different, I would have come to the same initial conclusion as you based on the different behavior of mesa 12/13. I ag

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Nicolai Hähnle
On 07.12.2016 17:26, Marek Olšák wrote: Optimizing the CSO cache isn't exactly on the top of my list, so I can't really do that right now. I think that varying the LOD bias is starting to be common. It's used for smooth LOD transitions when loading textures during rendering. Games with lots of c

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-07 Thread Ilia Mirkin
On Wed, Dec 7, 2016 at 10:31 AM, Ilia Mirkin wrote: > On Wed, Dec 7, 2016 at 10:25 AM, Lionel Landwerlin > wrote: >> On 07/12/16 14:55, Ilia Mirkin wrote: >>> >>> On Thu, Dec 1, 2016 at 10:56 AM, Lionel Landwerlin >>> wrote: Signed-off-by: Lionel Landwerlin --- src/compile

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-07 Thread Ilia Mirkin
On Wed, Dec 7, 2016 at 12:04 PM, Ilia Mirkin wrote: > On Wed, Dec 7, 2016 at 10:31 AM, Ilia Mirkin wrote: >> On Wed, Dec 7, 2016 at 10:25 AM, Lionel Landwerlin >> wrote: >>> On 07/12/16 14:55, Ilia Mirkin wrote: On Thu, Dec 1, 2016 at 10:56 AM, Lionel Landwerlin wrote: >

[Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Marek Olšák
From: Marek Olšák --- run.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/run.c b/run.c index 08fd543..ded224a 100644 --- a/run.c +++ b/run.c @@ -656,28 +656,32 @@ main(int argc, char **argv) /* If there's only one GLSL shader, mark it separable so

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Ilia Mirkin
What's wrong with feeding it stack memory? On Wed, Dec 7, 2016 at 12:33 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > run.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/run.c b/run.c > index 08fd543..ded224a 100644 > --- a/run.c > +++ b/run.c > @@ -656,28

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Marek Olšák
On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: > What's wrong with feeding it stack memory? I don't really have an answer to that. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-de

Re: [Mesa-dev] [PATCH v2 7/7] i965: Increase max texture to 16k for gen7+

2016-12-07 Thread Jason Ekstrand
This has some interesting implications... >From the Sky Lake PRM, Vol 7, section "Vertex XY Clamping and Quantization", > In addition, in order to be correctly rendered, objects must have a screenspace > bounding box not exceeding 8K in the X or Y direction. This additional restriction > must als

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #8 from Jan Vesely --- 12.0.4 is working fine* on r600 (turks). Looks like SI compute problem. *fine: within limits of what I know was broken in LLVM 3.8 -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Anuj Phogat
On Wed, Dec 7, 2016 at 3:38 AM, Alejandro Piñeiro wrote: > > > On 07/12/16 09:36, Alejandro Piñeiro wrote: >> On 06/12/16 22:26, Anuj Phogat wrote: >>> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro >>> wrote: The FIXME suggest that the check should be removed. >>> Only if we see a

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Ian Romanick
On 12/07/2016 09:44 AM, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: >> What's wrong with feeding it stack memory? > > I don't really have an answer to that. Does valgrind provide any clues? The usual problems are running out of stack (is that still a thing?) or buffe

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Jan Vesely
On Wed, 2016-12-07 at 18:44 +0100, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: > > What's wrong with feeding it stack memory? > > I don't really have an answer to that. what happens when you malloc shader[i].length + 1 instead of +1000? looks like you're just hiding o

[Mesa-dev] [PATCH 1/7] mesa: Add types for ARB_transform_feedback_oveflow_query.

2016-12-07 Thread Rafael Antognolli
Add some basic types and storage for the queries of this extension. Signed-off-by: Rafael Antognolli --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 5 + 2 files changed, 6 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_

[Mesa-dev] [PATCH 0/7] Add support for ARB_transform_feedback_overflow_query.

2016-12-07 Thread Rafael Antognolli
This patch series implements the ARB_transform_feedback_overflow_query extension for i965. It already addresses the issues raised by Ian Romanick on the RFC. The series is available on github here: https://github.com/rantogno/mesa/tree/review/overflow_query-v01 There are also piglit tests availa

[Mesa-dev] [PATCH 6/7] i965: Enable arb_transform_feedback_overflow_query.

2016-12-07 Thread Rafael Antognolli
This extension adds new query types which can be used to detect overflow of transform feedback buffers. The new query types are also accepted by conditional rendering commands. Signed-off-by: Rafael Antognolli --- docs/features.txt| 2 +- docs/relnotes/13.1.0.html

[Mesa-dev] [PATCH 3/7] i965: add plumbing for ARB_transform_feedback_overflow_query.

2016-12-07 Thread Rafael Antognolli
When querying for transform feedback overflow on one or all of the streams, store information about number of generated and written primitives. Then check whether generated == written. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_queryobj.c | 2 ++ src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 4/7] i965: Add support for xfb overflow on query buffer objects.

2016-12-07 Thread Rafael Antognolli
Enable getting the results of a transform feedback overflow query with a buffer object. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++ 1 file changed, 108 insertions(+) diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c b

[Mesa-dev] [PATCH 7/7] i965: Enable predicate support on gen >= 8.

2016-12-07 Thread Rafael Antognolli
Predication needs cmd parser only on gen7. For newer platforms, it should be available without it. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/driver

[Mesa-dev] [PATCH 2/7] mesa: Track transform feedback overflow query objects.

2016-12-07 Thread Rafael Antognolli
Also update checks on conditional rendering. Signed-off-by: Rafael Antognolli --- src/mesa/main/condrender.c | 4 +++- src/mesa/main/queryobj.c| 21 + src/mesa/state_tracker/st_cb_queryobj.c | 6 ++ 3 files changed, 30 insertions(+), 1 delet

[Mesa-dev] [PATCH 5/7] i965: Add support for xfb overflow query on conditional render.

2016-12-07 Thread Rafael Antognolli
Enable the use of a transform feedback overflow query with glBeginConditionalRender. The render commands will only execute if the query is true (i.e. if there was an overflow). Use ARB_conditional_render_inverted to change this behavior. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] automake: make the build less chatty

2016-12-07 Thread Eric Anholt
Emil Velikov writes: > From: Emil Velikov > > Having the "Entering|Leaving directory X" messages it not required nor > useful in vast majority of the cases. > > One can always have them printed by `make -w' or by overriding the > AM_MAKEFLAGS variable. > > Signed-off-by: Emil Velikov I tried t

Re: [Mesa-dev] [PATCH 05/10] radeonsi: check for sampler state CSO corruption

2016-12-07 Thread Marek Olšák
On Fri, Dec 2, 2016 at 9:52 PM, Gustaw Smolarczyk wrote: > 2016-12-02 21:39 GMT+01:00 Marek Olšák : >> >> From: Marek Olšák >> >> It really happens. >> --- >> src/gallium/drivers/radeonsi/si_descriptors.c | 1 + >> src/gallium/drivers/radeonsi/si_pipe.h| 3 +++ >> src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Marek Olšák
On Wed, Dec 7, 2016 at 6:00 PM, Roland Scheidegger wrote: > Am 07.12.2016 um 17:26 schrieb Marek Olšák: >> Optimizing the CSO cache isn't exactly on the top of my list, so I >> can't really do that right now. >> >> I think that varying the LOD bias is starting to be common. It's used >> for smooth

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Ilia Mirkin
On Wed, Dec 7, 2016 at 3:46 PM, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:00 PM, Roland Scheidegger wrote: >> Am 07.12.2016 um 17:26 schrieb Marek Olšák: >>> Optimizing the CSO cache isn't exactly on the top of my list, so I >>> can't really do that right now. >>> >>> I think that varying the

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Marek Olšák
On Wed, Dec 7, 2016 at 10:06 PM, Roland Scheidegger wrote: > Am 07.12.2016 um 21:46 schrieb Marek Olšák: >> On Wed, Dec 7, 2016 at 6:00 PM, Roland Scheidegger >> wrote: >>> Am 07.12.2016 um 17:26 schrieb Marek Olšák: Optimizing the CSO cache isn't exactly on the top of my list, so I ca

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 6, 2016 at 9:06 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to avoid trampling over memory > outside the GSVS ring. > > Cc: mesa-

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-07 Thread Roland Scheidegger
Am 07.12.2016 um 21:46 schrieb Marek Olšák: > On Wed, Dec 7, 2016 at 6:00 PM, Roland Scheidegger wrote: >> Am 07.12.2016 um 17:26 schrieb Marek Olšák: >>> Optimizing the CSO cache isn't exactly on the top of my list, so I >>> can't really do that right now. >>> >>> I think that varying the LOD bia

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #13 from Vinson Lee --- I also get this error when trying to use softpipe. libGL: dlopen lib/gallium/swrast_dri.so failed (lib/gallium/swrast_dri.so: undefined symbol: draw_gs_llvm_destroy_variant) -- You are receiving this mail be

[Mesa-dev] [PATCH] radeonsi: disable the constant engine (CE) on Carrizo and Stoney

2016-12-07 Thread Marek Olšák
From: Marek Olšák It must be disabled until the kernel bug is fixed, and then we'll enable CE based on the DRM version. Cc: 12.0 13.0 --- src/gallium/drivers/radeonsi/si_pipe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src

Re: [Mesa-dev] [PATCH v2 13/25] radeonsi: load the streamout buf descriptors closer to their use

2016-12-07 Thread Marek Olšák
Other than the comment on patch 2, patches 1-13 are: Reviewed-by: Marek Olšák Marek On Tue, Dec 6, 2016 at 11:48 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > LLVM can still decide to hoist the loads since they're marked invariant. > --- > src/gallium/drivers/radeonsi/si_shader.c | 25

[Mesa-dev] [PATCH 00/84] Introduce gallium nine internal multithreading

2016-12-07 Thread Axel Davy
This patch adds internal multithreading to gallium nine. The goal is to offload almost all gallium nine calls (and some other work) to a worker thread. The patch serie does first a lot of refactoring, and introduces a new nine_context structure containing all the required internal states to do th

[Mesa-dev] [PATCH 05/84] st/nine: Move texture setting to nine_context_*

2016-12-07 Thread Axel Davy
And move samplers_shadow to nine_context. Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 36 src/gallium

[Mesa-dev] [PATCH 18/84] st/nine: Put ff data in a separate structure

2016-12-07 Thread Axel Davy
And make nine_state_access_transform take this new structure as input. Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 6 ++-- src/

[Mesa-dev] [PATCH 09/84] st/nine: Move stream freq data to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 19 src/gallium/state_trackers/nine/nine_state.c | 32

[Mesa-dev] [PATCH 13/84] st/nine: Back all shader constants to nine_context

2016-12-07 Thread Axel Davy
For device vs shader float constants and may_swvp, the same tips than for the other constant types is used. Also memset the constants properly. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 138 ++ src/gallium/state_trackers/nine/nine_state.c | 349 ++

[Mesa-dev] [PATCH 06/84] st/nine: Back textures into nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 1 + src/gallium/state_trackers/nine/device9.c | 2 ++ src/gallium/state_tra

[Mesa-dev] [PATCH 04/84] st/nine: Track changed.texture only for stateblocks

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 4 +--- src/gallium/state_trackers/nine/device9.c | 3 ++- src/gallium/state_t

[Mesa-dev] [PATCH 02/84] st/nine: Move core of device clear to nine_state

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 130 + src/gallium/state_trackers/nine/nine_state.c | 166 +++

[Mesa-dev] [PATCH 07/84] st/nine: Move stream_usage_mask to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 6 +++--- src/gallium/state_trackers/nine/nine_state.h | 3 ++- 2 files changed, 5 in

[Mesa-dev] [PATCH 19/84] st/nine: Refactor SetLight

2016-12-07 Thread Axel Davy
Call a helper function to set the light. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 24 src/gallium/state_trackers/nine/nine_state.c | 28 src/gallium/state_trackers/nine/nine_state.h | 3 +++ 3 files changed

[Mesa-dev] [PATCH 29/84] st/nine: Access pipe_context via NineDevice9_GetPipe

2016-12-07 Thread Axel Davy
Except for nine_ff and nine_state. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 13 +--- src/gallium/state_trackers/nine/basetexture9.h | 1 - src/gallium/state_trackers/nine/buffer9.c | 16 + src/gallium/state_trackers/nine/buffer9.h |

[Mesa-dev] [PATCH 34/84] st/nine: Move Managed Pool handling out of nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 57 src/gallium/state_trackers/nine/nine_state.c | 32 --

[Mesa-dev] [PATCH 28/84] st/nine: Remove NineDevice9_GetCSO

2016-12-07 Thread Axel Davy
Was useless. Remove useless usage in swapchain9. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 6 -- src/gallium/state_trackers/nine/device9.h| 3 --- src/gallium/state_trackers/nine/swapchain9.c | 1 - src/gallium/state_trackers/nine/swapchain9.h | 1 - 4 f

[Mesa-dev] [PATCH 15/84] st/nine: Back RT to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 16 +++- src/gallium/state_trackers/nine/nine_state.c | 54 ++

[Mesa-dev] [PATCH 24/84] st/nine: Back User Clip Planes to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 5 - src/gallium/state_trackers/nine/nine_state.c | 30 +++--

[Mesa-dev] [PATCH 20/84] st/nine: Refactor LightEnable

2016-12-07 Thread Axel Davy
Call a helper function. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 25 +--- src/gallium/state_trackers/nine/nine_state.c | 35 src/gallium/state_trackers/nine/nine_state.h | 4 3 files changed, 40 insertions(+),

[Mesa-dev] [PATCH 08/84] st/nine: Move vtxbuf to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 33 -- src/gallium/state_trackers/nine/nine_state.c | 66 ++

[Mesa-dev] [PATCH 25/84] st/nine: Track dirty state groups in nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 3 +- src/gallium/state_trackers/nine/device9.c | 2 +- src/gallium/state_

[Mesa-dev] [PATCH 22/84] st/nine: Back ds to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 7 +++--- src/gallium/state_trackers/nine/nine_state.c | 33 ++--

[Mesa-dev] [PATCH 12/84] st/nine: Back sampler states to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 18 +++--- src/gallium/state_trackers/nine/nine_state.c | 83 +++---

[Mesa-dev] [PATCH 17/84] st/nine: Back viewport to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 4 ++- src/gallium/state_trackers/nine/nine_ff.c| 2 +- src/gallium/state_track

[Mesa-dev] [PATCH 01/84] st/nine: Introduce nine_context

2016-12-07 Thread Axel Davy
nine_context is a new structure which goal will be to contain all internal states. It will be the states of the second thread in the to-be-introduced CSMT mode. This patch moves several internal states to nine_context, while the next patches add the other fields. Signed-off-by: Axel Davy --- sr

[Mesa-dev] [PATCH 30/84] st/nine: Rename cso in nine_context to cso_shader

2016-12-07 Thread Axel Davy
This patch it to avoid name conflict when device->cso is moved to nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c| 12 ++-- src/gallium/state_trackers/nine/nine_state.h| 2 +- src/gallium/state_trackers/nine/pixelshader9.c | 4 ++-- src/

[Mesa-dev] [PATCH 03/84] st/nine: Move draw calls to nine_state

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 209 +++-- src/gallium/state_trackers/nine/nine_ff.c | 84 +++--

[Mesa-dev] [PATCH 65/84] st/nine: Fix NineUnknown_Detach

2016-12-07 Thread Axel Davy
We don't bind the container in AddRef. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/iunknown.h b/src/gallium/state_trackers/nine/iunknown.h index d357aad..dd1dab9 100

[Mesa-dev] [PATCH 10/84] st/nine: Back vdecl to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 21 +-- src/gallium/state_trackers/nine/nine_ff.c | 10 ---

[Mesa-dev] [PATCH 21/84] st/nine: Back all ff states in nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 60 -- src/gallium/state_trackers/nine/nine_ff.c | 114 +-

  1   2   3   >