Re: [Mesa-dev] [v2 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-24 Thread Pohjolainen, Topi
On Thu, Nov 24, 2016 at 09:34:37AM +0200, Pohjolainen, Topi wrote: > On Wed, Nov 23, 2016 at 01:05:31PM -0800, Jason Ekstrand wrote: > >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@gmail.com> wrote: > > > > v2: Added intel_resolve_map_clear() into intel_mi

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 --- Comment #2 from Pekka Paalanen --- (In reply to Eero Tamminen from comment #0) > Test suite has options for using single, double or triple buffering and > toggling Vsync, but these didn't have any effect. Just curious, how do you actually ch

Re: [Mesa-dev] [v2 04/17] i965: Provide slice details to color resolver

2016-11-24 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 09:26:29AM -0800, Jason Ekstrand wrote: >General comment: Does it make sense to squash this with the previous >patch? I'm fine either way. >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Signed-off-by: Top

[Mesa-dev] [PATCH] android: add support for EGL_EXT_buffer_age extension

2016-11-24 Thread Tapani Pälli
From: Kalyan Kondapally - initialize buffer age as 0 (Tapani) Signed-off-by: Kalyan Kondapally --- src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2/platform_android.c | 24 +++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/src/egl/driv

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 --- Comment #3 from Eero Tamminen --- Before checking other things, I'm going to try whether this happens also with latest kernel and on something else than SKL. (In reply to Daniel Stone from comment #1) > Which compositor is this? I wouldn't

Re: [Mesa-dev] [PATCH] android: add support for EGL_EXT_buffer_age extension

2016-11-24 Thread Tapani Pälli
Oops, commit message missed the dEQP testing results. I can add these when committing: On Android (running dEQP with *buffer_age*): 102 passing tests, 0 failing and 84 not supported ones On 11/24/2016 11:38 AM, Tapani Pälli wrote: From: Kalyan Kondapally - initialize buffer age as 0 (Tapani

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 --- Comment #4 from Pekka Paalanen --- > (In reply to Pekka Paalanen from comment #2) > > (In reply to Eero Tamminen from comment #0) > > > Test suite has options for using single, double or triple buffering and > > > toggling Vsync, but these di

Re: [Mesa-dev] [st/omx/dec/h264] Handing negative POC

2016-11-24 Thread Christian König
Hi, patch is Reviewed-by: Christian König . Regards, Christian. Am 24.11.2016 um 07:57 schrieb Namburu, Chandu-babu: Hi , I have been working on an issue where the for a particular stream playback is stuttering and there are lot of frame drops. That particular stream has negative POC valu

Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Trust the packet size in the header for SUBOPCODE_HEADER

2016-11-24 Thread Lionel Landwerlin
This series is : Reviewed-by: Lionel Landwerlin On 24/11/16 04:27, Jason Ekstrand wrote: We were reading from the "comment size" dword and incrementing by that amount. This never caused a problem because that field was always zero. However, experimenting with actual aub file comments indicate

[Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral Quiroga
Fixes multiple Vulkan CTS tests that combine anisotropy and VK_FILTER_NEAREST in dEQP-VK.texture.filtering_anisotropy.* --- src/intel/vulkan/genX_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 4122395.

[Mesa-dev] [PATCH 1/5] anv/pipeline: do not discard 'const' modifier

2016-11-24 Thread Juan A. Suarez Romero
Fixes warning. --- src/intel/vulkan/genX_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index cb164ad..ada7985 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline.c @@

[Mesa-dev] [PATCH 2/5] anv/pipeline: define is_dual_src_blend_factor() for gen <= 8

2016-11-24 Thread Juan A. Suarez Romero
Fixes defined but not used warning. --- src/intel/vulkan/genX_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index ada7985..991fbf6 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeli

[Mesa-dev] [PATCH 0/5] Several fixes for different warnings

2016-11-24 Thread Juan A. Suarez Romero
I'm sending several unrelated patches that fix different warnings when building Mesa. Juan A. Suarez Romero (5): anv/pipeline: do not discard 'const' modifier anv/pipeline: define is_dual_src_blend_factor() for gen <= 8 st/va: remove unsed variable ttn: handle GLSL_SAMPLER_DIM_SUBPASS_MS c

[Mesa-dev] [PATCH 4/5] ttn: handle GLSL_SAMPLER_DIM_SUBPASS_MS case

2016-11-24 Thread Juan A. Suarez Romero
Fixes a warning. --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 3f05acd..e90684f 100644 --- a/src/gallium/auxiliary/nir/tgsi_to_nir.c +++ b/src/gallium/auxiliar

[Mesa-dev] [PATCH 5/5] st/va: declare vlVaBuffer before vlVaContext

2016-11-24 Thread Juan A. Suarez Romero
And declare coded_buf in vlVaContext as "vlVaBuffer *" instead of "struct vlVaBuffer *". This fixes several warnings later about assignment from incompatible pointer type. --- src/gallium/state_trackers/va/va_private.h | 30 +++--- 1 file changed, 15 insertions(+), 15 dele

[Mesa-dev] [PATCH 3/5] st/va: remove unsed variable

2016-11-24 Thread Juan A. Suarez Romero
pbuff is defined but not used. --- src/gallium/state_trackers/va/surface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c index f8513d9..357e85e 100644 --- a/src/gallium/state_trackers/va/surface.c +++ b/src/gal

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Lionel Landwerlin
Hi Iago, Looking at the history, before ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if maxAnisotropy > 1. It seems your patch makes sense in using MAPFILTER_ANISOTROPIC in the NEAREST case, but I wonder whether we should also check for maxAn

Re: [Mesa-dev] [PATCH 1/5] anv/pipeline: do not discard 'const' modifier

2016-11-24 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 24/11/16 12:36, Juan A. Suarez Romero wrote: Fixes warning. --- src/intel/vulkan/genX_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index cb164ad..ada7985 10

Re: [Mesa-dev] [PATCH 2/5] anv/pipeline: define is_dual_src_blend_factor() for gen <= 8

2016-11-24 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 24/11/16 12:36, Juan A. Suarez Romero wrote: Fixes defined but not used warning. --- src/intel/vulkan/genX_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index ada7985..991

Re: [Mesa-dev] [PATCH] radv: Don't generate radv_timestamp.h

2016-11-24 Thread Emil Velikov
On 23 November 2016 at 19:07, Bas Nieuwenhuizen wrote: > Not needed anymore. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/Makefile.am | 6 +- > src/amd/vulkan/Makefile.sources | 3 +-- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/src/amd/vulkan/Mak

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral
Hi Lionel, On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > Hi Iago, > > Looking at the history, before > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa  > we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if > maxAnisotropy  >  > 1. It seems your patch makes sense in using MAPFILTER_

[Mesa-dev] [Bug 97145] include/GL/*.h not installed when GLX is disabled (eg for OSMesa)

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97145 --- Comment #1 from Emil Velikov --- Most/all of that should be resolved with commit a89faa2022fd995af2019c886b152b49a01f9392. Please give it a try and let me know the exact configure line (and the summary?) if things are still odd. -- You are

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 --- Comment #12 from Emil Velikov --- Hi Frederic, please send your patches to the ML for review[1]. [1] http://mesa3d.org/devinfo.html#submitting -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 --- Comment #5 from Emil Velikov --- Hi Frederic, sorry for dropping the ball on this one. Can you please attach (as plain text) the instructions and demo program that you've mentioned - the gist seems to have been removed. If you already have

[Mesa-dev] [v3 08/17] i965: Add plumbing for fast clear layer/level details

2016-11-24 Thread Topi Pohjolainen
Until now fast clear has been supported only for non-layered and non-mipmapped buffers. However, from gen8 onwards there is hardware support also for layered/mipmapped. Once this is enabled, fast clear operations target specific layer/level and call for the state to be tracked in the same granulari

[Mesa-dev] [v3 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-24 Thread Topi Pohjolainen
Note that RESOLVED is not tracked in the map explicitly. Absence of item implicitly means RESOLVED state. v2: Added intel_resolve_map_clear() into intel_miptree_release() v3 (Jason): Properly handle the assumption of resolve map not containing any items with state RESOLVED. Removed

[Mesa-dev] [v3 14/17] i965: Use ISL for CCS layouts

2016-11-24 Thread Topi Pohjolainen
One can now also delete intel_get_non_msrt_mcs_alignment(). v2 (Jason): Do not leak aux buf but allocate only after getting ISL surfaces. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 138 +++--- src/mesa/drivers/dri/i965/int

[Mesa-dev] [v3 04/17] i965: Provide slice details to color resolver

2016-11-24 Thread Topi Pohjolainen
v2: Make intel_miptree_resolve_color() take start layer and layer count. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 13 ++- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/brw_context.c | 14 +++-

Re: [Mesa-dev] [v2] i965: Fast color clear for mipmapped and arrayed

2016-11-24 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 11:15:59AM +0200, Topi Pohjolainen wrote: > This is a rebase on top recent changes by Jason and Lionel. While > things have changed quite a bit in some of the patches they have > mostly become clearer. > 2.5.5 I handpicked and sent v3 for patches that went thru significant

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-24 Thread Emil Velikov
On 24 November 2016 at 06:22, Boyan Ding wrote: > 2016-11-24 13:29 GMT+08:00 Derek Foreman : >> On 23/11/16 07:18 PM, Boyan Ding wrote: >>> >>> 2016-11-24 7:01 GMT+08:00 Derek Foreman : This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e except for i915. Orig

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Iago Toral
On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > Hi Lionel, > > On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > > > > Hi Iago, > > > > Looking at the history, before > > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa  > > we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if >

[Mesa-dev] [PATCH v2 00/14] implement EGL_EXT_image_dma_buf_import_modifiers v2

2016-11-24 Thread Varad Gautam
This is the second revision to the EGL_EXT_image_dma_buf_import_modifiers [1] series at [2], addressing the comments received. This diverges from v1 due to some reordered/squashed changes, hence the resend. Major modifications include: * Both format and modifier queries are now handled in the driv

[Mesa-dev] [PATCH v2 01/14] egl: return error for unknown EGLImage attributes

2016-11-24 Thread Varad Gautam
From: Pekka Paalanen Commit 0135e5d6c83add5e539492a4899504e33f3f2434 "egl: Add support for more EGLImage extensions to EGL core." removed an error code for unknown EGLImage attributes without explaining why. EGL_KHR_image_base says: * If an attribute specified in is not one of the

[Mesa-dev] [PATCH v2 02/14] egl: introduce DMA_BUF_MAX_PLANES

2016-11-24 Thread Varad Gautam
From: Pekka Paalanen Rather than hardcoding 3, use a #define. Makes it easier to bump this later to 4. Signed-off-by: Pekka Paalanen Signed-off-by: Varad Gautam Reviewed-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 8 src/egl/main/eglimage.h | 8 +--- 2 files

[Mesa-dev] [PATCH v2 04/14] egl/main: add support for fourth plane tokens

2016-11-24 Thread Varad Gautam
From: Pekka Paalanen The EGL_EXT_dma_buf_import_modifiers extension adds support for a fourth plane, just like DRM KMS API does. Bump maximum dma_buf plane count to four. v2: prevent attribute tokens from being parsed if EXT_image_dma_buf_import_modifiers is not suported. (Emil Velikov) Si

[Mesa-dev] [PATCH v2 05/14] dri: support DRIimage creation from dmabufs with modifiers

2016-11-24 Thread Varad Gautam
From: Pekka Paalanen add createImageFromDmaBufs2 function which accepts per-plane dmabuf format modifiers. Signed-off-by: Pekka Paalanen Signed-off-by: Varad Gautam --- include/GL/internal/dri_interface.h | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 03/14] egl: update eglext.h

2016-11-24 Thread Varad Gautam
From: Varad Gautam update eglext.h to revision 33288 from Khronos Signed-off-by: Varad Gautam Reviewed-by: Eric Engestrom --- include/EGL/eglext.h | 60 ++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/include/EGL/eglext.h b/i

[Mesa-dev] [PATCH v2 08/14] dri: add queryDmaBufFormats and queryDmaBufModifiers to DRIimage

2016-11-24 Thread Varad Gautam
From: Varad Gautam these allow querying the driver for supported dmabuf formats and modifiers. Signed-off-by: Varad Gautam --- include/GL/internal/dri_interface.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/i

[Mesa-dev] [PATCH v2 09/14] gallium: introduce dmabuf format and modifier querying

2016-11-24 Thread Varad Gautam
From: Varad Gautam this allows drivers to be queried for supported formats and format modifiers. drivers that implement these queries must expose these under PIPE_CAP_QUERY_DMABUF_ATTRIBS. Signed-off-by: Varad Gautam --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/dri

[Mesa-dev] [PATCH v2 12/14] st/dri: support format modifier queries

2016-11-24 Thread Varad Gautam
From: Varad Gautam ask the driver for supported modifiers for a given format. bump __DRI_IMAGE implementation version to 15. Signed-off-by: Varad Gautam --- src/gallium/state_trackers/dri/dri2.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/gall

[Mesa-dev] [PATCH v3 07/14] egl_dri2: add support for using modifier attributes in eglCreateImageKHR

2016-11-24 Thread Varad Gautam
From: Varad Gautam allow creating EGLImages with dmabuf format modifiers when target is EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers. v2: - clear modifier assembling and error label name (Eric Engestrom) v3: - remove goto jumps within switch-case (Emil Velikov) - treat zer

[Mesa-dev] [PATCH v2 06/14] st/dri: implement DRIimage creation from dmabufs with modifiers

2016-11-24 Thread Varad Gautam
From: Varad Gautam support importing dmabufs into DRIimage taking format modifiers in account, as per DRIimage extension version 14. Signed-off-by: Varad Gautam --- src/gallium/include/state_tracker/drm_driver.h | 2 ++ src/gallium/state_trackers/dri/dri2.c | 45 +

[Mesa-dev] [PATCH v2 10/14] st/dri: support format queries

2016-11-24 Thread Varad Gautam
From: Varad Gautam ask the driver for supported dmabuf formats Signed-off-by: Varad Gautam --- src/gallium/state_trackers/dri/dri2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index a2b87a7.

[Mesa-dev] [PATCH v2 14/14] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

2016-11-24 Thread Varad Gautam
From: Varad Gautam Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 5 + src/egl/main/eglapi.c | 1 + 2 files changed, 6 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index d387e28..e155801 100644 --- a/src/egl/drive

[Mesa-dev] [PATCH v2 11/14] egl: implement eglQueryDmaBufFormatsEXT

2016-11-24 Thread Varad Gautam
From: Varad Gautam allow egl clients to query the dmabuf formats supported on this platform. Signed-off-by: Louis-Francis Ratté-Boulianne Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 17 + src/egl/main/eglapi.c | 19 +++ src/egl/m

[Mesa-dev] [PATCH v2 13/14] egl: implement eglQueryDmaBufModifiersEXT

2016-11-24 Thread Varad Gautam
From: Varad Gautam query and return supported dmabuf format modifiers for EGL_EXT_image_dma_buf_import_modifiers. Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 47 + src/egl/main/eglapi.c | 21 ++ src/egl/mai

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-24 Thread Derek Foreman
On 24/11/16 08:53 AM, Emil Velikov wrote: On 24 November 2016 at 06:22, Boyan Ding wrote: 2016-11-24 13:29 GMT+08:00 Derek Foreman : On 23/11/16 07:18 PM, Boyan Ding wrote: 2016-11-24 7:01 GMT+08:00 Derek Foreman : This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e except fo

[Mesa-dev] [Bug 98842] mesa 13.0.1 build broken under debian8

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98842 --- Comment #1 from Emil Velikov --- Can you search through your system for the following files libdrm.so and libdrm.pc. For both, provide the exact location. And the contents in for the latter. Thanks -- You are receiving this mail because: Y

Re: [Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

2016-11-24 Thread Ben Widawsky
On 16-11-23 12:04:02, Jason Ekstrand wrote: On Wed, Nov 23, 2016 at 10:16 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote:

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 --- Comment #5 from Eero Tamminen --- Happens both on BDW & SKL, both with Ubuntu 16.04 kernel & latest kernel from drm nightly git. Not sure whether I have time to write test program, but at least I can provide EGL/GL API calls from apitrace du

Re: [Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 8:42 AM, "Ben Widawsky" wrote: > > On 16-11-23 12:04:02, Jason Ekstrand wrote: >> >> On Wed, Nov 23, 2016 at 10:16 AM, Pohjolainen, Topi < >> topi.pohjolai...@gmail.com> wrote: >> >>> On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote: >>> >On Wed, Nov 23, 2016 at 1

[Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Emil Velikov
Hello list, The candidate for the Mesa 13.0.2 is now available. Currently we have: - 49 queued - 4 nominated (outstanding) - and 1 rejected patch(es) With this series we have - fixes for vc4, i965 and radeon drivers. In addition to that PCI IDs for Geminilake have been added to the i965 drive

Re: [Mesa-dev] [v3 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 6:06 AM, "Topi Pohjolainen" wrote: > > Note that RESOLVED is not tracked in the map explicitly. Absence > of item implicitly means RESOLVED state. > > v2: Added intel_resolve_map_clear() into intel_miptree_release() > v3 (Jason): Properly handle the assumption of resolve map not >

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Gustaw Smolarczyk
2016-11-24 18:25 GMT+01:00 Emil Velikov : > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon drivers. In > addition > to

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Emil Velikov
On 24 November 2016 at 18:09, Gustaw Smolarczyk wrote: > 2016-11-24 18:25 GMT+01:00 Emil Velikov : >> The plan is to have 13.0.2 this Saturday (25th of November), around or > > Saturday is 26th of November. > That's correct. Thank you. Emil ___ mesa-de

[Mesa-dev] [PATCH] radv: honour the number of properties available

2016-11-24 Thread Emil Velikov
From: Emil Velikov Cap up-to the number of properties available while copying the data. Otherwise we might crash and/or leak data. Cc: Dave Airlie Cc: "13.0" Signed-off-by: Emil Velikov --- src/amd/vulkan/radv_device.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-)

[Mesa-dev] [PATCH 2/3] radv: Make radv_finishme only warn once per call-site

2016-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/amd/vulkan/radv_private.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index a5d13a9..def0af2 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src/a

[Mesa-dev] [PATCH 1/3] anv: use do { } while (0) in the anv_finishme macro

2016-11-24 Thread Emil Velikov
From: Emil Velikov Use the generic construct instead of the currect GCC specific one. Cc: Kenneth Graunke Suggested-by: Kenneth Graunke Signed-off-by: Emil Velikov --- src/intel/vulkan/anv_private.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/intel

[Mesa-dev] [PATCH 3/3] isl: Make radv_finishme only warn once per call-site

2016-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/intel/isl/isl_priv.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_priv.h b/src/intel/isl/isl_priv.h index dc3975d..1867d25 100644 --- a/src/intel/isl/isl_priv.h +++ b/src/intel/isl/isl_priv.h

Re: [Mesa-dev] [v3 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-24 Thread Pohjolainen, Topi
On Thu, Nov 24, 2016 at 10:01:51AM -0800, Jason Ekstrand wrote: >On Nov 24, 2016 6:06 AM, "Topi Pohjolainen" ><[1]topi.pohjolai...@gmail.com> wrote: >> >> Note that RESOLVED is not tracked in the map explicitly. Absence >> of item implicitly means RESOLVED state. >> >> v

Re: [Mesa-dev] [PATCH] radv: honour the number of properties available

2016-11-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 7:14 PM, Emil Velikov wrote: > From: Emil Velikov > > Cap up-to the number of properties available while copying the data. > Otherwise we might crash and/or leak data. > > Cc: Dave Airlie > Cc: "13.0" > Signed-off-by: Emil Velikov > ---

Re: [Mesa-dev] [PATCH 3/3] isl: Make radv_finishme only warn once per call-site

2016-11-24 Thread Bas Nieuwenhuizen
You might want to rename the title of this patch. - Bas On Thu, Nov 24, 2016 at 7:18 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/intel/isl/isl_priv.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl_

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Eduardo Lima Mitev
On 11/24/2016 06:25 PM, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon drivers. In addition >

Re: [Mesa-dev] [PATCH 2/3] radv: Make radv_finishme only warn once per call-site

2016-11-24 Thread Bas Nieuwenhuizen
Making this thread safe is probably overkill I guess? Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 7:18 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/amd/vulkan/radv_private.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-24 Thread Jose Fonseca
On 23/11/16 17:37, Emil Velikov wrote: On 23 November 2016 at 16:14, George Kyriazis wrote: --- src/gallium/targets/libgl-gdi/SConscript | 1 + src/gallium/targets/libgl-gdi/libgl_gdi.c | 4 2 files changed, 5 insertions(+) diff --git a/src/gallium/targets/libgl-gdi/SConscript b/src/ga

[Mesa-dev] [PATCH 2/2] st/va: fix gop size for rate control

2016-11-24 Thread boyuan.zhang
From: Boyuan Zhang The gop_size in rate control is the budget window for internal rate control calculation, and shouldn't always equal to idr period. Define a coefficient to let budget window contains a number of idr period for proper rate control calculation. Adjust the number of i/p frame remai

[Mesa-dev] [Bug 98846] triangle clipping causes wrong vertex's attribute to be broadcasted for flat interpolation

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98846 Bug ID: 98846 Summary: triangle clipping causes wrong vertex's attribute to be broadcasted for flat interpolation Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH 1/2] st/va: force to submit two consecutive single jobs

2016-11-24 Thread boyuan.zhang
From: Boyuan Zhang The gop_size in rate control is the budget window for internal rate control calculation, and shouldn't always equal to idr period. Define a coefficient to let budget window contains a number of idr period for proper rate control calculation. Adjust the number of i/p frame remai

[Mesa-dev] [PATCH] swr: perform perspective division on clip distances

2016-11-24 Thread Ilia Mirkin
Clip distances need to be perspective-divided. This fixes all the interpolation-*-{distance,vertex} piglits. Also take this opportunity to fix clip distances for points rasterized as triangles - the clip distance is not subject to sprite coord replacement, so there's no interpolation of it. We jus

[Mesa-dev] [PATCH 1/8] anv: Store UUID in physical device.

2016-11-24 Thread Emil Velikov
From: Emil Velikov Port of an equivalent commit for radv. Signed-off-by: Emil Velikov --- src/intel/vulkan/anv_device.c | 18 ++ src/intel/vulkan/anv_pipeline_cache.c | 8 src/intel/vulkan/anv_private.h| 4 ++-- 3 files changed, 16 insertions(+), 14 d

[Mesa-dev] [PATCH 8/8] radv: don't return VK_SUCCESS if radv_device_get_cache_uuid() fails

2016-11-24 Thread Emil Velikov
From: Emil Velikov If radv_device_get_cache_uuid() fails result will be VK_SUCCESS as set by the radv_init_wsi() call above. Fixes: d943839 (radv: Use library mtime for cache UUID.) Cc: Bas Nieuwenhuizen Signed-off-by: Emil Velikov --- src/amd/vulkan/radv_device.c | 2 ++ 1 file changed, 2 in

[Mesa-dev] [PATCH 6/8] anv: don't leak memory if anv_init_wsi() fails

2016-11-24 Thread Emil Velikov
From: Emil Velikov brw_compiler_create() rzalloc-ates memory which we forgot to free. Cc: "13.0" Signed-off-by: Emil Velikov --- src/intel/vulkan/anv_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.

[Mesa-dev] [PATCH 4/8] configure.ac: remove no longer used TIMESTAMP_CMD

2016-11-24 Thread Emil Velikov
From: Emil Velikov Good bye, you shall not be missed. Signed-off-by: Emil Velikov --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5f30ae8..e7e5628 100644 --- a/configure.ac +++ b/configure.ac @@ -2644,8 +2644,6 @@ AC_SUBST([XA_MINOR], $XA

[Mesa-dev] [PATCH 7/8] radv: don't leak the fd if radv_physical_device_init() succeeds

2016-11-24 Thread Emil Velikov
From: Emil Velikov radv_amdgpu_winsys_create() does not take ownership of the fd, thus we end up leaking it as we return with VK_SUCCESS. Cc: Dave Airlie Cc: "13.0" Signed-off-by: Emil Velikov --- Not 100% sure on this one. --- src/amd/vulkan/radv_device.c | 1 + 1 file changed, 1 insertion(

[Mesa-dev] [PATCH 3/8] anv: automake: don't generate anv_timestamp.h

2016-11-24 Thread Emil Velikov
From: Emil Velikov No longer used as of last commit. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 6 -- src/intel/vulkan/Makefile.sources | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.a

[Mesa-dev] [PATCH 5/8] anv: don't double-close the same fd

2016-11-24 Thread Emil Velikov
From: Emil Velikov Cc: "13.0" Signed-off-by: Emil Velikov --- src/intel/vulkan/anv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 4711501..0e01e28 100644 --- a/src/intel/vulkan/anv_device.c +++

[Mesa-dev] [PATCH 2/8] anv: Use library mtime for cache UUID.

2016-11-24 Thread Emil Velikov
From: Emil Velikov Inspired by a similar commit for radv. Rather than recomputing the timestamp on each make invocation, just fetch it at runtime. Thus we no longer get the constant rebuild of anv_device.c and the follow-up libvulkan_intel.so link, when nothing has changed. I.e. using make &&

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 9:26 AM, "Emil Velikov" wrote: > > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon drivers. In addition

Re: [Mesa-dev] [PATCH 1/8] anv: Store UUID in physical device.

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 12:42 PM, "Emil Velikov" wrote: > > From: Emil Velikov > > Port of an equivalent commit for radv. > > Signed-off-by: Emil Velikov > --- > src/intel/vulkan/anv_device.c | 18 ++ > src/intel/vulkan/anv_pipeline_cache.c | 8 > src/intel/vulkan/anv_

Re: [Mesa-dev] [PATCH 2/8] anv: Use library mtime for cache UUID.

2016-11-24 Thread Jason Ekstrand
I'm not sure what I think of this... It has some interesting implications. I'll think about it and write something more detailed on Monday. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96993] new gallium swr driver can not be built on Windows

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96993 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 98166] [vulkan, radv] make install regenerates radv_timestamp.h and rebuilds radv_device.lo

2016-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98166 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Lionel Landwerlin
Thanks for the explanation, feel free to wait for Jason's rb otherwise : Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-24 Thread Mark Janes
I don't see any regressions in the automated test suites (piglit, deqp, gl cts) with this patch. -Mark Emil Velikov writes: > On 24 November 2016 at 06:22, Boyan Ding wrote: >> 2016-11-24 13:29 GMT+08:00 Derek Foreman : >>> On 23/11/16 07:18 PM, Boyan Ding wrote: 2016-11-24 7:01 GMT+

Re: [Mesa-dev] [PATCH 7/8] radv: don't leak the fd if radv_physical_device_init() succeeds

2016-11-24 Thread Bas Nieuwenhuizen
Seems like libdrm_amdgpu does a dup indeed. Patches 7-8 are Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 9:30 PM, Emil Velikov wrote: > From: Emil Velikov > > radv_amdgpu_winsys_create() does not take ownership of the fd, thus we > end up leaking it as we return with VK_SUCCESS. > >

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Emil Velikov
On 24 November 2016 at 20:44, Jason Ekstrand wrote: > On Nov 24, 2016 9:26 AM, "Emil Velikov" wrote: >> >> Hello list, >> >> The candidate for the Mesa 13.0.2 is now available. Currently we have: >> - 49 queued >> - 4 nominated (outstanding) >> - and 1 rejected patch(es) >> >> >> With this ser

Re: [Mesa-dev] [PATCH 2/8] anv: Use library mtime for cache UUID.

2016-11-24 Thread Emil Velikov
On 24 November 2016 at 20:58, Jason Ekstrand wrote: > I'm not sure what I think of this... It has some interesting implications. > I'll think about it and write something more detailed on Monday. But but... it helps up get rid of the lovely timestamp experience Thanks for having a look - how go

[Mesa-dev] [PATCH] swr: [rasterizer jit] use signed integer representation for logic op

2016-11-24 Thread Ilia Mirkin
Instead of (incorrectly) biasing the snorm value to make it look like a unorm, just use signed integer math. This fixes arb_color_buffer_float-render GL_RGBA8_SNORM Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 17 - 1 file changed, 12

Re: [Mesa-dev] [PATCH 3/3] isl: Make radv_finishme only warn once per call-site

2016-11-24 Thread Emil Velikov
On 24 November 2016 at 18:35, Bas Nieuwenhuizen wrote: > You might want to rename the title of this patch. > That's correct, thanks. Fixed locally. Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/list

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Emil Velikov
On 17 November 2016 at 17:27, Emil Velikov wrote: > Admittedly not a huge C++ expert, but what's wrong with having a > simple 5 line patch that adds the original code in a if guard ? > If then the LLVM <= 3.9 codepath is (somewhat) wrong, let's tackle > that separately. > Anyone ? Emil _

Re: [Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

2016-11-24 Thread Timothy Arceri
Thanks. Patches 7 & 8 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Jan Vesely
On Tue, 2016-11-22 at 20:25 +0100, Vedran Miletić wrote: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatibility layer for LLVM. > > v2: merged #ifdef blocks > v3: added

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Jan Vesely
On Fri, 2016-11-25 at 00:00 +, Emil Velikov wrote: > On 17 November 2016 at 17:27, Emil Velikov wrote: > > > Admittedly not a huge C++ expert, but what's wrong with having a > > simple 5 line patch that adds the original code in a if guard ? > > If then the LLVM <= 3.9 codepath is (somewhat)

Re: [Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

2016-11-24 Thread Jason Ekstrand
On Nov 24, 2016 7:12 AM, "Iago Toral" wrote: > > On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote: > > Hi Lionel, > > > > On Thu, 2016-11-24 at 13:08 +, Lionel Landwerlin wrote: > > > > > > Hi Iago, > > > > > > Looking at the history, before > > > ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa >

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Francisco Jerez
Emil Velikov writes: > On 17 November 2016 at 17:27, Emil Velikov wrote: > >> Admittedly not a huge C++ expert, but what's wrong with having a >> simple 5 line patch that adds the original code in a if guard ? >> If then the LLVM <= 3.9 codepath is (somewhat) wrong, let's tackle >> that separate

Re: [Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Francisco Jerez
Vedran Miletić writes: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatibility layer for LLVM. > > v2: merged #ifdef blocks > v3: added support for LLVM 3.6-3.8 > v4: a

Re: [Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Francisco Jerez
Jan Vesely writes: > On Tue, 2016-11-22 at 20:25 +0100, Vedran Miletić wrote: >> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >> 3.9 and older versionsin Clover. This patch restores it and refactors >> the support using Clover compatibility layer for LLVM. >> >> v2: merg

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Jonathan Gray
On Thu, Nov 24, 2016 at 05:25:26PM +, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon drive

[Mesa-dev] loader: Add amdgpu code to loader.c

2016-11-24 Thread Albert Freeman
I wrote this code in response to a issue someone on mesa-users had (https://lists.freedesktop.org/archives/mesa-users/2016-October/001231.html). They didn't reply so I don't know if the patch resolved the issue. Can someone please determine its usefulness. Also please check if drmCommandWrite() is

Re: [Mesa-dev] loader: Add amdgpu code to loader.c

2016-11-24 Thread Albert Freeman
A different patch to that code has been applied that does the same thing in a different (better) way. On 24 November 2016 at 05:25, Albert Freeman wrote: > I wrote this code in response to a issue someone on mesa-users had > (https://lists.freedesktop.org/archives/mesa-users/2016-October/001231.h

  1   2   >