Seems like libdrm_amdgpu does a dup indeed. Patches 7-8 are Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
On Thu, Nov 24, 2016 at 9:30 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > radv_amdgpu_winsys_create() does not take ownership of the fd, thus we > end up leaking it as we return with VK_SUCCESS. > > Cc: Dave Airlie <airl...@redhat.com> > Cc: "13.0" <mesa-sta...@lists.freedesktop.org> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > Not 100% sure on this one. > --- > src/amd/vulkan/radv_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 1b8864d..a08f6ac 100644 > --- a/src/amd/vulkan/radv_device.c > +++ b/src/amd/vulkan/radv_device.c > @@ -130,6 +130,7 @@ radv_physical_device_init(struct radv_physical_device > *device, > > fprintf(stderr, "WARNING: radv is not a conformant vulkan > implementation, testing use only.\n"); > device->name = device->rad_info.name; > + close(fd); > return VK_SUCCESS; > > fail: > -- > 2.10.2 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
