2016-11-23 6:28 GMT+01:00 Dave Airlie :
> From: Dave Airlie
>
> This is kind of a gross hacks, but vulkan doesn't specify anything
> but it would be nice to let people with prime systems at least
> see some stuff rendering for now.
>
> This creates a linear shadow image in GART that gets blitted
You are a star :D
I'll test this out tonight
On Wed, 23 Nov 2016 at 05:29 Dave Airlie wrote:
> From: Dave Airlie
>
> This is kind of a gross hacks, but vulkan doesn't specify anything
> but it would be nice to let people with prime systems at least
> see some stuff rendering for now.
>
> This
This is a rebase on top recent changes by Jason and Lionel. While
things have changed quite a bit in some of the patches they have
mostly become clearer.
Ben Widawsky (1):
i965: Enable fast clears for multi-lod
Topi Pohjolainen (16):
i965: Refactor lossless compression state tracking
i965/b
Upcoming patches will introduce fast clear in level/layer
granularity like the driver does already for depth/hiz. This patch
introduces equivalent full resolve option.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.c| 6 +++---
src/mesa/drivers/dri/i965/intel_
Status is still tracked per miptree. Next patch will switch to
resolve map per slice/level.
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 58 --
src/mesa/drivers/dri/i965/intel_resolve_map.c | 6 +--
src/mesa
Essentially this moves fast clear state update away from surface
state setup into brw_postdraw_set_buffers_need_resolve() that gets
called just after draw submission.
Calling intel_miptree_used_for_rendering() can be drop for gen6
and earlier as it is no-op.
v2: Rebased on top current master setti
Currently the status bits for fast clear include the flag telling
if non-multisampled mcs buffer should be used at all. Once the
state tracking is changed to follow individual levels/layers one
still needs to have the mcs enabling information in the miptree.
Therefore simply split it out to its own
v2: Added intel_resolve_map_clear() into intel_miptree_release()
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand (v1)
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 64 +++
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 14 +++---
2 files changed, 53 in
Until now fast clear has been supported only for non-layered and
non-mipmapped buffers. However, from gen8 onwards there is hardware
support also for layered/mipmapped. Once this is enabled, fast clear
operations target specific layer/level and call for the state to be
tracked in the same granulari
This patch also introduces getter and setter for fast clear state
preparing for tracking the state per slice.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 +-
src/mesa/drivers/dri/i965/brw_draw.c | 10 +++---
src/mesa/drivers/dri/i965/intel_mipm
One can now also delete intel_get_non_msrt_mcs_alignment().
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 138 +++---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 -
2 files changed, 38 insertions(+), 104 deletions(-)
diff --git a
Originally re-clears where skipped but when lossless compression
was introduced the re-clears where errorneously enabled also for
non-compressed fast clears.
Signed-off-by: Topi Pohjolainen
CC: Ben Widawsky
CC: Kenneth Graunke
CC: Harri Syrja
Cc: Chad Versace
---
src/mesa/drivers/dri/i965/br
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23 +--
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++-
3 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/src/mes
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 1c8ce0d..d943f04 100644
--- a/src/mesa/drivers
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_blorp.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c
b/src/mesa/drivers/dri/i965/brw_blorp.c
index 44ae26e..1a4b333 100644
--- a/src/mesa/drivers/dr
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 43 +--
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_
From: Ben Widawsky
On SKL (also fast clear is used for level 0, layer 0):
Manhattan 3.0: 3.88434% +/- 0.814659%
Manhattan 3.0 off: 3.25542% +/- 0.101149%
Trex: 3.43501% +/- 0.31223%
Trex off: 4.13781% +/- 0.0993569%
ON BDW:
Manhattan 3.0:
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 +
2 files changed, 13 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/d
Signed-off-by: Topi Pohjolainen
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_draw.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
b/src/mesa/drivers/dri/i965/brw_draw.c
index 0e0bc27..21164f3 100644
--- a/src/mesa/driv
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 15 +--
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/brw_context.c | 14 +-
src/mesa/drivers/dri/i965/intel_blit.c| 4 ++--
src/mesa/driv
Thanks for this. The series is
Reviewed-by: Nicolai Hähnle
On 21.11.2016 22:41, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +
3
On 22.11.2016 02:20, Marek Olšák wrote:
From: Marek Olšák
for debugging
---
src/compiler/glsl/linker.cpp | 8
src/mesa/main/mtypes.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
index 61a029c..9678a74 100644
--
On 23.11.2016 06:28, Dave Airlie wrote:
From: Dave Airlie
This is kind of a gross hacks, but vulkan doesn't specify anything
but it would be nice to let people with prime systems at least
see some stuff rendering for now.
This creates a linear shadow image in GART that gets blitted to at the
i
I think it would be good to keep the DRI_PRIME switch to allow for
switching between anvil and radv, handy for testing / comparing /
benchmarking both
It seems that Vulkan automatically uses the first card listed in vulkaninfo
(in my case it's the amdgpu card) with no way to select which is used,
When a layout contains a duplicated layout-qualifier-name in a single
declaration, only the last occurrence should be taken into account.
From page 59 (page 65 of the PDF) of the GLSL 4.40 spec:
" More than one layout qualifier may appear in a single
declaration. Additionally, the same layo
Consider this example:
" #version 150 core
#extension GL_ARB_shading_language_420pack: require
#extension GL_ARB_explicit_attrib_location: require
layout(location=0) out vec4 o;
layout(binding=2) layout(binding=3, std140) uniform U {
vec4 a;
} u[2];"
A
In the case of layout-qualifier-names that can appear multiple times
in different declarations of the same shader or, even, the same
program, but that have to consistently hold the same value we are
using the ast_layout_expression class which holds a list to store all
the appearances to be able to
The point mode value in an ast_type_qualifier can only be true if the
flag is already set since this layout-id-qualifier can only be or not
be present in a shader.
Hence, it is useless to check for its value if the flag is already
set. Just replaced with an assert.
V2: assert instead of checking
The validation of the default in layout qualifier already assures that
we won't have 2 ast_gs_input_layout objects with different primitive
type values. In fact, the validation already assures that we won't
have 2 ast_gs_input_layout objects in the AST tree at all.
The check for an error in the sh
The merge into the default in layout qualifier duplicates a lot of
code that can be reused from the generic merge method.
Now, we use the generic merge method inside the specific merge for the
default in layout qualifier. The generic merge method has been
completed with some bits that were only pr
Currently, the default out layout qualifier merge performs specific
validation and merge.
We want to split out the validation from the merge so they can be done
independently.
Additionally, for simplification, the direction of the validation and
merge is changed so the ast_type_qualifier calling
Since we modified the way in which multiple repetitions of the same
layout-qualifier-name in a single declaration collapse into the
ast_type_qualifier class, we can simplify the
merge_into_[in|out]_qualifier APIs through removing the create_node
parameter.
Reviewed-by: Timothy Arceri
Signed-off-b
Several layout-qualifier validations are duplicated in the
merge_qualifier and validate_in_qualifier methods.
We would rather have them refactored into single calls.
Suggested by Timothy.
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_type.cpp | 126 +
Currently, the default in layout qualifier merge performs specific
validation and merge.
We want to split out the validation from the merge so they can be done
independently.
Additionally, for simplification, the direction of the validation and
merge is changed so the ast_type_qualifier calling t
This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572.
The commit was erroneous because the ast_layout_expression class is
meant to hold a list used for an after check that all the declared
values for a layout-qualifier-name are consistent.
Therefore, the check for the possibility of dupli
From page 46 (page 52 of the PDF) of the GLSL 4.20 spec:
" More than one layout qualifier may appear in a single
declaration. If the same layout-qualifier-name occurs in multiple
layout qualifiers for the same declaration, the last one overrides
the former ones."
Consider this examp
The GLSL parser has been simplified to check for the needed
GL_ARB_shading_language_420pack extension just when merging the
qualifiers in the proper cases.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_type.cpp | 6 ++
src/compiler/glsl/glsl_parser.yy
This reverts commit 4c863993780a11cea6f88fa0682796bee5794042.
The commit was erroneous because the ast_layout_expression class was
created to hold a list of values for a layout-qualifier-name which is
allowed to appear in more than one expression in the same
shader/program but not to hold differen
After the previous modifications in the merging of the
layout-qualifier-name values, we no longer push the final value in a
declaration to the global values.
This regression happens because we don't call for merging on the
right-most layout qualifier of a declaration which is also the
overriding o
https://bugs.freedesktop.org/show_bug.cgi?id=98831
Bug ID: 98831
Summary: Constantly increasing memory consumption in JavaFX
applications
Product: Mesa
Version: 12.0
Hardware: x86-64 (AMD64)
OS: Linux (All)
2016-11-07 20:27 GMT+08:00 Boyan Ding :
> 2016-11-05 3:23 GMT+08:00 Matt Turner :
>> On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding wrote:
>>> According to OpenGL Shading Language 4.50 spec, Section 8.7 "Vector
>>> Relational Functions", functions of this type do not operate on scalar
>>> types, so
https://bugs.freedesktop.org/show_bug.cgi?id=98831
Itai changed:
What|Removed |Added
Attachment #128164|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #2 from Eero Tamminen ---
Thanks for the bug!
Which HW you have / with which Mesa drivers you tried this (Nouveau? Intel
i965? swrast?)? Did it happen both with SW rendering & HW rendering?
> Animations in JavaFX applications ca
On 23 November 2016 at 01:23, Vinson Lee wrote:
> Signed-off-by: Vinson Lee
> ---
> scons/llvm.py | 19 ---
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/scons/llvm.py b/scons/llvm.py
> index 977e47a..a27bf00 100644
> --- a/scons/llvm.py
> +++ b/scons/llvm.p
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #3 from Itai ---
I'm running on Intel HD4000 graphics (i5-3210M integrated GPU).
I believe I'm using the i965 driver, or whatever is the default on Debian
systems. Here are what I believe to be the relevant lines from my Xorg.log
fi
On 23 November 2016 at 07:51, Iago Toral wrote:
> Hey Emil,
>
> On Thu, 2016-10-06 at 14:12 +0100, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Driver should enumerate only up-to min2(num_available, num_requested)
>> properties and return VK_INCOMPLETE if the # of requested props is
>> smaller
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #4 from Itai ---
Replaying with Apitrace does not exhibit the problem. Additionally, it seems to
perform altogether much better, hardly taxing my CPU, while the original seems
to constantly use up a whole core (~24% CPU usage).
Sin
Thanks Emil,
One thing that I am clear about is: what is the difference between
Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however
in the documentation they are worded as if they mean different things.
I will also suggest some edits and send out a diff for review.
Ge
On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George
wrote:
> Thanks Emil,
>
> One thing that I am clear about is: what is the difference between
> Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however
> in the documentation they are worded as if they mean different things.
---
docs/submittingpatches.html | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 2d18c74..be49a2e 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -41,7 +41,7 @@ components.
git bise
On 23 November 2016 at 15:39, Ilia Mirkin wrote:
> On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George
> wrote:
>> Thanks Emil,
>>
>> One thing that I am clear about is: what is the difference between
>> Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing,
>> however in the docu
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Emil Velikov
> Sent: Wednesday, November 23, 2016 10:02 AM
> To: Ilia Mirkin
> Cc: Kyriazis, George ; ML mesa-dev d...@lists.freedesktop.org>
> Subject: Re: [Mesa-dev] [PATCH v4 09/10] ga
_mesa_lookup_texture_err() is not currently checking that the
texture-id can be zero, but _mesa_HashLookup() doesn't expect the key
to be zero, and will fail an assertion (crashing the driver on debug mode).
Considering that _mesa_lookup_texture_err() is called from
_mesa_GetTextureImage and _mesa
This mini-series addresses a couple of issues I found while fixing CTS test
'GL45-CTS.direct_state_access.textures_image_query_errors' on i965/BDW, which
currently crashes the driver.
There is a little issue with the test itself, for which I submitted a fix too,
but these two patches should get ev
There is an specific list of texture targets that can be used with
glGetTextureImage. From OpenGL 4.5 spec, section '8.11 Texture Queries',
page 234 of the PDF states:
"An INVALID_ENUM error is generated if the effective target is
not one of TEXTURE_1D , TEXTURE_2D , TEXTURE_3D , TEXTURE_1D
On Tue, Nov 22, 2016 at 8:27 PM, Aaron Watry wrote:
>
>
> On Tue, Nov 22, 2016 at 2:48 PM, Matt Turner wrote:
>
>> On 11/22, Aaron Watry wrote:
>>
>>> disk_cache_get returns void*, but we were storing/comparing a char*.
>>>
>>> Signed-off-by: Aaron Watry
>>> ---
>>> Note that this did, and stil
---
src/gallium/targets/libgl-gdi/SConscript | 1 +
src/gallium/targets/libgl-gdi/libgl_gdi.c | 4
2 files changed, 5 insertions(+)
diff --git a/src/gallium/targets/libgl-gdi/SConscript
b/src/gallium/targets/libgl-gdi/SConscript
index d3251ca..adb3581 100644
--- a/src/gallium/targets/libgl
On 20 November 2016 at 16:28, Ilia Mirkin wrote:
> Thanks Marek.
>
> Emil, I'd appreciate it if you could have a look as well. I believe
> you were the last to touch these helpers. I'm highly confused by the
> flow of things, and mainly want to ensure that we don't warp the same
> screen *twice*.
On Wed, Nov 23, 2016 at 11:10 AM, Kyriazis, George
wrote:
>
>> -Original Message-
>> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
>> Behalf Of Emil Velikov
>> Sent: Wednesday, November 23, 2016 10:02 AM
>> To: Ilia Mirkin
>> Cc: Kyriazis, George ; ML mesa-dev > d...@l
Thanks,
I'll update the docs explaining the *-By: a bit better and send it out for
review.
George
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Ilia Mirkin
> Sent: Wednesday, November 23, 2016 10:59 AM
> To: Kyriazis, George
> Cc:
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> Originally re-clears where skipped but when lossless compression
> was introduced the re-clears where errorneously enabled also for
> non-compressed fast clears.
>
> Signed-off-by: Topi Pohjolainen
> CC: Ben
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #5 from Eero Tamminen ---
(In reply to Itai from comment #3)
> The problem disappears completely when using SW rendering in Java
> (-Dprism.order=sw), which as far as I understand surpasses Mesa, but I'm not
> sure.
It's not using M
General comment: Does it make sense to squash this with the previous
patch? I'm fine either way.
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/brw_blorp.c | 15 +--
>
https://bugs.freedesktop.org/show_bug.cgi?id=98833
Bug ID: 98833
Summary: [REGRESSION, bisected] Wayland revert commit breaks
fullscreen frame updates
Product: Mesa
Version: git
Hardware: Other
OS: All
On 23 November 2016 at 16:14, George Kyriazis wrote:
> ---
> src/gallium/targets/libgl-gdi/SConscript | 1 +
> src/gallium/targets/libgl-gdi/libgl_gdi.c | 4
> 2 files changed, 5 insertions(+)
>
> diff --git a/src/gallium/targets/libgl-gdi/SConscript
> b/src/gallium/targets/libgl-gdi/SCons
On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote:
>On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen
><[1]topi.pohjolai...@gmail.com> wrote:
>
> Originally re-clears where skipped but when lossless compression
> was introduced the re-clears where errorneously enable
On Wed, Nov 23, 2016 at 09:26:29AM -0800, Jason Ekstrand wrote:
>General comment: Does it make sense to squash this with the previous
>patch? I'm fine either way.
>On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen
><[1]topi.pohjolai...@gmail.com> wrote:
>
> Signed-off-by: Top
https://bugs.freedesktop.org/show_bug.cgi?id=98833
Daniel Stone changed:
What|Removed |Added
CC||dan...@fooishbar.org
--- Comment #1 from
On Tue, Nov 22, 2016 at 2:31 PM, Emil Velikov wrote:
> On 22 November 2016 at 01:19, Bas Nieuwenhuizen
> wrote:
>> We want to also invalidate the cache when LLVM gets changed. As the
>> specific LLVM revision is not fixed at build time, we will need to
>> check at runtime. Computing a checksum f
It works with the Talos Principle and performs well, I'm seeing some
artefacts in the grass which can be seen in https://imgur.com/a/3litB I'm
not sure if that's caused by one of the LLVM bugs that have been mentioned
On Wed, 23 Nov 2016 at 11:13 Mike Lothian wrote:
> I think it would be good to
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #6 from Christoph Haag ---
This was my test case for the same problem:
https://gist.github.com/ChristophHaag/661be992429b451218e9ee1fb0eacdec
The problematic calls being ImageView.setTranslateX() and
ImageView.setTranslateY() and per
The strategy is to just keep n anv_query_pool_slot entries per query
instead of one. The available bit is only valid in the last one.
Signed-off-by: Ilia Mirkin
---
This was lightly tested with this patch to the vulkan loader cube.c:
http://pastie.org/private/fe92867hwhxu7fzjw9pvzq
Flipping it
On Wed, Nov 23, 2016 at 1:52 PM, Ilia Mirkin wrote:
> The strategy is to just keep n anv_query_pool_slot entries per query
> instead of one. The available bit is only valid in the last one.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> This was lightly tested with this patch to the vulkan loader cube.
Not needed anymore.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/Makefile.am | 6 +-
src/amd/vulkan/Makefile.sources | 3 +--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
index c559a95..3f9b53e 100644
--- a
On 23/11/16 01:23, Vinson Lee wrote:
Signed-off-by: Vinson Lee
---
scons/llvm.py | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/scons/llvm.py b/scons/llvm.py
index 977e47a..a27bf00 100644
--- a/scons/llvm.py
+++ b/scons/llvm.py
@@ -194,11 +194,16 @@ def
On 23 November 2016 at 20:46, Nicolai Hähnle wrote:
> On 23.11.2016 06:28, Dave Airlie wrote:
>>
>> From: Dave Airlie
>>
>> This is kind of a gross hacks, but vulkan doesn't specify anything
>> but it would be nice to let people with prime systems at least
>> see some stuff rendering for now.
>>
On 23 November 2016 at 21:13, Mike Lothian wrote:
> I think it would be good to keep the DRI_PRIME switch to allow for switching
> between anvil and radv, handy for testing / comparing / benchmarking both
>
> It seems that Vulkan automatically uses the first card listed in vulkaninfo
> (in my case
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 17, 2016, at 6:51 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
Currently clears only operate on the 0th array index (ignoring surface
layout parameters). Instead normalize to take a RTAI like all the
load/store tile logi
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 17, 2016, at 6:51 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
When switching render target array indexes (as might happen in a GS, or
in a future change, with layered clears), if the previous state is
HOTTILE_CLEAR, we
On Wed, Nov 23, 2016 at 10:13 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Wed, Nov 23, 2016 at 09:26:29AM -0800, Jason Ekstrand wrote:
> >General comment: Does it make sense to squash this with the previous
> >patch? I'm fine either way.
> >On Wed, Nov 23, 2016 at
This code seems to assume that all attached buffers have the same start layer,
and that start will be zero. Maybe it should construct the clearMask inside
the layer loop, which would also be a bit clearer than the code you added to
drop bits out of the mask?
-Tim
> On Nov 17, 2016, at 6:51 PM
On Wed, Nov 23, 2016 at 10:16 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote:
> >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen
> ><[1]topi.pohjolai...@gmail.com> wrote:
> >
> > Originally re-clears where
Signed-off-by: Vinson Lee
Reviewed-by: Emil Velikov
---
v2
Use LLVM_CONFIG for swr too.
Update common.py.
Use local variable llvm_config instead of env['LLVM_CONFIG'].
common.py | 2 +-
scons/llvm.py | 17 +
src/gallium/drivers/swr/
On Wed, Nov 23, 2016 at 3:02 PM, Rowley, Timothy O
wrote:
> This code seems to assume that all attached buffers have the same start
> layer, and that start will be zero. Maybe it should construct the clearMask
> inside the layer loop, which would also be a bit clearer than the code you
> added
On 23/11/16 20:09, Vinson Lee wrote:
Signed-off-by: Vinson Lee
Reviewed-by: Emil Velikov
---
v2
Use LLVM_CONFIG for swr too.
Update common.py.
Use local variable llvm_config instead of env['LLVM_CONFIG'].
common.py | 2 +-
scons/llvm.py | 17
Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave the
changes as they are, then.
This series of four patches (or rather, the rebased versions in your repo) are
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 23, 2016, at 2:11 PM, Ilia Mirkin
mailto
Series is:
Reviewed-by: Nicolai Hähnle
On 23.11.2016 17:10, Eduardo Lima Mitev wrote:
This mini-series addresses a couple of issues I found while fixing CTS test
'GL45-CTS.direct_state_access.textures_image_query_errors' on i965/BDW, which
currently crashes the driver.
There is a little issue
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> v2: Added intel_resolve_map_clear() into intel_miptree_release()
>
> Signed-off-by: Topi Pohjolainen
> Reviewed-by: Jason Ekstrand (v1)
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 64
> +
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> One can now also delete intel_get_non_msrt_mcs_alignment().
>
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 138
> +++---
> src/mesa/drivers/dr
Commit 6d416bcd846a49414f210cd761789156c37a7b3e (i965: Use arrays in
Gen7+ URB code.) introduced a regression which caused us to fail to
allocate all of our URB space.
- total_wants -= ds_wants;
+ total_wants -= additional;
The new line should have been total_wants -= wants[
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen <
topi.pohjolai...@gmail.com> wrote:
> Until now fast clear has been supported only for non-layered and
> non-mipmapped buffers. However, from gen8 onwards there is hardware
> support also for layered/mipmapped. Once this is enabled, fast clear
> o
On Tue, Nov 22, 2016 at 7:03 PM, Jordan Justen
wrote:
> We rename do_blorp_blit() to try_blorp_blit(), and add a return error
> if the surface size for the blit is too large. Now, do_blorp_blit() is
> rewritten to try to split the blit into smaller operations if
> try_blorp_blit() fails.
>
> Note
Ported from radeonsi.
Note that si_make_texture_descriptor() already sets img7 to the mask
value referred to in the comment.
---
src/amd/common/ac_nir_to_llvm.c | 31 +++
src/amd/vulkan/radv_device.c| 11 ++-
2 files changed, 33 insertions(+), 9 deletions(-
radv_tex_wrap() already supports VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE,
so all that's needed is to advertise support for the extension.
---
src/amd/vulkan/radv_device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index
These are some random patches for radv. The first adds support for
anisotropic filtering on SI/CIK. Note that this patch has not been
tested. Patches 2-4 add support for extensions; two of which are
already supported in practice, and one that's trivial to implement.
One thing I noticed is that
The driver already supports this extension in practice.
---
src/amd/vulkan/radv_device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 0d79eee..58484bd 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_de
---
src/amd/vulkan/radv_cmd_buffer.c | 94 ++--
src/amd/vulkan/radv_device.c | 4 ++
2 files changed, 84 insertions(+), 14 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 824f9d8..d1e4deb 100644
--- a/src
This bumps the libdrm requirement to 2.4.72.
---
configure.ac | 2 +-
src/amd/vulkan/radv_radeon_winsys.h | 2 +-
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 43 +--
3 files changed, 26 insertions(+), 21 deletions(-)
On 24 November 2016 at 05:07, Bas Nieuwenhuizen
wrote:
> Not needed anymore.
>
> Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Dave Airlie
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-de
1 - 100 of 144 matches
Mail list logo
