Thanks Emil, One thing that I am clear about is: what is the difference between Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however in the documentation they are worded as if they mean different things.
I will also suggest some edits and send out a diff for review. George > -----Original Message----- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Monday, November 21, 2016 10:27 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for > windows > > On 18 November 2016 at 19:49, Kyriazis, George <george.kyria...@intel.com> > wrote: > > > > > >> -----Original Message----- > >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > >> Behalf Of Emil Velikov > >> Sent: Friday, November 18, 2016 5:24 AM > >> To: Kyriazis, George <george.kyria...@intel.com> > >> Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > >> Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr > >> build for windows > >> > >> On 18 November 2016 at 04:27, George Kyriazis > >> <george.kyria...@intel.com> > >> wrote: > >> > Also, modify gen_knobs.py so that each invocation creates a single > >> > generated file. This is more similar to how the other generators behave. > >> > --- > >> > src/gallium/SConscript | 1 + > >> > src/gallium/drivers/swr/Makefile.am | 15 +- > >> > src/gallium/drivers/swr/SConscript | 216 > >> +++++++++++++++++++++ > >> > .../drivers/swr/rasterizer/scripts/gen_knobs.py | 51 ++--- > >> > 4 files changed, 257 insertions(+), 26 deletions(-) create mode > >> > 100644 src/gallium/drivers/swr/SConscript > >> > > >> This is getting tiresome :'-( > >> > >> I've mentioned on multiple occasions to keep separate logical changes > >> into individual patches. > >> In my previous sounds I've _explicitly_ left only the ones > >> (SConscript > >> fixes) that should be squashed here. > >> Please read review comments more carefully ? > >> > > I hope we can go past the confusion. Hopefully last set of patches will be > posted in a bit. > > > >> When sending version X of patch series, adding r-b/ack-b/t-b/other > >> tags (where applicable) and brief version history is highly recommended. > >> If in doubt on the latter - skim through git log + grep v2. > >> > > Appreciate the pointer; I am new to mesa check-in practices, and I didn't > know. I think it's a good idea to add this info in the Mesa Development notes > webpage, to make it more obvious (http://www.mesa3d.org/devinfo.html). > > > Having a look and most/all the things mentioned seems to be already there. > From splitting, breakage, to the r-b,t-b, ack-b tags. > > I've just split devinfo.html in a goal to make things clearer/stand out. > Information about patch submission is in docs/submittingpatches.html. > If there's anything unclear (or a hyperlink should be nice) do send a patch. > Pretty please ? > > Thanks > Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
