Re: [Mesa-dev] [PATCH 2/2] i965: Fix typo in nir_op_pack_double_2x32_split handling

2016-10-17 Thread Iago Toral
On Fri, 2016-10-14 at 10:23 -0700, Ian Romanick wrote: > On 10/08/2016 09:33 AM, Eduardo Lima Mitev wrote: > > > > On 10/08/2016 02:12 AM, Ian Romanick wrote: > > > > > > From: Ian Romanick > > > > > > This was found partially by inspection and partially by hitting a > > > problem while working

Re: [Mesa-dev] [PATCH] radeonsi: clear DB_RENDER_OVERRIDE

2016-10-17 Thread Nicolai Hähnle
On 13.10.2016 18:54, Marek Olšák wrote: From: Marek Olšák Vulkan doesn't set these fields even though it doesn't use HiS. HiS is disabled by programming DB_SRESULTS_COMPARE_STATEn to 0. This probably has no effect, but it makes sense to handle state more similar to Vulkan in general. Revie

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

2016-10-17 Thread Michel Dänzer
On 14/10/16 07:02 PM, Emil Velikov wrote: > On 14 October 2016 at 09:45, Michel Dänzer wrote: >> On 14/10/16 05:14 PM, Emil Velikov wrote: >>> On 14 October 2016 at 01:45, Michel Dänzer wrote: On 13/10/16 07:14 PM, Emil Velikov wrote: > On 13 October 2016 at 04:07, Michel Dänzer wrote:

Re: [Mesa-dev] [PATCH] gallium/hud: Sensor extension is segfaulting.

2016-10-17 Thread Nicolai Hähnle
On 13.10.2016 19:29, Steven Toth wrote: Round two of the patchset, incorporating feedback from nhaeh...@gmail.com The fixes in this set address bugfix #68169, HUD crashing when testing with unigine (heaven). The bug also manifested itself as a lack of data in HUD charts when multiple instanced

Re: [Mesa-dev] [PATCH] radeonsi: shorten "shader->selector" to "sel" in si_shader_create

2016-10-17 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.10.2016 19:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH 1/6] util: add vector util code.

2016-10-17 Thread Nicolai Hähnle
On 14.10.2016 05:16, Dave Airlie wrote: From: Dave Airlie This is ported from anv, both anv and radv can share this. Signed-off-by: Dave Airlie --- src/util/Makefile.sources | 4 +- src/util/u_vector.c | 98 +++ src/util/u_vector.h | 8

Re: [Mesa-dev] [PATCH 4/6] util: move min/max/clamp macros to util macros.h

2016-10-17 Thread Nicolai Hähnle
Apart from the comment I sent on the first patch, patch 1&4 are Reviewed-by: Nicolai Hähnle On 14.10.2016 05:16, Dave Airlie wrote: From: Dave Airlie Although the vulkan drivers include mesa macros.h, for radv I'd like to move away from that. Signed-off-by: Dave Airlie --- src/mesa/main/m

[Mesa-dev] [PATCH] i965/fs/nir: fix double pack from previous unpack optimization

2016-10-17 Thread Iago Toral Quiroga
It seems I initially wrote this as: if (cond_for_opt) { } and then I modified the style at some point to be like: if (!cond_for_opt) continue; But I did not re-write all the conditions accordingly. --- I tested this quickly on a haswell with our fp64 branch and it did not show any regre

[Mesa-dev] [Bug 98275] Segmentation fault when using VAAPI acceleration in VLC after installing oibaf's optimized drivers

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98275 --- Comment #1 from Nicolai Hähnle --- Could you please provide a backtrace of the crash? (Make sure that debug symbol packages are installed.) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] anv/radv: WSI sharing code

2016-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/17/2016 03:24 PM, Dave Airlie wrote: > This series builds on top of the previous sharing patches I sent. > > The aim here is to share the X11 and wayland WSI code between > the two vulkan drivers so we have a consistent implementation and > one place to fix

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #19 from Michel Dänzer --- (In reply to shinji.suzuki from comment #16) > Created attachment 127317 [details] [review] > Arbitration on so->fence through per sync-object mutex. One minor comment below, otherwise looks good to me. Fee

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-17 Thread Marek Olšák
Reverting the whole commit is too much. You can just remove the PIPE BIND SHARED usage if you need to. Marek On Oct 17, 2016 6:43 AM, "Ilia Mirkin" wrote: > On Thu, Sep 15, 2016 at 4:54 PM, Marek Olšák wrote: > > On Thu, Sep 15, 2016 at 5:14 AM, Dave Airlie wrote: > >> On 15 September 2016 at

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Eric Engestrom
On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: > On OpenBSD try to dlopen 'libglapi.so', ld.so will find > the highest major/minor version and open it in this case. > > Avoids '#error Unknown glapi provider for this platform' at build time. > > Signed-off-by: Jonathan Gray LGTM, and

Re: [Mesa-dev] [PATCH] egl: remove docs directory from EXTRA_DIST

2016-10-17 Thread Eric Engestrom
On Sunday, 2016-10-16 21:06:25 +1100, Jonathan Gray wrote: > The egl docs directory no longer exists as of > 88b5c36fe1a1546bf633ee161a6715efc593acbd. > > Remove it from EXTRA_DIST to unbreak 'make dist' > > Signed-off-by: Jonathan Gray Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom >

[Mesa-dev] [PATCH mesa] gbm: add a couple missing includes

2016-10-17 Thread Eric Engestrom
Needed for memset() and drmIoctl(). Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_driint.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gbm/backends/dri/gbm_driint.h b/src/gbm/backends/dri/gbm_driint.h index 1644fac..26376ef 100644 --- a/src/gbm/backends/dri/gbm_driint

Re: [Mesa-dev] [PATCH mesa] gbm: add a couple missing includes

2016-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/17/2016 09:39 PM, Eric Engestrom wrote: > Needed for memset() and drmIoctl(). > > Signed-off-by: Eric Engestrom > --- > src/gbm/backends/dri/gbm_driint.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gbm/backends/dri/gbm_driint.h > b/src

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #2 from shinji.suz...@gmail.com --- The amount of memory being in use may be bounded. But I believe there are blocks that don't get released until process termination. Having unreleased memory brings bad user experience to users of val

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 09:04:56 +0300, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > > Signed-off-by: Tapani Pälli Fixes: acd35c8758dc73240903 ("egl/android: tweak droid_add_configs_for

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 07:04, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > Which brings the question - do we want to enable -Wshadow for the C sources. The C++ ones [used to] produce too

Re: [Mesa-dev] [PATCH v2] egl/wayland: Avoid race conditions when on non-main thread

2016-10-17 Thread Emil Velikov
On 16 October 2016 at 14:55, Daniel Stone wrote: > With those fixed, assuming we're fine with an increased hard dep: Wayland 1.11 has been out for a 3+ months so it's perfectly reasonable imho. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH] st/nine: Fix multisample limit check

2016-10-17 Thread Emil Velikov
On 16 October 2016 at 23:06, Axel Davy wrote: > I've pushed this just now to be sure it makes it for mesa 13. > Which reminds me that I should beat up our existing get-extra-pick-list.sh to track the offending SHA through the branch and "nominate" the fix. Currently if only checks if the SHA has b

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-17 Thread Emil Velikov
On 15 October 2016 at 08:59, Axel Davy wrote: > On 14/10/2016 22:33, Emil Velikov wrote: >> >> On 14 October 2016 at 20:21, Axel Davy wrote: >> >>> The code looks good. With the minor nitpick fixed, this patch is: >>> Reviewed-by: Axel Davy >>> >> Thanks. If you can skim through any of the other

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 10:53, Eric Engestrom wrote: > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: >> On OpenBSD try to dlopen 'libglapi.so', ld.so will find >> the highest major/minor version and open it in this case. >> >> Avoids '#error Unknown glapi provider for this platform' at

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Jonathan Gray
On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: > On 17 October 2016 at 10:53, Eric Engestrom wrote: > > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: > >> On OpenBSD try to dlopen 'libglapi.so', ld.so will find > >> the highest major/minor version and open it in this ca

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #2 from Christian König --- (In reply to John from comment #1) > I may have the same problem, and I know how to trigger it *easily*: Thanks, that is a very valuable information. Going to try to reproduce this, cause previously that s

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 Emil Velikov changed: What|Removed |Added CC|emil.l.veli...@gmail.com| --- Comment #1 from Emil Velikov --- Ja

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #3 from Emil Velikov --- Of the top of my head, it sounds like one is using PushDebugGroup without a corresponding Pop. Can you attach a simple program which reproduces this ? Ideally one which does not depend on glew, in order to is

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 --- Comment #2 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- (In reply to Emil Velikov from comment #1) > Jan, I'm not working on radv, so not sure how I can help here. Dropping > myself from the CC list. Ok. I found your name in https://cgit.free

Re: [Mesa-dev] [PACH v2] glsl: SSBO unsized array declarations, if present, must be declared last

2016-10-17 Thread Iago Toral
On Sun, 2016-10-16 at 17:00 +1100, Timothy Arceri wrote: > On Fri, 2016-10-14 at 14:30 +0200, Iago Toral Quiroga wrote: > > > > From the ARB_shader_storage_buffer_object spec: > > > > "In a shader storage block, the last member may be declared without > > an explicit > >  size.  In this case, the

[Mesa-dev] [PATCH 11/14] glsl_to_tgsi: remove code for fixing up TGSI labels

2016-10-17 Thread Marek Olšák
From: Marek Olšák I don't know what this was supposed to do, but all TGSI labels were always 0. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 +- 1 file changed, 2 insertions(+), 90 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mes

[Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

2016-10-17 Thread Marek Olšák
From: Marek Olšák it's always true --- src/mesa/drivers/dri/i915/i915_context.c | 1 - src/mesa/drivers/dri/i965/brw_compiler.c | 1 - src/mesa/main/mtypes.h | 1 - src/mesa/program/ir_to_mesa.cpp | 3 +-- src/mesa/state_tracker/st_extensions.c | 2 -- 5 files change

[Mesa-dev] [PATCH 13/14] mesa: remove gl_shader_compiler_options::EmitNoMainReturn

2016-10-17 Thread Marek Olšák
From: Marek Olšák it's always true --- src/mesa/drivers/dri/i915/i915_context.c | 1 - src/mesa/drivers/dri/i965/brw_compiler.c | 1 - src/mesa/main/mtypes.h | 1 - src/mesa/program/ir_to_mesa.cpp| 9 - src/mesa/state_tracker/st_extensions.c | 1 -

[Mesa-dev] [PATCH 09/14] mesa_to_tgsi: remove remnants of flow control and subroutine support

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 93 +--- 1 file changed, 1 insertion(+), 92 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index c8ed26c..4c26d92 100644 --- a/src/mesa/st

[Mesa-dev] [PATCH 01/14] glsl_to_tgsi: use array_id for temp arrays instead of hacking high bits

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 31 ++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index fd2485d..5bc2661 100644 --- a/src/m

[Mesa-dev] [PATCH 06/14] glsl_to_tgsi: merge buffer and sampler fields in glsl_to_tgsi_instruction

2016-10-17 Thread Marek Olšák
From: Marek Olšák sizeof(glsl_to_tgsi_instruction): 416 -> 384 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 63 +++--- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.

[Mesa-dev] [PATCH 02/14] glsl_to_tgsi: remove unused parameters from calc_deref_offsets

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 5bc2661..b857a5b 100644 --- a/src/mesa/state_tracker/

[Mesa-dev] [PATCH 07/14] glsl_to_tgsi: allocate glsl_to_tgsi_instruction::tex_offsets on demand

2016-10-17 Thread Marek Olšák
From: Marek Olšák sizeof(glsl_to_tgsi_instruction): 384 -> 264 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index b7280e3..2ae15c9 10

[Mesa-dev] [PATCH 03/14] glsl_to_tgsi: remove unused st_translate::tex_offsets

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index b857a5b..93673fa 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src/me

[Mesa-dev] [PATCH 2/6] gallium/radeon: remove unused radeon_llvm_reg_index_soa

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h| 2 -- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 5 - 2 files changed, 7 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h b/src/gallium/drivers/radeon/radeon_llvm.h index 367e4c0..b4b96

[Mesa-dev] [PATCH 1/6] radeonsi: move LLVM ALU codegen into radeonsi

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h |9 - .../drivers/radeon/radeon_setup_tgsi_llvm.c| 979 +-- src/gallium/drivers/radeonsi/Makefile.sources |2 + src/gallium/drivers/radeonsi/si_shader.c |9 +- src/gallium

[Mesa-dev] [PATCH 4/6] radeonsi: import all TGSI->LLVM code from gallium/radeon

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- .../drivers/r600/evergreen_compute_internal.h |1 - src/gallium/drivers/radeon/Makefile.sources|6 +- src/gallium/drivers/radeon/radeon_llvm.h | 151 --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 241 src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with RET opcodes. The alternative is that the st lowers the whole thing into a loop which adds IMHO unnecessary complexity to the resulting code. Any reason not to leave that in place? -ilia On Mon, Oct 17, 2016 at 9:39 AM, Marek

[Mesa-dev] [PATCH 08/14] mesa_to_tgsi: drop support for instructions that can't occur here

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 72 1 file changed, 72 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index b989257..c8ed26c 100644 --- a/src/mesa/state_tracker/st_m

[Mesa-dev] [PATCH 04/14] glsl_to_tgsi: reduce the size of st_dst_reg and st_src_reg

2016-10-17 Thread Marek Olšák
From: Marek Olšák I noticed that glsl_to_tgsi_instruction is too huge. sizeof(glsl_to_tgsi_instruction): 752 -> 464 (-38%) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 71 +- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git a/src/mesa/state_tracker/s

[Mesa-dev] [PATCH 12/14] mesa: remove gl_shader_compiler_options::EmitNoFunctions

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index ff20226..5368440 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
From: Marek Olšák Never used. The GLSL compiler doesn't even look at EmitNoFunctions. --- src/mesa/state_tracker/st_extensions.c | 6 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 212 + 2 files changed, 7 insertions(+), 211 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Marek Olšák
From: Marek Olšák sizeof(glsl_to_tgsi_instruction): 464 -> 416 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33 +++--- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: > nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with > RET opcodes. The alternative is that the st lowers the whole thing > into a loop which adds IMHO unnecessary complexity to the resulting > code. Any reason not to leave th

[Mesa-dev] [PATCH] gallium/tgsi: add missing #include

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h b/src/gallium/auxiliary/tgsi/tgsi_util.h index ca07bfd..83a930b 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_util.h +++ b/src/gallium/auxilia

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: > On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: >> nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with >> RET opcodes. The alternative is that the st lowers the whole thing >> into a loop which adds IMHO unnecessary comp

[Mesa-dev] [PATCH 3/6] gallium/radeon: simplify initialization of 64-bit gallivm builders

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 2d424d5..c06eb3e 1

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 3:48 PM, Ilia Mirkin wrote: > On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: >> On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: >>> nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with >>> RET opcodes. The alternative is that the st lowers the w

Re: [Mesa-dev] [PATCH] gallium/hud: Sensor extension is segfaulting.

2016-10-17 Thread Brian Paul
For the subject line we usually say what we're fixing. I'd suggest something like "gallium/hud: fix segfault in sensor extension code". -Brian On 10/13/2016 11:29 AM, Steven Toth wrote: Round two of the patchset, incorporating feedback from nhaeh...@gmail.com The fixes in this set address

[Mesa-dev] [PATCH 6/6] radeonsi: rename prefixes from radeon to si

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 96 ++--- src/gallium/drivers/radeonsi/si_shader_internal.h | 70 +- .../drivers/radeonsi/si_shader_tgsi_setup.c| 150 ++-

Re: [Mesa-dev] [PATCH 09/14] mesa_to_tgsi: remove remnants of flow control and subroutine support

2016-10-17 Thread Ilia Mirkin
Patches 1-9 are Reviewed-by: Ilia Mirkin On Mon, Oct 17, 2016 at 9:39 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_mesa_to_tgsi.c | 93 > +--- > 1 file changed, 1 insertion(+), 92 deletions(-) > > diff --git a/src/mesa/state_tracke

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
On Mon, Oct 17, 2016 at 9:59 AM, Marek Olšák wrote: > On Mon, Oct 17, 2016 at 3:48 PM, Ilia Mirkin wrote: >> On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: >>> On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with >>

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 4:10 PM, Ilia Mirkin wrote: > On Mon, Oct 17, 2016 at 9:59 AM, Marek Olšák wrote: >> On Mon, Oct 17, 2016 at 3:48 PM, Ilia Mirkin wrote: >>> On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: > nouveau suppor

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
I'm adding back this: options->EmitNoMainReturn = !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); And: diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 293654c..5f28d07 100644 --- a/src/mesa/state_trac

Re: [Mesa-dev] [PATCH 3/5] st/va: Return surface formats depending on config chroma format

2016-10-17 Thread Julien Isorce
Hi Mark, Thx for the patch. I can see it has already landed. I just tried it with gstreamer-vaapi and it causes problem since they create the config like this for VPP: va_status = vaCreateConfig (filter->va_display, VAProfileNone, VAEntrypointVideoProc, NULL, 0, &filter->va_config); As yo

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
On Mon, Oct 17, 2016 at 10:20 AM, Marek Olšák wrote: > I'm adding back this: > >options->EmitNoMainReturn = > !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); > > And: > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state_tracker/st_gls

[Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
From: Marek Olšák Never used. The GLSL compiler doesn't even look at EmitNoFunctions. v2: add back "return" support in "main" --- src/mesa/state_tracker/st_extensions.c | 3 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 207 + 2 files changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 4:23 PM, Ilia Mirkin wrote: > On Mon, Oct 17, 2016 at 10:20 AM, Marek Olšák wrote: >> I'm adding back this: >> >>options->EmitNoMainReturn = >> !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); >> >> And: >> >> diff --git a/src/mesa/stat

Re: [Mesa-dev] [PATCH 13/14] mesa: remove gl_shader_compiler_options::EmitNoMainReturn

2016-10-17 Thread Marek Olšák
Please ignore this patch. Nouveau wants to support "return" in "main". Marek On Mon, Oct 17, 2016 at 3:39 PM, Marek Olšák wrote: > From: Marek Olšák > > it's always true > --- > src/mesa/drivers/dri/i915/i915_context.c | 1 - > src/mesa/drivers/dri/i965/brw_compiler.c | 1 - > src/mesa/mai

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #4 from Eero Tamminen --- (In reply to Suzuki, Shinji from comment #2) > The amount of memory being in use may be bounded. But I believe there are > blocks that don't get released until process termination. Having unreleased > memory

[Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Mark Thompson
The default will only be used if the VAConfigRTFormat attribute is not provided by the user. --- On 17/10/16 15:21, Julien Isorce wrote: > Hi Mark, > > Thx for the patch. I can see it has already landed. > > I just tried it with gstreamer-vaapi and it causes problem since they create > the > con

Re: [Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Roland Scheidegger
Am 17.10.2016 um 15:39 schrieb Marek Olšák: > From: Marek Olšák > > sizeof(glsl_to_tgsi_instruction): 464 -> 416 > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33 > +++--- > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/src/mesa/state_tracker

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #3 from John --- Well I tried bisecting it today assuming 11.2.2 and got nowhere so I tried at commit3a9f6283f435f90ca1a2901be39ec9d629c95bb6 and it still froze. Because of that I am not sure if that is the same problem or not...

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #4 from John --- Created attachment 127357 --> https://bugs.freedesktop.org/attachment.cgi?id=127357&action=edit A quick script I wrote to trigger the issue. It takes a video file as an input (I used an X264 mkv movie file if it ma

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Mark Thompson
On 17/10/16 15:42, Mark Thompson wrote: > The default will only be used if the VAConfigRTFormat attribute is not > provided by the user. > --- > On 17/10/16 15:21, Julien Isorce wrote: >> Hi Mark, >> >> Thx for the patch. I can see it has already landed. >> >> I just tried it with gstreamer-vaapi a

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #5 from John --- Created attachment 127358 --> https://bugs.freedesktop.org/attachment.cgi?id=127358&action=edit dmesg written by the script before I restart the machine Since there are quite some lines in dmesg about the issue, th

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #8 from John --- I'll try today to go a bit further than 11.2, if anything in the logs give you an idea of a good starting point please do share. -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 John changed: What|Removed |Added CC||john.etted...@gmail.com --- Comment #6 from John

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Julien Isorce
Hi Mark, Yes I actually saw that too in the intel driver though I think it does not add VA_RT_FORMAT_RGB32 ? Or I missed something ? Maybe this is a bug. In any case yes as said before " the intel va driver always return the full list for vpp." from vaQuerySurfaceAttributes no matter the format se

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Mark Thompson
On 17/10/16 16:13, Julien Isorce wrote: > Hi Mark, > > Yes I actually saw that too in the intel driver though I think it does not add > VA_RT_FORMAT_RGB32 ? Or I missed something ? > Maybe this is a bug. In any case yes as said before " the intel va driver > always > return the full list for vpp.

Re: [Mesa-dev] [PATCH 0/6] EGL_MESA_platform_surfaceless (v2)

2016-10-17 Thread Adam Jackson
On Fri, 2016-10-14 at 10:48 -0700, Chad Versace wrote: > Some people privately asked why we need to create this EGL platform. > I want to respond publicly. > > Mesa *already* *has* this EGL platform. In my view, the issue at hand > isn't whether to create or to not create the platform. It's whethe

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #7 from John --- Created attachment 127360 --> https://bugs.freedesktop.org/attachment.cgi?id=127360&action=edit Xorg log -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 22:53:20 +1100, Jonathan Gray wrote: > On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: > > On 17 October 2016 at 10:53, Eric Engestrom > > wrote: > > > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: > > >> On OpenBSD try to dlopen 'libglapi.so', ld.

[Mesa-dev] [PATCH 5/5] anv: setup appropriate border color structures on gen7/gen75

2016-10-17 Thread Lionel Landwerlin
Up to this point we were using the gen8+ structures. Altough this commit doesn't fixes the border color CTS tests, this is a step in the right direction to fix the following tests : dEQP-VK.pipeline.sampler.view_type.2d.format.*.address_modes.all_mode_clamp_to_border_* Signed-off-by: Lionel Landw

[Mesa-dev] [PATCH 3/5] anv: add util functions to query max bpc & integer formats

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/vk_format_info.h | 300 ++ 1 file changed, 300 insertions(+) diff --git a/src/intel/vulkan/vk_format_info.h b/src/intel/vulkan/vk_format_info.h index 5c5a1f3..0c1d865 100644 --- a/src/intel/vulkan/vk_forma

[Mesa-dev] [PATCH 2/5] intel: aubinator: decode border color

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index d716a65..cda91d1 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -265,13 +265,2

[Mesa-dev] [PATCH 4/5] anv: add dispatch macro to find right function for given generation

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_cmd_buffer.c | 33 ++--- src/intel/vulkan/anv_device.c | 19 +-- src/intel/vulkan/anv_private.h| 23 +++ 3 files changed, 30 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 0/5] Anv border colors on IVB/HSW

2016-10-17 Thread Lionel Landwerlin
Hi, Spoiler alert, this series doesn't actually make the border colors work on IvyBridge and Haswell. It still brings some useful changes (I think). On Haswell, it seems the hardware always reads the border color from the offset 0 of the "Dynamic State Memory Address", regardless of what offset i

[Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 32 src/intel/genxml/gen7.xml | 12 src/intel/genxml/gen75.xml | 40 src/intel/genxml/gen8.xml | 12 src/intel/genxml/gen9.xml |

Re: [Mesa-dev] [PATCH 6/6] anv: add dispatch macro to find right function for given generation

2016-10-17 Thread Kenneth Graunke
On Wednesday, October 12, 2016 11:28:04 PM PDT Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_cmd_buffer.c | 33 ++--- > src/intel/vulkan/anv_device.c | 19 +-- > src/intel/vulkan/anv_pipeline.c | 30 -

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 Andy Furniss changed: What|Removed |Added Attachment #127360|text/x-log |text/plain mime type|

Re: [Mesa-dev] [PATCH 1/6] intel: genxml: add SO_WRITE_OFFSET register

2016-10-17 Thread Kenneth Graunke
On Wednesday, October 12, 2016 11:27:59 PM PDT Lionel Landwerlin wrote: > One of the register we happen to program but don't have a description for > yet. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/genxml/gen6.xml | 5 + > src/intel/genxml/gen7.xml | 5 + > src/intel/genxml

Re: [Mesa-dev] [PATCH 5/6] anv: replace , with ; in anv_batch_emit()

2016-10-17 Thread Kenneth Graunke
On Wednesday, October 12, 2016 11:28:03 PM PDT Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/genX_cmd_buffer.c| 20 ++-- > src/intel/vulkan/genX_pipeline_util.h | 4 ++-- > 2 files changed, 12 insertions(+), 12 deletions(-) This patch i

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 12:04:00 +0100, Emil Velikov wrote: > On 17 October 2016 at 07:04, Tapani Pälli wrote: > > This was some kind of leftover in commit acd35c8 and format_count > > array variable (declared in outer scope) should be used instead. > > > Which brings the question - do we want to en

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 Andy Furniss changed: What|Removed |Added Attachment #127357|application/x-shellscript |text/plain mime type|

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 --- Comment #3 from Manuel Iglesias --- Created attachment 127362 --> https://bugs.freedesktop.org/attachment.cgi?id=127362&action=edit the log before the computer lock I got the same problem and i got in dmesg this before the computer crashes

Re: [Mesa-dev] [PATCH 6/6] anv: add dispatch macro to find right function for given generation

2016-10-17 Thread Jason Ekstrand
As a side-note, I pushed code on Friday that gets rid of two of these (the create_pipeline calls). I think the best way to solve emit_state_base_address is by moving a bit of code into genX_cmd_buffer.c. null surface states probably need to be moved into ISL. In other words, while it's a nice cle

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #9 from Andy Furniss --- (In reply to John from comment #4) > Created attachment 127357 [details] > A quick script I wrote to trigger the issue. For me this would use s/w dec + --vo=opengl with current mpv. I guess you have a config

[Mesa-dev] [PATCH v2] intel: aubinator: use different colors to signal batch start/end

2016-10-17 Thread Kenneth Graunke
From: Lionel Landwerlin This makes the stream of commands a bit easier to read. v2 (Ken): Use bold text on green headers for easier readability; swap the green and blue headers so the majority stay blue. Signed-off-by: Lionel Landwerlin Signed-off-by: Kenneth Graunke --- src/intel/

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #5 from Suzuki, Shinji --- (In reply to Eero Tamminen from comment #4) > Just terminate the program with a signal that Valgrind can catch, but the Thank you for the tip. Very useful when I have to wade my way through tons of false pos

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #6 from Suzuki, Shinji --- (In reply to Emil Velikov from comment #3) > Can you attach a simple program which reproduces this ? Ideally one which > does not depend on glew, in order to isolate a problem with it. Please have a look on

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #7 from Suzuki, Shinji --- Created attachment 127363 --> https://bugs.freedesktop.org/attachment.cgi?id=127363&action=edit A program to reproduce leak by calling glGetString(GL_EXTENSIONS) with core-profile -- You are receiving th

Re: [Mesa-dev] [PATCH v2] intel: aubinator: use different colors to signal batch start/end

2016-10-17 Thread Lionel Landwerlin
Hi Ken, Sure, I guess this all depends on your terminal's background color (mine is white). Let's go with your version, having some distinction already helps :) Reviewed-by: Lionel Landwerlin On 17/10/16 17:11, Kenneth Graunke wrote: From: Lionel Landwerlin This makes the stream of comman

[Mesa-dev] [PATCH] st/va: set default rt formats when calling vaCreateConfig

2016-10-17 Thread Julien Isorce
As specified in va.h, default value should be set on attributes not present in the input list. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/config.c | 9 + src/gallium/state_trackers/va/surface.c | 5 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 16:39, Eric Engestrom wrote: > On Monday, 2016-10-17 22:53:20 +1100, Jonathan Gray wrote: >> On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: >> > On 17 October 2016 at 10:53, Eric Engestrom >> > wrote: >> > > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Julien Isorce
On 17 October 2016 at 16:27, Mark Thompson wrote: > On 17/10/16 16:13, Julien Isorce wrote: > > Hi Mark, > > > > Yes I actually saw that too in the intel driver though I think it does > not add > > VA_RT_FORMAT_RGB32 ? Or I missed something ? > > Maybe this is a bug. In any case yes as said befor

  1   2   >