Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Am 06.09.2016 um 22:39 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang This patch enables variable bit-rate for vaapi encoding. According to va.h, target bit-rate equals to maximum bit-rate multiplies by target_percentage. Signed-off-by: Boyuan Zhang That was astonishing simple to fix :)

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

This series is, Acked-by: Edward O'Callaghan On 09/07/2016 02:28 PM, Timothy Arceri wrote: > The last time this was bumped we settled on 4.2.0 because OpenBSD > wasn't shipping anything greater than 4.2.1 (as that was the last > GPLv2 licensed version) however they have now imported llvm to > th

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 09/06/2016 06:06 PM, Emil Velikov wrote: On 6 September 2016 at 15:33, Chih-Wei Huang wrote: 2016-08-29 16:52 GMT+08:00 Tapani Pälli : make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise build fails with: "In file included from external/mesa/src/mesa/state_tracker/st_glsl_to_ni

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > On 06.09.2016 16:37, Martina Kollarova wrote: >> 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] >> 2. Comparison of constant -1 with expression of type 'unsigned int' is >> always >>false [-Wtautological-constant-out-of-range-c

Re: [Mesa-dev] [PATCH] doc: fix typo of GALLIUM_HUD_TOGGLE_SIGNAL

+1 for doc fixes :) Reviewed-by: Nicolai Hähnle On 07.09.2016 01:13, Christoph Haag wrote: From: Christoph Haag In the original commit message in 56a1c10 it was wrongly used too: - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- docs/envvars.html | 2 +- 1 file changed, 1 in

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

On 09/07/2016 09:56 AM, Ian Romanick wrote: On 09/06/2016 03:24 PM, Kenneth Graunke wrote: On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: Kenneth Graunke writes: Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759. While reviewing the rules, I found a cit

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On 07/09/16 04:19 AM, Christian König wrote: > Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: >> On Tue, Sep 6, 2016 at 2:22 PM, Christian König >> wrote: >>> Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: > On 05/09/16 04:37 AM, Ilia M

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

On 07.09.2016 09:38, Michel Dänzer wrote: On 07/09/16 12:29 AM, Nicolai Hähnle wrote: On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtaut

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 --- Comment #7 from Vladimir --- I can confirm this happens on Intel with mesa 12.0.2. Is this patch going to be merged? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Wed, Sep 7, 2016 at 2:23 AM, Michel Dänzer wrote: > On 06/09/16 08:33 PM, Marek Olšák wrote: >> On Sep 6, 2016 12:03 PM, "Michel Dänzer" > > wrote: >>> On 06/09/16 06:04 PM, Marek Olšák wrote: >>> > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer >

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Tue, Sep 6, 2016 at 9:19 PM, Christian König wrote: > Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: >> >> On Tue, Sep 6, 2016 at 2:22 PM, Christian König >> wrote: >>> >>> Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: > >

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

LLVM was imported yes, but the integration of it has only started around the same time and it is not enabled by default yet. And it was only imported around two days or so ago. And LLVM does not support all the architectures OpenBSD builds Mesa on. Can you point to something specific that needs a

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

On Wednesday, September 7, 2016 10:42:06 AM PDT Tapani Pälli wrote: > On 09/07/2016 09:56 AM, Ian Romanick wrote: > > On 09/06/2016 03:24 PM, Kenneth Graunke wrote: > >> On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: > >>> Kenneth Graunke writes: > >>> > Ian added this check

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 Vladimir changed: What|Removed |Added CC||vovik-...@bk.ru -- You are receiving this ma

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 07/09/16 06:02 PM, Marek Olšák wrote: > > Based on the comments so far, it looks like all annotations in the > patch are very well placed, so I don't know what the fuss is about. As I said, there's no question about the first three annotations, but for the last two we can't know whether they h

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

Hi Tapani, does moving the declaration of the dependency to src/mesa/drivers/dri/i965/Android.mk also work? Mauro LOCAL_WHOLE_STATIC_LIBRARIES := \ $(MESA_DRI_WHOLE_STATIC_LIBRARIES) \ + libmesa_genxml \ libmesa_isl ___ mesa-dev mailing list mesa-dev@li

[Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

Missing bits from 2afb950161f847d9b0a7be03dfb62cacc5ea51ba. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer wrote: > On 07/09/16 06:02 PM, Marek Olšák wrote: >> >> Based on the comments so far, it looks like all annotations in the >> patch are very well placed, so I don't know what the fuss is about. > > As I said, there's no question about the first three

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 7 September 2016 at 11:01, Mauro Rossi wrote: > Hi Tapani, > > does moving the declaration of the dependency to > src/mesa/drivers/dri/i965/Android.mk also work? > Mauro > > LOCAL_WHOLE_STATIC_LIBRARIES := \ > $(MESA_DRI_WHOLE_STATIC_LIBRARIES) \ > + libmesa_genxml \ > libmesa_isl > > Mauro, it

[Mesa-dev] GLVND EGL EGL_EXT_device_base requirement (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

[Trimming the EGL device spec authors] On 6 September 2016 at 17:16, Kyle Brenneman wrote: > > On 09/06/2016 05:29 AM, Emil Velikov wrote: >> >> * Interaction of ^^ with EGL device extension(s) - update existing >> extensions/introduce new ones >> ** Should EGL_EXT_device_enumeration expose one

[Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

Hi Mathias, On 6 September 2016 at 18:32, Mathias Fröhlich wrote: >> ** EGL_EXT_output_drm Correction - the above should read: EGL_EXT_{device,output}_drm >> *** Using/exposing the card or render node >> - Extension is designed with EGL streams in mind (using the >> primary/card node) while

[Mesa-dev] [PATCH] android: depend on libmesa_genxml from i965 Android.gen.mk

Static library dependency is required to pull the generated XML headers into the generated C file. Signed-off-by: Tapani Pälli Reviewed-by: Emil Velikov --- src/mesa/drivers/dri/i965/Android.gen.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/Android.gen.mk b

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 Timo Aaltonen changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG

[Mesa-dev] Advertising device extensions on implementation supporting both HW and SW devices (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 6 September 2016 at 18:32, Mathias Fröhlich wrote: >> * Interaction of ^^ with EGL device extension(s) - update existing >> extensions/introduce new ones >> ** Should EGL_EXT_device_enumeration expose one/multiple SW devices >> - no: we need alternative glvnd EGL interface for such cases >>

[Mesa-dev] Exposing (or lack of) EGL device support on platforms lacking DRM devices (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 6 September 2016 at 18:32, Mathias Fröhlich wrote: >> * Systems with fb only, disabled render nodes and/or alike. >> EGL implementations (in our case the libdrm API provides all the info >> about available DRM devices) can effectively detect the presence of >> HW/SW devices and expose relevan

[Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell variable are appended to the compiler and linker options specified by the OpenCL program (if any). v2: * rename to CLOVER_EXTRA_COMPILER_OPTIONS * use debug_get_option * append to linker options as well v3: code cleanups Signed-off

[Mesa-dev] [PATCH 1/4] radeonsi: clamp integer clear color values for DCC fast clear

From: Marek Olšák It should be possible to get TC-compatible fast clear more often now. --- src/gallium/drivers/radeon/r600_texture.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600

[Mesa-dev] [PATCH 4/4] radeonsi: unify si_set_optimal_micro_tile_mode call sites

From: Marek Olšák There is nothing special happening in those code blocks. --- src/gallium/drivers/radeon/r600_texture.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index e

[Mesa-dev] [PATCH 3/4] radeonsi: fix texture reinterpretation after DCC fast clear

From: Marek Olšák The problem is that TC-compatible DCC clear codes translate into different clear values when you change the format. I have a new piglit reproducing the issue. --- src/gallium/drivers/radeon/r600_texture.c | 32 +++ 1 file changed, 20 insertions(+),

[Mesa-dev] [PATCH 2/4] radeonsi: enable DCC fast clear for 128-bit formats

From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 45 ++- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index aee768f..074fed8 100644 --- a/src/gal

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

2016-09-07 12:56 GMT+02:00 Emil Velikov : > On 7 September 2016 at 11:01, Mauro Rossi wrote: > > Hi Tapani, > > > > does moving the declaration of the dependency to > > src/mesa/drivers/dri/i965/Android.mk also work? > > Mauro > > > > LOCAL_WHOLE_STATIC_LIBRARIES := \ > > $(MESA_DRI_WHOLE_STATIC_

Re: [Mesa-dev] [PATCH 2/4] radeonsi: enable DCC fast clear for 128-bit formats

On Wed, Sep 7, 2016 at 1:46 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_texture.c | 45 > ++- > 1 file changed, 32 insertions(+), 13 deletions(-) > > diff --git a/src/gallium/drivers/radeon/r600_texture.c > b/src/gallium/driv

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

On Wed, 2016-09-07 at 10:12 +0200, Nicolai Hähnle wrote: > On 07.09.2016 09:38, Michel Dänzer wrote: > > > > On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > > > > > > On 06.09.2016 16:37, Martina Kollarova wrote: > > > > > > > > 1. Variable 'hole' is uninitialized when used here [- > > > > Wuninit

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 Eero Tamminen changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #10 from Eero Tammi

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 7 September 2016 at 13:10, Mauro Rossi wrote: > 2016-09-07 12:56 GMT+02:00 Emil Velikov : >> >> On 7 September 2016 at 11:01, Mauro Rossi wrote: >> > Hi Tapani, >> > >> > does moving the declaration of the dependency to >> > src/mesa/drivers/dri/i965/Android.mk also work? >> > Mauro >> > >> >

Re: [Mesa-dev] [PATCH 2/4] radeonsi: enable DCC fast clear for 128-bit formats

On Wed, Sep 7, 2016 at 2:11 PM, Bas Nieuwenhuizen wrote: > On Wed, Sep 7, 2016 at 1:46 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_texture.c | 45 >> ++- >> 1 file changed, 32 insertions(+), 13 deletions(-) >> >> diff --g

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

On Wed, 2016-09-07 at 19:26 +1000, Jonathan Gray wrote: > LLVM was imported yes, but the integration of it has only > started around the same time and it is not enabled by default yet. > And it was only imported around two days or so ago. > Which means its a good time to start a discussion on wha

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

On 09/07/2016 12:37 PM, Kenneth Graunke wrote: On Wednesday, September 7, 2016 10:42:06 AM PDT Tapani Pälli wrote: On 09/07/2016 09:56 AM, Ian Romanick wrote: On 09/06/2016 03:24 PM, Kenneth Graunke wrote: On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: Kenneth Graunke writes

Re: [Mesa-dev] [PATCH 2/4] radeonsi: enable DCC fast clear for 128-bit formats

On Wed, Sep 7, 2016 at 3:42 PM, Marek Olšák wrote: > On Wed, Sep 7, 2016 at 2:11 PM, Bas Nieuwenhuizen > wrote: >> On Wed, Sep 7, 2016 at 1:46 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/radeon/r600_texture.c | 45 >>> ++- >>> 1

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

On 07.09.2016 14:40, Jan Vesely wrote: On Wed, 2016-09-07 at 10:12 +0200, Nicolai Hähnle wrote: On 07.09.2016 09:38, Michel Dänzer wrote: On 07/09/16 12:29 AM, Nicolai Hähnle wrote: On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [- Wuniniti

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 07.09.2016 12:23, Marek Olšák wrote: On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer wrote: On 07/09/16 06:02 PM, Marek Olšák wrote: Based on the comments so far, it looks like all annotations in the patch are very well placed, so I don't know what the fuss is about. As I said, there's no

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: > Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell > variable > are appended to the compiler and linker options specified by the > OpenCL > program (if any). > > v2: >  * rename to CLOVER_EXTRA_COMPILER_OPTIONS >  * use debug_ge

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

On Wed, 2016-09-07 at 07:38 +, Michel Dänzer wrote: > On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > > On 06.09.2016 16:37, Martina Kollarova wrote: > >> 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] > >> 2. Comparison of constant -1 with expression of type 'unsigned int'

[Mesa-dev] [PATCH] gallium: fix return value check

A possible error (-1) was being lost because it was first converted to an unsigned int and only then checked. --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/

Re: [Mesa-dev] [PATCH] gallium: fix return value check

On Wed, Sep 7, 2016 at 10:34 AM, Martina Kollarova wrote: > A possible error (-1) was being lost because it was first converted to an > unsigned int and only then checked. > --- > src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-

Re: [Mesa-dev] [PATCH] gallium: fix return value check

On Wed, 2016-09-07 at 17:34 +0300, Martina Kollarova wrote: > A possible error (-1) was being lost because it was first converted > to an > unsigned int and only then checked. > --- >  src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- >  1 file changed, 6 insertions(+), 6 deletion

[Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

From: Kyle Brenneman Only keep track of a single current context, instead of separate contexts for GL and GLES. In EGL 1.4 (and 1.5), EGL_OPENGL_API and EGL_OPENGL_ES_API are supposed to be interchangeable for all purposes except for eglCreateContext. The _EGLThreadInfo::CurrentContexts array i

[Mesa-dev] Required-for-rendering internal formats

Hello, Is there a concept in OpenGL that certain internal formats *must* be supported for rendering? An issue we're running into is that NVIDIA hardware supports sampling from RGBA4 textures, but does not support that as a render format. So if you create a tex image with GL_RGBA4, we use that as t

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: > On 07/09/16 04:19 AM, Christian König wrote: >> Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: >>> On Tue, Sep 6, 2016 at 2:22 PM, Christian König >>> wrote: Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: > On Mon, Sep 5, 2016 at 2:48 AM,

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 --- Comment #8 from Ilia Mirkin --- (In reply to Vladimir from comment #7) > I can confirm this happens on Intel with mesa 12.0.2. Is this patch going to > be merged? The situation was a bit unclear to me. Without re-reading everything, my recol

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

On Wed, Sep 07, 2016 at 11:52:39PM +1000, Timothy Arceri wrote: > On Wed, 2016-09-07 at 19:26 +1000, Jonathan Gray wrote: > > LLVM was imported yes, but the integration of it has only > > started around the same time and it is not enabled by default yet. > > And it was only imported around two days

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: > From: Kyle Brenneman > > Only keep track of a single current context, instead of separate > contexts for GL and GLES. In addition to fixing 1.4+ compliance, this fixes the "eglterminate then unbind context" piglit. Merged. - ajax

Re: [Mesa-dev] [PATCH 3/3] nir/spirv: Use fill_common_atomic_sources for image atomics

On Wed, Sep 7, 2016 at 12:45 AM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > > Am 07.09.2016 um 00:17 schrieb Jason Ekstrand: > > We had two almost identical copies of this code and they were both broken > > but in different ways. The previous two comm

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: > On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: >> On 07/09/16 04:19 AM, Christian König wrote: >>> Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: > Am 06.09.2016 um 16:23

Re: [Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

LGTM. Reviewed-by: Jason Ekstrand Maybe we should consider making the orders of arguments a bit more consistent for a few functions so that we can use fill_common_atomic_sources for load and store too. --Jason On Wed, Sep 7, 2016 at 3:10 AM, Lionel Landwerlin wrote: > Missing bits from 2afb9

Re: [Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

Thanks, I thought about that but the various nir_intrinsic_set_write_mask()/etc.. for load/store kind of discouraged me. I'll give it a try though. On 07/09/16 17:12, Jason Ekstrand wrote: LGTM. Reviewed-by: Jason Ekstrand > Maybe we should consider making the

Re: [Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

On Wed, Sep 7, 2016 at 9:17 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Thanks, > > I thought about that but the various nir_intrinsic_set_write_mask()/etc.. > for load/store kind of discouraged me. > I'll give it a try though. > I just looked a bit and it's going to be a *maj

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

Am 07.09.2016 um 17:36 schrieb Ilia Mirkin: On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mo

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

Am 07.09.2016 um 18:06 schrieb Marek Olšák: On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Wed, Sep 7, 2016 at 6:23 PM, Christian König wrote: > Am 07.09.2016 um 18:06 schrieb Marek Olšák: >> >> On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: >>> >>> On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: > > Am 06.09.2

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote: > On Tue, Sep 6, 2016 at 4:12 PM, Nanley Chery wrote: > > > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/blorp/blorp.h | 10 > > > src/intel/blorp/blorp_blit.c | 133 ++

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On 09/07/2016 04:14 PM, Jan Vesely wrote: > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell >> variable >> are appended to the compiler and linker options specified by the >> OpenCL >> program (if any). >> >> v2: >> * rename

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery wrote: > On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote: > > On Tue, Sep 6, 2016 at 4:12 PM, Nanley Chery > wrote: > > > > > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > > > > --- > > > > src/intel/blorp/blorp.h

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Wed, Sep 7, 2016 at 6:23 PM, Christian König wrote: > Am 07.09.2016 um 18:06 schrieb Marek Olšák: >> >> On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: >>> >>> On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: > > Am 06.09.2

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

On 09/07/2016 03:02 AM, Christian König wrote: Am 06.09.2016 um 22:39 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang This patch enables variable bit-rate for vaapi encoding. According to va.h, target bit-rate equals to maximum bit-rate multiplies by target_percentage. Signed-off-by: Bo

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

Hi Lionel, This patch triggered CID 1372521 in Coverity. Please let me know if my the analysis is correct below: Lionel Landwerlin writes: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load > dEQP-VK.spirv_assembly.instruction.compute.opatomic.store > > v2: do

Re: [Mesa-dev] Required-for-rendering internal formats

Dropping texturing support for RGBA4 would resolve that issue. Marek On Wed, Sep 7, 2016 at 5:43 PM, Ilia Mirkin wrote: > Hello, > > Is there a concept in OpenGL that certain internal formats *must* be > supported for rendering? An issue we're running into is that NVIDIA > hardware supports samp

[Mesa-dev] [PATCH v4] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

The options specified in the CLOVER_EXTRA_COMPILER_OPTIONS shell variable are appended to the compiler options specified by the OpenCL program, if any. Analogously, the options specified in the CLOVER_EXTRA_LINKER_OPTIONS variable are appended to the linker options. v2: * rename to CLOVER_EXTRA_C

Re: [Mesa-dev] Required-for-rendering internal formats

Right, but it'd break st/nine which doesn't (didn't?) support fallbacks like st/mesa does. I'm trying to better understand what the required logic is based on the spec, not how to fix this particular application's rendering with nouveau (which I'm much less concerned about, tbh). -ilia On Wed,

[Mesa-dev] [4.1/6] i965: Add sanity check for non-compressible texture views

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 34 1 file changed, 34 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index 054c5c8..7bd4a97 100644 ---

[Mesa-dev] [v3 4/6] i965/rbc: Consult rb settings for texture surface setup

Once mcs buffer gets allocated without delay for lossless compression (same as we do for msaa), one gets regression in: GL45-CTS.texture_barrier_ARB.same-texel-rw Setting the auxiliary surface for both sampling engine and data port seems to fix this. I haven't found any hardware documentation bac

[Mesa-dev] [v3 3/6] i965: Track non-compressible sampling of renderbuffers

v3: - Actually set the flags when needed instead of falsely overwriting them (Jason). - Use more generic name for flag (dropped RENDERBUFFER) - Consult also shader images Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.c | 32 +

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Wed, Sep 7, 2016 at 9:50 AM, Jason Ekstrand wrote: > On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery > wrote: > >> On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote: >> > On Tue, Sep 6, 2016 at 4:12 PM, Nanley Chery >> wrote: >> > >> > > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Ja

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On Wednesday 07 September 2016 18:37:51 Vedran Miletić wrote: > On 09/07/2016 04:14 PM, Jan Vesely wrote: > > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: > >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell > >> variable > >> are appended to the compiler and linker option

Re: [Mesa-dev] [PATCH v4] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

On Wednesday 07 September 2016 19:17:39 Vedran Miletić wrote: > The options specified in the CLOVER_EXTRA_COMPILER_OPTIONS shell > variable are appended to the compiler options specified by the OpenCL > program, if any. > Analogously, the options specified in the CLOVER_EXTRA_LINKER_OPTIONS > varia

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Wed, Sep 07, 2016 at 10:26:25AM -0700, Jason Ekstrand wrote: > On Wed, Sep 7, 2016 at 9:50 AM, Jason Ekstrand wrote: > > > On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery > > wrote: > > > >> On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote: > >> > On Tue, Sep 6, 2016 at 4:12 PM, Na

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On Wednesday 07 September 2016 19:28:36 Serge Martin wrote: > On Wednesday 07 September 2016 18:37:51 Vedran Miletić wrote: > > On 09/07/2016 04:14 PM, Jan Vesely wrote: > > > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: > > >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS she

[Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

use a linear buffer in case of back buffer Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 3d59

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

Bump, any interest in this? On Sat, Aug 27, 2016 at 1:09 AM, Nicholas Bishop wrote: > Hi, > > I'd like to propose a conversion of Mesa's documentation to > reStructuredText (RST) and hosting the result on readthedocs.org. The > intent is to make Mesa's documentation more accessible, searchable,

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #10 from Vedran Miletić --- (In reply to Dennis Schridde from comment #1) > Created attachment 126118 [details] [review] > mesa-12.0.1-llvm-3.9.0_rc3-compatibility.patch > > Attached patch fixes the issue. Using LLVM release_39 bran

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

Hi Mark, Thanks for the report. The assumption is that coord will be set on the image by a preceding SpvOpImageTexelPointer opcode (see top of the vtn_handle_image function). I don't think there are tests in the CTS exercising this at the moment :( - Lionel On Wed, 2016-09-07 at 10:14 -0700, Ma

Re: [Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote: > On Thu 01 Sep 2016, Jason Ekstrand wrote: > > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote: > > > > From: Chad Versace > > > > Nanley Chery (amend): > >  - Remove wip! tag > > > > Signed-off-by: Nanley Chery

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

On 09/07/2016 07:58 PM, Nicholas Bishop wrote: > Bump, any interest in this? > In my experience rST is much nicer to write than pure HTML, and I like how the output looks. Definitive yes on the rST instead of HTML, no strong opinion on readthedocs.org vs self-hosted. Regards, Vedran -- Vedran

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 09/07/2016 04:18 AM, Emil Velikov wrote: Hi Mathias, On 6 September 2016 at 18:32, Mathias Fröhlich wrote: ** EGL_EXT_output_drm Correction - the above should read: EGL_EXT_{device,output}_drm *** Using/exposing the card or render node - Extension is designed with EGL streams in mind

Re: [Mesa-dev] [PATCH 3/6] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

On Fri 02 Sep 2016, Jason Ekstrand wrote: > HiZ buffers can be multisampled and, on BDW+, simply using interleaved > multisampling with a compression block size of 8x4 samples yields the > correct HiZ surface size calculations. Unfortunately, choose_msaa_layout > was rejecting multisampled HiZ buf

Re: [Mesa-dev] [PATCH 4/6] intel/isl: Handle HiZ and CCS tiling more directly

On Fri 02 Sep 2016, Jason Ekstrand wrote: > The HiZ and CCS tiling formats are always used for HiZ and CCS surfaces > respectively. There's no reason why we should go through filter_tiling and > it's much easier to always get HiZ and CCS right if we just handle them > directly. > --- > src/intel/

Re: [Mesa-dev] [PATCH 6/6] intel/isl: Add a detailed comment about multisampling with HiZ

On Fri 02 Sep 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 60 > +++-- > 1 file changed, 58 insertions(+), 2 deletions(-) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 33e83b1..cb9eb23 100644 > --- a/src/intel/isl/

Re: [Mesa-dev] [PATCH 5/6] intel/isl: Remove tiling checks from choose_msaa_layout

On Fri 02 Sep 2016, Jason Ekstrand wrote: > We already do those checks in filter_tiling. There's no good reason to > repeat them in choose_msaa_layout. If anything they should have been > asserts and not "return false" checks. Also, this check was causing us to > outright reject multisampled HiZ

Re: [Mesa-dev] [PATCH 0/6] intel/isl: A few cleanups for multisampled HiZ

On Fri, Sep 02, 2016 at 03:50:41PM -0700, Jason Ekstrand wrote: > This series does a few cleanups to ISL so that it can actually handle > multisampled HiZ correctly. When Chad and I first discussed HiZ, we > thought it would all work out easy as ISL already had all the required > code. We were co

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

On Wed 07 Sep 2016, Adam Jackson wrote: > On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: > > From: Kyle Brenneman > > > > Only keep track of a single current context, instead of separate > > contexts for GL and GLES. > > In addition to fixing 1.4+ compliance, this fixes the "eglterminate

[Mesa-dev] [PATCH] gallium: remove PIPE_BIND_TRANSFER_READ/WRITE

From: Marek Olšák not used in any useful way --- src/gallium/auxiliary/util/u_debug.c| 2 -- src/gallium/docs/source/screen.rst | 2 -- src/gallium/drivers/freedreno/a2xx/fd2_screen.c | 5 - src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 5 - s

Re: [Mesa-dev] [PATCH 0/6] intel/isl: A few cleanups for multisampled HiZ

On Sep 7, 2016 12:27 PM, "Nanley Chery" wrote: > > On Fri, Sep 02, 2016 at 03:50:41PM -0700, Jason Ekstrand wrote: > > This series does a few cleanups to ISL so that it can actually handle > > multisampled HiZ correctly. When Chad and I first discussed HiZ, we > > thought it would all work out ea

Re: [Mesa-dev] [PATCH 6/6] intel/isl: Add a detailed comment about multisampling with HiZ

On Sep 7, 2016 12:23 PM, "Chad Versace" wrote: > > On Fri 02 Sep 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 60 +++-- > > 1 file changed, 58 insertions(+), 2 deletions(-) > > > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/is

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Sep 7, 2016 10:45 AM, "Nanley Chery" wrote: > > On Wed, Sep 07, 2016 at 10:26:25AM -0700, Jason Ekstrand wrote: > > On Wed, Sep 7, 2016 at 9:50 AM, Jason Ekstrand wrote: > > > > > On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery > > > wrote: > > > > > >> On Tue, Sep 06, 2016 at 05:02:55PM -0700,

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

On 7 September 2016 at 16:57, Adam Jackson wrote: > On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: >> From: Kyle Brenneman >> >> Only keep track of a single current context, instead of separate >> contexts for GL and GLES. > > In addition to fixing 1.4+ compliance, this fixes the "eglterm

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

On Wed, 2016-09-07 at 22:07 +0100, Emil Velikov wrote: > Was going to mention this but it slipped through. Can we get a proper > spec quote in the code ? I guess the logic through eglCreateContext (the only place where the API difference matters) is a little contorted, certainly took me more than

[Mesa-dev] [PATCH] egl: Document why EGL_OPENGL{, _ES}_API are mostly identical

Signed-off-by: Adam Jackson --- src/egl/main/eglcontext.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index ebc004d..057b60f 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -457,6 +457,16 @@ _eglPa

Re: [Mesa-dev] [v3 4/6] i965/rbc: Consult rb settings for texture surface setup

On Sep 7, 2016 10:24 AM, "Topi Pohjolainen" wrote: > > Once mcs buffer gets allocated without delay for lossless > compression (same as we do for msaa), one gets regression in: > > GL45-CTS.texture_barrier_ARB.same-texel-rw > > Setting the auxiliary surface for both sampling engine and data > port

Re: [Mesa-dev] [4.1/6] i965: Add sanity check for non-compressible texture views

On Sep 7, 2016 10:24 AM, "Topi Pohjolainen" wrote: > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 34 > 1 file changed, 34 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/d

Re: [Mesa-dev] [v3 3/6] i965: Track non-compressible sampling of renderbuffers

On Sep 7, 2016 10:24 AM, "Topi Pohjolainen" wrote: > > v3: >- Actually set the flags when needed instead of falsely > overwriting them (Jason). >- Use more generic name for flag (dropped RENDERBUFFER) >- Consult also shader images > > Signed-off-by: Topi Pohjolainen > --- > src/

  1   2   >