Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

On Mon, Dec 14, 2015 at 07:24:29AM +, Song, Ruiling wrote: > > > > -Original Message- > > From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of > > Kristian H?gsberg > > Sent: Monday, December 14, 2015 1:34 PM > > To: Song, Ruiling > > Cc: Winiarski, Michal ; intel- > >

[Mesa-dev] [PATCH v2] mesa: fix interface matching done in validate_io

Patch makes following changes for interface matching: - do not try to match builtin variables - handle swizzle in input name, as example 'a.z' should match with 'a' - check that amount of inputs and outputs matches These changes make interface matching tests to work in: ES31-CTS.

[Mesa-dev] gallium r300 driver for PowerPC

Hello, I am new to this list. I have been trying to see if I can fix or at least pin point an issue with Radeon r300 driver failing on PowerPC systems. This has been a problem for a while and I would like to help to get this fixed. I have done some debugging with valgrind and I think I may see

Re: [Mesa-dev] [PATCH 1/8] st/va: remove nonesense HEVC picture id handling

Hi, shouldn't the check be the following condition instead: hevc->ReferenceFrames[i].flags & VA_PICTURE_HEVC_INVALID || hevc->ReferenceFrames[i].picture_id == VA_INVALID_SURFACE ? On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > The picture id in this case is a V

Re: [Mesa-dev] gallium r300 driver for PowerPC

Hi, On 12/14/2015 10:44 AM, Herminio Hernandez, Jr. wrote: I am new to this list. I have been trying to see if I can fix or at least pin point an issue with Radeon r300 driver failing on PowerPC systems. This has been a problem for a while and I would like to help to get this fixed. I have do

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

On Mon, Dec 14, 2015 at 08:41:05AM +, Song, Ruiling wrote: > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Monday, December 14, 2015 4:28 PM > > To: Song, Ruiling > > Cc: k...@bitplanet.net; Winiarski, Michal

Re: [Mesa-dev] [PATCH 6/8] st/va: remove fence handling

Hi Christian, I have tested this patch but then the displayed video is garbage (mostly white and sometimes just garbage). It also stall the nouveau driver which requires to reboot but I guess this is another issue. I tested with: GST_GL_WINDOW=x11 GST_GL_PLATFORM=egl GST_GL_API=gles2 GST_DEBUG=2 L

Re: [Mesa-dev] [PATCH 3/8] st/va: clean up post process includes

This patch is: Reviewed-by: Julien Isorce Tested-by: Julien Isorce On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/postproc.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH 2/8] st/va: cleanup filter color standard handling

This patch is: Reviewed-by: Julien Isorce Tested-by: ulien Isorce On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/surface.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

This patch is: Reviewed-by: Julien Isorce On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/picture.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/state_trackers/va/pict

Re: [Mesa-dev] [PATCH 5/8] st/va: handle default post process regions

This patch is: Reviewed-by: Julien Isorce Tested-by: Julien Isorce On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Avoid referencing NULL pointers. > > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/postproc.c | 36 > +++

Re: [Mesa-dev] [PATCH 7/8] st/va: add NV12 -> NV12 post processing

This patch is: Reviewed-by: Julien Isorce Tested-by: Julien Isorce On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Usefull for mpv and GStreamer. > > Signed-off-by: Indrajit-kumar Das > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/pi

Re: [Mesa-dev] [PATCH 8/8] st/va: add BOB/WEAVE deinterlacing

This patch is: Reviewed-by: Julien Isorce Tested-by: Julien Isorce (tested with gstvaapipostproc from gstreamer-vaapi) On 11 December 2015 at 12:33, Christian König wrote: > From: Christian König > > Tested with MPV. > > Signed-off-by: Christian König > --- > src/gallium/state_trackers/va/

Re: [Mesa-dev] [PATCH v2 11/13] i965: Add tessellation evaluation shaders

Whew... I probably would have split this one into 5 or so. Then krh would have grumbled at me. ;) On 2015-12-11 13:24:00, Kenneth Graunke wrote: > The TES is essentially a post-tessellator VS, which has access to the > entire TCS output patch, and a special gl_TessCoord input. Otherwise, > they'r

Re: [Mesa-dev] [PATCH 1/8] st/va: remove nonesense HEVC picture id handling

Yeah, at least that looks sane, but I don't think just continuing with the loop is the right things to do here. E.g. if we just continue h265.ref[i] will never be initialized to something. It's either NULL, a value from the last decode or some random data. vlVaGetReferenceFrame() can handle

Re: [Mesa-dev] [PATCH v2 08/13] i965: Handle TCS outputs and TES inputs.

On Saturday, December 12, 2015 10:21:19 PM Jordan Justen wrote: > On 2015-12-11 13:23:57, Kenneth Graunke wrote: > > TCS outputs and TES inputs both refer to a common "patch URB entry" > > shared across all invocations. First, there are some number of > > per-patch entries. Then, there are per-ve

Re: [Mesa-dev] [PATCH 6/8] st/va: remove fence handling

Also note that in this pipeline, HW decoding is done with nouveau driver and rendering is done with intel. dmabuf in between. Yeah, I already thought that somebody is using it like this. I'm not sure if this is actually supposed to work because we don't have proper synchronization between kernel

[Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv84_video.c b/src/gallium/drivers/nouveau/nv50/nv84_video.c index 7a4670f..5e2489a

[Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

frame cannot be NULL in that branch. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_video.c b/src/gallium/drivers/nouveau/nouveau_video.c index 8bb12b2..

[Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c inde

[Mesa-dev] [PATCH 1/5] nv50, nvc0: fix using uninitialized value 'templ.texture' in nvXX_blit_set_src()

Field 'templ.texture' is used uninitialized when calling nvXX_create_texture_view(). Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 1 + 2 files changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 2/5] nv50, nvc0: fix potential resource leak in nvXX_create_texture_view()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_tex.c | 3 ++- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_tex.c b/src/gallium/drivers/nouv

[Mesa-dev] [PATCH 0/5] nouveau: fix some Coverity issues

Hi, This series fixes some issues spotted by Coverity. Feel free to review, Thanks. Samuel. Samuel Pitoiset (5): nv50,nvc0: fix using uninitialized value 'templ.texture' in nvXX_blit_set_src() nv50,nvc0: fix potential resource leak in nvXX_create_texture_view() nvc0: make sure gmt progra

Re: [Mesa-dev] [PATCH v2 11/13] i965: Add tessellation evaluation shaders

On Monday, December 14, 2015 01:24:37 AM Jordan Justen wrote: > Whew... I probably would have split this one into 5 or so. Then krh > would have grumbled at me. ;) Sorry! These are pretty huge. I wasn't sure how best to split it up, or how much time to spend on that. > On 2015-12-11 13:24:00, K

Re: [Mesa-dev] [PATCH v2 05/13] i965: Allocate URB space for HS and DS stages when required.

On Saturday, December 12, 2015 10:39:13 AM Jordan Justen wrote: > On 2015-12-11 13:23:54, Kenneth Graunke wrote: > > From: Chris Forbes > > > > v2: Rewrite the push constant allocation code to be clearer. > > Only apply the minimum VS entries workaround on Gen 8. > > > > Signed-off-by: Chris

Re: [Mesa-dev] [PATCH v2 05/13] i965: Allocate URB space for HS and DS stages when required.

On Friday, December 11, 2015 01:23:54 PM Kenneth Graunke wrote: > From: Chris Forbes > > v2: Rewrite the push constant allocation code to be clearer. > Only apply the minimum VS entries workaround on Gen 8. > > Signed-off-by: Chris Forbes > Signed-off-by: Kenneth Graunke > --- > src/mesa/

[Mesa-dev] [PATCH] nir: Fix number of indices on shared variable store intrinsics.

Shared variables and input reworks landed around the same time. Presumably, this was some sort of mistake in rebase conflict resolution. Found by inspection. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_intrinsics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) No effect in Jenk

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

On 14 December 2015 at 09:04, Daniel Vetter wrote: > On Mon, Dec 14, 2015 at 08:41:05AM +, Song, Ruiling wrote: >> >> >> > -Original Message- >> > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel >> > Vetter >> > Sent: Monday, December 14, 2015 4:28 PM >> > To: S

[Mesa-dev] [PATCH 1/2] i965: Use DIV_ROUND_UP() in gen7_urb.c code.

This is a newer convention, which we prefer over ALIGN(x, n) / n. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_urb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_urb.c b/src/mesa/drivers/dri/i965/gen7_u

[Mesa-dev] [PATCH 2/2] i965: Allocate URB space for HS and DS stages when required.

From: Chris Forbes v2: (by Ken, incorporating feedback from Matt Turner): - Rewrite the push constant allocation code to be clearer. - Only apply the minimum VS entries workaround on Gen 8. v3: (by Ken) - Fix a bug in v2 where we failed to allocate the full push constant space when the number

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 Vedran Miletić changed: What|Removed |Added CC||riva...@gmail.com -- You are receiving

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

Jason Ekstrand writes: > On Dec 11, 2015 5:44 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > On Dec 10, 2015 6:58 AM, "Francisco Jerez" > wrote: >> >> >> >> Jason Ekstrand writes: >> >> >> >> > We aren't using it anymore. >> >> >> >> It seems useful to me to be able to repr

Re: [Mesa-dev] [Bug 93352] GRID Autosport crashes on start of race

Hi Edwin, Thanks for reaching out to the mesa community! See my comments inline. On Mon, Dec 14, 2015 at 5:13 AM, wrote: > Comment # 20 on bug 93352 from Edwin Smith > My name is Edwin Smith and I work for Feral Interactive who make the Linux > version of the game. Thank you for fixing the issu

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Monday, December 14, 2015 4:28 PM > To: Song, Ruiling > Cc: k...@bitplanet.net; Winiarski, Michal ; > mesa-dev@lists.freedesktop.org; intel-...@lists.freedesktop.org; Ben > Wid

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Micha? Winiarski > Sent: Wednesday, September 9, 2015 10:07 PM > To: intel-...@lists.freedesktop.org > Cc: Ben Widawsky ; dri-de...@lists.freedesktop.org; > mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

> -Original Message- > From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of > Kristian H?gsberg > Sent: Monday, December 14, 2015 1:34 PM > To: Song, Ruiling > Cc: Winiarski, Michal ; intel- > g...@lists.freedesktop.org; mesa-dev@lists.freedesktop.org; Ben Widawsky > ; dri

Re: [Mesa-dev] [PATCH 1/5] nv50, nvc0: fix using uninitialized value 'templ.texture' in nvXX_blit_set_src()

While true, this isn't a real issue. view->pipe = *templ; view->pipe.reference.count = 1; view->pipe.texture = NULL; texture can be uninitialized in the template. I know that your first impulse might be "just make Coverity happy", but I don't pander to broken tools. If the report is bogu

Re: [Mesa-dev] [PATCH 2/5] nv50, nvc0: fix potential resource leak in nvXX_create_texture_view()

Again, bogus. Can't get there. I'd take a patch that asserts though, or marks it unreachable, or just drops the default case entirely. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

Bogus. obj will be null on failure. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/galliu

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #14 from Vedran Miletić --- Ronie, was this fixed? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:/

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

This code is old, crusty and subtle. Clearly this can't happen, however I'd rather not remove it... if you really hate it how about a #if 0 /* XXX */ ... #endif I have no idea what DUAL_PRIME is, or whether it appears for frame or field stuff. Or what that PMPEG command does for that matter. On

Re: [Mesa-dev] [PATCH 5/5] draw: remove clip_vertex from vertex header

The series looks good to me. Thanks for digging into this. Reviewed-by: Brian Paul On 12/11/2015 07:31 PM, srol...@vmware.com wrote: From: Roland Scheidegger vertex header had both clip_pos and clip_vertex. We only really need one (clip_pos) because the draw llvm shader would overwrite th

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/

Re: [Mesa-dev] [PATCH 5/5] draw: remove clip_vertex from vertex header

On 12/12/15 02:31, srol...@vmware.com wrote: From: Roland Scheidegger vertex header had both clip_pos and clip_vertex. We only really need one (clip_pos) because the draw llvm shader would overwrite the position output from the vs with the viewport transformed. However, we don't really need the

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: > frame cannot be NULL in that branch. Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nouveau_video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nouveau_vide

[Mesa-dev] [PATCH] docs: Replace sourceforge logo with a text link

Fixes the following Lintian (Debian package checker) error: privacy-breach-logo usr/share/doc/mesa-common-dev/contents.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) usr/share/doc/mesa-common-dev/thanks.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) The extend

Re: [Mesa-dev] [PATCH 2/5] nv50, nvc0: fix potential resource leak in nvXX_create_texture_view()

On 12/14/2015 04:01 PM, Ilia Mirkin wrote: Again, bogus. Can't get there. I'd take a patch that asserts though, or marks it unreachable, or just drops the default case entirely. Make it unreachable is fine by me. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: Spotted by Coverity

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

On 12/14/2015 04:04 PM, Ilia Mirkin wrote: Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. We already return at the same point for vertex programs, but I can definitely move this below. On Mon, De

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On 12/14/2015 04:05 PM, Ilia Mirkin wrote: Bogus. obj will be null on failure. Well, checking the return value instead of obj seems better tbh, because we do that in the rest of the code. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: Spotted by Coverity. Signed-off-by: Samue

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

On Mon, Dec 14, 2015 at 11:02 AM, Samuel Pitoiset wrote: > > > On 12/14/2015 04:04 PM, Ilia Mirkin wrote: >> >> Instead take the return value and stick it into the if below. >> Returning early from these functions isn't something we generally want >> to do. > > > We already return at the same poin

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On Mon, Dec 14, 2015 at 11:04 AM, Samuel Pitoiset wrote: > > > On 12/14/2015 04:05 PM, Ilia Mirkin wrote: >> >> Bogus. obj will be null on failure. > > > Well, checking the return value instead of obj seems better tbh, because we > do that in the rest of the code. Can ret = 0 but obj still be nul

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

On 12/14/2015 04:48 PM, Pierre Moreau wrote: On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: frame cannot be NULL in that branch. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium/drivers/ilo/shader/ilo_shader_vs.c | 4 ++-- src/gallium/drivers/ilo/shader/toy_legaliz

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxiliary/util/u_surface.c | 2 +- src/gallium/auxili

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index db53eb4..e7932bf 100644 -

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_test_blend.c | 2 +- src/gallium/drivers/llvmpipe/lp_test_conv.c | 2 +- src/ga

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c index 09c1b37..f0

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/svga/svga_tgsi_insn.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c index dbb90f7..1c7097f 10064

[Mesa-dev] Further Coccinelle inspired cleanups

The following patch series continues on what can be done with Coccinelle to clean up Mesa3D house keeping duties. On a good note we have a pretty clean tree for the fairly trivial runs so far. [PATCH 1/6] gallium: Remove unnecessary semicolons [PATCH 2/6] gallium/drivers: Remove unnecessary semi

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On 12/14/2015 05:07 PM, Ilia Mirkin wrote: On Mon, Dec 14, 2015 at 11:04 AM, Samuel Pitoiset wrote: On 12/14/2015 04:05 PM, Ilia Mirkin wrote: Bogus. obj will be null on failure. Well, checking the return value instead of obj seems better tbh, because we do that in the rest of the code

[Mesa-dev] [PATCH v2 1/3] nv50, nvc0: make use of unreachable() when invalid texture target happens

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_tex.c | 3 +-- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_tex.c b/src/gallium/drivers/nou

[Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c index

[Mesa-dev] [PATCH v2 3/3] nv50: check return value of nouveau_object_new()

When ret == 0, obj is not NULL. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv84_video.c b/src/gallium/drivers/nouveau/nv50/nv84

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

No, gp->code_size is set by the validation. You need to put that last. On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + > 1 file changed, 1 insertion(+), 4 d

Re: [Mesa-dev] [PATCH v2 3/3] nv50: check return value of nouveau_object_new()

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > When ret == 0, obj is not NULL. Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [Mesa-dev] [PATCH v2 1/3] nv50, nvc0: make use of unreachable() when invalid texture target happens

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_tex.c | 3 +-- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 4 +--- > 2 files changed, 2 insertions(+), 5

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On 11:56 AM - Dec 14 2015, Ilia Mirkin wrote: > No, gp->code_size is set by the validation. You need to put that last. IIRC, you can't assume in which order the compiler will decide to evaluate the different expressions being AND'ed. > > On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset > wrote

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On Mon, Dec 14, 2015 at 11:59 AM, Pierre Moreau wrote: > On 11:56 AM - Dec 14 2015, Ilia Mirkin wrote: >> No, gp->code_size is set by the validation. You need to put that last. > > IIRC, you can't assume in which order the compiler will decide to evaluate the > different expressions being AND'ed.

[Mesa-dev] [PATCH 1/3] mesa/main: use BITSET_FOREACH_SET in perf_monitor_result_size

From: Nicolai Hähnle This should make the code both faster and slightly clearer. --- src/mesa/main/performance_monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/performance_monitor.c b/src/mesa/main/performance_monitor.c index 98dfbea..43529b2 10

[Mesa-dev] [PATCH 3/3] radeonsi: fix perfcounter selection for SI_PC_MULTI_BLOCK layouts

From: Nicolai Hähnle The incorrectly computed register count caused lockups. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On 12/14/2015 05:56 PM, Ilia Mirkin wrote: No, gp->code_size is set by the validation. You need to put that last. Right, it's set by nvc0_program_translate(). On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/

[Mesa-dev] [PATCH 2/3] gallium/radeon: remove unnecessary test in r600_pc_query_add_result

From: Nicolai Hähnle This test is a left-over of the initial development. It is unneeded and misleading, so let's get rid of it. --- src/gallium/drivers/radeon/r600_perfcounter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_perfcounter.c b/src/gallium/dr

[Mesa-dev] [PATCH v3] nvc0: check return value of nvc0_program_validate()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c index

Re: [Mesa-dev] [PATCH v3] nvc0: check return value of nvc0_program_validate()

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 12:07 PM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/gallium/driv

Re: [Mesa-dev] gallium r300 driver for PowerPC

On 14.12.2015 04:10, Eero Tamminen wrote: On 12/14/2015 10:44 AM, Herminio Hernandez, Jr. wrote: I am new to this list. I have been trying to see if I can fix or at least pin point an issue with Radeon r300 driver failing on PowerPC systems. This has been a problem for a while and I would like t

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix perfcounter selection for SI_PC_MULTI_BLOCK layouts

On 2015-12-15 04:06, Nicolai Hähnle wrote: From: Nicolai Hähnle The incorrectly computed register count caused lockups. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gall

Re: [Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

Instead of "unsigned int" you can just use "unsigned", but this is OK. With addressing the patch 1 issue, this series is: Reviewed-by: Brian Paul On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/svga/svga_tgsi_

Re: [Mesa-dev] [PATCH 1/3] mesa/main: use BITSET_FOREACH_SET in perf_monitor_result_size

Reviewed-by: Samuel Pitoiset On 12/14/2015 06:06 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle This should make the code both faster and slightly clearer. --- src/mesa/main/performance_monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/perfo

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxil

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

"Song, Ruiling" writes: >> -Original Message- >> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel >> Vetter >> Sent: Monday, December 14, 2015 4:28 PM >> To: Song, Ruiling >> Cc: k...@bitplanet.net; Winiarski, Michal ; >> mesa-dev@lists.freedesktop.org; intel-...@l

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

"Song, Ruiling" writes: >> -Original Message- >> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of >> Kristian H?gsberg >> Sent: Monday, December 14, 2015 1:34 PM >> To: Song, Ruiling >> Cc: Winiarski, Michal ; intel- >> g...@lists.freedesktop.org; mesa-dev@lists.freede

Re: [Mesa-dev] [PATCH] docs: Replace sourceforge logo with a text link

Reviewed-by: Brian Paul On 12/14/2015 08:55 AM, Andreas Boll wrote: Fixes the following Lintian (Debian package checker) error: privacy-breach-logo usr/share/doc/mesa-common-dev/contents.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) usr/share/doc/mesa-common-dev/than

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

On 14 December 2015 at 18:11, Brian Paul wrote: > On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: >> --- a/src/gallium/auxiliary/util/u_surface.c >> +++ b/src/gallium/auxiliary/util/u_surface.c >> @@ -600,7 +600,7 @@ is_box_inside_resource(const struct pipe_resource >> *res, >> depth =

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 Bug ID: 93375 Summary: unsupported call to function erf when running GROMACS with OpenCL Product: Mesa Version: git Hardware: All OS: All Status

Re: [Mesa-dev] [PATCH 1/2] i965: Use DIV_ROUND_UP() in gen7_urb.c code.

Kenneth Graunke writes: > This is a newer convention, which we prefer over ALIGN(x, n) / n. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/gen7_urb.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

Kristian Høgsberg writes: > "Song, Ruiling" writes: > >>> -Original Message- >>> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of >>> Kristian H?gsberg >>> Sent: Monday, December 14, 2015 1:34 PM >>> To: Song, Ruiling >>> Cc: Winiarski, Michal ; intel- >>> g...@lists.

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta/generate_mipmap: Work-around GLES 1.x problem with GL_DRAW_FRAMEBUFFER

On 12/12/2015 10:50 AM, Emil Velikov wrote: > On 3 December 2015 at 23:52, Anuj Phogat wrote: >> On Thu, Dec 3, 2015 at 2:43 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> GL_DRAW_FRAMEBUFFER does not exist in OpenGL ES 1.x, and since >>> _mesa_meta_begin hasn't been called yet, we have

Re: [Mesa-dev] Mesa 11.1.0 release candidate 3

On 12/11/2015 07:08 PM, Eric Anholt wrote: > Emil Velikov writes: > >> The third release candidate for Mesa 11.1.0 is now available. > > With the kernel stuff now looking ready to merge upstream, I'd like to > merge support for vc4 based on the headed-upstream kernel ABI to the > 11.1 branch. I

Re: [Mesa-dev] [PATCH] nir: Fix number of indices on shared variable store intrinsics.

Reviewed-by: Jason Ekstrand On Mon, Dec 14, 2015 at 3:32 AM, Kenneth Graunke wrote: > Shared variables and input reworks landed around the same time. > Presumably, this was some sort of mistake in rebase conflict resolution. > > Found by inspection. > > Signed-off-by: Kenneth Graunke > --- > s

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #15 from Ronie Salgado --- > > Ronie, was this fixed? > > I did not fix my patch. Sorry, but I do not have time to work on this. Best regards, Ronie 2015-12-14 12:06 GMT-03:00 : > *Comment # 14

Re: [Mesa-dev] [PATCH v2 06/13] i965: Add tessellation shader VUE map code.

On Saturday, December 12, 2015 12:16:33 PM Jordan Justen wrote: > On 2015-12-11 13:23:55, Kenneth Graunke wrote: > > Based on a patch by Chris Forbes, but largely rewritten by Ken. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/brw_compiler.h | 20 ++- > > src/m

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 --- Comment #1 from Aaron Watry --- Looks like libclc does not yet implement the erf function. erfc is implemented, but not plain erf. The amd-builtins branch in libclc looks like there's an erf implementation that can be ported over: https://l

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

On Thu, Dec 10, 2015 at 01:08:37PM -0800, Nanley Chery wrote: > On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > > If EGL_KHR_surfaceless_context is used then glViewport can be called > > with NULL for the draw and read surfaces. This was previously causing > > a crash because the i9

Re: [Mesa-dev] [PATCH 2/2] i965: Allocate URB space for HS and DS stages when required.

Kenneth Graunke writes: > From: Chris Forbes > > v2: (by Ken, incorporating feedback from Matt Turner): > - Rewrite the push constant allocation code to be clearer. > - Only apply the minimum VS entries workaround on Gen 8. > > v3: (by Ken) > - Fix a bug in v2 where we failed to allocate the ful

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #16 from Vedran Miletić --- (In reply to Ronie Salgado from comment #15) > I did not fix my patch. Sorry, but I do not have time to work on this. In case this turns out to be necessary to make GROMACS OpenCL work, do you mind if I fi

Re: [Mesa-dev] [PATCH] nir: Fix number of indices on shared variable store intrinsics.

Kenneth Graunke writes: > Shared variables and input reworks landed around the same time. > Presumably, this was some sort of mistake in rebase conflict resolution. > > Found by inspection. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/glsl/nir/nir_intrinsics.

Re: [Mesa-dev] [Bug 93352] GRID Autosport crashes on start of race

On Mon, 2015-12-14 at 09:46 -0500, Ilia Mirkin wrote: > Hi Edwin, > > Thanks for reaching out to the mesa community! See my comments > inline. > > On Mon, Dec 14, 2015 at 5:13 AM, > wrote: > > Comment # 20 on bug 93352 from Edwin Smith > > My name is Edwin Smith and I work for Feral Interactive

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 --- Comment #2 from Vedran Miletić --- (In reply to Aaron Watry from comment #1) > Looks like libclc does not yet implement the erf function. Neat, the approach you suggest seems to be simpler than the one I had in mind, analogous to ldexp http:

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #17 from Ronie Salgado --- > > In case this turns out to be necessary to make GROMACS OpenCL work, do you > mind > if I finish your patch and make it suitable for merging (with proper credit, > of > course)? > > I don't mind. Just g

Re: [Mesa-dev] [PATCH] mesa: remove validation of shaders that should be done elsewhere

On Wed, 2015-12-09 at 00:17 +1100, Timothy Arceri wrote: > In core profile even if re-linking fails rendering shouldn't fail as > the > previous succesfully linked program will still be available. It also > shouldn't be possible to have an unlinked program as part of the > current rendering state.

  1   2   >