[Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

2015-11-12 Thread Jordan Justen
This commit accidentally used a '==' when '=' was intended. commit 96b22fb080894ba1840af2372f28a46cc0f40c76 Author: Kristian Høgsberg Kristensen Date: Wed Nov 4 14:58:54 2015 -0800 glsl: Use array deref for access to vector components Signed-off-by: Jordan Justen Cc: Kristian Høgsberg Kr

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

2015-11-12 Thread Jordan Justen
On 2015-11-11 20:57:55, Matt Turner wrote: > On Wed, Nov 11, 2015 at 8:47 PM, Ilia Mirkin wrote: > > On Nov 11, 2015 9:10 PM, "Matt Turner" wrote: > >> > >> On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen > >> wrote: > >> > diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_funct

Re: [Mesa-dev] [PATCH 7/7] [v2] i965/gen9: Support fast clears for 32b float

2015-11-12 Thread Neil Roberts
Ben Widawsky writes: > Two formats are explicitly disabled because they fail piglit tests, > LUMINANCE16F and INTENSITY16F. There is some question about the > validity of sampling from these surfaces for all gens, however, there > seem to be no other failures, so I'd prefer to leave tackling that

Re: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matrices with atomic counter buffers

2015-11-12 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Monday, November 2, 2015 12:36 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matric

[Mesa-dev] [PATCH] glsl: move ast layout qualifier handling code into its own function

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri We now also only apply these rules to variables rather than also trying to apply them to function params. --- src/glsl/ast_to_hir.cpp | 404 +--- 1 file changed, 207 insertions(+), 197 deletions(-) diff --git a/src/glsl/ast_to_hir

Re: [Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

2015-11-12 Thread Emil Velikov
On 12 November 2015 at 00:09, Matt Turner wrote: > On Wed, Nov 11, 2015 at 4:08 PM, Kenneth Graunke > wrote: >> Actually, your earlier statement: >> "if file == BAD_FILE, no other fields mean anything." >> suggests that we should change fs_reg() to simply set BAD_FILE, and >> not bother initiali

Re: [Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

2015-11-12 Thread Emil Velikov
On 11 November 2015 at 20:45, Rob Clark wrote: > On Mon, Nov 9, 2015 at 8:39 AM, Rob Clark wrote: >> On Mon, Nov 9, 2015 at 8:30 AM, Emil Velikov >> wrote: >>> On 30 October 2015 at 17:57, Emil Velikov wrote: On 19 October 2015 at 18:41, Emil Velikov wrote: > On 19 October 2015 at 17

Re: [Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

2015-11-12 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-11-12 at 00:44 -0800, Jordan Justen wrote: > This commit accidentally used a '==' when '=' was intended. > > commit 96b22fb080894ba1840af2372f28a46cc0f40c76 > Author: Kristian Høgsberg Kristensen > Date: Wed Nov 4 14:58:54 2015 -0800 > > glsl:

Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

2015-11-12 Thread Iago Toral
On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > From: Timothy Arceri > > We already give the location of the qualifier so there is > no need to list all the identifiers in the error message. However, there can be multiple layout qualifiers in the same declaration and in that case, wit

[Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Samuel Iglesias Gonsálvez
Commit 8b28b35 added 'shared' as a keyword for compute shaders but it broke the existing 'shared' layout qualifier support for uniform and shader storage blocks. This patch fixes 578 dEQP-GLES31.functional.ssbo.* tests. Signed-off-by: Samuel Iglesias Gonsálvez --- src/glsl/glsl_parser.yy | 11 +

[Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-12 Thread Samuel Iglesias Gonsálvez
'shared' was added in ARB_uniform_buffer_object and also used in ARB_shader_storage_buffer_object. A later patch will fix the shader layout qualifier regressions in dEQP. Signed-off-by: Samuel Iglesias Gonsálvez --- src/glsl/glsl_lexer.ll | 9 - 1 file changed, 8 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-12 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Samuel Iglesias Gonsálvez > Sent: Thursday, November 12, 2015 2:23 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH 1/2] glsl: enable 'shar

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Samuel Iglesias Gonsálvez > Sent: Thursday, November 12, 2015 2:23 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-12 Thread Timothy Arceri
On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" wrote: >'shared' was added in ARB_uniform_buffer_object and also used >in ARB_shader_storage_buffer_object. Hi Samuel, Shared for UBO and SSBOs is not a key word its just an identifier for a layout qualifier, are you sure you

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Timothy Arceri
On 13 November 2015 12:22:40 am AEDT, "Samuel Iglesias Gonsálvez" wrote: >Commit 8b28b35 added 'shared' as a keyword for compute shaders >but it broke the existing 'shared' layout qualifier support for >uniform and shader storage blocks. > >This patch fixes 578 dEQP-GLES31.functional.ssbo.* tes

Re: [Mesa-dev] [PATCH] egl/wayland: Ignore rects from SwapBuffersWithDamage

2015-11-12 Thread Pekka Paalanen
On Sat, 7 Nov 2015 18:34:20 + Daniel Stone wrote: > eglSwapBuffersWithDamage accepts damage-region rectangles to hint the > compositor that it only needs to redraw certain areas, which was passed > through the wl_surface_damage request, as designed. > > Wayland also offers a buffer transfor

Re: [Mesa-dev] [PATCH 00/11] i965/nir: Do texture rectangle lowering in NIR

2015-11-12 Thread Iago Toral
Patches 1-4 are, Reviewed-by: Iago Toral Quiroga Patch 5 seems to be missing. Iago On Wed, 2015-11-11 at 17:23 -0800, Jason Ekstrand wrote: > On older hardware (Iron Lake and below), we can't support texture rectangle > natively. Sandy Bridge through Haswell can support it but don't support >

Re: [Mesa-dev] [PATCH 00/11] i965/nir: Do texture rectangle lowering in NIR

2015-11-12 Thread Iago Toral
On Thu, 2015-11-12 at 16:23 +0100, Iago Toral wrote: > Patches 1-4 are, > Reviewed-by: Iago Toral Quiroga > > Patch 5 seems to be missing. Oh never mind, I've just seen your reply to the thread pointing to the repository. Iago > Iago > > On Wed, 2015-11-11 at 17:23 -0800, Jason Ekstrand wrote

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-12 Thread Samuel Iglesias Gonsálvez
On 12/11/15 15:28, Timothy Arceri wrote: > > > On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" > wrote: >> 'shared' was added in ARB_uniform_buffer_object and also used >> in ARB_shader_storage_buffer_object. > > Hi Samuel, > > Shared for UBO and SSBOs is not a key word it

Re: [Mesa-dev] [PATCH 7/7] [v2] i965/gen9: Support fast clears for 32b float

2015-11-12 Thread Ben Widawsky
On Thu, Nov 12, 2015 at 11:39:25AM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > Two formats are explicitly disabled because they fail piglit tests, > > LUMINANCE16F and INTENSITY16F. There is some question about the > > validity of sampling from these surfaces for all gens, however, th

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Samuel Iglesias Gonsálvez
On 12/11/15 15:38, Timothy Arceri wrote: > > > On 13 November 2015 12:22:40 am AEDT, "Samuel Iglesias Gonsálvez" > wrote: >> Commit 8b28b35 added 'shared' as a keyword for compute shaders >> but it broke the existing 'shared' layout qualifier support for >> uniform and shader storage blocks.

[Mesa-dev] [PATCH v2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Samuel Iglesias Gonsálvez
Commit 8b28b35 added 'shared' as a keyword for compute shaders but it broke the existing 'shared' layout qualifier support for uniform and shader storage blocks. This patch fixes 578 dEQP-GLES31.functional.ssbo.* tests. v2: - Move SHARED to interface_block_layout_qualifier (Timothy) - Don't remov

Re: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matrices with atomic counter buffers

2015-11-12 Thread Ilia Mirkin
On Mon, Nov 2, 2015 at 6:36 AM, Tapani Pälli wrote: > Patch sets matrix_stride as 0 for non matrix uniforms that are in a > atomic counter buffer. Matrix stride calculation for actual matrix > uniforms is done during link_assign_uniform_locations. > > From ARB_program_interface_query specification

[Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

2015-11-12 Thread Neil Roberts
It looks like the sampler hardware doesn't take into account the surface format when sampling a cleared color after a fast clear has been done. So for example if you clear a GL_RED surface to 1,1,1,1 then the sampling instructions will return 1,1,1,1 instead of 1,0,0,1. This patch makes it override

Re: [Mesa-dev] [PATCH 06/11] i965/nir: Split shader optimization and lowering into three satages

2015-11-12 Thread Iago Toral
s/satages/stages in the shortlog. Other than that it looks good to me: Reviewed-by: Iago Toral Quiroga On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote: > At the moment, brw_create_nir just calls the three stages in sequence so > there's not much difference. Soon, however, we will want to

Re: [Mesa-dev] [PATCH] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

2015-11-12 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Nov 11, 2015 at 11:34 PM, Iago Toral Quiroga wrote: > If a source operand in a MOV has source modifiers, then we cannot > copy-propagate it from the parent instruction and remove the MOV. > > v2: remove the check for source source modifiers from is_move() (Jas

Re: [Mesa-dev] [PATCH] egl/wayland: Ignore rects from SwapBuffersWithDamage

2015-11-12 Thread Jason Ekstrand
On Thu, Nov 12, 2015 at 6:46 AM, Pekka Paalanen wrote: > On Sat, 7 Nov 2015 18:34:20 + > Daniel Stone wrote: > >> eglSwapBuffersWithDamage accepts damage-region rectangles to hint the >> compositor that it only needs to redraw certain areas, which was passed >> through the wl_surface_damage

[Mesa-dev] [PATCH v2 3/3] nvc0/ir: add support for TGSI_SEMANTIC_HELPER_INVOCATION

2015-11-12 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 1 + sr

[Mesa-dev] [PATCH v2 1/3] glsl: add gl_HelperInvocation system value

2015-11-12 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: changed name of sysval to longer thing that matches GL name src/glsl/builtin_variables.cpp | 3 +++ src/glsl/nir/shader_enums.h| 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 3 files changed, 5 insertions(+) diff --g

[Mesa-dev] [PATCH v2 2/3] gallium: add support for gl_HelperInvocation semantic

2015-11-12 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/docs/source/tgsi.rst | 8 src/gallium/include/pipe/p_shader_tokens.h | 3 ++- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++- 4 files changed, 14 insertions(+), 2 deletions(-) dif

Re: [Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

2015-11-12 Thread Kristian Høgsberg
On Thu, Nov 12, 2015 at 12:44 AM, Jordan Justen wrote: > This commit accidentally used a '==' when '=' was intended. > > commit 96b22fb080894ba1840af2372f28a46cc0f40c76 > Author: Kristian Høgsberg Kristensen > Date: Wed Nov 4 14:58:54 2015 -0800 > > glsl: Use array deref for access to vecto

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-12 Thread Emil Velikov
Hi Sam, On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez wrote: > On 12/11/15 15:28, Timothy Arceri wrote: >> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" >> wrote: >>> 'shared' was added in ARB_uniform_buffer_object and also used >>> in ARB_shader_storage_buffer_obj

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-12 Thread Ilia Mirkin
On Tue, Nov 10, 2015 at 12:01 PM, Ian Romanick wrote: > On 11/09/2015 04:29 PM, Ilia Mirkin wrote: >> On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: >>> On 11/04/2015 03:26 PM, Ryan Houdek wrote: I'm hoping to potentially convince about lowering the minimum requirement of EXT_buffe

Re: [Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

2015-11-12 Thread Ryan Houdek
In response to using FRAG_RESULT_DATA0 for both of the builtins that the extension provides for ES2. When looking at what _mesa_BindFragDataLocationIndexed does, it binds the output variable to DATA0+colorNumber that you passed in to it, and also sets that variable to being whatever index you passe

Re: [Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

2015-11-12 Thread Ilia Mirkin
On Thu, Nov 12, 2015 at 1:02 PM, Ryan Houdek wrote: > In response to using FRAG_RESULT_DATA0 for both of the builtins that the > extension provides for ES2. > When looking at what _mesa_BindFragDataLocationIndexed does, it binds the > output variable to DATA0+colorNumber that you passed in to it,

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #57 from pavi...@yahoo.fr --- There will be a workaround in chromium and the Tooltips will work but something still need to be fixed in nouveau if I understand corrcectly ? -- You are receiving this mail because: You are the QA Conta

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #58 from Ilia Mirkin --- (In reply to paviluf from comment #57) > There will be a workaround in chromium and the Tooltips will work but > something still need to be fixed in nouveau if I understand corrcectly ? Unfortunately chrome w

Re: [Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

2015-11-12 Thread Matt Turner
On Thu, Nov 12, 2015 at 12:44 AM, Jordan Justen wrote: > This commit accidentally used a '==' when '=' was intended. > > commit 96b22fb080894ba1840af2372f28a46cc0f40c76 > Author: Kristian Høgsberg Kristensen > Date: Wed Nov 4 14:58:54 2015 -0800 > > glsl: Use array deref for access to vecto

Re: [Mesa-dev] [PATCH v2 10/18] mesa: In helpers, only check driver capability for meta

2015-11-12 Thread Nanley Chery
On Wed, Nov 11, 2015 at 3:00 PM, Chad Versace wrote: > On Fri 30 Oct 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > Make API context and version checks done by the helper functions pass > > unconditionally while meta is in progress. This transparently makes > > extension checks solely

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-12 Thread Matt Turner
On Thu, Nov 12, 2015 at 9:54 AM, Ilia Mirkin wrote: > I wonder if we'll be able to support ES 3.1 on Intel Sandy Bridge, > NVIDIA Tesla family (G80-GT218), or ATI R600/R700 GPU's, all of which > support ES 3.0 today. OTOH, they're unlikely targets for ES software. Not on Sandybridge -- no compute

Re: [Mesa-dev] [RFC 04/21] mesa/extensions: Move entries entries to seperate file

2015-11-12 Thread Matt Turner
On Thu, Oct 22, 2015 at 3:13 AM, Emil Velikov wrote: > On 19 October 2015 at 23:36, Nanley Chery wrote: >> From: Nanley Chery >> >> With this infrastructure set in place, we can now reuse the entries to >> generate useful code. >> >> Signed-off-by: Nanley Chery >> --- >> src/mesa/main/extensio

[Mesa-dev] [PATCH 1/2] radeon: fix bgrx8/xrgb8 blits

2015-11-12 Thread sroland
From: Roland Scheidegger Since d21320f6258b2e1780a15c1ca718963d8a15ca18 the same txformat table entries are used for "normal" texturing as well as for blits. However, I forgot to put in an entry for the bgrx8 (le) and xrgb8 (be) formats - the normal texturing path can't hit them because the radeo

[Mesa-dev] [PATCH 2/2] r200: fix bgrx8/xrgb8 blits

2015-11-12 Thread sroland
From: Roland Scheidegger Since 779cabfc7d022de8b7b9bc7fdac0caffa8646c51 the same txformat table entries are used for "normal" texturing as well as for blits. However, I forgot to put in an entry for the bgrx8 (le) and xrgb8 (be) formats - the normal texturing path can't hit them because the radeo

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-11-12 Thread Samuel Pitoiset
Hi Emil, On 11/10/2015 04:35 PM, Emil Velikov wrote: Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: On 10/27/2015 02:01 PM, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil Velikov wrote: On 27 October 2015 at 10:50, samuel.

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add gl_HelperInvocation system value

2015-11-12 Thread Matt Turner
Reviewed-by: Matt Turner I'll take a stab at hooking this up in the i965 backend. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/6] nir/validate: Validated dests after sources

2015-11-12 Thread Jason Ekstrand
Previously, if someone accidentally made an instruction that refers to its own SSA destination, the validator wouldn't catch it. The reason for this is that it validated the destination too early and, by the time it got to the source, the destination SSA value was already added to the set of seen

[Mesa-dev] [PATCH 4/6] nir: Add a tex_instr_is_query helper

2015-11-12 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 25 + 1 file changed, 25 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 47fc62e..53dea7f 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1038,6 +1038,31 @@ nir_tex_instr_dest_size(nir_tex_instr *instr) }

[Mesa-dev] [PATCH 5/6] nir/lower_tex: Add support for lowering texture swizzle

2015-11-12 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 13 + src/glsl/nir/nir_lower_tex.c | 67 2 files changed, 80 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 53dea7f..a07380e 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @

[Mesa-dev] [PATCH 3/6] nir: Add a ssa_def_rewrite_uses_after helper

2015-11-12 Thread Jason Ekstrand
--- src/glsl/nir/nir.c | 49 + src/glsl/nir/nir.h | 2 ++ 2 files changed, 51 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 32d8598..9b11b26 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1315,6 +1315,55 @@

[Mesa-dev] [PATCH 0/6] i965: Do textures swizzle work-arounds in NIR.

2015-11-12 Thread Jason Ekstrand
The subject says it all. This little series adds texture swizzle support to nir_lower_tex and makes the i965 driver use that instead of its own code. This approach has a few advantages: 1) It lets us share the swizzling code between both backends and with anyone else who wants it. 2) It s

[Mesa-dev] [PATCH 2/6] nir: Use instr/if_rewrite in nir_ssa_def_rewrite_uses

2015-11-12 Thread Jason Ekstrand
nir_ssa_def_rewrite_uses is one of the older helpers in NIR and predated both of those. Now it can be substantially simplified. --- src/glsl/nir/nir.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 93c18fb..32d85

[Mesa-dev] [PATCH 6/6] i965: Use NIR for lowering texture swizzle

2015-11-12 Thread Jason Ekstrand
Now that nir_lower_tex can do texture swizzle lowering, we can use that instead of repeating more-or-less the same code in both backends. This both allows us to share code and means that things like the tg4 work-arounds are somewhat simpler because they don't have to take the swizzle into account.

[Mesa-dev] [PATCH] i965: Make convert_attr_sources_to_hw_regs handle stride == 0.

2015-11-12 Thread Kenneth Graunke
This makes expressions like component(fs_reg(ATTR, n), 7) get a proper <0,1,0> region instead of the invalid <0,8,0>. Nobody uses this today, but I plan to. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 +++- 1 file changed, 11 insertions(+), 5 deletio

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-11-12 Thread Samuel Pitoiset
On 11/12/2015 08:51 PM, Samuel Pitoiset wrote: Hi Emil, On 11/10/2015 04:35 PM, Emil Velikov wrote: Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: On 10/27/2015 02:01 PM, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil Vel

Re: [Mesa-dev] [PATCH] i965: Make convert_attr_sources_to_hw_regs handle stride == 0.

2015-11-12 Thread Matt Turner
On Thu, Nov 12, 2015 at 12:18 PM, Kenneth Graunke wrote: > This makes expressions like component(fs_reg(ATTR, n), 7) get a proper > <0,1,0> region instead of the invalid <0,8,0>. > > Nobody uses this today, but I plan to. This seems like the right thing to do, but I'd appreciate holding on to thi

Re: [Mesa-dev] [PATCH v2] glsl: fix 'shared' layout qualifier related regressions

2015-11-12 Thread Timothy Arceri
Thanks. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] [v2] i965/skl: Add fast color clear infrastructure

2015-11-12 Thread Chad Versace
On Wed 11 Nov 2015, Ben Widawsky wrote: > Patch was originally called: > i965/skl: Enable fast color clears on SKL > > Skylake introduces some differences in the way that fast clears are programmed > and in the restrictions for using fast clears. Since some of these are > non-obvious, and fast cle

[Mesa-dev] [PATCH] i965/skl: Disable fast clear for formats without alpha

2015-11-12 Thread Ben Widawsky
--- Here is one proposal to fix the issue. I noticed that only formats without alpha were failing. This sucks for RGBX formats (which technically aren't fast clearable based on the surface format). The hunk for moving the format should happen regardless of this patch. Neil has another patch which

[Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for the % operator.

2015-11-12 Thread Kenneth Graunke
GLSL 4.00 and GL_ARB_gpu_shader5 introduced a new int -> uint implicit conversion rule and updated the rules for modulus to use them. (In earlier languages, none of the implicit conversion rules did anything relevant, so there was no point in applying them.) This allows expressions such as: i

Re: [Mesa-dev] [PATCH v2 01/18] mesa/extensions: Remove array sentinel

2015-11-12 Thread Roland Scheidegger
Am 11.11.2015 um 23:13 schrieb Nanley Chery: > > > On Wed, Nov 11, 2015 at 2:07 PM, Chad Versace > wrote: > > On Fri 30 Oct 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > > Simplify future updates to the

Re: [Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for the % operator.

2015-11-12 Thread Ian Romanick
On 11/12/2015 02:25 PM, Kenneth Graunke wrote: > GLSL 4.00 and GL_ARB_gpu_shader5 introduced a new int -> uint implicit > conversion rule and updated the rules for modulus to use them. (In > earlier languages, none of the implicit conversion rules did anything > relevant, so there was no point in

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] r200: fix bgrx8/xrgb8 blits

2015-11-12 Thread Ian Romanick
I'll try to swap the RV200 for the R200 next week. I'm not sure when Emil is planning the next stable release... I'll try to test before that... unless someone beats me to it. ;) On 11/12/2015 11:00 AM, srol...@vmware.com wrote: > From: Roland Scheidegger > > Since 779cabfc7d022de8b7b9bc7fdac0c

Re: [Mesa-dev] [PATCH v2 2/3] gallium: add support for gl_HelperInvocation semantic

2015-11-12 Thread Glenn Kennard
On Thu, 12 Nov 2015 18:32:25 +0100, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/docs/source/tgsi.rst | 8 src/gallium/include/pipe/p_shader_tokens.h | 3 ++- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4

[Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

2015-11-12 Thread Brian Paul
--- src/mesa/main/extensions.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h index e4671be..1615e1c 100644 --- a/src/mesa/main/extensions.h +++ b/src/mesa/main/extensions.h @@ -75,7 +75,9 @@ struct mesa_extension {

[Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

2015-11-12 Thread Nanley Chery
From: Nanley Chery Hopefully fixes the MSVC build error reported by Roland. Signed-off-by: Nanley Chery --- I'm not sure why the array size being unknown is an issue. Please let me know if this fixes the build issue. src/mesa/main/extensions.c | 2 +- src/mesa/main/extensions.h | 17 +++

[Mesa-dev] [PATCH] r600g: Support TGSI_SEMANTIC_HELPER_INVOCATION

2015-11-12 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- Maybe there is a better way to check if a thread is a helper invocation? src/gallium/drivers/r600/r600_shader.c | 83 +- 1 file changed, 72 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/

Re: [Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

2015-11-12 Thread Brian Paul
On 11/12/2015 04:03 PM, Nanley Chery wrote: From: Nanley Chery Hopefully fixes the MSVC build error reported by Roland. Signed-off-by: Nanley Chery --- I'm not sure why the array size being unknown is an issue. Please let me know if this fixes the build issue. src/mesa/main/extensions.c |

Re: [Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for the % operator.

2015-11-12 Thread Kenneth Graunke
On Thursday, November 12, 2015 02:48:34 PM Ian Romanick wrote: > On 11/12/2015 02:25 PM, Kenneth Graunke wrote: > > GLSL 4.00 and GL_ARB_gpu_shader5 introduced a new int -> uint implicit > > conversion rule and updated the rules for modulus to use them. (In > > earlier languages, none of the impli

[Mesa-dev] [PATCH 1/2] i965: Convert scalar_* flags to a scalar_stage array.

2015-11-12 Thread Kenneth Graunke
I was going to add scalar_tcs and scalar_tes flags, and then thought better of it and decided to convert this to an array. Simpler. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.h | 3 +-- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/

[Mesa-dev] [PATCH 2/2] i965: Clean up context constant initialization code.

2015-11-12 Thread Kenneth Graunke
This was getting pretty out of hand, and with compute partially in place and tessellation on the way, it was only going to get worse. This patch makes a "stage exists?" predicate and a "number of stages" count and uses them to clean up a lot of calculations. We can just loop over shader stages an

Re: [Mesa-dev] [PATCH 08/11] nir/lower_tex: Report progress

2015-11-12 Thread Kenneth Graunke
On Wednesday, November 11, 2015 05:26:28 PM Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 2 +- > src/glsl/nir/nir_lower_tex.c | 19 +++ > 2 files changed, 16 insertions(+), 5 deletions(-) (a bit of drive by reviewing, since we talked about patch 10 on IRC) Patche

Re: [Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

2015-11-12 Thread Emil Velikov
On 12 November 2015 at 22:59, Brian Paul wrote: > --- > src/mesa/main/extensions.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h > index e4671be..1615e1c 100644 > --- a/src/mesa/main/extensions.h > +++ b/src/mes

[Mesa-dev] [PATCH] nir: Add helpers for getting input/output intrinsic sources.

2015-11-12 Thread Kenneth Graunke
With the many variants of IO intrinsics, particular sources are often in different locations. It's convenient to say "give me the indirect offset" or "give me the vertex index" and have it just work, without having to think about exactly which kind of intrinsic you have. Signed-off-by: Kenneth Gr

[Mesa-dev] [PATCH 4/5] nv50: expose two groups of compute-related MP perf counters

2015-11-12 Thread Samuel Pitoiset
This turns on GL_AMD_performance_monitor which needs at least one group of GPU counters to be enabled. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 55 ++ src/gallium/drivers/nouveau/nv50/nv50_query.h | 6 +++ .../drivers/nouve

[Mesa-dev] [PATCH 2/5] nv50: add compute-related MP perf counters on G84+

2015-11-12 Thread Samuel Pitoiset
These compute-related MP performance counters have been reverse engineered using CUPTI which is part of NVIDIA CUDA. As for nvc0, we use a compute kernel to read out those performance counters, and the command stream to configure them. Note that Tesla only exposes 4 MP performance counters, while

[Mesa-dev] [PATCH 3/5] nv50: add support for performance metrics on G84+

2015-11-12 Thread Samuel Pitoiset
Currently only one metric is exposed but more will be added later. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 19 +- .../drivers/nouveau/nv50/nv50_query_hw_metric.c

[Mesa-dev] [PATCH 5/5] docs: mark GL_AMD_performance_monitor for nv50

2015-11-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 82ee3c4..14dc5e4 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -63,6 +63,7 @@ Note: some of the

[Mesa-dev] [PATCH 0/5] nv50: compute support & some perf counters

2015-11-12 Thread Samuel Pitoiset
Hi there, The first patch of this series implements a basic compute support which allows to launch simple kernels on NV50 (Tesla). The other patches add some compute-related MP performance counters that will enable GL_AMD_performance_monitor on Tesla at the end of the series. This has been fully

[Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

2015-11-12 Thread Samuel Pitoiset
This adds the ability to launch simple compute kernels like the one I will use to read out MP performance counters in the upcoming patch. This compute support is based on the work of Francisco Jerez (aka curro) that he did as part of his EVoC project in 2011/2012 to get OpenCL working on Tesla. Hi

Re: [Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

2015-11-12 Thread Roland Scheidegger
Am 12.11.2015 um 23:59 schrieb Brian Paul: > --- > src/mesa/main/extensions.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h > index e4671be..1615e1c 100644 > --- a/src/mesa/main/extensions.h > +++ b/src/mesa/mai

Re: [Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

2015-11-12 Thread Nanley Chery
On Thu, Nov 12, 2015 at 3:17 PM, Brian Paul wrote: > On 11/12/2015 04:03 PM, Nanley Chery wrote: > >> From: Nanley Chery >> >> Hopefully fixes the MSVC build error reported by Roland. >> >> Signed-off-by: Nanley Chery >> --- >> >> I'm not sure why the array size being unknown is an issue. Pleas

Re: [Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

2015-11-12 Thread Ilia Mirkin
On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: > +static bool > +nv50_compute_validate_program(struct nv50_context *nv50) > +{ > + struct nv50_program *prog = nv50->compprog; > + > + if (prog->mem) > + return true; > + > + if (!prog->translated) { > + prog->translated = nv

Re: [Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

2015-11-12 Thread Samuel Pitoiset
On 11/13/2015 01:15 AM, Ilia Mirkin wrote: On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: +static bool +nv50_compute_validate_program(struct nv50_context *nv50) +{ + struct nv50_program *prog = nv50->compprog; + + if (prog->mem) + return true; + + if (!prog->translated) {

Re: [Mesa-dev] [PATCH 2/2] i965: Clean up context constant initialization code.

2015-11-12 Thread Kenneth Graunke
On Thursday, November 12, 2015 03:38:52 PM Kenneth Graunke wrote: [snip] > - ctx->Const.MaxDualSourceDrawBuffers = 1; > - ctx->Const.MaxDrawBuffers = BRW_MAX_DRAW_BUFFERS; > - ctx->Const.Program[MESA_SHADER_FRAGMENT].MaxTextureImageUnits = > max_samplers; > - ctx->Const.MaxTextureCoordUnit

Re: [Mesa-dev] [PATCH 5/5] docs: mark GL_AMD_performance_monitor for nv50

2015-11-12 Thread Ilia Mirkin
On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > docs/relnotes/11.1.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html > index 82ee3c4..14dc5e4 100644 > --- a/docs/relnotes/11.1.0.h

Re: [Mesa-dev] [PATCH 1/4] nir/lower_io: Use load_per_vertex_input intrinsics for TCS and TES.

2015-11-12 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 1:21 AM, Kenneth Graunke wrote: > Tessellation control shader inputs are an array indexed by the vertex > number, like geometry shader inputs. There aren't per-patch TCS inputs. > > Tessellation evaluation shaders have both per-vertex and per-patch > inputs. Per-vertex in

Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

2015-11-12 Thread Timothy Arceri
On Thu, 2015-11-12 at 13:59 +0100, Iago Toral wrote: > On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > > From: Timothy Arceri > > > > We already give the location of the qualifier so there is > > no need to list all the identifiers in the error message. > > However, there can be multi

Re: [Mesa-dev] [PATCH 2/4] nir/lower_io: Introduce nir_store_per_vertex_output intrinsics.

2015-11-12 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 1:21 AM, Kenneth Graunke wrote: > Similar to nir_load_per_vertex_input, but for outputs. This is not > useful in geometry shaders, but will be useful in tessellation shaders. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir_intrinsics.h | 1 + > src/glsl/nir/

[Mesa-dev] [PATCH 5/8] glsl: use better location in struct and block error messages

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri Previously we only gave the location for some members and never gave the variable location. In those cases we were just giving the location of the struct/block. --- src/glsl/ast_to_hir.cpp | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/gls

[Mesa-dev] [PATCH 4/8] glsl: only do type and qualifier validation once per declaration

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri For struct and block members previously we were doing it for every variable declaration. So for example struct S { atomic_uint x, y, z; }; Would previously generate three error messages when one is sufficient. --- src/glsl/ast_to_hir.cpp | 196 --

[Mesa-dev] [PATCH 3/8] glsl: rename function that processes struct and iface members

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 60f415d..3cd7a88 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/as

[Mesa-dev] [PATCH 6/8] glsl: cleanup and fix validate matrix function for arrays

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri Previously if the member was an array of matrices then a warning message would be incorrectly given. Also the struct case could never be met so it has been removed. --- src/glsl/ast_to_hir.cpp | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/s

[Mesa-dev] ast clean-up and fixes

2015-11-12 Thread Timothy Arceri
This is a bunch of clean ups and some small fixes I noticed while getting ready to add arb_enhanced_layouts support. No regressions after runnning on Intels CI system. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

[Mesa-dev] [PATCH 7/8] glsl: remove temp variable to make code easier to read

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 3cc60a9..75da399 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5992,20 +5992,17

[Mesa-dev] [PATCH 8/8] glsl: don't validate binding when its not needed

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri Checking that the flag has been set is all the validation thats needed here. Also not calling the binding validation function will make things much simpler when adding compile time constant support as we won't need to resolve the binding value. --- src/glsl/ast_to_hir.cpp |

[Mesa-dev] [PATCH 2/8] glsl: move block validation outside function that validates members

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f4c53b4..60f415d 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5816,14 +5816,6 @@

[Mesa-dev] [PATCH 1/8] glsl: move ast layout qualifier handling code into its own function

2015-11-12 Thread Timothy Arceri
From: Timothy Arceri We now also only apply these rules to variables rather than also trying to apply them to function params. --- src/glsl/ast_to_hir.cpp | 404 +--- 1 file changed, 207 insertions(+), 197 deletions(-) diff --git a/src/glsl/ast_to_hir

Re: [Mesa-dev] [PATCH 3/4] nir: Allow outputs reads and add the relevant intrinsics.

2015-11-12 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 1:21 AM, Kenneth Graunke wrote: > Normally, we rely on nir_lower_outputs_to_temporaries to create shadow > variables for outputs, buffering the results and writing them all out > at the end of the program. However, this is infeasible for tessellation > control shader outpu

Re: [Mesa-dev] [PATCH] nir: Add helpers for getting input/output intrinsic sources.

2015-11-12 Thread Jason Ekstrand
I didn't double-check all your indices, but I like it. Reviewed-by: Jason Ekstrand The other four can also have my R-B conditional on the little rework I suggested. --Jason On Thu, Nov 12, 2015 at 4:03 PM, Kenneth Graunke wrote: > With the many variants of IO intrinsics, particular sources are

[Mesa-dev] [PATCH] i965/fs: Replace nested ternary with if ladder.

2015-11-12 Thread Matt Turner
Since the types of the expression were bool ? src_reg : (bool ? brw_reg : brw_reg) the result of the second (nested) ternary would be implicitly converted to a src_reg by the src_reg(struct brw_reg) constructor. I.e., bool ? src_reg : src_reg(bool ? brw_reg : brw_reg) In the next patch, I

  1   2   >