[Mesa-dev] [PATCH] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-10 Thread Kenneth Graunke
We basically just need to uncomment Ben's code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src/mesa/drivers/dri/i965/gen6_queryobj.c index 9f

[Mesa-dev] [Bug 92278] Black screen in War Thunder

2015-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92278 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-10 Thread Iago Toral
On Mon, 2015-11-09 at 16:52 +0100, Iago Toral wrote: > On Wed, 2015-11-04 at 15:33 -0800, Kristian Høgsberg Kristensen wrote: > > All GLSL IR consumers run this lowering pass so we can move it to the > > linker. This moves the pass up quite a bit, but that's the point: it > > needs to run before we

Re: [Mesa-dev] [PATCH] i965: Print force_writemask_all in dump_instructions().

2015-11-10 Thread Matt Turner
On Mon, Nov 9, 2015 at 11:55 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mes

Re: [Mesa-dev] [PATCH 08/23] i965: Don't pollute the buffer object namespace in brw_meta_fast_clear

2015-11-10 Thread Abdiel Janulgue
On 11/10/2015 02:56 AM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear about h

Re: [Mesa-dev] [PATCH 02/23] mesa: Make bind_vertex_buffer avilable outside varray.c

2015-11-10 Thread Abdiel Janulgue
On 11/10/2015 02:56 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/main/varray.c | 29 +++-- > src/mesa/main/varray.h | 7 +++ > 2 files changed, 22 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/main/varra

[Mesa-dev] [PATCH] i965: Print input/output VUE maps on INTEL_DEBUG=vs, gs.

2015-11-10 Thread Kenneth Graunke
I've been carrying around a patch to do this for the last few months, and it's been exceedingly useful for debugging GS and tessellation problems. I've caught lots of bugs by inspecting the interface expectations of two adjacent stages. It's not that much spam, so I figure we may as well just pri

Re: [Mesa-dev] [PATCH] i965: Print force_writemask_all in dump_instructions().

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 12:41:47 AM Matt Turner wrote: > On Mon, Nov 9, 2015 at 11:55 PM, Kenneth Graunke > wrote: > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ > > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ > > 2 files changed, 6 inse

Re: [Mesa-dev] [PATCH v4 0/6] nouveau: add support for vaapi

2015-11-10 Thread Julien Isorce
Hi, I found some difference in the content of dec->bsp_bo[i], for h264 when using st/vdpau (ok) and st/vaapi (ko). In src/gallium/state_trackers/va/picture.c, at least the reference frames are not set. At minimum it is missing something like the following though still not enough: @@ -193,7 +194,

Re: [Mesa-dev] nir/i965: Source modifiers on vecN opcodes

2015-11-10 Thread Iago Toral
On Mon, 2015-11-09 at 12:27 -0500, Connor Abbott wrote: > On Mon, Nov 9, 2015 at 10:41 AM, Jason Ekstrand wrote: > > > > On Nov 9, 2015 7:24 AM, "Connor Abbott" wrote: > >> > >> On Mon, Nov 9, 2015 at 6:55 AM, Iago Toral wrote: > >> > Hi, > >> > > >> > Currently, NIR defines vecN operations as u

[Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Kenneth Graunke
Inspired by a patch by Fabian Bieler. Fabian defined a _3DPRIM_PATCHLIST_0 macro (which isn't actually a valid topology type); I instead chose to make a macro that takes an argument. He also took the number of patch vertices from _mesa_prim (which was set to ctx->TessCtrlProgram.patch_vertices) -

[Mesa-dev] [PATCH 4/4] nir: Don't lower TCS outputs to temporaries.

2015-11-10 Thread Kenneth Graunke
We'd like to shadow these when possible, but the current code doesn't work properly for TCS outputs. For now, disable it. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_lower_outputs_to_temporaries.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/nir/nir_lower_outputs_to_t

[Mesa-dev] [PATCH 1/4] nir/lower_io: Use load_per_vertex_input intrinsics for TCS and TES.

2015-11-10 Thread Kenneth Graunke
Tessellation control shader inputs are an array indexed by the vertex number, like geometry shader inputs. There aren't per-patch TCS inputs. Tessellation evaluation shaders have both per-vertex and per-patch inputs. Per-vertex inputs get the new intrinsics; per-patch inputs continue to use the

[Mesa-dev] [PATCH 2/4] nir/lower_io: Introduce nir_store_per_vertex_output intrinsics.

2015-11-10 Thread Kenneth Graunke
Similar to nir_load_per_vertex_input, but for outputs. This is not useful in geometry shaders, but will be useful in tessellation shaders. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_intrinsics.h | 1 + src/glsl/nir/nir_lower_io.c | 27 ++- src/glsl/nir/nir_pr

[Mesa-dev] [PATCH 3/4] nir: Allow outputs reads and add the relevant intrinsics.

2015-11-10 Thread Kenneth Graunke
Normally, we rely on nir_lower_outputs_to_temporaries to create shadow variables for outputs, buffering the results and writing them all out at the end of the program. However, this is infeasible for tessellation control shader outputs. Tessellation control shaders can generate multiple output ve

Re: [Mesa-dev] [PATCH v4 0/6] nouveau: add support for vaapi

2015-11-10 Thread Ilia Mirkin
On Tue, Nov 10, 2015 at 4:09 AM, Julien Isorce wrote: > Hi, > > I found some difference in the content of dec->bsp_bo[i], for h264 when > using st/vdpau (ok) and st/vaapi (ko). > > In src/gallium/state_trackers/va/picture.c, at least the reference frames > are not set. At minimum it is missing som

Re: [Mesa-dev] FOSDEM16: Graphics DevRoom: call for speakers.

2015-11-10 Thread Luc Verhaegen
On Mon, Nov 09, 2015 at 03:42:17PM -0800, Ian Romanick wrote: > On 10/31/2015 09:43 AM, Luc Verhaegen wrote: > > > > Like the last few years, the pentabarf system will be used for talk > > Properly pronounced like "pent up barf." It seems like they should have > a "Replace pentabarf" BoF to jus

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ryan Houdek
In particular I was thinking about a3xx hardware that most likely can't physically support ES 3.1, and also drivers that may not get it for a long while. On Mon, Nov 9, 2015 at 6:29 PM, Ilia Mirkin wrote: > On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: > > On 11/04/2015 03:26 PM, Ryan Hou

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #6 from Emil Velikov --- (In reply to Giulio Camuffo from comment #5) > (In reply to Daniel Stone from comment #2) > > I think that commit is a a red herring. 0x3098 is > > EGL_CONTEXT_CLIENT_VERSION, and Mesa has recently gained more

[Mesa-dev] [PATCH v2] st/omx: straighten get/put_screen

2015-11-10 Thread Emil Velikov
The current code is busted in a number of ways. - initially checks for omx_display (rather than omx_screen), which may or may not be around. - blindly feeds the empty env variable string to loader_open_device() - reads the env variable every time get_screen is called - the latter manifests int

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Iago Toral
On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: > From: Iago Toral Quiroga > > We will need this later on when we implement proper support for > precision qualifiers in the drivers and also to do link time checks for > uniforms as indicated by the spec. > > This patch also adds compile-ti

Re: [Mesa-dev] [PATCH 6/7] glsl: do not loose precision information when packing varyings

2015-11-10 Thread Iago Toral
s/loose/lose Reviewed-by: Iago Toral Quiroga On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: > This information will be used by cross stage validation of varyings > for pipeline objects. > > Signed-off-by: Tapani Pälli > --- > src/glsl/lower_packed_varyings.cpp | 1 + > 1 file changed,

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Tapani Pälli
On 11/10/2015 12:26 PM, Iago Toral wrote: On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: From: Iago Toral Quiroga We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec.

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Iago Toral
On Tue, 2015-11-10 at 12:41 +0200, Tapani Pälli wrote: > > On 11/10/2015 12:26 PM, Iago Toral wrote: > > On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: > >> From: Iago Toral Quiroga > >> > >> We will need this later on when we implement proper support for > >> precision qualifiers in the

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-11-10 Thread Ilia Mirkin
On Tue, Sep 15, 2015 at 12:51 AM, Ilia Mirkin wrote: > On Tue, Sep 15, 2015 at 12:41 AM, Tapani Pälli wrote: >> >> >> On 09/15/2015 12:43 AM, Ilia Mirkin wrote: >>> >>> On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/glsl/builtin_vari

Re: [Mesa-dev] [PATCH 1/7] radeonsi: initialize SX_PS_DOWNCONVERT to 0 on Stoney

2015-11-10 Thread Marek Olšák
On Mon, Nov 9, 2015 at 1:05 PM, Emil Velikov wrote: > On 8 November 2015 at 21:45, Marek Olšák wrote: >> From: Marek Olšák >> >> otherwise the SX or CB blocks can go bananas >> --- > > Should we get this into stable as well, considering Alex requested > that we have Stoney support there ? It see

Re: [Mesa-dev] [PATCH 7/7] mesa: validate precision of varyings during ValidateProgramPipeline

2015-11-10 Thread Iago Toral
On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: > Fixes following failing ES3.1 CTS tests: > >ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingFloat >ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingInt >ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingUInt > > Signed-off-by: T

Re: [Mesa-dev] [PATCH 7/7] mesa: validate precision of varyings during ValidateProgramPipeline

2015-11-10 Thread Iago Toral
On Tue, 2015-11-10 at 12:10 +0100, Iago Toral wrote: > On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: > > Fixes following failing ES3.1 CTS tests: > > > >ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingFloat > >ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingInt > >ES31-CTS.s

Re: [Mesa-dev] [PATCH 2/7] glsl: Add default precision qualifiers to the symbol table

2015-11-10 Thread Iago Toral
On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: > From: Iago Toral Quiroga > > The GLSL ES spec specifies default precision qualifiers for certain types, > so populate the symbol table with these. > > Notice that the desktop GLSL spec also indicates defaults for some types > but this is n

Re: [Mesa-dev] [PATCH 6/7] gallium/radeon: remove predicate_drawing flag

2015-11-10 Thread Marek Olšák
On Mon, Nov 9, 2015 at 10:55 AM, Nicolai Hähnle wrote: > On 08.11.2015 22:48, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/r600/r600_hw_context.c| 2 +- >> src/gallium/drivers/r600/r600_state_common.c | 2 +- >> src/gallium/drivers/radeon/r600_pipe_common.h

Re: [Mesa-dev] [PATCH 7/7] mesa: validate precision of varyings during ValidateProgramPipeline

2015-11-10 Thread Tapani Pälli
On 11/10/2015 01:15 PM, Iago Toral wrote: On Tue, 2015-11-10 at 12:10 +0100, Iago Toral wrote: On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: Fixes following failing ES3.1 CTS tests: ES31-CTS.sepshaderobjs.InterfacePrecisionMatchingFloat ES31-CTS.sepshaderobjs.InterfacePrecis

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-11-10 Thread Tapani Pälli
On 11/10/2015 01:06 PM, Ilia Mirkin wrote: On Tue, Sep 15, 2015 at 12:51 AM, Ilia Mirkin wrote: On Tue, Sep 15, 2015 at 12:41 AM, Tapani Pälli wrote: On 09/15/2015 12:43 AM, Ilia Mirkin wrote: On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/

Re: [Mesa-dev] [PATCH 7/7] mesa: validate precision of varyings during ValidateProgramPipeline

2015-11-10 Thread Iago Toral
On Tue, 2015-11-10 at 13:34 +0200, Tapani Pälli wrote: > > On 11/10/2015 01:15 PM, Iago Toral wrote: > > On Tue, 2015-11-10 at 12:10 +0100, Iago Toral wrote: > >> On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote: > >>> Fixes following failing ES3.1 CTS tests: > >>> > >>> ES31-CTS.sepshade

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-11-10 Thread Timothy Arceri
On 10 November 2015 10:06:49 pm AEDT, Ilia Mirkin wrote: >On Tue, Sep 15, 2015 at 12:51 AM, Ilia Mirkin >wrote: >> On Tue, Sep 15, 2015 at 12:41 AM, Tapani Pälli > wrote: >>> >>> >>> On 09/15/2015 12:43 AM, Ilia Mirkin wrote: On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin >wrote: >

Re: [Mesa-dev] [PATCH 3/3] i965/nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

2015-11-10 Thread Eduardo Lima Mitev
I realized that patch 1/2 hasn't been reviewed, and this one didn't get R-b. Any objection to these two? thanks, Eduardo On 10/23/2015 05:55 PM, Eduardo Lima Mitev wrote: > When both fadd and fmul instructions have at least one operand that is a > constant and it is only used once, the total numb

Re: [Mesa-dev] [PATCH V2 01/12] glsl: simplify interface block stream qualifier validation

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > Qualifiers on member variables are redundent all we need to do > if check if it matches the stream associated with the block and > throw an error if its not. > > Cc: Samuel Iglesias Gonsalvez > Cc: Emil Velikov > ---

Re: [Mesa-dev] [PATCH V2 02/12] mesa: add ARB_enhanced_layouts

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > --- > src/glsl/glcpp/glcpp-parse.y| 1 + > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h | 2 ++ > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 5 file

Re: [Mesa-dev] [PATCH V2 03/12] glsl: add helper to check for enhanced layouts support

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > --- > src/glsl/glsl_parser_extras.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h > index 684b917..1d8c1b8 100644 > --- a/src/glsl/glsl_pars

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

2015-11-10 Thread Martin Peres
On 09/10/15 08:55, Dave Airlie wrote: On 9 October 2015 at 13:30, Boyan Ding wrote: 2015-10-09 8:38 GMT+08:00 Dave Airlie : From: Dave Airlie So I've known this was broken before, cogl has a workaround for it from what I know, but with the gallium based swrast drivers BlitFramebuffer from ba

Re: [Mesa-dev] [PATCH V2 04/12] glsl: add layout qualifier validation to the ast for vars

2015-11-10 Thread Emil Velikov
Hi Tim, On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preparation for compile-time constant support, > a later patch will remove validation from the parser. Thanks for splitting these up. The approach you opted for seems rather nasty way imho. Let me e

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Marek Olšák
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote: > The goal is to allow the pipe driver to request something other than > TGSI, but detect whether what is getting is TGSI vs what it requested. > The pipe drivers will always have to support TGSI (and convert that into > whatever it is that they pre

Re: [Mesa-dev] [RFCv2 02/13] gallium: add NIR as a possible IR

2015-11-10 Thread Marek Olšák
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote: > --- > src/gallium/include/pipe/p_defines.h | 1 + > src/gallium/include/pipe/p_state.h | 7 +++ > 2 files changed, 8 insertions(+) > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/include/pipe/p_defines.h > index 0a9d9

Re: [Mesa-dev] [PATCH V2 05/12] glsl: add layout qualifier validation for the shader outside the parser

2015-11-10 Thread Emil Velikov
Hi Tim, On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preparation for compile-time constant support, a later patch > will remove the validation from the shader. > > The global shader layout qualifiers will now mostly be validated in > glsl_parser_extras

Re: [Mesa-dev] [PATCH V2 06/12] glsl: remove layout qualifier validation from the parser

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > Now that we have added validation elsewhere we can remove it from > the parser. Despite the comments that cover the last few patches (04-06 incl.) these look functionally correct, and if others disagree with my suggesti

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This helper is similar to the function added as part of the > ast_layout_expression class but will be used when only the > ast_expression type is required for the qualifier. > > ast_expression is used if qualifier can't

Re: [Mesa-dev] [PATCH V2 07/12] glsl: add new type from compile time constants

2015-11-10 Thread Emil Velikov
Hi Tim, On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > In this patch we introduce a new ast type for holding the new > compile-time constant expressions. The main reason for this is that > we can no longer do merging of layout qualifiers before they have been > con

Re: [Mesa-dev] [PATCH V2 10/12] glsl: add support for complie-time constant expressions

2015-11-10 Thread Emil Velikov
Hi Tim, Mostly trivial suggestions, and one bug caught :-) On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This patch replaces the old interger constant qualifiers with either typo "integer" > the new ast_layout_expression type if the qualifier requires merging > o

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This helper is similar to the function added as part of the > ast_layout_expression class but will be used when only the > ast_expression type is required for the qualifier. > > ast_expression is used if qualifier can't

Re: [Mesa-dev] [PATCH V2 11/12] glsl: add subroutine index qualifier support

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > ARB_explicit_uniform_location allows the index for subroutine functions > to be explicitly set in the shader. > > This patch reduces the restriction on the index qualifier in > validate_layout_qualifiers() to allow it t

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Rob Clark
On Tue, Nov 10, 2015 at 7:24 AM, Marek Olšák wrote: >> +/** >> + * The 'ir' parameter identifies whether the shader state contains TGSI >> + * tokens, etc. If the driver returns 'PIPE_SHADER_IR_TGSI' for the >> + * 'PIPE_SHADER_CAP_PREFERRED_IR' shader param, the ir will *always* be >> + * 'PIPE_

Re: [Mesa-dev] [PATCH v3] gallium/hud: control visibility at startup and runtime.

2015-11-10 Thread Brian Paul
On 11/09/2015 10:20 PM, Jimmy Berry wrote: On Mon, Nov 9, 2015 at 11:28 AM, Brian Paul wrote: On 11/07/2015 09:05 PM, Jimmy Berry wrote: - env GALLIUM_HUD_VISIBLE: control default visibility - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- docs/envvars.html

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-11-10 Thread Emil Velikov
Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: > On 10/27/2015 02:01 PM, samuel.pitoiset wrote: >> On 27/10/2015 12:52, Emil Velikov wrote: >>> >>> On 27 October 2015 at 10:50, samuel.pitoiset >>> wrote: On 27/10/2015 11

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Brian Paul
On 11/08/2015 01:12 PM, Rob Clark wrote: The goal is to allow the pipe driver to request something other than TGSI, but detect whether what is getting is TGSI vs what it requested. The pipe drivers will always have to support TGSI (and convert that into whatever it is that they prefer), but in so

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Marek Olšák
In my opinion, glsl_to_nir should be in its own file and independent of glsl_to_tgsi. Marek On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 > - > src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + > src/mes

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Roland Scheidegger
Am 10.11.2015 um 15:41 schrieb Rob Clark: > On Tue, Nov 10, 2015 at 7:24 AM, Marek Olšák wrote: >>> +/** >>> + * The 'ir' parameter identifies whether the shader state contains TGSI >>> + * tokens, etc. If the driver returns 'PIPE_SHADER_IR_TGSI' for the >>> + * 'PIPE_SHADER_CAP_PREFERRED_IR' sha

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Connor Abbott
On Sun, Nov 8, 2015 at 3:12 PM, Rob Clark wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 > - > src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + > src/mesa/state_tracker/st_program.c| 118 +++-- > src/mesa/state_tracker/st_program.h

[Mesa-dev] [Bug 92869] OpenGL ES 3.0 context creation failure

2015-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92869 --- Comment #3 from Jose Fonseca --- I believe that there was a problem with xserver's glx/createcontext.c Ian mentioned on http://lists.freedesktop.org/archives/mesa-dev/2015-April/082010.html but it has been fixed http://lists.freedesk

Re: [Mesa-dev] [PATCH] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-10 Thread Ben Widawsky
On Mon, Nov 09, 2015 at 11:59:43PM -0800, Kenneth Graunke wrote: > We basically just need to uncomment Ben's code. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drive

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Rob Clark
On Tue, Nov 10, 2015 at 10:59 AM, Connor Abbott wrote: > On Sun, Nov 8, 2015 at 3:12 PM, Rob Clark wrote: >> --- >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 >> - >> src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + >> src/mesa/state_tracker/st_program.c

Re: [Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Ian Romanick
On 11/10/2015 01:19 AM, Kenneth Graunke wrote: > Inspired by a patch by Fabian Bieler. > > Fabian defined a _3DPRIM_PATCHLIST_0 macro (which isn't actually a valid > topology type); I instead chose to make a macro that takes an argument. > He also took the number of patch vertices from _mesa_prim

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Rob Clark
I think I'll end up moving st_glsl_to_nir (plus the fxns only called from it) into a new file. But I think get_mesa_program_nir() and get_mesa_program_tgsi() could end up sharing more common code like I am doing w/ st_translate_xyz_program().. at least that is my current thinking.. BR, -R On Tue

Re: [Mesa-dev] Can't get OpenGL 3.x inside VMware Workstation 12 (Ubuntu guest)

2015-11-10 Thread Brian Paul
On 11/09/2015 09:24 PM, Valera Rozuvan wrote: On Tue, Nov 10, 2015 at 4:13 AM, Brian Paul wrote: After running depmod, you probably need to update the initramfs with: 'sudo update-initramfs -u' -Brian Hi Brian. First of all, thank you for your reply. I have tried your suggestion on my worki

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:10 PM, Ian Romanick wrote: > On 11/04/2015 03:26 PM, Ryan Houdek wrote: >> I'm hoping to potentially convince about lowering the minimum >> requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. >> The only thing that causes it to require ES 3.1 is glMemoryBarrier, >> which shoul

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:29 PM, Ilia Mirkin wrote: > On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: >> On 11/04/2015 03:26 PM, Ryan Houdek wrote: >>> I'm hoping to potentially convince about lowering the minimum >>> requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. >>> The only thing that caus

[Mesa-dev] [PATCH 7/7] egl: make it clear which platform x11 backend is being used (dri2 or 3)

2015-11-10 Thread Martin Peres
Signed-off-by: Martin Peres Reviewed-by: Boyan Ding Reviewed-by: Kristian Høgsberg --- src/egl/drivers/dri2/egl_dri2.c | 6 +++--- src/egl/drivers/dri2/platform_x11.c | 6 +- src/egl/drivers/dri2/platform_x11_dri3.c | 10 +- 3 files changed, 13 insertions(+), 9 delet

[Mesa-dev] [PATCH 2/7] glx/dri3: Convert to use dri3 helper in loader library

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - convert to the new drawable interface - delete dead code after the dropping of some vfuncs - delete the width and height attributes since they are found in the helper Signed-off-by: Boyan Ding Signed-off-by: Martin Peres Reviewed-by: Kristian Høgsber

[Mesa-dev] [PATCH 3/7] egl_dri2: Add a function to let platform code return dri drawable from _EGLSurface

2015-11-10 Thread Martin Peres
From: Boyan Ding dri3 for EGL will use different struct other than dri2_egl_surface for an EGL surface, the common code only uses __DRIdrawable from that struct, so instead of converting _EGLSurface to dri2_egl_surface, let the platform code return the __DRIdrawable by its own (although the curre

[Mesa-dev] [PATCH 1/7] loader: Add dri3 helper

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - Try to fit in the 80-col limit as much as possible v3: From Martin Peres - introduce loader_dri3_helper.la to avoid dragging the xcb dep everywhere (Kristian & Emil) - get rid of the width, height, dri_screen and is_different_gpu vfuncs (Kristian) -

[Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v4)

2015-11-10 Thread Martin Peres
Here is an update to the v3, addressing almost all the comments I got during the previous round. The one item that is left to do is the handling of EGL_BUFFER_PRESERVED which will take some time since I need to write a piglit test for it.

[Mesa-dev] [PATCH 6/7] egl/x11_dri3: Implement EGL_KHR_image_pixmap

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: from Martin Peres - Replace a tab with spaces Signed-off-by: Boyan Ding Reviewed-by: Martin Peres Reviewed-by: Kristian Høgsberg --- src/egl/drivers/dri2/platform_x11.c | 1 + src/egl/drivers/dri2/platform_x11_dri3.c | 77 +++- 2 files

[Mesa-dev] [PATCH 4/7] egl/x11: Implement dri3 support with loader's dri3 helper

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - Tell we are compiling the dri3 backend in configure.ac - Update the Makefile.am - get rid of the LIBDRM_HAS_RENDERNODE_SUPPORT macro - fix some warnings related to EGLuint64KHR to int64_t conversions - use dri2_get_dri_config to get the __DRIconfig in

[Mesa-dev] [PATCH 5/7] loader/dri3: Expose function to create __DRIimage from pixmap

2015-11-10 Thread Martin Peres
From: Boyan Ding Used to support EGL_KHR_image_pixmap. Signed-off-by: Boyan Ding Reviewed-by: Martin Peres Reviewed-by: Kristian Høgsberg --- src/loader/loader_dri3_helper.c | 78 ++--- src/loader/loader_dri3_helper.h | 9 + 2 files changed, 58 insert

Re: [Mesa-dev] [PATCH 3/3] i965/nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

2015-11-10 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 4:03 AM, Eduardo Lima Mitev wrote: > I realized that patch 1/2 hasn't been reviewed, and this one didn't get > R-b. Any objection to these two? Go ahead Reviewed-by: Jason Ekstrand > thanks, > Eduardo > > On 10/23/2015 05:55 PM, Eduardo Lima Mitev wrote: >> When both f

Re: [Mesa-dev] [PATCH 03/23] mesa: Refactor update_array_format to make _mesa_update_array_format_public

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Pulls the parts of update_array_format that aren't just parameter > validation out into a function that can be called from other parts of > Mesa (e.g., meta). > > Signed-off-by: Ian Romanick > --- > src/mesa/main/varra

Re: [Mesa-dev] [PATCH 02/23] mesa: Make bind_vertex_buffer avilable outside varray.c

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/main/varray.c | 29 +++-- > src/mesa/main/varray.h | 7 +++ > 2 files changed, 22 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/main/

Re: [Mesa-dev] [PATCH 05/23] i965: Pass brw_context instead of gl_context to brw_draw_rectlist

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Future patches will use the brw_context instead. Keeping this > non-functional change separate should make the function changes easier > to review. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 06/23] i965: Use DSA functions for VBOs in brw_meta_fast_clear

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

Re: [Mesa-dev] [PATCH 04/23] mesa: Refactor enable_vertex_array_attrib to make _mesa_enable_vertex_array_attrib

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Pulls the parts of enable_vertex_array_attrib that aren't just parameter > validation out into a function that can be called from other parts of > Mesa (e.g., meta). > > _mesa_enable_vertex_array_attrib can also be used

Re: [Mesa-dev] [PATCH 07/23] i965: Use internal functions for buffer object access

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Instead of going through the GL API implementation functions, use the > lower-level functions. This means that we have to keep track of a > pointer to the gl_buffer_object and the gl_vertex_array_object. > > This has tw

Re: [Mesa-dev] [PATCH 08/23] i965: Don't pollute the buffer object namespace in brw_meta_fast_clear

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 09/23] meta: Use DSA functions for PBO in create_texture_for_pbo

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta_tex_subimage.c | 30 > +++-- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/src/mesa/drivers/common/meta_t

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Use image_format_info for doing image_load_store workarounds

2015-11-10 Thread Chad Versace
On Mon 09 Nov 2015, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 2:24 PM, Chad Versace wrote: > > On Wed 04 Nov 2015, Jason Ekstrand wrote: > >> --- > >> .../drivers/dri/i965/brw_fs_surface_builder.cpp| 157 > >> ++--- > >> 1 file changed, 106 insertions(+), 51 deletions(-)

[Mesa-dev] [PATCH] egl/x11/dri3: do not expose the preserved swap behavior (to be squashed)

2015-11-10 Thread Martin Peres
The preserved swap behavior is currently untested in piglit and not supported on the GLX side. Before working on implementing it for EGL/DRI3, let's disable it until support comes. This patch is trivial enough and will likely be squashed in the commit egl/x11: Implement dri3 support with loader's

Re: [Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v4)

2015-11-10 Thread Axel Davy
Hi, I did take a look, and it looks good to me. I'm happy you implemented DRI_PRIME support as well. About it, do you need testers to check everything works ? A mistake about it I noticed is that you don't disable EGL_KHR_image_pixmap when is_different_gpu is set. It should be disabled, just li

Re: [Mesa-dev] [PATCH 10/23] meta: Use _mesa_NamedBufferData and _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 12 +--- > src/mesa/drivers/common/meta_blit.c| 2 +- > src/mesa/drivers/common/meta_generate_mipmap.c | 4 ++--

Re: [Mesa-dev] [PATCH 11/23] i965: Use _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c >

Re: [Mesa-dev] [PATCH 12/23] meta: Don't leave the VBO bound after _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Meta currently does this, but future changes will make this impossible. > Explicitly do it as a step in the patch series now to catch any possible > kinks. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/commo

Re: [Mesa-dev] [PATCH 13/23] meta: Track VBO using gl_buffer_object instead of GL API object handle

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c| 69 > +++ > src/mesa/drivers/common/meta.h| 19 --- > src/mesa/drivers/common/meta_bl

Re: [Mesa-dev] [PATCH 15/23] meta: Use internal functions for buffer object and VAO access

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 76 > -- > 1 file changed, 43 insertions(+), 33 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c

Re: [Mesa-dev] [PATCH 14/23] meta: Use DSA functions for VBOs in _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > The fixed-function attribute paths don't get the DSA treatment because > there are no DSA entry-points for fixed-function attributes. These > could have been added, but this is a temporary patch intended to make > later

Re: [Mesa-dev] [PATCH 16/23] meta: Don't pollute the buffer object namespace in _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Marek Olšák
On Tue, Nov 10, 2015 at 5:42 PM, Rob Clark wrote: > I think I'll end up moving st_glsl_to_nir (plus the fxns only called > from it) into a new file. But I think get_mesa_program_nir() and > get_mesa_program_tgsi() could end up sharing more common code like I > am doing w/ st_translate_xyz_program

Re: [Mesa-dev] [PATCH] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 08:33:51 AM Ben Widawsky wrote: > On Mon, Nov 09, 2015 at 11:59:43PM -0800, Kenneth Graunke wrote: > > We basically just need to uncomment Ben's code. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 > > 1 fi

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-11-10 Thread Rowley, Timothy O
> On Oct 22, 2015, at 4:17 PM, Jose Fonseca wrote: > > They do share a lot already, Mesa, gallium statetracker, and gallivm. If > further development in openswr is planned, it might require to jump through a > few hoops, but I think it's worth to figure out what would take to get this > merge

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-11-10 Thread Ben Widawsky
There is one thing I need a response on at the very bottom, the rest will be addressed in v2. Thanks. On Mon, Nov 09, 2015 at 11:33:17AM -0800, Chad Versace wrote: > On Tue 03 Nov 2015, Ben Widawsky wrote: > > On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > > > On Tue 13 Oct 2015,

Re: [Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-10 Thread Kristian Høgsberg
On Tue, Nov 10, 2015 at 12:09 AM, Iago Toral wrote: > On Mon, 2015-11-09 at 16:52 +0100, Iago Toral wrote: >> On Wed, 2015-11-04 at 15:33 -0800, Kristian Høgsberg Kristensen wrote: >> > All GLSL IR consumers run this lowering pass so we can move it to the >> > linker. This moves the pass up quite

Re: [Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 08:41:22 AM Ian Romanick wrote: > On 11/10/2015 01:19 AM, Kenneth Graunke wrote: > > Inspired by a patch by Fabian Bieler. > > > > Fabian defined a _3DPRIM_PATCHLIST_0 macro (which isn't actually a valid > > topology type); I instead chose to make a macro that takes a

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-10 Thread Kristian Høgsberg
On Mon, Nov 9, 2015 at 6:26 PM, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 3:52 PM, Ian Romanick wrote: >> On 11/04/2015 03:55 PM, Jason Ekstrand wrote: >>> Here's some shader-db numbers: >>> >>> total instructions in shared programs: 6236146 -> 6255385 (0.31%) >>> instructions in affected p

Re: [Mesa-dev] [PATCH V2 07/12] glsl: add new type from compile time constants

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 12:33 +, Emil Velikov wrote: > Hi Tim, > > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > In this patch we introduce a new ast type for holding the new > > compile-time constant expressions. The main reason for this is that > > we c

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 12:33 +, Emil Velikov wrote: > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This helper is similar to the function added as part of the > > ast_layout_expression class but will be used when only the > > ast_expression type is requi

  1   2   >