On Tuesday, November 10, 2015 12:41:47 AM Matt Turner wrote: > On Mon, Nov 9, 2015 at 11:55 PM, Kenneth Graunke <kenn...@whitecape.org> > wrote: > > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ > > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > > b/src/mesa/drivers/dri/i965/brw_fs.cpp > > index b2b7762..8185355 100644 > > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > > @@ -4774,6 +4774,9 @@ fs_visitor::dump_instruction(backend_instruction > > *be_inst, FILE *file) > > > > fprintf(file, " "); > > > > + if (inst->force_writemask_all) > > + fprintf(file, "NoMask "); > > I think you want the space before NoMask, and not after it.
Nope, the line immediately before this unconditionally prints a space.
The lines below print spaces after the message.
> > +
> > if (dispatch_width == 16 && inst->exec_size == 8) {
> > if (inst->force_sechalf)
> > fprintf(file, "2ndhalf ");
> > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > index e52114a..4e6fd2f 100644
> > --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > @@ -1589,6 +1589,9 @@ vec4_visitor::dump_instruction(backend_instruction
> > *be_inst, FILE *file)
> > fprintf(file, ", ");
> > }
> >
> > + if (inst->force_writemask_all)
> > + fprintf(file, " NoMask ");
>
> Probably don't want the space after NoMask.
Right, I can drop that.
> One way or the other,
>
> Reviewed-by: Matt Turner <matts...@gmail.com>
Thanks :)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
