Re: [Mesa-dev] [PATCH] main: Match DispatchCompute* API validation from main specification

On Wed, 2015-10-14 at 13:46 -0700, Jordan Justen wrote: > There is a discrepancy between the ARB_compute_shader specification, > and the OpenGL 4.3 and OpenGLES 3.1 specifications. With regards to > the indirect dispatch parameter, unsupported value errors should > return INVALID_VALUE according to

Re: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

On Thu, 2015-10-29 at 10:06 -0700, Jordan Justen wrote: > On 2015-10-29 03:04:38, Iago Toral wrote: > > On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > > src/mesa/main/api_validate.c | 2 +- > > > src/mesa/main/pipelineobj.c | 11

[Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

This will allow gallium drivers to send messages to KHR_debug endpoints Signed-off-by: Ilia Mirkin --- This patch has a major problem in that it uses GET_CURRENT_CONTEXT. I was thinking of maybe adding a userdata thing into the pipe_context to be passed into that callback? Wanted to get more fee

Re: [Mesa-dev] [PATCH] i965/nir: Mark const index UBO surfaces as used

On Thu, 2015-10-29 at 10:44 -0700, Jordan Justen wrote: > On 2015-10-29 02:17:20, Iago Toral wrote: > > On Thu, 2015-10-29 at 00:50 -0700, Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- > > > src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

On Fri, Oct 30, 2015 at 3:17 AM, Ilia Mirkin wrote: > This will allow gallium drivers to send messages to KHR_debug endpoints > > Signed-off-by: Ilia Mirkin > --- > > This patch has a major problem in that it uses GET_CURRENT_CONTEXT. I > was thinking of maybe adding a userdata thing into the pip

Re: [Mesa-dev] [PATCH] mesa: DispatchComputeIndirect should return INVALID_VALUE on unaligned

I sent a patch on Oct 14 for this: "main: Match DispatchCompute* API validation from main specification" http://patchwork.freedesktop.org/patch/61881/ You might want monitor my cs git branch for related patches to help with the OpenGLES 3.1 CTS compute shader tests. -Jordan On 2015-10-29 07:

Re: [Mesa-dev] [PATCH] mesa: DispatchComputeIndirect should return INVALID_VALUE on unaligned

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Friday, October 30, 2015 8:32 AM > To: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa: DispatchComputeIndirect should > return IN

Re: [Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

Reviewed-by: Marek Olšák What's the use case for this? Marek On Fri, Oct 30, 2015 at 8:17 AM, Ilia Mirkin wrote: > This will allow gallium drivers to send messages to KHR_debug endpoints > > Signed-off-by: Ilia Mirkin > --- > > This patch has a major problem in that it uses GET_CURRENT_CONTEX

Re: [Mesa-dev] Patchwork/mesa-stable question

On Fri, Oct 30, 2015 at 3:33 AM, Michel Dänzer wrote: > On 30.10.2015 08:11, Nicolai Hähnle wrote: >> >> I am not familiar with patchwork yet and have a related question: on my >> push, I got the following error message related to patchwork: >> >> remote: E: failed to find patch for rev >> f75f21a

Re: [Mesa-dev] Patchwork/mesa-stable question

On 30.10.2015 17:44, Marek Olšák wrote: > On Fri, Oct 30, 2015 at 3:33 AM, Michel Dänzer wrote: >> On 30.10.2015 08:11, Nicolai Hähnle wrote: >>> >>> I am not familiar with patchwork yet and have a related question: on my >>> push, I got the following error message related to patchwork: >>> >>> re

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

Hi, I know this isn't your fault, but I really really don't see any reason why the vl winsys bits should continue to exist. We already have a winsys/presentation layer in Mesa ... Cheers, Daniel On 29 October 2015 at 17:40, Julien Isorce wrote: > This patch allows to use gallium vaapi without re

Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

-Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: 29 October 2015 19:04 To: Julien Isorce Cc: ML mesa-dev Subject: Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes On 29 October 2015 at 17:40, Julien Isorce wrote

[Mesa-dev] [PATCH] mesa: fix program resource queries for atomic counter buffers

gl_active_atomic_buffer contains index to UniformStorage, we need to calculate resource index for that gl_uniform_storage. Fixes following CTS tests: ES31-CTS.program_interface_query.atomic-counters ES31-CTS.program_interface_query.atomic-counters-one-buffer No Piglit regressions. Signed-o

Re: [Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

-Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 19:07 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage > @@ -80,12 +82,46 @@ YCbCrToPipe(u

Re: [Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

Ok I will reorder, make sense. -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 19:26 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH v4 5/9] st/va: handle Video Post Processing for configs On 29.10.2015 18:40, Julien I

Re: [Mesa-dev] [PATCH] mesa: fix program resource queries for atomic counter buffers

> -Original Message- > From: Palli, Tapani > Sent: Friday, October 30, 2015 11:03 AM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; curroje...@riseup.net; Palli, Tapani > Subject: [PATCH] mesa: fix program resource queries for atomic counter > buffers > > gl_active_atomic_buf

Re: [Mesa-dev] [PATCH] mesa: fix program resource queries for atomic counter buffers

On 10/30/2015 12:36 PM, Lofstedt, Marta wrote: -Original Message- From: Palli, Tapani Sent: Friday, October 30, 2015 11:03 AM To: mesa-dev@lists.freedesktop.org Cc: Lofstedt, Marta; curroje...@riseup.net; Palli, Tapani Subject: [PATCH] mesa: fix program resource queries for atomic cou

Re: [Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

-Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 19:26 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH v4 5/9] st/va: handle Video Post Processing for configs On 29.10.2015 18:40, Julien Isorce wrote: > Add support for

Re: [Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

-Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 19:24 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2 On 29.10.2015 18:40, Julien Isorce wrote: > For now it

Re: [Mesa-dev] [PATCH] mesa: fix program resource queries for atomic counter buffers

> -Original Message- > From: Palli, Tapani > Sent: Friday, October 30, 2015 11:43 AM > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > Cc: curroje...@riseup.net > Subject: Re: [PATCH] mesa: fix program resource queries for atomic counter > buffers > > > > On 10/30/2015 12:36 PM, Lo

[Mesa-dev] [PATCH 04/10] i965/vec4: Do not mark used direct surfaces in VS_OPCODE_PULL_CONSTANT_LOAD

Right now the generator marks direct surfaces as used but leaves marking of indirect surfaces to the caller. Just make the callers handle marking in both cases for consistency. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 9 - src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6

[Mesa-dev] [PATCH 08/10] i965/vec4: Do not mark used surfaces in VS_OPCODE_GET_BUFFER_SIZE

Do it in the visitor, like we do for other opcodes. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 -- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp b/src/mesa/

[Mesa-dev] [PATCH 06/10] i965/vec4: Do not mark used surfaces in SHADER_OPCODE_SHADER_TIME_ADD

Do it in the visitor, like we do for other opcodes. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 09/10] i965/fs: Do not mark used surfaces in FS_OPCODE_GET_BUFFER_SIZE

Do it in the visitor, like we do for other opcodes. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 -- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers

[Mesa-dev] [PATCH 00/10] i965: always mark used surfaces in the visitors

Right now some opcodes that only use constant surface indexing mark them as used in the generator while others do it in the visitor. When the opcode can handle both direct and indirect surface indexing then some opcodes handle only the constant part in the generator and leave the indirect case to t

[Mesa-dev] [PATCH 07/10] i965/fs: Do not mark used surfaces in SHADER_OPCODE_SHADER_TIME_ADD

Do it in the visitor, like we do for other opcodes. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 03/10] i965/fs: Do not mark used direct surfaces in the generator for texture opcodes

Right now the generator marks direct surfaces as used but leaves marking of indirect surfaces to the caller. Just make the callers handle marking in both cases for consistency. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 6 -- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 24 +

[Mesa-dev] [PATCH 05/10] i965/vec4: Do not mark used direct surfaces in the generator for texture opcodes

Right now the generator marks direct surfaces as used but leaves marking of indirect surfaces to the caller. Just make the callers handle marking in both cases for consistency. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 6 - src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 32 ++

[Mesa-dev] [PATCH 01/10] i965/fs: Do not mark direct used surfaces in VARYING_PULL_CONSTANT_LOAD

Right now the generator marks direct surfaces as used but leaves marking of indirect surfaces to the caller. Just make the callers handle marking in both cases for consistency. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8

[Mesa-dev] [PATCH 02/10] i965/fs: Do not mark used direct surfaces in UNIFORM_PULL_CONSTANT_LOAD

Right now the generator marks direct surfaces as used but leaves marking of indirect surfaces to the caller. Just make the callers handle marking in both cases for consistency. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 10 -

[Mesa-dev] [PATCH 10/10] i965/fs: Do not mark used surfaces in FS_OPCODE_FB_WRITE/FS_OPCODE_REP_FB_WRITE

Do it in the visitor, like we do for other opcodes. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 + src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 -- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 24 +++---

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

Ok I'll make a separate patch for the add of errors checks and add the break in the loop. Thx Julien -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: 29 October 2015 22:03 To: Julien Isorce Cc: ML mesa-dev Subject: Re: [Mesa-dev] [PATCH v4 8/9] st/va: impleme

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

-Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: 29 October 2015 22:21 To: Christian König Cc: Julien Isorce; ML mesa-dev Subject: Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM >>With the VA_RT_FORMAT_YUV400 handling droppe

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

Hi Daniel, Thx for pointing this out. Where are the files related to winsys/presentation :) ? Is your remark a blocker for landing the patches I submitted ? Maybe we can still land them and then if you could guide me what I should change to use newer api that would be great. Cheers Julien On 30

[Mesa-dev] [PATCH v5 10/10] st/va: add support to export a surface as dmabuf

I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Tested with gstreamer-vaapi wit

[Mesa-dev] [PATCH v5 04/10] st/va: implement dmabuf import for VaCreateSurfaces2

For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_tr

[Mesa-dev] [PATCH v5 06/10] st/va: handle Video Post Processing for configs

Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/config.c | 20 src/galliu

[Mesa-dev] [PATCH v5 09/10] st/va: implement VaDeriveImage

And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data arr

[Mesa-dev] [PATCH v5 01/10] st/va: properly defines VAImageFormat formats and improve VaCreateImage

Added PIPE_VIDEO_CHROMA_FORMAT_NONE in p_format.h and return it by default in ChromaToPipe. Renamed YCbCrToPipe to VaFourccToPipeFormat because it now contains RGB. Implemented PipeFormatToVaFourcc which will be used later in VlVaDeriveImage. Note that gstreamer-vaapi check all the VAImageFormat

[Mesa-dev] [PATCH v5 08/10] st/va: add more errors checks in vlVaBufferSetNumElements and vlVaMapBuffer

Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/buffer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/va/buffer.c b/src/gallium/state_trackers/va/buffer.c index 8f9ba44..f5b9e81 100644 --- a/src/gallium/state_trackers/va/buffer.c +++ b/src/g

[Mesa-dev] [PATCH v5 03/10] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

Inspired from http://cgit.freedesktop.org/vaapi/intel-driver/ especially src/i965_drv_video.c::i965_CreateSurfaces2. This patch is mainly to support gstreamer-vaapi and tools that uses this newer libva API. The first advantage of using VaCreateSurfaces2 over existing VaCreateSurfaces, is that it i

[Mesa-dev] [PATCH v5 00/10] st/va: add support for VPP, headless and dmabuf

All these patches have been already reviewed by Emil Velikov. And are now under review by Christian Koenig. This patch serie adds initial support for Video Post Processing. It also implements VaCreateSurfaces2 for common purpose and also to import a dmabuf. It also adds support for headless mode,

[Mesa-dev] [PATCH v5 05/10] st/va: add colospace conversion through Video Post Processing

Add support for VPP in the following functions: vlVaCreateContext vlVaDestroyContext vlVaBeginPicture vlVaRenderPicture vlVaEndPicture Add support for VAProcFilterNone in: vlVaQueryVideoProcFilters vlVaQueryVideoProcFilterCaps vlVaQueryVideoProcPipelineCaps Add handleVAProcPipelineParameterBuffer

[Mesa-dev] [PATCH v5 07/10] st/va: add headless support, i.e. VA_DISPLAY_DRM

This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium/state_trackers/va/context.c | 70 --- 2 files changed, 73 inse

[Mesa-dev] [PATCH v5 02/10] st/va: do not destroy old buffer when new one failed

If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by: Julien Isorce --- src/gallium/state_tracker

Re: [Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

On 29.10.2015 18:40, Julien Isorce wrote: Add support for VPP in the following functions: vlVaCreateContext vlVaDestroyContext vlVaBeginPicture vlVaRenderPicture vlVaEndPicture Add support for VAProcFilterNone in: vlVaQueryVideoProcFilters vlVaQueryVideoProcFilterCaps vlVaQueryVideoProcPipelineC

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 29.10.2015 18:40, Julien Isorce wrote: This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce Reviewed-by: Christian König --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium/state_tracke

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

On 29.10.2015 18:40, Julien Isorce wrote: And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType whi

Re: [Mesa-dev] [PATCH v4 9/9] st/va: add support to export a surface as dmabuf

On 29.10.2015 18:40, Julien Isorce wrote: I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/i

[Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

Since introduction of SSBO, UniformStorage contains not just uniforms but also buffer variables, this needs to be taken in to account when calculating active uniforms with GL_ACTIVE_UNIFORMS and GL_ACTIVE_UNIFORM_MAX_LENGTH. No Piglit regressions. Signed-off-by: Tapani Pälli --- src/mesa/main/s

[Mesa-dev] [PATCH 2/2] mesa: check if resource backed by buffer in property queries

Patch fixes broken behaviour of queries for following properties, from ARB_program_interface_query specification: GL_OFFSET: "For active variables not backed by a buffer object, an offset of -1 is written to ." GL_ARRAY_STRIDE: "For active variables not declared as an array of basic ty

Re: [Mesa-dev] [PATCH 4/7] glsl: set image access qualifiers for AoA

Timothy Arceri writes: > Cc: Francisco Jerez > --- > src/glsl/link_uniforms.cpp | 77 > +- > 1 file changed, 49 insertions(+), 28 deletions(-) > > diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp > index 647aa2b..2a1da07 100644 >

Re: [Mesa-dev] [PATCH 5/7] i965: add support for image AoA

Timothy Arceri writes: > Cc: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 44 > -- > src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 2 ++ > 2 files changed, 30 insertions(+), 16 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_f

Re: [Mesa-dev] [PATCH 01/10] i965/fs: Do not mark direct used surfaces in VARYING_PULL_CONSTANT_LOAD

Iago Toral Quiroga writes: > Right now the generator marks direct surfaces as used but leaves marking of > indirect surfaces to the caller. Just make the callers handle marking in both > cases for consistency. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 +++- > src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 01/10] i965/fs: Do not mark direct used surfaces in VARYING_PULL_CONSTANT_LOAD

Francisco Jerez writes: > Iago Toral Quiroga writes: > >> Right now the generator marks direct surfaces as used but leaves marking of >> indirect surfaces to the caller. Just make the callers handle marking in both >> cases for consistency. >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 02/10] i965/fs: Do not mark used direct surfaces in UNIFORM_PULL_CONSTANT_LOAD

Iago Toral Quiroga writes: > Right now the generator marks direct surfaces as used but leaves marking of > indirect surfaces to the caller. Just make the callers handle marking in both > cases for consistency. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 04/10] i965/vec4: Do not mark used direct surfaces in VS_OPCODE_PULL_CONSTANT_LOAD

Iago Toral Quiroga writes: > Right now the generator marks direct surfaces as used but leaves marking of > indirect surfaces to the caller. Just make the callers handle marking in both > cases for consistency. > --- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 9 - > src/mesa/dri

Re: [Mesa-dev] [PATCH 08/10] i965/vec4: Do not mark used surfaces in VS_OPCODE_GET_BUFFER_SIZE

Iago Toral Quiroga writes: > Do it in the visitor, like we do for other opcodes. > --- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 -- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 09/10] i965/fs: Do not mark used surfaces in FS_OPCODE_GET_BUFFER_SIZE

Iago Toral Quiroga writes: > Do it in the visitor, like we do for other opcodes. > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 -- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 - > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 10/10] i965/fs: Do not mark used surfaces in FS_OPCODE_FB_WRITE/FS_OPCODE_REP_FB_WRITE

Iago Toral Quiroga writes: > Do it in the visitor, like we do for other opcodes. Hm... I'm not 100% convinced of this and the texturing changes (patches 3 and 5). It definitely makes sense to do this explicitly in the visitor for the pull constant and dataport surface opcodes, because they tak

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

On 10/30/2015 01:30 PM, Tapani Pälli wrote: > Since introduction of SSBO, UniformStorage contains not just uniforms > but also buffer variables, this needs to be taken in to account when > calculating active uniforms with GL_ACTIVE_UNIFORMS and > GL_ACTIVE_UNIFORM_MAX_LENGTH. > > No Piglit regress

Re: [Mesa-dev] [PATCH 00/10] i965: always mark used surfaces in the visitors

Iago Toral Quiroga writes: > Right now some opcodes that only use constant surface indexing mark them as > used in the generator while others do it in the visitor. When the opcode can > handle both direct and indirect surface indexing then some opcodes handle > only the constant part in the gener

Re: [Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

On 10/30/2015 01:23 AM, Ilia Mirkin wrote: On Fri, Oct 30, 2015 at 3:17 AM, Ilia Mirkin wrote: This will allow gallium drivers to send messages to KHR_debug endpoints Signed-off-by: Ilia Mirkin --- This patch has a major problem in that it uses GET_CURRENT_CONTEXT. I was thinking of maybe ad

Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

On 30 October 2015 at 09:59, Julien Isorce wrote: > > > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: 29 October 2015 19:04 > To: Julien Isorce > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and > VaQuerySu

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

Hi Julien, On 30 October 2015 at 11:32, Julien Isorce wrote: > Thx for pointing this out. Where are the files related to > winsys/presentation :) ? The one you're changing. ;) src/gbm already has a great deal of infrastructure for handling direct connections to DRM/KMS devices, buffer allocatio

Re: [Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

On 30 October 2015 at 11:54, Christian König wrote: > On 29.10.2015 18:40, Julien Isorce wrote: > >> Add support for VPP in the following functions: >> vlVaCreateContext >> vlVaDestroyContext >> vlVaBeginPicture >> vlVaRenderPicture >> vlVaEndPicture >> >> Add support for VAProcFilterNone in: >>

Re: [Mesa-dev] [PATCH 2/2] mesa: check if resource backed by buffer in property queries

Patch is, Reviewed-by: Eduardo Lima Mitev On 10/30/2015 01:30 PM, Tapani Pälli wrote: > Patch fixes broken behaviour of queries for following properties, from > ARB_program_interface_query specification: > > GL_OFFSET: > >"For active variables not backed by a buffer object, an offset of >

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli wrote: > Since introduction of SSBO, UniformStorage contains not just uniforms > but also buffer variables, this needs to be taken in to account when > calculating active uniforms with GL_ACTIVE_UNIFORMS and > GL_ACTIVE_UNIFORM_MAX_LENGTH. > > No Pigli

[Mesa-dev] [PATCH 1/7] loader: Add dri3 helper

From: Boyan Ding v2: From Martin Peres - Try to fit in the 80-col limit as much as possible Signed-off-by: Boyan Ding Reviewed-by: Martin Peres --- configure.ac|8 +- src/loader/Makefile.am |9 + src/loader/loader_dri3_helper.c | 1404

[Mesa-dev] [PATCH 5/7] loader/dri3: Expose function to create __DRIimage from pixmap

From: Boyan Ding Used to support EGL_KHR_image_pixmap. Signed-off-by: Boyan Ding Reviewed-by: Martin Peres --- src/loader/loader_dri3_helper.c | 81 + src/loader/loader_dri3_helper.h | 9 + 2 files changed, 58 insertions(+), 32 deletions(-) diff -

[Mesa-dev] [PATCH 7/7] egl: make it clear which platform x11 backend is being used (dri2 or 3)

Signed-off-by: Martin Peres --- src/egl/drivers/dri2/egl_dri2.c | 6 +++--- src/egl/drivers/dri2/platform_x11.c | 6 +- src/egl/drivers/dri2/platform_x11_dri3.c | 10 +- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/s

[Mesa-dev] [PATCH 3/7] egl_dri2: Add a function to let platform code return dri drawable from _EGLSurface

From: Boyan Ding dri3 for EGL will use different struct other than dri2_egl_surface for an EGL surface, the common code only uses __DRIdrawable from that struct, so instead of converting _EGLSurface to dri2_egl_surface, let the platform code return the __DRIdrawable by its own (although the curre

[Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v3)

First of all, I would like to thank Boyan for his work here. I rebased his patch series, fixed minor issues here and there and reviewed it. You can check the changes in every patch but the biggest changes are related to the build system. Speaking about the build system it seems like scons is not b

[Mesa-dev] [PATCH 6/7] egl/x11_dri3: Implement EGL_KHR_image_pixmap

From: Boyan Ding v2: from Martin Peres - Replace a tab with spaces Signed-off-by: Boyan Ding Reviewed-by: Martin Peres --- src/egl/drivers/dri2/platform_x11.c | 1 + src/egl/drivers/dri2/platform_x11_dri3.c | 77 +++- 2 files changed, 77 insertions(+), 1 del

[Mesa-dev] [PATCH 4/7] egl/x11: Implement dri3 support with loader's dri3 helper

From: Boyan Ding v2: From Martin Peres - Tell we are compiling the dri3 backend in configure.ac - Update the Makefile.am - get rid of the LIBDRM_HAS_RENDERNODE_SUPPORT macro - fix some warnings related to EGLuint64KHR to int64_t conversions - use dri2_get_dri_config to get the __DRIconfig in

[Mesa-dev] [PATCH 2/7] glx/dri3: Convert to use dri3 helper in loader library

From: Boyan Ding Signed-off-by: Boyan Ding Reviewed-by: Martin Peres --- configure.ac|4 - src/glx/dri3_glx.c | 1446 ++- src/glx/dri3_priv.h | 96 +--- 3 files changed, 171 insertions(+), 1375 deletions(-) diff --git a/configure.

Re: [Mesa-dev] [PATCH 4/7] egl/x11: Implement dri3 support with loader's dri3 helper

On Fri, Oct 30, 2015 at 9:03 AM, Martin Peres wrote: > diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am > index 5c2ba30..cdf2216 100644 > --- a/src/egl/Makefile.am > +++ b/src/egl/Makefile.am > @@ -47,12 +47,18 @@ libEGL_la_LDFLAGS = \ > $(LD_NO_UNDEFINED) > > dri2_backend_FILES = >

Re: [Mesa-dev] [PATCH 00/10] i965: always mark used surfaces in the visitors

On Fri, Oct 30, 2015 at 4:11 AM, Iago Toral Quiroga wrote: > Right now some opcodes that only use constant surface indexing mark them as > used in the generator while others do it in the visitor. When the opcode can > handle both direct and indirect surface indexing then some opcodes handle > only

Re: [Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

On Fri, Oct 30, 2015 at 10:23 AM, Brian Paul wrote: > On 10/30/2015 01:23 AM, Ilia Mirkin wrote: >> >> On Fri, Oct 30, 2015 at 3:17 AM, Ilia Mirkin wrote: >>> >>> This will allow gallium drivers to send messages to KHR_debug endpoints >>> >>> Signed-off-by: Ilia Mirkin >>> --- >>> >>> This patch

Re: [Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

On 29 October 2015 at 21:50, Dave Airlie wrote: > On 29 October 2015 at 21:12, Emil Velikov wrote: >> On 29 October 2015 at 11:12, Emil Velikov wrote: >>> Hi all, >>> >>> A slightly longer series (that builds on top of the previous sent a >>> minute ago), that moves/renames a couple of files, ad

Re: [Mesa-dev] [PATCH v2 shader-db] report.py: rework and update for cycle info

Ping. I just pushed the corresponding mesa patch to master yesterday, so I'd like to get this landed in shader-db soon. On Fri, Oct 16, 2015 at 11:09 PM, Connor Abbott wrote: > Now that we have three separate things we want to measure (instructions, > cycles, and loops), it's impractical to keep

Re: [Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

On 19 October 2015 at 18:41, Emil Velikov wrote: > On 19 October 2015 at 17:07, Brian Paul wrote: >> >> I'm not too familiar with this code or these changes but I'm wondering how >> much of chance there is of this breaking any driver/target builds. >> >> For example, is there a chance of breakin

Re: [Mesa-dev] [PATCH] gallium: expose a debug message callback settable by context owner

On Fri, Oct 30, 2015 at 12:38 PM, Ilia Mirkin wrote: > On Fri, Oct 30, 2015 at 10:23 AM, Brian Paul wrote: >> On 10/30/2015 01:23 AM, Ilia Mirkin wrote: >>> >>> On Fri, Oct 30, 2015 at 3:17 AM, Ilia Mirkin wrote: This will allow gallium drivers to send messages to KHR_debug endpoints >

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 30 October 2015 at 14:48, Daniel Stone wrote: > Hi Julien, > > On 30 October 2015 at 11:32, Julien Isorce wrote: >> Thx for pointing this out. Where are the files related to >> winsys/presentation :) ? > > The one you're changing. ;) > > src/gbm already has a great deal of infrastructure for h

Re: [Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v3)

On Fri, Oct 30, 2015 at 06:03:31PM +0200, Martin Peres wrote: > First of all, I would like to thank Boyan for his work here. I rebased his > patch > series, fixed minor issues here and there and reviewed it. You can check the > changes in every patch but the biggest changes are related to the buil

Re: [Mesa-dev] [PATCH v2 11/11] i965: Add scalar GS input lowering code.

On Mon, Oct 12, 2015 at 02:49:13PM -0700, Kenneth Graunke wrote: > We really ought to compute the VUE map at link time and stash it, rather > than recomputing it here, but with the mess of program structures I > wasn't sure where to put it. We can improve that later. Yeah, this will work for now,

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] [v3] i965/skl: Add GT4 PCI IDs

On 10/29/2015 05:30 PM, Ben Widawsky wrote: > Like other gen8+ hardware, the hardware automatically scales up thread counts > and URB sizes, so there is no need to do anything but add the PCI IDs. Give the v3 change, is that really true? > FINISHME: This patch still needs testing before merge. >

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On 10/28/2015 09:26 PM, Ilia Mirkin wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> People often complain about the way that open-source projects are so nit >> picky about coding standards. It's a necessary survival tactic. Mesa >> is 22 years old. It has had dozens of contribu

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On 10/28/2015 06:30 PM, Kenneth Graunke wrote: > On Wednesday, October 28, 2015 05:04:07 PM Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On 10/28/2015 06:15 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h

[Mesa-dev] [PATCH v2 01/18] mesa/extensions: Remove array sentinel

From: Nanley Chery Simplify future updates to the extension struct array by removing the sentinel. Signed-off-by: Nanley Chery --- src/mesa/main/extensions.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/extensio

[Mesa-dev] [PATCH v2 02/18] mesa/extensions: Wrap array entries in macros

From: Nanley Chery Now that we're using macros, remove the redundant text from each entry. Remove comments between the entries to make editing easier and separate the sections with blank lines. Structure the EXT macros in a way that helps reviewers verify that no meaning has been altered. Signe

[Mesa-dev] [PATCH v2 03/18] mesa/extensions: Move entries entries to seperate file

From: Nanley Chery With this infrastructure set in place, we can now reuse the entries to generate useful code. v2. Add the new file into Makefile.sources (Emil) Signed-off-by: Nanley Chery --- src/mesa/Makefile.sources| 1 + src/mesa/main/extensions.c | 321 +-

[Mesa-dev] [PATCH v2 05/18] mesa/extensions: Create _mesa_extension_supported()

From: Nanley Chery Create a function which determines if an extension is supported in the current context. v2. Use common variable names (Emil) Insert new line between variables and return statement (Chad) Rename api_set variable to api_bit (Chad) Signed-off-by: Nanley Chery --- src/m

[Mesa-dev] [PATCH v2 06/18] mesa/extensions: Use _mesa_extension_supported()

From: Nanley Chery Replace open-coded checks for extension support with _mesa_extension_supported(). Signed-off-by: Nanley Chery --- src/mesa/main/extensions.c | 54 src/mesa/main/extensions_table.h | 6 ++--- 2 files changed, 14 insertions(+), 4

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

On 10/28/2015 10:01 PM, Jason Ekstrand wrote: > > On Oct 28, 2015 9:12 PM, "Kenneth Graunke" > wrote: >> >> On Wednesday, October 28, 2015 02:58:07 PM Kristian Høgsberg wrote: >> > On Wed, Oct 28, 2015 at 2:34 PM, Jason Ekstrand > mailto:ja...@jlekstrand.net>> wrote:

[Mesa-dev] [PATCH v2 04/18] mesa/extensions: Add extension::version

From: Nanley Chery Enable limiting advertised extension support by context version with finer granularity. v2. Use uint*t type for version and note the expected values (Emil) Use an 8-bit wide datatype. Reformat macro for better readability (Chad) Signed-off-by: Nanley Chery --- src/m

[Mesa-dev] [PATCH v2 13/18] mesa: Fix ASTC extension functionality leak into GLES 1

From: Nanley Chery Stop a leak of ASTC functionality into GLES 1 contexts. v2. Handle ASTC driver capability check in texcompress.c Signed-off-by: Nanley Chery --- src/mesa/main/glformats.c | 4 ++-- src/mesa/main/texcompress.c | 2 +- src/mesa/main/teximage.c| 6 +++--- 3 files changed

[Mesa-dev] [PATCH v2 07/18] mesa/extensions: Replace extension::api_set with ::version

From: Nanley Chery The api_set field has no users outside of _mesa_extension_supported(). Remove it and allow the version field to take its place. The brunt of the transformation was performed with the following vim commands: s/\(GL [^,]\+\),\s*\d*,\s*\d*\(,\s*\d*\)\(,\s*\d*\)/\1, GLL, GLC\2\3/g

[Mesa-dev] [PATCH v2 17/18] mesa: Replace gl_extensions::EXT_texture3D with ::dummy_true

From: Nanley Chery Mesa unconditionally sets this driver flag to true in _mesa_init_extensions(). There is therefore no need for the driver to communicate support for this extension. Replace the driver capability flag with ::dummy_true. Signed-off-by: Nanley Chery Reviewed-by: Chad Versace ---

  1   2   >