Re: [Mesa-dev] [PATCH 3/3] st/mesa: use PK2H/UP2H when gs5 is supported

2015-10-29 Thread Ilia Mirkin
On Thu, Oct 29, 2015 at 2:52 AM, Ilia Mirkin wrote: > ARB_gpu_shader5 should be a decent proxy for whether those instructions > are supported. > > Signed-off-by: Ilia Mirkin > --- > > Not actually ready to be committed, since r600/radeonsi need support > for these ops as well. Should be easy to i

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-29 Thread Iago Toral
On Wed, 2015-10-28 at 10:58 -0700, Kristian Høgsberg wrote: > On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: > > There is no opinions about this issue or reviews of the proposed patch > > after one week. > > > > This is just a reminder in case you have missed it :-) >

[Mesa-dev] [PATCH v2] main: fix basename match's check if it's an array or struct

2015-10-29 Thread Samuel Iglesias Gonsalvez
Commit 4565b6f did not update the basename match's check for the case that string would exactly match the name of the variable if the suffix "[0]" were appended to it. Fixes two dEQP-GLES31 tests: dEQP-GLES31.functional.program_interface_query.shader_storage_block.resource_list.block_array dEQP-G

[Mesa-dev] [PATCH] glsl: Add compute shader builtin variables for OpenGLES 3.1

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index a6ad105..00113d5 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src/glsl/builtin_variables.c

[Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Jordan Justen
The OpenGLES GLSL 3.1 specification uses the precision qualifier ordering rules from ARB_shading_language_420pack. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser.yy | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy

[Mesa-dev] [PATCH] main/get: Add MAX_COMBINED_COMPUTE_UNIFORM_COMPONENTS

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/get_hash_params.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index c295615..fbc7b8f 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@

[Mesa-dev] [PATCH] i965: Setup pull constant state for compute programs

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/brw_state.h| 1 + src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ src/mesa/drivers/dri/i965/gen7_cs_state.c| 32 4 files changed, 36 ins

[Mesa-dev] [PATCH] i965/nir: Mark const index UBO surfaces as used

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH 1/2] mesa/sso: Add MESA_VERBOSE=api trace support

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/pipelineobj.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 51ee10f..c8c50fa 100644 --- a/src/mesa/main/pipelineobj.c +++ b/src/mesa/main/pipelin

[Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

2015-10-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c | 2 +- src/mesa/main/pipelineobj.c | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index c59b6f3..46f39e7 100644 --- a/src/mesa/main/api_va

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Ilia Mirkin
Would it make sense to just modify the has_420pack function? Or do you not want all of it? On Thu, Oct 29, 2015 at 3:47 AM, Jordan Justen wrote: > The OpenGLES GLSL 3.1 specification uses the precision qualifier > ordering rules from ARB_shading_language_420pack. > > Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

2015-10-29 Thread Nicolai Hähnle
On 29.10.2015 01:52, Ivan Kalvachev wrote: -- Forwarded message -- From: Ivan Kalvachev Date: Wed, 28 Oct 2015 23:46:44 +0200 Subject: [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier. To: Nicolai Hähnle On 10/26/15, Nicolai Hähnle wrote: Hi

Re: [Mesa-dev] [PATCH] glsl: Add compute shader builtin variables for OpenGLES 3.1

2015-10-29 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-10-29 at 00:46 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/builtin_variables.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Jordan Justen
On 2015-10-29 00:53:01, Ilia Mirkin wrote: > Would it make sense to just modify the has_420pack function? Or do you > not want all of it? Yeah, that was my first thought. Looking at the OpenGLES 3.1 spec, it seems to not have picked up very much of 420pack. This was the only part I've noticed so

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:47 -0700, Jordan Justen wrote: > The OpenGLES GLSL 3.1 specification uses the precision qualifier > ordering rules from ARB_shading_language_420pack. Maybe expand the commit log to make explicit that this is for GLES 3.1 and desktop GL since 4.2 Reviewed-by: Iago Toral Qu

Re: [Mesa-dev] [PATCH] main/get: Add MAX_COMBINED_COMPUTE_UNIFORM_COMPONENTS

2015-10-29 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-10-29 at 00:47 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/get_hash_params.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/get_hash_params.py > b/src/mesa/main/get_hash_params.py > inde

Re: [Mesa-dev] [PATCH 1/3] mesa: rename UniformBlockStageIndex to InterfaceBlockStageIndex

2015-10-29 Thread Juha-Pekka Heikkila
This set was Reviewed-by: Juha-Pekka Heikkila On 28.10.2015 07:38, Jordan Justen wrote: Signed-off-by: Jordan Justen Cc: Samuel Iglesias Gonsálvez Cc: Iago Toral Quiroga --- src/glsl/link_uniform_initializers.cpp | 2 +- src/glsl/linker.cpp| 16 src

Re: [Mesa-dev] [PATCH] i965: Setup pull constant state for compute programs

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:49 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > src/mesa/drivers/dri/i965/brw_state.h| 1 + > src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ > src/mesa/drivers/dri/i965/gen7_cs_s

Re: [Mesa-dev] [PATCH] i965/nir: Mark const index UBO surfaces as used

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:50 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

2015-10-29 Thread Ivan Kalvachev
On 10/29/15, Ilia Mirkin wrote: > On Wed, Oct 28, 2015 at 8:52 PM, Ivan Kalvachev > wrote: >> I'm attaching v3 of the patch. Same as v2, but without the extra empty >> line. > > FYI, there's a lot of overhead to reviewing an attached patch (in > fact, gmail makes it extra difficult since you can'

Re: [Mesa-dev] [PATCH 1/2] st/mesa: create temporary textures with the same nr_samples as source

2015-10-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Oct 28, 2015 at 9:18 PM, Ilia Mirkin wrote: > Not sure if this is actually reachable in practice (to have a complex > copy with MS textures). > > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_cb_copyimage.c | 8 ++-- > 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] mesa/sso: Add MESA_VERBOSE=api trace support

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/pipelineobj.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c > index 51ee10f..c8c50f

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

2015-10-29 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Thursday, October 29, 2015 8:47 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision q

Re: [Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

2015-10-29 Thread Emil Velikov
Hi Nanley, On 28 October 2015 at 21:50, Nanley Chery wrote: > From: Nanley Chery > > A prior, literal reading of the ASTC spec led to the prohibition > of some compressed formats being used against the targets: > TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Since the spec does not specify > interactio

Re: [Mesa-dev] [PATCH] glsl: Add compute shader builtin variables for OpenGLES 3.1

2015-10-29 Thread Lofstedt, Marta
Thanks for your recent patches, they make big difference for the gles 3.1 CTS results! Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Thursday, October 29, 2015 8:46 AM > To: mesa-dev

Re: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

2015-10-29 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Thursday, October 29, 2015 8:52 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader sup

Re: [Mesa-dev] [PATCH] main/get: Add MAX_COMBINED_COMPUTE_UNIFORM_COMPONENTS

2015-10-29 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Jordan Justen > Sent: Thursday, October 29, 2015 8:48 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] main/get: Add > MAX_COMBINED_COMPUTE

Re: [Mesa-dev] Manipulate GALLIUM_HUD post-launch (interactively)

2015-10-29 Thread Marek Olšák
On Wed, Oct 28, 2015 at 10:24 PM, Jimmy Berry wrote: > I have found myself desiring the ability to manipulate the GALLIUM_HUD > variable while an application is running. At the most basic simply > being able to toggle the hud on and off would be great. Otherwise, one > has to relaunch an applicati

Re: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

2015-10-29 Thread Iago Toral
On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/api_validate.c | 2 +- > src/mesa/main/pipelineobj.c | 11 +++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/a

Re: [Mesa-dev] [PATCH v2] main: fix basename match's check if it's an array or struct

2015-10-29 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/29/2015 09:43 AM, Samuel Iglesias Gonsalvez wrote: Commit 4565b6f did not update the basename match's check for the case that string would exactly match the name of the variable if the suffix "[0]" were appended to it. Fixes two dEQP-GLES31 tests: dEQP-GLES31.f

Re: [Mesa-dev] Manipulate GALLIUM_HUD post-launch (interactively)

2015-10-29 Thread Eero Tamminen
Hi, On 10/28/2015 11:24 PM, Jimmy Berry wrote: I have found myself desiring the ability to manipulate the GALLIUM_HUD variable while an application is running. At the most basic simply being able to toggle the hud on and off would be great. Otherwise, one has to relaunch an application and get b

Re: [Mesa-dev] Manipulate GALLIUM_HUD post-launch (interactively)

2015-10-29 Thread Martin Peres
On 29/10/15 12:33, Eero Tamminen wrote: Hi, On 10/28/2015 11:24 PM, Jimmy Berry wrote: I have found myself desiring the ability to manipulate the GALLIUM_HUD variable while an application is running. At the most basic simply being able to toggle the hud on and off would be great. Otherwise, o

Re: [Mesa-dev] [PATCH 3/3] st/mesa: use PK2H/UP2H when gs5 is supported

2015-10-29 Thread Marek Olšák
On Thu, Oct 29, 2015 at 8:07 AM, Ilia Mirkin wrote: > On Thu, Oct 29, 2015 at 2:52 AM, Ilia Mirkin wrote: >> ARB_gpu_shader5 should be a decent proxy for whether those instructions >> are supported. >> >> Signed-off-by: Ilia Mirkin >> --- >> >> Not actually ready to be committed, since r600/rade

Re: [Mesa-dev] Manipulate GALLIUM_HUD post-launch (interactively)

2015-10-29 Thread Eero Tamminen
Hi, On 10/29/2015 12:27 PM, Martin Peres wrote: On 29/10/15 12:33, Eero Tamminen wrote: On 10/28/2015 11:24 PM, Jimmy Berry wrote: I have found myself desiring the ability to manipulate the GALLIUM_HUD variable while an application is running. At the most basic simply being able to toggle the

[Mesa-dev] [PATCH 1/6] virgl: fix drm.h include path

2015-10-29 Thread Emil Velikov
From: Emil Velikov The drm/ prefix is required, if using the kernel provided headers. As most distros don't ship them it and we already depend on libdrm (which adds the relevant -I flag) just drop the drm/ from the include. Once a libdrm release with the virtgpu_drm.h header is released, we can

[Mesa-dev] [PATCH 3/6] winsys/virgl/vtest: list all files in Makefile.sources

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/vtest/Makefile.sources | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/vtest/Makefile.sources b/src/gallium/winsys/virgl/vtest/Makefile.sources index ab72560..410763f 100644 --- a/src/galli

[Mesa-dev] [PATCH 5/6] virgl: remove the _FILE_OFFSET_BITS defines

2015-10-29 Thread Emil Velikov
From: Emil Velikov The build already sets it as needed. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 3 --- src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c | 2 -- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 2 -- 3 files changed, 7 deleti

[Mesa-dev] [PATCH 0/6] virgl: trivial build fixes/cleanups

2015-10-29 Thread Emil Velikov
Hi all, Some mostly trivial fixes which I came across whist trying to build virgl. Build tested only. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/6] winsys/virgl/drm: add all files to the tarball

2015-10-29 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/Makefile.sources | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/drm/Makefile.sources b/src/gallium/winsys/virgl/drm/Makefile.sources index c0baed8..eca8eb6 100644

[Mesa-dev] [PATCH 6/6] virgl: straighten the includes confusion

2015-10-29 Thread Emil Velikov
From: Emil Velikov Use the relevant GALLIUM_foo_CFLAGS which has all the requirements (not to mention VISIBITY_CFLAGS) and keep ../ out of the include directives. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.am | 5 + src/gallium/drivers/virgl/virgl.h

[Mesa-dev] [PATCH 2/6] virgl: move sources list to Makefile.sources

2015-10-29 Thread Emil Velikov
From: Emil Velikov ... and add the missing files while we're at it. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.am | 12 ++-- src/gallium/drivers/virgl/Makefile.sources | 17 + 2 files changed, 19 insertions(+), 10 deletions(-) create mode 1

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

Re: [Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 11:12, Emil Velikov wrote: > Hi all, > > A slightly longer series (that builds on top of the previous sent a > minute ago), that moves/renames a couple of files, adds a few inline > wrappers, 'includes what you want' and related fixes. > > As some of these can be seen as bike

[Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

2015-10-29 Thread Oded Gabbay
Hi Roland, Jose I wanted to bring a problem I found to your attention, and discuss about it and ways to solve it. I'm working on regressions of piglit gpu.py between x86-64 and ppc64le, when running with llvmpipe. One of the regressions manifests itself in 2 tests, clip-distance-bulk-copy and cl

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 09:24, Ivan Kalvachev wrote: > On 10/29/15, Ilia Mirkin wrote: >> On Wed, Oct 28, 2015 at 8:52 PM, Ivan Kalvachev >> wrote: >>> I'm attaching v3 of the patch. Same as v2, but without the extra empty >>> line. >> >> FYI, there's a lot of overhead to reviewing an attached pat

[Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data arr

[Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

2015-10-29 Thread Julien Isorce
I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Tested with gstreamer-vaapi wit

[Mesa-dev] [PATCH 0/2] vaapi: add support for dmabuf export

2015-10-29 Thread Julien Isorce
This 2 patches allow to derive a va surface as a va image. Which one can be exported as dmabuf by calling VaAcquireBufferHandle. I have tested these patches with gstreamer-vaapi and nouveau driver. The pipeline looks like: gstvaapidecode:(vasurface, NV12) -> gstvaapipostproc:(dmabuf, RGBA) -> gl

[Mesa-dev] [PATCH 01/15] virgl: move virgl_hw.h into the driver dir

2015-10-29 Thread Emil Velikov
Strictly speaking virgl_hw.h should reside in the driver folder, as it describes the hardware. Moving it allows us to nuke the following strange dependency winsys/vtest > driver > winsys/drm Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources | 1 + src/gallium/

[Mesa-dev] [PATCH 14/15] virgl: unwrap the includes

2015-10-29 Thread Emil Velikov
Include what you want, rather than relying on a header foo.h N levels down the include chain, to provide something that you need. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 ++ src/gallium/drivers/virgl/virgl_context.c | 7 ++- src/gal

[Mesa-dev] [PATCH 02/15] virgl: rename virgl.h to virgl_screen.h

2015-10-29 Thread Emil Velikov
Provide a more meaningful name considering it's purpose. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources | 2 +- src/gallium/drivers/virgl/virgl.h | 51 -- src/gallium/drivers/virgl/virgl_context.c | 2 +- src/gallium/drivers/vir

[Mesa-dev] [PATCH 12/15] winsys/virgl: always memset prior to ioctl

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index 11542f5..d9b4d58 100644 --- a/s

[Mesa-dev] [PATCH 15/15] winsys/virgl: rework line wrapping/indent

2015-10-29 Thread Emil Velikov
Wrap some of the 'omg it's getting out of hand' long lines, and re-indent where things feel off. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c| 83 --- .../winsys/virgl/vtest/virgl_vtest_socket.c| 13 ++- .../winsys/virgl/vtest/virgl_vt

[Mesa-dev] [PATCH 03/15] virgl: remove sw_winsys pointer from virgl_screen

2015-10-29 Thread Emil Velikov
The screen already has a pointer to the (base) winsys object. With the latter of which implemented/sub-classed as either drm or sw based one, depending on the target. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_public.h | 1 - src/gallium/drivers/virgl/virgl_screen.c | 1 - s

[Mesa-dev] [PATCH 04/15] winsys/virgl/drm: drop unneeded forward declaration

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h index eac1d3e..a547654 100644 --- a/src/gallium/winsys/virgl/drm/

[Mesa-dev] [PATCH 06/15] virgl: introduce and use virgl_transfer/texture/resource inline wrappers

2015-10-29 Thread Emil Velikov
The only two remaining cases of (struct virgl_resource *) require a closer look. Either the error checking is missing or the arguments provided feel wrong. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 +- src/gallium/drivers/virgl/virgl_context.c | 28 ++

[Mesa-dev] [PATCH 09/15] winsys/virgl: throw in some inline wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 10 +- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 14 ++ src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 10 +- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.h |

[Mesa-dev] [PATCH 11/15] winsys/virgl: use MALLOC to match FREE

2015-10-29 Thread Emil Velikov
The uppercase versions are wrappers which must be matched. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm

[Mesa-dev] [PATCH 13/15] winsys/virgl: remove temporary ret variable

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index d9b4d58..0616de3 100644 --- a/s

[Mesa-dev] [PATCH 10/15] winsys/virgl: remove calloc/malloc casts

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 5 ++--- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/dr

[Mesa-dev] [PATCH 07/15] virgl: use virgl_screen/surface upcast wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_context.c | 2 +- src/gallium/drivers/virgl/virgl_encode.c | 4 ++-- src/gallium/drivers/virgl/virgl_encode.h | 5 + src/gallium/drivers/virgl/virgl_resource.c | 4 ++-- src/gallium/drivers/virgl/virgl_screen.h | 2 +- 5 f

[Mesa-dev] [PATCH 05/15] virgl: add virgl_context/sampler_view/so_target() upcast wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 6 +- src/gallium/drivers/virgl/virgl_context.c | 98 ++--- src/gallium/drivers/virgl/virgl_context.h | 17 + src/gallium/drivers/virgl/virgl_encode.c| 2 +- src/gallium/drivers/vir

[Mesa-dev] [PATCH 08/15] virgl: introduce virgl_query() inline wrapper

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_query.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_query.c b/src/gallium/drivers/virgl/virgl_query.c index ea50f2f..b06635b 100644 --- a/src/gallium/drivers/v

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-29 Thread Christian König
+ drm_info = (struct drm_state *) ctx->drm_state; + if (!drm_info) { + FREE(drv); + return VA_STATUS_ERROR_INVALID_PARAMETER; + } + +#if GALLIUM_STATIC_TARGETS + drm_fd = drm_info->fd; +#else + drm_fd = dup(drm_info->fd); +#endif + + if (drm_fd < 0)

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

2015-10-29 Thread Christian König
Hi Julien, if Emil or Ilia have no further comments please send out your full set of patches once more I would like to get this pusched upstream. Best regards, Christian. On 17.10.2015 01:14, Julien Isorce wrote: This patch serie adds initial support for Video Post Processing. It also implem

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

2015-10-29 Thread Felix Schwarz
Am 29.10.2015 um 10:24 schrieb Ivan Kalvachev: > Configuring smtp server is too much hassle for a single patch and I > would like to avoid writing my email credentials if possible. > If I'm about to send more patches, then I guess I would have to do that. You might want to look into "git imap-send

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

2015-10-29 Thread Francisco Jerez
Francisco Jerez writes: > Chris Wilson writes: > >> On Sat, Oct 03, 2015 at 05:57:05PM +0300, Francisco Jerez wrote: >>> Jordan Justen writes: >>> >>> > From: Francisco Jerez >>> > >>> > Fixes >>> > arb_shader_image_load_store/execution/load-from-cleared-image.shader_test >>> > >>> > Cc: Chr

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Christian König
Patch #1: + if (buf->data) + FREE(buf->data); FREE() usually does a NULL check anyway. Apart from that minor nitpick the patch is Reviewed-by: Christian König Regards, Christian. On 29.10.2015 12:47, Julien Isorce wrote: And apply relatives change to: vlVaBufferSetNumElements vlVaCr

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

2015-10-29 Thread Christian König
@@ -108,6 +109,9 @@ vlVaMapBuffer(VADriverContextP ctx, VABufferID buf_id, void **pbuff) if (!buf) return VA_STATUS_ERROR_INVALID_BUFFER; + if (buf->export_refcount > 0) + return VA_STATUS_ERROR_INVALID_BUFFER; Why it is illegal to CPU map a buffer which is exported? +

Re: [Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

2015-10-29 Thread Marek Olšák
On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle wrote: > Without the clamping by NumLevels, the state tracker would reallocate the > texture storage (incorrect) and even fail to copy the base level image > after reallocation, leading to the graphical glitch of > https://bugs.freedesktop.org/show_b

Re: [Mesa-dev] [PATCH v2 6/8] st/va: handle Video Post Processing for configs

2015-10-29 Thread Christian König
On 22.10.2015 18:37, Julien Isorce wrote: Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce Reviewed-by: Christian König --- s

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

2015-10-29 Thread Christian König
+if(src_surface->fence) { + screen->fence_finish(screen, src_surface->fence, PIPE_TIMEOUT_INFINITE); + screen->fence_reference(screen, &src_surface->fence, NULL); +} That shouldn't be necessary cause all render operations to the same surface are pipelined anyway. Regards, Ch

[Mesa-dev] [PATCH] mesa: DispatchComputeIndirect should return INVALID_VALUE on unaligned

2015-10-29 Thread Marta Lofstedt
From: Marta Lofstedt From the ARB_compute_shader specification: "An INVALID_OPERATION error is generated [...] if is less than zero or not a multiple of the size, in basic machine units, of uint." However, OpenGL ES 3.1 specification, section 17 and OpenGL 4.5 specification, section 19, has th

[Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Emmanuel Gil Peyrot
This was causing compilation issues when one of its providers wasn’t already included before gbm.h. --- src/gbm/main/gbm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index 2708e50..8db2153 100644 --- a/src/gbm/main/gbm.h +++ b/src/gbm/main/gbm.h @@

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

2015-10-29 Thread Roland Scheidegger
Am 29.10.2015 um 12:27 schrieb Oded Gabbay: > Hi Roland, Jose > > I wanted to bring a problem I found to your attention, and discuss > about it and ways to solve it. > > I'm working on regressions of piglit gpu.py between x86-64 and > ppc64le, when running with llvmpipe. > > One of the regressio

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Emil Velikov
Hi Emmanuel, On 29 October 2015 at 15:22, Emmanuel Gil Peyrot wrote: > This was causing compilation issues when one of its providers wasn’t > already included before gbm.h. Cc: "11.0" Reviewed-by: Emil Velikov I'll push this later on today. For future patches please include your s-o-b line. -

[Mesa-dev] [Bug 92645] kodi vdpau interop fails since mesa, meta: move gl_texture_object::TargetIndex initializations

2015-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92645 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

2015-10-29 Thread Julien Isorce
Ack. I confirm it still works without it. So I'll remove it. Thx -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 14:02 To: Julien Isorce; mesa-dev@lists.freedesktop.org Cc: emil.l.veli...@gmail.com Subject: Re: [Mesa-dev] [PATCH v2 7/8] st/v

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
Ack. And I'll move this bit at the end just before the other FREE. Thx -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 12:22 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

[Mesa-dev] [PATCH] radeonsi: add ETC2 support for Stoney

2015-10-29 Thread Marek Olšák
From: Marek Olšák Untested. I don't have Stoney. --- src/gallium/drivers/radeonsi/si_state.c | 28 src/gallium/drivers/radeonsi/sid.h | 20 ++-- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_stat

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

2015-10-29 Thread Julien Isorce
-Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 12:29 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf > @@ -108,6 +109,9 @@ vlVaMapBuffer(VADriverConte

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

2015-10-29 Thread Julien Isorce
Hi Christian, Ok I'll send all of it including last 2 patches about dmabuf export. I addressed all remarks already in my local branch and I did some round of testing, so it should be ok. Cheers Julien On 29 October 2015 at 12:10, Christian König wrote: > Hi Julien, > > if Emil or Ilia have no

Re: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

2015-10-29 Thread Jordan Justen
On 2015-10-29 03:04:38, Iago Toral wrote: > On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/main/api_validate.c | 2 +- > > src/mesa/main/pipelineobj.c | 11 +++ > > 2 files changed, 12 insertions(+), 1 deletion(-) > > > > d

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Grazvydas Ignotas
Hi, On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov wrote: > On 29 October 2015 at 15:22, Emmanuel Gil Peyrot > wrote: >> This was causing compilation issues when one of its providers wasn’t >> already included before gbm.h. > Cc: "11.0" > Reviewed-by: Emil Velikov > > I'll push this later on to

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Always try to enable GL_ARB_sample_shading

2015-10-29 Thread Anuj Phogat
On Thu, Oct 22, 2015 at 2:34 AM, Neil Roberts wrote: > Previously this extension was only enabled when blitting between two > multisampled buffers. However I don't think it does any harm to just > enable it all the time. The ‘enable’ option is used instead of > ‘require’ so that the shader will st

[Mesa-dev] [PATCH v4 9/9] st/va: add support to export a surface as dmabuf

2015-10-29 Thread Julien Isorce
I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Tested with gstreamer-vaapi wit

[Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

2015-10-29 Thread Julien Isorce
For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_tr

[Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

2015-10-29 Thread Julien Isorce
Inspired from http://cgit.freedesktop.org/vaapi/intel-driver/ especially src/i965_drv_video.c::i965_CreateSurfaces2. This patch is mainly to support gstreamer-vaapi and tools that uses this newer libva API. The first advantage of using VaCreateSurfaces2 over existing VaCreateSurfaces, is that it i

[Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data arr

[Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-29 Thread Julien Isorce
This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium/state_trackers/va/context.c | 70 --- 2 files changed, 73 inse

[Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

2015-10-29 Thread Julien Isorce
Add support for VPP in the following functions: vlVaCreateContext vlVaDestroyContext vlVaBeginPicture vlVaRenderPicture vlVaEndPicture Add support for VAProcFilterNone in: vlVaQueryVideoProcFilters vlVaQueryVideoProcFilterCaps vlVaQueryVideoProcPipelineCaps Add handleVAProcPipelineParameterBuffer

[Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

2015-10-29 Thread Julien Isorce
If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by: Julien Isorce --- src/gallium/state_tracker

[Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

2015-10-29 Thread Julien Isorce
Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/config.c | 20 src/galliu

Re: [Mesa-dev] [PATCH] i965/nir: Mark const index UBO surfaces as used

2015-10-29 Thread Jordan Justen
On 2015-10-29 02:17:20, Iago Toral wrote: > On Thu, 2015-10-29 at 00:50 -0700, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- > > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- > > 2 files changed, 8 insertions(+),

[Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-29 Thread Julien Isorce
Also add RGBA, RGBX and BGRX. Also extend ChromaToPipe and implement PipeToYCbCr. Note that gstreamer-vaapi check all the VAImageFormat fields. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/image.c | 18 +++--- src/gallium/state_trackers/va/va_private.h | 38 ++

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Matt Turner
On Thu, Oct 29, 2015 at 10:15 AM, Grazvydas Ignotas wrote: > Hi, > > On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov > wrote: >> On 29 October 2015 at 15:22, Emmanuel Gil Peyrot >> wrote: >>> This was causing compilation issues when one of its providers wasn’t >>> already included before gbm.h. >

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 17:15, Grazvydas Ignotas wrote: > Hi, > > On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov > wrote: >> On 29 October 2015 at 15:22, Emmanuel Gil Peyrot >> wrote: >>> This was causing compilation issues when one of its providers wasn’t >>> already included before gbm.h. >> Cc:

[Mesa-dev] [PATCH 1/2] gallium/radeon: always return the last SDMA fence on SDMA flush if needed

2015-10-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 11 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.

  1   2   >