Re: [Mesa-dev] [PATCH 00/42] RadeonSI cleaning up states

2015-08-31 Thread Christian König
On 31.08.2015 05:50, Alex Deucher wrote: On Sun, Aug 30, 2015 at 3:11 PM, Marek Olšák wrote: Hi, Nothing special here, just a lot of cosmetic changes and a few micro-optimizations. This series starts with some fixes for 11.0 (patches 3-5). Then it converts a half of pm4 states into atoms. A

[Mesa-dev] [PATCH] mesa: change 'SHADER_SUBST' facility to work with env variables

2015-08-31 Thread Tapani Pälli
Patch modifies existing shader source and replace functionality to work with environment variables rather than enable dumping on compile time. Also instead of _mesa_str_checksum, _mesa_sha1_compute is used to avoid collisions. Functionality is controlled via 2 environment variables: MESA_SHADER_D

Re: [Mesa-dev] [PATCH] r600/sb: update last_cf for finalize if.

2015-08-31 Thread Glenn Kennard
On Mon, 31 Aug 2015 06:23:38 +0200, Dave Airlie wrote: From: Dave Airlie As Glenn did for finalize_loop we need to update_cf when we add a POP at the end of a shader. I think this fixes one of the earlier shader going off end of memory problems we've stopped. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH v2] mesa: Allow query of GL_VERTEX_BINDING_BUFFER

2015-08-31 Thread Marta Lofstedt
From: Marta Lofstedt According to OpenGL ES 3.1 specification table : 20.2 and OpenGL specification 4.4 table 23.4. The glGetIntegeri_v functions should report the name of the buffer bound when called with GL_VERTEX_BINDING_BUFFER. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 8 +++

Re: [Mesa-dev] No VAAPI driver hardlinks?

2015-08-31 Thread Emil Velikov
On 30 August 2015 at 00:21, Matt Turner wrote: > Hi Emil, > > src/gallium/targets/vdpau has a block that installs per-driver > hardlinks, but src/gallium/targets/va does not (presumably because it > was added later), which leads to: > > https://bugs.gentoo.org/549564 > > Presumably it's mostly a m

Re: [Mesa-dev] nv3x libreoffice impress opengl animations not working

2015-08-31 Thread Hans de Goede
Hi, On 28-08-15 11:02, Ilia Mirkin wrote: On Fri, Aug 28, 2015 at 4:54 AM, Hans de Goede wrote: Hi, On 27-08-15 20:19, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 1:59 PM, Alex Deucher wrote: 2) Since the glretrace does work outside of libreoffice impress, I think it may have somethin

[Mesa-dev] [PATCH v3] mesa: Allow query of GL_VERTEX_BINDING_BUFFER

2015-08-31 Thread Marta Lofstedt
From: Marta Lofstedt According to OpenGL ES 3.1 specification table : 20.2 and OpenGL specification 4.4 table 23.4. The glGetIntegeri_v functions should report the name of the buffer bound when called with GL_VERTEX_BINDING_BUFFER. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 8 +++

[Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

2015-08-31 Thread Chris Wilson
From: Jason Ekstrand If the user is specifying a subregion of a buffer using SKIP_ROWS and SKIP_PIXELS, we must compute the buffer size carefully as the end of the last row may be much shorter than stride*image_height*depth. The current code tries to memcpy from beyond the end of the user data, f

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

2015-08-31 Thread Chris Wilson
On Mon, Aug 31, 2015 at 02:47:48PM +0100, Chris Wilson wrote: > From: Jason Ekstrand Sorry for the confusion Jason, I was messing around with git trying to reference the right commit easily. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Mesa-dev] [PATCH 02/14] util: added ffsll() function

2015-08-31 Thread Brian Paul
On 08/28/2015 07:36 PM, Jason Ekstrand wrote: On Aug 28, 2015 2:31 PM, "Brian Paul" mailto:bri...@vmware.com>> wrote: > > v2: fix errant _GNU_SOURCE test, per Matt Turner. > --- > src/gallium/auxiliary/util/u_math.h | 20 > 1 file changed, 20 insertions(+) > > diff -

Re: [Mesa-dev] [PATCH 02/14] util: added ffsll() function

2015-08-31 Thread Jason Ekstrand
On Aug 31, 2015 7:35 AM, "Brian Paul" wrote: > > On 08/28/2015 07:36 PM, Jason Ekstrand wrote: >> >> >> On Aug 28, 2015 2:31 PM, "Brian Paul" > > wrote: >> > >> > v2: fix errant _GNU_SOURCE test, per Matt Turner. >> > --- >> > src/gallium/auxiliary/util/u_math.h | 20

Re: [Mesa-dev] [PATCH] mesa: change 'SHADER_SUBST' facility to work with env variables

2015-08-31 Thread Brian Paul
Looks good. Just some minor nitpicks below. Reviewed-by: Brian Paul On 08/31/2015 01:23 AM, Tapani Pälli wrote: Patch modifies existing shader source and replace functionality to work with environment variables rather than enable dumping on compile time. Also instead of _mesa_str_checksum, _

[Mesa-dev] Mesa 11.0.0 release candidate 2

2015-08-31 Thread Emil Velikov
The second release candidate for Mesa 11.0.0 is now available. Chris Wilson (1): i965: Always re-emit the pipeline select during invariant state emission Daniel Scharrer (1): mesa: add missing queries for ARB_direct_state_access Dave Airlie (5): mesa/arb_gpu_shader_fp64: add s

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Marcos Paulo de souza
ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog. Signed-off-by: Marcos Paulo de Souza --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Tobias Klausmann
On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog. It is not changing now, don't know if it will in the future. Using prog->getTarget() may save us from has

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann wrote: > > > On 31.08.2015 17:19, Marcos Paulo de souza wrote: >> >> ping :) >> >> Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: >>> >>> instead of call prog->getTarget(), since the target never change in prog. > > > It is not changing now,

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Tobias Klausmann
On 31.08.2015 18:23, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann wrote: On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog. It i

Re: [Mesa-dev] nv3x libreoffice impress opengl animations not working

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 8:58 AM, Hans de Goede wrote: > Hi, > > > On 28-08-15 11:02, Ilia Mirkin wrote: >> >> On Fri, Aug 28, 2015 at 4:54 AM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> On 27-08-15 20:19, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 1:59 PM, Alex Deucher wrote

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 12:26 PM, Tobias Klausmann wrote: > > > On 31.08.2015 18:23, Ilia Mirkin wrote: >> >> On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann >> wrote: >>> >>> >>> On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de

Re: [Mesa-dev] Mesa 11.0.0 release candidate 2

2015-08-31 Thread Marek Olšák
Hi Emil, Would you please also pick this for 11.0: commit 03b7ec877843cd622717b01c1047e08baf34facf r600: move prim convert from geom shader to function. It allegedly fixes a compile failure caused by "r600: port si_conv_prim_to_gs_out from radeonsi". Thanks, Marek On Mon, Aug 31, 2015 at 5:05

Re: [Mesa-dev] Mesa 11.0.0 release candidate 2

2015-08-31 Thread Rob Clark
Emil, could you also cherry-pick: afb6c24a207fe7b9917644b940e4c5d1870c5c92 and then 000e225360c020e8b3de142c4c898baad321d242 (the 2nd depends on the 1st) Those fix x11 font rendering (ie. xterm) with glamor.. BR, -R On Mon, Aug 31, 2015 at 12:55 PM, Marek Olšák wrote: > Hi Emil, > > Would yo

Re: [Mesa-dev] Mesa 11.0.0 release candidate 2

2015-08-31 Thread Alexander von Gluck IV
Good afternoon, One more cherry pick for 11.0: 5abbd1caccf4653ac1a8760de68d8ed101c814d8 egl: scons: fix the haiku build, do not build the dri2 backend Fixes the scons build after support for scons building egl + dri2 was dropped. -- Alex On 2015-08-31 10:05, Emil Velikov wrote: The second

Re: [Mesa-dev] [PATCH] i965/fs: Use greater-equal cmod to implement maximum.

2015-08-31 Thread Matt Turner
On Fri, Aug 28, 2015 at 6:42 PM, Jordan Justen wrote: > On 2015-08-28 17:12:31, Matt Turner wrote: >> See commit 3b7f683f. > > That commit message seems short enough to replicate, although it is > also valuable to mention the hash here too. > > Reviewed-by: Jordan Justen Thanks! > It almost see

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

2015-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91826 Bug ID: 91826 Summary: Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD Product: Mesa Version: 11.0 Hardware: x86-64 (AMD64) OS: FreeBSD

Re: [Mesa-dev] [PATCH 1/2] mesa/texcompress: correct mapping of S3TC formats in conversion function

2015-08-31 Thread Chad Versace
On Wed 26 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > MESA_FORMAT_RGBA_DXT5 should actually be reserved for GL_RGBA[4]_DXT5_S3TC. > Also, Gallium and other dri drivers (radeon and nouveau) follow this mapping > scheme. > > Cc: Brian Paul > Cc: Chad Versace > Cc: Ian Romanick > Sign

Re: [Mesa-dev] [PATCH v2 2/2] mesa/texformat: use format conversion function in _mesa_choose_tex_format

2015-08-31 Thread Chad Versace
On Fri 28 Aug 2015, Nanley Chery wrote: > I should add that this patch enables this function to handle ASTC formats. > This in turn enables such formats to be used for GL calls such as > Tex*Storage*. > > - Nanley > > On Wed, Aug 26, 2015 at 2:38 PM, Nanley Chery wrote: > > > From: Nanley Chery

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Marcos Paulo de souza
Em 31-08-2015 13:31, Ilia Mirkin escreveu: On Mon, Aug 31, 2015 at 12:26 PM, Tobias Klausmann wrote: On 31.08.2015 18:23, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann wrote: On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos P

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 5:28 PM, Marcos Paulo de souza wrote: > > > Em 31-08-2015 13:31, Ilia Mirkin escreveu: >> >> On Mon, Aug 31, 2015 at 12:26 PM, Tobias Klausmann >> wrote: >>> >>> >>> On 31.08.2015 18:23, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann

[Mesa-dev] [PATCH] mesa: Move gl_vert_attrib from mtypes.h to shader_enums.h

2015-08-31 Thread Jason Ekstrand
It is a shader enum after all... --- src/glsl/shader_enums.h | 108 src/mesa/main/mtypes.h | 107 --- 2 files changed, 108 insertions(+), 107 deletions(-) diff --git a/src/glsl/shader_enums.h b/src/glsl/

Re: [Mesa-dev] [PATCH demos] egl: Remove demos using EGL_MESA_screen_surface.

2015-08-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Aug 29, 2015 at 1:09 AM, Matt Turner wrote: > The remnants of the extension were removed from Mesa in commit 7a58262e. > > Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=555186 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91020 > Bugzilla: h

Re: [Mesa-dev] [PATCH 11/17] nir: Trivial clean ups in the generated nir_constant_expressions.c

2015-08-31 Thread Ian Romanick
On 08/27/2015 06:41 AM, Jason Ekstrand wrote: > > On Aug 27, 2015 4:08 AM, "Ian Romanick" > wrote: >> >> On 08/26/2015 10:11 PM, Jason Ekstrand wrote: >> > On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick > wrote: >> >> From: Ian Romanick

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-31 Thread Ian Romanick
ping. :) On 08/10/2015 11:48 AM, Matt Turner wrote: > On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> On many CPU-limited applications, this is *the* hot path. The idea is >> to generate per-API versions of brw_draw_prims that elide some checks. >> This patch r

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 7:06 PM, Ian Romanick wrote: > ping. :) > > On 08/10/2015 11:48 AM, Matt Turner wrote: >> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> On many CPU-limited applications, this is *the* hot path. The idea is >>> to generate per-API ve

Re: [Mesa-dev] [PATCH 5/6] mesa/formats: add some formats from GL3.3

2015-08-31 Thread Brian Paul
On 08/25/2015 07:14 PM, Dave Airlie wrote: From: Dave Airlie GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies a lot more things than just rgb10/a2ui. While playing with ogl conform one of the tests must attempted all valid formats for GL3.3 and hits the unreachable here. This adds the f

Re: [Mesa-dev] [PATCH 5/6] mesa/formats: add some formats from GL3.3

2015-08-31 Thread Dave Airlie
On 1 September 2015 at 09:34, Brian Paul wrote: > On 08/25/2015 07:14 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies >> a lot more things than just rgb10/a2ui. >> >> While playing with ogl conform one of the tests must >> attempted all

[Mesa-dev] [PATCH] i965: enable ASTC for Cherryview

2015-08-31 Thread Nanley Chery
From: Nanley Chery Add modifications necessary to get ASTC functional on Cherryview. Cc: Chad Versace Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_tex_layout.c | 55 +++--- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH] nir/builder: Use nir_after_instr to advance the cursor

2015-08-31 Thread Jason Ekstrand
This *should* ensure that the cursor gets properly advanced in all cases. We had a problem before where, if the cursor was created using nir_after_cf_node on a non-block cf_node, that would call nir_before_block on the block following the cf node. Instructions would then get inserted in backwards

Re: [Mesa-dev] [PATCH] i965: enable ASTC for Cherryview

2015-08-31 Thread Matt Turner
On Mon, Aug 31, 2015 at 4:45 PM, Nanley Chery wrote: > From: Nanley Chery > > Add modifications necessary to get ASTC functional on Cherryview. > > Cc: Chad Versace > Signed-off-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/brw_defines.h| 1 + > src/mesa/drivers/dri/i965/brw_tex_

Re: [Mesa-dev] [PATCH] i965: enable ASTC for Cherryview

2015-08-31 Thread Nanley Chery
On Mon, Aug 31, 2015 at 4:58 PM, Matt Turner wrote: > On Mon, Aug 31, 2015 at 4:45 PM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Add modifications necessary to get ASTC functional on Cherryview. > > > > Cc: Chad Versace > > Signed-off-by: Nanley Chery > > --- > > src/mesa/drivers/

Re: [Mesa-dev] [PATCH] nir/builder: Use nir_after_instr to advance the cursor

2015-08-31 Thread Kenneth Graunke
On Monday, August 31, 2015 04:55:51 PM Jason Ekstrand wrote: > This *should* ensure that the cursor gets properly advanced in all cases. > We had a problem before where, if the cursor was created using > nir_after_cf_node on a non-block cf_node, that would call nir_before_block > on the block follo

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-31 Thread Ian Romanick
On 08/31/2015 04:21 PM, Ilia Mirkin wrote: > On Mon, Aug 31, 2015 at 7:06 PM, Ian Romanick wrote: >> ping. :) >> >> On 08/10/2015 11:48 AM, Matt Turner wrote: >>> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: From: Ian Romanick On many CPU-limited applications, this is *th

Re: [Mesa-dev] [PATCH] i965: enable ASTC for Cherryview

2015-08-31 Thread Matt Turner
On Mon, Aug 31, 2015 at 5:02 PM, Nanley Chery wrote: > On Mon, Aug 31, 2015 at 4:58 PM, Matt Turner wrote: >> (what's this patch against? I don't have this in my tree) > > > This is against mesa master. It's not -- for instance, current intel_extensions.c does not contain the string "astc".

Re: [Mesa-dev] [PATCH] i965: enable ASTC for Cherryview

2015-08-31 Thread Nanley Chery
On Mon, Aug 31, 2015 at 5:16 PM, Matt Turner wrote: > On Mon, Aug 31, 2015 at 5:02 PM, Nanley Chery > wrote: > > On Mon, Aug 31, 2015 at 4:58 PM, Matt Turner wrote: > >> (what's this patch against? I don't have this in my tree) > > > > > > This is against mesa master. > > It's not -- for instan

Re: [Mesa-dev] [PATCH] nir/builder: Use nir_after_instr to advance the cursor

2015-08-31 Thread Jason Ekstrand
On Mon, Aug 31, 2015 at 5:04 PM, Kenneth Graunke wrote: > On Monday, August 31, 2015 04:55:51 PM Jason Ekstrand wrote: >> This *should* ensure that the cursor gets properly advanced in all cases. >> We had a problem before where, if the cursor was created using >> nir_after_cf_node on a non-block

[Mesa-dev] [PATCH] r600g: fix calculation for gpr allocation

2015-08-31 Thread Dave Airlie
From: Dave Airlie I've been chasing a geom shader hang on rv635 since I wrote r600 geom code, and finally I hacked some values from fglrx in and I could run texelfetch without failures. This is totally my fault as well, maths fail 101. This makes geom shaders on r600 not fail heavily. Cc: "10.

Re: [Mesa-dev] [PATCH] r600g: fix calculation for gpr allocation

2015-08-31 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 1, 2015, at 12:34 PM, Dave Airlie wrote: > From: Dave Airlie > > I've been chasing a geom shader hang on rv635 since I wrote > r600 geom code, and finally I hacked some values from fglrx > in an

Re: [Mesa-dev] [PATCH] r600g: fix calculation for gpr allocation

2015-08-31 Thread Alex Deucher
On Mon, Aug 31, 2015 at 10:34 PM, Dave Airlie wrote: > From: Dave Airlie > > I've been chasing a geom shader hang on rv635 since I wrote > r600 geom code, and finally I hacked some values from fglrx > in and I could run texelfetch without failures. > > This is totally my fault as well, maths fail

[Mesa-dev] [PATCH 2/2] mesa: Don't allow wrong type setters for matrix uniforms

2015-08-31 Thread Ian Romanick
From: Ian Romanick Previously we would allow glUniformMatrix4fv on a dmat4 and glUniformMatrix4dv on a mat4. Both are illegal. That later also overwrites the storage for the mat4 and causes bad things to happen. Should fix the (new) arb_gpu_shader_fp64-wrong-type-setter piglit test. Signed-of

[Mesa-dev] [PATCH 1/2] mesa: Pass the type to _mesa_uniform_matrix as a glsl_base_type

2015-08-31 Thread Ian Romanick
From: Ian Romanick This matches _mesa_uniform, and it enables the bug fix in the next patch. Signed-off-by: Ian Romanick Cc: Dave Airlie Cc: "10.6 11.0 " --- src/mesa/main/uniform_query.cpp | 10 +++--- src/mesa/main/uniforms.c| 72 - src/mesa/m

Re: [Mesa-dev] [PATCH 1/2] mesa: Pass the type to _mesa_uniform_matrix as a glsl_base_type

2015-08-31 Thread Timothy Arceri
On Mon, 2015-08-31 at 20:56 -0700, Ian Romanick wrote: > From: Ian Romanick > > This matches _mesa_uniform, and it enables the bug fix in the next > patch. > > Signed-off-by: Ian Romanick Both are: Reviewed-by: Timothy Arceri > Cc: Dave Airlie > Cc: "10.6 11.0 " > --- > src/mesa/main/unif

[Mesa-dev] [PATCH 1/2] mesa: fix SwapBytes handling in numerous places

2015-08-31 Thread Dave Airlie
From: Dave Airlie In a number of places the SwapBytes handling didn't handle cases with GL_(UN)PACK_ALIGNMENT set and 7 byte width cases aligned to 8 bytes. This adds a common routine to swap bytes a 2D image and uses this code in the: texture store texture getting readpixels and swrast drawpixe

[Mesa-dev] [PATCH 2/2] mesa: handle SwapBytes in compressed texture get code.

2015-08-31 Thread Dave Airlie
This case just wasn't handled, so add support for it. Signed-off-by: Dave Airlie --- src/mesa/main/texgetimage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 0c23687..52ed1ef 100644 --- a/src/mesa/main/texgetimage.c ++

Re: [Mesa-dev] [PATCH 1/6] mesa: fix SwapBytes handling in texstore.

2015-08-31 Thread Dave Airlie
On 28 August 2015 at 09:16, Brian Paul wrote: > Some of the commit messages, like this one, seem to line-wrapped shorter > than necessary. > > For patches 1-4, the changes look OK, AFAICT. Though, it seems there's some > very similar byte-swap code duplicated in several places. Would it be > pos

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

2015-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #1 from Albert Freeman --- I believe the fix for this is in mesa master. Here is the patch: https://patchwork.freedesktop.org/patch/56716/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assig

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

2015-08-31 Thread Jason Ekstrand
On Aug 31, 2015 6:48 AM, "Chris Wilson" wrote: > > From: Jason Ekstrand > > If the user is specifying a subregion of a buffer using SKIP_ROWS and > SKIP_PIXELS, we must compute the buffer size carefully as the end of the > last row may be much shorter than stride*image_height*depth. The current >

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

2015-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #2 from Albert Freeman --- Ignore my last comment, it is wrong, I got very confused. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-31 Thread Eirik Byrkjeflot Anonsen
Ian Romanick writes: > ping. :) > > On 08/10/2015 11:48 AM, Matt Turner wrote: >> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> On many CPU-limited applications, this is *the* hot path. The idea is >>> to generate per-API versions of brw_draw_prims that e

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-08-31 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 1:48 AM, Eirik Byrkjeflot Anonsen wrote: > Ian Romanick writes: > >> ping. :) >> >> On 08/10/2015 11:48 AM, Matt Turner wrote: >>> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: From: Ian Romanick On many CPU-limited applications, this is *the* hot p

[Mesa-dev] [PATCH 2/3] texcompress_s3tc: fix stride checks

2015-08-31 Thread Dave Airlie
From: Dave Airlie The fastpath currently checks the stride != width, but if you have a RowLength of 7, and Alignment of 4, then that shuoldn't match. align the rowlength to the pack alignment before comparing. This fixes compressed cases in CTS packed_pixels_pixelstore test when SKIP_PIXELS is

[Mesa-dev] [PATCH 1/3] st/readpixels: fix accel path for skipimages.

2015-08-31 Thread Dave Airlie
From: Dave Airlie We don't need to use the 3d image address here as that will include SKIP_IMAGES, and we are only blitting a single 2D anyways, so just use the 2D path. This fixes some memory overruns under CTS packed_pixels.packed_pixels_pixelstore when PACK_SKIP_IMAGES is used. Signed-off-b

[Mesa-dev] [PATCH 3/3] mesa/readpixels: check strides are equal before skipping conversion

2015-08-31 Thread Dave Airlie
From: Dave Airlie The CTS packed_pixels test checks that readpixels doesn't write into the space between rows, however we fail that here unless we check the format and stride match. This fixes all the core mesa problems with CTS packed_pixels tests. Signed-off-by: Dave Airlie --- src/mesa/mai

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

2015-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #3 from Albert Freeman --- Well changing typename to enum seems to fix the problem: diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 7c23a27..d74b50d 100

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

2015-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #4 from Albert Freeman --- You should probably report this to the clang developers too. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __