On 08/25/2015 07:14 PM, Dave Airlie wrote:
From: Dave Airlie <airl...@redhat.com>

GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies
a lot more things than just rgb10/a2ui.

While playing with ogl conform one of the tests must
attempted all valid formats for GL3.3 and hits the
unreachable here.

This adds the first chunk of formats that hit the
assert.

Signed-off-by: Dave Airlie <airl...@redhat.com>

Hi Dave,

I stumbled across this area when working on a new GL_ARB_copy_image test, but it's really a GL_EXT_texture_integer issue. So I wrote a new piglit test (see my recent review request) that exercises glTexImage2D and glGetTexImage with the GL_EXT_texture_integer formats. It passes with NVIDIA but hits an assertion in Mesa:

ext_texture_integer-texformats: main/glformats.c:2895: _mesa_format_from_format_and_type: Assertion `!"Unsupported format"' failed.

The issue is, when calling glTexImage2D(intFormat=GL_RGBA8UI, format=GL_RGBA_INTEGER, type=GL_UNSIGNED_INT_8_8_8_8) the texstore code tries to find a Mesa format which exactly matches GL_RGBA_INTEGER + GL_UNSIGNED_INT_8_8_8_8 and fails.

It looks like your patch _should_ fix this.

Dave, can you check my new piglit test against your patch? I've run out of time to check it myself today. If it passes, I'll take a closer look at your Mesa patch. I think you're still waiting on a review of it.

-Brian

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to