[Mesa-dev] [PATCH v2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-27 Thread Marta Lofstedt
From: Marta Lofstedt V2: Conform to new standard for exposing enums for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/mapi/glapi/gen/ARB_framebuffer_no_attachments.xml | 4 ++-- src/mapi/glapi/gen/apiexec.py | 4 ++-- src/mesa/main/get_hash_params.py

Re: [Mesa-dev] [PATCH] Revert "i965: Stop aux data compare preventing program binary re-use"

2015-08-27 Thread Pohjolainen, Topi
On Wed, Aug 26, 2015 at 03:46:05PM -0700, Ben Widawsky wrote: > This reverts commit 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf > Author: Topi Pohjolainen > Date: Thu Jun 25 14:00:41 2015 +0300 > > i965: Stop aux data compare preventing program binary re-use > > This fixes an intermittent fai

Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

2015-08-27 Thread Eduardo Lima Mitev
On 07/30/2015 05:05 PM, Predut, Marius wrote: > Was sent 2 month ago, still not review/upstream > > -Original Message- > From: Predut, Marius > Sent: Thursday, July 30, 2015 7:04 PM > To: mesa-dev@lists.freedesktop.org > Cc: Predut, Marius > Subject: [Mesa-dev][PATCH] i915/aa: fixing anti

Re: [Mesa-dev] [PATCH 03/17] i965: Make gen8_upload_state_base_address static

2015-08-27 Thread Pohjolainen, Topi
On Wed, Aug 26, 2015 at 06:19:52PM +0100, Ian Romanick wrote: > From: Ian Romanick > > All of the other state upload functions are static because the only use > is in the brw_tracked_state structure. If and when I get my "i965-meta-ops reusing blorp launch"-series to be available again, I need t

Re: [Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Pohjolainen, Topi
On Mon, Aug 24, 2015 at 05:04:22PM -0600, Brian Paul wrote: > Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures > to wrap renderbuffer sources/destinations. This caused a bit of a mess in > the Mesa/gallium state tracker because we had to basically undo that > wrapping. >

[Mesa-dev] [Bug 91711] mesa-9.1.3: undefined reference to `wglGetProcAddress@4'

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91711 --- Comment #1 from YuGiOhJCJ --- OK I found how to solve this problem. Instead of using the libopengl32.a file provided by mesa I need to use the one provided by my cross-compiler. The problem is that my current cross-compiler [1] does not provi

Re: [Mesa-dev] [PATCH] st/mesa: use PROGRAM_ARRAY for storing structs containing arrays

2015-08-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 26, 2015 at 10:55 PM, Brian Paul wrote: > Previously, we used PROGRAM_ARRAY only for variables which were > arrays or matrices. But if the variable is a structure containing > an array or matrix, we need to use PROGRAM_ARRAY for that too. > > Before,

Re: [Mesa-dev] [PATCH 04/17] i965: Make gen7_enable_hw_binding_tables static

2015-08-27 Thread Abdiel Janulgue
On 08/26/2015 08:19 PM, Ian Romanick wrote: > From: Ian Romanick > > All of the other state upload functions are static because the only use > is in the brw_tracked_state structure. > > Signed-off-by: Ian Romanick This patch is Reviewed-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 03/17] i965: Make gen8_upload_state_base_address static

2015-08-27 Thread Ian Romanick
On 08/27/2015 09:19 AM, Pohjolainen, Topi wrote: > On Wed, Aug 26, 2015 at 06:19:52PM +0100, Ian Romanick wrote: >> From: Ian Romanick >> >> All of the other state upload functions are static because the only use >> is in the brw_tracked_state structure. > > If and when I get my "i965-meta-ops re

Re: [Mesa-dev] [PATCH 11/17] nir: Trivial clean ups in the generated nir_constant_expressions.c

2015-08-27 Thread Ian Romanick
On 08/26/2015 10:11 PM, Jason Ekstrand wrote: > On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/glsl/nir/nir_constant_expressions.py | 13 + >> 1 file changed, 5 insertions(+), 8 deletions(-) >> >> diff --gi

Re: [Mesa-dev] [PATCH] st/mesa: cache tgsi opcode info in the instruction

2015-08-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Aug 27, 2015 at 2:02 AM, Dave Airlie wrote: > From: Dave Airlie > > Instead of looking this up lots, lets just cache it in the instruction > translation up front. I just noticed this function what high in a profile > of shader-db on radeonsi. > > Signed-o

Re: [Mesa-dev] [PATCH 09/17] nir: Fix wonkey indentation in generated code

2015-08-27 Thread Ian Romanick
On 08/26/2015 06:44 PM, Jason Ekstrand wrote: > I think I'd rather just run it through indent like we do for some of > the other auto-generated code. That way the mako file (the one you'll > actually be editing) can remain readable. I had thought about doing that. We use indent in a few places w

Re: [Mesa-dev] [PATCH 1/2] st/mesa: reduce time spent in calculating temp read/writes

2015-08-27 Thread Marek Olšák
We could just skip this for radeonsi or any driver that does regalloc, because it's useless there. Marek On Thu, Aug 27, 2015 at 5:30 AM, Dave Airlie wrote: > From: Dave Airlie > > The glsl->tgsi convertor does some temporary register reduction > however in profiling shader-db this shows up qui

[Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Hans de Goede
Hi All, While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 I made a apitrace recording of the a single slide transition animation, and since I suspected memory corruption replayed it using ElectrFence + glretrace, this finds a 0 sized array allocation at src/mesa/state_tracker/

Re: [Mesa-dev] [PATCH 11/17] nir: Trivial clean ups in the generated nir_constant_expressions.c

2015-08-27 Thread Jason Ekstrand
On Aug 27, 2015 4:08 AM, "Ian Romanick" wrote: > > On 08/26/2015 10:11 PM, Jason Ekstrand wrote: > > On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> Signed-off-by: Ian Romanick > >> --- > >> src/glsl/nir/nir_constant_expressions.py | 13 + > >

Re: [Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Marek Olšák
On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede wrote: > Hi All, > > While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 > > I made a apitrace recording of the a single slide transition > animation, and since I suspected memory corruption replayed > it using ElectrFence + glretrace

[Mesa-dev] [PATCH 2/8] nouveau: remove nouveau_vp3_bsp to use begin/next/end

2015-08-27 Thread Julien Isorce
https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 6 -- .../drivers/nouveau/nouveau_vp3_video_bsp.c| 79 -- src/gallium/drivers/nouveau/nv50/nv98_video_bsp.c | 5 +- src/gallium/

[Mesa-dev] [PATCH 7/8] nouveau: fix chunk decoding by updating number of slices

2015-08-27 Thread Julien Isorce
https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c b/src/gallium/drivers/nouveau/nouveau_vp3_video_bsp

[Mesa-dev] [PATCH 1/8] nouveau: extract memcpy loop from nouveau_vp3_bsp

2015-08-27 Thread Julien Isorce
This patch add 3 functions to split nouveau_vp3_bsp: nouveau_vp3_bsp_begin nouveau_vp3_bsp_next nouveau_vp3_bsp_end https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 15 +++ .../drivers/nouveau/nouveau_vp3_

[Mesa-dev] [PATCH 4/8] nouveau: preserve content buffer when calling nvc0_decoder_bsp_next

2015-08-27 Thread Julien Isorce
https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c | 34 +++ 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c b/src/gallium/drive

[Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

2015-08-27 Thread Julien Isorce
Currently nouveau does not support chunk decoding which is required to support st/va The following patches refactor nouveau_vp3_bsp and nvc0_decoder_bsp in order to implement pipe_video_codec::begin_frame/decode_bitstream/end_frame. So that decode_bitstream can be call multiple times between each

[Mesa-dev] [PATCH 3/8] nouveau: split nvc0_decoder_bsp in begin/next/end

2015-08-27 Thread Julien Isorce
It will allow to call nvc0_decoder_bsp_next's content mutlitple times between one begin/end. https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_video.h | 14 ++ src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c | 197 ++

[Mesa-dev] [PATCH 8/8] build: enable st/va with nouveau driver

2015-08-27 Thread Julien Isorce
vainfo fails in vaDriverInit because "dd_create_screen" does not reach strcmp(driver_name, "nouveau") code. Indeed when compiling the va target.c, the macro GALLIUM_NOUVEAU is not defined. This patch define the macro the same it is done for dri and vdpau targets. Tested with: ./autogen.sh --enable

[Mesa-dev] [PATCH 6/8] nvc0: implement pipe_video_codec::begin_frame/end_frame

2015-08-27 Thread Julien Isorce
In order to add support for chunck decoding. Required to support st/va. https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 48 +-- 1 file changed, 37 insertions(+), 11 deletions(-) diff --gi

[Mesa-dev] [PATCH 5/8] nouveau: remove nvc0_decoder_bsp and use begin/next/end instead

2015-08-27 Thread Julien Isorce
https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 12 +- src/gallium/drivers/nouveau/nvc0/nvc0_video.h | 8 -- src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c | 167 -- 3 files chan

Re: [Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Brian Paul
On 08/27/2015 02:28 AM, Pohjolainen, Topi wrote: On Mon, Aug 24, 2015 at 05:04:22PM -0600, Brian Paul wrote: Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker becau

[Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-27 Thread Marcos Paulo de Souza
instead of call prog->getTarget(), since the target never change in prog. Signed-off-by: Marcos Paulo de Souza --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gall

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 --- Comment #2 from Sinclair Yeh --- Can you provide output from glxinfo? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mai

[Mesa-dev] [PATCH 2/3] r600g/sb: Don't read junk after EOP

2015-08-27 Thread Glenn Kennard
Shaders that contain instruction data after an instruction with EOP could end up parsing that as an instruction, leading to various crashes and asserts in SB as it gets very confused if it sees for instance a loop start instruction jumping off to some random point. Add a couple of asserts, and pri

[Mesa-dev] [PATCH 1/3] r600g/sb: Handle undef in read port tracker

2015-08-27 Thread Glenn Kennard
e8e443 missed adding check for undef values also in unreserve function, leading to an assert triggering. Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/sb/sb_sched.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_sched.cpp b/src/g

Re: [Mesa-dev] [PATCH] Revert "i965: Stop aux data compare preventing program binary re-use"

2015-08-27 Thread Ben Widawsky
On Thu, Aug 27, 2015 at 10:51:59AM +0300, Pohjolainen, Topi wrote: > On Wed, Aug 26, 2015 at 03:46:05PM -0700, Ben Widawsky wrote: > > This reverts commit 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf > > Author: Topi Pohjolainen > > Date: Thu Jun 25 14:00:41 2015 +0300 > > > > i965: Stop aux da

[Mesa-dev] [PATCH 3/3] r600g/sb: Don't crash on empty if jump target

2015-08-27 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_bc_parser.cpp b/src/gallium/drivers/r600/sb/sb_bc_parser.cpp index 748aae2..c479927 100644 --- a/src/gallium/driver

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

2015-08-27 Thread Emil Velikov
HI Julien, On 27 August 2015 at 15:15, Julien Isorce wrote: > Currently nouveau does not support chunk decoding > which is required to support st/va > > The following patches refactor nouveau_vp3_bsp > and nvc0_decoder_bsp in order to implement > pipe_video_codec::begin_frame/decode_bitstream/end

Re: [Mesa-dev] [PATCH 1/3] r600g/sb: Handle undef in read port tracker

2015-08-27 Thread Emil Velikov
Hi Glenn, On 27 August 2015 at 18:04, Glenn Kennard wrote: > e8e443 missed adding check for undef values also in > unreserve function, leading to an assert triggering. > Can you please add the mesa-stable tag before pushing this series. Please also add 10.6 if applicable. Thanks Emil ___

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 1:11 PM, Emil Velikov wrote: > HI Julien, > > On 27 August 2015 at 15:15, Julien Isorce wrote: >> Currently nouveau does not support chunk decoding >> which is required to support st/va >> >> The following patches refactor nouveau_vp3_bsp >> and nvc0_decoder_bsp in order t

Re: [Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Hans de Goede
Hi, On 27-08-15 15:46, Marek Olšák wrote: On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede wrote: Hi All, While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 I made a apitrace recording of the a single slide transition animation, and since I suspected memory corruption replaye

Re: [Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Alex Deucher
On Thu, Aug 27, 2015 at 1:55 PM, Hans de Goede wrote: > Hi, > > On 27-08-15 15:46, Marek Olšák wrote: >> >> On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede >> wrote: >>> >>> Hi All, >>> >>> While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 >>> >>> I made a apitrace recording of

Re: [Mesa-dev] [Nouveau] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 1:59 PM, Alex Deucher wrote: > On Thu, Aug 27, 2015 at 1:55 PM, Hans de Goede wrote: >> Hi, >> >> On 27-08-15 15:46, Marek Olšák wrote: >>> >>> On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede >>> wrote: Hi All, While debugging: https://bugzilla.redhat.c

Re: [Mesa-dev] [PATCH 1/5] nir: Make nir_block_{first, last}_instr return NULL for empty blocks.

2015-08-27 Thread Jason Ekstrand
On Tue, Aug 25, 2015 at 1:24 PM, Kenneth Graunke wrote: > This is a lot more reasonable than returning an offset from NULL. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir

[Mesa-dev] [PATCH 2/2] i965/gen: Don't conflate base miplevel in sampler state

2015-08-27 Thread Ben Widawsky
Gen9 changes the meaning of this to coarse LOD quality mode. Although that's a desirable thing to be setting, it doesn't match the gen8 behavior and this was unintentional. This doesn't fix, or regress anything on SKL (AFAICT). Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_sampl

[Mesa-dev] [PATCH 1/2] i965/gen9: Annotate input coverage mask change

2015-08-27 Thread Ben Widawsky
As far as I can tell, the behavior is preserved from the previous generations. Before we set a single bit to tell the FS whether or not we'll be using an input coverage mask. Now we have some options which are implementing various extensions. These bits are used for the various conservative rasteri

Re: [Mesa-dev] [PATCH 1/5] nir: Make nir_block_{first, last}_instr return NULL for empty blocks.

2015-08-27 Thread Jason Ekstrand
On Thu, Aug 27, 2015 at 11:45 AM, Jason Ekstrand wrote: > On Tue, Aug 25, 2015 at 1:24 PM, Kenneth Graunke > wrote: >> This is a lot more reasonable than returning an offset from NULL. >> >> Signed-off-by: Kenneth Graunke >> --- >> src/glsl/nir/nir.h | 4 ++-- >> 1 file changed, 2 insertions(+

Re: [Mesa-dev] [PATCH 0/2] i965: Two more UNIFORM cleanups

2015-08-27 Thread Kenneth Graunke
On Wednesday, August 26, 2015 10:24:04 AM Jason Ekstrand wrote: > These two patches are largely a re-send of other patches in my bigger > series to push small uniform arrays. The first patch is a really nice > cleanup that I think we want regardless of pushing uniform arrays. > Unfortunately, it w

Re: [Mesa-dev] [PATCH 2/2] i965/gen: Don't conflate base miplevel in sampler state

2015-08-27 Thread Ben Widawsky
On Thu, Aug 27, 2015 at 11:50:52AM -0700, Ben Widawsky wrote: Subject should read gen9. Fixed locally > Gen9 changes the meaning of this to coarse LOD quality mode. Although that's a > desirable thing to be setting, it doesn't match the gen8 behavior and this was > unintentional. > > This doesn'

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > v2: > - Reduce the number of lines over 80 character line width > limit. (Thomas Hellan) > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 190 >

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > v2: > - Reduce the number of lines over 80 character line width > limit. (Thomas Hellan) > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 190 >

[Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
Cube maps are special in that they have separate teximages for each face. We handled that by copying the data to them separately, but in case zoffset != 0 or depth != 6 we would read off the end of the client array or modify the wrong images. zoffset/depth have already been verified by the time th

Re: [Mesa-dev] [PATCH 1/2] st/mesa: reduce time spent in calculating temp read/writes

2015-08-27 Thread Dave Airlie
On 27 August 2015 at 21:57, Marek Olšák wrote: > We could just skip this for radeonsi or any driver that does regalloc, > because it's useless there. I did expect this comment from Ilia, though adding a CAP and piping it through is an option I'd look into later. (or someone who cares can do it so

Re: [Mesa-dev] [PATCH 1/2] st/mesa: reduce time spent in calculating temp read/writes

2015-08-27 Thread Marek Olšák
Yes, I think it's useful too. I'm not familiar with this code, so you can add Acked-by: Marek Olšák and commit if there is no reviewer. Marek On Thu, Aug 27, 2015 at 9:48 PM, Dave Airlie wrote: > On 27 August 2015 at 21:57, Marek Olšák wrote: >> We could just skip this for radeonsi or any dr

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 01:43 PM, Ilia Mirkin wrote: Cube maps are special in that they have separate teximages for each face. We handled that by copying the data to them separately, but in case zoffset != 0 or depth != 6 we would read off the end of the client array or modify the wrong images. zoffset/de

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: > On 08/27/2015 01:43 PM, Ilia Mirkin wrote: >> >> Cube maps are special in that they have separate teximages for each >> face. We handled that by copying the data to them separately, but in >> case zoffset != 0 or depth != 6 we would read off the

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: > On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: >> On 08/27/2015 01:43 PM, Ilia Mirkin wrote: >>> >>> Cube maps are special in that they have separate teximages for each >>> face. We handled that by copying the data to them separately, but

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 03:05 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: Cube maps are special in that they have separate teximages for each face. We handled that by copying t

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 5:15 PM, Brian Paul wrote: > On 08/27/2015 03:05 PM, Ilia Mirkin wrote: >> >> On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: >>> >>> On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: > > > Cube maps ar

[Mesa-dev] [PATCH] mesa: rename rowStride to imageStride in texturesubimage()

2015-08-27 Thread Brian Paul
--- src/mesa/main/teximage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8d94903..3647854 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3764,7 +3764,7 @@ texturesubimage(struct gl_c

Re: [Mesa-dev] [PATCH] mesa: rename rowStride to imageStride in texturesubimage()

2015-08-27 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Aug 27, 2015 at 5:16 PM, Brian Paul wrote: > --- > src/mesa/main/teximage.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 8d94903..3647854 100644 > --- a/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 03:15 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 5:15 PM, Brian Paul wrote: On 08/27/2015 03:05 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: C

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

2015-08-27 Thread Emil Velikov
On 27 August 2015 at 18:35, Ilia Mirkin wrote: > On Thu, Aug 27, 2015 at 1:11 PM, Emil Velikov > wrote: >> HI Julien, >> >> On 27 August 2015 at 15:15, Julien Isorce wrote: >>> Currently nouveau does not support chunk decoding >>> which is required to support st/va >>> >>> The following patches

Re: [Mesa-dev] [PATCH 1/3] r600g/sb: Handle undef in read port tracker

2015-08-27 Thread Dieter Nützel
Hello Glenn, with your series I got some steps forward on this one: [r600g] regression: SB-related NI/Turks crash on 'gsraytrace' https://bugs.freedesktop.org/show_bug.cgi?id=91503 Crash is GONE. GPU hang is BACK _without_ R600_DEBUG=nosb. With R600_DEBUG=nosb vsraytrace, fsraytrace and gsrayt

Re: [Mesa-dev] [PATCH v2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 3:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > V2: Conform to new standard for exposing enums for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt Reviewed-by: Ilia Mirkin While this patch is fine, it appears that ES3.1 doesn't have GL_FRAMEBUFFER_DEFAULT_LA

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Annotate input coverage mask change

2015-08-27 Thread Ben Widawsky
On Thu, Aug 27, 2015 at 11:50:51AM -0700, Ben Widawsky wrote: > As far as I can tell, the behavior is preserved from the previous generations. > Before we set a single bit to tell the FS whether or not we'll be using an > input > coverage mask. Now we have some options which are implementing vario

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 Bug ID: 91783 Summary: Requesting Account Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity: normal Priority: medi

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #1 from Arsen Tufankjian --- Created attachment 117956 --> https://bugs.freedesktop.org/attachment.cgi?id=117956&action=edit GPG Public Key -- You are receiving this mail because: You are the QA Contact for the bug. You are the as

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #2 from Brian Paul --- I don't recall seeing any patches from you on the mesa-dev list yet. Generally, we don't give git commit access until the developer has some track record of producing good patches. -- You are receiving this ma

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #3 from Arsen Tufankjian --- Oops you're right I didn't RTFM. This can be closed for now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 1/6] mesa: fix SwapBytes handling in texstore.

2015-08-27 Thread Brian Paul
Some of the commit messages, like this one, seem to line-wrapped shorter than necessary. For patches 1-4, the changes look OK, AFAICT. Though, it seems there's some very similar byte-swap code duplicated in several places. Would it be possible to write a function which does byte swapping for

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Brian Paul
If you've seen the announcement of VMware Workstation 12 / Fusion 8, we now support OpenGL 3.3 in the guest. The Mesa/gallium patches for this can be seen in my git repo at cgit.freedesktop.org/~brianp/mesa/log/?h=vmware-gl3 The first 15 patches or so are general gallium util/tgsi/etc chang

[Mesa-dev] [PATCH 2/9] util: update util_resource_copy_region() for GL_ARB_copy_image

2015-08-27 Thread Brian Paul
This primarily means added support for copying between compressed and uncompressed formats. --- src/gallium/auxiliary/util/u_surface.c | 106 +++-- 1 file changed, 88 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxi

[Mesa-dev] [PATCH 7/9] softpipe: don't use 3-component formats

2015-08-27 Thread Brian Paul
Mesa and gallium don't have a complete set of matching 3-component texture formats. For example, 8-bit sRGB unorm. To fully support the GL_ARB_copy_image extension we need to have support for all of these formats: RGB8_UNORM, RGB8_SNORM, RGB8_SRGB, RGB8_UINT, and RGB8_SINT using the same componen

[Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
This enables GL_ARB_copy_image for softpipe. --- src/gallium/drivers/softpipe/sp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 817572c..4cd8581 100644 --- a/src/gallium/drive

[Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Brian Paul
From: Neha Bhende Basically, get the src/dst pipe_resource surfaces and call the pipe_context::resource_copy_region() function. Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_copyimage.c | 94 src/mesa

[Mesa-dev] [PATCH 1/9] mesa, i965: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Brian Paul
Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx->Driver.CopyImageSubData() to take both gl_rende

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-27 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. Reviewed-by: Marek Olšák --- src/mesa/state

[Mesa-dev] [PATCH 6/9] st/mesa: enable GL_ARB_copy_image if driver supports PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 13d636f..dfa8936 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_

[Mesa-dev] [PATCH 9/9] llvmpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
We have to disallow the 8 and 16-bit 3-component formats for non-display target surfaces as we do for softpipe (see earlier commit). v2: Simplify 3-component format check, per Marek. Also check that target != PIPE_BUFFER --- src/gallium/drivers/llvmpipe/lp_screen.c | 17 - 1 file

[Mesa-dev] [PATCH 5/9] gallium: add new PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
In principle, since all gallium drivers implement pipe_context:: resource_copy_region() they should all support GL_ARB_copy_image but until that's true and verified, drivers must opt-in to support this feature. Reviewed-by: Marek Olšák --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 +

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Ilia Mirkin
The ffsll patch seems dodgy... among other things the same logic is in imports.c and thus would probably best refactored to src/util, but additionally it's only defined if !_GNU_SOURCE -- is that OK? Would e.g. a 32-bit build have ffsll? Perhaps it'd make sense to post the generic patches to the l

Re: [Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Ilia Mirkin
You need to rip out the st_CopyImageSubData I already added in st_cb_texture.c (I think). On Thu, Aug 27, 2015 at 7:47 PM, Brian Paul wrote: > From: Neha Bhende > > Basically, get the src/dst pipe_resource surfaces and call the > pipe_context::resource_copy_region() function. > > Reviewed-by: Ma

[Mesa-dev] [PATCH 1/2] gallium/util: fix debug_get_flags_option on 32-bit

2015-08-27 Thread Dave Airlie
From: Dave Airlie On 32-bit we need to use PRIu64 flags for printfs, otherwise this segfaults in R600_DEBUG=help otherwise. Cc: "11.0" Signed-off-by: Dave Airlie --- src/gallium/auxiliary/util/u_debug.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/aux

[Mesa-dev] [PATCH 2/2] r600g: use PRIu64 for some compute debug printfs

2015-08-27 Thread Dave Airlie
From: Dave Airlie Otherwise this will crash on 32-bit, and it gets rid of warnings building on 32-bit. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memo

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Ilia Mirkin
Are you sure you want to enable it in spite of the fact that it doesn't handle swizzling (which you've slightly papered over by switching some of the format orders around, but as I pointed out not completely)? On Thu, Aug 27, 2015 at 7:48 PM, Brian Paul wrote: > This enables GL_ARB_copy_image for

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Notice that Skylake needs to include a header in the sampler message > so it will need some tweaks to work there. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Brian Paul
On 08/27/2015 05:56 PM, Ilia Mirkin wrote: The ffsll patch seems dodgy... among other things the same logic is in imports.c and thus would probably best refactored to src/util, I can do that in a follow-on someday. There was very little in src/util/ back when I added that code to u_math.h s

Re: [Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Brian Paul
On 08/27/2015 05:59 PM, Ilia Mirkin wrote: You need to rip out the st_CopyImageSubData I already added in st_cb_texture.c (I think). Yes, I created my feature branch before you added that code. I'll have to rebase onto master. A patch to remove your code will be trivial. -Brian On Thu,

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
On 08/27/2015 06:01 PM, Ilia Mirkin wrote: Are you sure you want to enable it in spite of the fact that it doesn't handle swizzling (which you've slightly papered over by switching some of the format orders around, but as I pointed out not completely)? As I said before, I'd like to get as much

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Notice that Skylake needs to include a header in the sampler message > so it will need some tweaks to work there. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 8:19 PM, Brian Paul wrote: > On 08/27/2015 06:01 PM, Ilia Mirkin wrote: >> >> Are you sure you want to enable it in spite of the fact that it >> doesn't handle swizzling (which you've slightly papered over by >> switching some of the format orders around, but as I pointed o

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Matt Turner
On Thu, Aug 27, 2015 at 4:56 PM, Ilia Mirkin wrote: > The ffsll patch seems dodgy... among other things the same logic is in > imports.c and thus would probably best refactored to src/util, but > additionally it's only defined if !_GNU_SOURCE -- is that OK? Would > e.g. a 32-bit build have ffsll?

[Mesa-dev] [PATCH] r600: port si_conv_prim_to_gs_out from radeonsi

2015-08-27 Thread Dave Airlie
From: Dave Airlie This code we broken by the tess merge, and I totally missed it until now. I'm not sure this fixes anything but it stops the assert. Cc: "11.0" Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h | 31 --- 1 file changed, 16 inserti

[Mesa-dev] [PATCH] glsl: clean up textureSize prototype

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 4092d68..5e05199 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Timothy Arceri
On Thu, 2015-08-27 at 15:43 -0400, Ilia Mirkin wrote: > Cube maps are special in that they have separate teximages for each > face. We handled that by copying the data to them separately, but in > case zoffset != 0 or depth != 6 we would read off the end of the client > array or modify the wrong im

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 11:14 PM, Timothy Arceri wrote: > On Thu, 2015-08-27 at 15:43 -0400, Ilia Mirkin wrote: >> Cube maps are special in that they have separate teximages for each >> face. We handled that by copying the data to them separately, but in >> case zoffset != 0 or depth != 6 we would

Re: [Mesa-dev] [PATCH] glsl: clean up textureSize prototype

2015-08-27 Thread Timothy Arceri
On Thu, 2015-08-27 at 23:08 -0400, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin Reviewed-by: Timothy Arceri > --- > src/glsl/builtin_functions.cpp | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp >

[Mesa-dev] [PATCH 04/10] glsl: add ARB_shader_texture_image_samples infrastructure

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 2d631f0..118333d 100644 --- a/src

[Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a57d5ba..1f7d542 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 09/10] i965: add handling for imageSamples

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 172e29f..0b13e74 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/

[Mesa-dev] [PATCH 08/10] nir: convert glsl imageSamples into a new intrinsic

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/nir/glsl_to_nir.cpp | 6 +- src/glsl/nir/nir_intrinsics.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index ed1a91e..fb90ade 100644 --- a/src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] [PATCH 03/10] nir: add nir_texop_texture_samples and convert from glsl

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/nir/glsl_to_nir.cpp | 5 + src/glsl/nir/nir.h | 4 +++- src/glsl/nir/nir_print.c | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5fb4ee2..ed1a91e 100

[Mesa-dev] [PATCH 07/10] glsl: add support for the imageSamples function

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 48 +++--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 3fdda32..b3982f4 100644 --- a/src/glsl/builtin_functi

  1   2   >