[Mesa-dev] [PATCH 0/3 v3] clLinkProgram

2015-07-05 Thread EdB
This serie add OpenCL 1.2 clLinkProgram. However, it lacks the binary type part that is mandatory for input validation and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed in another serie once we agree on the way to store it. EdB (3): clover: separate compile and link stages clove

[Mesa-dev] [PATCH 2/3] clover: override ret_object

2015-07-05 Thread EdB
Return an API object from an intrusive smart reference Clover object, incrementing the reference count of the object. --- src/gallium/state_trackers/clover/api/util.hpp | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/util.hpp b/src/gallium/s

[Mesa-dev] [PATCH 0/3 v3] clLinkProgram

2015-07-05 Thread EdB
(resending because git send-email crashed) This serie add OpenCL 1.2 clLinkProgram. However, it lacks the binary type part that is mandatory for input validation and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed in another serie once we agree on the way to store it. EdB (3): clov

[Mesa-dev] [PATCH 1/3] clover: separate compile and link stages

2015-07-05 Thread EdB
--- src/gallium/state_trackers/clover/api/program.cpp | 6 +- .../state_trackers/clover/core/compiler.hpp| 7 +- src/gallium/state_trackers/clover/core/error.hpp | 21 ++ src/gallium/state_trackers/clover/core/program.cpp | 93 ++- src/gallium/state_trackers/clover/core/progra

[Mesa-dev] [PATCH 3/3] clover: add clLinkProgramm for CL 1.2

2015-07-05 Thread EdB
--- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 31 ++ src/gallium/state_trackers/clover/core/program.cpp | 4 +++ src/gallium/state_trackers/clover/core/program.hpp | 1 + 4 files changed, 37 insertions(+),

[Mesa-dev] [PATCH V2] mesa: fix active sampler conflict validation

2015-07-05 Thread Timothy Arceri
The type stored in gl_uniform_storage is the type of a single array element not the array type so size was always 1. Use the number of array elements stored in the gl_uniform_storage instead. V2: Dont validate sampler units pointing to 0 --- Fixes new piglit test: http://lists.freedesktop.org/a

[Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-05 Thread Marek Olšák
From: Marek Olšák Other approaches are being considered: 1) Don't use resource wrappers (views) and pass all view parameters (format, layer range, level) to set_shader_images just like set_vertex_buffers, set_constant_buffer, or even glBindImageTexture do. 2) Use pipe_sampler_view instead

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-05 Thread Ilia Mirkin
On Sun, Jul 5, 2015 at 9:25 AM, Marek Olšák wrote: > From: Marek Olšák > > Other approaches are being considered: > > 1) Don't use resource wrappers (views) and pass all view parameters >(format, layer range, level) to set_shader_images just like >set_vertex_buffers, set_constant_buffer,

Re: [Mesa-dev] [PATCH 1/3] clover: separate compile and link stages

2015-07-05 Thread Francisco Jerez
Hi EdB, a bunch of comments inline, EdB writes: > --- > src/gallium/state_trackers/clover/api/program.cpp | 6 +- > .../state_trackers/clover/core/compiler.hpp| 7 +- > src/gallium/state_trackers/clover/core/error.hpp | 21 ++ > src/gallium/state_trackers/clover/core/program.cpp

Re: [Mesa-dev] [PATCH 2/3] clover: override ret_object

2015-07-05 Thread Francisco Jerez
EdB writes: > Return an API object from an intrusive smart reference Clover object, > incrementing the reference count of the object. > --- > src/gallium/state_trackers/clover/api/util.hpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/gallium/state_trackers/clover/ap

Re: [Mesa-dev] [PATCH 1/3] clover: separate compile and link stages

2015-07-05 Thread EdB
On Sunday 05 July 2015 18:15:33 Francisco Jerez wrote: > Hi EdB, a bunch of comments inline, Hello > > EdB writes: > > --- > > > > src/gallium/state_trackers/clover/api/program.cpp | 6 +- > > .../state_trackers/clover/core/compiler.hpp| 7 +- > > src/gallium/state_trackers/clove

Re: [Mesa-dev] [PATCH 1/3] clover: separate compile and link stages

2015-07-05 Thread Francisco Jerez
EdB writes: > On Sunday 05 July 2015 18:15:33 Francisco Jerez wrote: >>[...] >> > --- a/src/gallium/state_trackers/clover/core/error.hpp >> > +++ b/src/gallium/state_trackers/clover/core/error.hpp >> > @@ -68,10 +68,31 @@ namespace clover { >> > >> > class build_error : public error { >> >

Re: [Mesa-dev] [PATCH 1/6] i965/vec4: Plumb log_data through so the backend_shader field gets set.

2015-07-05 Thread Pohjolainen, Topi
On Fri, Jul 03, 2015 at 09:29:16AM -0700, Kenneth Graunke wrote: > On Friday, July 03, 2015 10:50:52 AM Pohjolainen, Topi wrote: > > On Wed, Jul 01, 2015 at 03:03:31PM -0700, Kenneth Graunke wrote: > > > Jason plumbed this through a while back in the FS backend, but > > > apparently we were just pa

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Matt Turner
On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez wrote: > Heh, I happened to come across this comment yesterday while looking for > the remaining no16 calls and wondered why on earth it couldn't do the > same that the normal interpolation code does. After this patch and a > series coming up that w

Re: [Mesa-dev] [PATCH v2 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-05 Thread Matt Turner
On Fri, Jul 3, 2015 at 12:00 AM, Abdiel Janulgue wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_binding_tables.c > b/src/mesa/drivers/dri/i965/brw_binding_tables.c > index 7396c94..34a88b9 100644 > --- a/src/mesa/drivers/dri/i965/brw_binding_tables.c > +++ b/src/mesa/drivers/dri/i965/brw_bin

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Francisco Jerez
Hi Matt, Matt Turner writes: > On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez wrote: >> Heh, I happened to come across this comment yesterday while looking for >> the remaining no16 calls and wondered why on earth it couldn't do the >> same that the normal interpolation code does. After this

[Mesa-dev] [Bug 91149] make check optimization-test regression

2015-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91149 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] glsl: move max_index calc to assign_attribute_or_color_locations

2015-07-05 Thread Ilia Mirkin
On Fri, Jul 3, 2015 at 4:54 AM, Tapani Pälli wrote: > Change function to get all gl_constants for inspection, this is used > by follow-up patch. > > Signed-off-by: Tapani Pälli > --- > src/glsl/linker.cpp | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH 1/2] glsl: move max_index calc to assign_attribute_or_color_locations

2015-07-05 Thread Ilia Mirkin
On Sun, Jul 5, 2015 at 8:17 PM, Ilia Mirkin wrote: > On Fri, Jul 3, 2015 at 4:54 AM, Tapani Pälli wrote: >> Change function to get all gl_constants for inspection, this is used >> by follow-up patch. >> >> Signed-off-by: Tapani Pälli >> --- >> src/glsl/linker.cpp | 16 >> 1 fil

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Kenneth Graunke
On Monday, July 06, 2015 02:45:59 AM Francisco Jerez wrote: > Matt Turner writes: > > On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez > > wrote: [snip] > Yeah. I did in fact try to implement uaddCarry last Friday without > using the accumulator by doing something like: > > | CMP.o tmp, src0, -

Re: [Mesa-dev] [PATCH 39/78] i965/nir/vec4: Add swizzle utility method for vector ops

2015-07-05 Thread Jason Ekstrand
On Fri, Jul 3, 2015 at 10:23 AM, Antía Puentes wrote: > Hi Jason, > > On mar, 2015-06-30 at 14:18 -0700, Jason Ekstrand wrote: >> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote: >> > From: Antia Puentes >> > >> > For operations that have a predefined operand size > 0, defined in >> >

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-07-05 Thread Jason Ekstrand
On Fri, Jul 3, 2015 at 12:58 AM, Iago Toral wrote: > On Thu, 2015-07-02 at 09:31 +0200, Iago Toral wrote: >> On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote: >> > I'm not sure what I think about adding an is_scalar flag vs. having >> > _scalar and _vec4 versions of each function. My feeli

Re: [Mesa-dev] [PATCH 13/78] i965/nir/vec4: Implement conditional statements (nir_cf_node_if)

2015-07-05 Thread Jason Ekstrand
On Fri, Jul 3, 2015 at 12:32 AM, Iago Toral wrote: > On Thu, 2015-07-02 at 10:11 -0700, Jason Ekstrand wrote: >> On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral wrote: >> > On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote: >> >> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev >> >> wrote

Re: [Mesa-dev] [PATCH 13/78] i965/nir/vec4: Implement conditional statements (nir_cf_node_if)

2015-07-05 Thread Iago Toral
On Sun, 2015-07-05 at 19:14 -0700, Jason Ekstrand wrote: > On Fri, Jul 3, 2015 at 12:32 AM, Iago Toral wrote: > > On Thu, 2015-07-02 at 10:11 -0700, Jason Ekstrand wrote: > >> On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral wrote: > >> > On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote: > >> >