Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

Am 10.02.2015 um 03:41 schrieb Alex Deucher: On Mon, Feb 9, 2015 at 7:29 PM, Marek Olšák wrote: Hi Christian, What hardware is this supported on? SI and later? Or even r600? r300? Theoretically r300 and newer hardware, however, the kernel currently only allows it on r600 and newer since we ne

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

https://bugs.freedesktop.org/show_bug.cgi?id=89050 Chris Wilson changed: What|Removed |Added Component|Driver/intel|GLX Version|unspecified

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

https://bugs.freedesktop.org/show_bug.cgi?id=89050 Chris Wilson changed: What|Removed |Added Priority|high|medium -- You are receiving this mail be

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

On 09/02/15 23:25, Sedat Dilek wrote: On Mon, Feb 9, 2015 at 9:51 PM, Jose Fonseca wrote: On 09/02/15 17:44, Emil Velikov wrote: Hi Sedat, On 07/02/15 22:42, Sedat Dilek wrote: [ Please CC me I am not subscribed to mesa-dev and llvmdev MLs ] Hi, I already reported this when playing 1st t

[Mesa-dev] [PATCH 1/2] i915g: Use the actual MIN instruction.

Matt Turner noticed that the hardware has always had a MIN instruction, but the driver always used MAX+MOV for no apparent reason. This should cut an instruction, and a temporary, allowing more programs to run in hardware. Signed-off-by: Kenneth Graunke Cc: Stéphane Marchesin --- src/gallium/d

[Mesa-dev] [PATCH 2/2] i915c: Use the actual MIN instruction.

Matt Turner noticed that the hardware has always had a MIN instruction, but the driver always used MAX+MOV for no apparent reason. This should cut an instruction, and a temporary, allowing more programs to run in hardware. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i915/i915_fragpr

Re: [Mesa-dev] [PATCHv2 12/14] i965/gen7-8: Poke the 3DSTATE UAV access enable bits.

On Monday, February 09, 2015 09:13:04 PM Francisco Jerez wrote: > v2: Set the PS UAV-only bit on HSW (Ken). > --- > src/mesa/drivers/dri/i965/brw_defines.h | 4 > src/mesa/drivers/dri/i965/gen7_gs_state.c | 4 +++- > src/mesa/drivers/dri/i965/gen7_vs_state.c | 13 - > src/mesa

Re: [Mesa-dev] [PATCHv2 13/14] i965/gen7-8: Set up early depth/stencil control appropriately for image load/store.

On Monday, February 09, 2015 09:14:36 PM Francisco Jerez wrote: > v2: Store early fragment test mode in brw_wm_prog_data instead of > getting it from core mesa data structures (Ken). > --- > src/mesa/drivers/dri/i965/brw_context.h | 1 + > src/mesa/drivers/dri/i965/brw_defines.h | 3

Re: [Mesa-dev] [PATCHv2 11/14] i965/gen7: Enable fragment shader dispatch if the program has image uniforms.

On Monday, February 09, 2015 09:11:18 PM Francisco Jerez wrote: > Shaders with image uniforms may have side effects. Make sure that > fragment shader threads are dispatched if the shader has any image > uniforms. > > v2: Use brw_stage_state::nr_image_params to find out if the shader has > ima

[Mesa-dev] [PATCH 3/6] meta: react to errors in create_texture_for_pbo()

Check if we got requested temporary buffers and no NULL pointer. Signed-off-by: Juha-Pekka Heikkila --- In original patch there was missing '*'s for tmp_pbo and tmp_tex. tmp_pbo will not get value if end up in rehashing and rehashing fails. If tmp_tex does not get value there is already GL_OUT_

[Mesa-dev] [PATCH 6/6] nir: check malloc return value in print_block()

Signed-off-by: Juha-Pekka Heikkila --- src/glsl/nir/nir_print.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index 9c07950..c250850 100644 --- a/src/glsl/nir/nir_print.c +++ b/src/glsl/nir/nir_print.c @@ -646,6 +646,9 @@ print_block(ni

[Mesa-dev] [PATCH v5 01/29] glapi: add ARB_gpu_shader_fp64 (v2)

From: Dave Airlie Just add the xml file covering this extension, and dummy interface files in mesa, and fix up sanity tests. v2: Enable ProgramUniform*d* from ARB_separate_shader_objects (Ian) use 40 instead of 43 for dispatch_sanity.cpp (Chris) uncomment PU sanity tests. Signed-off-by: Dave Ai

[Mesa-dev] [PATCH v5 02/29] mesa: add ARB_gpu_shader_fp64 extension info (v2)

From: Dave Airlie This just adds the entries to extensions.c and mtypes.h v2: use core profile only (Ian) Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick Reviewed-by: Matt Turner --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) d

[Mesa-dev] [PATCH v5 06/29] glsl: Add double builtin type generation

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/glsl/builtin_type_macros.h | 16 ++ src/glsl/builtin_types.cpp | 30 +++ src/glsl/glsl_parser_extras.h | 5 ++ src/glsl/glsl_types.cpp| 112

[Mesa-dev] [PATCH v5 00/29] add fp64 support to mesa and glsl compiler

I spent a lot of quality time with Ian's random_ubo.py script, and I'm happy to report that with the current iteration, it doesn't spot any problems (after ~1000 shaders). I only had to make the following change to it: diff --git a/generated_tests/random_ubo.py b/generated_tests/random_ubo.py inde

[Mesa-dev] [PATCH v5 08/29] glsl: fix uniform linking logic in the presence of structs

Add a enter/leave record callback so that the offset may be aligned to the proper value. Otherwise only leaf fields are called, and the first field needs to be aligned to the outer struct's base alignment while the last field needs to be aligned to the inner struct's base alignment. This removes m

[Mesa-dev] [PATCH v5 24/29] glsl: enable/disable certain lowering passes for doubles

From: Dave Airlie We want to restrict some lowering passes to floats only, and enable other for doubles. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_ins

[Mesa-dev] [PATCH v5 10/29] glsl/ir: Add printing support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/glsl/ir_print_visitor.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp index bd39805..3600827 100644 --- a/

[Mesa-dev] [PATCH v5 05/29] glsl: add ARB_gpu_shader_fp64 to the glsl extensions. (v2)

From: Dave Airlie v2: add define bit (Tapani Pälli) Patch makes following Piglit tests pass: arb_gpu_shader_fp64/preprocessor/define.vert arb_gpu_shader_fp64/preprocessor/define.frag Reviewed-by: Ian Romanick Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/glcpp/glcpp

[Mesa-dev] [PATCH v5 26/29] glsl: implement double builtin functions

From: Dave Airlie This implements the bulk of the builtin functions for fp64 support. Signed-off-by: Dave Airlie --- src/glsl/builtin_functions.cpp | 751 +++-- 1 file changed, 492 insertions(+), 259 deletions(-) diff --git a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH v5 28/29] glsl: add a lowering pass for frexp/ldexp with double arguments

Signed-off-by: Ilia Mirkin --- src/glsl/ir_optimization.h | 1 + src/glsl/lower_instructions.cpp | 279 +++- 2 files changed, 279 insertions(+), 1 deletion(-) diff --git a/src/glsl/ir_optimization.h b/src/glsl/ir_optimization.h index 9f91e2f..7eb861a 10

[Mesa-dev] [PATCH v5 11/29] glsl/ir: Add cloning support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/glsl/ir_clone.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index dffa578..5c7279c 100644 --- a/src/glsl/ir_clone.cpp +++ b/src/glsl/

[Mesa-dev] [PATCH v5 09/29] glsl/ir: Add builtin function support for doubles

From: Dave Airlie v2: add d2b, more ir_constant stuff (Ilia) Signed-off-by: Dave Airlie --- src/glsl/ir.cpp | 111 ++-- src/glsl/ir.h | 22 src/glsl/ir_validate.cpp| 72 +++--- src/mesa

[Mesa-dev] [PATCH v5 13/29] glsl/ir: Add builder support for functions with double floats

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/glsl/ir_builder.cpp | 23 +++ src/glsl/ir_builder.h | 5 + 2 files changed, 28 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index

[Mesa-dev] [PATCH v5 12/29] glsl/ir: Add builtin constant function support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir_constant_expression.cpp | 247 +++- 1 file changed, 215 insertions(+), 32 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 1e8b3a3..214e945 100

[Mesa-dev] [PATCH v5 20/29] glsl: Support double loop control

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/loop_controls.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glsl/loop_controls.cpp b/src/glsl/loop_controls.cpp index 1c1d34f..2459fc1 100644 --- a/src/glsl/loop_controls.cpp +++ b/src/glsl/loop_cont

[Mesa-dev] [PATCH v5 22/29] glsl: add double support to lower_mat_op_to_vec

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/glsl/lower_mat_op_to_vec.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_to_vec.cpp index 105ee0d..dda754f 100644 --- a/src/glsl/lower_mat_op_to_vec

[Mesa-dev] [PATCH v5 07/29] glsl: Uniform linking support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/link_uniforms.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index de2f6c9..3aa6e0a 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_unifor

[Mesa-dev] [PATCH v5 04/29] mesa: add double uniform support. (v5)

From: Dave Airlie This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) v3: fix size_mul v4: Teach uniform update to take into account double precisio

[Mesa-dev] [PATCH v5 15/29] glsl: Add ubo lowering support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/lower_ubo_reference.cpp | 57 +++- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 43dd067..4ea4ccb 100644 ---

[Mesa-dev] [PATCH v5 29/29] glsl/tests: add DOUBLE/IMAGE types

Signed-off-by: Ilia Mirkin --- src/glsl/tests/uniform_initializer_utils.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/tests/uniform_initializer_utils.cpp b/src/glsl/tests/uniform_initializer_utils.cpp index 6f47acd..8c9d8cc 100644 --- a/src/glsl/tests/uniform_ini

[Mesa-dev] [PATCH v5 21/29] glsl: Linking support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/glsl/link_uniform_initializers.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index f6a60bc..6907384 1

[Mesa-dev] [PATCH v5 27/29] glsl: lower double optional passes (v2)

From: Dave Airlie These lowering passes are optional for the backend to request, currently the TGSI softpipe backend most likely the r600g backend would want to use these passes as is. They aim to hit the gallium opcodes from the standard rounding/truncation functions. v2: also lower floor in mo

[Mesa-dev] [PATCH v5 19/29] glsl: Support double inouts

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir_set_program_inouts.cpp | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index 97ead75..e877a20 100644 --- a/src/

[Mesa-dev] [PATCH v5 18/29] glsl/lexer: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick Reviewed-by: Matt Turner --- src/glsl/glsl_lexer.ll | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index 48ba463..8dc3d1

[Mesa-dev] [PATCH v5 03/29] glsl: Add double builtin type

This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/glsl_types.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index 441015c..f472d

[Mesa-dev] [PATCH v5 17/29] glsl/parser: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/glsl/glsl_parser.yy | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 7fb8c38..5

[Mesa-dev] [PATCH v5 16/29] glsl/ast: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ast.h | 2 ++ src/glsl/ast_function.cpp | 66 + src/glsl/ast_to_hir.cpp | 33 +++-- src/glsl/glsl_parser_extras.cpp | 4 +++ 4 files changed, 90 ins

[Mesa-dev] [PATCH v5 25/29] glsl/lower_instructions: add double lowering passes

From: Dave Airlie This lowers double dot product and lrp to fma. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 65 + 1 file changed, 65 insertions(+) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp index

[Mesa-dev] [PATCH v5 14/29] glsl: Add support doubles in optimization passes

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/opt_algebraic.cpp| 26 ++ src/glsl/opt_constant_propagation.cpp | 3 +++ src/glsl/opt_minmax.cpp | 13 + 3 files changed, 38 insertions(+), 4 deleti

[Mesa-dev] [PATCH v5 23/29] glsl: validate output types for shader stages

From: Tapani Pälli Patch fixes Piglit test: arb_gpu_shader_fp64/preprocessor/fs-output-double.frag and adds additional validation for shader outputs. Signed-off-by: Tapani Pälli Signed-off-by: Dave Airlie --- src/glsl/ast_to_hir.cpp | 45 + 1 fi

[Mesa-dev] [PATCHv4 32/32] i965: Don't compact instructions with unmapped bits.

Some instruction bits don't have a mapping defined to any compacted instruction field. If they're ever set and we end up compacting the instruction they will be forced to zero. Avoid using compaction in such cases. v2: Align multiple lines of an expression to the same column. Change conditi

[Mesa-dev] [PATCH 00/11] More patches fixing dEQP test fails

Hi, This is yet another batch of fixes for dEQP failing tests. It fixes a total of 249 test cases. The test failures were gathered on i965 (gen7) against 10.4.2, but again there are driver and version agnostic fixes. A GIT tree with these patches based on git-08a06 is available at: https://git

[Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

The zoffset and depth values were not being considered when calling error_check_subtexture_dimensions(). Fixes 2 dEQP tests: * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_invalid_offset --- src/mesa/main/teximage.c

[Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

From: Iago Toral Quiroga --- src/mesa/main/teximage.c | 22 ++ src/mesa/main/teximage.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index c9c48bb..f0d0ef0 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/ma

[Mesa-dev] [PATCH 09/11] i965: Fix non-AA wide line rendering with fractional line widths

From: Iago Toral Quiroga From 14.5.2.2. Wide Lines of the OpenGL spec 4.5: "(...)Let w be the width rounded to the nearest integer (...). If the line segment has endpoints given by (x0,y0) and (x1,y1) in window coordinates, the segment with endpoints (x0,y0-(w-1)/2) and (x1,y1-(w-1/2)) is raste

[Mesa-dev] [PATCH 10/11] mesa: Return error if BeginQuery is called with an existing object of different type

Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 spec states: "BeginQuery generates an INVALID_OPERATION error if any of the following conditions hold: [...] id is the name of an existing query object whose type does not match target; [...] Similar wording exists in the O

[Mesa-dev] [PATCH 11/11] i965: Fix textureSize for Lod > 0 with non-mipmap filters

From: Iago Toral Quiroga Currently, when the MinFilter is GL_LINEAR or GL_NEAREST we hide the actual miplevel count from the hardware (and we avoid re-creating the miptree structure with all the levels), since we don't expect levels other than the base level to be needed. Unfortunately, GLSL's te

[Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

From: Samuel Iglesias Gonsalvez Round floating point values to nearest integer to avoid "off by one texel" kind of errors when blitting. Fixes: dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_nearest dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_linear dEQP-GLES3.functional.fbo.blit.rect.

[Mesa-dev] [PATCH 03/11] mesa: Return INVALID_ENUM in glClearBufferiv() when buffer is not color or stencil

Section 4.2.3 Clearing the Buffers, page 190 of the OpenGL ES 3.0.4 spec says: "ClearBufferiv generates an INVALID_ENUM error if buffer is not COLOR or STENCIL." Fixes 1 dEQP test: * dEQP-GLES3.functional.negative_api.buffer.clear_bufferiv --- src/mesa/main/clear.c | 13 + 1 file cha

[Mesa-dev] [PATCH 04/11] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

Fixes 3 dEQP tests: * dEQP-GLES3.functional.negative_api.state.get_program_info_log * dEQP-GLES3.functional.negative_api.state.get_shader_info_log * dEQP-GLES3.functional.negative_api.state.get_programiv --- src/mesa/main/shaderapi.c | 84 --- 1 file cha

[Mesa-dev] [PATCH 07/11] i965: Make sure we always mark array surfaces as such

From: Iago Toral Quiroga Even if they only have one slice, otherwise textureSize() won't produce correct results for the depth value. Fixes 10 dEQP tests in this category: dEQP-GLES3.functional.shaders.texture_functions.texturesize.sampler2darray* --- src/mesa/drivers/dri/i965/gen7_wm_surface_s

[Mesa-dev] [PATCH 01/11] i965: Fix ctx->Texture.CubeMapSeamless

From: Iago Toral Quiroga The intel driver code, and apparently all other Mesa drivers, call _mesa_initialize_context early in the CreateContext hook. That function will end up calling _mesa_init_texture which will do: ctx->Texture.CubeMapSeamless = _mesa_is_gles3(ctx); But this won't work at th

[Mesa-dev] [PATCH 08/11] mesa: Return INVALID_OPERATION when querying a never bound Query obj

Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 states: "The command void GenQueries( sizei n, uint *ids ); returns n previously unused query object names in ids. These names are marked as used, for the purposes of GenQueries only, but no object is associated with them until the

[Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

Currently having the wayland-scanner is optional, which causes problems when autotools parses through the makefiles, and tries to generate all the BUILT_SOURCES. As the config option --with-egl-platform=wayland is not the default, we won't end up setting the WAYLAND_SCANNER variable, which in turn

[Mesa-dev] [PATCH 2/4] nir: add missing header to the sources list

Cc: "10.5" Signed-off-by: Emil Velikov --- src/glsl/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources index a580b6e..7e66e91 100644 --- a/src/glsl/Makefile.sources +++ b/src/glsl/Makefile.sources @@ -21,6 +21,7 @@ NIR_FILES

[Mesa-dev] [PATCH 4/4] auxiliary/vl: bring back the VL code for the dri targets

With commit c642e87d9f4(auxiliary/vl: rework the build of the VL code) we split out the VL code into a separate static library that was meant to be used by the VL targets alone - va, vdpau, xvmc. The commit failed to consider the way we handle vdpau-gl interop and broke it. Bring back the function

Re: [Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga --- src/mesa/main/teximage.c | 22 ++ src/mesa/main/teximage.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index c9c48bb..f0d0ef0

Re: [Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: The zoffset and depth values were not being considered when calling error_check_subtexture_dimensions(). Fixes 2 dEQP tests: * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset * dEQP-GLES3.functional.negative_api.texture.texsub

[Mesa-dev] [PATCH 1/4] nir: resolve nir.h dependency list (fix make distcheck)

Use nir/nir_opcodes.h as is (w/o the absolute path), as it is the target name used to generate the actual file. Otherwise the target is missing, the file won't get generated and the build will fail. Cc: "10.5" Signed-off-by: Emil Velikov --- src/glsl/Makefile.am | 2 +- 1 file changed, 1 insert

Re: [Mesa-dev] [PATCH 1/4] nir: resolve nir.h dependency list (fix make distcheck)

On 10/02/15 16:07, Emil Velikov wrote: > Use nir/nir_opcodes.h as is (w/o the absolute path), as it is the target > name used to generate the actual file. Otherwise the target is missing, > the file won't get generated and the build will fail. > > Cc: "10.5" Fwiw the "destkop" typo in all 4 patch

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #25 from Emil Velikov --- Hi guys, sorry about the delay. Christian had some comments on the original patch which I've addressed here - http://patchwork.freedesktop.org/patch/42201/ Can you give it a spin ? -- You are receiving thi

[Mesa-dev] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

Before, if --disable-dri was set we were still testing the libdrm version for r300, r600, vmware/svga. Cc: "10.4, 10.5" --- I'm not an autoconf expert, so there might be a better way of doing this. --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configu

Re: [Mesa-dev] [PATCH 2/2] i915c: Use the actual MIN instruction.

On 02/10/2015 03:36 AM, Kenneth Graunke wrote: > Matt Turner noticed that the hardware has always had a MIN > instruction, but the driver always used MAX+MOV for no > apparent reason. And it has been right there in the docs the whole time too. WTF? > This should cut an instruction, and a tempora

Re: [Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov wrote: > Currently having the wayland-scanner is optional, which causes problems > when autotools parses through the makefiles, and tries to generate all > the BUILT_SOURCES. > > As the config option --with-egl-platform=wayland is not the default, we >

Re: [Mesa-dev] [PATCH 03/11] mesa: Return INVALID_ENUM in glClearBufferiv() when buffer is not color or stencil

On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 4.2.3 Clearing the Buffers, page 190 of the OpenGL ES 3.0.4 spec says: > "ClearBufferiv generates an INVALID_ENUM error if buffer is not COLOR or > STENCIL." > > Fixes 1 dEQP test: > * dEQP-GLES3.functional.negative_api.buffer.clear_buff

Re: [Mesa-dev] [PATCH 04/11] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Fixes 3 dEQP tests: > * dEQP-GLES3.functional.negative_api.state.get_program_info_log > * dEQP-GLES3.functional.negative_api.state.get_shader_info_log > * dEQP-GLES3.functional.negative_api.state.get_programiv > --- > src/mesa/main/shaderapi.c |

Re: [Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

On 02/10/2015 08:12 AM, Brian Paul wrote: > On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: >> The zoffset and depth values were not being considered when calling >> error_check_subtexture_dimensions(). >> >> Fixes 2 dEQP tests: >> * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_of

Re: [Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

On 02/10/2015 08:10 AM, Brian Paul wrote: > On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: >> From: Iago Toral Quiroga >> >> --- >> src/mesa/main/teximage.c | 22 ++ >> src/mesa/main/teximage.h | 3 +++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/src/mesa/ma

Re: [Mesa-dev] [PATCH 08/11] mesa: Return INVALID_OPERATION when querying a never bound Query obj

This patch is Reviewed-by: Ian Romanick On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 states: > > "The command void GenQueries( sizei n, uint *ids ); returns n previously > unused > query object names in ids. These names a

Re: [Mesa-dev] [PATCH 01/11] i965: Fix ctx->Texture.CubeMapSeamless

On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > The intel driver code, and apparently all other Mesa drivers, call > _mesa_initialize_context early in the CreateContext hook. That > function will end up calling _mesa_init_texture which will do: > > ctx->Texture.C

Re: [Mesa-dev] [PATCH 10/11] mesa: Return error if BeginQuery is called with an existing object of different type

This patch is Reviewed-by: Ian Romanick We'll have to see if this breaks any applications... On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 > spec states: > > "BeginQuery generates an INVALID_OPERATION error if any of the

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #26 from Andy Furniss --- (In reply to Emil Velikov from comment #25) > Hi guys, sorry about the delay. > > Christian had some comments on the original patch which I've addressed here > - http://patchwork.freedesktop.org/patch/42201/

Re: [Mesa-dev] [PATCH 2/2] i915c: Use the actual MIN instruction.

Both look like what I'd expect, FWIW. Thanks Ken! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov wrote: > Currently having the wayland-scanner is optional, which causes problems > when autotools parses through the makefiles, and tries to generate all > the BUILT_SOURCES. > > As the config option --with-egl-platform=wayland is not the default, we >

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

Connor Abbott writes: > On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: >> NIR instruction count results on i965: >> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) >> instructions in affected programs: 455 -> 438 (-3.74%) >> >> One in yofrankie, two in tropics. Appar

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

On Tue, Feb 10, 2015 at 10:32 AM, Eric Anholt wrote: > Connor Abbott writes: > > > On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: > >> NIR instruction count results on i965: > >> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) > >> instructions in affected programs:

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

On Tue, Feb 10, 2015 at 7:40 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > Round floating point values to nearest integer to avoid "off by one texel" > kind of errors when blitting. > > Fixes: > > dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_nearest > dEQP-GLES3.functio

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: >>> NIR instruction count results on i965: >>> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) >>> instructions in affected programs: 455 ->

[Mesa-dev] [PATCH 2/4] i965: Use greater-equal cmod to implement maximum.

The docs specifically call out SEL with .l and .ge as the implementations of MIN and MAX respectively. Among other things, SEL with these conditional mods are commutative. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp| 6 +++---

[Mesa-dev] [PATCH 1/4] i965: Don't emit saturates for instructions without destinations.

We were special casing OPCODE_END but no other instructions that have no destination, like OPCODE_KIL, leading us to emitting MOVs with null destinations. total instructions in shared programs: 5950886 -> 5947182 (-0.06%) instructions in affected programs: 139700 -> 135996 (-2.65%) helped:

[Mesa-dev] [PATCH 3/4] i965/blorp: Optimize clamping tex coords.

Each emit_cond_mov() emits a CMP of its first to arguments using the specified conditional mod, followed by a predicated MOV of the fifth argument into the fourth. In all four cases here, it was just implementing MIN/MAX which we can do in a single SEL instruction. Also reorder the instructions fo

[Mesa-dev] [PATCH 4/4] i965/blorp: Emit MADs.

Low hanging fruit: cuts a couple of instructions. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 9 + 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/driv

[Mesa-dev] nir warnings

There's a number of new compiler warnings (gcc 4.8.2) in the nir code: nir/glsl_to_nir.cpp: In member function 'virtual void {anonymous}::nir_visitor::visit(ir_call*)': nir/glsl_to_nir.cpp:610:73: warning: 'op' may be used uninitialized in this function [-Wmaybe-uninitialized] nir_intri

Re: [Mesa-dev] nir warnings

On Tue, Feb 10, 2015 at 11:15 AM, Brian Paul wrote: > There's a number of new compiler warnings (gcc 4.8.2) in the nir code: I'm glad I'm not the only one annoyed by new warnings. > nir/glsl_to_nir.cpp: In member function 'virtual void > {anonymous}::nir_visitor::visit(ir_call*)': > nir/glsl_to_

[Mesa-dev] [PATCH 1/3] nir: Remove unused has_indirect variable.

--- src/glsl/nir/nir_lower_samplers.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/glsl/nir/nir_lower_samplers.cpp b/src/glsl/nir/nir_lower_samplers.cpp index dca086d..3015dbd 100644 --- a/src/glsl/nir/nir_lower_samplers.cpp +++ b/src/glsl/nir/nir_lower_samplers.cpp @@ -69,7 +69,6

[Mesa-dev] [PATCH 3/3] nir: Remove casts from void*.

--- src/glsl/nir/nir.c | 16 src/glsl/nir/nir_dominance.c | 6 +++--- src/glsl/nir/nir_lower_atomics.c | 3 +-- src/glsl/nir/nir_remove_dead_variables.c | 2 +- 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/glsl/n

[Mesa-dev] [PATCH 2/3] nir: Replace assert(0) with unreachable().

--- src/glsl/nir/glsl_to_nir.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 46cfac3..e505a1d 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -604,7 +604,7 @@ ni

Re: [Mesa-dev] [PATCH 2/4] nir: add missing header to the sources list

Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 11:08 AM, Emil Velikov wrote: > Cc: "10.5" > Signed-off-by: Emil Velikov > --- > src/glsl/Makefile.sources | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources > index a580b6e..7e66e91

Re: [Mesa-dev] [PATCH 2/3] nir: Replace assert(0) with unreachable().

Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 2:24 PM, Matt Turner wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp > index 46cfac3..e505a1d 100644

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

https://bugs.freedesktop.org/show_bug.cgi?id=89068 Bug ID: 89068 Summary: glTexImage2D regression by texstore_rgba switch to _mesa_format_convert Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

On Tue, Feb 10, 2015 at 10:52 AM, Matt Turner wrote: >> + /* Round floating point values to nearest integer to avoid "off by one >> texel" >> +* kind of errors when blitting. >> +*/ >> + x0 = wm_push_consts.dst_x0 = dst_x0 + 0.5; >> + y0 = wm_push_consts.dst_y0 = dst_y0 + 0.5; >> +

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #1 from Brad King --- Created attachment 113324 --> https://bugs.freedesktop.org/attachment.cgi?id=113324&action=edit VTK test output image before change -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #2 from Brad King --- Created attachment 113325 --> https://bugs.freedesktop.org/attachment.cgi?id=113325&action=edit VTK test output image after change -- You are receiving this mail because: You are the QA Contact for the bug. Y

Re: [Mesa-dev] [PATCH 3/3] nir: Remove casts from void*.

Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 2:24 PM, Matt Turner wrote: > --- > src/glsl/nir/nir.c | 16 > src/glsl/nir/nir_dominance.c | 6 +++--- > src/glsl/nir/nir_lower_atomics.c | 3 +-- > src/glsl/nir/nir_remove_dead_vari

[Mesa-dev] [PATCH] i965/fs: Convert MOV null with conditional mod into CMP.

The cmod propagation pass handles CMP and MOV.NZ. If we propagated a conditional modifier other than NZ onto a MOV, it would be stuck there. Convert these instructions into a CMP to let the cmod be propagated further. instructions in affected programs: 1482 -> 1454 (-1.89%) helped:

Re: [Mesa-dev] nir warnings

On 02/10/2015 12:19 PM, Matt Turner wrote: On Tue, Feb 10, 2015 at 11:15 AM, Brian Paul wrote: There's a number of new compiler warnings (gcc 4.8.2) in the nir code: I'm glad I'm not the only one annoyed by new warnings. nir/glsl_to_nir.cpp: In member function 'virtual void {anonymous}::nir

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #27 from darkbasic --- Created attachment 113327 --> https://bugs.freedesktop.org/attachment.cgi?id=113327&action=edit build.log It doesn't build anymore with your latest patch (Mesa-dev-4-4-auxiliary-vl-bring-back-the-VL-code-for-

[Mesa-dev] [PATCH] mesa: silence uninitialized var warning in get_tex_rgba_uncompressed()

--- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index ee465e6..db674dc 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -450,7 +450,7 @@ get_tex_rgba_uncompr

[Mesa-dev] [PATCH] glsl: Optimize 1/exp(x) into exp(-x).

Lots of shaders divide by exp2(...) which we turn into a multiplication by the reciprocal. We can avoid the reciprocal by simply negating exp2's argument. total instructions in shared programs: 5947154 -> 5946695 (-0.01%) instructions in affected programs: 118661 -> 118202 (-0.39%) helped:

  1   2   >