Re: [Mesa-dev] [PATCH 02/10] nir: Properly clean up CF nodes when we remove them

2015-02-09 Thread Jason Ekstrand
On Thu, Feb 5, 2015 at 3:27 PM, Connor Abbott wrote: > While we're cleaning this up, we should go a little farther - we > should also see if anything is using the SSA result of any of these > instructions, and if so make it point to an undef_instr instead to > avoid dangling pointers. This doesn'

[Mesa-dev] [PATCH v2 03/12] nir/from_ssa: Use the nir_block_dominance function instead of our own

2015-02-09 Thread Jason Ekstrand
Reviewed-by: Connor Abbott --- src/glsl/nir/nir_from_ssa.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/nir_from_ssa.c b/src/glsl/nir/nir_from_ssa.c index 2e7add3..3625237 100644 --- a/src/glsl/nir/nir_from_ssa.c +++ b/src/glsl/nir/nir_from_ssa.c @@ -5

[Mesa-dev] [PATCH v2 09/12] nir: Make nir_[cf_node/instr]_[prev/next] return null if at the end

2015-02-09 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 5d84343..f4056f4 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -416,15 +416,23 @@ typedef struct { } nir_instr; s

[Mesa-dev] [PATCH v2 07/12] nir/validate: Validate SSA defs the same way we do for registers

2015-02-09 Thread Jason Ekstrand
Reviewed-by: Connor Abbott --- src/glsl/nir/nir_validate.c | 87 - 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index 13010ae..a3fe9d6 100644 --- a/src/glsl/nir/nir_validate.c +

[Mesa-dev] [PATCH v2 10/12] nir: Add an instruction index

2015-02-09 Thread Jason Ekstrand
This index, unlike the others, has to be manually updated by passes that want to use it. Reviewed-by: Connor Abbott --- src/glsl/nir/nir.c | 20 src/glsl/nir/nir.h | 4 2 files changed, 24 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 8ea7bb

[Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Jason Ekstrand
v2 Jason Ekstrand : - Use nir_dominance_lca for computing least common anscestors - Use the block index for comparing dominance tree depths - Pin things that do partial derivatives --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_opt_gcm.c | 501 +

[Mesa-dev] [PATCH v2 06/12] nir/validate: Validate if_uses on registers

2015-02-09 Thread Jason Ekstrand
Reviewed-by: Connor Abbott --- src/glsl/nir/nir_validate.c | 62 - 1 file changed, 44 insertions(+), 18 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a34a017..13010ae 100644 --- a/src/glsl/nir/nir_validate.c

[Mesa-dev] [PATCH v2 08/12] nir/from_ssa: Don't try to read an invalid instruction

2015-02-09 Thread Jason Ekstrand
--- src/glsl/nir/nir_from_ssa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_from_ssa.c b/src/glsl/nir/nir_from_ssa.c index 3625237..7c50095 100644 --- a/src/glsl/nir/nir_from_ssa.c +++ b/src/glsl/nir/nir_from_ssa.c @@ -272,7 +272,7 @@ get_parallel_copy_at_e

[Mesa-dev] [PATCH v2 05/12] nir: Properly clean up CF nodes when we remove them

2015-02-09 Thread Jason Ekstrand
Previously, if you remved a CF node that still had instructions in it, none of the use/def information from those instructions would get cleaned up. Also, we weren't removing if statements from the if_uses of the corresponding register or SSA def. This commit fixes both of these problems --- src/

[Mesa-dev] [PATCH v2 12/12] i965/nir: Use Global Code Motion

2015-02-09 Thread Jason Ekstrand
v2: Do GCM after dead code elimination --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index da81b61..a0e6b1d 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cp

[Mesa-dev] [PATCH v2 04/12] nir: use nir_foreach_ssa_def for indexing ssa defs

2015-02-09 Thread Jason Ekstrand
This is both simpler and more correct. The old code didn't properly index load_const instructions. Reviewed-by: Connor Abbott --- src/glsl/nir/nir.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 10e6

[Mesa-dev] [PATCH v2 01/12] nir/dominance: Expose the dominance intersection function

2015-02-09 Thread Jason Ekstrand
Being able to find the least common anscestor in the dominance tree is a useful thing that we may want to do in other passes. In particular, we need it for GCM. v2: Handle NULL inputs by returning the other block --- src/glsl/nir/nir.h | 2 ++ src/glsl/nir/nir_dominance.c | 22 +++

[Mesa-dev] [PATCH v2 02/12] nir/dominance: Add a constant-time mechanism for comparing blocks

2015-02-09 Thread Jason Ekstrand
This is mostly thanks to Connor. The idea is to do a depth-first search that computes pre and post indices for all the blocks. We can then figure out if one block dominates another in constant time by two simple comparison operations. Reviewed-by: Connor Abbott --- src/glsl/nir/nir.h

[Mesa-dev] [Bug 84570] Borderlands 2/Pre-Sequel: Constant frame rate drops while playing; really bad with additionl lighting

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 --- Comment #32 from Kai --- (In reply to Michel Dänzer from comment #31) > (In reply to Kai from comment #30) > > Michel, is there any chance attachment 107544 will be > > part of 3.18? > > No, but it's in Alex's queue for 3.19. 3.19 has been

[Mesa-dev] [Bug 84570] Borderlands 2/Pre-Sequel: Constant frame rate drops while playing; really bad with additionl lighting

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 --- Comment #33 from Kenneth Graunke --- Aspyr's latest release contains bugfixes related to this, and that's solved the problem on Intel. -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Iago Toral
On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: > Am 06.02.2015 um 13:11 schrieb Iago Toral: > > Hi, > > > > Eduardo and I have been looking into a few dEQP test failures that deal > > with wide line rendering. There are a few of them that fail because of > > how clipping is implement

[Mesa-dev] [PATCH v4] glsl: Linking support for doubles

2015-02-09 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- Removed slot multiplication in link_varyings, since component_slots now takes care of it. src/glsl/link_uniform_initializers.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/link

[Mesa-dev] [PATCH v4] glsl: Uniform linking support for doubles

2015-02-09 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie --- Removed now-unnecessary component_slots multiplication, check the base type without array. src/glsl/link_uniforms.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.c

[Mesa-dev] [PATCH v4] glsl: Add double builtin type generation

2015-02-09 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- Made component_slots() return 2 instead of 1 for double. Also added to list for uniform_locations(), returning 1. src/glsl/builtin_type_macros.h | 16 ++ src/glsl/builtin_types.cpp |

[Mesa-dev] [PATCH v4] mesa: add double uniform support. (v5)

2015-02-09 Thread Ilia Mirkin
From: Dave Airlie This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) v3: fix size_mul v4: Teach uniform update to take into account double precisio

[Mesa-dev] [PATCH v4] glsl: lower double optional passes (v2)

2015-02-09 Thread Ilia Mirkin
From: Dave Airlie These lowering passes are optional for the backend to request, currently the TGSI softpipe backend most likely the r600g backend would want to use these passes as is. They aim to hit the gallium opcodes from the standard rounding/truncation functions. v2: also lower floor in mo

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Iago Toral
On Sat, 2015-02-07 at 13:41 +0100, Erik Faye-Lund wrote: > On Fri, Feb 6, 2015 at 1:11 PM, Iago Toral wrote: > > Hi, > > > > Eduardo and I have been looking into a few dEQP test failures that deal > > with wide line rendering. There are a few of them that fail because of > > how clipping is implem

Re: [Mesa-dev] [PATCH v3 00/29] add fp64 support to mesa and glsl compiler

2015-02-09 Thread Ilia Mirkin
I just sent out a few updated patches (latest can be seen in https://github.com/imirkin/mesa/commits/fp64-5) -- with all that in place the mysterious failure in one of the initializer tests is gone, and the constbuf locations being used correspond to the ones that we expect instead of having *tons*

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Roland Scheidegger
Am 09.02.2015 um 09:53 schrieb Iago Toral: > On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: >> Am 06.02.2015 um 13:11 schrieb Iago Toral: >>> Hi, >>> >>> Eduardo and I have been looking into a few dEQP test failures that deal >>> with wide line rendering. There are a few of them that

[Mesa-dev] [PATCH 3/3] dri/common: Fix returned value of __DRI2_RENDERER_PREFERRED_PROFILE

2015-02-09 Thread Andreas Boll
If the renderer supports the core profile the query returned incorrectly 0x8 as value, because it was using (1U << __DRI_API_OPENGL_CORE) for the returned value. The same happened with the compatibility profile. It returned 0x1 (1U << __DRI_API_OPENGL) instead of 0x2. Used defines for the incorre

[Mesa-dev] [PATCH 2/3] mesa: Redefine GLX_CONTEXT_{CORE|COMPATIBILITY}_PROFILE_BIT_ARB

2015-02-09 Thread Andreas Boll
GLX_MESA_query_renderer uses these values for its query GLX_RENDERER_PREFERRED_PROFILE_MESA. Since GLX header files may not be available everywhere they need to be used, redefine them here. This is needed for the next patch. Cc: "10.3 10.4 10.5" Signed-off-by: Andreas Boll --- I hope this is

[Mesa-dev] [PATCH 1/3] dri/common: Update comment about driQueryRendererIntegerCommon

2015-02-09 Thread Andreas Boll
Since 87d3ae0b45b6b6bb50b583dafa55eb109449a005 driQueryRendererIntegerCommon handles __DRI2_RENDERER_PREFFERED_PROFILE too. Signed-off-by: Andreas Boll --- src/mesa/drivers/dri/common/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/driv

Re: [Mesa-dev] [PATCH 08/32] i965/fs: Fix stack allocation of fs_inst and stop stealing src array provided on construction.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: >> Using 'ralloc*(this, ...)' is wrong if the object has automatic >> storage or was allocated through any other means. Use normal dynamic >> memory instead. >> --- > > I don't see any places we were allocating an fs_i

Re: [Mesa-dev] [PATCH 14/32] i965/fs: Fix register coalesce not to lose track of the second half of 16-wide moves.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: >> Fixes rewrite by the register coalesce pass of references to >> individual halves of 16-wide coalesced registers. >> --- >> src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 8 ++-- >> 1 file changed, 6 i

[Mesa-dev] [PATCH 2/6] main: Added entry point for glTransformFeedbackBufferBase

2015-02-09 Thread Martin Peres
v2: Review from Laura Ekstrand - give more helpful error messages - factor the lookup code for the xfb and objBuf - replace some already-existing tabs with spaces - add comments to explain the cases where xfb == 0 or buffer == 0 - fix the condition for binding the transform buffer or not v3: Revie

[Mesa-dev] [PATCH 1/6] main: Added entry point for glCreateTransformFeedbacks

2015-02-09 Thread Martin Peres
v2: Review from Laura Ekstrand - generate the name of the gl method once - shorten some lines to stay in the 78 chars limit v3: Review from Fredrik Höglund - rename gl_mthd_name to func - set EverBound in _mesa_create_transform_feedbacks in the dsa case v4: - rename _mesa_create_transform_feedba

[Mesa-dev] [PATCH 5/6] main: Added entry point for glGetTransformFeedbacki_v

2015-02-09 Thread Martin Peres
v2: Review from Laura Ekstrand - use the transform feedback object lookup wrapper v3: - use the new name of _mesa_lookup_transform_feedback_object_err Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1

[Mesa-dev] [PATCH 6/6] main: Added entry point for glGetTransformFeedbacki64_v

2015-02-09 Thread Martin Peres
v2: Review from Laura Ekstrand - use the transform feedback object lookup wrapper v3: - use the new name of _mesa_lookup_transform_feedback_object_err Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ src/mesa/main/tests/dispatch_sanity.cpp| 1

[Mesa-dev] [PATCH 0/6] Add 6 transform-feedback-related entry points for direct_state_access v2

2015-02-09 Thread Martin Peres
The updated version of my series. I think I answered everyone's comments on the previous series. The corresponding piglit tests have been submited to the piglit ML too. No regression spotted by piglit when applying this series. Warning: Those tests will only work when forcing mesa to expose the DS

[Mesa-dev] [PATCH 4/6] main: Added entry point for glGetTransformFeedbackiv

2015-02-09 Thread Martin Peres
v2: Review from Laura Ekstrand - use the transform feedback object lookup wrapper Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/transformfeedback.c | 25 +++

[Mesa-dev] [PATCH 3/6] main: Added entry point for glTransformFeedbackBufferRange

2015-02-09 Thread Martin Peres
v2: review from Laura Ekstrand - use the refactored code to lookup the objects - improve some error messages - factor out the gl method name computation - better handle the spec differences between the DSA and non-DSA cases - quote the spec a little more v3: review from Laura Ekstrand - use the ne

Re: [Mesa-dev] [PATCH 18/32] i965/vec4: Don't attempt to reduce swizzles of send from GRF instructions.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp >> b/src/mesa/drivers/dri/i965/brw_vec4.cpp >> inde

Re: [Mesa-dev] [PATCH 19/32] i965/vec4: Pass dst register to the vec4_instruction constructor.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: >> So regs_written gets initialized with a sensible value. >> --- >> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 11 +-- >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/src/mesa/drive

Re: [Mesa-dev] [PATCH 21/32] i965/vec4: Fix the scheduler to take into account reads and writes of multiple registers.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:43 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 1 + >> src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 15 ++- >> src/mesa/drivers/dri/i965/brw_vec4.cpp | 17

Re: [Mesa-dev] [PATCH 01/14] i965: Don't tile 1D miptrees.

2015-02-09 Thread Neil Roberts
I made a similar patch in my local tree because it will be necessary for Skylake which doesn't support tiling for 1D textures. I made a little test to time rendering a large (4096) 1D texture here: https://github.com/bpeel/glthing/tree/time-1d-texture It gives about an 11% increase in FPS with th

[Mesa-dev] [PATCHv2 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-09 Thread Francisco Jerez
Some instruction bits don't have a mapping defined to any compacted instruction field. If they're ever set and we end up compacting the instruction they will be forced to zero. Avoid using compaction in such cases. v2: Align multiple lines of an expression to the same column. Change conditi

[Mesa-dev] [PATCHv2 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-09 Thread Francisco Jerez
Right now virtual GRF book-keeping and allocation is performed in each visitor class separately (among other hundred different things), leading to duplicated logic in each visitor and preventing layering as it forces any code that manipulates i965 IR and needs to allocate virtual registers to depen

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 84570, which changed state. Bug 84570 Summary: Borderlands 2/Pre-Sequel: Constant frame rate drops while playing; really bad with additionl lighting https://bugs.freedesktop.org/show_bug.cgi?id=84570 What|

[Mesa-dev] [Bug 84570] Borderlands 2/Pre-Sequel: Constant frame rate drops while playing; really bad with additionl lighting

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 Kai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 00/10] i965/fs: Combine constants and unconditionally emit MADs

2015-02-09 Thread Eero Tamminen
Hi, On 02/05/2015 06:21 AM, Matt Turner wrote: total instructions in shared programs: 5895414 -> 5747578 (-2.51%) instructions in affected programs: 3618111 -> 3470275 (-4.09%) helped:20492 HURT: 4449 GAINED:

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Erik Faye-Lund
On Mon, Feb 9, 2015 at 12:35 PM, Roland Scheidegger wrote: > Am 09.02.2015 um 09:53 schrieb Iago Toral: >> On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: >>> Am 06.02.2015 um 13:11 schrieb Iago Toral: Hi, Eduardo and I have been looking into a few dEQP test failures th

[Mesa-dev] [PATCH] mesa: Rename the CEILING() macro to DIV_ROUND_UP().

2015-02-09 Thread Francisco Jerez
Some people have complained that code using the CEILING() macro is difficult to understand because it's not immediately obvious what it is supposed to do until you go and look up its definition. Use a more descriptive name that matches the similar utility macro in the Linux kernel. --- src/mesa/d

[Mesa-dev] [PATCH] i965/fs: Fix fs_inst::regs_written calculation for instructions with scalar dst.

2015-02-09 Thread Francisco Jerez
Scalar registers are required to have zero stride, fix the regs_written calculation not to assume that the instruction writes zero registers in that case. v2: Rename CEILING() to DIV_ROUND_UP(). (Matt, Ken) Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 3 ++- 1 file ch

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-09 Thread Jose Fonseca
On 06/02/15 22:39, Carl Worth wrote: On Fri, Feb 06 2015, Aaron Watry wrote: Ignore me if this is a stupid question, but should those both be sizeof(short)? I'd expect the first to be sizeof(char). Not a stupid question. That was a copy-and-paste (kill-and-yank ?) bug of mine. Thanks for you

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 Bug ID: 89043 Summary: undefined symbol: _glapi_tls_Dispatch Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: nor

[Mesa-dev] [PATCH] mesa: Bump MAX_IMAGE_UNIFORMS to 32.

2015-02-09 Thread Francisco Jerez
So the i965 driver can expose 32 image uniforms per shader stage. --- src/mesa/main/config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index 4ec4b75..08e1a14 100644 --- a/src/mesa/main/config.h +++ b/src/mesa/main/config.h @

Re: [Mesa-dev] [PATCH 02/14] i965: Allocate binding table space for shader images.

2015-02-09 Thread Francisco Jerez
Kenneth Graunke writes: > On Saturday, February 07, 2015 03:03:44 AM Francisco Jerez wrote: >> Kenneth Graunke writes: >> >> > On Friday, February 06, 2015 07:23:16 PM Francisco Jerez wrote: >> >> Reviewed-by: Paul Berry >> >> --- >> >> src/mesa/drivers/dri/i965/brw_context.h | 5 + >> >>

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-02-09 Thread Jon TURNEY
On 06/02/2015 19:58, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:38 AM, Jonathan Gray wrote: OpenBSD has ffs in libc but does not have ffsll so use the compiler builtin. PIPE_OS_BSD isn't suitable here as FreeBSD has ffsll in libc. Signed-off-by: Jonathan Gray --- src/gallium/auxiliary/uti

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

2015-02-09 Thread Roland Scheidegger
FWIW using a different name for such helpers in src/util looks good to me (and I'm pretty indifferent to the actual name). We already have imports from mesa/main crept in there which need fixing and we certainly don't want to make the same mistake with gallium includes. Roland Am 08.02.2015 um 21

[Mesa-dev] [PATCH] i965: Don't tile 1D miptrees.

2015-02-09 Thread Francisco Jerez
It doesn't really improve locality of texture fetches, quite the opposite it's a waste of memory bandwidth and space due to tile alignment. v2: Check mt->logical_height0 instead of mt->target (Ken). Add short comment explaining why they shouldn't be tiled. --- src/mesa/drivers/dri/i965/intel

Re: [Mesa-dev] [PATCH 14/14] i965/gen7-8: Implement glMemoryBarrier().

2015-02-09 Thread Francisco Jerez
Kristian Høgsberg writes: > On Fri, Feb 6, 2015 at 9:23 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_program.c | 40 >> + >> src/mesa/drivers/dri/i965/intel_reg.h | 1 + >> 2 files changed, 41 insertions(+) >> >> diff --git a/src/mesa/dr

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

2015-02-09 Thread Emil Velikov
On 07/02/15 21:44, Sedat Dilek wrote: > Hi, > > I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2. > > My build breaks like this... > > ... > > Please cherry-pick... > > commit ef7e0b39a24966526b102643523feac765771842 > "gallivm: Update for RTDyldMemoryManager becoming an unique_ptr

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

2015-02-09 Thread Emil Velikov
Hi Sedat, On 07/02/15 22:42, Sedat Dilek wrote: > [ Please CC me I am not subscribed to mesa-dev and llvmdev MLs ] > > Hi, > > I already reported this when playing 1st time with my llvm-toolchain > v3.6.0rc2 and mesa v10.3.7 [1]. > The issue still remains in mesa v10.4.4. > > So, this is a fiel

Re: [Mesa-dev] [PATCH 11/14] i965/gen7: Enable fragment shader dispatch if the program has image uniforms.

2015-02-09 Thread Francisco Jerez
Kenneth Graunke writes: > On Friday, February 06, 2015 07:23:25 PM Francisco Jerez wrote: >> Shaders with image uniforms may have side effects. Make sure that >> fragment shader threads are dispatched if the shader has any image >> uniforms. >> --- >> src/mesa/drivers/dri/i965/gen7_wm_state.c |

Re: [Mesa-dev] [PATCH] i965: Don't tile 1D miptrees.

2015-02-09 Thread Neil Roberts
Looks good to me. Reviewed-by: Neil Roberts - Neil Francisco Jerez writes: > It doesn't really improve locality of texture fetches, quite the > opposite it's a waste of memory bandwidth and space due to tile > alignment. > > v2: Check mt->logical_height0 instead of mt->target (Ken). Add shor

[Mesa-dev] [PATCH] i965/skl: Implement WaDisable1DDepthStencil

2015-02-09 Thread Neil Roberts
Skylake+ doesn't support setting a depth buffer to a 1D surface but it does allow pretending it's a 2D texture with a height of 1 instead. This fixes the GL_DEPTH_COMPONENT_* tests of the copyteximage piglit test (and also seems to avoid a subsequent GPU hang). Bugzilla: https://bugs.freedesktop.

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-09 Thread Carl Worth
On Mon, Feb 09 2015, Jose Fonseca wrote: > Just one more tweak to InterlockedExchangeAdd64 as per patch attached. .. > With that u_test_atomic builds and passes for me both on 32 and > 64bits. Excellent. Thanks for the fix and for the testing report. > Sorry for the delay. And thanks for your he

Re: [Mesa-dev] [PATCH] mesa: Rename the CEILING() macro to DIV_ROUND_UP().

2015-02-09 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Fix fs_inst::regs_written calculation for instructions with scalar dst.

2015-02-09 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] glsl: Making logical operations per-component?

2015-02-09 Thread Ian Romanick
On 02/08/2015 04:10 PM, Matt Turner wrote: > The GLSL IR ir_binop_logic_* operations match the source language > operators in that they only operate on scalars. > > In talking to Ilia, I realized that the vectorizer pass doesn't know > about that, and so it will happily vectorize the vertex shader

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-09 Thread Ian Romanick
On 02/07/2015 05:25 PM, Matt Turner wrote: > On Sat, Feb 7, 2015 at 5:16 PM, Ilia Mirkin wrote: >> On Sat, Feb 7, 2015 at 8:10 PM, Ilia Mirkin wrote: > diff --git a/src/glsl/ir.h b/src/glsl/ir.h > index a0f48b2..6e7c654 100644 > --- a/src/glsl/ir.h > +++ b/src/glsl/ir.h > @@ -

[Mesa-dev] [PATCHv2 11/14] i965/gen7: Enable fragment shader dispatch if the program has image uniforms.

2015-02-09 Thread Francisco Jerez
Shaders with image uniforms may have side effects. Make sure that fragment shader threads are dispatched if the shader has any image uniforms. v2: Use brw_stage_state::nr_image_params to find out if the shader has image uniforms instead of checking core mesa data structures (Ken). --- src/me

Re: [Mesa-dev] [PATCH v2 12/28] glsl/ir: Add builtin constant function support for doubles

2015-02-09 Thread Ian Romanick
On 02/07/2015 06:25 PM, Ilia Mirkin wrote: > On Fri, Feb 6, 2015 at 3:02 AM, Ian Romanick wrote: >>> @@ -708,6 +763,9 @@ ir_expression::constant_expression_value(struct >>> hash_table *variable_context) >>>case GLSL_TYPE_FLOAT: >>> data.f[c] = op[0]->value.f[c] - floor(op[0]->va

[Mesa-dev] [PATCHv2 12/14] i965/gen7-8: Poke the 3DSTATE UAV access enable bits.

2015-02-09 Thread Francisco Jerez
v2: Set the PS UAV-only bit on HSW (Ken). --- src/mesa/drivers/dri/i965/brw_defines.h | 4 src/mesa/drivers/dri/i965/gen7_gs_state.c | 4 +++- src/mesa/drivers/dri/i965/gen7_vs_state.c | 13 - src/mesa/drivers/dri/i965/gen7_wm_state.c | 9 + src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCHv2 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 6:08 AM, Francisco Jerez wrote: > Some instruction bits don't have a mapping defined to any compacted > instruction field. If they're ever set and we end up compacting the > instruction they will be forced to zero. Avoid using compaction in such > cases. > > v2: Align mult

[Mesa-dev] [PATCHv2 13/14] i965/gen7-8: Set up early depth/stencil control appropriately for image load/store.

2015-02-09 Thread Francisco Jerez
v2: Store early fragment test mode in brw_wm_prog_data instead of getting it from core mesa data structures (Ken). --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_defines.h | 3 +++ src/mesa/drivers/dri/i965/brw_wm.c | 2 ++ src/mesa/drivers

Re: [Mesa-dev] [PATCH 08/32] i965/fs: Fix stack allocation of fs_inst and stop stealing src array provided on construction.

2015-02-09 Thread Matt Turner
Sounds well reasoned to me. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-02-09 Thread Jose Fonseca
On 09/02/15 16:59, Jon TURNEY wrote: On 06/02/2015 19:58, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:38 AM, Jonathan Gray wrote: OpenBSD has ffs in libc but does not have ffsll so use the compiler builtin. PIPE_OS_BSD isn't suitable here as FreeBSD has ffsll in libc. Signed-off-by: Jonathan

Re: [Mesa-dev] [PATCH 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-09 Thread Matt Turner
On Fri, Feb 6, 2015 at 2:40 PM, Matt Turner wrote: > 8 - Sent a question > 9 - Like mine better? > 10 - Looks wrong to me > 11-13 - Asked Jason to review > 14 - Asked for an example showing the problem > 15-16 - R-b > 17-18 - R-b - but wow, did we really hit these in practice? > 19-20 - R-b > 21 -

Re: [Mesa-dev] [PATCHv2 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-09 Thread Francisco Jerez
Matt Turner writes: > On Mon, Feb 9, 2015 at 6:08 AM, Francisco Jerez wrote: >> Some instruction bits don't have a mapping defined to any compacted >> instruction field. If they're ever set and we end up compacting the >> instruction they will be forced to zero. Avoid using compaction in such

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Connor Abbott
So last time you posted this, I had some suggestions but I realized that in light of the fact that we want to do value numbering, it didn't seem like my suggestions were any good. But now that I've thought about it a little bit, it seems to me like a better plan might be to pull instructions out of

[Mesa-dev] [PATCHv3 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-09 Thread Francisco Jerez
Some instruction bits don't have a mapping defined to any compacted instruction field. If they're ever set and we end up compacting the instruction they will be forced to zero. Avoid using compaction in such cases. v2: Align multiple lines of an expression to the same column. Change conditi

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

2015-02-09 Thread Jose Fonseca
On 09/02/15 17:44, Emil Velikov wrote: Hi Sedat, On 07/02/15 22:42, Sedat Dilek wrote: [ Please CC me I am not subscribed to mesa-dev and llvmdev MLs ] Hi, I already reported this when playing 1st time with my llvm-toolchain v3.6.0rc2 and mesa v10.3.7 [1]. The issue still remains in mesa v10.

Re: [Mesa-dev] [PATCH] mesa: Bump MAX_IMAGE_UNIFORMS to 32.

2015-02-09 Thread Kenneth Graunke
On Monday, February 09, 2015 06:37:45 PM Francisco Jerez wrote: > So the i965 driver can expose 32 image uniforms per shader stage. > --- > src/mesa/main/config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h > index 4ec4b

Re: [Mesa-dev] [PATCH] i965: Don't tile 1D miptrees.

2015-02-09 Thread Kenneth Graunke
On Monday, February 09, 2015 07:15:28 PM Francisco Jerez wrote: > It doesn't really improve locality of texture fetches, quite the > opposite it's a waste of memory bandwidth and space due to tile > alignment. > > v2: Check mt->logical_height0 instead of mt->target (Ken). Add short > comment

Re: [Mesa-dev] [PATCH] i965/skl: Implement WaDisable1DDepthStencil

2015-02-09 Thread Kenneth Graunke
On Monday, February 09, 2015 05:57:20 PM Neil Roberts wrote: > Skylake+ doesn't support setting a depth buffer to a 1D surface but it > does allow pretending it's a 2D texture with a height of 1 instead. > > This fixes the GL_DEPTH_COMPONENT_* tests of the copyteximage piglit > test (and also seem

Re: [Mesa-dev] [PATCHv3 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 12:26 PM, Francisco Jerez wrote: > Some instruction bits don't have a mapping defined to any compacted > instruction field. If they're ever set and we end up compacting the > instruction they will be forced to zero. Avoid using compaction in such > cases. > > v2: Align mul

[Mesa-dev] [PATCH] nir: Mark nir_print_instr's instr pointer as const.

2015-02-09 Thread Kenneth Graunke
Printing instructions doesn't modify them, so we can mark the parameter const. --- src/glsl/nir/nir.h | 2 +- src/glsl/nir/nir_print.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 4cb2e92..ceda977 100644 --- a/src/glsl

Re: [Mesa-dev] [PATCH] nir: Mark nir_print_instr's instr pointer as const.

2015-02-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Feb 9, 2015 at 4:42 PM, Kenneth Graunke wrote: > Printing instructions doesn't modify them, so we can mark the parameter > const. > --- > src/glsl/nir/nir.h | 2 +- > src/glsl/nir/nir_print.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Jason Ekstrand
Sorry I didn't get to this earlier. It got lost in the backlog. Reviewed-by: Jason Ekstrand Out of curiosity, are there any shader-db results for this? If not, that's ok. --Jason On Wed, Feb 4, 2015 at 3:19 PM, Matt Turner wrote: > --- > I don't know if this is right, but what we had befor

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 1:45 PM, Jason Ekstrand wrote: > Sorry I didn't get to this earlier. It got lost in the backlog. > > Reviewed-by: Jason Ekstrand > > Out of curiosity, are there any shader-db results for this? If not, that's > ok. I didn't even know if this the correct fix, so no shader-

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Jason Ekstrand
On Mon, Feb 9, 2015 at 3:01 PM, Connor Abbott wrote: > So last time you posted this, I had some suggestions but I realized > that in light of the fact that we want to do value numbering, it > didn't seem like my suggestions were any good. But now that I've > thought about it a little bit, it seem

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Jason Ekstrand
On Mon, Feb 9, 2015 at 4:54 PM, Matt Turner wrote: > On Mon, Feb 9, 2015 at 1:45 PM, Jason Ekstrand > wrote: > > Sorry I didn't get to this earlier. It got lost in the backlog. > > > > Reviewed-by: Jason Ekstrand > > > > Out of curiosity, are there any shader-db results for this? If not, > th

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 2:06 PM, Jason Ekstrand wrote: > Wow... I need to learn to read... I think we actually want || and ==. Feel free to take it over. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 --- Comment #1 from Aditya Atluri --- Hi, I re-installed Ubuntu 14.04.1 and did not check "install updates" during installation. Install and Upgrade all the packages. sudo apt-get install freeglut3-dev build-essential libx11-dev libxmu-dev li

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 Aditya Atluri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 00/10] i965/fs: Combine constants and unconditionally emit MADs

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 7:05 AM, Eero Tamminen wrote: > Hi, > > On 02/05/2015 06:21 AM, Matt Turner wrote: >> >> total instructions in shared programs: 5895414 -> 5747578 (-2.51%) >> instructions in affected programs: 3618111 -> 3470275 (-4.09%) >> helped:20492 >

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 Aditya Atluri changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 --- Comment #2 from Aditya Atluri --- It came back! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lis

[Mesa-dev] [PATCH] nir/lower_phis_to_scalar: Fix some logic in is_phi_scalarizable

2015-02-09 Thread Jason Ekstrand
--- src/glsl/nir/nir_lower_phis_to_scalar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c b/src/glsl/nir/nir_lower_phis_to_scalar.c index 3bb5cc7..7cd93ea 100644 --- a/src/glsl/nir/nir_lower_phis_to_scalar.c +++ b/src/glsl/nir/ni

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Connor Abbott
On Mon, Feb 9, 2015 at 5:04 PM, Jason Ekstrand wrote: > > > On Mon, Feb 9, 2015 at 3:01 PM, Connor Abbott wrote: >> >> So last time you posted this, I had some suggestions but I realized >> that in light of the fact that we want to do value numbering, it >> didn't seem like my suggestions were an

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Jason Ekstrand
On Mon, Feb 9, 2015 at 12:01 PM, Connor Abbott wrote: > So last time you posted this, I had some suggestions but I realized > that in light of the fact that we want to do value numbering, it > didn't seem like my suggestions were any good. But now that I've > thought about it a little bit, it see

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add a global code motion (GCM) pass

2015-02-09 Thread Connor Abbott
On Mon, Feb 9, 2015 at 6:11 PM, Jason Ekstrand wrote: > > > On Mon, Feb 9, 2015 at 12:01 PM, Connor Abbott wrote: >> >> So last time you posted this, I had some suggestions but I realized >> that in light of the fact that we want to do value numbering, it >> didn't seem like my suggestions were a

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 --- Comment #3 from Brian Paul --- Try reconfiguring with --enable-glx-tls and rebuilding. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

Re: [Mesa-dev] [PATCH 02/10] nir: Properly clean up CF nodes when we remove them

2015-02-09 Thread Connor Abbott
For some reason, the v2 version of this disappeared from my inbox, so I'll say Reviewed-by: Connor Abbott I'm not convinced this is enough for when we optimize constant if-statement conditions, but I'll leave that be for now. On Thu, Feb 5, 2015 at 5:28 PM, Jason Ekstrand wrote: > Previously,

  1   2   >