[Mesa-dev] [PATCH] r600g: Drop references to destroyed blend state

From: Michel Dänzer Fixes use-after-free when the currently bound blend state is destroyed. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85267 Signed-off-by: Michel Dänzer --- src/gallium/drivers/r600/r600_state_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] r600g: Drop references to destroyed blend state

Reviewed-by: Marek Olšák Marek On Tue, Oct 21, 2014 at 11:52 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes use-after-free when the currently bound blend state is destroyed. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85267 > Signed-off-by: Michel Dänzer > --- > src/

Re: [Mesa-dev] [PATCH] clover: Require libelf

On Mon, Oct 20, 2014 at 05:44:53PM -0400, Jan Vesely wrote: > From: Jan Vesely > > CC: Tom Stellard > CC: Emil Velikov > CC: Francisco Jerez > Signed-off-by: Jan Vesely > --- > > This fixes clover build failures when building without radeon > > configure.ac | 2 ++ > 1 file changed, 2 inse

Re: [Mesa-dev] [PATCH] clover: Fix build error with LLVM 3.4.

On Sun, Oct 19, 2014 at 12:27:26AM -0700, Vinson Lee wrote: > DataLayoutPass was added in LLVM 3.5 r202168, commit > 57edc9d4ff1648568a5dd7e9958649065b260dca "Make DataLayout a plain > object, not a pass.". > > This patch fixes this build error with LLVM 3.4. > > CXX llvm/libclllvm_la-invo

Re: [Mesa-dev] [PATCH 3/3] radeonsi/compute: Enable PIPE_SHADER_IR_NATIVE for compute shaders v2

On Mon, Oct 20, 2014 at 01:06:34PM +0900, Michel Dänzer wrote: > On 17.10.2014 08:41, Tom Stellard wrote: > >v2: > > - Drop dependency on LLVM >= 3.5.1 > > Have you tested this patch with LLVM < 3.6? Yes, I tested them with 3.5 on both radeonsi and r600. > > > >@@ -61,10 +66,7 @@ static void

Re: [Mesa-dev] [PATCH] r600g: disable sqrt for the LLVM backend.

On Mon, Oct 20, 2014 at 10:53:21PM +0200, Christopher Egert wrote: > sqrt is not supported by the LLVM backend. > What version of LLVM are you using, and what error message are you seeing? -Tom > Fixes rendering errors in Passing by Still. > http://demozoo.org/productions/156/ > > Signed-off-b

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

I have this exact patch setting in me queue to send out. Reviewed-by: Ian Romanick I had initially thought about going the other way, and using the enums instead of UniformBooleanTrue. I think the UniformBooleanTrue method is slightly more efficient since there is only one place where value con

Re: [Mesa-dev] [PATCH 3/4] glsl_to_tgsi: fix the value of gl_FrontFacing with native integers

Marek Olšák writes: > From: Marek Olšák > > We must convert it to boolean from the DX9 float encoding that Gallium > specifies. > > Later, we should probably define that FACE should be 0 or ~0 if native > integers are supported. Also fixes the ES2 conformance test. Reviewed-by: Eric Anholt

[Mesa-dev] [PATCH v2 1/1] clover: Require libelf

v2: test for libelf once, check in both radeon and clover CC: Tom Stellard CC: Emil Velikov CC: Francisco Jerez Signed-off-by: Jan Vesely --- configure.ac | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ed9325..93b25a2 100644 -

Re: [Mesa-dev] [PATCH 3/5] clover: Add support for compiling to native object code v3

On Thu, 2014-10-09 at 11:07 -0400, Tom Stellard wrote: > v2: > - Split build_module_native() into three separate functions. > - Code cleanups. > > v3: > - More cleanups. > --- > .../state_trackers/clover/llvm/invocation.cpp | 208 > - > src/gallium/targets/opencl/M

[Mesa-dev] [PATCH 2/2] clover: Fix bug when binary programs are passed to clBuildProgram()

This was a regression introduced by 611d66fe4513e53bde052dd2bab95d448c909a2a Passing a binary program to clBuildProgram() is legal, but passing one to clCompileProgram() is not. --- src/gallium/state_trackers/clover/api/program.cpp | 21 - 1 file changed, 16 insertions(+), 5 d

[Mesa-dev] [PATCH 1/2] clover: Factor input validation of clCompileProgram into a new function

This factors out the validation that is common with clBuildProgram(). --- src/gallium/state_trackers/clover/api/program.cpp | 36 --- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/

Re: [Mesa-dev] [PATCH 09/14] gallium/auxiliary: add inc and dec alternative with return

Am 20.10.2014 um 14:37 schrieb David Heidelberger: > From: Christoph Bumiller > > They're useful for Gallium Nine. > > Signed-off-by: David Heidelberger > --- > src/gallium/auxiliary/util/u_atomic.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/src/galli

Re: [Mesa-dev] [PATCH 00/14] [v2] Famous Gallium Nine

Hello, according to DRI3 is mandatory. But AFAICT you only enforce "has Gallium3D drivers" in the configure checks introduced in . I would find it better, if configure died, in case I'm try

[Mesa-dev] [PATCH v2] nv50: Handle ARB_conditional_render_inverted and enable it

Signed-off-by: Tobias Klausmann --- docs/GL3.txt| 2 +- docs/relnotes/10.4.html | 1 + src/gallium/drivers/nouveau/nv50/nv50_context.h | 3 +- src/gallium/drivers/nouveau/nv50/nv50_query.c | 56 + src/gallium

Re: [Mesa-dev] [PATCH 3/5] clover: Add support for compiling to native object code v3

On Tue, Oct 21, 2014 at 12:16:12PM -0400, Jan Vesely wrote: > On Thu, 2014-10-09 at 11:07 -0400, Tom Stellard wrote: > > v2: > > - Split build_module_native() into three separate functions. > > - Code cleanups. > > > > v3: > > - More cleanups. > > --- > > .../state_trackers/clover/llvm/invo

Re: [Mesa-dev] [PATCH] r600g: Drop references to destroyed blend state

Hello Michel, this patch fixes this, too: https://bugs.freedesktop.org/show_bug.cgi?id=84140 Tested-by: Dieter Nützel GREAT stuff! Dieter Am 21.10.2014 11:52, schrieb Michel Dänzer: From: Michel Dänzer Fixes use-after-free when the currently bound blend state is destroyed. Bugzilla: https

Re: [Mesa-dev] [PATCH 3/5] clover: Add support for compiling to native object code v3

On Tue, 2014-10-21 at 09:50 -0700, Tom Stellard wrote: [SNIP] > > > + void > > > + init_targets() { > > > + static bool targets_initialized = false; > > > + if (!targets_initialized) { > > > + LLVMInitializeAllTargets(); > > > + LLVMInitializeAllTargetInfos(); > > > +

Re: [Mesa-dev] [PATCH 1/4] gallium: add PIPE_SHADER_CAP_MAX_OUTPUTS and use it in st/mesa

Okay, I decided to change the output limit for softpipe and llvmpipe to 32 instead of 48. 32 is all that OpenGL needs and it will probably make piglit happier too. Marek On Fri, Oct 17, 2014 at 8:19 AM, Roland Scheidegger wrote: > On 10/16/2014 12:55 PM, Marek Olšák wrote: >> >> On Thu, Oct 16,

Re: [Mesa-dev] [PATCH v4] radeonsi: Add CIK SDMA support

Sorry for a late review. cik_num_pipes is redundant with si_pipe.c : si_initialize_pipe_config. If you look at that, you'll see that sscreen->b.tiling_info.num_channels already contains the number of pipes. Other than that, it looks good. Marek On Tue, Oct 7, 2014 at 10:53 AM, Michel Dänzer w

Re: [Mesa-dev] [PATCH] r600g: disable sqrt for the LLVM backend.

Hi Tom, i'm using LLVM 3.5 (Debian unstable). There is no error message, but the rendering is wrong: correct: https://i.imgur.com/matTeJk.jpg wrong: https://i.imgur.com/zRJ3hdJ.png This is the same frame dumped via apitrace with and without that patch. I can provide the apitrace if you want to

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

On Tuesday, October 21, 2014 08:05:43 AM Ian Romanick wrote: > I have this exact patch setting in me queue to send out. > > Reviewed-by: Ian Romanick > > I had initially thought about going the other way, and using the enums > instead of UniformBooleanTrue. I think the UniformBooleanTrue method

[Mesa-dev] [PATCH] mesa: remove conditional render and rgtc from ES3 requirements

The functionality exposed by those extensions does not appear in ES3 Signed-off-by: Ilia Mirkin --- I'm _pretty_ sure the above statement is right, but not 100% sure :) Perhaps someone who really knows can double-check. src/mesa/main/version.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[Mesa-dev] [Bug 84566] Unify the format conversion code

https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #34 from Jason Ekstrand --- (In reply to Samuel Iglesias from comment #33) > Jason, I would like to know your opinion about the integer RGBA clamping > done in pack.c (_mesa_pack_rgba_span_from_ints()). > > glReadPixels() and glGetTe

Re: [Mesa-dev] [PATCH] mesa: remove conditional render and rgtc from ES3 requirements

Reviewed-by: Matt Turner Maybe we can also get rid of this comment as well? /* FINISHME: This list isn't quite right. */ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: remove conditional render and rgtc from ES3 requirements

On Tue, Oct 21, 2014 at 11:10 PM, Matt Turner wrote: > Reviewed-by: Matt Turner > > Maybe we can also get rid of this comment as well? > > /* FINISHME: This list isn't quite right. */ I'm happy to get rid of it, but that list definitely isn't quite right. At the very least, EXT_texture_snorm is

[Mesa-dev] [PATCH 3/4] mesa: Handle clip control in meta operations.

From: Mathias Fröhlich Restore clip control to the default state if MESA_META_VIEWPORT or MESA_META_DEPTH_TEST is requested. Signed-off-by: Mathias Froehlich --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 4 2 files changed, 17 insertions(+) diff

[Mesa-dev] [PATCH 0/4] Implement clip control

From: Mathias Fröhlich Hi, The next approach to bring decent depth buffer precision to mesa. The patch series implements ARB_clip_control in mesa and enables the extension for the gallium drivers. Please review. Greetings Mathias Mathias Fröhlich (4): mesa: Refactor viewport transform com

[Mesa-dev] [PATCH 2/4] mesa: Implement ARB_clip_control.

From: Mathias Fröhlich Implement the mesa parts of ARB_clip_control. So far no driver enables this. Signed-off-by: Mathias Froehlich --- src/mapi/glapi/gen/ARB_clip_control.xml | 25 +++ src/mapi/glapi/gen/gl_API.xml | 4 +- src/mesa/main/dlist.c | 26 +

[Mesa-dev] [PATCH 1/4] mesa: Refactor viewport transform computation.

From: Mathias Fröhlich This is for preparation of ARB_clip_control. Signed-off-by: Mathias Froehlich --- src/mesa/drivers/dri/i915/i915_state.c| 26 ++--- src/mesa/main/state.c | 9 +++--- src/mesa/main/viewport.c | 47 -

[Mesa-dev] [PATCH 4/4] gallium: Enable ARB_clip_control for gallium drivers.

From: Mathias Fröhlich Gallium should be prepared fine for ARB_clip_control. So enable this and mention it in the release notes. Signed-off-by: Mathias Froehlich --- docs/GL3.txt| 2 +- docs/relnotes/10.4.html | 1 + src/mesa/state_tracker/

Re: [Mesa-dev] [PATCH 00/14] [v2] Famous Gallium Nine

On 21/10/2014 18:30, Kai Wasserbäch wrote : Hello, according to DRI3 is mandatory. But AFAICT you only enforce "has Gallium3D drivers" in the configure checks introduced in . I would find

Re: [Mesa-dev] [PATCH 0/4] Implement clip control

Hi Mathias, Do you have piglit tests to go with this? -- Chris On Wed, Oct 22, 2014 at 6:31 PM, wrote: > From: Mathias Fröhlich > > Hi, > > The next approach to bring decent depth buffer precision to mesa. > > The patch series implements ARB_clip_control in mesa and enables the > extension f

[Mesa-dev] [Bug 83445] eglSwapBuffers() crash on dri

https://bugs.freedesktop.org/show_bug.cgi?id=83445 --- Comment #3 from Tapani Pälli --- Lionel, could you specify a minimal testcase for this? I'm not able to reproduce this using a small app (egl and gles2) that just calls eglSwapBuffers() few times (with or without glclear calls in between). -