On Tuesday, October 21, 2014 08:05:43 AM Ian Romanick wrote: > I have this exact patch setting in me queue to send out. > > Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > I had initially thought about going the other way, and using the enums > instead of UniformBooleanTrue. I think the UniformBooleanTrue method is > slightly more efficient since there is only one place where value > conversions occur.
Right. It seems like the remaining enums are a bit redundant as well, given that we have ctx->Const.NativeIntegers, but ir_to_mesa uses it, so it isn't technically dead yet. It seemed odd to me that st_glsl_to_tgsi doesn't use uniform_int_float at all. If anyone is bored and wants to tidy more code... :)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
