Re: [Mesa-dev] [PATCH] glsl: make consistent use of DECLARE_RALLOC_CXX_OPERATORS

2014-09-30 Thread Kenneth Graunke
On Tuesday, September 30, 2014 12:14:06 AM Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > Noticed this when investigating how ralloc worked. I'm moderately sure that > the old code was fine, but seems nicer to use the cooked known-to-work macro. Yeah, Curro fixed this to actually hook

[Mesa-dev] [PATCH] mesa: relax draw api validation on ES2

2014-09-30 Thread Tapani Pälli
Patch fixes failing test in WebGL conformance test 'point-no-attributes' when running Chrome on OpenGL ES. (Shader program may draw points using constant data in shader.) No Piglit regressions. Signed-off-by: Tapani Pälli --- src/mesa/main/api_validate.c | 5 ++--- 1 file changed, 2 insertions(

Re: [Mesa-dev] [PATCH] mesa: relax draw api validation on ES2

2014-09-30 Thread Kenneth Graunke
On Tuesday, September 30, 2014 10:28:26 AM Tapani Pälli wrote: > Patch fixes failing test in WebGL conformance test > 'point-no-attributes' when running Chrome on OpenGL ES. > (Shader program may draw points using constant data in shader.) > > No Piglit regressions. > > Signed-off-by: Tapani Päll

[Mesa-dev] [PATCH 2/2] i965: Use BDW_MOCS_PTE for renderbuffers.

2014-09-30 Thread Kenneth Graunke
Write-back caching cannot be used for buffers being scanned out by the display engine; surfaces used for scan-out must be write-through or uncached. I originally chose WT for render targets because it works in all cases. However, we really want to use write-back caching where possible, as it is m

[Mesa-dev] [PATCH 1/2] i965: Add a BRW_MOCS_PTE #define.

2014-09-30 Thread Kenneth Graunke
Like BDW_MOCS_WB and BDW_MOCS_WT, this specifies that we want to use all three caches (L3, LLC, and eLLC where available), but leaves the LLC caching mode up to the kernel's page table entry. This allows the kernel to pick WB/WT/UC based on whether it's using a buffer for scanout. Signed-off-by:

Re: [Mesa-dev] [PATCH 2/2] i965: Use BDW_MOCS_PTE for renderbuffers.

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 01:15:56AM -0700, Kenneth Graunke wrote: > Write-back caching cannot be used for buffers being scanned out by the > display engine; surfaces used for scan-out must be write-through or > uncached. I originally chose WT for render targets because it works in > all cases. How

Re: [Mesa-dev] [PATCH 1/4] radeonsi: Fix tiling mode index for stencil resources

2014-09-30 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 30, 2014 at 5:58 AM, Michel Dänzer wrote: > From: Michel Dänzer > > We are currently only dealing with depth-only or stencil-only resources > here, not with resources having both depth and stencil[0]. In both cases, > the tiling mode

Re: [Mesa-dev] [PATCH libdrm] radeon: Always multiply pitch_bytes by nsamples, not by slice_pt

2014-09-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Sep 30, 2014 at 5:58 AM, Michel Dänzer wrote: > From: Michel Dänzer > > slice_pt is tileb[0] / tile_split, which isn't directly related to the > pitch. > > This caused pitch_bytes to be too large in some cases. > > [0] Tile size in bytes > > Signed-off-by

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 --- Comment #10 from David Kredba --- The same result with gcc 5.0 svn rev. 215679. .eh_frame_hdr table[5712] FDE at 00c45788 overlaps table[5713] FDE at 00c45684. Now I will try older binutils with two gcc versions used before.

Re: [Mesa-dev] [PATCH v3] glsl: Optimize min/max expression trees

2014-09-30 Thread Iago Toral Quiroga
I just noticed that we should add: index a4fe2bd..ca53eb8 100644 --- a/src/glsl/opt_minmax.cpp +++ b/src/glsl/opt_minmax.cpp @@ -415,6 +415,17 @@ ir_minmax_visitor::prune_expression(ir_expression *expr, minmax_range baserange) } } + /* If we got here we could not discard any of the

Re: [Mesa-dev] [PATCH] egl: setup screen iterator before using it

2014-09-30 Thread Juha-Pekka Heikkila
On 29.09.2014 19:07, Matt Turner wrote: > On Mon, Sep 29, 2014 at 5:08 AM, Tapani Pälli wrote: >> commit 4ed23fd broke creation of pbuffer surfaces, patch fixes >> the failure, noticed when running chrome with '--use-gl=egl'. > > Cc'ing JP so he can review as well. > > Reviewed-by: Matt Turner

[Mesa-dev] SandyBridge's 'resinfo' -> returned value for SURFTYPE_BUFFER?

2014-09-30 Thread Samuel Iglesias Gonsálvez
Hello, I am looking at bug 57439 [0] where it shows an error in a piglit test [1] related to textureSize() function happening in Intel SandyBridge hardware. According to SNB's PRM documentation (vol4 part1 page 141), the returned value for SURFTYPE_BUFFER (the surface type used in the test) is no

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 --- Comment #11 from David Kredba --- With Gentoo vanilla binutils 2.24-r3 with two slim LTO patches and the patch referred by Emil Velikov in Comment #3 https://projects.archlinux.org/svntogit/packages.git/plain/trunk/binutils-2.24-shared-pie.p

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 Marek Olšák changed: What|Removed |Added Attachment #105815|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH v2] replace file specific compileroptimization withinline attibute

2014-09-30 Thread Marc Dietrich
Hi Matt, Am Donnerstag, 25. September 2014, 09:56:42 schrieb Marc Dietrich: > Am Mittwoch, 24. September 2014, 18:35:24 schrieb Matt Turner: > > On Wed, Sep 24, 2014 at 6:25 AM, Marc Dietrich wrote: > > > Am Montag, 22. September 2014, 11:48:29 schrieb Matt Turner: > > >> We need a configure chec

[Mesa-dev] [PATCH] llvmpipe: move lp_jit_screen_init() call after allocation of screen object

2014-09-30 Thread Brian Paul
The screen argument isn't actually used by lp_jit_screen_init() at this time, but let's move the call so that we pass a valid pointer. v2: don't leak screen if lp_jit_screen_init() fails. --- src/gallium/drivers/llvmpipe/lp_screen.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: move lp_jit_screen_init() call after allocation of screen object

2014-09-30 Thread Brian Paul
On 09/29/2014 07:46 PM, Michel Dänzer wrote: On 30.09.2014 10:45, Michel Dänzer wrote: On 30.09.2014 07:16, Brian Paul wrote: The screen argument isn't actually used by lp_jit_screen_init() at this time, I guess that's why gcc didn't warn about it? Nope, it actually does warn about it. Mea

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 --- Comment #12 from Emil Velikov --- (In reply to comment #11) > With Gentoo vanilla binutils 2.24-r3 with two slim LTO patches and the patch > referred by Emil Velikov in Comment #3 > > https://projects.archlinux.org/svntogit/packages.git/plai

Re: [Mesa-dev] [PATCH] mesa: relax draw api validation on ES2

2014-09-30 Thread Ian Romanick
On 09/30/2014 12:28 AM, Tapani Pälli wrote: > Patch fixes failing test in WebGL conformance test > 'point-no-attributes' when running Chrome on OpenGL ES. > (Shader program may draw points using constant data in shader.) > > No Piglit regressions. This sounds believable. Did you also try the ES2

Re: [Mesa-dev] [PATCH] radeonsi: fix CS tracing and remove excessive CS dumping

2014-09-30 Thread Marek Olšák
Jerome, Could you please review this? Thanks, Marek On Sat, Sep 20, 2014 at 12:26 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 36 > ++-- > src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- > src/gallium/dri

Re: [Mesa-dev] [RFC PATCH 05/56] mesa/main: Add tessellation shader state and limits

2014-09-30 Thread Ian Romanick
On 09/20/2014 07:41 PM, Matt Turner wrote: > On Sat, Sep 20, 2014 at 6:40 PM, Chris Forbes wrote: >> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c >> index 79d2e94..c11ad4f 100644 >> --- a/src/mesa/main/shaderapi.c >> +++ b/src/mesa/main/shaderapi.c >> @@ -105,6 +105,7 @@ _mes

Re: [Mesa-dev] [RFC PATCH 10/56] mesa: Generalize sso stage interleaving check for tess

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/pipelineobj.c | 53 > +++-- > 1 file changed, 37 insertions(+), 16 deletions(-) > > diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c > in

Re: [Mesa-dev] [RFC PATCH 15/56] mesa/main: Add misc tessellation shader stuff.

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > From: Fabian Bieler > > --- > src/mesa/main/context.c | 6 + > src/mesa/main/mtypes.h| 3 ++- > src/mesa/main/shaderapi.c | 29 > src/mesa/main/state.c | 67 > +-- > 4

Re: [Mesa-dev] [RFC PATCH 09/56] mesa: Allow tess stages in glUseProgramStages

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > --- > src/mesa/main/pipelineobj.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c > index 61a5785..c902107 100644 > --- a/src/mesa/main/pipelineobj.c

Re: [Mesa-dev] [RFC PATCH 16/56] mesa/program: Add misc tessellation shader support.

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > From: Fabian Bieler > > --- > src/mesa/program/program.c | 44 ++ > src/mesa/program/program.h | 60 > +- > 2 files changed, 103 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-09-30 Thread Marek Olšák
From: Marek Olšák I'll need this in radeonsi. --- src/gallium/auxiliary/util/u_math.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index 39bd40f..48d5c31 100644 --- a/src/gallium/auxiliary/util/u_math.h +++

Re: [Mesa-dev] [RFC PATCH 17/56] mesa: Add support for UNIFORM_BLOCK_REFERENCED_BY_TESS_*_SHADER

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/uniforms.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c > index 0d0cbf5..ceeadf4 100644 > --- a/s

Re: [Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-09-30 Thread Ilia Mirkin
Perhaps do the same thing as util_bitcount, i.e. #if defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 304) return __builtin_popcountll(n); #else ... #endif Perhaps the gcc version check is no longer necessary, unlikely anyone's using gcc3.3 or earlier at this point. But whatever. On Tue, Sep 30

[Mesa-dev] [PATCH] tgsi: fix Semantic.Name assignment in tgsi_transform_input_decl()

2014-09-30 Thread Brian Paul
Assign the sem_name parameter, not TGSI_SEMANTIC_GENERIC. Fixes polygon stipple regression. --- src/gallium/auxiliary/tgsi/tgsi_transform.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.h b/src/gallium/auxiliary/tgsi/tgsi_transfor

Re: [Mesa-dev] [RFC PATCH 12/56] mesa: Add tessellation shader builtin varyings.

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > From: Fabian Bieler > > --- > src/mesa/main/mtypes.h| 15 ++- > src/mesa/program/prog_print.c | 4 > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index

Re: [Mesa-dev] [RFC PATCH 21/56] glsl: Add tessellation shader defines and built-in variables.

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:41 PM, Chris Forbes wrote: > From: Fabian Bieler > > --- > src/glsl/builtin_variables.cpp | 62 > +- > src/glsl/glcpp/glcpp-parse.y | 3 ++ > 2 files changed, 64 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/builtin_variables

Re: [Mesa-dev] [RFC PATCH 00/56] ARB_tessellation_shader for core mesa

2014-09-30 Thread Ian Romanick
On 09/20/2014 06:40 PM, Chris Forbes wrote: > This series adds all the driver-independent bits for ARB_tessellation_shader. > It's not quite finished, and there are still a handful of ugly hacks to > remove, but I think it's complete enough to start getting some review > feedback. Patches 1, 2, a

[Mesa-dev] [PATCH 03/13] radeonsi: get fs_write_all from tgsi_shader_info directly

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 8 ++-- src/gallium/drivers/radeonsi/si_shader.h | 6 -- src/gallium/drivers/radeonsi/si_state.c | 5 + 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/ga

[Mesa-dev] [PATCH 02/13] tgsi: simplify shader properties in tgsi_shader_info

2014-09-30 Thread Marek Olšák
From: Marek Olšák Use an array of properties indexed by TGSI_PROPERTY_* definitions. --- src/gallium/auxiliary/draw/draw_gs.c | 23 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 15 +++--- src/gallium/auxiliary/tgsi/tgsi_scan.c | 59 ++--

[Mesa-dev] [PATCH 04/13] tgsi: remove some not so useful variables from tgsi_shader_info

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 8 src/gallium/auxiliary/tgsi/tgsi_scan.h | 3 --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 4 +++- src/gallium/drivers/softpipe/sp_quad_blend.c | 5 ++--- src/gallium/drivers/softpipe/sp_setup.c |

[Mesa-dev] [PATCH 01/13] radeonsi: get tgsi_shader_info only once before compilation

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 25 +++-- src/gallium/drivers/radeonsi/si_shader.h | 2 ++ src/gallium/drivers/radeonsi/si_state.c | 10 +++--- 3 files changed, 16 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 07/13] radeonsi: move geometry shader properties from si_shader to si_shader_selector

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 24 ++-- src/gallium/drivers/radeonsi/si_shader.h | 10 +- src/gallium/drivers/radeonsi/si_state.c | 25 +++-- src/gallium/drivers/radeonsi/si_state_draw.c | 8

[Mesa-dev] [PATCH 12/13] radeonsi: pass the GS shader directly to si_generate_gs_copy_shader

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 286014c..4e8f80f 100644 --- a/src/gallium/drivers/radeonsi/si_shader

[Mesa-dev] [PATCH 10/13] radeonsi: make the vertex shader key smaller

2014-09-30 Thread Marek Olšák
From: Marek Olšák We only support 16 vertex attribs, not 32. --- src/gallium/drivers/radeonsi/si_shader.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/si_shader.h index d9a89e3..c0e5cf4 100644 --- a

[Mesa-dev] [PATCH 11/13] radeonsi: set LLVMByValAttribute for all descriptor arrays

2014-09-30 Thread Marek Olšák
From: Marek Olšák I hope this is correct. --- src/gallium/drivers/radeonsi/si_shader.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 69382bd..286014c 100644 --- a/s

[Mesa-dev] [PATCH 06/13] radeonsi: always compile shaders on demand

2014-09-30 Thread Marek Olšák
From: Marek Olšák The first compiled shader is sometimes useless, because the key doesn't match the key for the draw call where it's used. --- src/gallium/drivers/radeonsi/si_state.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 08/13] radeonsi: remove interp_at_sample from the key, use TGSI_INTERPOLATE_LOC_SAMPLE

2014-09-30 Thread Marek Olšák
From: Marek Olšák st/mesa has the same flag in its shader key, we don't need to do it in the driver anymore. Instead, use TGSI_INTERPOLATE_LOC_SAMPLE, which is what st/mesa sets. --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.h | 1 - src/gallium/d

[Mesa-dev] [PATCH 13/13] radeonsi: set number of userdata SGPRs of GS copy shader to 4

2014-09-30 Thread Marek Olšák
From: Marek Olšák It only needs the constant buffer with clip planes and read-write resources for the GS->VS ring and streamout. That's 2 pointers. --- src/gallium/drivers/radeonsi/si_shader.c | 9 - src/gallium/drivers/radeonsi/si_shader.h | 18 ++ src/gallium/d

[Mesa-dev] [PATCH 05/13] radeonsi: remove unused variable si_shader::gs_input_prim

2014-09-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 2 -- src/gallium/drivers/radeonsi/si_shader.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e76b969..c5f13be 100644 --- a/src/galliu

[Mesa-dev] [PATCH 09/13] radeonsi: don't flush shader caches when building PM4 shader states

2014-09-30 Thread Marek Olšák
From: Marek Olšák This is a wrong place to flush caches to say the least. I don't think we need to flush the instruction caches if we don't patch shaders with DMA. --- src/gallium/drivers/radeonsi/si_state_draw.c | 8 1 file changed, 8 deletions(-) diff --git a/src/gallium/drivers/rad

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #41 from Ernst Sjöstrand --- No longer crashes after applying the patch here! -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH] mesa: relax draw api validation on ES2

2014-09-30 Thread Tapani
On 09/30/2014 06:13 PM, Ian Romanick wrote: On 09/30/2014 12:28 AM, Tapani Pälli wrote: Patch fixes failing test in WebGL conformance test 'point-no-attributes' when running Chrome on OpenGL ES. (Shader program may draw points using constant data in shader.) No Piglit regressions. This sounds

Re: [Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-09-30 Thread Tom Stellard
On Tue, Sep 30, 2014 at 12:29:52PM -0400, Ilia Mirkin wrote: > Perhaps do the same thing as util_bitcount, i.e. > > #if defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 304) > return __builtin_popcountll(n); > #else > ... > #endif > > Perhaps the gcc version check is no longer necessary, unlikel

Re: [Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-09-30 Thread Ilia Mirkin
On Tue, Sep 30, 2014 at 1:14 PM, Tom Stellard wrote: > On Tue, Sep 30, 2014 at 12:29:52PM -0400, Ilia Mirkin wrote: >> Perhaps do the same thing as util_bitcount, i.e. >> >> #if defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 304) >> return __builtin_popcountll(n); >> #else >> ... >> #endif >> >

Re: [Mesa-dev] [PATCH] tgsi: fix Semantic.Name assignment in tgsi_transform_input_decl()

2014-09-30 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Tuesday, September 30, 2014 9:31 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] tgsi: fix Semantic.Name assignment in tgsi_transform_input_decl() Assign th

Re: [Mesa-dev] [PATCH] llvmpipe: move lp_jit_screen_init() call after allocation of screen object

2014-09-30 Thread Roland Scheidegger
Am 30.09.2014 15:16, schrieb Brian Paul: > The screen argument isn't actually used by lp_jit_screen_init() at this > time, but let's move the call so that we pass a valid pointer. > > v2: don't leak screen if lp_jit_screen_init() fails. > --- > src/gallium/drivers/llvmpipe/lp_screen.c |8

[Mesa-dev] [PATCH] i965/brw_reg: Make the accumulator register take an explicit width.

2014-09-30 Thread Jason Ekstrand
The big pile of patches I just pushed regresses about 25 piglit tests on SNB. This fixes the regressions. Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 12 src/mesa/drivers/dri/i965/brw_reg.h| 5 +++-- src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 2/2] galahad: fix indirect draw

2014-09-30 Thread sroland
From: Roland Scheidegger Need to unwrap the indirect resource otherwise bad things will happen. Fixes random crashes and timeouts with piglit's arb_indirect_draw tests. --- src/gallium/drivers/galahad/glhd_context.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a

[Mesa-dev] [PATCH 1/2] galahad: (trivial) handle cubemap arrays

2014-09-30 Thread sroland
From: Roland Scheidegger --- src/gallium/drivers/galahad/glhd_screen.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/galahad/glhd_screen.c b/src/gallium/drivers/galahad/glhd_screen.c index 5a91077..11ab1a9 100644 --- a/src/gallium/drivers/galahad/glhd_screen.c +

Re: [Mesa-dev] [PATCH] i965/brw_reg: Make the accumulator register take an explicit width.

2014-09-30 Thread Matt Turner
Assuming no regressions on other platforms: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V3 1/4] mesa: Add new variables in gl_context to store sample layout

2014-09-30 Thread Anuj Phogat
On Mon, Sep 29, 2014 at 7:16 PM, Jordan Justen wrote: > > On 2014-09-29 16:33:33, Anuj Phogat wrote: > > SampleMap{2,4,8}x variables are used in later patches to implement > > EXT_framebuffer_multisample_blit_scaled extension. > > > > V2: Use integer array instead of a string. > > Bump up the

Re: [Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 9:26 AM, Marek Olšák wrote: > From: Marek Olšák > > I'll need this in radeonsi. > --- > src/gallium/auxiliary/util/u_math.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > inde

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #42 from Benjamin Bellec --- (In reply to comment #40) > Created attachment 107124 [details] [review] > possible fix > > Could you please test this patch? Tested-by: Benjamin Bellec Your patch fixes the crash. Tested on Evergreen.

Re: [Mesa-dev] [RFC PATCH 05/56] mesa/main: Add tessellation shader state and limits

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 8:50 AM, Ian Romanick wrote: > On 09/20/2014 07:41 PM, Matt Turner wrote: >> On Sat, Sep 20, 2014 at 6:40 PM, Chris Forbes wrote: >>> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c >>> index 79d2e94..c11ad4f 100644 >>> --- a/src/mesa/main/shaderapi.c >>

Re: [Mesa-dev] [PATCH 2/2] i965: Use BDW_MOCS_PTE for renderbuffers.

2014-09-30 Thread Kenneth Graunke
On Tuesday, September 30, 2014 10:33:42 AM Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 01:15:56AM -0700, Kenneth Graunke wrote: > > Write-back caching cannot be used for buffers being scanned out by the > > display engine; surfaces used for scan-out must be write-through or > > uncached. I orig

Re: [Mesa-dev] SandyBridge's 'resinfo' -> returned value for SURFTYPE_BUFFER?

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 5:22 AM, Samuel Iglesias Gonsálvez wrote: > Hello, > > I am looking at bug 57439 [0] where it shows an error > in a piglit test [1] related to textureSize() function happening > in Intel SandyBridge hardware. > > According to SNB's PRM documentation (vol4 part1 page 141), t

[Mesa-dev] [PATCH V4 1/4] mesa: Add new variables in gl_context to store sample layout

2014-09-30 Thread Anuj Phogat
SampleMap{2,4,8}x variables are used in later patches to implement EXT_framebuffer_multisample_blit_scaled extension. V2: Use integer array instead of a string. Bump up the comment. V3: Use uint8_t type array. Signed-off-by: Anuj Phogat --- src/mesa/main/mtypes.h | 32 +

[Mesa-dev] [PATCH V4 2/4] i965: Initialize the SampleMap{2, 4, 8}x variables

2014-09-30 Thread Anuj Phogat
with values specific to Intel hardware. V2: Define and use gen6_get_sample_map() function to initialize the variables. V3: Change the function name to gen6_set_sample_maps() and use memcpy() to fill in the data. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH V4 3/4] meta: Implement ext_framebuffer_multisample_blit_scaled extension

2014-09-30 Thread Anuj Phogat
Extension enables doing a multisample buffer resolve and buffer scaling using a single glBlitFrameBuffer() call. Currently, we have this extension implemented in BLORP which is only used by SNB and IVB. This patch implements the extension in meta path which makes it available to Broadwell. Impleme

[Mesa-dev] [PATCH V4 4/4] i965: Enable EXT_framebuffer_multisample_blit_scaled for gen8

2014-09-30 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 046d2a1..10fe10e 100644 --- a/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH] gallivm: Disable gallivm to fix build with LLVM 3.6

2014-09-30 Thread Mathias Fröhlich
Jose, On Wednesday, September 24, 2014 12:42:24 Jose Fonseca wrote: > That said, the way we use these things are still a bit in flux. Mathias > has some pending patches. BTW, Mathis, should I submit your patches > for making llvmpipe thread safe? Mesa day for me. I did double check the mesa c

Re: [Mesa-dev] [PATCH 02/13] tgsi: simplify shader properties in tgsi_shader_info

2014-09-30 Thread Roland Scheidegger
Am 30.09.2014 18:46, schrieb Marek Olšák: > From: Marek Olšák > > Use an array of properties indexed by TGSI_PROPERTY_* definitions. > --- > src/gallium/auxiliary/draw/draw_gs.c | 23 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 15 +++--- > src/gallium/auxiliary/tg

Re: [Mesa-dev] [PATCH] gallivm: Disable gallivm to fix build with LLVM 3.6

2014-09-30 Thread Brian Paul
On 09/30/2014 01:00 PM, Mathias Fröhlich wrote: Jose, On Wednesday, September 24, 2014 12:42:24 Jose Fonseca wrote: That said, the way we use these things are still a bit in flux. Mathias has some pending patches. BTW, Mathis, should I submit your patches for making llvmpipe thread safe? Me

Re: [Mesa-dev] [PATCH] gallivm: Disable gallivm to fix build with LLVM 3.6

2014-09-30 Thread Brian Paul
On 09/30/2014 01:16 PM, Brian Paul wrote: On 09/30/2014 01:00 PM, Mathias Fröhlich wrote: Jose, On Wednesday, September 24, 2014 12:42:24 Jose Fonseca wrote: That said, the way we use these things are still a bit in flux. Mathias has some pending patches. BTW, Mathis, should I submit your p

Re: [Mesa-dev] [PATCH] gallivm: Disable gallivm to fix build with LLVM 3.6

2014-09-30 Thread Mathias Fröhlich
Hi, On Tuesday, September 30, 2014 13:17:31 Brian Paul wrote: > Same failure with LLVM 3.3.1 too. Ok, that's what I did not try. Sorry. I will try to followup immediately ... Greetings Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

Re: [Mesa-dev] [PATCH] gallivm: Disable gallivm to fix build with LLVM 3.6

2014-09-30 Thread Brian Paul
On 09/30/2014 01:26 PM, Mathias Fröhlich wrote: Hi, On Tuesday, September 30, 2014 13:17:31 Brian Paul wrote: Same failure with LLVM 3.3.1 too. Ok, that's what I did not try. Sorry. I will try to followup immediately ... Thanks, Mathias. But I'm about to post a patch that fixes things for

[Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Brian Paul
Move the USE_MCJIT / HAVE_AVX determination logic to lp_bld.h. If we don't have MCJIT define a dummy LLVMMCJITMemoryManagerRef type to avoid excessive #ifdef testing elsewhere. --- src/gallium/auxiliary/gallivm/lp_bld.h | 40 +++ src/gallium/auxiliary/gallivm/lp_bld

Re: [Mesa-dev] [PATCH 2/2] i965: Use BDW_MOCS_PTE for renderbuffers.

2014-09-30 Thread Kristian Høgsberg
On Tue, Sep 30, 2014 at 1:15 AM, Kenneth Graunke wrote: > Write-back caching cannot be used for buffers being scanned out by the > display engine; surfaces used for scan-out must be write-through or > uncached. I originally chose WT for render targets because it works in > all cases. However, we

Re: [Mesa-dev] [PATCH 02/13] tgsi: simplify shader properties in tgsi_shader_info

2014-09-30 Thread Marek Olšák
On Tue, Sep 30, 2014 at 9:04 PM, Roland Scheidegger wrote: > Am 30.09.2014 18:46, schrieb Marek Olšák: >> From: Marek Olšák >> >> Use an array of properties indexed by TGSI_PROPERTY_* definitions. >> --- >> src/gallium/auxiliary/draw/draw_gs.c | 23 - >> src/gallium/auxiliary

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Mathias Fröhlich
Hi Brian, On Tuesday, September 30, 2014 13:30:21 Brian Paul wrote: > Move the USE_MCJIT / HAVE_AVX determination logic to lp_bld.h. If we > don't have MCJIT define a dummy LLVMMCJITMemoryManagerRef type to avoid > excessive #ifdef testing elsewhere. [...] > @@ -219,7 +188,7 @@ gallivm_free_code

Re: [Mesa-dev] [PATCH 2/2] galahad: fix indirect draw

2014-09-30 Thread Jose Fonseca
Series looks good. Thanks for looking into this Roland. It looks nobody else is using galahad, nor looking at the warnings. I wonder if it makes sense to keep using/updating it. Jose From: srol...@vmware.com Sent: 30 September 2014 19:07 To: Jose Fonse

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Brian Paul
On 09/30/2014 02:40 PM, Mathias Fröhlich wrote: Hi Brian, On Tuesday, September 30, 2014 13:30:21 Brian Paul wrote: Move the USE_MCJIT / HAVE_AVX determination logic to lp_bld.h. If we don't have MCJIT define a dummy LLVMMCJITMemoryManagerRef type to avoid excessive #ifdef testing elsewhere.

Re: [Mesa-dev] [RFC PATCH 05/56] mesa/main: Add tessellation shader state and limits

2014-09-30 Thread Ian Romanick
On 09/30/2014 11:24 AM, Matt Turner wrote: > On Tue, Sep 30, 2014 at 8:50 AM, Ian Romanick wrote: >> On 09/20/2014 07:41 PM, Matt Turner wrote: >>> On Sat, Sep 20, 2014 at 6:40 PM, Chris Forbes wrote: diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 79d2e94..c11a

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Call opt_algebraic after opt_cse.

2014-09-30 Thread Anuj Phogat
On Sat, Sep 27, 2014 at 12:12 PM, Matt Turner wrote: > The next patch adds an algebraic optimization for the pattern > >sqrt a, b >rcp c, a > > and turns it into > >sqrt a, b >rsq c, b > > but many vertex shaders do > >a = sqrt(b); >var1 /= a; >var2 /= a; > > which ge

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Call opt_algebraic after opt_cse.

2014-09-30 Thread Ian Romanick
On 09/27/2014 12:12 PM, Matt Turner wrote: > The next patch adds an algebraic optimization for the pattern > >sqrt a, b >rcp c, a > > and turns it into > >sqrt a, b >rsq c, b > > but many vertex shaders do > >a = sqrt(b); >var1 /= a; >var2 /= a; > > which generat

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Call opt_algebraic after opt_cse.

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 2:10 PM, Ian Romanick wrote: > On 09/27/2014 12:12 PM, Matt Turner wrote: >> The next patch adds an algebraic optimization for the pattern >> >>sqrt a, b >>rcp c, a >> >> and turns it into >> >>sqrt a, b >>rsq c, b >> >> but many vertex shaders do >> >>

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Extend predicated break pass to predicate WHILE.

2014-09-30 Thread Matt Turner
On Mon, Sep 8, 2014 at 12:21 PM, Matt Turner wrote: > Helps a handful of programs in Serious Sam 3 that use do-while loops. > > instructions in affected programs: 16114 -> 16075 (-0.24%) > --- How about a review? ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH 4/6] i965/fs: Implement SIMD16 integer multiplies on Gen 7.

2014-09-30 Thread Ian Romanick
On 09/28/2014 01:26 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > index e

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Jose Fonseca
Brian, Your patch looks good AFAICT. Not sure why the crash, and I'm afraid I won't have time to look into it. I think it might help to '#define USE_MCJIT 1' for now, ie, enable MCJIT for all LLVM versions . We were avoiding it on old LLVM versions, but AFAICT there's no longer any reason to

Re: [Mesa-dev] [PATCH 0/6] i965/fs: ARB_gpu_shader5 operations SIMD16 support

2014-09-30 Thread Ian Romanick
The first 3 are Reviewed-by: Ian Romanick I sent a question on patch 4 that may affect it and the others. On 09/28/2014 01:26 PM, Matt Turner wrote: > [PATCH 1/6] i965/fs: Set MUL source type to W/UW in 64-bit mul macro > >Fixes 64-bit multiploes on Gen8. > > [PATCH 2/6] i965/fs: Don't of

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Call opt_algebraic after opt_cse.

2014-09-30 Thread Ian Romanick
On 09/30/2014 02:16 PM, Matt Turner wrote: > On Tue, Sep 30, 2014 at 2:10 PM, Ian Romanick wrote: >> On 09/27/2014 12:12 PM, Matt Turner wrote: >>> The next patch adds an algebraic optimization for the pattern >>> >>>sqrt a, b >>>rcp c, a >>> >>> and turns it into >>> >>>sqrt a, b >>>

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Extend predicated break pass to predicate WHILE.

2014-09-30 Thread Ian Romanick
On 09/25/2014 09:00 AM, Matt Turner wrote: > On Thu, Sep 25, 2014 at 8:25 AM, Ian Romanick wrote: >> How did you test this? Do we have piglit execution tests that actually >> hit this path? I'm assuming you didn't play Serious Sam 3 looking for >> rendering errors. ;) > > I wrote the patch and

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Mathias Fröhlich
Hi, On Tuesday, September 30, 2014 21:25:54 Jose Fonseca wrote: > Your patch looks good AFAICT. > > Not sure why the crash, and I'm afraid I won't have time to look into it. I am currently looking into that. > I think it might help to '#define USE_MCJIT 1' for now, ie, enable MCJIT for > all L

[Mesa-dev] [PATCH] util: add u_lowering

2014-09-30 Thread Rob Clark
From: Rob Clark TGSI->TGSI pass, extracted from freedreno. Currently provides the following lower support, to help drivers emulate unsupported opcodes or features: Individual opcodes: DST, XPD, SCS, LRP, FRC, POW, LIT, EXP, LOG, DP4, DP3, DPH, DP2, DP2A Also supported, although it is up to

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Brian Paul
On 09/30/2014 03:34 PM, Mathias Fröhlich wrote: Hi, On Tuesday, September 30, 2014 21:25:54 Jose Fonseca wrote: Your patch looks good AFAICT. Not sure why the crash, and I'm afraid I won't have time to look into it. I am currently looking into that. I think it might help to '#define USE_MC

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Mathias Fröhlich
Hi Brian, On Tuesday, September 30, 2014 15:42:21 Brian Paul wrote: > Yeah, reverting that patch clears up the regression here. Please go > ahead and do the revert if you don't think you can solve the problem > otherwise. Thanks! I could even reproduce the segfault with the previous patch an

Re: [Mesa-dev] [PATCH] util: add u_lowering

2014-09-30 Thread Brian Paul
On 09/30/2014 03:38 PM, Rob Clark wrote: From: Rob Clark TGSI->TGSI pass, extracted from freedreno. Currently provides the following lower support, to help drivers emulate unsupported opcodes or features: Individual opcodes: DST, XPD, SCS, LRP, FRC, POW, LIT, EXP, LOG, DP4, DP3, DPH, DP

Re: [Mesa-dev] [PATCH 4/6] i965/fs: Implement SIMD16 integer multiplies on Gen 7.

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 2:26 PM, Ian Romanick wrote: > Are there a bunch of cases where we double emit things for SIMD16? > Would it make more sense to have a generic function that took a list of > instructions, duplicated them, and did the force_uncompressed / > force_sechalf modification? Not m

Re: [Mesa-dev] [PATCH] util: add u_lowering

2014-09-30 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > TGSI->TGSI pass, extracted from freedreno. Currently provides the > following lower support, to help drivers emulate unsupported opcodes > or features: > > Individual opcodes: > DST, XPD, SCS, LRP, FRC, POW, LIT, EXP, LOG, DP4, DP3, DPH, > DP2, DP2A >

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Mathias Fröhlich
Brian, at least here, I get a build that runs glxgears which previously did not run with 3.3, 3.5. Currently the compile test runs with 3.6. If this succeeds, ok to push the attached fix (The same than before but with a more descriptive commit message)? Greetings Mathias>From 39a8625423f85327eef

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Brian Paul
On 09/30/2014 04:17 PM, Mathias Fröhlich wrote: Brian, at least here, I get a build that runs glxgears which previously did not run with 3.3, 3.5. Currently the compile test runs with 3.6. If this succeeds, ok to push the attached fix (The same than before but with a more descriptive commit mes

Re: [Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

2014-09-30 Thread Roland Scheidegger
Am 01.10.2014 00:17, schrieb Mathias Fröhlich: > > Brian, > > at least here, I get a build that runs glxgears which > previously did not run with 3.3, 3.5. > Currently the compile test runs with 3.6. > If this succeeds, ok to push the attached fix > (The same than before but with a more descripti

Re: [Mesa-dev] [PATCH] util: add u_lowering

2014-09-30 Thread Eric Anholt
Brian Paul writes: > On 09/30/2014 03:38 PM, Rob Clark wrote: >> From: Rob Clark >> >> TGSI->TGSI pass, extracted from freedreno. Currently provides the >> following lower support, to help drivers emulate unsupported opcodes >> or features: >> >> Individual opcodes: >>DST, XPD, SCS, LRP, FR

[Mesa-dev] [PATCH 1/3] gallium: Copy fd_lowering.[ch] to tgsi_lowering.[ch] for code sharing.

2014-09-30 Thread Eric Anholt
Lots of drivers need to transform the weird instructions in TGSI into reasonable scalar ops, and this code can make those translations canonical. --- src/gallium/auxiliary/tgsi/tgsi_lowering.c | 1573 src/gallium/auxiliary/tgsi/tgsi_lowering.h | 89 ++ 2 files change

[Mesa-dev] [PATCH 3/3] gallium: Rename freedreno parts of tgsi_lowering.[ch].

2014-09-30 Thread Eric Anholt
--- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/tgsi/tgsi_lowering.c | 50 +++--- src/gallium/auxiliary/tgsi/tgsi_lowering.h | 12 +++ 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/src/gallium/auxiliary/Makefile.sources b

  1   2   >