Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-30 Thread Marek Olšák
On Thu, Aug 28, 2014 at 12:07 AM, Ian Romanick wrote: > On 08/27/2014 02:55 PM, Marek Olšák wrote: >> Our plan is to always require the latest released version of LLVM >> because of new features in our LLVM backend that the radeonsi driver >> depends on to advertise all GL features. Some new featu

Re: [Mesa-dev] [PATCH] i965: Add 2x MSAA support to Broadwell fast clear code.

2014-08-30 Thread Matt Turner
On Fri, Aug 29, 2014 at 11:58 PM, Kenneth Graunke wrote: > According to the cited documentation section (but in the newer docs), > x_scaledown is the same for 2x and 4x MSAA. > > +47 piglits. That's why you run piglit against Mesa with assertions enabled... Reviewed-by: Matt Turner

[Mesa-dev] [PATCH] i965: Use unreachable() to silence warning.

2014-08-30 Thread Matt Turner
brw_meta_fast_clear.c:211:17: warning: 'x_scaledown' may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned int x_scaledown, y_scaledown; --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/driv

[Mesa-dev] [PATCH] st/xvmc/tests: avoid non portable error.h functions

2014-08-30 Thread Jonathan Gray
Signed-off-by: Jonathan Gray --- src/gallium/state_trackers/xvmc/tests/test_blocks.c | 6 -- src/gallium/state_trackers/xvmc/tests/test_context.c| 6 -- src/gallium/state_trackers/xvmc/tests/test_rendering.c | 13 - src/gallium/state_trackers/xvmc/tests/test_subpict

Re: [Mesa-dev] [PATCH] st/xvmc/tests: avoid non portable error.h functions

2014-08-30 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Aug 30, 2014 at 1:43 PM, Jonathan Gray wrote: > Signed-off-by: Jonathan Gray > --- > src/gallium/state_trackers/xvmc/tests/test_blocks.c | 6 -- > src/gallium/state_trackers/xvmc/tests/test_context.c| 6 -- > src/gallium/state_trackers/xvmc/te

[Mesa-dev] [PATCH] Fix assertion which fails for unsigned array indices.

2014-08-30 Thread tiffany
According to the GLSL 1.40 spec, section 5.7 Structure and Array Operations: "Array elements are accessed using an expression whose type is int or uint." --- src/glsl/lower_variable_index_to_cond_assign.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/lower_variabl

Re: [Mesa-dev] [PATCH 27/27] gallium/vc4: ship all files in the tarball

2014-08-30 Thread Eric Anholt
Emil Velikov writes: > - include all headers in Makefile.sources Reviewed-by: Eric Anholt pgpKjm_01xwry.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Use unreachable() to silence warning.

2014-08-30 Thread Kenneth Graunke
On Saturday, August 30, 2014 09:43:07 AM Matt Turner wrote: > brw_meta_fast_clear.c:211:17: warning: 'x_scaledown' may be used > uninitialized in this function [-Wmaybe-uninitialized] > unsigned int x_scaledown, y_scaledown; > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 +-- > 1

Re: [Mesa-dev] [PATCH 03/14] i965/compaction: Rework 3-src compaction logic.

2014-08-30 Thread Kenneth Graunke
On Thursday, August 28, 2014 08:10:33 PM Matt Turner wrote: > It may be possible to create a contrived example in which a 3-src > instruction would have been compacted on Gen < 8. I'd rather not > discover it in the wild. > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 14 +- > 1

Re: [Mesa-dev] [PATCH 05/14] i965/compaction: Make src_offset local to the for loop.

2014-08-30 Thread Kenneth Graunke
On Thursday, August 28, 2014 08:10:35 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > i

[Mesa-dev] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Ilia Mirkin
Samplers are only defined up to num_samplers, so set all samplers above nr to NULL so that we don't try to read them again later. Tested-by: Christian Ruppert Signed-off-by: Ilia Mirkin Cc: "10.2 10.3" --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 7 +-- 1 file changed, 5 insertions(

[Mesa-dev] [PATCH 1/2] nvc0/ir: avoid infinite recursion when finding first uses of tex

2014-08-30 Thread Ilia Mirkin
In certain circumstances, findFirstUses could end up doubling back on instructions it had already processed, resulting in an infinite recursion. Avoid this by keeping track of already-visited instructions. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83079 Tested-by: Tobias Klausmann Si

Re: [Mesa-dev] [PATCH 05/14] i965/compaction: Make src_offset local to the for loop.

2014-08-30 Thread Matt Turner
On Sat, Aug 30, 2014 at 2:43 PM, Kenneth Graunke wrote: > On Thursday, August 28, 2014 08:10:35 PM Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_eu_compact.c | 17 +++-- >> 1 file changed, 7 insertions(+), 10 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_e

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Emil Velikov
On 30/08/14 23:02, Ilia Mirkin wrote: > Samplers are only defined up to num_samplers, so set all samplers above > nr to NULL so that we don't try to read them again later. > Would it be worth doing a similar thing with the unlocked samplers below the nr mark ? It seems to me that we might be leaki

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Ilia Mirkin
On Sat, Aug 30, 2014 at 7:30 PM, Emil Velikov wrote: > On 30/08/14 23:02, Ilia Mirkin wrote: >> Samplers are only defined up to num_samplers, so set all samplers above >> nr to NULL so that we don't try to read them again later. >> > Would it be worth doing a similar thing with the unlocked sample

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Emil Velikov
On 31/08/14 00:34, Ilia Mirkin wrote: > On Sat, Aug 30, 2014 at 7:30 PM, Emil Velikov > wrote: >> On 30/08/14 23:02, Ilia Mirkin wrote: >>> Samplers are only defined up to num_samplers, so set all samplers above >>> nr to NULL so that we don't try to read them again later. >>> >> Would it be wort

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Emil Velikov
On 31/08/14 00:34, Ilia Mirkin wrote: > On Sat, Aug 30, 2014 at 7:30 PM, Emil Velikov > wrote: >> On 30/08/14 23:02, Ilia Mirkin wrote: >>> Samplers are only defined up to num_samplers, so set all samplers above >>> nr to NULL so that we don't try to read them again later. >>> >> Would it be wort

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] nv50: zero out unbound samplers

2014-08-30 Thread Ilia Mirkin
On Sat, Aug 30, 2014 at 8:09 PM, Emil Velikov wrote: > On 31/08/14 00:34, Ilia Mirkin wrote: >> On Sat, Aug 30, 2014 at 7:30 PM, Emil Velikov >> wrote: >>> On 30/08/14 23:02, Ilia Mirkin wrote: Samplers are only defined up to num_samplers, so set all samplers above nr to NULL so that w

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/4] i965: Fix GPU hangs when INTEL_DEBUG=no16 is set.

2014-08-30 Thread Matt Turner
On Fri, Aug 29, 2014 at 11:10 PM, Kenneth Graunke wrote: > The replicated data clear shader needs to be SIMD16, or else the GPU > will hang. So, compile it even if INTEL_DEBUG=no16 is set. Oh, great. I wasted a bunch of time wondering wtf was causing my GPU to hang. Reviewed-by: Matt Turner __