Re: [Mesa-dev] [PATCH 18/20] i965/fs: Preserve CFG in the SEL peephole.

2014-08-19 Thread Pohjolainen, Topi
On Mon, Aug 18, 2014 at 10:42:26AM -0700, Matt Turner wrote: > On Mon, Aug 18, 2014 at 8:34 AM, Pohjolainen, Topi > wrote: > > On Thu, Jul 24, 2014 at 07:54:25PM -0700, Matt Turner wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp | 15 +-- > >> 1 file changed, 9

Re: [Mesa-dev] [PATCHv2 03/13] glsl: initialize locale_t with a static object

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 3:00 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> The compiler may be used by multiple contexts simultaneously and needs to be >> thread-safe. >> >> Signed-off-by: Chia-I Wu >> --- >> src/glsl/strtod.cpp | 29 +++-- >> 1 fi

Re: [Mesa-dev] [PATCHv2 04/13] glsl: protect anonymous struct id with a mutex

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 3:03 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> There may be two contexts compiling shaders at the same time, and we want the >> anonymous struct id to be globally unique. >> >> Signed-off-by: Chia-I Wu >> --- >> src/glsl/glsl_parser_extras.cpp

Re: [Mesa-dev] [PATCHv2 08/13] mesa: add infrastructure for threaded shader compilation

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 4:35 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and >> add ctx->Const.DeferCompileShader and ctx->Const.DeferLinkProgram to >> fine-control what gets threaded. >> >> Setting

Re: [Mesa-dev] [PATCHv2 08/13] mesa: add infrastructure for threaded shader compilation

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 4:41 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> @@ -3489,6 +3508,18 @@ struct gl_constants >> GLfloat MaxFragmentInterpolationOffset; >> >> GLboolean FakeSWMSAA; >> + >> + /* >> +* Defer certain operations to a thread pool. >> +*

Re: [Mesa-dev] [PATCHv2 13/13] i965: enable threaded precompile

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 4:44 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> Inherit gl_shader_program and add save/restore functions to save precompile >> results in the shader programs. When DeferLinkProgram is set, we will save >> the precompile results instead of uploadi

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: > This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in > an ELSE/ENDIF sequence. > > In the typical case (where IF and ENDIF) aren't the only instructions in > their basic blocks, we can simply remove the instructions

Re: [Mesa-dev] [PATCHv2 06/13] glsl: add a generic thread pool data structure

2014-08-19 Thread Chia-I Wu
On Thu, Aug 14, 2014 at 8:38 AM, Ian Romanick wrote: > On 07/09/2014 12:47 AM, Chia-I Wu wrote: >> It can be used to implement, for example, threaded glCompileShader and >> glLinkProgram. >> >> v2: allow tasks to "complete" other tasks >> >> Signed-off-by: Chia-I Wu >> --- >> src/glsl/Makefile.a

Re: [Mesa-dev] [PATCH 16/20] i965/cfg: Add functions to combine basic blocks.

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:23PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_cfg.cpp | 59 > +++ > src/mesa/drivers/dri/i965/brw_cfg.h | 2 ++ > 2 files changed, 61 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp > b/

Re: [Mesa-dev] [PATCHv2 01/13] mesa: protect the debug state with a mutex

2014-08-19 Thread Chia-I Wu
Hi Ian, Thanks for the reviews. On Thu, Aug 14, 2014 at 8:45 AM, Ian Romanick wrote: > Patches 7, 8, and 9 are > > Reviewed-by: Ian Romanick > > I made a few minor comments on 7, but they should be trivial to resolve. > > Patches 10 through 13 are > > Acked-by: Ian Romanick > > I'd like to see

Re: [Mesa-dev] [PATCH 19/20] i965/fs: Rename variable in predicated break pass.

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:26PM -0700, Matt Turner wrote: > --- > .../drivers/dri/i965/brw_fs_peephole_predicated_break.cpp | 15 > --- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_peephole_pre

Re: [Mesa-dev] [PATCH 18/20] i965/fs: Preserve CFG in the SEL peephole.

2014-08-19 Thread Pohjolainen, Topi
On Tue, Aug 19, 2014 at 10:19:42AM +0300, Pohjolainen, Topi wrote: > On Mon, Aug 18, 2014 at 10:42:26AM -0700, Matt Turner wrote: > > On Mon, Aug 18, 2014 at 8:34 AM, Pohjolainen, Topi > > wrote: > > > On Thu, Jul 24, 2014 at 07:54:25PM -0700, Matt Turner wrote: > > >> --- > > >> src/mesa/drivers

Re: [Mesa-dev] [PATCH 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Chia-I Wu
On Tue, Aug 19, 2014 at 7:20 AM, Emil Velikov wrote: > Make the header location, inclusion and contents more common with > its i915,r* and nouveau counterparts: > > - Move the header within intel/drm. > - Separate out intel_winsys_create_for_fd into 'drm_public' header. > - Cleanup the compiler

Re: [Mesa-dev] [PATCH 13/19] gallium/ilo: handle query_renderer caps

2014-08-19 Thread Chia-I Wu
On Fri, Aug 15, 2014 at 6:18 AM, Emil Velikov wrote: > Implementation based on the classic driver with the following > changes: > - Use auxiliarry function os_get_total_physical_memory to get the > total amount of memory. > - Move the libdrm_intel specific get_aperture_size to the winsys. Please

Re: [Mesa-dev] [PATCH 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Emil Velikov
On 19/08/14 09:07, Chia-I Wu wrote: > On Tue, Aug 19, 2014 at 7:20 AM, Emil Velikov > wrote: >> Make the header location, inclusion and contents more common with >> its i915,r* and nouveau counterparts: >> >> - Move the header within intel/drm. >> - Separate out intel_winsys_create_for_fd into

Re: [Mesa-dev] [PATCH 15/20] i965/cfg: Point to bblock_t containing associated control flow

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:22PM -0700, Matt Turner wrote: > ... rather than pointing directly to the associated instruction. This > will let us set the block containing the IF statement's else-pointer to > NULL, when we delete a useless ELSE instruction, as in the case > >(+f0) if(8) >.

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #29 from Michel Dänzer --- (In reply to comment #28) > Program received signal SIGSEGV, Segmentation fault. > 0x7fffe09f1d89 in ?? () Since this is not 0x, this looks like a different crash, or maybe still just no

Re: [Mesa-dev] [PATCH 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Chia-I Wu
On Tue, Aug 19, 2014 at 4:26 PM, Emil Velikov wrote: > On 19/08/14 09:07, Chia-I Wu wrote: >> On Tue, Aug 19, 2014 at 7:20 AM, Emil Velikov >> wrote: >>> Make the header location, inclusion and contents more common with >>> its i915,r* and nouveau counterparts: >>> >>> - Move the header within

Re: [Mesa-dev] [PATCH 20/20] i965/fs: Preserve CFG in predicated break pass.

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:27PM -0700, Matt Turner wrote: > Operating on this code, > > B0: ... > cmp.ne.f0(8) > (+f0) if(8) > B1: break(8) > B2: endif(8) > > We can delete B2 without attempting to merge any blocks, since the > break/continue instruction necessarily ends the previous b

Re: [Mesa-dev] [PATCH 16/22] st/vdpau: remove obsolete define VL_HANDLES

2014-08-19 Thread Christian König
Am 19.08.2014 um 01:20 schrieb Emil Velikov: This define is always set and it had no real purpose according to git log. Seems like it is a leftover from the vl/vdpau prototype stage. Cc: Christian König Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/state_track

[Mesa-dev] [Bug 76188] EGL_EXT_image_dma_buf_import fd ownership is incorrect

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76188 Topi Pohjolainen changed: What|Removed |Added CC||i...@freedesktop.org --- Comment #6 f

Re: [Mesa-dev] [PATCH 17/22] st/vdpau: pickup/ship the private header

2014-08-19 Thread Christian König
Am 19.08.2014 um 01:20 schrieb Emil Velikov: Signed-off-by: Emil Velikov Is it necessary to sort the files by name? They where more or less sorted by importance and time of creation in the VDPAU interface. Christian. --- src/gallium/state_trackers/vdpau/Makefile.sources | 17 +--

Re: [Mesa-dev] [PATCH 18/22] st/omx: use makefile.sources to handle sources lists

2014-08-19 Thread Christian König
Am 19.08.2014 um 01:20 schrieb Emil Velikov: ... and add the headers so that 'make check' is happy. Cc: Christian König Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/state_trackers/omx/Makefile.am | 8 ++-- src/gallium/state_trackers/omx/Makefile.sou

[Mesa-dev] [PATCH] ilo: fold drm_intel_get_aperture_sizes() within probe_winsys()

2014-08-19 Thread Emil Velikov
... and store the value in intel_winsys_info/ilo_dev_info. Suggested-by: Chia-I Wu Signed-off-by: Emil Velikov --- Hello Chia-I Hope I've understood you correctly this time :) -Emil src/gallium/drivers/ilo/ilo_common.h| 1 + src/gallium/drivers/ilo/ilo_screen.c| 4 +

Re: [Mesa-dev] [PATCH 17/22] st/vdpau: pickup/ship the private header

2014-08-19 Thread Emil Velikov
On 19/08/14 09:59, Christian König wrote: > Am 19.08.2014 um 01:20 schrieb Emil Velikov: >> Signed-off-by: Emil Velikov > > Is it necessary to sort the files by name? They where more or less sorted by > importance and time of creation in the VDPAU interface. > Not necessary but it eases things g

Re: [Mesa-dev] [PATCH 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Emil Velikov
On 19/08/14 09:39, Chia-I Wu wrote: > On Tue, Aug 19, 2014 at 4:26 PM, Emil Velikov > wrote: >> On 19/08/14 09:07, Chia-I Wu wrote: >>> On Tue, Aug 19, 2014 at 7:20 AM, Emil Velikov >>> wrote: Make the header location, inclusion and contents more common with its i915,r* and nouveau co

Re: [Mesa-dev] [PATCH] ilo: fold drm_intel_get_aperture_sizes() within probe_winsys()

2014-08-19 Thread Chia-I Wu
On Tue, Aug 19, 2014 at 5:02 PM, Emil Velikov wrote: > ... and store the value in intel_winsys_info/ilo_dev_info. One nitpick: use size_t and report in bytes. I will make the change and commit. Thanks. I wasn't aware the patch has gone in (kind of catching up mails today). > > Suggested-by:

[Mesa-dev] [PATCHv2 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Emil Velikov
Make the header location, inclusion and contents more common with its i915,r* and nouveau counterparts: - Move the header within drivers/ilo. - Separate out intel_winsys_create_for_fd into 'drm_public' header. - Cleanup the compiler includes. v2: Move the header to drivers/ilo. Suggested by Ch

Re: [Mesa-dev] [PATCHv2 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Chia-I Wu
On Tue, Aug 19, 2014 at 5:32 PM, Emil Velikov wrote: > Make the header location, inclusion and contents more common with > its i915,r* and nouveau counterparts: > > - Move the header within drivers/ilo. > - Separate out intel_winsys_create_for_fd into 'drm_public' header. > - Cleanup the compil

Re: [Mesa-dev] [PATCH] gallium/radeon: Do not use u_upload_mgr for buffer downloads

2014-08-19 Thread Marek Olšák
I'll push this, but I need to test piglit first. Marek On Tue, Aug 19, 2014 at 5:03 AM, Michel Dänzer wrote: > On 15.08.2014 03:22, Niels Ole Salscheider wrote: >> Instead create a staging texture with pipe_buffer_create and >> PIPE_USAGE_STAGING. >> >> u_upload_mgr sets the usage of its staging

Re: [Mesa-dev] [PATCHv2 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-19 Thread Emil Velikov
On 19/08/14 10:40, Chia-I Wu wrote: > On Tue, Aug 19, 2014 at 5:32 PM, Emil Velikov > wrote: >> Make the header location, inclusion and contents more common with >> its i915,r* and nouveau counterparts: >> >> - Move the header within drivers/ilo. >> - Separate out intel_winsys_create_for_fd int

Re: [Mesa-dev] [PATCH 17/22] st/vdpau: pickup/ship the private header

2014-08-19 Thread Christian König
Am 19.08.2014 um 11:09 schrieb Emil Velikov: On 19/08/14 09:59, Christian König wrote: Am 19.08.2014 um 01:20 schrieb Emil Velikov: Signed-off-by: Emil Velikov Is it necessary to sort the files by name? They where more or less sorted by importance and time of creation in the VDPAU interface.

[Mesa-dev] [Bug 36083] Feature wish: EXT_gpu_shader4

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36083 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 3/3] docs: Mark off ARB_conditional_render_inverted for i965

2014-08-19 Thread Chris Forbes
Signed-off-by: Chris Forbes --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5549b30..76412c3 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -186,7 +186,7 @@ GL 4.5, GLSL 4.50:

[Mesa-dev] [PATCH 1/3] mesa: Add support for inverted s/w conditional rendering

2014-08-19 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/condrender.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 54cd423..75f9d74 100644 --- a/src/mesa/main/condrender.c +++ b/src/mesa/main/condrender.c @@ -162,12 +162,25

[Mesa-dev] [PATCH 2/3] i965: Enable ARB_conditional_render_inverted on Gen6+.

2014-08-19 Thread Chris Forbes
The extension requires GL 3.0, so enable on just the generations exposing that. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensi

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Francisco Jerez
Connor Abbott writes: > I know what you might be thinking right now. "Wait, *another* IR? Don't > we already have like 5 of those, not counting all the driver-specific > ones? Isn't this stuff complicated enough already?" Well, there are some > pretty good reasons to start afresh (again...). In t

Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

2014-08-19 Thread Olivier Galibert
Hi, That patch makes glDrawBuffer(0, NULL); segfault because _mesa_drawbuffers expects buffers[0] to be valid. Note that the bug is there, but I'm not sure what the final setup should look like in that case. Best, OG. PS: reported by haagch on irc On Fri, Aug 8, 2014 at 11:20 PM, Brian P

[Mesa-dev] [PATCH 3/3] gallium/target: Add needed mesautil lib to haiku-softpipe

2014-08-19 Thread Alexander von Gluck IV
--- src/gallium/targets/haiku-softpipe/SConscript |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/gallium/targets/haiku-softpipe/SConscript b/src/gallium/targets/haiku-softpipe/SConscript index 0381d05..c730fde 100644 --- a/src/gallium/targets/haiku-softpipe/SConscrip

[Mesa-dev] [PATCH 1/3] haiku/swrast: Add missing src include search path for missing util/macros.h

2014-08-19 Thread Alexander von Gluck IV
--- src/mesa/drivers/haiku/swrast/SConscript |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/haiku/swrast/SConscript b/src/mesa/drivers/haiku/swrast/SConscript index aef7300..2c25f72 100644 --- a/src/mesa/drivers/haiku/swrast/SConscript +++ b/src/mesa/dri

[Mesa-dev] [PATCH 2/3] gallium/aux: Fill in Haiku get process name code

2014-08-19 Thread Alexander von Gluck IV
--- src/gallium/auxiliary/os/os_process.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/os/os_process.c b/src/gallium/auxiliary/os/os_process.c index 3e060b9..a626228 100644 --- a/src/gallium/auxiliary/os/os_process.c +++ b/src/gallium/auxili

[Mesa-dev] [Bug 82814] New: glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82814 Priority: medium Bug ID: 82814 Assignee: mesa-dev@lists.freedesktop.org Summary: glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers Severity: normal Classification: Unclassified

[Mesa-dev] [Bug 82814] glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82814 --- Comment #1 from Ilia Mirkin --- FWIW I'm fairly sure that it's actually commit 39b40ad144f5f587e505b45048e33a03641ba857 Author: Brian Paul Date: Fri Aug 8 15:01:50 2014 -0600 mesa: fix assertion in _mesa_drawbuffers() Fixes faile

Re: [Mesa-dev] [PATCH 1/3] haiku/swrast: Add missing src include search path for missing util/macros.h

2014-08-19 Thread Brian Paul
On 08/19/2014 07:23 AM, Alexander von Gluck IV wrote: --- src/mesa/drivers/haiku/swrast/SConscript |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/haiku/swrast/SConscript b/src/mesa/drivers/haiku/swrast/SConscript index aef7300..2c25f72 100644 --- a/s

[Mesa-dev] [PATCH] mesa: fix NULL pointer deref bug in _mesa_drawbuffers()

2014-08-19 Thread Brian Paul
This is a follow-on fix to commit 39b40ad144. Fixes a crash if the user calls glDrawBuffers(0, NULL). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82814 Cc: "10.2" --- src/mesa/main/buffers.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/buffers.

[Mesa-dev] [Bug 82814] glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82814 --- Comment #2 from Brian Paul --- Patch posted to mesa-dev. Thanks for finding/reporting this. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mes

Re: [Mesa-dev] [PATCH 2/3] mesa: Use a recursive mutex for the texture lock.

2014-08-19 Thread Dave Airlie
> This avoids problems with things like meta operations calling functions > that want to take the lock while the lock is already held. Basically, > the point is to guard against API reentrancy across threads...not to > guard against ourselves. I hate this on purely the grounds that I feel someone

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Jose Fonseca
On 18/08/14 17:25, Connor Abbott wrote: On Mon, Aug 18, 2014 at 11:47 AM, Jose Fonseca wrote: On 18/08/14 14:21, Marek Olšák wrote: On Mon, Aug 18, 2014 at 2:44 PM, Roland Scheidegger wrote: Am 16.08.2014 02:12, schrieb Connor Abbott: I know what you might be thinking right now. "Wait, *

Re: [Mesa-dev] [PATCH 19/22] st/xlib: Include the headers in the sources list.

2014-08-19 Thread Jose Fonseca
On 19/08/14 00:20, Emil Velikov wrote: Yet another step towards a working 'make dist'. Cc: José Fonseca Signed-off-by: Emil Velikov --- src/gallium/state_trackers/glx/xlib/Makefile.sources | 5 - src/gallium/state_trackers/glx/xlib/SConscript | 1 - 2 files changed, 4 insertions(

Re: [Mesa-dev] [PATCH v4 1/6] mesa: add ARB_conditional_render_inverted flags

2014-08-19 Thread Ilia Mirkin
On Mon, Aug 18, 2014 at 7:56 PM, Roland Scheidegger wrote: > Series looks good to me too, just one minor nitpick below, otherwise > 1-4, and 6 are > Reviewed-by: Roland Scheidegger Thanks Roland. I've pushed these out, with ChrisF's r-b on 1 as well. (And an additional patch to glapi... oops.)

Re: [Mesa-dev] [PATCH 1/3] mesa: Add support for inverted s/w conditional rendering

2014-08-19 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin On Tue, Aug 19, 2014 at 7:40 AM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/condrender.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c > index 54cd

Re: [Mesa-dev] [PATCH] mesa: fix NULL pointer deref bug in _mesa_drawbuffers()

2014-08-19 Thread Roland Scheidegger
Am 19.08.2014 15:53, schrieb Brian Paul: > This is a follow-on fix to commit 39b40ad144. Fixes a crash if the > user calls glDrawBuffers(0, NULL). > > Bugzilla: > https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D82814&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Connor Abbott
On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer wrote: > On 19.08.2014 01:28, Connor Abbott wrote: >> On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer wrote: >>> On 16.08.2014 09:12, Connor Abbott wrote: I know what you might be thinking right now. "Wait, *another* IR? Don't we already hav

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Connor Abbott
On Mon, Aug 18, 2014 at 1:38 PM, Roland Scheidegger wrote: > Am 18.08.2014 19:05, schrieb Connor Abbott: >> On Mon, Aug 18, 2014 at 12:38 PM, Ilia Mirkin wrote: >>> On Mon, Aug 18, 2014 at 12:25 PM, Connor Abbott wrote: On Mon, Aug 18, 2014 at 11:47 AM, Jose Fonseca wrote: > On 18/08/1

[Mesa-dev] [Bug 82814] glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82814 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Optimize conditional discards.

2014-08-19 Thread Henri Verbeet
On 19 August 2014 02:50, Kenneth Graunke wrote: > +/* Returns a conditional modifier that negates the condition. */ > +enum brw_conditional_mod > +brw_negate_cmod(uint32_t cmod) > +{ > + switch (cmod) { > + case BRW_CONDITIONAL_Z: > + return BRW_CONDITIONAL_NZ; > + case BRW_CONDITIONAL_

[Mesa-dev] [Bug 82668] Can't set int attributes to certain values on 32-bit

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82668 --- Comment #3 from Jason Ekstrand --- I took a brief look at this. It doesn't look too hard to chane. We just need to update the code in mesa/vbo to do integer copies instead of float copies. Maybe we should change the pointer type while we'r

Re: [Mesa-dev] [PATCH 07/11] glsl: add double support

2014-08-19 Thread Pohjolainen, Topi
On Thu, Aug 14, 2014 at 08:52:38PM +1000, Dave Airlie wrote: > This adds the guts of the fp64 implementation to the GLSL compiler. > > - builtin double types > - double constant support > - lexer parsing for double types (lf, LF) > - enforcing flat on double fs inputs > - double operations (d2f,f2

[Mesa-dev] [Bug 36083] Feature wish: EXT_gpu_shader4

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36083 --- Comment #7 from Matt Turner --- Well, neither EXT_gpu_shader4 nor GL_EXT_geometry_shader4 exist, but GL 3.2 has the features he mentions. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] r300g: Fix path to test programs for out-of-tree builds

2014-08-19 Thread Tom Stellard
On Tue, Aug 19, 2014 at 11:17:49AM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes make check in that case. > Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/r300/Makefile.am | 1 + > src/gallium/drivers/r300/compiler/tests

Re: [Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-08-19 Thread Anuj Phogat
On Wed, Jul 30, 2014 at 4:09 PM, Carl Worth wrote: > Ian Romanick writes: >> Anuj: Can you verify this does not regress proxy_textures_invalid_size? > ... >> Cc: "10.2" > > Iana (or Anuj), is there an outstanding question of a regression here > that should still be answered before this patch is

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Tom Stellard
On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: > On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer wrote: > > On 19.08.2014 01:28, Connor Abbott wrote: > >> On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer wrote: > >>> On 16.08.2014 09:12, Connor Abbott wrote: > I know what you mi

Re: [Mesa-dev] [PATCH 16/20] i965/cfg: Add functions to combine basic blocks.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:53 AM, Pohjolainen, Topi wrote: > On Thu, Jul 24, 2014 at 07:54:23PM -0700, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_cfg.cpp | 59 >> +++ >> src/mesa/drivers/dri/i965/brw_cfg.h | 2 ++ >> 2 files changed, 61 insertio

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Francisco Jerez
Tom Stellard writes: > On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: >> On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer wrote: >> > On 19.08.2014 01:28, Connor Abbott wrote: >> >> On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer wrote: >> >>> On 16.08.2014 09:12, Connor Abbott wro

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:49 AM, Pohjolainen, Topi wrote: > On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: >> This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in >> an ELSE/ENDIF sequence. >> >> In the typical case (where IF and ENDIF) aren't the only instruction

Re: [Mesa-dev] [PATCH 2/3] mesa: Use a recursive mutex for the texture lock.

2014-08-19 Thread Kristian Høgsberg
On Tue, Aug 19, 2014 at 7:03 AM, Dave Airlie wrote: >> This avoids problems with things like meta operations calling functions >> that want to take the lock while the lock is already held. Basically, >> the point is to guard against API reentrancy across threads...not to >> guard against ourselve

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Optimize conditional discards.

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:50 PM, Kenneth Graunke wrote: > Almost all uses of discard in GLSL take the form: > > if (some_condition) > discard; > > This generates the following assembly: > > cmp.condition.f0.0 src0 src1 /* generate some condition */ > IF >(+f0.1) cmp.ne.

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Pohjolainen, Topi
On Tue, Aug 19, 2014 at 12:03:01PM -0700, Matt Turner wrote: > On Tue, Aug 19, 2014 at 12:49 AM, Pohjolainen, Topi > wrote: > > On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: > >> This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in > >> an ELSE/ENDIF sequence. > >

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Connor Abbott
On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez wrote: > Tom Stellard writes: > >> On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: >>> On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer wrote: >>> > On 19.08.2014 01:28, Connor Abbott wrote: >>> >> On Mon, Aug 18, 2014 at 4:32 AM, Mi

[Mesa-dev] [PATCH 2/2] pipe-loader: Fix memory leak

2014-08-19 Thread Tom Stellard
CC: "10.2" --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c index 1bbaf19..88056f5 100644 --- a/src/gallium/auxilia

[Mesa-dev] [PATCH 1/2] loader: loader_get_driver_for_fd() return value needs to be freed by caller

2014-08-19 Thread Tom Stellard
--- src/loader/loader.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/loader/loader.h b/src/loader/loader.h index fa57950..d58aaab 100644 --- a/src/loader/loader.h +++ b/src/loader/loader.h @@ -35,6 +35,9 @@ int loader_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id); +/**

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:36 PM, Pohjolainen, Topi wrote: > Oh, so sorry Matt, I somehow forgot to send my r-b, they are just fine. No problem at all. Thanks a ton for reviewing these. I know they've been a lot of work to get through. ___ mesa-dev mail

Re: [Mesa-dev] [PATCH 20/20] i965/fs: Preserve CFG in predicated break pass.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 1:52 AM, Pohjolainen, Topi wrote: > On Thu, Jul 24, 2014 at 07:54:27PM -0700, Matt Turner wrote: >> Operating on this code, >> >> B0: ... >> cmp.ne.f0(8) >> (+f0) if(8) >> B1: break(8) >> B2: endif(8) >> >> We can delete B2 without attempting to merge any blocks, si

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #30 from Eugene --- (In reply to comment #29) > (In reply to comment #28) > > Program received signal SIGSEGV, Segmentation fault. > > 0x7fffe09f1d89 in ?? () > > Since this is not 0x, this looks like a different

[Mesa-dev] Mesa 10.2.6

2014-08-19 Thread Carl Worth
Mesa 10.2.6 has been released. Mesa 10.2.6 is a bug fix release fixing bugs since the 10.2.5 release, (see below for a list of changes). The tag in the git repository for Mesa 10.2.6 is 'mesa-10.2.6'. Mesa 10.2.6 is available for download at ftp://freedesktop.org/pub/mesa/10.2.6/ SHA-256 checksu

Re: [Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-08-19 Thread Carl Worth
Anuj Phogat writes: > On Wed, Jul 30, 2014 at 4:09 PM, Carl Worth wrote: >> Ian Romanick writes: >>> Anuj: Can you verify this does not regress proxy_textures_invalid_size? >> ... >>> Cc: "10.2" >> >> Ian (or Anuj), is there an outstanding question of a regression here >> that should still be a

[Mesa-dev] [PATCH 1/2] egl/dri2: use the correct screen index

2014-08-19 Thread Marek Olšák
From: Marek Olšák Required for multi-GPU configuration where each GPU has its own X screen. --- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_x11.c | 39 +++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/src/egl/dri

[Mesa-dev] [PATCH 2/2] pipe-loader: use the correct screen index

2014-08-19 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c index 1bbaf19..2468336 10

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #31 from Eugene --- Here it is another one time again: Program received signal SIGSEGV, Segmentation fault. 0x in ?? () (gdb) bt full #0 0x in ?? () No symbol table info available. #1 0x7fffb5ee

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Tom Stellard
On Tue, Aug 19, 2014 at 01:37:56PM -0700, Connor Abbott wrote: > On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez > wrote: > > Tom Stellard writes: > > > >> On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: > >>> On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer wrote: > >>> > On 19.

[Mesa-dev] [PATCH 2/2] evergreen/compute: Don't initialize vertex_buffer_state masks to 0x2

2014-08-19 Thread Tom Stellard
cs_vertex_buffer_state.enabled_mask and cs_vertex_buffer_state.dirty_mask are both updated when r600_set_constant_buffer() is called, so we don't need to manually update these values. This fixes a crash with OpenCL programs that have a kernel with no arguments. https://bugs.freedesktop.org/show_b

[Mesa-dev] [PATCH 1/2] r600g/compute: Use the first parameter in evergreen_set_global_binding()

2014-08-19 Thread Tom Stellard
--- src/gallium/drivers/r600/evergreen_compute.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index acc1b71..9e3404f 100644 --- a/src/gallium/drivers/r600/evergreen_compute.c ++

[Mesa-dev] [PATCH] pipe-loader: Fix memory leak v2

2014-08-19 Thread Tom Stellard
CC: "10.2" v2: - Change driver_name to char* --- src/gallium/auxiliary/pipe-loader/pipe_loader.h | 2 +- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader.h b/src/gallium

[Mesa-dev] [PATCH] glsl: Use the without_array predicate in some more places

2014-08-19 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/glsl/link_uniform_initializers.cpp | 3 +-- src/mesa/program/ir_to_mesa.cpp| 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index c6fe6a9..c938845

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-19 Thread Connor Abbott
On Tue, Aug 19, 2014 at 3:57 PM, Tom Stellard wrote: > On Tue, Aug 19, 2014 at 01:37:56PM -0700, Connor Abbott wrote: >> On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez >> wrote: >> > Tom Stellard writes: >> > >> >> On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: >> >>> On Mon,

Re: [Mesa-dev] [PATCH] glsl: Use the without_array predicate in some more places

2014-08-19 Thread Matt Turner
Thanks. Reviewed-by: Matt Turner and committed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Add blorp fast clear back

2014-08-19 Thread Kristian Høgsberg
The meta fast clear implementation still has some rough edges. In particular, it still hits a texture deadlock in some code paths and even with the mi_flush fix there is still a rendering regression on the SynMark Terrain test case. This adds back the blorp path, while we figure out how to make th

[Mesa-dev] cant build mesa against current llvm(3.6 git)

2014-08-19 Thread Enrico Horn
Hi everyone, tried to build mesa just now with llvm from git and get the following error: gallivm/lp_bld_misc.cpp: In function 'LLVMBool lp_build_create_jit_compiler_for_module(LLVMOpaqueExecutionEngine**, lp_generated_code**, LLVMModuleRef, unsigned int, int, char**)': gallivm/lp_bld_misc.cpp:424

Re: [Mesa-dev] cant build mesa against current llvm(3.6 git)

2014-08-19 Thread Roland Scheidegger
Am 19.08.2014 23:29, schrieb Enrico Horn: > Hi everyone, > tried to build mesa just now with llvm from git and get the following error: > > gallivm/lp_bld_misc.cpp: In function 'LLVMBool > lp_build_create_jit_compiler_for_module(LLVMOpaqueExecutionEngine**, > lp_generated_code**, LLVMModuleRef, un

[Mesa-dev] [PATCH] nv50: Handle ARB_conditional_render_inverted and enable it

2014-08-19 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 2 +- src/gallium/drivers/nouveau/nv50/nv50_context.h | 3 +- src/gallium/drivers/nouveau/nv50/nv50_query.c | 59 - src/galliu

Re: [Mesa-dev] [PATCH 01/17] i965/vec4/fs: Count loops in shader debug

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:17 AM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 6 -- > src/mesa/drivers/dri/i965/brw_vec4.h | 1 + > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 6 -- > 3 files changed

Re: [Mesa-dev] [PATCH 13/17] i965/fs: Allow propagation of instructions with saturate flag to sel

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:17 AM, Abdiel Janulgue wrote: > When sel conditon is bounded within 0 and 1.0. This allows code as: > mov.sat a b > sel.ge dst a 0.25F > > To be propagated as: > sel.ge.sat dst b 0.25F > > v3: Syntax clarifications in inst->saturate assignment (Ma

Re: [Mesa-dev] [PATCH 14/17] i965/vec4: Allow propagation of instructions with saturate flag to sel

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:17 AM, Abdiel Janulgue wrote: > + if (entry->saturatemask & (1 << arg)) { > + switch(inst->opcode) { > + case BRW_OPCODE_SEL: > + if (inst->src[1].file != IMM || > + inst->src[1].fixed_hw_reg.dw1.f < 0.0 || > + inst->src[1].fixe

Re: [Mesa-dev] [PATCH 16/17] i965/fs: Refactor try_emit_saturate

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:17 AM, Abdiel Janulgue wrote: > + /* If the last instruction from our accept() generated our > +* src, just set the saturate flag instead of emmitting a separate mov. emitting. > */ > fs_inst *modify = get_instruction_generating_reg(pre_inst, last_inst,

Re: [Mesa-dev] Clamp/saturate optimizations v3

2014-08-19 Thread Matt Turner
On Mon, Aug 18, 2014 at 5:17 AM, Abdiel Janulgue wrote: > v3 of clamp and saturate optimizations Patches 2-4, (5-9 already reviewed), 10, 13-16, (17 already reviewed) are Reviewed-by: Matt Turner I've requested a change come before patch 1, and then rebased patch 1 should be an easy R-b. I'll

[Mesa-dev] [Bug 79629] [dri3] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 --- Comment #6 from wendy.w...@intel.com --- Hi Chris, would you pls take a look at this bug which blocked WebGL performance testing. Bug will disable WebGL in chrome(Firefox is OK) -- You are receiving this mail because: You are the assignee fo

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2014-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 wendy.w...@intel.com changed: What|Removed |Added Summary|[dri3] piglit |[Dri3 bisected] piglit

[Mesa-dev] [PATCH V3 2/4] r600g: add MAX_VERTEX_ATTRIB_STRIDE

2014-08-19 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- Note: I have not tested that this patch works as I dont have access to the hardware. src/gallium/drivers/r600/r600_pipe.c | 3 +++ src/gallium/include/pipe/p_defines.h | 1 + src/mesa/state_tracker/st_extensions.c | 3 +++ 3 files changed, 7 insertions(+)

[Mesa-dev] [PATCH V3 4/4] docs: mark GL_MAX_VERTEX_ATTRIB_STRIDE as done

2014-08-19 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 76412c3..a5842cc 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -172,7 +172,7 @@ GL 4.3, GLSL 4.30: GL 4.4, GLSL 4.40: - GL_MAX_VERTEX_ATTRIB

[Mesa-dev] [PATCH V3 1/4] mesa: implement GL_MAX_VERTEX_ATTRIB_STRIDE

2014-08-19 Thread Timothy Arceri
V2: moved test for the VertexAttrib*Pointer() functions to update_array(), and made constant available for drivers to set Signed-off-by: Timothy Arceri --- Although 4.4 is a while away GL_MAX_VERTEX_ATTRIB_STRIDE is used in the ARB_direct_state_access spec so it seemed worth while adding this

  1   2   >