On 19/08/14 09:39, Chia-I Wu wrote: > On Tue, Aug 19, 2014 at 4:26 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 19/08/14 09:07, Chia-I Wu wrote: >>> On Tue, Aug 19, 2014 at 7:20 AM, Emil Velikov <emil.l.veli...@gmail.com> >>> wrote: >>>> Make the header location, inclusion and contents more common with >>>> its i915,r* and nouveau counterparts: >>>> >>>> - Move the header within intel/drm. >>>> - Separate out intel_winsys_create_for_fd into 'drm_public' header. >>>> - Cleanup the compiler includes. >>> The latter two sound fine to me, but do you have a real need to move >>> intel_winsys.h into drm/? It is supposed to be OS-neutral so that the >>> pipe driver stays OS-neutral, not being tied to DRM. >>> >> No "real need" just the following ideas >> - Ease 'make dist' - see patch 07/22 from this series. >> - Gets things more obvious by prefixing the winsys header inclusions with >> $(hw)/drm or sw/$(platform). >> - This is how the cool kids do it (radeon) :P >> >> One could argue that ilo's approach is correct, and everyone else is >> encouraged to follow, yet I'm taking the route of least resistance :) > How about splitting intel_winsys_create_for_fd() out to the public > header, and move intel_winsys.h to drivers/ilo/? Other cool kids > appear to do it that way. > Like i915g, svga and nouveau ? Sure fine with me :)
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
