Re: [Mesa-dev] [PATCH 04/19] i965/fs: Store the number of sources an fs_inst has.

On 05/28/2014 04:47 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 21 +++-- > src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH 04/19] i965/fs: Store the number of sources an fs_inst has.

On 05/28/2014 10:38 AM, Tapani Pälli wrote: > On 05/28/2014 04:47 AM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 21 +++-- >> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >> 2 files changed, 13 insertions(+), 11 deletions(-) >> >> diff --git a/src/mesa/dr

Re: [Mesa-dev] [PATCH 05/19] i965/fs: Loop from 0 to inst->sources, not 0 to 3.

On 05/28/2014 04:47 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 24 > +++--- > .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 ++-- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- > .../dri/i965/brw_fs_dead_code_elimin

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

On 28.05.2014 09:55, Axel Davy wrote: > From: Keith Packard > > Provide the hook to pull textures out of __DRIimage structures and use them as > renderbuffers. > > Signed-off-by: Keith Packard This patch breaks a number of piglit tests with DRI2, see the backtrace below. This fixes it: diff -

Re: [Mesa-dev] [PATCH 07/19] i965/fs: Add a function to resize fs_inst's sources array.

On 05/28/2014 04:47 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + > src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index f926d97.

[Mesa-dev] [Bug 79263] Linking error in egl_gallium.la when compiling 32 bit on multiarch

https://bugs.freedesktop.org/show_bug.cgi?id=79263 Chia-I Wu changed: What|Removed |Added CC||emil.l.veli...@gmail.com,

Re: [Mesa-dev] [PATCH 11/11] Radeonsi: Use dma_copy when possible for si_blit.

On 28.05.2014 09:55, Axel Davy wrote: > This improves GLX DRI3 Gpu offloading significantly on cpu > bound benchmarks particularly. > No performance impact for DRI2 Gpu offloading. > > Signed-off-by: Axel Davy > --- > src/gallium/drivers/radeonsi/si_blit.c | 15 +++ > 1 file changed,

[Mesa-dev] [Bug 78716] Fix Mesa bugs for running Unreal Engine 4.1 Cave effects demo compiled for Linux

https://bugs.freedesktop.org/show_bug.cgi?id=78716 darkbasic changed: What|Removed |Added CC||darkba...@linuxsystems.it -- You are receiv

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

On 28.05.2014 09:55, Axel Davy wrote: > From: Keith Packard > > Provide the hook to pull textures out of __DRIimage structures and use them as > renderbuffers. > > Signed-off-by: Keith Packard Enabling DRI3 using this change breaks a number of depth/stencil and multisampling related piglit tes

[Mesa-dev] [PATCH v2] glsl: reduce size of swizzle field in ir_state_slot

v2: oops, swizzle needs more space than 8 bits (Tapani) Signed-off-by: Tapani Pälli --- src/glsl/ir.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index fccbfdd..22d981a 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -384,7 +384,7 @@ depth_

Re: [Mesa-dev] [PATCH 00/21] Reduce ir_variable memory usage

On 05/28/2014 05:48 AM, Ian Romanick wrote: > This series reduces the memory usage of ir_variable quite significantly. > > The first couple patches add a mechanism to determine the amount of > memory used by any kind of IR object. This is used to collect the data > that is shown in the commit mess

Re: [Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM

On 28/05/14 07:42, Kertesz Laszlo wrote: >>> Hi, >>> i too hit the X crashing issue. But i am unable to compile the latest >>> git (10.2-branchpoint-318-g4c7bf8a according to 'git describe') >>> Here is the errors i get: >>> >>> >>> make[3]: Entering directory '/compile/mesa/src/gallium/targets/gbm

Re: [Mesa-dev] [PATCH 06/11] loader: Use drirc device_id parameter in complement to DRI_PRIME

On 27/05/2014 23:46, Michel Dänzer wrote : This breaks the build for me, see below. That's an out-of-tree build FWIW. make[2]: Entering directory '/home/daenzer/src/mesa-git/mesa/build-amd64/src/loader' cd ../../.. && automake-1.14 --foreign src/loader/Makefile src/loader/Makefile.am:42: war

Re: [Mesa-dev] [PATCH 11/11] Radeonsi: Use dma_copy when possible for si_blit.

On 28/05/2014 04:40, Michel Dänzer wrote : On 28.05.2014 09:55, Axel Davy wrote: This improves GLX DRI3 Gpu offloading significantly on cpu bound benchmarks particularly. No performance impact for DRI2 Gpu offloading. Signed-off-by: Axel Davy --- src/gallium/drivers/radeonsi/si_blit.c | 15 +

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

On 28/05/2014 03:47, Michel Dänzer wrote : On 28.05.2014 09:55, Axel Davy wrote: From: Keith Packard Provide the hook to pull textures out of __DRIimage structures and use them as renderbuffers. Signed-off-by: Keith Packard This patch breaks a number of piglit tests with DRI2, see the backt

Re: [Mesa-dev] [PATCH 04/11] Loader: Add gpu selection code with DRI_PRIME.

On 28/05/14 01:55, Axel Davy wrote: > Signed-off-by: Axel Davy > --- > src/loader/loader.c | 188 > > src/loader/loader.h | 7 ++ > 2 files changed, 195 insertions(+) > > diff --git a/src/loader/loader.c b/src/loader/loader.c > index 666d01

[Mesa-dev] Splitting fs-instruction emission out of fs_visitor

Here is some restructuring I've done in the compiler backend, mostly for the fragment shader side. It allows me to introduce gen6/7 stencil texturing without growing the already large fs_visitor even more. I identified some common logic between fs and vec4 visitors and moved these into brw_shader.

[Mesa-dev] [PATCH 04/14] i965/vec4: Use unsigned instead of signed for visitor uniform count

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 12 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 2 +- 4 files changed, 11 ins

[Mesa-dev] [PATCH 01/14] i965: Split emitter out of backend_visitor

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_cfg.cpp| 8 src/mesa/drivers/dri/i965/brw_cfg.h | 4 ++-- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_dead_control_flow.h| 2 +- s

[Mesa-dev] [PATCH 02/14] i965: Merge emission memory context setup for shader visitors

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +-- src/mesa/drivers/dri/i965/brw_shader.cpp | 5 +++-- src/mesa/drivers/dri/i965/brw_shader.h | 8 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 +-- 4 files changed, 11 insertions

[Mesa-dev] [PATCH 09/14] i965: Merge resolving of register size between fs and vec4

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 37 --- src/mesa/drivers/dri/i965/brw_fs.h | 1 - src/mesa/drivers/dri/i965/brw_shader.cpp | 51 + src/mesa/drivers/dri/i965/brw_shader.h | 3 ++ src/me

[Mesa-dev] [PATCH 11/14] i965/fs: Reduce scope for the visitor

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 90aca4f..c971480 1006

[Mesa-dev] [PATCH 06/14] i965: Merge fail() for ir visitors

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 30 -- src/mesa/drivers/dri/i965/brw_fs.h | 4 --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 44

[Mesa-dev] [PATCH 12/14] i965/fs: Split declarations of fs_reg and fs_inst out of brw_fs.h

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 174 + src/mesa/drivers/dri/i965/brw_fs_emit.h | 220 2 files changed, 221 insertions(+), 173 deletions(-) create mode 100644 src/mesa/drivers/dri/i965/brw_fs_em

[Mesa-dev] [PATCH 08/14] i965: Refactor virtual register allocation between fs and vec4

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 15 - src/mesa/drivers/dri/i965/brw_fs.h | 4 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 25 +++

[Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

Now empty destructors are dropped allowing compiler to generate the defaults (calling base class). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 src/mesa/drivers/dri/i965/brw_shader.cpp

[Mesa-dev] [PATCH 07/14] i965/vec4: Move virtual register map into backend_emitter

In preparation for merging virtual register allocation between vector and fragment visitors. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_shader.h | 8 src/mesa/drivers/dri/i965/brw_vec4.h |

[Mesa-dev] [PATCH 13/14] i965/fs: Split LIR emission ouf of ir-visitor

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 44 --- src/mesa/drivers/dri/i965/brw_fs.h | 19 + src/mesa/drivers/dri/i965/brw_fs_emit.h | 33 src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 03/14] i965: Merge max_grf between stage compilers

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h| 2 -- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 - src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++- src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 14/14] i965/fs: Move emission of ALUs into fs_emitter

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 99 src/mesa/drivers/dri/i965/brw_fs.h | 31 - src/mesa/drivers/dri/i965/brw_fs_emit.h | 32 + src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 98 +

[Mesa-dev] [PATCH 10/14] i965: Merge common members of visitors

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 12 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 7 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 9 - src/mesa/drivers/dri/i965/brw_shader.h | 16 s

Re: [Mesa-dev] [PATCH 06/11] loader: Use drirc device_id parameter in complement to DRI_PRIME

On 28/05/14 01:55, Axel Davy wrote: > Signed-off-by: Axel Davy Hi Axel Can you give the scons build a try. I suspect that this patch will leave it in somewhat broken state. > --- > src/Makefile.am | 4 +++- > src/loader/Makefile.am | 21

[Mesa-dev] [Bug 79263] Linking error in egl_gallium.la when compiling 32 bit on multiarch

https://bugs.freedesktop.org/show_bug.cgi?id=79263 --- Comment #2 from Emil Velikov --- Handling of the egl_platform is slightly move convoluted than expected. platform_drm - things will build nicely as the loader* symbols are provided via gbm/libgbm. Everything else - the symbols are missing.

Re: [Mesa-dev] [PATCH 04/11] Loader: Add gpu selection code with DRI_PRIME.

On 28/05/2014 08:33, Emil Velikov wrote : Hi Axel, AFAICS we're leaking device_name. That's true, I'll send a patch with the fix. FYI I'm about to push a few patches for non libudev users which may cause merge conflicts when applying this series. Thanks for the information. Cheers Emil A

Re: [Mesa-dev] [PATCH 06/11] loader: Use drirc device_id parameter in complement to DRI_PRIME

On 28/05/2014 08:40, Emil Velikov wrote : On 28/05/14 01:55, Axel Davy wrote: Signed-off-by: Axel Davy Hi Axel Can you give the scons build a try. I suspect that this patch will leave it in somewhat broken state. I'll give a try. --- src/Makefile.am | 4

Re: [Mesa-dev] [PATCH 17/21] glsl: Make ir_variable::num_state_slots and ir_variable::state_slots private

On 05/28/2014 05:49 AM, Ian Romanick wrote: From: Ian Romanick Also move num_state_slots inside ir_variable_data for better packing. The payoff for this will come in a few more patches. Signed-off-by: Ian Romanick looks good to me, also I've rebased my cache code on top of these particula

Re: [Mesa-dev] [PATCH 1/2] glsl: fix use-after free bug/crash in ast_declarator_list::hir()

Ping. On 05/23/2014 03:22 PM, Brian Paul wrote: The call to get_variable_being_redeclared() may delete 'var' so we can't reference var->name afterward. We fix that by examining the var's name before making that call. Fixes valgrind warnings and possible crash when running the piglit tests/spe

Re: [Mesa-dev] [PATCH 09/19] i965/fs: Add SHADER_OPCODE_LOAD_PAYLOAD.

On Tue, May 27, 2014 at 06:47:40PM -0700, Matt Turner wrote: > Will be used to simplify the handling of large virtual GRFs in SSA form. > --- > src/mesa/drivers/dri/i965/brw_defines.h| 2 ++ > src/mesa/drivers/dri/i965/brw_fs.cpp | 10 ++ > src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 1/2] egl_dri2: fix wayland_platform when drm_platform is not set

The build fails with implicit delaration of drmGetCap (xf86drm.h) Were we're including the header only when building the DRM_PLATFORM. Wayland backend can operate without DRM_PLATFORM so replace the guard, and fold in drmGetCap() usage to silence compiler warnings. Cc: Chad Versace Cc: Kristian

[Mesa-dev] [PATCH 2/2] egl-static: resolve library linking

With DRM_PLATFORM libloader.la in linked into libEGL pleading to multiple defition of the loader* symbols. For every other platform we need to explicitly link against it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79263 Cc: José Fonseca Cc: Chia-I Wu Signed-off-by: Emil Velikov ---

Re: [Mesa-dev] [PATCH 10/19] i965/fs: Lower LOAD_PAYLOAD and clean up.

On Tue, May 27, 2014 at 06:47:41PM -0700, Matt Turner wrote: > Clean up with with register_coalesce()/dead_code_eliminate(). > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 42 > > src/mesa/drivers/dri/i965/brw_fs.h | 1 + > 2 files changed, 43 insertions(+)

Re: [Mesa-dev] [PATCH 06/11] loader: Use drirc device_id parameter in complement to DRI_PRIME

On 28/05/14 14:24, Axel Davy wrote: > On 28/05/2014 08:40, Emil Velikov wrote : >> On 28/05/14 01:55, Axel Davy wrote: >>> Signed-off-by: Axel Davy >> Hi Axel >> >> Can you give the scons build a try. I suspect that this patch will leave it >> in >> somewhat broken state. > I'll give a try. >> >>

Re: [Mesa-dev] [PATCH 09/19] i965/fs: Add SHADER_OPCODE_LOAD_PAYLOAD.

On Wed, May 28, 2014 at 7:43 AM, Pohjolainen, Topi wrote: > On Tue, May 27, 2014 at 06:47:40PM -0700, Matt Turner wrote: >> Will be used to simplify the handling of large virtual GRFs in SSA form. >> --- >> src/mesa/drivers/dri/i965/brw_defines.h| 2 ++ >> src/mesa/drivers/dri/i965/brw_f

Re: [Mesa-dev] [PATCH 1/2] glsl: reduce size of glsl_type::base_type

Types are fly-weights, so there aren't that many of them allocated... maybe a couple hundred, tops. Have you measured the memory savings? On 05/27/2014 10:09 PM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/glsl/glsl_types.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

Re: [Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM

[Just a short note, as I can't test Mesa any longer, since I have a new Radeon, which is "no business case" for the FLOSS driver.] terminfo rings a bell, IIRC there was a Mesa bug about this some while back; for myself at least I just added the terminfo stuff to my Mesa build (again IIRC, that pro

Re: [Mesa-dev] [PATCH 2/2] glsl: reduce size of swizzle field in ir_state_slot

This won't actually do anything because the compiler still rounds the size of the structure upto a multiple of sizeof(int) for alignment purposes. With your v2 patch applied, I still get (gdb) print sizeof(ir_state_slot) $1 = 24 which is 6*sizeof(int). On 05/27/2014 10:09 PM, Tapani Pälli wrote

Re: [Mesa-dev] [PATCH 2/2] glsl: replace strncmp("gl_") calls with new is_gl_identifier() helper

Reviewed-by: Ian Romanick On 05/23/2014 02:22 PM, Brian Paul wrote: > Makes things a little easier to read. > --- > src/glsl/ast_to_hir.cpp |8 > src/glsl/ir.h |9 + > src/glsl/ir_print_visitor.cpp |2 +- > src/glsl/link_uniforms.cpp|4 +

Re: [Mesa-dev] [PATCH 1/2] glsl: fix use-after free bug/crash in ast_declarator_list::hir()

On 05/23/2014 02:22 PM, Brian Paul wrote: > The call to get_variable_being_redeclared() may delete 'var' so we > can't reference var->name afterward. We fix that by examining the > var's name before making that call. > > Fixes valgrind warnings and possible crash when running the piglit > tests/s

Re: [Mesa-dev] [PATCH 2/2] wglinfo: use common code from glinfo_common.c

This is a nice cleanup. You can use ${CMAKE_SOURCE_DIR}/src/xdemos/glinfo_common.c instead. Jose - Original Message - > I'm not a cmake expert so I'm not sure my changes to CMakeLists.txt are > ideal. Doing ../somewhere always feels like a hack. > > -Brian > > > On 05/22/2014

Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

On Wed, May 28, 2014 at 5:36 AM, Topi Pohjolainen wrote: > Now empty destructors are dropped allowing compiler to generate the > defaults (calling base class). > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 -- > src/mesa/drivers/dri/i965/brw_fs_vi

Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

On Wed, May 28, 2014 at 10:43 AM, Matt Turner wrote: > Doesn't backend_visitor need to have a destructor that calls hash_table_dtor? Ah, next patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

[Mesa-dev] [Bug 79382] New: build error: multiple definition of `loader_get_pci_id_for_fd'

https://bugs.freedesktop.org/show_bug.cgi?id=79382 Priority: high Bug ID: 79382 CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: build error: multiple definition of `loader_get_pci_id_for_fd'

Re: [Mesa-dev] [PATCH 12/14] i965/fs: Split declarations of fs_reg and fs_inst out of brw_fs.h

On Wed, May 28, 2014 at 5:36 AM, Topi Pohjolainen wrote: > + * Authors: > + *Eric Anholt I think Eric said he wanted to stop using Author lists. Probably use this opportunity to drop it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 13/14] i965/fs: Split LIR emission ouf of ir-visitor

On Wed, May 28, 2014 at 5:36 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_fs.cpp | 44 --- > src/mesa/drivers/dri/i965/brw_fs.h | 19 + > src/mesa/driver

Re: [Mesa-dev] [PATCH] i965: Fix repeated usage of rectangle texture coordinate scaling.

On 05/27/2014 06:16 PM, Kenneth Graunke wrote: > Previously, we set up new entries in the params[] array on every access > of a rectangle texture. Unfortunately, we only reserve space for > (2 * MaxTextureImageUnits) extra entries, so programs which accessed > rectangle textures more times than th

[Mesa-dev] [PATCH 14/16] mesa: Change program parser instruction storage.

This is in preparation for making prog_instruction be a list element -- I'm going to want to allocate the final instruction at this point, and this gets a bunch of pointer type changes out of the way for that big commit. --- src/mesa/program/prog_parameter_layout.c | 16 src/mesa/program/

[Mesa-dev] [PATCH 05/16] mesa: Fix debug printing of live ranges for dead values.

We'd loop for approximately forever trying to get to (GLuint)-1. --- src/mesa/program/prog_optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/prog_optimize.c b/src/mesa/program/prog_optimize.c index 1ab54ec..e877497 100644 --- a/src/mesa/program/prog_op

[Mesa-dev] [PATCH 10/16] mesa: Remove REG_ALLOCATE_MAX_PROGRAM_TEMPS from global dead code.

--- src/mesa/program/prog_optimize.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/mesa/program/prog_optimize.c b/src/mesa/program/prog_optimize.c index ce53937..f0d279b 100644 --- a/src/mesa/program/prog_optimize.c +++ b/src/mesa/program/prog_op

[Mesa-dev] [PATCH 12/16] mesa: Dynamically allocate memory for _mesa_reallocate_registers().

No more nasty stack allocations in this path. --- src/mesa/program/prog_optimize.c | 51 1 file changed, 36 insertions(+), 15 deletions(-) diff --git a/src/mesa/program/prog_optimize.c b/src/mesa/program/prog_optimize.c index 20c6dd9..d76a15d 100644 --- a/

[Mesa-dev] [PATCH 16/16] mesa: Expand the Mesa IR register index to a full int.

With this, we can stop worrying about overflowing the tiny 4k temps we used to be limited to. --- src/mesa/program/ir_to_mesa.cpp | 1 - src/mesa/program/prog_instruction.h | 25 ++--- src/mesa/program/program.c | 17 - src/mesa/program/program_par

[Mesa-dev] [PATCH 04/16] mesa: Make prog_optimize() consistently use stderr.

Note that _mesa_print_program() and _mesa_print_instruction() both used stderr, so this stdout stuff would get mixed up with it. --- src/mesa/program/prog_optimize.c | 64 +--- 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/src/mesa/program/prog

[Mesa-dev] Mesa IR as a list of instructions

Here's a series I started back in January as a little experiment. Basically, I feel guilty for pushing GLSL IR into the driver, and wish I'd just fixed up Mesa IR back in the day. But, given that we're still feeding Mesa IR into drivers as well (ARB programs and fixed function vertex programs), it

[Mesa-dev] [PATCH 01/16] ir_to_mesa: Move Mesa IR debug to stderr as well.

Half the debug was in stderr, and this bit was in stdout. --- src/mesa/program/ir_to_mesa.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 59cf123..978b6cf 100644 --- a/src/mesa/program/ir_t

[Mesa-dev] [PATCH 07/16] mesa: Drop some redundant Mesa IR instruction setup for MVP.

Since we've got them already initialized by _mesa_init_instructions(), I think this helps make the code more obvious (only set a writemask when you've got a non-default writemask). Ideally, we'd probably reuse one of those piles of helper code for emitting Mesa IR instructions, though. --- src/me

[Mesa-dev] [PATCH 08/16] mesa: Remove stale comment (and fix grammar in the remainder).

_mesa_add_state_reference() already checks to see if you've already got that state referenced. --- src/mesa/program/programopt.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c index 39a83b4..bcc0b75 10064

[Mesa-dev] [PATCH 02/16] ir_to_mesa: Dump the optimized Mesa IR as well.

We were dumping the intial code generated before optimization, with annotation, because we don't have support for tracking the annotation info across optimization. It's still really useful to see the optimized code, though. --- src/mesa/program/ir_to_mesa.cpp | 8 1 file changed, 8 inser

[Mesa-dev] [PATCH 06/16] mesa: Fix a "1" vs "i" typo in MVP setup.

It doesn't matter, because the instructions were initialized to noop swizzles anyway. --- src/mesa/program/programopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c index 92a8831..ee822be 100644 --- a/src/mesa/pro

[Mesa-dev] [PATCH 03/16] mesa: Fix find_next_use() in the presence of RelAddr.

Both callers of this function are doing dead code elimintation: "is this reg completely rewritten before any of these components are used?". If there's reladdr on this write, then we don't know if the write landed in our channels or not, but assuming that it didn't is conservative and safe. This

[Mesa-dev] [PATCH 09/16] mesa: Slightly change instruction walking behavior for prog_optimize.

I was going to change this when I moved to lists of instructions, and wanted to call the behavior change out here. Note that the last instruction is always OPCODE_END, and can_upward_mov_be_modified will notice that it's not a MOV and take the continue path (to the exit of the loop). --- src/mesa

[Mesa-dev] [PATCH 11/16] mesa: Simplify _mesa_find_temp_intervals().

Since there are no other callers, we can make it static and propagate some types around, removing one of the giant stack allocations. --- src/mesa/program/prog_optimize.c | 77 ++-- src/mesa/program/prog_optimize.h | 7 2 files changed, 34 insertions(+), 5

[Mesa-dev] [PATCH 13/16] mesa: Remove the last REG_ALLOCATE_MAX_TEMPS user.

--- src/mesa/program/prog_optimize.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/mesa/program/prog_optimize.c b/src/mesa/program/prog_optimize.c index d76a15d..88dc177 100644 --- a/src/mesa/program/prog_optimize.c +++ b/src/mesa/program/prog_optimize

Re: [Mesa-dev] [PATCH 08/10] glsl: parser changes for GL_ARB_explicit_uniform_location

On 05/22/2014 09:37 PM, Tapani Pälli wrote: > On 05/21/2014 07:52 PM, Ian Romanick wrote: >> On 05/21/2014 08:11 AM, Tapani wrote: >>> On 05/21/2014 05:43 PM, Tapani wrote: On 05/21/2014 01:27 AM, Ian Romanick wrote: > On 05/19/2014 10:08 PM, Tapani wrote: >> On 05/19/2014 08:18 PM, Ia

Re: [Mesa-dev] [PATCH] i965: Fix repeated usage of rectangle texture coordinate scaling.

Kenneth Graunke writes: > Previously, we set up new entries in the params[] array on every access > of a rectangle texture. Unfortunately, we only reserve space for > (2 * MaxTextureImageUnits) extra entries, so programs which accessed > rectangle textures more times than that would write off th

Re: [Mesa-dev] [PATCH 1/2] glxinfo: move reusable, non-GLX code into glinfo_common.[ch]

The code changes look good, but I know approximately jack about cmake. Reviewed-by: Ian Romanick On 05/22/2014 07:53 PM, Brian Paul wrote: > So that we can share some of the code with wglinfo. > --- > src/xdemos/CMakeLists.txt |4 +- > src/xdemos/Makefile.am |4 + > src/xdemos/glin

Re: [Mesa-dev] Mesa IR as a list of instructions

On 05/28/2014 11:37 AM, Eric Anholt wrote: > Here's a series I started back in January as a little experiment. > Basically, I feel guilty for pushing GLSL IR into the driver, and wish I'd > just fixed up Mesa IR back in the day. But, given that we're still > feeding Mesa IR into drivers as well (A

Re: [Mesa-dev] [PATCH 11/21] glsl: Store ir_variable::ir_type in 8 bits instead of 32

On 05/27/2014 08:28 PM, Matt Turner wrote: > On Tue, May 27, 2014 at 7:49 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> No change in the peak ir_variable memory usage in a trimmed apitrace of >> dota2 on 64-bit. >> >> No change in the peak ir_variable memory usage in a trimmed apitrace of >

Re: [Mesa-dev] [PATCH 06/16] mesa: Fix a "1" vs "i" typo in MVP setup.

This should also get tagged for stable... probably 10.1 and 10.2. On 05/28/2014 11:37 AM, Eric Anholt wrote: > It doesn't matter, because the instructions were initialized to noop > swizzles anyway. > --- > src/mesa/program/programopt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 11/21] glsl: Store ir_variable::ir_type in 8 bits instead of 32

On Wed, May 28, 2014 at 2:17 PM, Ian Romanick wrote: > On 05/27/2014 08:28 PM, Matt Turner wrote: > > On Tue, May 27, 2014 at 7:49 PM, Ian Romanick > wrote: > >> From: Ian Romanick > >> > >> No change in the peak ir_variable memory usage in a trimmed apitrace of > >> dota2 on 64-bit. > >> > >>

Re: [Mesa-dev] [PATCH 17/21] glsl: Make ir_variable::num_state_slots and ir_variable::state_slots private

On 05/28/2014 07:22 AM, Tapani wrote: > On 05/28/2014 05:49 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> Also move num_state_slots inside ir_variable_data for better packing. >> >> The payoff for this will come in a few more patches. >> >> Signed-off-by: Ian Romanick > > looks good to me,

Re: [Mesa-dev] [PATCH 11/21] glsl: Store ir_variable::ir_type in 8 bits instead of 32

On 05/28/2014 12:20 PM, Patrick Baggett wrote: > On Wed, May 28, 2014 at 2:17 PM, Ian Romanick > wrote: > > On 05/27/2014 08:28 PM, Matt Turner wrote: > > On Tue, May 27, 2014 at 7:49 PM, Ian Romanick > wrote: > >> From: I

Re: [Mesa-dev] [PATCH 11/21] glsl: Store ir_variable::ir_type in 8 bits instead of 32

On 05/28/2014 12:17 PM, Ian Romanick wrote: > On 05/27/2014 08:28 PM, Matt Turner wrote: >> On Tue, May 27, 2014 at 7:49 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> No change in the peak ir_variable memory usage in a trimmed apitrace of >>> dota2 on 64-bit. >>> >>> No change in the pea

Re: [Mesa-dev] [PATCH 2/3] i965: Add runtime checks for line antialiasing in Gen < 6.

On 05/27/2014 03:50 AM, Iago Toral Quiroga wrote: > In Gen < 6 the hardware generates a runtime bit that indicates whether AA data > has to be sent as part of the framebuffer write SEND message. This affects the > specific case where we have setup antialiased line rendering and we render > polygons

Re: [Mesa-dev] [PATCH 11/21] glsl: Store ir_variable::ir_type in 8 bits instead of 32

On Wed, May 28, 2014 at 3:39 PM, Ian Romanick wrote: > On 05/28/2014 12:17 PM, Ian Romanick wrote: >> On 05/27/2014 08:28 PM, Matt Turner wrote: >>> On Tue, May 27, 2014 at 7:49 PM, Ian Romanick wrote: From: Ian Romanick No change in the peak ir_variable memory usage in a trimmed

Re: [Mesa-dev] [PATCH v2 3/4] glsl/tests: call create_test_cases.py in optimization-test

On 05/27/2014 06:23 PM, Connor Abbott wrote: > This way, when someone modifies create_test_cases.py and forgets to > commit their changes again, people will notice. > > v2: make sure we parse the right directories and check for existance the > right way. > > Signed-off-by: Connor Abbott > --- >

Re: [Mesa-dev] [PATCH v2 3/4] glsl/tests: call create_test_cases.py in optimization-test

On Wed, May 28, 2014 at 1:09 PM, Kenneth Graunke wrote: > On 05/27/2014 06:23 PM, Connor Abbott wrote: >> This way, when someone modifies create_test_cases.py and forgets to >> commit their changes again, people will notice. >> >> v2: make sure we parse the right directories and check for existanc

[Mesa-dev] [Bug 78318] [swrast] piglit glsl-kwin-blur-1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=78318 --- Comment #1 from Kenneth Graunke --- This is the first broken commit: commit ca21cffebd063354291d561eadc2ded8795a5333 Author: Ian Romanick Date: Tue Mar 25 18:34:31 2014 -0700 meta: Fix saving the program pipeline state This code

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79039 Kenneth Graunke changed: What|Removed |Added Depends on|77161 | -- You are receiving this mail becau

[Mesa-dev] [Bug 77161] [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=77161 Kenneth Graunke changed: What|Removed |Added Blocks|79039 | --- Comment #5 from Kenneth Graunke

Re: [Mesa-dev] [PATCH 07/19] i965/fs: Add a function to resize fs_inst's sources array.

On Wed, May 28, 2014 at 12:50 AM, Tapani Pälli wrote: > On 05/28/2014 04:47 AM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + >> src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH] mesa: Free the compiled shader IR after it has been linked.

If the shader compiled once, then we can compile it again. Compiled shaders almost always get used in just one program, so holding that compiled IR until the program is freed is just a waste of memory. On the other hand, if they are either reusing shader objects to compile multiple times, or link

Re: [Mesa-dev] [PATCH 06/16] mesa: Fix a "1" vs "i" typo in MVP setup.

Ian Romanick writes: > This should also get tagged for stable... probably 10.1 and 10.2. Did you note the commit message where it said that it's a no-op change? pgpAPvCa02_7Q.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] Mesa IR as a list of instructions

Ian Romanick writes: > On 05/28/2014 11:37 AM, Eric Anholt wrote: >> Here's a series I started back in January as a little experiment. >> Basically, I feel guilty for pushing GLSL IR into the driver, and wish I'd >> just fixed up Mesa IR back in the day. But, given that we're still >> feeding Me

Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

On Wed, May 28, 2014 at 10:46:42AM -0700, Matt Turner wrote: > On Wed, May 28, 2014 at 10:43 AM, Matt Turner wrote: > > Doesn't backend_visitor need to have a destructor that calls > > hash_table_dtor? > > Ah, next patch. Good catch, it is a rebase error of mine. It definitely belongs here. ___

Re: [Mesa-dev] [PATCH 09/19] i965/fs: Add SHADER_OPCODE_LOAD_PAYLOAD.

On Wed, May 28, 2014 at 10:06:03AM -0700, Matt Turner wrote: > On Wed, May 28, 2014 at 7:43 AM, Pohjolainen, Topi > wrote: > > On Tue, May 27, 2014 at 06:47:40PM -0700, Matt Turner wrote: > >> Will be used to simplify the handling of large virtual GRFs in SSA form. > >> --- > >> src/mesa/drivers/

Re: [Mesa-dev] [PATCH 12/19] i965/fs: Apply cube map array fixup and restore the payload.

It looks like the special handling of sources[0] in lowering LOAD_PAYLOAD would break this -- or does it never see this? On Wed, May 28, 2014 at 1:47 PM, Matt Turner wrote: > So that we don't have partial writes to a large VGRF. Will be cleaned up > by register coalescing. > --- > src/mesa/drive

Re: [Mesa-dev] [PATCH 12/19] i965/fs: Apply cube map array fixup and restore the payload.

Oh, ignore that -- I had misread your lowering code. On Thu, May 29, 2014 at 9:40 AM, Chris Forbes wrote: > It looks like the special handling of sources[0] in lowering > LOAD_PAYLOAD would break this -- or does it never see this? > > On Wed, May 28, 2014 at 1:47 PM, Matt Turner wrote: >> So tha

Re: [Mesa-dev] Mesa IR as a list of instructions

On Wed, May 28, 2014 at 2:37 PM, Eric Anholt wrote: > Here's a series I started back in January as a little experiment. > Basically, I feel guilty for pushing GLSL IR into the driver, and wish I'd > just fixed up Mesa IR back in the day. But, given that we're still > feeding Mesa IR into drivers

Re: [Mesa-dev] [PATCH v2 3/4] glsl/tests: call create_test_cases.py in optimization-test

On 05/28/2014 01:17 PM, Matt Turner wrote: > On Wed, May 28, 2014 at 1:09 PM, Kenneth Graunke > wrote: >> On 05/27/2014 06:23 PM, Connor Abbott wrote: >>> This way, when someone modifies create_test_cases.py and forgets to >>> commit their changes again, people will notice. >>> >>> v2: make sure

[Mesa-dev] [Bug 79263] Linking error in egl_gallium.la when compiling 32 bit on multiarch

https://bugs.freedesktop.org/show_bug.cgi?id=79263 --- Comment #3 from Emil Velikov --- Jose has pushed a patch that adds the symbol back, although it causes a multiple definition of loader* as expected - bug 79382. Proper fix is available http://patchwork.freedesktop.org/patch/26746/ -- You a

[Mesa-dev] [Bug 79382] build error: multiple definition of `loader_get_pci_id_for_fd'

https://bugs.freedesktop.org/show_bug.cgi?id=79382 --- Comment #1 from Emil Velikov --- Does the following patch help ? http://patchwork.freedesktop.org/patch/26746/ -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-de

  1   2   >