Re: [Mesa-dev] [PATCH 07/19] i965/fs: Add a function to resize fs_inst's sources array.

[Tapani Pälli]

On 05/28/2014 04:47 AM, Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 9 +++++++++
>  src/mesa/drivers/dri/i965/brw_fs.h   | 2 ++
>  2 files changed, 11 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp 
> b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index f926d97..1f174d3 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -111,6 +111,15 @@ fs_inst::fs_inst(const fs_inst &that)
>        this->src[i] = that.src[i];
>  }
>  
> +void
> +fs_inst::resize_sources(uint8_t num_sources)
> +{
> +   if (this->sources != num_sources) {
> +      this->src = reralloc(this, this->src, fs_reg, num_sources);
> +      this->sources = num_sources;
> +   }
> +}
> +

This looks proper to me but it does not seem to be used anywhere by this
series?

>  #define ALU1(op)                                                        \
>     fs_inst *                                                            \
>     fs_visitor::op(fs_reg dst, fs_reg src0)                              \
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.h 
> b/src/mesa/drivers/dri/i965/brw_fs.h
> index fb68923..b7cfb3c 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.h
> +++ b/src/mesa/drivers/dri/i965/brw_fs.h
> @@ -200,6 +200,8 @@ public:
>             const fs_reg &src1, const fs_reg &src2);
>     fs_inst(const fs_inst &that);
>  
> +   void resize_sources(uint8_t num_sources);
> +
>     bool equals(fs_inst *inst) const;
>     bool overwrites_reg(const fs_reg &reg) const;
>     bool is_send_from_grf() const;

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev