Re: [Mesa-dev] [PATCH 07/20] targets/dri: use install-gallium-links.mk

On Tue, 2014-03-04 at 21:12 +, Emil Velikov wrote: > Drop the duplication accross all dri targets. ... > diff --git a/src/gallium/targets/dri-ilo/Makefile.am > b/src/gallium/targets/dri-ilo/Makefile.am > index 418e2ea..18d3c44 100644 > --- a/src/gallium/targets/dri-ilo/Makefile.am > +++ b/sr

Re: [Mesa-dev] [PATCH 07/20] targets/dri: use install-gallium-links.mk

On 13/03/14 07:09, Steven Newbury wrote: On Tue, 2014-03-04 at 21:12 +, Emil Velikov wrote: Drop the duplication accross all dri targets. ... diff --git a/src/gallium/targets/dri-ilo/Makefile.am b/src/gallium/targets/dri-ilo/Makefile.am index 418e2ea..18d3c44 100644 --- a/src/gallium/ta

[Mesa-dev] [PATCH 1/2] radeonsi: Add DMA ring

Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ src/gallium/drivers/radeonsi/si_pipe.c | 22 ++ 2 files changed, 25 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 2/2] radeonsi: Implement DMA blit

This code is a slightly modified version of evergreen_dma_blit (and evergreen_dma_copy as well as evergreen_dma_copy_tile). It would be nice to share some of the code in the long term. I have reused some "cik"-prefixed functions that also return the right value for SI. I am not sure if they should

Re: [Mesa-dev] [PATCH 07/20] targets/dri: use install-gallium-links.mk

On Thu, 2014-03-13 at 07:35 +, Emil Velikov wrote: > On 13/03/14 07:09, Steven Newbury wrote: > > On Tue, 2014-03-04 at 21:12 +, Emil Velikov wrote: > >> Drop the duplication accross all dri targets. > > > > ... > > > >> diff --git a/src/gallium/targets/dri-ilo/Makefile.am > >> b/src/galli

[Mesa-dev] [PATCH] mesa: return v.value_int64 when the requested type is TYPE_INT64

Fixes "Operands don't affect result" defect reported by Coverity. Cc: "9.2 10.0 10.1" Signed-off-by: Emil Velikov --- src/mesa/main/get.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index b190851..88cf202 100644 --- a/src/

[Mesa-dev] [PATCH] winsys/radeon: Store GPU virtual memory addresses of BOs in a hash table

From: Michel Dänzer This allows retrieving the existing BO and incrementing its reference count, instead of creating a separate winsys representation for it, when the kernel reports that the BO was already assigned a virtual memory address. This fixes problems with XWayland using radeonsi and th

[Mesa-dev] [PATCH 2/8] i965: Fix indentation in brw_upload_indices().

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c index 3c537a5..f2945c1 1006

[Mesa-dev] [PATCH 8/8] i965/upload: Rename "buffer" to "staging_buffer".

This clarifies the purpose of the buffer, and also avoids some confusion between the two data stores---buffer and bo both are generic names. To match this, also rename "buffer_len" to "staging_buffer_len." Don't rename buffer_offset, as it's actually a bo offset. Signed-off-by: Kenneth Graunke -

[Mesa-dev] [PATCH 4/8] i965/upload: Refactor open-coded ALIGN-like computations.

Sadly, we can't use actual ALIGN(), since that only supports power-of-two values for the alignment parameter. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_upload.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/int

[Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

This code literally had zero comments, which made it impenetrable for basically everybody except the authors. We still ought to comment the refcounting strategy. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 24 +++ src/mesa/drivers/dri/i965/intel_upload.c |

[Mesa-dev] [PATCH 6/8] i965/upload: Drop use of GL types.

Using GL types outside of the GL API is silly. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_buffer_objects.h | 10 +- src/mesa/drivers/dri/i965/intel_upload.c | 18 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 3/8] i965: Expand comments in brw_upload_indices().

This function has three cases: 1. Data is in user arrays 2. Data is in a buffer object, but misaligned. 3. Data is acceptable as is. Previously, there was a "Turn into a proper VBO" comment above all three cases, even though it only applies to case 1, and maybe case 2 (with a specific interpretati

[Mesa-dev] [PATCH 7/8] i965/upload: Switch from < to <= in intel_upload_data().

intel_upload_data() uses <, while intel_upload_map() uses <=. Otherwise, the two blocks of code are identical. This appears to be a typo; we should be able to stage the exact amount of data that will fit in the staging buffer. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_u

[Mesa-dev] [PATCH 1/8] i965: Consolidate code for setting brw->ib.start_vertex_offset.

This was set identically in three places. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) This is just a series of tidying and commenting, for the most part. Patch 7 has an actual change. diff

[Mesa-dev] Wrong colors in 3D apps on big-endian systems

10.0.3 works with 3D acceleration. My system: Nemo board with a 1.8GHz dual core PA6T processer and an AMD Radeon HD 6870 graphics card. Mesa/standard (mesa-git-20140313): glxinfo | grep OpenGL libGL error: failed to load driver: r600 OpenGL vendor string: VMware, Inc. OpenGL renderer string

[Mesa-dev] [PATCH] i965: Delete "fast color clear unsupported" performance warning.

Applications frequently clear to colors other than 0.0 or 1.0, which prevents us from doing fast color clears. In that case, we issue this performance warning on basically every glClear call, resulting in so much spam that it's nearly impossible to see any other messages. Plus, I don't think it's

Re: [Mesa-dev] [PATCH 1/8] i965: Consolidate code for setting brw->ib.start_vertex_offset.

On Thu, Mar 13, 2014 at 01:57:09AM -0700, Kenneth Graunke wrote: > This was set identically in three places. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_draw_upload.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > This is just a series o

Re: [Mesa-dev] [RFC PATCH 3/4] mesa: Prefer non-swizzled formats when prefer_no_swizzle set

Chris Forbes writes: > Actually, after poking around a bit more, I think this is correct... > > As of Brian's commit 657436da7ee, the packed formats are described as > being laid out from the LSB. This is consistent with this patch, with > the pack/unpack code, and the hardware documentation: > >

Re: [Mesa-dev] Wrong colors in 3D apps on big-endian systems

the driver is not loading: $ LIBGL_DEBUG=verbose glxinfo | grep direct > > My system: Nemo board with a 1.8GHz dual core PA6T processer and an AMD > Radeon HD 6870 graphics card. > > Mesa/standard (mesa-git-20140313): > > glxinfo | grep OpenGL > > libGL error: failed

Re: [Mesa-dev] [PATCH 2/8] glsl: Add wrapper function that calls ir_dereference::constant_referenced

On Wed, Mar 12, 2014 at 07:20:04PM -0400, Connor Abbott wrote: > On Wed, Mar 12, 2014 at 6:49 PM, Ian Romanick wrote: > > From: Ian Romanick > > > > Signed-off-by: Ian Romanick > > --- > > src/glsl/ir_constant_expression.cpp | 52 > > + > > 1 file changed, 3

Re: [Mesa-dev] [PATCH 3/8] glsl: Fold implementation of ir_dereference_variable::constant_referenced into wrapper

On Wed, Mar 12, 2014 at 03:49:22PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/ir_constant_expression.cpp | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/src/glsl/ir_constant_expression.cp

[Mesa-dev] Wrong colors in 3D apps on big-endian systems

information on why the driver is not loading: $ LIBGL_DEBUG=verbose glxinfo | grep direct Hi Timothy, Thanks for the hint. I get some error messages: libGL: OpenDriver: trying /usr/local/mesa-git-20140313/lib/dri/r600_dri.so libGL: driver does not expose __driDriverGetExtensions_r600(): /usr

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

Ilia Mirkin writes: > Hi Francisco, > > I'm looking at some piglit failures on nv10... full run at > > http://people.freedesktop.org/~imirkin/nv10-comparison/problems.html > > The specific one is: > > http://people.freedesktop.org/~imirkin/nv10-comparison/nv18-imirkin/spec/!OpenGL%201.1/copytexim

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

On Thu, Mar 13, 2014 at 6:42 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> Hi Francisco, >> >> I'm looking at some piglit failures on nv10... full run at >> >> http://people.freedesktop.org/~imirkin/nv10-comparison/problems.html >> >> The specific one is: >> >> http://people.freedesktop.o

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

On Thu, Mar 13, 2014 at 6:43 AM, Ilia Mirkin wrote: > On Thu, Mar 13, 2014 at 6:42 AM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> Hi Francisco, >>> >>> I'm looking at some piglit failures on nv10... full run at >>> >>> http://people.freedesktop.org/~imirkin/nv10-comparison/problems.

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

On Thu, Mar 13, 2014 at 6:55 AM, Ilia Mirkin wrote: > On Thu, Mar 13, 2014 at 6:43 AM, Ilia Mirkin wrote: >> On Thu, Mar 13, 2014 at 6:42 AM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> Hi Francisco, I'm looking at some piglit failures on nv10... full run at

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

Ilia Mirkin writes: > On Thu, Mar 13, 2014 at 6:55 AM, Ilia Mirkin wrote: >> On Thu, Mar 13, 2014 at 6:43 AM, Ilia Mirkin wrote: >>> On Thu, Mar 13, 2014 at 6:42 AM, Francisco Jerez >>> wrote: Ilia Mirkin writes: > Hi Francisco, > > I'm looking at some piglit failures o

Re: [Mesa-dev] Z24S8 textures on nv04/nv10

On Thu, Mar 13, 2014 at 7:36 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Thu, Mar 13, 2014 at 6:55 AM, Ilia Mirkin wrote: >>> On Thu, Mar 13, 2014 at 6:43 AM, Ilia Mirkin wrote: On Thu, Mar 13, 2014 at 6:42 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >>>

[Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

EXT_packed_depth_stencil is supported by all drivers, but ARB_depth_texture isn't (notably nouveau_vieux). This should avoid passing unexpected values down to ChooseTextureFormat. The EXT_packed_depth_stencil spec does not make any explicit references to requiring ARB_depth_texture in order to all

Re: [Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

Ilia Mirkin writes: > EXT_packed_depth_stencil is supported by all drivers, but > ARB_depth_texture isn't (notably nouveau_vieux). This should avoid > passing unexpected values down to ChooseTextureFormat. > > The EXT_packed_depth_stencil spec does not make any explicit references > to requiring

Re: [Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

On Thu, Mar 13, 2014 at 9:22 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> EXT_packed_depth_stencil is supported by all drivers, but >> ARB_depth_texture isn't (notably nouveau_vieux). This should avoid >> passing unexpected values down to ChooseTextureFormat. >> >> The EXT_packed_depth_s

Re: [Mesa-dev] [PATCH 0/7] EGL_MESA_configless_context

Kristian Høgsberg writes: > Thanks Neil, series applied to mesa and weston. Great, thanks! I've reposted the piglit patch to the piglit list in case someone wants to review it there. Regards, - Neil ___ mesa-dev mailing list mesa-dev@lists.freedeskto

[Mesa-dev] [PATCH 2/8] egl: Protect use of gbm_dri with ifdef HAVE_DRM_PLATFORM

From: Ander Conselvan de Oliveira Otherwise it fails to compile if the drm egl platform is disabled. --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 892f1f4..2e8f01b 100644 --- a/src

[Mesa-dev] [PATCH 1/8] egl/drm: Rename dri2_egl_surface field gbm_surf to gbm_dri_surf

From: Ander Conselvan de Oliveira It actually contains a pointer to a gbm_dri_surface, so use a more appropriate name. --- src/egl/drivers/dri2/egl_dri2.h | 2 +- src/egl/drivers/dri2/platform_drm.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dr

[Mesa-dev] [PATCH 7/8] egl/dri: Add gbm platform

From: Ander Conselvan de Oliveira This adds a GBM platform that works with native gbm backends, such as the intel backend. --- configure.ac| 7 +- src/egl/drivers/dri2/Makefile.am| 5 + src/egl/drivers/dri2/egl_dri2.c | 6 + src/egl/drivers/dri2/egl_dri2.h

[Mesa-dev] [PATCH 0/8] Native GBM backends and map/unmap support

From: Ander Conselvan de Oliveira Hi, This patch series implements an API for mapping an unapping GBM buffer objects. The native intel backend was implemented so that the map and unmap functionality wouldn't have to be implemented in the DRI image extension. A new EGL platform is necessary, sinc

[Mesa-dev] [PATCH 4/8] gbm_drm: Keep a reference to drm native objects

From: Ander Conselvan de Oliveira Add bo and bufmgr fields to gbm_drm_bo and gbm_drm_device respectively. --- src/gbm/backends/intel/gbm_intel.c | 4 src/gbm/main/common_drm.h | 6 ++ 2 files changed, 10 insertions(+) diff --git a/src/gbm/backends/intel/gbm_intel.c b/src/gbm/

[Mesa-dev] [PATCH 5/8] dri, i965: Add an extension for sharing the drm bufmgr

From: Ander Conselvan de Oliveira If the fd used by the DRI driver is going to be shared with something else, like gbm, this lets the loader pass the bufmgr struct so it is shared too. --- include/GL/internal/dri_interface.h | 11 +++ src/egl/drivers/dri2/egl_dri2.h | 3 ++

[Mesa-dev] [PATCH 6/8] dri, i965: Add entry point for creating image from native handle

From: Ander Conselvan de Oliveira The native handle is a pointer to drm_intel_bo for the i965 driver. --- include/GL/internal/dri_interface.h | 13 +++- src/mesa/drivers/dri/i965/intel_regions.c | 50 ++- src/mesa/drivers/dri/i965/intel_regions.h | 6

[Mesa-dev] [PATCH 8/8] gbm: Add entry points for mapping and unmapping bos

From: Ander Conselvan de Oliveira Add gbm_bo_map() and gbm_bo_unmap(). This lets a user access the contents of a bo using the CPU. --- src/gbm/backends/dri/gbm_dri.c | 3 +++ src/gbm/backends/intel/gbm_intel.c | 24 src/gbm/backends/intel/gbm_intel.h | 2 ++ src/gb

[Mesa-dev] [PATCH 3/8] gbm: Add a native intel backend

From: Ander Conselvan de Oliveira --- src/gbm/Makefile.am| 14 ++- src/gbm/backends/intel/gbm_intel.c | 241 + src/gbm/backends/intel/gbm_intel.h | 74 src/gbm/main/backend.c | 2 + src/gbm/main/common_drm.h

Re: [Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

On 03/13/2014 07:33 AM, Ilia Mirkin wrote: On Thu, Mar 13, 2014 at 9:22 AM, Francisco Jerez wrote: Ilia Mirkin writes: EXT_packed_depth_stencil is supported by all drivers, but ARB_depth_texture isn't (notably nouveau_vieux). This should avoid passing unexpected values down to ChooseTextureF

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: return v.value_int64 when the requested type is TYPE_INT64

On 03/13/2014 02:31 AM, Emil Velikov wrote: Fixes "Operands don't affect result" defect reported by Coverity. Cc: "9.2 10.0 10.1" Signed-off-by: Emil Velikov --- src/mesa/main/get.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/mai

Re: [Mesa-dev] removal of _glthread_GetID() breaks libglapi.so's ABI

On 03/12/2014 11:31 PM, Chia-I Wu wrote: Hi Brian, _glthread_GetID() was removed by this commit commit 02cb04c68ffbdaffaf7513ddc951584cac29f209 Author: Brian Paul Date: Tue Mar 4 15:24:16 2014 -0700 mesa: remove remaining uses of _glthread_GetID() It turns out the function, declared i

Re: [Mesa-dev] [PATCH] winsys/radeon: Store GPU virtual memory addresses of BOs in a hash table

Reviewed-by: Marek Olšák Marek On Thu, Mar 13, 2014 at 9:34 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This allows retrieving the existing BO and incrementing its reference count, > instead of creating a separate winsys representation for it, when the kernel > reports that the BO was a

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Add DMA ring

On Thu, Mar 13, 2014 at 8:45 AM, Niels Ole Salscheider wrote: > Signed-off-by: Niels Ole Salscheider > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ > src/gallium/drivers/radeonsi/si_pipe.c | 22 ++ > 2 files changed, 25 insertions(+) > > diff --git a/src

Re: [Mesa-dev] [Mesa-stable] [PATCH V2] mesa: Fix glGetVertexAttribi(GL_VERTEX_ATTRIB_ARRAY_SIZE)

I like this fix much better. Reviewed-by: Ian Romanick On 03/12/2014 06:20 PM, Anuj Phogat wrote: > mesa currently returns 4 when GL_VERTEX_ATTRIB_ARRAY_SIZE is queried > for a vertex array initially set up with size=GL_BGRA. This patch > makes changes to return size=GL_BGRA as required by the s

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: return v.value_int64 when the requested type is TYPE_INT64

On 03/13/2014 01:31 AM, Emil Velikov wrote: > Fixes "Operands don't affect result" defect reported by Coverity. D'oh. So... we obviously don't have any piglit tests that hit these cases. Would you mind whipping up something simple? > Cc: "9.2 10.0 10.1" > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

On 03/13/2014 06:33 AM, Ilia Mirkin wrote: > On Thu, Mar 13, 2014 at 9:22 AM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> EXT_packed_depth_stencil is supported by all drivers, but >>> ARB_depth_texture isn't (notably nouveau_vieux). This should avoid >>> passing unexpected values down

Re: [Mesa-dev] [PATCH 2/8] glsl: Add wrapper function that calls ir_dereference::constant_referenced

On 03/12/2014 04:20 PM, Connor Abbott wrote: > On Wed, Mar 12, 2014 at 6:49 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/glsl/ir_constant_expression.cpp | 52 >> + >> 1 file changed, 36 insertions(+), 16 delet

Re: [Mesa-dev] [PATCH] mesa/main: condition GL_DEPTH_STENCIL on ARB_depth_texture

On Thu, Mar 13, 2014 at 11:40 AM, Ian Romanick wrote: > On 03/13/2014 06:33 AM, Ilia Mirkin wrote: >> On Thu, Mar 13, 2014 at 9:22 AM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> EXT_packed_depth_stencil is supported by all drivers, but ARB_depth_texture isn't (notably nouve

Re: [Mesa-dev] [PATCH 3/8] i965: Expand comments in brw_upload_indices().

On 03/13/2014 01:57 AM, Kenneth Graunke wrote: > This function has three cases: > 1. Data is in user arrays > 2. Data is in a buffer object, but misaligned. > 3. Data is acceptable as is. > > Previously, there was a "Turn into a proper VBO" comment above all three > cases, even though it only appl

Re: [Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

On 03/13/2014 01:57 AM, Kenneth Graunke wrote: > diff --git a/src/mesa/drivers/dri/i965/intel_upload.c > b/src/mesa/drivers/dri/i965/intel_upload.c > index ec3109b..c767b7d 100644 > --- a/src/mesa/drivers/dri/i965/intel_upload.c > +++ b/src/mesa/drivers/dri/i965/intel_upload.c > @@ -25,7 +25,16 @@

Re: [Mesa-dev] [PATCH 1/8] i965: Consolidate code for setting brw->ib.start_vertex_offset.

Patches 1, 2, 4, 6, 7, and 8 are Reviewed-by: Ian Romanick I separately sent some questions about 3 and 5. On 03/13/2014 01:57 AM, Kenneth Graunke wrote: > This was set identically in three places. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_draw_upload.c | 15 ++

Re: [Mesa-dev] [PATCH] i965: Delete "fast color clear unsupported" performance warning.

On 03/13/2014 02:41 AM, Kenneth Graunke wrote: > Applications frequently clear to colors other than 0.0 or 1.0, which > prevents us from doing fast color clears. In that case, we issue this > performance warning on basically every glClear call, resulting in so > much spam that it's nearly impossib

Re: [Mesa-dev] [PATCH 1/4] dri3: Fix indentation of buffer age code

Am 2014-03-08 02:26, schrieb Eric Anholt: --- Here's my series of cleanups and fixes for your EXT_buffer_age patch. I've run it through piglit, and run gnome-shell with it now. I'm proposing moving patch 3 before your patch, then squashing 1, 2, and 4 in with yours. Does this sound good? Hi,

[Mesa-dev] [PATCH] nouveau: add fogotten GL_COMPRESSED_INTENSITY to texture format list

Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/nouveau/nouveau_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_texture.c b/src/mesa/drivers/dri/nouveau/nouveau_texture.c index a8c0268..ae8dbd4 100644 --- a/src/mesa/drivers/dri/nouveau/nouve

[Mesa-dev] glx: Fix incorrect pdp assignment in dri2_bind_context().

My coworker found this issue while testing with glretrace. Looks correct to me but I'd like another reviewer (Kristian?) -Brian Original Message Subject: [Review Request] glx: Fix incorrect pdp assignment in dri2_bind_context(). Date: Thu, 13 Mar 2014 10:16:31 -0700 From: C

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

Ian Romanick writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/05/2014 01:00 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> From: Gregory Hainaut >>> >>> Implementation note: I don't use context for ralloc (don't know >>> how). >>> >>> The check on PROGRAM_SEPARABLE

Re: [Mesa-dev] [PATCH] nouveau: add fogotten GL_COMPRESSED_INTENSITY to texture format list

Ilia Mirkin writes: > Signed-off-by: Ilia Mirkin Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/nouveau/nouveau_texture.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/nouveau/nouveau_texture.c > b/src/mesa/drivers/dri/nouveau/nouveau_texture.c > i

Re: [Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

On 03/13/2014 09:05 AM, Ian Romanick wrote: > On 03/13/2014 01:57 AM, Kenneth Graunke wrote: >> diff --git a/src/mesa/drivers/dri/i965/intel_upload.c >> b/src/mesa/drivers/dri/i965/intel_upload.c >> index ec3109b..c767b7d 100644 >> --- a/src/mesa/drivers/dri/i965/intel_upload.c >> +++ b/src/mesa/d

Re: [Mesa-dev] [PATCH 07/12] mesa/sso: Implement _mesa_UseProgramStages

Ian Romanick writes: > On 03/05/2014 12:35 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> From: Gregory Hainaut >>> >>> Now arb_separate_shader_object-GetProgramPipelineiv should pass. >>> >>> V3 (idr): >>> * Change spec references to core OpenGL versions instead of issues in >>> the

[Mesa-dev] [PATCH 1/2] radeon: Move DMA ring creation to common code

Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/r600/r600_pipe.c | 30 - src/gallium/drivers/r600/r600_pipe.h | 1 - src/gallium/drivers/radeon/r600_pipe_common.c | 32 +++ src/gallium/drivers/radeon/r600_pipe_common.

[Mesa-dev] [PATCH 2/2] radeonsi: flush the dma ring in si_flush_from_st

Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeonsi/si_pipe.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 827e9fe..401bf6a 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c ++

Re: [Mesa-dev] [PATCH] i965: Don't enable reset notification support on Gen4-5.

Ian Romanick writes: > On 03/12/2014 01:43 AM, Kenneth Graunke wrote: >> arekm reported that using Chrome with GPU acceleration enabled on GM45 >> triggered the hw_ctx != NULL assertion in brw_get_graphics_reset_status. >> >> We definitely do not want to advertise reset notification support on >

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: return v.value_int64 when the requested type is TYPE_INT64

On 13/03/14 15:31, Ian Romanick wrote: On 03/13/2014 01:31 AM, Emil Velikov wrote: Fixes "Operands don't affect result" defect reported by Coverity. D'oh. So... we obviously don't have any piglit tests that hit these cases. Would you mind whipping up something simple? Considering that these

Re: [Mesa-dev] [PATCH] i965: Enable EWA anisotropic filtering algorithm

On 03/04/2014 01:08 AM, Ian Romanick wrote: > From: Ian Romanick > > Volume 4, part 1 of the Ivybridge PRM says, "Generally, the EWA > approximation algorithm results in higher image quality than the legacy > algorithm." Using a classic anisotropic filtering "tunnel" demo, it > appears that ther

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: Allow overlapping locations for vertex input attributes

On Tue, Mar 11, 2014 at 10:37 AM, Ian Romanick wrote: > On 03/10/2014 04:15 PM, Anuj Phogat wrote: > > > > > > > > On Mon, Mar 10, 2014 at 3:27 PM, Ian Romanick > > wrote: > > > > On 03/10/2014 11:19 AM, Anuj Phogat wrote: > > > Currently overlapping location

Re: [Mesa-dev] [PATCH] i965: Enable EWA anisotropic filtering algorithm

On 03/13/2014 03:30 PM, Kenneth Graunke wrote: > On 03/04/2014 01:08 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> Volume 4, part 1 of the Ivybridge PRM says, "Generally, the EWA >> approximation algorithm results in higher image quality than the legacy >> algorithm." Using a classic anisot

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: > Previously, both move_uniform_array_access_to_pull_constants() and > setup_pull_constants() maintained stack-local arrays with this > information. Storing this information will allow it to be used from > multiple functions, allowin

Re: [Mesa-dev] Wrong colors in 3D apps on big-endian systems

On Don, 2014-03-13 at 10:38 +0100, Christian Zigotzky wrote: > On 12.03.2014 05:35, Michel Dänzer wrote: > > > > Do the attached patches help? > > Thank you very much for your effort. I've patched the latest git version > with your patches. Mesa works with the right colors but it doesn't have >

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

On 03/13/2014 05:55 PM, Pohjolainen, Topi wrote: > On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: >> Previously, both move_uniform_array_access_to_pull_constants() and >> setup_pull_constants() maintained stack-local arrays with this >> information. Storing this information will

Re: [Mesa-dev] i965 GL_ARB_buffer_storage

On 02/27/2014 02:52 PM, Eric Anholt wrote: > One thing I noticed while working on this was that we only reallocate buffer > storage for INVALIDATE_BUFFER_BIT when UNSYNCHRONIZED_BIT is unset. The > ARB_mbr spec says that the contents "may be discarded", not "must be > discarded". However, while w