Re: [Mesa-dev] [PATCH 4/4] glsl: Change locations from yylloc to appropriate tokens positions.

On 02/06/2014 12:40 PM, Carl Worth wrote: > Sir Anthony writes: >> This is tough question, I thought about it some time and concluded >> that some function class must include body range, otherwise there will >> be no easy way to get function end > > Good. That's all I wanted to hear, that you ha

Re: [Mesa-dev] [PATCH] glcpp: Do not remove spaces to preserve locations.

On 02/05/2014 06:15 AM, Sir Anthony wrote: > After preprocessing by glcpp all adjacent spaces were replaced by > single one and glsl parser received column-shifted shader source. > It negatively affected ast location set up and produced wrong error > messages for heavily-spaced shaders. Pushed!

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

On 02/05/2014 04:30 PM, Ian Romanick wrote: > On 02/05/2014 01:07 PM, Fabian Bieler wrote: >> The hardcoded numbers are a few lines off at the moment. >> Keeping track of the numbers through further modifications is inconvenient. >> The __LINE__ "constant" takes care of this automatically. >> >> Si

Re: [Mesa-dev] [PATCH] automake: make clean the correct git_sha1.h.tmp

On 03/05/2014 05:04 AM, Emil Velikov wrote: > When building out of tree, the file ends up dangling which > may result in a binary with the old git sha. > > Signed-off-by: Emil Velikov > --- > src/mesa/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/

[Mesa-dev] [PATCH 1/3] radeon/vce: fix memory leak

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_vce.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 665c1dc..0d3fe08 100644 --- a/src/gallium/drivers/radeon/

[Mesa-dev] [PATCH 2/3] radeonsi: fix leaking the bound state on destruction

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pm4.c | 7 +++ src/gallium/drivers/radeonsi/si_pm4.h | 1 + 3 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src

[Mesa-dev] [PATCH 3/3] radeonsi: fix leaking the null constant buffer

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_pipe.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 5bc86bb..7e8e09b 100644 --- a/src

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

On Sat, Mar 8, 2014, at 11:13 AM, Kenneth Graunke wrote: > On 02/05/2014 04:30 PM, Ian Romanick wrote: > > On 02/05/2014 01:07 PM, Fabian Bieler wrote: > >> The hardcoded numbers are a few lines off at the moment. > >> Keeping track of the numbers through further modifications is inconvenient. > >>

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix leaking the null constant buffer

si_release_all_descriptors does this already. Marek On Sat, Mar 8, 2014 at 1:21 PM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/si_pipe.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --gi

Re: [Mesa-dev] [PATCH 1/3] radeon/vce: fix memory leak

For patch 1 & 2: Reviewed-by: Marek Olšák Marek On Sat, Mar 8, 2014 at 1:21 PM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeon/radeon_vce.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix leaking the null constant buffer

Strange, than this doesn't seems to work. I get valgrind warning that this is still allocated. Christian. Am 08.03.2014 13:52, schrieb Marek Olšák: si_release_all_descriptors does this already. Marek On Sat, Mar 8, 2014 at 1:21 PM, Christian König wrote: From: Christian König Signed-off-

[Mesa-dev] [PATCH 3/4] radeonsi: fix leaking the bound state on destruction v2

From: Christian König v2: rebased on stale pointer fixes Signed-off-by: Christian König Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pm4.c | 7 +++ src/gallium/drivers/radeonsi/si_pm4.h | 1 + 3 files changed, 10 insertions(

[Mesa-dev] [PATCH 4/4] radeonsi: fix freeing descriptor buffers

From: Christian König That structure member is a pointer, so the loop with the Elements macro only freed up the first entry. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 2/4] radeonsi: avoid stale state pointers

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_pipe.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index ff11a67..ac9e49a 100644 --- a/s

[Mesa-dev] [PATCH 1/4] radeonsi: avoid stale pointers in si_delete_shader_selector

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_state.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 8f9..0ee4154 100644 --- a/src/g

Re: [Mesa-dev] [PATCH 1/4] radeonsi: avoid stale pointers in si_delete_shader_selector

Yeah, you found the correct fix for the null constant buffer leak. For the series: Reviewed-by: Marek Olšák Marek On Sat, Mar 8, 2014 at 2:54 PM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/si_state.c | 7 ++- >

Re: [Mesa-dev] [PATCH] fix vdpau interop when using -Bsymbolic-functions in ldflags

op 07-03-14 17:33, Emil Velikov schreef: On 06/03/14 09:56, Maarten Lankhorst wrote: Explicitly add radeon_drm_winsys_create and nouveau_drm_screen_create to the dynamic list. This will ensure vdpau interop still works even when the user links with -Bsymbolic-functions in hardened builds. With

[Mesa-dev] [Bug 75913] New: Add support DRI_PRIME to drirc

https://bugs.freedesktop.org/show_bug.cgi?id=75913 Priority: medium Bug ID: 75913 Assignee: mesa-dev@lists.freedesktop.org Summary: Add support DRI_PRIME to drirc Severity: enhancement Classification: Unclassified OS: All

[Mesa-dev] [Bug 75913] Add support DRI_PRIME to drirc

https://bugs.freedesktop.org/show_bug.cgi?id=75913 commiethebeas...@gmail.com changed: What|Removed |Added CC||commiethebeas...@gmail.com -

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

On 03/08/2014 04:24 AM, Fabian Bieler wrote: > On Sat, Mar 8, 2014, at 11:13 AM, Kenneth Graunke wrote: >> On 02/05/2014 04:30 PM, Ian Romanick wrote: >>> On 02/05/2014 01:07 PM, Fabian Bieler wrote: The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers thr

[Mesa-dev] [PATCHv2 02/20] automake: silence folder creation

There is little gain in printing whenever a folder is created. v2: - Use $(AM_V_at) over @ to have control in verbose builds. Suggested by Erik Faye-Lund. Signed-off-by: Emil Velikov Reviewed-by: Jon TURNEY --- src/gallium/auxiliary/Makefile.am | 8 src/glsl/Makefile.am

[Mesa-dev] [PATCHv2 03/20] automake: use only the folder name if it's a subfolder of the present one

v2: Resolve rebase conflicts. Signed-off-by: Emil Velikov Reviewed-by: Jon TURNEY --- src/glsl/Makefile.am | 4 ++-- src/mesa/Makefile.am | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index c703317..8516459 100644 --- a/src/

[Mesa-dev] [PATCHv2 06/20] automake: introduce install-gallium-links.mk

This helper script will be used to minimise the duplication during link generation across all gallium targets. v2: - Handle vdpau_LTLIBRARIES. Requested by Christian König. Signed-off-by: Emil Velikov Reviewed-by: Jon TURNEY --- install-gallium-links.mk | 23 +++ 1 file ch

[Mesa-dev] [PATCH 07.1/20] targets/vdpau: use install-gallium-links.mk

Drop the duplication across all vdpau targets. Signed-off-by: Emil Velikov --- src/gallium/targets/r600/vdpau/Makefile.am | 6 +- src/gallium/targets/radeonsi/vdpau/Makefile.am | 6 +- src/gallium/targets/vdpau-nouveau/Makefile.am | 6 +- 3 files changed, 3 insertions(+), 15 del

[Mesa-dev] [PATCHv2 09/20] gallium/targets: drop link generation for non DRI targets

All three (xvmc and omx) do not have an alternative loading similar to the dri modules. Thus one needs to explicitly install them in order to use/test them. v2: - Keep vdpau targets, as an equivalent of LIBGL_DRIVERS_PATH is being worked on. Signed-off-by: Emil Velikov Reviewed-by: Jon TURNEY

[Mesa-dev] [PATCHv2 14/20] automake: create compat symlinks only for linux systems

The primary users of these are linux developers, although it can be extended for *BSD and others if needed. Fixes make install for Cygwin and OpenBSD at least. v2: - Wrap vdpau targets as well. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63269 Signed-off-by: Emil Velikov Reviewed-by

Re: [Mesa-dev] [PATCH 00/20] Automake cleanups and Cygwin fixes

On 04/03/14 21:12, Emil Velikov wrote: > Hi all, > > An interesting cleanup series inspired by Jon Turney's tinderbox. > > Highlights: > - Cleanup unused configure.ac variables dating from the static makefile days. > - Use platform specific library extension for links generation. > - Move all

Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

On 03/03/14 17:31, Julien Cristau wrote: > On Mon, Mar 3, 2014 at 17:29:56 +, Emil Velikov wrote: > >> On 03/03/14 17:23, Julien Cristau wrote: >>> On Mon, Mar 3, 2014 at 17:21:15 +, Emil Velikov wrote: >>> On 03/03/14 16:41, Julien Cristau wrote: > It's only used in this one fi

[Mesa-dev] [PATCH 2/3] i965: Disassemble 3 src instructions' rep_ctrl field.

--- src/mesa/drivers/dri/i965/brw_disasm.c | 15 --- src/mesa/drivers/dri/i965/gen8_disasm.c | 15 --- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c index 913e04d..d79e750 10

[Mesa-dev] [PATCH 1/3] i965: Disassemble 3-src operands widths' correctly.

<4,1,1> isn't a real thing. We meant <4,4,1>, i.e., each component of the whole register. --- src/mesa/drivers/dri/i965/brw_disasm.c | 6 +-- .../drivers/dri/i965/brw_schedule_instructions.cpp | 16 src/mesa/drivers/dri/i965/gen8_disasm.c| 6 +-- .../drivers/dri/

[Mesa-dev] [PATCH 3/3] i965/vec4: Don't fix-up scalar uniforms for 3 src instructions.

Removes unnecessary MOV instructions in L4D2, TF2, Dota2, and many other Steam games. total instructions in shared programs: 1668126 -> 1657509 (-0.64%) instructions in affected programs: 242235 -> 231618 (-4.38%) --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 +++ 1 file changed, 3 i

[Mesa-dev] [Bug 75919] New: LLVM changed output of llvm-config, again

https://bugs.freedesktop.org/show_bug.cgi?id=75919 Priority: medium Bug ID: 75919 Assignee: mesa-dev@lists.freedesktop.org Summary: LLVM changed output of llvm-config, again Severity: normal Classification: Unclassified OS: L

Re: [Mesa-dev] [PATCH 3/3] i965/vec4: Don't fix-up scalar uniforms for 3 src instructions.

On 03/08/2014 12:46 PM, Matt Turner wrote: > Removes unnecessary MOV instructions in L4D2, TF2, Dota2, and many other > Steam games. > > total instructions in shared programs: 1668126 -> 1657509 (-0.64%) > instructions in affected programs: 242235 -> 231618 (-4.38%) > --- > src/mesa/drivers/d

Re: [Mesa-dev] [PATCHv2 09/20] gallium/targets: drop link generation for non DRI targets

On Sat, Mar 8, 2014 at 3:31 PM, Emil Velikov wrote: > All three (xvmc and omx) do not have an alternative loading > similar to the dri modules. Thus one needs to explicitly install > them in order to use/test them. Not strictly true... I mean, I install anyway because it's easier for me, but xvmc

[Mesa-dev] [PATCH 1/4] mesa: s/GLhandleARB/GLuint/ for glGetUniform functions

The GL specs say the parameter is GLuint, not GLhandleARB. --- src/mapi/glapi/gen/ARB_robustness.xml |8 src/mesa/main/uniform_query.cpp |6 +++--- src/mesa/main/uniforms.c | 20 ++-- src/mesa/main/uniforms.h | 24 ---

[Mesa-dev] [PATCH 4/4] mesa: stop aliasing ARB and core shader API functions

For example, we now we have separate dispatch functions for glCompileShader(GLuint) and glCompileShaderARB(GLhandleARB). With this change and the previous ones we should be able to build/run on MacOS again (where GLhandleARB is a void pointer, not a GLuint). Bugzilla: https://bugs.freedesktop.org

[Mesa-dev] [PATCH 3/4] mesa: untangle GLhandleARB vs. GLuint usage

Create separate core (GLuint) and ARB (GLhandleARB) shader functions. For example: we previously had: _mesa_CompileShader(GLhandleARB shader) Now there's two functions: _mesa_CompileShader(GLuint shader) _mesa_CompileShaderARB(GLhandleARB shader) In most cases, the later now simply calls the fo

[Mesa-dev] [PATCH 2/4] meta: use non-ARB shader/program create/delete functions

The non-ARB versions take GLuint ids, not GLhandleARB. --- src/mesa/drivers/common/meta.c | 54 +-- src/mesa/drivers/common/meta_blit.c |6 ++-- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/dri

[Mesa-dev] [PATCH 2/3] r600g,radeonsi: fix broken buffer download

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index a7ecfb3..d56a644 100644 --- a/src/gallium/drivers/rad

[Mesa-dev] [PATCH 1/3] r600g, radeonsi: use a fallback in dma_copy instead of failing

From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c | 37 +--- src/gallium/drivers/r600/r600_state.c | 41 ++--- src/gallium/drivers/radeon/r600_buffer_common.c | 58 +++-- src/gallium/drivers/radeon/r600_pipe_common.h | 1

[Mesa-dev] [PATCH 3/3] r600g, radeonsi: attempt to fix racy multi-context apps calling BufferData

From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75061 --- src/gallium/drivers/r600/r600_state_common.c| 5 + src/gallium/drivers/radeon/r600_buffer_common.c | 20 +++- src/gallium/drivers/radeonsi/si_descriptors.c | 5 + 3 files changed, 1

[Mesa-dev] [PATCH 3/3] mesa: rename MESA_FORMAT_X8Z24_UNORM -> MESA_FORMAT_X8_UINT_Z24_UNORM

To follow the example of MESA_FORMAT_Z24_UNORM_X8_UINT. --- src/mesa/drivers/dri/i965/brw_surface_formats.c |2 +- src/mesa/drivers/dri/nouveau/nouveau_util.h |2 +- src/mesa/main/format_pack.c | 12 ++-- src/mesa/main/format_unpack.c |

[Mesa-dev] [PATCH 1/3] mesa: trim down format.h comments

There's no real reason to list all the formats in the comments. --- src/mesa/main/formats.h | 169 --- 1 file changed, 169 deletions(-) diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h index a12fe4f..89bb24f 100644 --- a/src/mesa/main/for

[Mesa-dev] [PATCH 0/3] formats.h clean-ups

This patch series: 1. removes an unnecessary section of comments. 2. Reorders the MESA_FORMAT_x enums to be more logical. 3. Renames MESA_FORMAT_X8Z24_UNORM Since it's hard to read from the diff, here's how the relevant part of formats.h looks afterward (omitting a big comment block at the top