Re: [Mesa-dev] [PATCH] loader: Allow a non-udev linux fallback

2014-02-07 Thread Lauri Kasanen
On Fri, 07 Feb 2014 01:20:39 + Emil Velikov wrote: > > The argument is "this setup worked, and was supported, for 10 years > > now". You don't break supported setups without good reason. > > > FWIW I'm in favour of not breaking existing setups without any serious > reason. Current patch look

[Mesa-dev] [Bug 69101] prime: black window

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 Mike Lothian changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] Flatland

2014-02-07 Thread Timothy Arceri
For those interested Ian's talk is available here: http://video.fosdem.org/2014/H1301_Cornil/Saturday/Three_Years_Experience_with_a_Treelike_Shader_IR.webm On Fri, 2014-02-07 at 00:34 -0500, Connor Abbott wrote: > Hi, > > So I believe that we can all agree that the tree-based representation > tha

Re: [Mesa-dev] [PATCH 1/4] r600g, radeonsi: force VRAM placement for DRI2 buffers

2014-02-07 Thread Marek Olšák
On Fri, Feb 7, 2014 at 3:55 AM, Michel Dänzer wrote: > On Mon, 2014-02-03 at 18:07 +0100, Marek Olšák wrote: >> Do you mean something like: >> >> write_domains = VRAM >> read_domains = VRAM | GTT >> >> I don't think it's perfect. > > That's what I meant, and of course it's not perfect. :) > > >> W

[Mesa-dev] [PATCH 1/9] glx: Add missing null checks in glxcmds.c

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxcmds.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index b5377c2..38a5262 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -385,7 +385,9 @@ glXCre

[Mesa-dev] [PATCH 0/9] Klocwork related patches

2014-02-07 Thread Juha-Pekka Heikkila
1..5 are previously submitted patches which seem to have been lost in the list, just resubmitting them here. Other patches are new. Juha-Pekka Heikkila (9): glx: Add missing null checks in glxcmds.c glx: Add missing null check in __glXCloseDisplay glsl: Fix null access on file read error g

[Mesa-dev] [PATCH 4/9] glx: Add some missing null checks in glx_pbuffer.c

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glx_pbuffer.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 183fbaa..411d6e5 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -60,7 +60,7

[Mesa-dev] [PATCH 6/9] i965: Add missing null check in fs_visitor::dead_code_eliminate_local()

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index c290c28..217892a 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/

[Mesa-dev] [PATCH 8/9] egl: Unhide functionality in _eglInitContext()

2014-02-07 Thread Juha-Pekka Heikkila
_eglInitResource() was used to memset entire _EGLContext by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLContext, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila --- src/egl/main/eglcontext.c | 3 ++- 1 file changed

[Mesa-dev] [PATCH 3/9] glsl: Fix null access on file read error

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index 5ea57d5..3a0f812 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -232,7 +232,7 @@ load_text_file(void *ctx, const ch

[Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

2014-02-07 Thread Juha-Pekka Heikkila
ir_constant::ir_constant(const struct glsl_type, const ir_constant_data *) was copying too much memory. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/ir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 1a36bd6..abc5568 100644 --- a

[Mesa-dev] [PATCH 2/9] glx: Add missing null check in __glXCloseDisplay

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 2711e57..4a195bd 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -269,7 +269,8 @@ __glXCloseDisplay(Display * dpy, XExtCo

[Mesa-dev] [PATCH 9/9] egl: Unhide functionality in _eglInitSurface()

2014-02-07 Thread Juha-Pekka Heikkila
_eglInitResource() was used to memset entire _EGLSurface by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLSurface, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila --- src/egl/main/eglsurface.c | 4 +++- 1 file change

[Mesa-dev] [PATCH 7/9] glx: Add missing null check in __glX_send_client_info()

2014-02-07 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/clientinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/clientinfo.c b/src/glx/clientinfo.c index e90fd79..8f3fdeb 100644 --- a/src/glx/clientinfo.c +++ b/src/glx/clientinfo.c @@ -113,6 +113,10 @@ __glX_send_client_info(struct gl

[Mesa-dev] [PATCH 1/2] gallium/tgsi: use CLAMP instead of open-coded clamps

2014-02-07 Thread Erik Faye-Lund
Signed-off-by: Erik Faye-Lund --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index 3d37eaa..96809cd 100644 --- a/src/gallium

[Mesa-dev] [PATCH 2/2] gallium/tgsi: correct typo propagated from NV_vertex_program1_1

2014-02-07 Thread Erik Faye-Lund
In the specification text of NV_vertex_program1_1, the upper limit of the RCC instruction is written as 1.884467e+19 in scientific notation, but as 0x5F80 in binary. But the binary version translates to 1.84467e+19 rather than 1.884467e+19 in scientific notation. Since the lower-limit equals 2

Re: [Mesa-dev] [PATCH] gallium/tgsi: correct typo propagated from NV_vertex_program1_1

2014-02-07 Thread Erik Faye-Lund
On Thu, Feb 6, 2014 at 5:30 PM, Brian Paul wrote: > On 02/06/2014 09:09 AM, Erik Faye-Lund wrote: >> >> In the specification text of NV_vertex_program1_1, the upper >> limit of the RCC instruction is written as 1.884467e+19 in >> scientific notation, but as 0x5F80 in binary. But the binary >>

[Mesa-dev] [Bug 69101] prime: black window

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 --- Comment #21 from Alexander Mezin --- Yes, unigine valley renders fully transparent window with OpenGL compositing, and everything works fine with XRender. Also, looks like first launched windowed application still renders black window. If I

Re: [Mesa-dev] [PATCH 0/9] Klocwork related patches

2014-02-07 Thread Brian Paul
On 02/07/2014 05:43 AM, Juha-Pekka Heikkila wrote: 1..5 are previously submitted patches which seem to have been lost in the list, just resubmitting them here. Other patches are new. Juha-Pekka Heikkila (9): glx: Add missing null checks in glxcmds.c glx: Add missing null check in __glXClos

Re: [Mesa-dev] [PATCH 1/2] gallium/tgsi: use CLAMP instead of open-coded clamps

2014-02-07 Thread Erik Faye-Lund
On Fri, Feb 7, 2014 at 4:15 PM, Brian Paul wrote: > On 02/07/2014 05:45 AM, Erik Faye-Lund wrote: >> >> Signed-off-by: Erik Faye-Lund >> --- >> src/gallium/auxiliary/tgsi/tgsi_exec.c | 26 -- >> 1 file changed, 4 insertions(+), 22 deletions(-) >> >> diff --git a/src/gal

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Roland Scheidegger
Am 07.02.2014 04:37, schrieb Dave Airlie: > On Fri, Feb 7, 2014 at 12:36 PM, Roland Scheidegger > wrote: >> Am 07.02.2014 02:56, schrieb Ilia Mirkin: >>> On Thu, Feb 6, 2014 at 8:52 PM, Dave Airlie wrote: From: Dave Airlie This just adds the TG4 opcode, and a CAP for the max

[Mesa-dev] [PATCH] R600/SI: Custom select 64-bit ADD

2014-02-07 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/AMDGPUISelDAGToDAG.cpp | 48 ++ lib/Target/R600/SIISelLowering.cpp | 29 lib/Target/R600/SIISelLowering.h | 1 - test/CodeGen/R600/add.ll | 10 +++ test/CodeGen/R600/add_i64.l

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 Alex Deucher changed: What|Removed |Added Summary|Missing trees in flightgear |Missing trees in flightgear

Re: [Mesa-dev] Flatland

2014-02-07 Thread Alex Deucher
On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott wrote: > Hi, > > So I believe that we can all agree that the tree-based representation > that GLSL IR currently uses for shaders needs to go. For the benefit > of those that didn't watch Ian Romanick's talk at FOSDEM, I'll > reiterate some of the prob

Re: [Mesa-dev] files out of date

2014-02-07 Thread Alex Deucher
On Thu, Feb 6, 2014 at 7:08 PM, Joey Reid wrote: > the folder: > http://www.x.org/docs/AMD/ > > has an outdated version of Southern Islands Series Instruction Set > Architecture. The latest version can be found here: > http://developer.amd.com/wordpress/media/2012/12/AMD_Southern_Islands_Instructi

Re: [Mesa-dev] Flatland

2014-02-07 Thread Erik Faye-Lund
On Fri, Feb 7, 2014 at 6:34 AM, Connor Abbott wrote: > - It turns out that the original advantage of a tree-based IR, to be > able to automatically generate pattern-matching code for optimizing > certain code patterns, only really matters for CPU's with weird > instruction sets with lots of exotic

[Mesa-dev] [PATCH] st/mesa: avoid sw fallback for getting/decompressing textures

2014-02-07 Thread Brian Paul
If st_GetTexImage() is to decompress the texture, avoid the fallback path even if prefer_blit_based_texture_transfer = false. For drivers that returned PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0, we were always taking the fallback path for texture decompression rather than rendering a quad.

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add support for GL_ARB_viewport_array (v0.2)

2014-02-07 Thread Marek Olšák
The CSO stuff looks good. We want the ability to save and restore the first viewport, but not the other ones. Marek On Tue, Jan 21, 2014 at 7:09 AM, Dave Airlie wrote: > From: Dave Airlie > > this just ties the mesa code to the pre-existing gallium interface, > I'm not sure what to do with the

Re: [Mesa-dev] Flatland

2014-02-07 Thread Christian König
Am 07.02.2014 16:49, schrieb Alex Deucher: On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott wrote: Hi, So I believe that we can all agree that the tree-based representation that GLSL IR currently uses for shaders needs to go. For the benefit of those that didn't watch Ian Romanick's talk at FOSD

Re: [Mesa-dev] mesa/st: how to force glLinkProgram to create/translate the program?

2014-02-07 Thread Marek Olšák
FYI, I found the patch which compiles some shader variants in glLinkProgram: http://cgit.freedesktop.org/~mareko/mesa/commit/?h=precompile&id=8dc586297e4902dfc14cf8001b8202db4fdc9447 Marek On Tue, Jan 21, 2014 at 12:56 AM, Marek Olšák wrote: > It was pretty simple IIRC. You just need to call st

Re: [Mesa-dev] mesa/st: how to force glLinkProgram to create/translate the program?

2014-02-07 Thread Ilia Mirkin
Cool. Do you think something like this is check-in-able behind a ST_PRECOMPILE=1 env var (or something that fits well into the current env var scheme, dunno what it would be)? On Fri, Feb 7, 2014 at 12:46 PM, Marek Olšák wrote: > FYI, I found the patch which compiles some shader variants in glLin

Re: [Mesa-dev] Flatland

2014-02-07 Thread Tom Stellard
On Fri, Feb 07, 2014 at 05:20:12PM +0100, Christian König wrote: > Am 07.02.2014 16:49, schrieb Alex Deucher: > >On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott wrote: > >>Hi, > >> > >>So I believe that we can all agree that the tree-based representation > >>that GLSL IR currently uses for shaders

Re: [Mesa-dev] Flatland

2014-02-07 Thread Tom Stellard
On Fri, Feb 07, 2014 at 10:49:01AM -0500, Alex Deucher wrote: > On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott wrote: > > Hi, > > > > So I believe that we can all agree that the tree-based representation > > that GLSL IR currently uses for shaders needs to go. For the benefit > > of those that did

Re: [Mesa-dev] [PATCH] R600/SI: Custom select 64-bit ADD

2014-02-07 Thread Tom Stellard
On Fri, Feb 07, 2014 at 10:31:20AM -0800, Matt Arsenault wrote: > I didn't think to try this. Where is the address folding happening? > There are TableGen patterns that do the folding. I recently added several new ones: r200932-r200935. -Tom > On 02/07/2014 07:46 AM, Tom Stellard wrote: > >From

[Mesa-dev] [PATCH 1/3] i965: Don't print source registers for Broadwell flow control.

2014-02-07 Thread Kenneth Graunke
The bits which normally contain the source register descriptions actually contain the JIP/UIP jump targets, which we already printed. Interpreting JIP/UIP as source registers results in some really creepy looking output, like IF statements with acc14.4<0,1,0>UD sources. Signed-off-by: Kenneth Gra

[Mesa-dev] [PATCH 2/3] i965: Don't disassemble UIP field for Broadwell WHILE instructions.

2014-02-07 Thread Kenneth Graunke
The WHILE instruction doesn't have UIP. It only has JIP. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_disasm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_disasm.c b/src/mesa/drivers/dri/i965/gen8_disasm.c index b2ab

[Mesa-dev] [Bug 67676] Transparent windows no longer work

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67676 --- Comment #5 from Eric Anholt --- Daniel: the problem is that normal apps use the alpha, but they don't fill it with values that should be used to blend window contents over other windows. So you must not return the rgba visual when people are

Re: [Mesa-dev] [PATCH 1/3] i965: Don't print source registers for Broadwell flow control.

2014-02-07 Thread Eric Anholt
Kenneth Graunke writes: > The bits which normally contain the source register descriptions > actually contain the JIP/UIP jump targets, which we already printed. > > Interpreting JIP/UIP as source registers results in some really creepy > looking output, like IF statements with acc14.4<0,1,0>UD s

Re: [Mesa-dev] Flatland

2014-02-07 Thread Rob Clark
On Fri, Feb 7, 2014 at 11:20 AM, Christian König wrote: > Am 07.02.2014 16:49, schrieb Alex Deucher: > >> On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott >> wrote: >>> >>> Hi, >>> >>> So I believe that we can all agree that the tree-based representation >>> that GLSL IR currently uses for shaders

Re: [Mesa-dev] [PATCH] st/mesa: avoid sw fallback for getting/decompressing textures

2014-02-07 Thread Roland Scheidegger
Am 07.02.2014 17:39, schrieb Brian Paul: > If st_GetTexImage() is to decompress the texture, avoid the fallback > path even if prefer_blit_based_texture_transfer = false. For drivers > that returned PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0, we > were always taking the fallback path for text

Re: [Mesa-dev] Flatland

2014-02-07 Thread Ian Romanick
On 02/07/2014 07:49 AM, Alex Deucher wrote: > On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott wrote: >> Hi, >> >> So I believe that we can all agree that the tree-based representation >> that GLSL IR currently uses for shaders needs to go. For the benefit >> of those that didn't watch Ian Romanick'

Re: [Mesa-dev] Flatland

2014-02-07 Thread Ian Romanick
On 02/06/2014 09:34 PM, Connor Abbott wrote: > Hi, > > So I believe that we can all agree that the tree-based representation > that GLSL IR currently uses for shaders needs to go. For the benefit > of those that didn't watch Ian Romanick's talk at FOSDEM, I'll > reiterate some of the problems with

Re: [Mesa-dev] files out of date

2014-02-07 Thread Ian Romanick
On 02/07/2014 08:06 AM, Alex Deucher wrote: > On Thu, Feb 6, 2014 at 7:08 PM, Joey Reid wrote: >> the folder: >> http://www.x.org/docs/AMD/ >> >> has an outdated version of Southern Islands Series Instruction Set >> Architecture. The latest version can be found here: >> http://developer.amd.com/wo

Re: [Mesa-dev] Flatland

2014-02-07 Thread Tom Stellard
On Fri, Feb 07, 2014 at 02:52:15PM -0500, Rob Clark wrote: > On Fri, Feb 7, 2014 at 11:20 AM, Christian König > wrote: > > Am 07.02.2014 16:49, schrieb Alex Deucher: > > > >> On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott > >> wrote: > >>> > >>> Hi, > >>> > >>> So I believe that we can all agree

[Mesa-dev] [PATCH 3/3] i965: Label JIP and UIP in Broadwell shader disassembly.

2014-02-07 Thread Kenneth Graunke
This makes it obvious which number is which. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_disasm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_disasm.c b/src/mesa/drivers/dri/i965/gen8_disasm.c index 3705908..e6

Re: [Mesa-dev] [PATCH 1/2] gallium/tgsi: use CLAMP instead of open-coded clamps

2014-02-07 Thread Brian Paul
On 02/07/2014 05:45 AM, Erik Faye-Lund wrote: Signed-off-by: Erik Faye-Lund --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec

[Mesa-dev] [Bug 67676] Transparent windows no longer work

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67676 Daniel Stone changed: What|Removed |Added CC||dan...@fooishbar.org --- Comment #4 from

Re: [Mesa-dev] Flatland

2014-02-07 Thread Connor Abbott
On Fri, Feb 7, 2014 at 3:13 PM, Ian Romanick wrote: > On 02/06/2014 09:34 PM, Connor Abbott wrote: >> Hi, >> >> So I believe that we can all agree that the tree-based representation >> that GLSL IR currently uses for shaders needs to go. For the benefit >> of those that didn't watch Ian Romanick's

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #15 from Barto --- I tried with flightgear 3.0.0 release candidate, and the bug is still here, I created a bugreport in order to warn the flightgear developpers : https://code.google.com/p/flightgear-bugs/issues/detail?id=1363 ma

Re: [Mesa-dev] [PATCH] R600/SI: Make sure M0 is always initialized when DS instructions are used

2014-02-07 Thread Tom Stellard
On Fri, Feb 07, 2014 at 11:46:55AM +0900, Michel Dänzer wrote: > On Don, 2014-02-06 at 09:40 -0800, Tom Stellard wrote: > > From: Tom Stellard > > > > DS instructions that access local memory can only uses addresses that > > are less than or equal to the value of M0. When M0 is uninitialized, >

[Mesa-dev] [PATCH] i965: Fix fast depth clear values on Broadwell.

2014-02-07 Thread Kenneth Graunke
Broadwell's 3DSTATE_CLEAR_PARAMS packet expects a floating point value regardless of format. This means we need to stop converting it to UNORM. Storing the value as float would make sense, but since we already have a uint32_t field, this patch continues shoehorning it into that. In a sense, this

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Dave Airlie
>>> >> Doh, yes because GL has ARB_texture_gather then has stuff hidden away >> in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should >> do. >> >> So I've reposted with the component selection in src1 now. > > Hmm seems a bit excessive to use an extra reg for that (gather4 bu

Re: [Mesa-dev] [PATCH] i965: Fix fast depth clear values on Broadwell.

2014-02-07 Thread Eric Anholt
Kenneth Graunke writes: > Broadwell's 3DSTATE_CLEAR_PARAMS packet expects a floating point value > regardless of format. This means we need to stop converting it to > UNORM. > > Storing the value as float would make sense, but since we already have a > uint32_t field, this patch continues shoeho

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #16 from Fredrik Höglund --- Created attachment 93635 --> https://bugs.freedesktop.org/attachment.cgi?id=93635&action=edit patch Thanks, but I think I've found the cause of the problem. Can you confirm that this patch fixes it for

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #17 from Ilia Mirkin --- (In reply to comment #16) > Created attachment 93635 [details] [review] > patch > > Thanks, but I think I've found the cause of the problem. > > Can you confirm that this patch fixes it for you? FWIW, seems

Re: [Mesa-dev] [PATCH] configure: Use LLVM shared libraries by default

2014-02-07 Thread Emil Velikov
On 04/02/14 19:24, Tom Stellard wrote: > From: Tom Stellard > > Linking with LLVM static libraries is easily broken by changes to > the llvm-config program or when LLVM adds, removes, or changes library > components. Keeping up with these changes requires a lot of maintanence > effort to keep th

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #18 from Barto --- (In reply to comment #16) > Created attachment 93635 [details] [review] > patch > > Thanks, but I think I've found the cause of the problem. > > Can you confirm that this patch fixes it for you? yes your patch so

Re: [Mesa-dev] [PATCH RFC 07/11] glsl: add SSA infrastructure

2014-02-07 Thread Connor Abbott
On Tue, Jan 28, 2014 at 1:50 PM, Paul Berry wrote: > On 22 January 2014 09:16, Connor Abbott wrote: >> >> This patch introduces all the changes to the IR that are necessary for >> representing programs in the SSA form. This consists of a new variable >> mode, the SSA temporary, which is guarentee

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #19 from Benjamin Bellec --- (In reply to comment #16) > Created attachment 93635 [details] [review] > patch > > Thanks, but I think I've found the cause of the problem. > > Can you confirm that this patch fixes it for you? Yes it

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #20 from Fredrik Höglund --- (In reply to comment #18) > (In reply to comment #16) > > Can you confirm that this patch fixes it for you? > > yes your patch solves the bug, thank you very much No problem - the apitrace helped. -- Y

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #21 from Ian Romanick --- Comment on attachment 93635 --> https://bugs.freedesktop.org/attachment.cgi?id=93635 patch Review of attachment 93635: - There are a couple

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Roland Scheidegger
Am 07.02.2014 23:25, schrieb Dave Airlie: >>> Doh, yes because GL has ARB_texture_gather then has stuff hidden away >>> in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should >>> do. >>> >>> So I've reposted with the component selection in src1 now. >> >> Hmm seems a bit

[Mesa-dev] [Bug 72895] Missing trees in flightgear 2.12.1 with mesa 10.0.1

2014-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- Comment #22 from Fredrik Höglund --- (In reply to comment #21) > Comment on attachment 93635 [details] [review] > patch > > Review of attachment 93635 [details] [review]: > - >

Re: [Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

2014-02-07 Thread Ian Romanick
On 02/07/2014 04:44 AM, Juha-Pekka Heikkila wrote: > ir_constant::ir_constant(const struct glsl_type, > const ir_constant_data *) was copying too much memory. The code looks correct as-is to me. This copies one ir_constant_data union to another... they're declared as the same type, and they have

[Mesa-dev] [PATCH 3/3] mesa: allocate gl_debug_state on demand

2014-02-07 Thread Brian Paul
We don't need to allocate all the state related to GL_ARB_debug_output until some aspect of that extension is actually needed. The sizeof(gl_debug_state) is huge (~285KB on 64-bit systems), not even counting the 54(!) hash tables and lists that it contains. This change reduces the size of gl_cont

[Mesa-dev] [PATCH 1/3] mesa: remove _mesa_ prefix from some static functions

2014-02-07 Thread Brian Paul
--- src/mesa/main/errors.c | 50 ++-- 1 file changed, 23 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 28357e0..f84a3c1 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/main/errors.c @@ -346,9 +346

[Mesa-dev] [PATCH 2/3] mesa: trivial clean-ups in errors.c

2014-02-07 Thread Brian Paul
Whitespace changes, 78-column rewrapping, comment clean-ups, add some braces, etc. --- src/mesa/main/errors.c | 125 1 file changed, 84 insertions(+), 41 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index f84a3c1..dcae

[Mesa-dev] Mesa 10.1 release candidate 1

2014-02-07 Thread Ian Romanick
Mesa 10.1 release candidate 1 is now available for testing. The current plan of record is to have the 10.1 release on Friday, February 28th. The tag in the GIT repository for Mesa 10.1-rc1 is 'mesa-10.1-rc1'. Mesa 10.1 release candidate 1 is available for download at ftp://freedesktop.org/pub/me

[Mesa-dev] [PATCH] i965/Gen7: Fix HiZ ops for MSAA depth

2014-02-07 Thread Chris Forbes
Previously, we would program the sample count based on the blorp operation's dst sample count -- which is zero for a HiZ op; we'd also ignore the difference between physical and logical surface size for the depth surface. That kindof worked -- the two errors almost cancel out -- but produced stran

[Mesa-dev] [PATCH] mesa: Fix MESA_FORMAT_Z24_UNORM_S8_UINT vs. X8_UINT mix-up.

2014-02-07 Thread Kenneth Graunke
In commit eeed49f5f290793870c60b5b635b977a732a1eb4, Mark accidentally renamed MESA_FORMAT_S8_Z24 to MESA_FORMAT_Z24_UNORM_X8_UINT and MESA_FORMAT_X8_Z24 to MESA_FORMAT_Z24_UNORM_S8_UINT, reversing their sense. The commit message was correct, but what sed commands actually got run didn't match that

[Mesa-dev] [PATCH 14/15] mesa/sso: Implement _mesa_ActiveShaderProgram

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/pipelineobj.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelin

[Mesa-dev] [PATCH 02/15] mesa/sso: Add extension tracking for ARB_separate_shader_objects

2014-02-07 Thread Ian Romanick
From: Ian Romanick This adds the necessary bits for both the API and the GLSL compiler. Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 7 +++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 4 files chan

[Mesa-dev] [PATCH 10/15] mesa/sso: Implement _mesa_IsProgramPipeline

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut Implement IsProgramPipeline based on the VAO code. This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/mtypes.h | 2 ++ src/mesa/main/pipelineobj.c | 8 +++- 2 files changed, 9 insertio

[Mesa-dev] [PATCH 00/15] The first half of GL_ARB_separate_shader_objects

2014-02-07 Thread Ian Romanick
I'm taking a patch from Paul's notebook, and I'm going to try land a giant patch series in a small number of more manageable chunks. GL_ARB_separate_shader_objects has been work-in-progress for about 10 months. This represents about half of the final patch series. The next block of patches will b

[Mesa-dev] [PATCH 03/15] glsl/sso: Add parser and AST-to-HIR support for separate shader object layouts

2014-02-07 Thread Ian Romanick
From: Ian Romanick GL_ARB_separate_shader_objects adds the ability to specify location layouts for interstage inputs and outputs. In addition, this extension makes 'in' and 'out' generally available for shader inputs and outputs. This mimics the behavior of GL_ARB_explicit_attrib_location. Sig

[Mesa-dev] [PATCH 12/15] mesa/sso: Refactor implementation of _mesa_CreateShaderProgramEXT

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut This will allow the guts of the implementation to be shared with _mesa_CreateShaderProgramv. This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/shaderapi.c | 26 ++ 1 fi

[Mesa-dev] [PATCH 15/15] mesa/sso: Implement _mesa_GetProgramPipelineiv

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut This was originally included in another patch, but it was split out by Ian Romanick. v2 (idr): * Trivial reformatting. * Remove GL_COMPUTE_SHADER. Compute shaders don't participate in pipeline objects anyway. Suggested by Matt Turner. v3 (idr): * Use _mesa_has_geometry

[Mesa-dev] [PATCH 13/15] mesa/sso: Implement _mesa_CreateShaderProgramv

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/shaderapi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c ind

[Mesa-dev] [PATCH 07/15] mesa/sso: Add pipeline container/state

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut V1: * Extend gl_shader_state as pipeline object state * Add a new container gl_pipeline_shader_state that contains binding point of the previous object * Update mesa init/free shader state due to the extension of the attibute * Add an init/free pipeline function for th

[Mesa-dev] [PATCH 09/15] mesa/sso: Implement _mesa_GenProgramPipelines

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut Implement GenProgramPipelines based on the VAO code. This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/pipelineobj.c | 30 ++ 1 file changed, 30 insertions(+) diff

[Mesa-dev] [PATCH 01/15] mesa: Refactor per-stage link check to its own function

2014-02-07 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.c | 102 1 file changed, 34 insertions(+), 68 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 458d8e5..8421a25 100644 --- a/src/mesa/main/

[Mesa-dev] [PATCH 06/15] mesa: Add a mutex and refcounting to gl_shader_state

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut Reviewed-by: Ian Romanick --- src/mesa/main/mtypes.h| 4 src/mesa/main/shaderapi.c | 8 2 files changed, 12 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9786a98..52aeb15 100644 --- a/src/mesa/main/mtypes.h +++ b/src/me

[Mesa-dev] [PATCH 05/15] mesa: Make get_shader_flags publicly available

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut Future patches will use this function outside shaderapi.c. This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/shaderapi.c | 6 +++--- src/mesa/main/shaderapi.h | 3 +++ 2 files changed, 6 inser

[Mesa-dev] [PATCH 08/15] mesa/sso: Implement _mesa_DeleteProgramPipelines

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut Implement DeleteProgramPipelines based on the VAO code. This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/pipelineobj.c | 33 + 1 file changed, 33 insertions(+)

[Mesa-dev] [PATCH 11/15] mesa/sso: Add support for GL_PROGRAM_SEPARABLE query

2014-02-07 Thread Ian Romanick
From: Gregory Hainaut This was originally included in another patch, but it was split out by Ian Romanick. Reviewed-by: Ian Romanick --- src/mesa/main/mtypes.h| 6 ++ src/mesa/main/shaderapi.c | 25 + 2 files changed, 31 insertions(+) diff --git a/src/mesa/mai

[Mesa-dev] [PATCH 1/8] i965: Pull format conversion logic out of brw_depthbuffer_format.

2014-02-07 Thread Kenneth Graunke
brw_depthbuffer_format is not very reusable at the moment, since it uses global state (ctx->DrawBuffer) to access a particular depth buffer. For HiZ on Broadwell, I need a function which simply converts the formats. However, at least one existing user of brw_depthbuffer_format really wants the ex

[Mesa-dev] [PATCH 6/8] i965: Implement HiZ resolves on Broadwell.

2014-02-07 Thread Kenneth Graunke
Broadwell's 3DSTATE_WM_HZ_OP packet makes this much easier. Instead of programming the whole pipeline, we simply have to emit the depth/stencil packets, a state override, and a pipe control. Then arrange for the state to be put back. This is easily done from a single function. Signed-off-by: Ke

[Mesa-dev] [PATCH 5/8] i965: Refactor Gen8 depth packet emission.

2014-02-07 Thread Kenneth Graunke
The existing code followed the vtable function signature, which is not a great fit: many of the parameters are unused, and the function still inspects global state, making it less reusable. This patch refactors the depth buffer packet emission code into a new function which takes exactly the param

[Mesa-dev] [PATCH 2/8] i965: Program 3DSTATE_HIER_DEPTH_BUFFER properly on Broadwell.

2014-02-07 Thread Kenneth Graunke
HiZ buffers still don't exist, but when they do, we'll set them up. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_depth_state.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c b/src/m

[Mesa-dev] [PATCH 8/8] i965: Enable fast depth clears.

2014-02-07 Thread Kenneth Graunke
They work fine now, too. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_clear.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index 1964572..7c2e5cc 100644 --- a/src/mesa/driver

[Mesa-dev] [PATCH 7/8] i965: Enable HiZ on Broadwell.

2014-02-07 Thread Kenneth Graunke
It appears to work fine. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 021287e..b9251a2 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 4/8] i965: Add #defines for the 3DSTATE_WM_HZ_OP packet's contents.

2014-02-07 Thread Kenneth Graunke
We're going to need these to implement HiZ. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 25 + 1 file changed, 25 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 75d09fc..

[Mesa-dev] [PATCH 3/8] i965: Bump generation check in code to disable HiZ at LODs > 0.

2014-02-07 Thread Kenneth Graunke
Broadwell's "HiZ Resolve" operation still has the restriction that the rectangle primitive must be 8x4 aligned. So I believe we still need this. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] "glsl: Vectorize multiple scalar assignments" (mesa 4bd6e0d) breaks League of Legends on wine

2014-02-07 Thread Matt Turner
On Fri, Feb 7, 2014 at 10:22 PM, Andrew Guertin wrote: > Hi, > > I updated mesa and started getting some bad behavior in League of Legends > (played through wine). After starting a game, upon hovering any of the skill > buttons, instead of an info tooltip appearing, the whole screen is covered > i