On 31/01/2014, Michel Dänzer wrote :
On Don, 2014-01-30 at 16:10 +0100, Axel Davy wrote:
dri2_dup_image was not copying the dri_format field.
This was causing some bugs, for example:
. we create an gbm_bo.
. we get an EGLImage from the gbm_bo.
. Bug: impossible to get again the gbm_bo from the
On 01/29/2014 02:15 PM, Carl Worth wrote:
> Carl Worth writes:
>> Matt Turner writes:
>>>
>>> LINE_EXPANDED expression expression NEWLINE
>>
>> Yes. Thanks for the catch. I'll expand the testing and follow up with a
>> new set of patches.
>
> Except that that's totally bogus. We can't parse two
On 01/30/2014 02:24 PM, Carl Worth wrote:
> Matt Turner writes:
>> +if (parser->version_resolved) {
>> +glcpp_error(& @1, parser, "#version after
>> version is resolved");
>
> The phrasing "after version is resolved" makes a lot of sense from the
> point-of-view of
The need_workaround_flush flag was an attempt to avoid doing the
post-sync non-zero workaround flush unless it was actually necessary.
Getting the tracking right is tricky; we've messed it up several times.
The cost of getting this wrong is high: almost certainly a GPU hang.
The cost of always do
Reviewed-by: Marek Olšák
Marek
On Fri, Jan 31, 2014 at 4:15 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Fixes piglit glx/GLX_ARB_create_context/current with no framebuffer.
>
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/state_trackers/dri/common/dri_context.c | 4 ++--
> 1 file
On Thu, 30 Jan 2014 10:46:21 -0800
Eric Anholt wrote:
> The loader infrastructure for everything but DRI2 requires that udev be
> present, so we can figure out an appropriate driver from the fd. We don't
> have a portable solution yet, but presumably it will similar lookup based
> on the device
On Fri, 31 Jan 2014 12:16:05 +0200
Lauri Kasanen wrote:
> On Thu, 30 Jan 2014 10:46:21 -0800
> Eric Anholt wrote:
>
> > The loader infrastructure for everything but DRI2 requires that udev be
> > present, so we can figure out an appropriate driver from the fd. We don't
> > have a portable solu
It's important not to break existing uses. There is no need to require
udev for 3d. This is an alternative to Stéphane Marchesin's patch
"loader: Make drmGetVersion logic conditional on non-pci devices".
Signed-off-by: Lauri Kasanen
---
src/egl/drivers/dri2/platform_android.c| 2 +-
Hi,
I can get a crash without this change (now _mesa_align_malloc is being used
for buffer object data)
--- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 +
+++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 +
@@ -407,7 +407,7 @@ _mesa_delete_buffer_object(st
I think we always flush the HDP cache after (before?) command submission.
This patch adds nothing new to the drivers - we have always had
persistent buffer mappings for all buffers and it has always worked.
The only thing this does is that persistent mappings are now also
supported by Gallium and
Hello, I'm responsible for the caused inconvenience. I forgot to use
_mesa_align_free to clean up the allocated memory blocked using
_mesa_align_malloc. Good catch and thanks for the patch! :)
On POSIX aligned allocated memory (using posix_memalign) should be freed
using ordinary free() and I
Hello, on which OS is this happening?
On 01/31/2014 02:38 PM, Colin Harrison wrote:
Hi,
I can get a crash without this change (now _mesa_align_malloc is being used
for buffer object data)
--- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 +
+++ ./src/mesa/main/bufferobj.
Hi Roland,
The persistent and coherent flags are only for buffers.
It's unfortunate that buffer and texture transfers share the same
interface, because their implementation is vastly different in
hardware drivers. For textures, we only need 3 modes of transfers:
read, readwrite, and write+discard
On 01/28/2014 03:49 AM, Muhammad Al-Adly wrote:
Does OSMesa support OpenGL versions higher than GL1?
Yes.
If it does, how can I make it work?
You should get a GL 2.1 context without doing anything special.
-Brian
___
mesa-dev mailing list
mesa-d
On 01/31/2014 03:14 AM, Lauri Kasanen wrote:
> It's important not to break existing uses. There is no need to require
> udev for 3d. This is an alternative to Stéphane Marchesin's patch
> "loader: Make drmGetVersion logic conditional on non-pci devices".
>
> Signed-off-by: Lauri Kasanen
I'm stil
On 22 January 2014 09:16, Connor Abbott wrote:
> Right now we are being basically as naive as possible, and inserting
> more copies than necessary. It is possible to implement a more
> sophisticated algorithm later, although extending the current copy
> propagation pass to support loops better an
https://bugs.freedesktop.org/show_bug.cgi?id=74166
Matt Turner changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 01/31/2014 04:08 AM, Colin Harrison wrote:
Hi,
I can get a crash without this change (now _mesa_align_malloc is being used
for buffer object data)
--- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 +
+++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 +
@
On Fri, Jan 31, 2014 at 7:05 AM, Marek Olšák wrote:
> I think we always flush the HDP cache after (before?) command submission.
>
The kernel flushes the HDP cache in the fence command sequence.
Alex
> This patch adds nothing new to the drivers - we have always had
> persistent buffer mappings f
On 22 January 2014 09:16, Connor Abbott wrote:
> This series enables GLSL IR support for SSA, including passes to convert
> to and from SSA form. SSA is a form of the intermediate representation
> of a compiler in which each variable is assigned exactly once. SSA form
> makes many optimizations f
On Thu, Jan 30, 2014 at 10:16:41PM +, Emil Velikov wrote:
> On 27/01/14 16:13, Tom Stellard wrote:
> > From: Tom Stellard
> >
> > v2:
> >- Add missing call to pipe_loader_drm_release()
> >- Fix render node macros
> >- Drop render-node configure option
> > ---
> >
> > For referenc
>From the GLSL 4.40 spec, section 6.4 (Jumps):
The continue jump is used only in loops. It skips the remainder of
the body of the inner most loop of which it is inside. For while
and do-while loops, this jump is to the next evaluation of the
loop condition-expression from which the
In addition to making it public, we also need to change its first
argument from an ir_loop * to an exec_list *, so that it can be used
to insert the condition anywhere in the IR (rather than just in the
body of the loop).
This will be necessary in order to make continue statements work
properly in
Lauri Kasanen writes:
>> 32-bit use is on the increase due to Steam; avoid any surprises
>> and make Mesa LFS-aware.
...
>> AC_PROG_MKDIR_P
>> +AC_SYS_LARGEFILE
Hi Lauri,
Can you describe a bit more what failure modes you encounter without
AC_SYS_LARGEFILE in place? I just haven't dealt with th
Matt Turner writes:
> ---
> src/glsl/opt_vectorize.cpp | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
Hi Matt,
I'm missing the rest of your commit message besides the one-line
summary.
I think the discipline of always typing _something_ there is valuable. I
like to call
Anuj Phogat writes:
> I missed this change in commit f5cfb4a. It fixes the incorrect
> rendering caused in Dolphin Emulator.
It's too late for my review to change anything, but since I was recently
adding this commit (and the previous one being touched-up here) to my
ignore list, I noticed someth
Kenneth Graunke writes:
> This code is strange anyway; the typical paradigm is to check whether
> the batch references the buffer, flush it if so, and then check whether
> it's busy.
I really like the series. So, thanks!
As far as your comment here, am I understanding that the (minor,
not-direct
On Fri, Jan 31, 2014 at 12:55 PM, Carl Worth wrote:
> Anuj Phogat writes:
>> I missed this change in commit f5cfb4a. It fixes the incorrect
>> rendering caused in Dolphin Emulator.
>
> It's too late for my review to change anything, but since I was recently
> adding this commit (and the previous
On 28 January 2014 11:22, Jordan Justen wrote:
> _mesa_glsl_parse_state::gs_invocations will store the
> invocation count.
>
> Signed-off-by: Jordan Justen
>
This looks like it will work if the shader contains a line like this:
layout(triangles, invocations=6) in;
But it won't handle this:
On 28 January 2014 11:22, Jordan Justen wrote:
> Grab the parsed invocation count, check for consistency
> during linking, and finally save the result in
> gl_shader_program Geom.Invocations.
>
> Signed-off-by: Jordan Justen
> ---
> src/glsl/glsl_parser_extras.cpp | 2 ++
> src/glsl/linker.cpp
On 01/31/2014 01:45 PM, Carl Worth wrote:
> Kenneth Graunke writes:
>> This code is strange anyway; the typical paradigm is to check whether
>> the batch references the buffer, flush it if so, and then check whether
>> it's busy.
>
> I really like the series. So, thanks!
>
> As far as your comme
On 28 January 2014 11:22, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> ---
> src/mesa/main/shaderapi.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index a8336c9..fb107d5 100644
> --- a/src/mesa/main/shaderapi.c
On 28 January 2014 11:22, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> ---
> src/mesa/drivers/dri/i965/brw_defines.h | 5 +
> src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 24
> ---
> 2 files changed, 26 insertions(+), 3 deletions(-)
>
> diff --
https://bugs.freedesktop.org/show_bug.cgi?id=69101
--- Comment #17 from Christoph Haag ---
Well, some people here talk about PRIME not working with compositing, some
people are talking about PRIME having some issues with OpenGL compositing.
The second one is still an issue and maybe it's some ra
Paul Berry writes:
> This patch fixes the problem by replicating the loop condition when
> converting the "continue" statement to IR. (We already do a similar
> thing in "for" loops, to ensure that "continue" causes the loop
> expression to be executed).
Nice fix, Paul. Thanks.
For the series:
---
src/mesa/state_tracker/st_manager.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_manager.c
b/src/mesa/state_tracker/st_manager.c
index b7757e9..215b276 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_mana
---
src/mesa/drivers/dri/radeon/radeon_texstate.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/radeon/radeon_texstate.c
b/src/mesa/drivers/dri/radeon/radeon_texstate.c
index 66daccf..dac8aed 100644
--- a/src/mesa/drivers/dri/radeon/radeon_texst
The _mesa_get_current_tex_object() function is now used everywhere that
_mesa_select_tex_object() was formerly used.
---
src/mesa/main/teximage.c | 28 ++--
src/mesa/main/teximage.h |5 -
2 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/src/mesa/mai
---
src/mesa/drivers/dri/r200/r200_texstate.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/r200/r200_texstate.c
b/src/mesa/drivers/dri/r200/r200_texstate.c
index 5160c2c..c3c92cb 100644
--- a/src/mesa/drivers/dri/r200/r200_texstate.c
+++ b/src/
And update a related comment.
---
src/mesa/main/texparam.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c
index e915ddd..9362cf84 100644
--- a/src/mesa/main/texparam.c
+++ b/src/mesa/main/texparam.c
@@ -118,8 +118
---
src/mesa/drivers/dri/swrast/swrast.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/swrast/swrast.c
b/src/mesa/drivers/dri/swrast/swrast.c
index 48b07bd..071192c 100644
--- a/src/mesa/drivers/dri/swrast/swrast.c
+++ b/src/mesa/drivers/dri/swrast
Wasn't used in any other file.
---
src/mesa/main/teximage.c | 10 +-
src/mesa/main/teximage.h |3 ---
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 508d546..6f84b38 100644
--- a/src/mesa/main/teximage.c
+++ b/
Put common code in new svga_shader.c file. Considate separate vertex/
fragment shader ID generation.
---
src/gallium/drivers/svga/Makefile.sources |1 +
src/gallium/drivers/svga/svga_context.c | 19 ++
src/gallium/drivers/svga/svga_context.h |3 +-
src/gallium/drivers/svga/svga_
If the shader is too large, plug in a dummy shader. This patch also
reworks the existing dummy shader code.
---
src/gallium/drivers/svga/include/svga_reg.h |1 +
src/gallium/drivers/svga/svga_state_fs.c| 60 +--
2 files changed, 49 insertions(+), 12 deletions(-)
To match the CALLOC_STRUCT() call.
---
src/gallium/auxiliary/indices/u_primconvert.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/indices/u_primconvert.c
b/src/gallium/auxiliary/indices/u_primconvert.c
index 14da7a6..f2a77ce 100644
--- a/src/gallium
I've just pushed out several updates to the 10.0 branch. This branch
passes my testing, and unless I hear of some problem over the weekend,
I'll plan to make a 10.0.3 release from this branch Monday morning.
I believe that I've included all of the commits on the master branch
since 10.0.2 that wer
Not really used anywhere.
---
src/mesa/drivers/dri/nouveau/nouveau_state.c |2 +-
src/mesa/drivers/dri/r200/r200_tex.c |5 ++---
src/mesa/drivers/dri/radeon/radeon_tex.c |2 +-
src/mesa/main/dd.h |2 +-
src/mesa/main/texobj.c
glTexSubImage(), glCopyTexSubImage() and glCompressedTexSubImage()
only change the texel data, not other state like texture size or format.
If a driver really needs do something special it can hook into the
corresponding driver functions or Map/UnmapTextureImage().
This should avoid some needless
We definitely want to apply "glx: Update glxext.h to revision 24777."
in time for the next 10.0 release. It fixes a really annoying problem
with the GL headers that make distributions lives awful. I sent this
to mesa-stable@ on the 25th. It's a slightly different than what's on
master due to some o
On 01/23/2014 01:13 PM, Kenneth Graunke wrote:
> I added this assertion in the last revision of the gen8_fs_generator
> patch, and apparently didn't test it enough. Many Piglit tests fail
> this test. The destination hstride is 1, while the source hstride and
> vstride appear to be 0. This sound
On 28 January 2014 11:22, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> ---
> src/mesa/drivers/dri/i965/brw_context.h | 2 ++
> src/mesa/drivers/dri/i965/brw_defines.h | 1 +
> src/mesa/drivers/dri/i965/brw_vec4_gs.c | 2 ++
> src/mesa/drivers/dri/i965/brw_
Lauri Kasanen writes:
> Forgot to mention, this would appear to make 3d impossible without udev
> (ie, static devices, mdev, or other solutions).
No, DRI2 continues to fall back to using the driver provided by the X
server if it can't find one locally.
--
keith.pack...@intel.com
pgppIx3XzY_4
52 matches
Mail list logo
