[Mesa-dev] [Bug 74122] loader.c:71:19: fatal error: dlfcn.h: No such file or directory

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74122 José Fonseca changed: What|Removed |Added CC||bri...@vmware.com, |

[Mesa-dev] [PATCH v2 14/17] radeonsi: We don't support indirect addressing of geometry shader inputs

2014-01-28 Thread Michel Dänzer
From: Michel Dänzer Fixes piglit spec/glsl-1.50/execution/geometry/dynamic_input_array_index Signed-off-by: Michel Dänzer --- v2: Limit to geometry shader inputs, add explanatory comment src/gallium/drivers/radeonsi/si_pipe.c | 4 1 file changed, 4 insertions(+) diff --git a/src/galliu

[Mesa-dev] [PATCH v2 03/17] radeonsi: Fix handling of geometry shader output vertex ID

2014-01-28 Thread Michel Dänzer
From: Michel Dänzer It needs to increment at shader runtime, not at shader compile time, as the geometry shader can emit vertices in loops. LLVM automagically converts the ID back to an immediate value if its value can be determined at compile time. Signed-off-by: Michel Dänzer --- v2: Drop ex

[Mesa-dev] [PATCH v2 16/17] radeonsi: Enable OpenGL 3.3

2014-01-28 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- v2: * Drop excessive HAVE_LLVM preprocessor guards * Update docs/GL3.txt docs/GL3.txt | 36 +- src/gallium/drivers/radeonsi/si_pipe.c | 8 +--- 2 files changed, 23 insertions(+)

[Mesa-dev] [PATCH 17/17] radeonsi; Put GS ring buffer descriptors with streamout buffer descriptors

2014-01-28 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_descriptors.c | 93 --- src/gallium/drivers/radeonsi/si_pipe.h| 6 +- src/gallium/drivers/radeonsi/si_shader.c | 22 --- src/gallium/drivers/radeonsi/si_shader.h |

Re: [Mesa-dev] [PATCH] i965/blorp: do not use unnecessary hw-blending support

2014-01-28 Thread Pohjolainen, Topi
On Mon, Jan 27, 2014 at 06:00:54PM -0800, Kenneth Graunke wrote: > On 01/27/2014 11:06 AM, Pohjolainen, Topi wrote: > > On Mon, Jan 27, 2014 at 10:20:54AM -0800, Eric Anholt wrote: > >> Topi Pohjolainen writes: > >> > >>> This is really not needed as blorp blit programs already sample > >>> XRGB n

Re: [Mesa-dev] [PATCH 14/16] radeonsi: We don't support indirect addressing of shader inputs/outputs

2014-01-28 Thread Michel Dänzer
On Mon, 2014-01-27 at 12:03 +0100, Marek Olšák wrote: > The function "emit_fetch" in radeon_setup_tgsi_llvm.c seems to > implement indirect addressing of everything but constants. Ah, there it is, thanks. v2 of the patch only disallows indirect addressing of geometry shader inputs. -- Earthling

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Michel Dänzer
On Sam, 2014-01-25 at 02:21 +0100, Marek Olšák wrote: > On Fri, Jan 24, 2014 at 10:19 PM, Marek Olšák wrote: > > 1) Do we really have to have so much code inside #if...#endif? Can we > > always compile everything and just not set the pipe_context functions > > if LLVM < 3.5 and the same for get_(s

Re: [Mesa-dev] [PATCH] i965/blorp: do not use unnecessary hw-blending support

2014-01-28 Thread Pohjolainen, Topi
On Tue, Jan 28, 2014 at 11:48:18AM +0200, Pohjolainen, Topi wrote: > On Mon, Jan 27, 2014 at 06:00:54PM -0800, Kenneth Graunke wrote: > > On 01/27/2014 11:06 AM, Pohjolainen, Topi wrote: > > > On Mon, Jan 27, 2014 at 10:20:54AM -0800, Eric Anholt wrote: > > >> Topi Pohjolainen writes: > > >> > > >

Re: [Mesa-dev] [PATCH 2/2] loader: do not print the pci id on release builds

2014-01-28 Thread Emil Velikov
Ignore this patch, I had it completely wrong. I'll send a proper solution in a moment. -Emil On 23/01/14 18:03, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/loader/loader.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/loader/loader.c b/src/loader/loader.c > i

Re: [Mesa-dev] What use do swap interval > 1 and OML_sync_control divisor and remainder have?

2014-01-28 Thread Pekka Paalanen
Hi Ian and Jason On Mon, 27 Jan 2014 12:26:23 -0700 Ian Romanick wrote: > On 01/24/2014 04:32 AM, Pekka Paalanen wrote: > > Hi, > > > > I am investigating what kind of Wayland protocol extensions would be > > needed to support proper presentation timing. Looking at existing > > works, I am wond

[Mesa-dev] [PATCH 1/3] loader: print WARNING and FATAL messages using the default logger

2014-01-28 Thread Emil Velikov
Lower values are used for more severe cases. Signed-off-by: Emil Velikov --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 6d179a1..6b60ce7 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -80,

[Mesa-dev] [PATCH 0/3] loader: misc patches

2014-01-28 Thread Emil Velikov
Hi list, A few small patches on the infamous loader topic. The first two are cosmetic - they make sure that messages is higher severity (although defined by lower numbers) are printed, and promoting the "pci id" printout to DEBUG. The last patch covers unfortunate regression, where we would try

[Mesa-dev] [PATCH 3/3] loader: include dlfcn.h when building with HAVE_LIBUDEV

2014-01-28 Thread Emil Velikov
The code depending on the definitions is already wrapped in the same conditional so go ahead and wrap the include. Otherwise we'll brake compilation on platforms that are missing the header. Add assert.h in there as well, as it is introduced and used in the same fashon. Cc: Eric Anholt Bugzilla:

[Mesa-dev] [PATCH 2/3] loader: do not print the pci id during normal operation

2014-01-28 Thread Emil Velikov
Spamming the pci id is not beneficial. Make sure it's printed only when needed. v2: Change severity to _LOADER_DEBUG, rather than removing the message. Signed-off-by: Emil Velikov --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/loader.c b/s

Re: [Mesa-dev] [PATCH] Correct test for depth parameter for checking if dimension is legal

2014-01-28 Thread Rogovin, Kevin
> Okay if we make this the subject? > mesa: Allow depth = 0 parameter for TexImage3D. Sure, that is fine and more succinct. -Kevin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/blorp: do not use unnecessary hw-blending support

2014-01-28 Thread Pohjolainen, Topi
On Tue, Jan 28, 2014 at 11:48:18AM +0200, Pohjolainen, Topi wrote: > On Mon, Jan 27, 2014 at 06:00:54PM -0800, Kenneth Graunke wrote: > > On 01/27/2014 11:06 AM, Pohjolainen, Topi wrote: > > > On Mon, Jan 27, 2014 at 10:20:54AM -0800, Eric Anholt wrote: > > >> Topi Pohjolainen writes: > > >> > > >

Re: [Mesa-dev] can we have gl_framebuffer _NumColorDrawBuffers = 1 and all the entries in the array NULL

2014-01-28 Thread Marek Olšák
Hi Dave, Yes, it's legal. Drivers should handle NULL color buffer bindings and there is a test for it: http://cgit.freedesktop.org/piglit/commit/?id=ff2398a4e3c4805e7d1bea38f4ae6f9811b42ede I fixed it just recently. That said, I think we don't have to bind NULL color buffers which appear at the

[Mesa-dev] [PATCH] egl/dri2/android: free driver_name in dri2_initialize_android error path

2014-01-28 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 4a201c8..e149a4b 100644 --- a/src/egl/drivers/dri2/platform_android.c +++ b/src/eg

Re: [Mesa-dev] [PATCH] i965/blorp: do not use unnecessary hw-blending support

2014-01-28 Thread Pohjolainen, Topi
On Tue, Jan 28, 2014 at 11:48:18AM +0200, Pohjolainen, Topi wrote: > On Mon, Jan 27, 2014 at 06:00:54PM -0800, Kenneth Graunke wrote: > > On 01/27/2014 11:06 AM, Pohjolainen, Topi wrote: > > > On Mon, Jan 27, 2014 at 10:20:54AM -0800, Eric Anholt wrote: > > >> Topi Pohjolainen writes: > > >> > > >

Re: [Mesa-dev] [PATCH] i965/blorp: do not use unnecessary hw-blending support

2014-01-28 Thread Pohjolainen, Topi
On Tue, Jan 28, 2014 at 02:20:47PM +0200, Pohjolainen, Topi wrote: > On Tue, Jan 28, 2014 at 11:48:18AM +0200, Pohjolainen, Topi wrote: > > On Mon, Jan 27, 2014 at 06:00:54PM -0800, Kenneth Graunke wrote: > > > On 01/27/2014 11:06 AM, Pohjolainen, Topi wrote: > > > > On Mon, Jan 27, 2014 at 10:20:5

Re: [Mesa-dev] [PATCH 17/17] radeonsi; Put GS ring buffer descriptors with streamout buffer descriptors

2014-01-28 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Jan 28, 2014 at 10:46 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 93 > --- > src/gallium/drivers/radeonsi/si_pipe.h

Re: [Mesa-dev] [PATCH 2/2] pipe-loader: Add support for render nodes v2

2014-01-28 Thread David Herrmann
Hi Tom On Mon, Jan 27, 2014 at 5:13 PM, Tom Stellard wrote: > From: Tom Stellard > > v2: >- Add missing call to pipe_loader_drm_release() >- Fix render node macros >- Drop render-node configure option Patch looks fine to me, but I lack mesa-insights to really comment on it. But I'd

[Mesa-dev] [Bug 74122] loader.c:71:19: fatal error: dlfcn.h: No such file or directory

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74122 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] r600g, radeonsi: Don't set resource_create in r600_common_screen_init()

2014-01-28 Thread Tom Stellard
From: Tom Stellard r600g and radeonsi have different implementations of resource_create. https://bugs.freedesktop.org/show_bug.cgi?id=74139 --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 - src/gallium/drivers/radeonsi/si_pipe.c| 1 + 2 files changed, 1 insertion(+), 1 deletion(-

Re: [Mesa-dev] [PATCH] r600g, radeonsi: Don't set resource_create in r600_common_screen_init()

2014-01-28 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 28, 2014 at 4:01 PM, Tom Stellard wrote: > From: Tom Stellard > > r600g and radeonsi have different implementations of resource_create. > > https://bugs.freedesktop.org/show_bug.cgi?id=74139 > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 1 -

[Mesa-dev] [Bug 74098] [clover] adaptor.hpp:47:16: error: function cannot return function type 'std::vector > (unsigned long, unsigned long)'

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74098 Francisco Jerez changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 74098] [clover] adaptor.hpp:47:16: error: function cannot return function type 'std::vector > (unsigned long, unsigned long)'

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74098 --- Comment #3 from Francisco Jerez --- Created attachment 92932 --> https://bugs.freedesktop.org/attachment.cgi?id=92932&action=edit clover_workaround_clang_function_argument_deduction.patch I suspect this is a clang bug. In the function cal

Re: [Mesa-dev] can we have gl_framebuffer _NumColorDrawBuffers = 1 and all the entries in the array NULL

2014-01-28 Thread Jose Fonseca
If drivers has issues dealing with NULL cbufs, then we could have the state trackers using dummy rendertargets. But probably it's more efficent to handle in the pipe drivers. My concern is that this ends up being a rare condition in practice, and that pipe drivers end up having a lot of bugs h

[Mesa-dev] [Bug 74098] [clover] adaptor.hpp:47:16: error: function cannot return function type 'std::vector > (unsigned long, unsigned long)'

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74098 Vinson Lee changed: What|Removed |Added See Also||http://llvm.org/bugs/show_b

Re: [Mesa-dev] [PATCH] egl/dri2/android: free driver_name in dri2_initialize_android error path

2014-01-28 Thread Chad Versace
On Tue, Jan 28, 2014 at 11:59:14AM +, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/platform_android.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/egl/drivers/dri2/platform_android.c > b/src/egl/drivers/dri2/platform_android.c > index 4a20

Re: [Mesa-dev] [PATCH] loader: fix running with --disable-egl builds

2014-01-28 Thread Eric Anholt
Dave Airlie writes: > From: Dave Airlie > > I sometimes build without EGL just for speed purposes, however > it no longer finds my drivers when I do due to the HAVE_LIBUDEV > defines being wrong. Reviewed-by: Eric Anholt pgpAk2C4zftCK.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH 0/3] loader: misc patches

2014-01-28 Thread Eric Anholt
Emil Velikov writes: > Hi list, > > A few small patches on the infamous loader topic. > > The first two are cosmetic - they make sure that messages is higher > severity (although defined by lower numbers) are printed, and promoting > the "pci id" printout to DEBUG. > > The last patch covers unfor

Re: [Mesa-dev] [PATCH] mesa: Generate correct error code in glDrawBuffers()

2014-01-28 Thread Ian Romanick
On 01/27/2014 07:29 PM, Anuj Phogat wrote: > OpenGL 3.3 spec expects GL_INVALID_OPERATION: > "For both the default framebuffer and framebuffer objects, the > constants FRONT, BACK, LEFT, RIGHT, and FRONT AND BACK are not > valid in the bufs array passed to DrawBuffers, and will result > in t

Re: [Mesa-dev] [PATCH RFC 07/11] glsl: add SSA infrastructure

2014-01-28 Thread Paul Berry
On 22 January 2014 09:16, Connor Abbott wrote: > This patch introduces all the changes to the IR that are necessary for > representing programs in the SSA form. This consists of a new variable > mode, the SSA temporary, which is guarenteed to be written to exactly > once, and classes to represent

Re: [Mesa-dev] [PATCH 00/12] ARB_fragment_layer_viewport for i965

2014-01-28 Thread Ian Romanick
On 01/24/2014 11:51 PM, Chris Forbes wrote: > This series adds support for ARB_fragment_layer_viewport on i965 Gen7, in > core contexts [the same conditions as for ARB_viewport_array being exposed]. > > This is another tiny piece of GL4.3, allowing the GS- [or with > AMD_vertex_shader_*, VS- ] wri

Re: [Mesa-dev] [PATCH 07/12] glsl: Add gl_Layer and gl_ViewportIndex builtins to fragment shader

2014-01-28 Thread Ian Romanick
Patches 1-7 are Reviewed-by: Ian Romanick On 01/24/2014 11:51 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/glsl/builtin_variables.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp > index d6bc

[Mesa-dev] [PATCH v2 0/7] i965/gen7 instanced GS support for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
v2: * Convert gl_InvocationID to a system value No piglit regressions on HSW. MESA_EXTENSION_OVERRIDE=GL_ARB_gpu_shader5 allows piglit arb_gpu_shader5/execution/invocation-id-basic.shader_test to pass. There are known issues with invalid layout qualifiers being allowed by the compiler. (Most ar

[Mesa-dev] [PATCH v2 1/7] glsl: parse invocations layout qualifier for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
_mesa_glsl_parse_state::gs_invocations will store the invocation count. Signed-off-by: Jordan Justen --- src/glsl/ast.h| 15 +-- src/glsl/ast_to_hir.cpp | 14 ++ src/glsl/ast_type.cpp | 11 +++ src/glsl/glsl_parser.yy | 19 +

[Mesa-dev] [PATCH v2 3/7] mesa: initialize gl_geometry_program Invocations field

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 1 + src/mesa/main/shaderapi.c | 1 + src/mesa/program/program.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + src/mesa/state_tracker/st_program.c| 1 + 5 files change

[Mesa-dev] [PATCH v2 6/7] i965: support gl_InvocationID for gen7

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 24 --- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/driver

[Mesa-dev] [PATCH v2 4/7] main/shaderapi: GL_GEOMETRY_SHADER_INVOCATIONS GetProgramiv support

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/shaderapi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index a8336c9..fb107d5 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -603,6 +603,12 @@ get_program

[Mesa-dev] [PATCH v2 5/7] glsl: add gl_InvocationID variable for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 ++ src/mesa/main/mtypes.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index d6bc3c0..d9ed2db 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src

[Mesa-dev] [PATCH v2 7/7] i965: support instanced GS on gen7

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_gs.c | 2 ++ src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 6 -- src/mesa/drivers/dri/i965/gen

[Mesa-dev] [PATCH v2 2/7] glsl/linker: produce gl_shader_program Geom.Invocations

2014-01-28 Thread Jordan Justen
Grab the parsed invocation count, check for consistency during linking, and finally save the result in gl_shader_program Geom.Invocations. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 2 ++ src/glsl/linker.cpp | 18 ++ src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 03/16] llvmpipe: Use alignment of 64 instead of 16 for buffer allocation

2014-01-28 Thread Jose Fonseca
- Original Message - > From: Siavash Eliasi > > v2: Changed allocation alignment of llvmpipe_displaytarget_layout. > > Reviewed-by: Ian Romanick > --- > src/gallium/drivers/llvmpipe/lp_texture.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/galli

Re: [Mesa-dev] [PATCH 0/3] loader: misc patches

2014-01-28 Thread Kenneth Graunke
On 01/28/2014 02:35 AM, Emil Velikov wrote: > Hi list, > > A few small patches on the infamous loader topic. > > The first two are cosmetic - they make sure that messages is higher > severity (although defined by lower numbers) are printed, and promoting > the "pci id" printout to DEBUG. > > The

Re: [Mesa-dev] [PATCH 1/2] glsl: s/_NDEBUG/NDEBUG/

2014-01-28 Thread Kenneth Graunke
On 01/23/2014 10:03 AM, Emil Velikov wrote: > The former symbol is never defined within mesa. Based > it seems that the original intent was to use NDEBUG. > > Signed-off-by: Emil Velikov > --- > src/glsl/ir.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/ir.h

Re: [Mesa-dev] [PATCH RFC 07/11] glsl: add SSA infrastructure

2014-01-28 Thread Paul Berry
On 22 January 2014 09:16, Connor Abbott wrote: > diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp > index cb732a5..7075579 100644 > --- a/src/glsl/ir_clone.cpp > +++ b/src/glsl/ir_clone.cpp > @@ -40,7 +40,15 @@ ir_rvalue::clone(void *mem_ctx, struct hash_table *ht) > const > ir_variabl

Re: [Mesa-dev] glsl: vectorize pass probably needs to change types of scalar constants as well?

2014-01-28 Thread Matt Turner
On Mon, Jan 27, 2014 at 10:28 PM, Aras Pranckevicius wrote: > The new vectorization pass (added in 4bd6e0d7c69) properly changes types of > scalar dereferences. Doesn't it need to change types of scalar constants as > well? > > Consider this shader: > > uniform sampler2D maintex; > uniform float f

[Mesa-dev] Sandybridge ARB_gpu_shader5 gather bits

2014-01-28 Thread Chris Forbes
Hi Ian, Replying to IRC: < idr> chrisf: You know if SNB can do the enhanced textureGatherOffset modes from ARB_gpu_shader5? Sandybridge has per-slot offset support (gather4_po) but lacks: * Channel select bits in the message header * Any ability to sample from a multi-component textu

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/5] glcpp: Set extension defines after resolving the GLSL version.

2014-01-28 Thread Carl Worth
Matt Turner writes: > Unless there are objections, I think we should probably skip this > patch going to the stable branches. Thanks, Matt. I've updated my ".cherry-ignore" file so that I won't accidentally pick this one over to the stable branch. To everyone, Matt's protocol here is a good one.

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Add support for gl_ViewportIndex input

2014-01-28 Thread Ian Romanick
On 01/26/2014 02:31 PM, Chris Forbes wrote: > Ian, > > I'd thought about that a bit while building this, and struggled to > find cases where this was observable in a defined fragment shader > execution. Yeah, I've been thinking about it a bit too. > The ARB_viewport_array spec says: > > If

Re: [Mesa-dev] can we have gl_framebuffer _NumColorDrawBuffers = 1 and all the entries in the array NULL

2014-01-28 Thread Dave Airlie
> > Yes, it's legal. Drivers should handle NULL color buffer bindings and > there is a test for it: > http://cgit.freedesktop.org/piglit/commit/?id=ff2398a4e3c4805e7d1bea38f4ae6f9811b42ede > > I fixed it just recently. > Ah okay on r600g this is broken due to how we work out the CB_TARGET_MASK, th

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Dave Airlie
>> 3) In si_init_gs_rings: >> - could you please use readable decimal numbers for specifying the >> sizes? Like 1024 * 1024 * ... > [...] >> - isn't 64 MB too many for a ring buffer? > > I can write the numbers any way you like. :) But I just copied them from > the corresponding r600g patches; I do

Re: [Mesa-dev] [PATCH 1/2] mesa: Ensure that transform feedback refers to the correct program.

2014-01-28 Thread Carl Worth
Paul Berry writes: > Previous to this patch, the _mesa_{Begin,Resume}TransformFeedback > functions were using ctx->Shader.CurrentProgram[MESA_SHADER_VERTEX] I see that this commit was nominated for the stable branch when it was committed. However, it appears to depend at least on commit b22146dc

Re: [Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

2014-01-28 Thread Matt Turner
On Wed, Jan 22, 2014 at 3:54 PM, Anuj Phogat wrote: > I missed this change in commit f5cfb4a. It fixes the incorrect > rendering caused in Dolphin Emulator. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73915 > > Cc: Markus wick Capitalize his last name (and turn the Cc into a Teste

Re: [Mesa-dev] [PATCH 1/2] mesa: Ensure that transform feedback refers to the correct program.

2014-01-28 Thread Paul Berry
On 28 January 2014 13:15, Carl Worth wrote: > Paul Berry writes: > > Previous to this patch, the _mesa_{Begin,Resume}TransformFeedback > > functions were using ctx->Shader.CurrentProgram[MESA_SHADER_VERTEX] > > I see that this commit was nominated for the stable branch when it was > committed. >

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Add support for gl_ViewportIndex input

2014-01-28 Thread Roland Scheidegger
Am 28.01.2014 21:45, schrieb Ian Romanick: > On 01/26/2014 02:31 PM, Chris Forbes wrote: >> Ian, >> >> I'd thought about that a bit while building this, and struggled to >> find cases where this was observable in a defined fragment shader >> execution. > > Yeah, I've been thinking about it a bit t

Re: [Mesa-dev] [PATCH 4/7] dri2: Trust our own driver name lookup over the server's.

2014-01-28 Thread Mark Mueller
This patch could cause the i965 driver to not load if Mesa was built on a system without libudev devel present. For example on Fedora one should install systemd-devel before configuring and building Mesa drivers subsequent to this change. On Sun, Jan 26, 2014 at 4:02 PM, Keith Packard wrote: >

[Mesa-dev] [PATCH V2] mesa: Generate correct error code in glDrawBuffers()

2014-01-28 Thread Anuj Phogat
OpenGL 3.3 spec expects GL_INVALID_OPERATION: "For both the default framebuffer and framebuffer objects, the constants FRONT, BACK, LEFT, RIGHT, and FRONT AND BACK are not valid in the bufs array passed to DrawBuffers, and will result in the error INVALID OPERATION." But OpenGL 4.0 spec cha

Re: [Mesa-dev] [PATCH 1/2] mesa: Ensure that transform feedback refers to the correct program.

2014-01-28 Thread Kenneth Graunke
On 01/28/2014 01:26 PM, Paul Berry wrote: > On 28 January 2014 13:15, Carl Worth > wrote: > > Paul Berry > writes: > > Previous to this patch, the _mesa_{Begin,Resume}TransformFeedback > > functions were using ctx->Shader.

Re: [Mesa-dev] [Mesa-stable] [PATCH V2] mesa: Generate correct error code in glDrawBuffers()

2014-01-28 Thread Ian Romanick
On 01/28/2014 02:52 PM, Anuj Phogat wrote: > OpenGL 3.3 spec expects GL_INVALID_OPERATION: > "For both the default framebuffer and framebuffer objects, the > constants FRONT, BACK, LEFT, RIGHT, and FRONT AND BACK are not > valid in the bufs array passed to DrawBuffers, and will result > in t

[Mesa-dev] [PATCH] gallivm: fix opcode and function nesting

2014-01-28 Thread Zack Rusin
gallivm soa code supported only a single level of nesting for control flow opcodes (if, switch, loops...) but the d3d10 spec clearly states that those are nested within functions. To support nesting of conditionals inside functions we need to store the nesting data inside function contexts and keep

Re: [Mesa-dev] [PATCH 4/7] dri2: Trust our own driver name lookup over the server's.

2014-01-28 Thread Ian Romanick
On 01/28/2014 02:51 PM, Mark Mueller wrote: > This patch could cause the i965 driver to not load if Mesa was built on > a system without libudev devel present. For example on Fedora one should > install systemd-devel before configuring and building Mesa drivers > subsequent to this change. I don't

Re: [Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

2014-01-28 Thread Ian Romanick
On 01/22/2014 04:54 PM, Anuj Phogat wrote: > I missed this change in commit f5cfb4a. It fixes the incorrect > rendering caused in Dolphin Emulator. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73915 > > Cc: Markus wick > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj P

Re: [Mesa-dev] [PATCH 1/2] glsl: s/_NDEBUG/NDEBUG/

2014-01-28 Thread Ian Romanick
On 01/23/2014 11:03 AM, Emil Velikov wrote: > The former symbol is never defined within mesa. Based > it seems that the original intent was to use NDEBUG. That seems right to me. Reviewed-by: Ian Romanick It looks like this code was originally written by Paul, so he may have some comment. > Si

Re: [Mesa-dev] can we have gl_framebuffer _NumColorDrawBuffers = 1 and all the entries in the array NULL

2014-01-28 Thread Marek Olšák
I was hoping my kernel fix would be backported to old kernels: http://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-3.14&id=56492e0fac2dbaf7735ffd66b206a90624917789 I guess I should have fixed up the user space as well. Marek On Tue, Jan 28, 2014 at 10:06 PM, Dave Airlie wrote: >> >> Ye

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Guess nr_color_regions better in precompile

2014-01-28 Thread Kenneth Graunke
On 01/25/2014 04:07 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index 1e6c3e0..d6ebe

[Mesa-dev] [PATCH] glsl: Expand non-expr & non-swizzle scalar rvalues in vectorizing.

2014-01-28 Thread Matt Turner
--- src/glsl/opt_vectorize.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/glsl/opt_vectorize.cpp b/src/glsl/opt_vectorize.cpp index 5ad1320..8ee81f1 100644 --- a/src/glsl/opt_vectorize.cpp +++ b/src/glsl/opt_vectorize.cpp @@ -106,9 +106,10 @@ public: *

Re: [Mesa-dev] Request for support of GL_AMD_pinned_memory and GL_ARB_buffer_storage extensions

2014-01-28 Thread Marek Olšák
Yes, GL_ARB_buffer_storage is being worked on. We'll support it on all Radeon cards R300 and up. Anyway, GL_STREAM_DRAW should give you the same behavior as GL_CLIENT_STORAGE_BIT on open source Radeon drivers. Marek On Sun, Nov 24, 2013 at 1:19 PM, Tony Wasserka wrote: > Hello everyone, > I was

[Mesa-dev] [Bug 74166] New: piglit CorrectVersion1.V110 regression regression

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74166 Priority: medium Bug ID: 74166 Keywords: regression CC: cwo...@cworth.org, i...@freedesktop.org, jljus...@gmail.com, matts...@gmail.com Assignee: mesa-dev@lists.freedesk

Re: [Mesa-dev] Request for support of GL_AMD_pinned_memory and GL_ARB_buffer_storage extensions

2014-01-28 Thread Ian Romanick
On 01/28/2014 05:35 PM, Marek Olšák wrote: > Yes, GL_ARB_buffer_storage is being worked on. We'll support it on all > Radeon cards R300 and up. Are you guys working on that? Have an ETA? :) > Anyway, GL_STREAM_DRAW should give you the same behavior as > GL_CLIENT_STORAGE_BIT on open source Radeo

Re: [Mesa-dev] Request for support of GL_AMD_pinned_memory and GL_ARB_buffer_storage extensions

2014-01-28 Thread Marek Olšák
On Wed, Jan 29, 2014 at 1:42 AM, Ian Romanick wrote: > On 01/28/2014 05:35 PM, Marek Olšák wrote: >> Yes, GL_ARB_buffer_storage is being worked on. We'll support it on all >> Radeon cards R300 and up. > > Are you guys working on that? Have an ETA? :) It's done. I'm writing piglit tests at the mo

[Mesa-dev] Question about OSMesa

2014-01-28 Thread Muhammad Al-Adly
Does OSMesa support OpenGL versions higher than GL1? If it does, how can I make it work? Muhammad ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] glcpp: Add testing for #line with integer expression.

2014-01-28 Thread Carl Worth
This was enabled in the previous commit. Now add a test for "make check" to ensure it works. --- src/glsl/glcpp/tests/120-hash-line-expression.c | 8 src/glsl/glcpp/tests/120-hash-line-expression.c.expected | 9 + 2 files changed, 17 insertions(+) create mode 100644 src/

[Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-28 Thread Carl Worth
The GLSL specification explicitly allows for an in integer expression here, not just a literal integer. The specification says: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number where

Re: [Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-28 Thread Matt Turner
On Tue, Jan 28, 2014 at 5:56 PM, Carl Worth wrote: > The GLSL specification explicitly allows for an in integer expression here, > not just a literal integer. The specification says: > > #line must have, after macro substitution, one of the following forms: > > #line line >

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm >= 3.4

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 Nikoli changed: What|Removed |Added CC||nik...@gmx.us -- You are receiving this mail b

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-28 Thread Vadim Girlin
On Wed, 2014-01-29 at 07:13 +1000, Dave Airlie wrote: > >> 3) In si_init_gs_rings: > >> - could you please use readable decimal numbers for specifying the > >> sizes? Like 1024 * 1024 * ... > > [...] > >> - isn't 64 MB too many for a ring buffer? > > > > I can write the numbers any way you like. :)

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2014-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 Natanael Copa changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTOURBUG